diff --git a/app/assets/javascripts/ml/experiment_tracking/components/experiment_metadata.vue b/app/assets/javascripts/ml/experiment_tracking/components/experiment_metadata.vue index d10aeceb0d3b459aabd560b4f0dd90bdd81fe395..568c5f42540f6c44a11309dd44c4b0c180bd4e2b 100644 --- a/app/assets/javascripts/ml/experiment_tracking/components/experiment_metadata.vue +++ b/app/assets/javascripts/ml/experiment_tracking/components/experiment_metadata.vue @@ -1,7 +1,6 @@ <script> import { isEmpty } from 'lodash'; import { GlTableLite } from '@gitlab/ui'; -import * as translations from '~/ml/experiment_tracking/routes/experiments/show/translations'; import { s__ } from '~/locale'; export default { @@ -32,14 +31,17 @@ export default { tdClass: 'gl-content-center', }, ], - i18n: translations, + i18n: { + metadataLabel: s__('MlExperimentTracking|Experiment metadata'), + noMetadataMessage: s__('MlExperimentTracking|No logged experiment metadata'), + }, }; </script> <template> <section> <div class="experiment-metadata"> - <h3 class="gl-heading-3" data-testid="metadata-header">{{ $options.i18n.METADATA_LABEL }}</h3> + <h3 class="gl-heading-3" data-testid="metadata-header">{{ $options.i18n.metadataLabel }}</h3> <gl-table-lite v-if="hasMetadata" @@ -51,7 +53,7 @@ export default { <template #cell(value)="{ item: { value } }">{{ value }}</template> </gl-table-lite> <div v-else class="gl-text-subtle" data-testid="metadata-empty-state"> - {{ $options.i18n.NO_METADATA_MESSAGE }} + {{ $options.i18n.noMetadataMessage }} </div> </div> </section> diff --git a/app/assets/javascripts/ml/experiment_tracking/routes/experiments/show/ml_experiments_show.vue b/app/assets/javascripts/ml/experiment_tracking/routes/experiments/show/ml_experiments_show.vue index daff337d2482e50255e02a40285262c7d3f82126..2ab5e003ed1094b0551bba8519684a6a90b87a8e 100644 --- a/app/assets/javascripts/ml/experiment_tracking/routes/experiments/show/ml_experiments_show.vue +++ b/app/assets/javascripts/ml/experiment_tracking/routes/experiments/show/ml_experiments_show.vue @@ -16,8 +16,6 @@ import { import { s__ } from '~/locale'; import PerformanceGraph from '~/ml/experiment_tracking/components/performance_graph.vue'; -import * as translations from './translations'; - const routes = [ { path: '/', @@ -103,9 +101,11 @@ export default { deleteButtonInfo() { return { deletePath: this.experiment.path, - deleteConfirmationText: translations.DELETE_EXPERIMENT_CONFIRMATION_MESSAGE, - actionPrimaryText: translations.DELETE_EXPERIMENT_PRIMARY_ACTION_LABEL, - modalTitle: translations.DELETE_EXPERIMENT_MODAL_TITLE, + deleteConfirmationText: s__( + 'MlExperimentTracking|Deleting this experiment will also delete its runs and their associated metadata.', + ), + actionPrimaryText: s__('MlExperimentTracking|Delete experiment'), + modalTitle: s__('MLExperimentTracking|Delete experiment?'), }; }, tabIndex() { @@ -135,8 +135,8 @@ export default { }, }, i18n: { - ...translations, - PERFORMANCE_LABEL: s__('ExperimentTracking|Performance'), + downloadAsCsvLabel: s__('MlExperimentTracking|Download as CSV'), + performanceLabel: s__('ExperimentTracking|Performance'), tabs: { metadata: s__('MlExperimentTracking|Overview'), candidates: s__('MlExperimentTracking|Runs'), @@ -173,7 +173,7 @@ export default { </template> <template #right-actions> <gl-button class="gl-mr-3" @click="downloadCsv">{{ - $options.i18n.DOWNLOAD_AS_CSV_LABEL + $options.i18n.downloadAsCsvLabel }}</gl-button> <delete-button v-if="showDeleteButton" v-bind="deleteButtonInfo" /> </template> @@ -186,7 +186,7 @@ export default { <gl-badge class="gl-tab-counter-badge">{{ candidatesCount }}</gl-badge> </template> </gl-tab> - <gl-tab :title="$options.i18n.PERFORMANCE_LABEL" @click="goTo($options.ROUTE_PERFORMANCE)" /> + <gl-tab :title="$options.i18n.performanceLabel" @click="goTo($options.ROUTE_PERFORMANCE)" /> </gl-tabs> <router-view diff --git a/app/assets/javascripts/ml/experiment_tracking/routes/experiments/show/translations.js b/app/assets/javascripts/ml/experiment_tracking/routes/experiments/show/translations.js deleted file mode 100644 index a002cab57835d6d1dc7ac58681306c0feb2ae289..0000000000000000000000000000000000000000 --- a/app/assets/javascripts/ml/experiment_tracking/routes/experiments/show/translations.js +++ /dev/null @@ -1,26 +0,0 @@ -import { s__ } from '~/locale'; - -export const ARTIFACTS_LABEL = s__('MlExperimentTracking|Artifacts'); -export const DETAILS_LABEL = s__('MlExperimentTracking|Details'); -export const USER_LABEL = s__('MlExperimentTracking|Author'); -export const CI_JOB_LABEL = s__('MlExperimentTracking|CI Job'); -export const CREATED_AT_LABEL = s__('MlExperimentTracking|Created at'); -export const NAME_LABEL = s__('MlExperimentTracking|Name'); -export const NO_DATA_CONTENT = s__('MlExperimentTracking|-'); -export const FILTER_CANDIDATES_LABEL = s__('MlExperimentTracking|Filter runs'); -export const NO_CANDIDATE_NAME = s__('MlExperimentTracking|No name'); -export const NO_ARTIFACT = s__('MlExperimentTracking|No artifacts'); -export const NO_JOB = s__('MlExperimentTracking|-'); -export const CREATE_NEW_LABEL = s__('MlExperimentTracking|Create new runs'); -export const EMPTY_STATE_DESCRIPTION_LABEL = s__( - 'MlExperimentTracking|No runs logged for the query. Create new runs using the MLflow client.', -); -export const EMPTY_STATE_TITLE_LABEL = s__('MlExperimentTracking|No runs'); -export const DELETE_EXPERIMENT_CONFIRMATION_MESSAGE = s__( - 'MlExperimentTracking|Deleting this experiment will also delete its runs and their associated metadata.', -); -export const DELETE_EXPERIMENT_PRIMARY_ACTION_LABEL = s__('MlExperimentTracking|Delete experiment'); -export const DELETE_EXPERIMENT_MODAL_TITLE = s__('MLExperimentTracking|Delete experiment?'); -export const DOWNLOAD_AS_CSV_LABEL = s__('MlExperimentTracking|Download as CSV'); -export const METADATA_LABEL = s__('MlExperimentTracking|Experiment metadata'); -export const NO_METADATA_MESSAGE = s__('MlExperimentTracking|No logged experiment metadata'); diff --git a/locale/gitlab.pot b/locale/gitlab.pot index 397cbd54c07980a6aefb6344012bf2e4539967fc..c9471d21f61f2bd5fdb95b5d10869bc3883689b6 100644 --- a/locale/gitlab.pot +++ b/locale/gitlab.pot @@ -36446,27 +36446,12 @@ msgstr "" msgid "MissingSSHKeyWarningLink|You won't be able to pull or push repositories via SSH until you add an SSH key to your profile" msgstr "" -msgid "MlExperimentTracking|-" -msgstr "" - msgid "MlExperimentTracking|Are you sure you would like to delete this model?" msgstr "" -msgid "MlExperimentTracking|Artifacts" -msgstr "" - -msgid "MlExperimentTracking|Author" -msgstr "" - -msgid "MlExperimentTracking|CI Job" -msgstr "" - msgid "MlExperimentTracking|Create an experiment using MLflow" msgstr "" -msgid "MlExperimentTracking|Create new runs" -msgstr "" - msgid "MlExperimentTracking|Created" msgstr "" @@ -36500,9 +36485,6 @@ msgstr "" msgid "MlExperimentTracking|Deleting this run will delete the associated parameters, metrics, and metadata." msgstr "" -msgid "MlExperimentTracking|Details" -msgstr "" - msgid "MlExperimentTracking|Download as CSV" msgstr "" @@ -36521,9 +36503,6 @@ msgstr "" msgid "MlExperimentTracking|Failed to load experiment candidates with error: %{message}" msgstr "" -msgid "MlExperimentTracking|Filter runs" -msgstr "" - msgid "MlExperimentTracking|Get started with model experiments!" msgstr "" @@ -36545,24 +36524,12 @@ msgstr "" msgid "MlExperimentTracking|Name" msgstr "" -msgid "MlExperimentTracking|No artifacts" -msgstr "" - msgid "MlExperimentTracking|No candidates associated with this experiment" msgstr "" msgid "MlExperimentTracking|No logged experiment metadata" msgstr "" -msgid "MlExperimentTracking|No name" -msgstr "" - -msgid "MlExperimentTracking|No runs" -msgstr "" - -msgid "MlExperimentTracking|No runs logged for the query. Create new runs using the MLflow client." -msgstr "" - msgid "MlExperimentTracking|Number of runs" msgstr ""