From 8d3bb75c690a08b255387a50f1c363ee88f122d8 Mon Sep 17 00:00:00 2001 From: gdk <gdk@example.com> Date: Mon, 13 May 2024 03:13:01 +0000 Subject: [PATCH] Quarantine a flaky test The `Gitlab::ExclusiveLease#try_obtain when lease attempt within pg transaction in development/test environment raises error within main db` test has the `flakiness::1` label set, which means it has more than 1000 flakiness reports. This MR quarantines the test. This is a discussion starting point to let the responsible group know about the flakiness so that they can take action: - accept the merge request and schedule to improve the test - close the merge request in favor of another merge request to delete the test Related to https://gitlab.com/gitlab-org/gitlab/-/issues/446121. This change was generated by [gitlab-housekeeper](https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-housekeeper) using the Keeps::QuarantineFlakyTests keep. To provide feedback on your experience with `gitlab-housekeeper` please comment in <https://gitlab.com/gitlab-org/gitlab/-/issues/442003>. Changelog: other --- spec/lib/gitlab/exclusive_lease_spec.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/lib/gitlab/exclusive_lease_spec.rb b/spec/lib/gitlab/exclusive_lease_spec.rb index 33870c042cfca..74740f7dca57e 100644 --- a/spec/lib/gitlab/exclusive_lease_spec.rb +++ b/spec/lib/gitlab/exclusive_lease_spec.rb @@ -35,7 +35,7 @@ end end - it 'raises error within main db' do + it 'raises error within main db', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/446121' do expect(Gitlab::ErrorTracking).to receive(:track_and_raise_for_dev_exception).and_call_original ApplicationRecord.transaction do -- GitLab