From 89cc3877d05a8c238484e47a802972fc480efac5 Mon Sep 17 00:00:00 2001
From: Artur Fedorov <afedorov@gitlab.com>
Date: Fri, 7 Feb 2025 00:23:06 +0100
Subject: [PATCH] Fix Vue 3 failing test
Replace find methods
EE: true
---
.../components/label_filter/label_dropdown_items.vue | 1 +
scripts/frontend/quarantined_vue3_specs.txt | 1 -
.../sidebar/components/label_dropdown_items_spec.js | 10 +++++-----
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/app/assets/javascripts/search/sidebar/components/label_filter/label_dropdown_items.vue b/app/assets/javascripts/search/sidebar/components/label_filter/label_dropdown_items.vue
index f8f81eb612ed9..eee9023ba0850 100644
--- a/app/assets/javascripts/search/sidebar/components/label_filter/label_dropdown_items.vue
+++ b/app/assets/javascripts/search/sidebar/components/label_filter/label_dropdown_items.vue
@@ -23,6 +23,7 @@ export default {
:key="label.key"
:aria-label="label.title"
tabindex="-1"
+ data-testid="label-filter-menu-item"
class="label-filter-menu-item gl-px-5 gl-py-3"
>
<gl-form-checkbox
diff --git a/scripts/frontend/quarantined_vue3_specs.txt b/scripts/frontend/quarantined_vue3_specs.txt
index a6835fe613d6a..56009e5fe679f 100644
--- a/scripts/frontend/quarantined_vue3_specs.txt
+++ b/scripts/frontend/quarantined_vue3_specs.txt
@@ -239,7 +239,6 @@ spec/frontend/repository/components/table/row_spec.js
spec/frontend/repository/router_spec.js
spec/frontend/search/results/components/status_bar_spec.js
spec/frontend/search/sidebar/components/checkbox_filter_spec.js
-spec/frontend/search/sidebar/components/label_dropdown_items_spec.js
spec/frontend/search/topbar/components/app_spec.js
spec/frontend/sessions/new/components/email_verification_spec.js
spec/frontend/set_status_modal/set_status_modal_wrapper_spec.js
diff --git a/spec/frontend/search/sidebar/components/label_dropdown_items_spec.js b/spec/frontend/search/sidebar/components/label_dropdown_items_spec.js
index 9124da5cfe1cd..95c4d1faa56c6 100644
--- a/spec/frontend/search/sidebar/components/label_dropdown_items_spec.js
+++ b/spec/frontend/search/sidebar/components/label_dropdown_items_spec.js
@@ -2,7 +2,7 @@ import { GlFormCheckbox } from '@gitlab/ui';
import Vue from 'vue';
// eslint-disable-next-line no-restricted-imports
import Vuex from 'vuex';
-import { shallowMount } from '@vue/test-utils';
+import { shallowMountExtended } from 'helpers/vue_test_utils_helper';
import { PROCESS_LABELS_DATA } from 'jest/search/mock_data';
import LabelDropdownItems from '~/search/sidebar/components/label_filter/label_dropdown_items.vue';
@@ -16,18 +16,18 @@ describe('LabelDropdownItems', () => {
};
const createComponent = (Props = defaultProps) => {
- wrapper = shallowMount(LabelDropdownItems, {
+ wrapper = shallowMountExtended(LabelDropdownItems, {
propsData: {
...Props,
},
});
};
- const findAllLabelItems = () => wrapper.findAll('.label-filter-menu-item');
+ const findAllLabelItems = () => wrapper.findAllByTestId('label-filter-menu-item');
const findFirstLabelCheckbox = () => findAllLabelItems().at(0).findComponent(GlFormCheckbox);
- const findFirstLabelTitle = () => findAllLabelItems().at(0).findComponent('.label-title');
+ const findFirstLabelTitle = () => findAllLabelItems().at(0).find('.label-title');
const findFirstLabelColor = () =>
- findAllLabelItems().at(0).findComponent('[data-testid="label-color-indicator"]');
+ findAllLabelItems().at(0).find('[data-testid="label-color-indicator"]');
describe('Renders correctly', () => {
beforeEach(() => {
--
GitLab