From 88c4f65af928695ed9602391ff91cfe16df6936d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?R=C3=A9my=20Coutable?= <remy@rymai.me>
Date: Tue, 13 Apr 2021 18:10:31 +0200
Subject: [PATCH] Get rid of the 'brakeman' gem and the 'gitlab:test' task
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Signed-off-by: Rémy Coutable <remy@rymai.me>
---
Gemfile | 1 -
Gemfile.lock | 2 --
lib/tasks/brakeman.rake | 13 -------------
lib/tasks/gitlab/test.rake | 17 -----------------
4 files changed, 33 deletions(-)
delete mode 100644 lib/tasks/brakeman.rake
delete mode 100644 lib/tasks/gitlab/test.rake
diff --git a/Gemfile b/Gemfile
index ca9a34436397..8f908bb14979 100644
--- a/Gemfile
+++ b/Gemfile
@@ -342,7 +342,6 @@ group :metrics do
end
group :development do
- gem 'brakeman', '~> 4.10.0', require: false
gem 'lefthook', '~> 0.7.0', require: false
gem 'letter_opener_web', '~> 1.4.0'
diff --git a/Gemfile.lock b/Gemfile.lock
index 4ad1c2420a0f..271cc8e13daa 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -151,7 +151,6 @@ GEM
bootstrap_form (4.2.0)
actionpack (>= 5.0)
activemodel (>= 5.0)
- brakeman (4.10.1)
browser (4.2.0)
builder (3.2.4)
bullet (6.1.3)
@@ -1369,7 +1368,6 @@ DEPENDENCIES
better_errors (~> 2.9.0)
bootsnap (~> 1.4.6)
bootstrap_form (~> 4.2.0)
- brakeman (~> 4.10.0)
browser (~> 4.2)
bullet (~> 6.1.3)
bundler-audit (~> 0.7.0.1)
diff --git a/lib/tasks/brakeman.rake b/lib/tasks/brakeman.rake
deleted file mode 100644
index 44d2071751f3..000000000000
--- a/lib/tasks/brakeman.rake
+++ /dev/null
@@ -1,13 +0,0 @@
-# frozen_string_literal: true
-
-desc 'Security check via brakeman'
-task :brakeman do
- # We get 0 warnings at level 'w3' but we would like to reach 'w2'. Merge
- # requests are welcome!
- if system(*%w(brakeman --no-progress --skip-files lib/backup/repository.rb -w3 -z))
- puts 'Security check succeed'
- else
- puts 'Security check failed'
- exit 1
- end
-end
diff --git a/lib/tasks/gitlab/test.rake b/lib/tasks/gitlab/test.rake
deleted file mode 100644
index a83ba69bc75d..000000000000
--- a/lib/tasks/gitlab/test.rake
+++ /dev/null
@@ -1,17 +0,0 @@
-# frozen_string_literal: true
-
-namespace :gitlab do
- desc "GitLab | Run all tests"
- task :test do
- cmds = [
- %w(rake brakeman),
- %w(rake rubocop),
- %w(rake spec),
- %w(rake karma)
- ]
-
- cmds.each do |cmd|
- system({ 'RAILS_ENV' => 'test', 'force' => 'yes' }, *cmd) || raise("#{cmd} failed!")
- end
- end
-end
--
GitLab