From 88b7d5dd9ca6e7ef0b5cd936ab435e1f092ecc3b Mon Sep 17 00:00:00 2001
From: Miguel Rincon <mrincon@gitlab.com>
Date: Wed, 30 Aug 2023 07:36:30 +0000
Subject: [PATCH] Remove Danger warnings for changes in tests
This change removes `data-testid` warnings when tests have changed.
The warnings are meant to prevent breakage when production code changes
and the tests have not yet passed, not the other way around.
---
danger/qa_selector/Dangerfile | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/danger/qa_selector/Dangerfile b/danger/qa_selector/Dangerfile
index 57f992ec16035..c8450bffe2789 100644
--- a/danger/qa_selector/Dangerfile
+++ b/danger/qa_selector/Dangerfile
@@ -2,13 +2,15 @@
return if helper.stable_branch?
-data_testids = /testid|data-testid|find_by_testid|within_testid/
+data_testids = /testid/
deprecated_qa_selectors = /(?=qa_selector|data-qa-selector)|(?!.*\bdata-qa-)(?=class=.*qa-.*|class: .*qa-.*)/
def filter_changed_lines(files, pattern)
lines = []
files.each do |file|
+ next if file.start_with?('spec/', 'ee/spec/', 'qa/')
+
testid_changed_lines = helper.changed_lines(file).select { |line| line =~ pattern }
next unless testid_changed_lines.any?
--
GitLab