diff --git a/config/feature_flags/experiment/ci_syntax_templates_experiment_percentage.yml b/config/feature_flags/experiment/ci_syntax_templates_experiment_percentage.yml
new file mode 100644
index 0000000000000000000000000000000000000000..3ed457acce8f1b9d1f7d6284cc75d37041885184
--- /dev/null
+++ b/config/feature_flags/experiment/ci_syntax_templates_experiment_percentage.yml
@@ -0,0 +1,8 @@
+---
+name: ci_syntax_templates_experiment_percentage
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/48141
+rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/281057
+milestone: '13.8'
+type: experiment
+group: group::activation
+default_enabled: false
diff --git a/config/feature_flags/experiment/customize_homepage_experiment_percentage.yml b/config/feature_flags/experiment/customize_homepage_experiment_percentage.yml
new file mode 100644
index 0000000000000000000000000000000000000000..eff0d2785eb448eeba5c2d6270dcbdece5ca19bb
--- /dev/null
+++ b/config/feature_flags/experiment/customize_homepage_experiment_percentage.yml
@@ -0,0 +1,8 @@
+---
+name: customize_homepage_experiment_percentage
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/39348
+rollout_issue_url: https://gitlab.com/gitlab-org/growth/team-tasks/-/issues/187
+milestone: '13.4'
+type: experiment
+group: group::expansion
+default_enabled: false
diff --git a/config/feature_flags/experiment/default_to_issues_board_experiment_percentage.yml b/config/feature_flags/experiment/default_to_issues_board_experiment_percentage.yml
new file mode 100644
index 0000000000000000000000000000000000000000..d4a695502f945022eae410ee7f699970aca86dc2
--- /dev/null
+++ b/config/feature_flags/experiment/default_to_issues_board_experiment_percentage.yml
@@ -0,0 +1,8 @@
+---
+name: default_to_issues_board_experiment_percentage
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/43939
+rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/268298
+milestone: '13.5'
+type: experiment
+group: group::conversion
+default_enabled: true
diff --git a/config/feature_flags/experiment/invite_members_empty_group_version_a_experiment_percentage.yml b/config/feature_flags/experiment/invite_members_empty_group_version_a_experiment_percentage.yml
new file mode 100644
index 0000000000000000000000000000000000000000..6f8186a6888bc969de40e2f1bd47b221d4da52bc
--- /dev/null
+++ b/config/feature_flags/experiment/invite_members_empty_group_version_a_experiment_percentage.yml
@@ -0,0 +1,8 @@
+---
+name: invite_members_empty_group_version_a_experiment_percentage
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/45689
+rollout_issue_url: https://gitlab.com/gitlab-org/growth/team-tasks/-/issues/280
+milestone: '13.6'
+type: experiment
+group: group::expansion
+default_enabled: false
diff --git a/config/feature_flags/experiment/invite_members_empty_project_version_a_experiment_percentage.yml b/config/feature_flags/experiment/invite_members_empty_project_version_a_experiment_percentage.yml
new file mode 100644
index 0000000000000000000000000000000000000000..8b91ec9526ccb4aeda7723138c21b4c23fa08dd4
--- /dev/null
+++ b/config/feature_flags/experiment/invite_members_empty_project_version_a_experiment_percentage.yml
@@ -0,0 +1,8 @@
+---
+name: invite_members_empty_project_version_a_experiment_percentage
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/49588
+rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/262014
+milestone: '13.7'
+type: experiment
+group: group::expansion
+default_enabled: false
diff --git a/config/feature_flags/experiment/invite_members_new_dropdown_experiment_percentage.yml b/config/feature_flags/experiment/invite_members_new_dropdown_experiment_percentage.yml
new file mode 100644
index 0000000000000000000000000000000000000000..6fac63b381c604625d1949488b9fe0b9aab04aca
--- /dev/null
+++ b/config/feature_flags/experiment/invite_members_new_dropdown_experiment_percentage.yml
@@ -0,0 +1,8 @@
+---
+name: invite_members_new_dropdown_experiment_percentage
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/50069
+rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/268129
+milestone: '13.8'
+type: experiment
+group: group::expansion
+default_enabled: false
diff --git a/config/feature_flags/experiment/invite_members_version_a_experiment_percentage.yml b/config/feature_flags/experiment/invite_members_version_a_experiment_percentage.yml
new file mode 100644
index 0000000000000000000000000000000000000000..b284a0e2f78fcabc31b93cbc64ebfa4ed5033961
--- /dev/null
+++ b/config/feature_flags/experiment/invite_members_version_a_experiment_percentage.yml
@@ -0,0 +1,8 @@
+---
+name: invite_members_version_a_experiment_percentage
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/45689/
+rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/219239
+milestone: '13.6'
+type: experiment
+group: group::expansion
+default_enabled: false
diff --git a/config/feature_flags/experiment/invite_members_version_b_experiment_percentage.yml b/config/feature_flags/experiment/invite_members_version_b_experiment_percentage.yml
new file mode 100644
index 0000000000000000000000000000000000000000..069e740ba4408986f26f63bdf80597affb3a04a4
--- /dev/null
+++ b/config/feature_flags/experiment/invite_members_version_b_experiment_percentage.yml
@@ -0,0 +1,8 @@
+---
+name: invite_members_version_b_experiment_percentage
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/43900
+rollout_issue_url: https://gitlab.com/gitlab-org/growth/team-tasks/-/issues/214
+milestone: '13.5'
+type: experiment
+group: group::expansion
+default_enabled: false
diff --git a/config/feature_flags/experiment/jobs_empty_state_experiment_percentage.yml b/config/feature_flags/experiment/jobs_empty_state_experiment_percentage.yml
new file mode 100644
index 0000000000000000000000000000000000000000..33a15e28d445d0311690450dd40fbd00084a4cb9
--- /dev/null
+++ b/config/feature_flags/experiment/jobs_empty_state_experiment_percentage.yml
@@ -0,0 +1,8 @@
+---
+name: jobs_empty_state_experiment_percentage
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/48686
+rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/281054
+milestone: '13.7'
+type: experiment
+group: group::activation
+default_enabled: false
diff --git a/config/feature_flags/experiment/onboarding_issues_experiment_percentage.yml b/config/feature_flags/experiment/onboarding_issues_experiment_percentage.yml
new file mode 100644
index 0000000000000000000000000000000000000000..7a8f3074d96c5e367bc3eb22c7907c0a3157c764
--- /dev/null
+++ b/config/feature_flags/experiment/onboarding_issues_experiment_percentage.yml
@@ -0,0 +1,8 @@
+---
+name: onboarding_issues_experiment_percentage
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/31656/
+rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/224515
+milestone: '13.0'
+type: experiment
+group: group::conversion
+default_enabled: true
diff --git a/config/feature_flags/experiment/pipelines_empty_state_experiment_percentage.yml b/config/feature_flags/experiment/pipelines_empty_state_experiment_percentage.yml
new file mode 100644
index 0000000000000000000000000000000000000000..beb8e8a21c63e7c3835fd8d4c3dff4ca2e1e1058
--- /dev/null
+++ b/config/feature_flags/experiment/pipelines_empty_state_experiment_percentage.yml
@@ -0,0 +1,8 @@
+---
+name: pipelines_empty_state_experiment_percentage
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/47952
+rollout_issue_url: https://gitlab.com/gitlab-org/growth/team-tasks/-/issues/289
+milestone: '13.8'
+type: experiment
+group: group::activation
+default_enabled: false
diff --git a/ee/config/feature_flags/experiment/ci_notification_dot_experiment_percentage.yml b/ee/config/feature_flags/experiment/ci_notification_dot_experiment_percentage.yml
new file mode 100644
index 0000000000000000000000000000000000000000..3d6f70d2ce578fb77947253913ce5c9d583d1379
--- /dev/null
+++ b/ee/config/feature_flags/experiment/ci_notification_dot_experiment_percentage.yml
@@ -0,0 +1,8 @@
+---
+name: ci_notification_dot_experiment_percentage
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/27626
+rollout_issue_url: https://gitlab.com/gitlab-org/growth/team-tasks/-/issues/101
+milestone: '12.10'
+type: experiment
+group: group::expansion
+default_enabled: false
diff --git a/ee/config/feature_flags/experiment/contact_sales_btn_in_app_experiment_percentage.yml b/ee/config/feature_flags/experiment/contact_sales_btn_in_app_experiment_percentage.yml
new file mode 100644
index 0000000000000000000000000000000000000000..80401523f53e96f8e88e17f1f8525ca3cc7c656a
--- /dev/null
+++ b/ee/config/feature_flags/experiment/contact_sales_btn_in_app_experiment_percentage.yml
@@ -0,0 +1,8 @@
+---
+name: contact_sales_btn_in_app_experiment_percentage
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/38508
+rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/238207
+milestone: '13.3'
+type: experiment
+group: group::conversion
+default_enabled: true
diff --git a/ee/config/feature_flags/experiment/group_only_trials_experiment_percentage.yml b/ee/config/feature_flags/experiment/group_only_trials_experiment_percentage.yml
new file mode 100644
index 0000000000000000000000000000000000000000..e410eb08d01723a4e7570db20333c6843d8249da
--- /dev/null
+++ b/ee/config/feature_flags/experiment/group_only_trials_experiment_percentage.yml
@@ -0,0 +1,8 @@
+---
+name: group_only_trials_experiment_percentage
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/40564
+rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/258629
+milestone: '13.5'
+type: experiment
+group: group::conversion
+default_enabled: false
diff --git a/ee/config/feature_flags/experiment/remove_known_trial_form_fields_experiment_percentage.yml b/ee/config/feature_flags/experiment/remove_known_trial_form_fields_experiment_percentage.yml
new file mode 100644
index 0000000000000000000000000000000000000000..72b49a0423546e631d325711102f257aa8ec5f11
--- /dev/null
+++ b/ee/config/feature_flags/experiment/remove_known_trial_form_fields_experiment_percentage.yml
@@ -0,0 +1,8 @@
+---
+name: remove_known_trial_form_fields_experiment_percentage
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/45634/
+rollout_issue_url: https://gitlab.com/gitlab-org/growth/team-tasks/-/issues/281
+milestone: '13.7'
+type: experiment
+group: group::conversion
+default_enabled: false
diff --git a/ee/config/feature_flags/experiment/show_trial_status_in_sidebar_experiment_percentage.yml b/ee/config/feature_flags/experiment/show_trial_status_in_sidebar_experiment_percentage.yml
new file mode 100644
index 0000000000000000000000000000000000000000..08cc5cae6c4db13ad7b2e3b7e892cab813ff9fbe
--- /dev/null
+++ b/ee/config/feature_flags/experiment/show_trial_status_in_sidebar_experiment_percentage.yml
@@ -0,0 +1,8 @@
+---
+name: show_trial_status_in_sidebar_experiment_percentage
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/50090
+rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/281019
+milestone: '13.8'
+type: experiment
+group: group::conversion
+default_enabled: false
diff --git a/ee/config/feature_flags/experiment/trial_during_signup_experiment_percentage.yml b/ee/config/feature_flags/experiment/trial_during_signup_experiment_percentage.yml
new file mode 100644
index 0000000000000000000000000000000000000000..543b48b6626507b6561dfb7e84238109619f16f3
--- /dev/null
+++ b/ee/config/feature_flags/experiment/trial_during_signup_experiment_percentage.yml
@@ -0,0 +1,8 @@
+---
+name: trial_during_signup_experiment_percentage
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/45147/
+rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/251231
+milestone: '13.8'
+type: experiment
+group: group::conversion
+default_enabled: false
diff --git a/ee/config/feature_flags/experiment/trial_onboarding_issues_experiment_percentage.yml b/ee/config/feature_flags/experiment/trial_onboarding_issues_experiment_percentage.yml
new file mode 100644
index 0000000000000000000000000000000000000000..4d31cce9a52b66467d20b4c3ab3cb262992df4db
--- /dev/null
+++ b/ee/config/feature_flags/experiment/trial_onboarding_issues_experiment_percentage.yml
@@ -0,0 +1,8 @@
+---
+name: trial_onboarding_issues_experiment_percentage
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/48052
+rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/276703
+milestone: '13.8'
+type: experiment
+group: group::conversion
+default_enabled: false
diff --git a/ee/config/feature_flags/experiment/trial_registration_with_social_signin_experiment_percentage.yml b/ee/config/feature_flags/experiment/trial_registration_with_social_signin_experiment_percentage.yml
new file mode 100644
index 0000000000000000000000000000000000000000..e0f224ae0c45f796551a86be5570b14cf9d05ae8
--- /dev/null
+++ b/ee/config/feature_flags/experiment/trial_registration_with_social_signin_experiment_percentage.yml
@@ -0,0 +1,8 @@
+---
+name: trial_registration_with_social_signin_experiment_percentage
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/45633
+rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/262853
+milestone: '13.7'
+type: experiment
+group: group::conversion
+default_enabled: false
diff --git a/ee/config/feature_flags/experiment/trimmed_skip_trial_copy_experiment_percentage.yml b/ee/config/feature_flags/experiment/trimmed_skip_trial_copy_experiment_percentage.yml
new file mode 100644
index 0000000000000000000000000000000000000000..6e6e4555a6b5b523d06aa5ee436b02814eefe13f
--- /dev/null
+++ b/ee/config/feature_flags/experiment/trimmed_skip_trial_copy_experiment_percentage.yml
@@ -0,0 +1,8 @@
+---
+name: trimmed_skip_trial_copy_experiment_percentage
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/48110
+rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/284956
+milestone: '13.7'
+type: experiment
+group: group::conversion
+default_enabled: false
diff --git a/ee/config/feature_flags/experiment/upgrade_link_in_user_menu_a_experiment_percentage.yml b/ee/config/feature_flags/experiment/upgrade_link_in_user_menu_a_experiment_percentage.yml
new file mode 100644
index 0000000000000000000000000000000000000000..e383e7040db39ef1a0eb86d6d300557a82124dd0
--- /dev/null
+++ b/ee/config/feature_flags/experiment/upgrade_link_in_user_menu_a_experiment_percentage.yml
@@ -0,0 +1,8 @@
+---
+name: upgrade_link_in_user_menu_a_experiment_percentage
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/29428
+rollout_issue_url: https://gitlab.com/gitlab-org/growth/team-tasks/-/issues/126
+milestone: '13.0'
+type: experiment
+group: group::expansion
+default_enabled: false
diff --git a/ee/spec/requests/api/experiments_spec.rb b/ee/spec/requests/api/experiments_spec.rb
index 535fd065230a6d667827126811b8970c8516d4f3..99f99a8ae3d46e497f6f7cac289e2b0a9e3b33a0 100644
--- a/ee/spec/requests/api/experiments_spec.rb
+++ b/ee/spec/requests/api/experiments_spec.rb
@@ -20,6 +20,8 @@
end
before do
+ skip_feature_flags_yaml_validation
+ skip_default_enabled_yaml_check
stub_const('Gitlab::Experimentation::EXPERIMENTS', experiments)
Feature.enable_percentage_of_time('experiment_1_experiment_percentage', 10)
Feature.disable('experiment_2_experiment_percentage')
diff --git a/lib/feature/shared.rb b/lib/feature/shared.rb
index 17dfe26bd8276f6d096474050c43aae1cc205f9e..5ad9af6ff7ddc0e70b0f56084b82c31058cd251b 100644
--- a/lib/feature/shared.rb
+++ b/lib/feature/shared.rb
@@ -53,10 +53,12 @@ module Shared
description: 'Short lived, used specifically to run A/B/n experiments.',
optional: true,
rollout_issue: true,
- ee_only: true,
+ ee_only: false,
default_enabled: false,
example: <<-EOS
experiment(:my_experiment, project: project, actor: current_user) { ...variant code... }
+ # or
+ Gitlab::Experimentation.in_experiment_group?(:my_experiment, subject: current_user)
EOS
}
}.freeze
diff --git a/lib/gitlab/experimentation/experiment.rb b/lib/gitlab/experimentation/experiment.rb
index e594c3bedeb444fde9a1981c3024f3989d3570e5..36cd673a38fbcecdfd18a58302a14f61795215b6 100644
--- a/lib/gitlab/experimentation/experiment.rb
+++ b/lib/gitlab/experimentation/experiment.rb
@@ -3,17 +3,21 @@
module Gitlab
module Experimentation
class Experiment
+ FEATURE_FLAG_SUFFIX = "_experiment_percentage"
+
attr_reader :key, :tracking_category, :use_backwards_compatible_subject_index
def initialize(key, **params)
@key = key
@tracking_category = params[:tracking_category]
@use_backwards_compatible_subject_index = params[:use_backwards_compatible_subject_index]
-
- @experiment_percentage = Feature.get(:"#{key}_experiment_percentage").percentage_of_time_value # rubocop:disable Gitlab/AvoidFeatureGet
end
def active?
+ # TODO: just touch a feature flag
+ # Temporary change, we will change `experiment_percentage` in future to `Feature.enabled?
+ Feature.enabled?(feature_flag_name, type: :experiment, default_enabled: :yaml)
+
::Gitlab.dev_env_or_com? && experiment_percentage > 0
end
@@ -25,7 +29,17 @@ def enabled_for_index?(index)
private
- attr_reader :experiment_percentage
+ def experiment_percentage
+ feature_flag.percentage_of_time_value
+ end
+
+ def feature_flag
+ Feature.get(feature_flag_name) # rubocop:disable Gitlab/AvoidFeatureGet
+ end
+
+ def feature_flag_name
+ :"#{key}#{FEATURE_FLAG_SUFFIX}"
+ end
end
end
end
diff --git a/spec/lib/gitlab/experimentation/experiment_spec.rb b/spec/lib/gitlab/experimentation/experiment_spec.rb
index 7b1d1763010ed27b273afb6c9892f07a6ad367e8..008e669959796bfc2e495f5c7851088950ccbf3e 100644
--- a/spec/lib/gitlab/experimentation/experiment_spec.rb
+++ b/spec/lib/gitlab/experimentation/experiment_spec.rb
@@ -14,8 +14,10 @@
end
before do
- feature = double('FeatureFlag', percentage_of_time_value: percentage )
- expect(Feature).to receive(:get).with(:experiment_key_experiment_percentage).and_return(feature)
+ skip_feature_flags_yaml_validation
+ skip_default_enabled_yaml_check
+ feature = double('FeatureFlag', percentage_of_time_value: percentage, enabled?: true)
+ allow(Feature).to receive(:get).with(:experiment_key_experiment_percentage).and_return(feature)
end
subject(:experiment) { described_class.new(:experiment_key, **params) }
diff --git a/spec/lib/gitlab/experimentation_spec.rb b/spec/lib/gitlab/experimentation_spec.rb
index a68c050d8296ebeba638a08a8d224c9aee6e8f39..b503960b8c78de0e1bf9fa4b1f368456ac702f43 100644
--- a/spec/lib/gitlab/experimentation_spec.rb
+++ b/spec/lib/gitlab/experimentation_spec.rb
@@ -38,6 +38,8 @@
}
})
+ skip_feature_flags_yaml_validation
+ skip_default_enabled_yaml_check
Feature.enable_percentage_of_time(:backwards_compatible_test_experiment_experiment_percentage, enabled_percentage)
Feature.enable_percentage_of_time(:test_experiment_experiment_percentage, enabled_percentage)
allow(Gitlab).to receive(:com?).and_return(true)
diff --git a/spec/support/helpers/stub_experiments.rb b/spec/support/helpers/stub_experiments.rb
index 247692d83ee3b07e087527406a6e03aac30fcce1..408d16a7c08d780b41db14b8531fe90a5541823c 100644
--- a/spec/support/helpers/stub_experiments.rb
+++ b/spec/support/helpers/stub_experiments.rb
@@ -11,6 +11,7 @@ def stub_experiment(experiments)
allow(Gitlab::Experimentation).to receive(:active?).and_call_original
experiments.each do |experiment_key, enabled|
+ Feature.persist_used!("#{experiment_key}#{feature_flag_suffix}")
allow(Gitlab::Experimentation).to receive(:active?).with(experiment_key) { enabled }
end
end
@@ -25,7 +26,14 @@ def stub_experiment_for_subject(experiments)
allow(Gitlab::Experimentation).to receive(:in_experiment_group?).and_call_original
experiments.each do |experiment_key, enabled|
+ Feature.persist_used!("#{experiment_key}#{feature_flag_suffix}")
allow(Gitlab::Experimentation).to receive(:in_experiment_group?).with(experiment_key, anything) { enabled }
end
end
+
+ private
+
+ def feature_flag_suffix
+ Gitlab::Experimentation::Experiment::FEATURE_FLAG_SUFFIX
+ end
end
diff --git a/spec/support/helpers/stub_feature_flags.rb b/spec/support/helpers/stub_feature_flags.rb
index 7f30a2a70cdf56fdc90cf3ef6c183b55828345a6..77f31169ecb9e70f29b002b9fd82e635de541806 100644
--- a/spec/support/helpers/stub_feature_flags.rb
+++ b/spec/support/helpers/stub_feature_flags.rb
@@ -66,4 +66,8 @@ def stub_feature_flag_gate(object)
def skip_feature_flags_yaml_validation
allow(Feature::Definition).to receive(:valid_usage!)
end
+
+ def skip_default_enabled_yaml_check
+ allow(Feature::Definition).to receive(:default_enabled?).and_return(false)
+ end
end