diff --git a/app/assets/javascripts/super_sidebar/components/help_center.vue b/app/assets/javascripts/super_sidebar/components/help_center.vue index 4cebc247454a6a1c7b8313b147884bdab9f03bf8..415da9b79f108ca587d56c9fd6d162592970330f 100644 --- a/app/assets/javascripts/super_sidebar/components/help_center.vue +++ b/app/assets/javascripts/super_sidebar/components/help_center.vue @@ -239,7 +239,7 @@ export default { <span class="gl-flex gl-flex-col gl-leading-24"> <span class="gl-text-sm gl-font-bold"> {{ item.text }} - <gl-emoji data-name="rocket" /> + <gl-emoji data-name="rocket" aria-hidden="true" /> </span> <span> <span class="gl-mr-2">{{ item.version }}</span> @@ -258,8 +258,10 @@ export default { <template #list-item="{ item }"> <span class="-gl-my-1 gl-flex gl-items-center gl-justify-between"> {{ item.text }} - <gl-badge v-if="item.count" pill variant="info">{{ item.count }}</gl-badge> - <kbd v-else-if="item.shortcut" class="flat">?</kbd> + <gl-badge v-if="item.count" pill variant="info" aria-hidden="true">{{ + item.count + }}</gl-badge> + <kbd v-else-if="item.shortcut" aria-hidden="true" class="flat">?</kbd> </span> </template> </gl-disclosure-dropdown-group> diff --git a/spec/frontend/super_sidebar/components/help_center_spec.js b/spec/frontend/super_sidebar/components/help_center_spec.js index 65c2e5b73d6fbae4c882fd7c4e0c55c002af9459..d607ca9d3fa5de3c356714ebce0b4a7391820de8 100644 --- a/spec/frontend/super_sidebar/components/help_center_spec.js +++ b/spec/frontend/super_sidebar/components/help_center_spec.js @@ -181,7 +181,7 @@ describe('HelpCenter component', () => { let button; beforeEach(() => { - button = findButton('Keyboard shortcuts ?'); + button = findButton('Keyboard shortcuts'); }); it('shows the keyboard shortcuts modal', () => { @@ -191,7 +191,7 @@ describe('HelpCenter component', () => { }); it('should have Snowplow tracking attributes', () => { - expect(findButton('Keyboard shortcuts ?').dataset).toEqual( + expect(findButton('Keyboard shortcuts').dataset).toEqual( expect.objectContaining({ trackAction: 'click_button', trackLabel: 'keyboard_shortcuts_help', @@ -205,7 +205,7 @@ describe('HelpCenter component', () => { beforeEach(() => { createWrapper({ ...sidebarData, show_version_check: true }); - findButton("What's new 5").click(); + findButton("What's new").click(); }); it('shows the "What\'s new" slideout', () => { @@ -221,7 +221,7 @@ describe('HelpCenter component', () => { it('should have Snowplow tracking attributes', () => { createWrapper({ ...sidebarData, display_whats_new: true }); - expect(findButton("What's new 5").dataset).toEqual( + expect(findButton("What's new").dataset).toEqual( expect.objectContaining({ trackAction: 'click_button', trackLabel: 'whats_new', @@ -255,7 +255,7 @@ describe('HelpCenter component', () => { describe('when "What\'s new" drawer got opened', () => { beforeEach(() => { - findButton("What's new 5").click(); + findButton("What's new").click(); }); it('does not render notification dot', () => {