diff --git a/spec/lib/api/helpers/related_resources_helpers_spec.rb b/spec/lib/api/helpers/related_resources_helpers_spec.rb
index fb26cc417e85852b71e3cbe3cb241f08cb26a984..eeeb22abd10ce953b2372193f19b75179954c1e8 100644
--- a/spec/lib/api/helpers/related_resources_helpers_spec.rb
+++ b/spec/lib/api/helpers/related_resources_helpers_spec.rb
@@ -43,6 +43,7 @@
describe '#expose_url' do
let(:path) { '/api/v4/awesome_endpoint' }
+
subject(:url) { helpers.expose_url(path) }
def stub_default_url_options(protocol: 'http', host: 'example.com', port: nil, script_name: '')
diff --git a/spec/lib/backup/repository_spec.rb b/spec/lib/backup/repository_spec.rb
index 82ae535e100055302a9a3bfe5ac078829a0a7e3f..32e718d4b3b476938feb43f8dc5f0d59ef6f6f60 100644
--- a/spec/lib/backup/repository_spec.rb
+++ b/spec/lib/backup/repository_spec.rb
@@ -5,6 +5,7 @@
describe Backup::Repository do
let(:progress) { StringIO.new }
let!(:project) { create(:project, :wiki_repo) }
+
subject { described_class.new(progress) }
before do
diff --git a/spec/lib/backup/uploads_spec.rb b/spec/lib/backup/uploads_spec.rb
index 55b69f29812cb431808ac77df7bc010f20ee3217..1f49baeff69da0d76d7f92afc11b478697af02d8 100644
--- a/spec/lib/backup/uploads_spec.rb
+++ b/spec/lib/backup/uploads_spec.rb
@@ -4,6 +4,7 @@
describe Backup::Uploads do
let(:progress) { StringIO.new }
+
subject(:backup) { described_class.new(progress) }
describe '#initialize' do
diff --git a/spec/lib/banzai/filter/relative_link_filter_spec.rb b/spec/lib/banzai/filter/relative_link_filter_spec.rb
index 371c7a2347c2213d62deeb354dd3054b2f900cf3..5f26a386fe11705af4df2c5cd1bedd0e602493f9 100644
--- a/spec/lib/banzai/filter/relative_link_filter_spec.rb
+++ b/spec/lib/banzai/filter/relative_link_filter_spec.rb
@@ -96,21 +96,25 @@ def allow_gitaly_n_plus_1
context 'with a project_wiki' do
let(:project_wiki) { double('ProjectWiki') }
+
include_examples :preserve_unchanged
end
context 'without a repository' do
let(:project) { create(:project) }
+
include_examples :preserve_unchanged
end
context 'with an empty repository' do
let(:project) { create(:project_empty_repo) }
+
include_examples :preserve_unchanged
end
context 'without project repository access' do
let(:project) { create(:project, :repository, repository_access_level: ProjectFeature::PRIVATE) }
+
include_examples :preserve_unchanged
end
@@ -269,6 +273,7 @@ def allow_gitaly_n_plus_1
context 'when requested path is a file in the repo' do
let(:requested_path) { 'doc/api/README.md' }
+
it 'rebuilds URL relative to the containing directory' do
doc = filter(link('users.md'))
expect(doc.at_css('a')['href']).to eq "/#{project_path}/blob/#{Addressable::URI.escape(ref)}/doc/api/users.md"
@@ -277,6 +282,7 @@ def allow_gitaly_n_plus_1
context 'when requested path is a directory in the repo' do
let(:requested_path) { 'doc/api/' }
+
it 'rebuilds URL relative to the directory' do
doc = filter(link('users.md'))
expect(doc.at_css('a')['href']).to eq "/#{project_path}/blob/#{Addressable::URI.escape(ref)}/doc/api/users.md"
@@ -287,6 +293,7 @@ def allow_gitaly_n_plus_1
let(:ref) { '100%branch' }
let(:commit) { project.commit('1b12f15a11fc6e62177bef08f47bc7b5ce50b141') }
let(:requested_path) { 'foo/bar/' }
+
it 'correctly escapes the ref' do
doc = filter(link('.gitkeep'))
expect(doc.at_css('a')['href']).to eq "/#{project_path}/blob/#{Addressable::URI.escape(ref)}/foo/bar/.gitkeep"
@@ -316,6 +323,7 @@ def allow_gitaly_n_plus_1
let(:ref) { 'master' }
let(:commit) { project.commit('38008cb17ce1466d8fec2dfa6f6ab8dcfe5cf49e') }
let(:requested_path) { 'with space/' }
+
it 'does not escape the space twice' do
doc = filter(link('README.md'))
expect(doc.at_css('a')['href']).to eq "/#{project_path}/blob/#{Addressable::URI.escape(ref)}/with%20space/README.md"
@@ -328,7 +336,9 @@ def allow_gitaly_n_plus_1
end
context 'with a valid ref' do
- let(:commit) { nil } # force filter to use ref instead of commit
+ let(:commit) { nil }
+
+ # force filter to use ref instead of commit
include_examples :valid_repository
end
diff --git a/spec/lib/banzai/reference_parser/issue_parser_spec.rb b/spec/lib/banzai/reference_parser/issue_parser_spec.rb
index a925d294b1ba74ac2c979e58f27425ed49b11c91..ac321aca5e91d21a5684a104ccba72421d728f6c 100644
--- a/spec/lib/banzai/reference_parser/issue_parser_spec.rb
+++ b/spec/lib/banzai/reference_parser/issue_parser_spec.rb
@@ -9,6 +9,7 @@
let(:user) { create(:user) }
let(:issue) { create(:issue, project: project) }
let(:link) { empty_html_link }
+
subject { described_class.new(Banzai::RenderContext.new(project, user)) }
describe '#nodes_visible_to_user' do
diff --git a/spec/lib/banzai/reference_parser/snippet_parser_spec.rb b/spec/lib/banzai/reference_parser/snippet_parser_spec.rb
index 05dc1cb4d2d062513a870237f897c79285f31f89..6581ed0d7c32b68157f5b2d348ad17f0d164ef8a 100644
--- a/spec/lib/banzai/reference_parser/snippet_parser_spec.rb
+++ b/spec/lib/banzai/reference_parser/snippet_parser_spec.rb
@@ -200,6 +200,7 @@ def visible_references(snippet_visibility, user = nil)
describe '#referenced_by' do
let(:snippet) { create(:snippet, project: project) }
+
describe 'when the link has a data-snippet attribute' do
context 'using an existing snippet ID' do
it 'returns an Array of snippets' do
diff --git a/spec/lib/banzai/reference_redactor_spec.rb b/spec/lib/banzai/reference_redactor_spec.rb
index 9e1a389d2db7503aa7956de5da1a6baeec7dd213..0dec6395fb336bb7c0f7bc8aea93729716c541c3 100644
--- a/spec/lib/banzai/reference_redactor_spec.rb
+++ b/spec/lib/banzai/reference_redactor_spec.rb
@@ -36,6 +36,7 @@
context 'when data-original attribute provided' do
let(:original_content) { '<code>foo</code>' }
+
it 'replaces redacted reference with original content' do
doc = Nokogiri::HTML.fragment("<a class='gfm' href='https://www.gitlab.com' data-reference-type='issue' data-original='#{original_content}'>bar</a>")
redactor.redact([doc])
diff --git a/spec/lib/constraints/project_url_constrainer_spec.rb b/spec/lib/constraints/project_url_constrainer_spec.rb
index ac3221ecab70b91a46d89682d8f2cfafbde07268..963e1d5b8e08058d3ed5305717407c2806e1e785 100644
--- a/spec/lib/constraints/project_url_constrainer_spec.rb
+++ b/spec/lib/constraints/project_url_constrainer_spec.rb
@@ -37,11 +37,13 @@
context 'and is a GET request' do
let(:request) { build_request(namespace.full_path, old_project_path) }
+
it { expect(subject.matches?(request)).to be_truthy }
end
context 'and is NOT a GET request' do
let(:request) { build_request(namespace.full_path, old_project_path, 'POST') }
+
it { expect(subject.matches?(request)).to be_falsey }
end
end
diff --git a/spec/lib/constraints/user_url_constrainer_spec.rb b/spec/lib/constraints/user_url_constrainer_spec.rb
index 15ef930420ce314fae789073d095e6697d0cd079..4f665def3bff06e35c9c9077c7ee689702ab2b21 100644
--- a/spec/lib/constraints/user_url_constrainer_spec.rb
+++ b/spec/lib/constraints/user_url_constrainer_spec.rb
@@ -24,11 +24,13 @@
context 'and is a GET request' do
let(:request) { build_request(redirect_route.path) }
+
it { expect(subject.matches?(request)).to be_truthy }
end
context 'and is NOT a GET request' do
let(:request) { build_request(redirect_route.path, 'POST') }
+
it { expect(subject.matches?(request)).to be_falsey }
end
end
diff --git a/spec/lib/gitlab/asciidoc_spec.rb b/spec/lib/gitlab/asciidoc_spec.rb
index 415a6e623743ce3e9a3cfb05c67ffcc5611ab301..38ec04ebe81a0621d5977d33fe2b565cf354ed43 100644
--- a/spec/lib/gitlab/asciidoc_spec.rb
+++ b/spec/lib/gitlab/asciidoc_spec.rb
@@ -451,6 +451,7 @@ module Gitlab
context 'with path to a binary file' do
let(:blob) { fake_blob(path: 'dk.png', binary: true) }
+
include_examples :invalid_include
end
@@ -500,6 +501,7 @@ module Gitlab
context 'without a commit (only ref)' do
let(:commit) { nil }
+
include_examples :valid_include
end
end
@@ -511,6 +513,7 @@ module Gitlab
context 'without a commit (only ref)' do
let(:commit) { nil }
+
include_examples :valid_include
end
end
diff --git a/spec/lib/gitlab/auth/o_auth/user_spec.rb b/spec/lib/gitlab/auth/o_auth/user_spec.rb
index 3b490646b6e14f9be6153c0695ce6a94788ab0b5..c621c0aa9353ed8bb9eba90274a5d412772a16e7 100644
--- a/spec/lib/gitlab/auth/o_auth/user_spec.rb
+++ b/spec/lib/gitlab/auth/o_auth/user_spec.rb
@@ -253,6 +253,7 @@ def stub_omniauth_config(messages)
context "and LDAP user has an account already" do
let!(:existing_user) { create(:omniauth_user, name: 'John Doe', email: 'john@example.com', extern_uid: dn, provider: 'ldapmain', username: 'john') }
+
it "adds the omniauth identity to the LDAP account" do
allow(Gitlab::Auth::LDAP::Person).to receive(:find_by_uid).and_return(ldap_user)
diff --git a/spec/lib/gitlab/auth_spec.rb b/spec/lib/gitlab/auth_spec.rb
index 0a54a72abad092ee1b7be9db648b1ba3ba0cc31c..311cbd4dd7e22de76c48417a811577649d2e6ced 100644
--- a/spec/lib/gitlab/auth_spec.rb
+++ b/spec/lib/gitlab/auth_spec.rb
@@ -4,6 +4,7 @@
describe Gitlab::Auth, :use_clean_rails_memory_store_caching do
let(:gl_auth) { described_class }
+
set(:project) { create(:project) }
describe 'constants' do
diff --git a/spec/lib/gitlab/background_migration/backfill_project_fullpath_in_repo_config_spec.rb b/spec/lib/gitlab/background_migration/backfill_project_fullpath_in_repo_config_spec.rb
index c66d7cd614863462c8681f03f36c4ebca5808e03..5cad479ff05b3ae6779a8d0b99671789e7dc9202 100644
--- a/spec/lib/gitlab/background_migration/backfill_project_fullpath_in_repo_config_spec.rb
+++ b/spec/lib/gitlab/background_migration/backfill_project_fullpath_in_repo_config_spec.rb
@@ -10,6 +10,7 @@
describe described_class::Storage::HashedProject do
let(:project) { double(id: 555) }
+
subject(:project_storage) { described_class.new(project) }
it 'has the correct disk_path' do
@@ -19,6 +20,7 @@
describe described_class::Storage::LegacyProject do
let(:project) { double(full_path: 'this/is/the/full/path') }
+
subject(:project_storage) { described_class.new(project) }
it 'has the correct disk_path' do
@@ -28,6 +30,7 @@
describe described_class::Project do
let(:project_record) { projects.create!(namespace_id: subgroup.id, name: 'baz', path: 'baz') }
+
subject(:project) { described_class.find(project_record.id) }
describe '#full_path' do
diff --git a/spec/lib/gitlab/branch_push_merge_commit_analyzer_spec.rb b/spec/lib/gitlab/branch_push_merge_commit_analyzer_spec.rb
index 1e9695429754931fff4e723b686be98edb3a2791..a27f14cd62140aca564e2532db017c0983b34989 100644
--- a/spec/lib/gitlab/branch_push_merge_commit_analyzer_spec.rb
+++ b/spec/lib/gitlab/branch_push_merge_commit_analyzer_spec.rb
@@ -49,6 +49,7 @@
context 'when relevant_commit_ids is provided' do
let(:relevant_commit_id) { '8a994512e8c8f0dfcf22bb16df6e876be7a61036' }
+
subject { described_class.new(commits, relevant_commit_ids: [relevant_commit_id]) }
it 'returns correct merge commit' do
diff --git a/spec/lib/gitlab/ci/build/artifacts/metadata/entry_spec.rb b/spec/lib/gitlab/ci/build/artifacts/metadata/entry_spec.rb
index 73c3cad88bcc48cdaebe762415bf090628bad670..243c6f063247ed4fbaf25c5c07051945ad423997 100644
--- a/spec/lib/gitlab/ci/build/artifacts/metadata/entry_spec.rb
+++ b/spec/lib/gitlab/ci/build/artifacts/metadata/entry_spec.rb
@@ -152,6 +152,7 @@ def entry(path)
describe '#blob' do
let(:file_entry) { |example| path(example) }
+
subject { file_entry.blob }
it 'returns a blob representing the entry data' do
diff --git a/spec/lib/gitlab/ci/status/pipeline/blocked_spec.rb b/spec/lib/gitlab/ci/status/pipeline/blocked_spec.rb
index 876ba712d05c55cd5b2bc402c87ed1f2675989a5..664915ba55292df33486ef06a68b9675007d18b7 100644
--- a/spec/lib/gitlab/ci/status/pipeline/blocked_spec.rb
+++ b/spec/lib/gitlab/ci/status/pipeline/blocked_spec.rb
@@ -23,6 +23,7 @@
describe '.matches?' do
let(:user) { double('user') }
+
subject { described_class.matches?(pipeline, user) }
context 'when pipeline is blocked' do
diff --git a/spec/lib/gitlab/ci/status/pipeline/delayed_spec.rb b/spec/lib/gitlab/ci/status/pipeline/delayed_spec.rb
index 90b797965b3fc825715b41168821d8c54ad64aa2..aba403de7129bf2433eaba7c268275b0ad4929ca 100644
--- a/spec/lib/gitlab/ci/status/pipeline/delayed_spec.rb
+++ b/spec/lib/gitlab/ci/status/pipeline/delayed_spec.rb
@@ -23,6 +23,7 @@
describe '.matches?' do
let(:user) { double('user') }
+
subject { described_class.matches?(pipeline, user) }
context 'when pipeline is scheduled' do
diff --git a/spec/lib/gitlab/ci/trace/section_parser_spec.rb b/spec/lib/gitlab/ci/trace/section_parser_spec.rb
index 5e2efe083bedaf0d0272c3b1a695153786e9181e..6e8504a158475416b208c21bb73b164316b73946 100644
--- a/spec/lib/gitlab/ci/trace/section_parser_spec.rb
+++ b/spec/lib/gitlab/ci/trace/section_parser_spec.rb
@@ -21,6 +21,7 @@ def section(name, start, duration, text)
end
let(:lines) { build_lines('') }
+
subject { described_class.new(lines) }
describe '#sections' do
diff --git a/spec/lib/gitlab/ci/yaml_processor_spec.rb b/spec/lib/gitlab/ci/yaml_processor_spec.rb
index ed2d97b1a38237731c4cde722548c032ddefd850..e2a0da1a62e2a71ea291e9c3e475332ea5f1b7d7 100644
--- a/spec/lib/gitlab/ci/yaml_processor_spec.rb
+++ b/spec/lib/gitlab/ci/yaml_processor_spec.rb
@@ -1708,6 +1708,7 @@ module Ci
describe "Hidden jobs" do
let(:config_processor) { Gitlab::Ci::YamlProcessor.new(config) }
+
subject { config_processor.stage_builds_attributes("test") }
shared_examples 'hidden_job_handling' do
@@ -1752,6 +1753,7 @@ module Ci
describe "YAML Alias/Anchor" do
let(:config_processor) { Gitlab::Ci::YamlProcessor.new(config) }
+
subject { config_processor.stage_builds_attributes("build") }
shared_examples 'job_templates_handling' do
diff --git a/spec/lib/gitlab/cleanup/orphan_job_artifact_files_spec.rb b/spec/lib/gitlab/cleanup/orphan_job_artifact_files_spec.rb
index fc9792e16d753008ecdea71ed831b795fd25a48c..75ef75fccc98c6f2bdd6ef2fb142d9dbd4d60157 100644
--- a/spec/lib/gitlab/cleanup/orphan_job_artifact_files_spec.rb
+++ b/spec/lib/gitlab/cleanup/orphan_job_artifact_files_spec.rb
@@ -4,6 +4,7 @@
describe Gitlab::Cleanup::OrphanJobArtifactFiles do
let(:null_logger) { Logger.new('/dev/null') }
+
subject(:cleanup) { described_class.new(logger: null_logger) }
before do
diff --git a/spec/lib/gitlab/database/rename_reserved_paths_migration/v1/rename_base_spec.rb b/spec/lib/gitlab/database/rename_reserved_paths_migration/v1/rename_base_spec.rb
index 612c418e8bba360a72c7ffec90e0102cf12382d1..7b8437e48745167fe98668633bd7fcc55dfb92ec 100644
--- a/spec/lib/gitlab/database/rename_reserved_paths_migration/v1/rename_base_spec.rb
+++ b/spec/lib/gitlab/database/rename_reserved_paths_migration/v1/rename_base_spec.rb
@@ -83,6 +83,7 @@ def migration_project(project)
describe '#rename_path_for_routable' do
context 'for namespaces' do
let(:namespace) { create(:namespace, path: 'the-path') }
+
it "renames namespaces called the-path" do
subject.rename_path_for_routable(migration_namespace(namespace))
@@ -159,6 +160,7 @@ def migration_project(project)
describe '#perform_rename' do
describe 'for namespaces' do
let(:namespace) { create(:namespace, path: 'the-path') }
+
it 'renames the path' do
subject.perform_rename(migration_namespace(namespace), 'the-path', 'renamed')
diff --git a/spec/lib/gitlab/database/rename_reserved_paths_migration/v1/rename_namespaces_spec.rb b/spec/lib/gitlab/database/rename_reserved_paths_migration/v1/rename_namespaces_spec.rb
index 8c4d7e323fa962e49660f3226c1401459609a820..46fc48ab3fc072a0c4565524d260a7e09a5a78b9 100644
--- a/spec/lib/gitlab/database/rename_reserved_paths_migration/v1/rename_namespaces_spec.rb
+++ b/spec/lib/gitlab/database/rename_reserved_paths_migration/v1/rename_namespaces_spec.rb
@@ -95,6 +95,7 @@ def migration_namespace(namespace)
describe '#move_repositories' do
let(:namespace) { create(:group, name: 'hello-group') }
+
it 'moves a project for a namespace' do
create(:project, :repository, :legacy_storage, namespace: namespace, path: 'hello-project')
expected_path = File.join(TestEnv.repos_path, 'bye-group', 'hello-project.git')
diff --git a/spec/lib/gitlab/diff/diff_refs_spec.rb b/spec/lib/gitlab/diff/diff_refs_spec.rb
index e12b46c15adabcfe21ced3e3ba10c968705b71f7..33a7cf5ae12e6c056f30933c3d76ba25c8ff52ea 100644
--- a/spec/lib/gitlab/diff/diff_refs_spec.rb
+++ b/spec/lib/gitlab/diff/diff_refs_spec.rb
@@ -7,6 +7,7 @@
describe '#==' do
let(:commit) { project.commit('1a0b36b3cdad1d2ee32457c102a8c0b7056fa863') }
+
subject { commit.diff_refs }
context 'when shas are missing' do
@@ -63,6 +64,7 @@
describe '#compare_in' do
context 'with diff refs for the initial commit' do
let(:commit) { project.commit('1a0b36b3cdad1d2ee32457c102a8c0b7056fa863') }
+
subject { commit.diff_refs }
it 'returns an appropriate comparison' do
@@ -74,6 +76,7 @@
context 'with diff refs for a commit' do
let(:commit) { project.commit('6f6d7e7ed97bb5f0054f2b1df789b39ca89b6ff9') }
+
subject { commit.diff_refs }
it 'returns an appropriate comparison' do
diff --git a/spec/lib/gitlab/diff/line_mapper_spec.rb b/spec/lib/gitlab/diff/line_mapper_spec.rb
index 1739bcd14a888ffadb46935f98fec353393dd6ba..6a86f885c3b57efbcce092b5176f35841b402936 100644
--- a/spec/lib/gitlab/diff/line_mapper_spec.rb
+++ b/spec/lib/gitlab/diff/line_mapper_spec.rb
@@ -11,6 +11,7 @@
let(:diffs) { commit.raw_diffs }
let(:diff) { diffs.first }
let(:diff_file) { Gitlab::Diff::File.new(diff, diff_refs: commit.diff_refs, repository: repository) }
+
subject { described_class.new(diff_file) }
describe '#old_to_new' do
diff --git a/spec/lib/gitlab/diff/parallel_diff_spec.rb b/spec/lib/gitlab/diff/parallel_diff_spec.rb
index 7540da7108676dd147fce5d644d11517e5f30b60..d275bf2c223b5030e1c27f631228bb95062bbe92 100644
--- a/spec/lib/gitlab/diff/parallel_diff_spec.rb
+++ b/spec/lib/gitlab/diff/parallel_diff_spec.rb
@@ -11,6 +11,7 @@
let(:diffs) { commit.raw_diffs }
let(:diff) { diffs.first }
let(:diff_file) { Gitlab::Diff::File.new(diff, diff_refs: commit.diff_refs, repository: repository) }
+
subject { described_class.new(diff_file) }
describe '#parallelize' do
diff --git a/spec/lib/gitlab/email/handler/create_merge_request_handler_spec.rb b/spec/lib/gitlab/email/handler/create_merge_request_handler_spec.rb
index 50e425f2bc1023f6ceb39ffe4166a866bed925e8..9f5413f96075e17812ce195e22c50c470ea408dc 100644
--- a/spec/lib/gitlab/email/handler/create_merge_request_handler_spec.rb
+++ b/spec/lib/gitlab/email/handler/create_merge_request_handler_spec.rb
@@ -191,6 +191,7 @@
describe '#patch_attachments' do
let(:email_raw) { email_fixture('emails/merge_request_multiple_patches.eml') }
let(:mail) { Mail::Message.new(email_raw) }
+
subject(:handler) { described_class.new(mail, mail_key) }
it 'orders attachments ending in `.patch` by name' do
diff --git a/spec/lib/gitlab/external_authorization/client_spec.rb b/spec/lib/gitlab/external_authorization/client_spec.rb
index a17d933e3bb90261d2dd06c338c09309c7e50d41..e28a155a47fa10ebaf265fb0efdde9bdb6f27459 100644
--- a/spec/lib/gitlab/external_authorization/client_spec.rb
+++ b/spec/lib/gitlab/external_authorization/client_spec.rb
@@ -5,6 +5,7 @@
describe Gitlab::ExternalAuthorization::Client do
let(:user) { build(:user, email: 'dummy_user@example.com') }
let(:dummy_url) { 'https://dummy.net/' }
+
subject(:client) { described_class.new(user, 'dummy_label') }
before do
diff --git a/spec/lib/gitlab/external_authorization/response_spec.rb b/spec/lib/gitlab/external_authorization/response_spec.rb
index e1f6e9ac1fa5f6762e2f2b232077709a12ef0857..5ce3325ef771a9b178c018fde10869e1364925e5 100644
--- a/spec/lib/gitlab/external_authorization/response_spec.rb
+++ b/spec/lib/gitlab/external_authorization/response_spec.rb
@@ -4,6 +4,7 @@
describe Gitlab::ExternalAuthorization::Response do
let(:excon_response) { double }
+
subject(:response) { described_class.new(excon_response) }
describe '#valid?' do
diff --git a/spec/lib/gitlab/file_finder_spec.rb b/spec/lib/gitlab/file_finder_spec.rb
index 7ea9d43c9f776a39293a5441c4cc61205c0ce5fc..6cc5141a6fe49ff1ee8061cd1a3c93468f29f72c 100644
--- a/spec/lib/gitlab/file_finder_spec.rb
+++ b/spec/lib/gitlab/file_finder_spec.rb
@@ -5,6 +5,7 @@
describe Gitlab::FileFinder do
describe '#find' do
let(:project) { create(:project, :public, :repository) }
+
subject { described_class.new(project, project.default_branch) }
it_behaves_like 'file finder' do
diff --git a/spec/lib/gitlab/gfm/reference_rewriter_spec.rb b/spec/lib/gitlab/gfm/reference_rewriter_spec.rb
index 026fd1fedde2e2137e8dcc170141976a32a7a9eb..d16f34af325212bd19c64892f678ef1a0f49f873 100644
--- a/spec/lib/gitlab/gfm/reference_rewriter_spec.rb
+++ b/spec/lib/gitlab/gfm/reference_rewriter_spec.rb
@@ -54,11 +54,13 @@
context 'code' do
let(:text) { "#1, but not `[#1]`" }
+
it { is_expected.to eq "#{issue_first.to_reference(new_project)}, but not `[#1]`" }
end
context 'code reverse' do
let(:text) { "not `#1`, but #1" }
+
it { is_expected.to eq "not `#1`, but #{issue_first.to_reference(new_project)}" }
end
@@ -74,11 +76,13 @@
context 'label referenced by id' do
let(:text) { '#1 and ~123' }
+
it { is_expected.to eq %Q{#{old_project_ref}#1 and #{old_project_ref}~123} }
end
context 'label referenced by text' do
let(:text) { '#1 and ~"test"' }
+
it { is_expected.to eq %Q{#{old_project_ref}#1 and #{old_project_ref}~123} }
end
end
@@ -93,11 +97,13 @@
context 'label referenced by id' do
let(:text) { '#1 and ~321' }
+
it { is_expected.to eq %Q{#{old_project_ref}#1 and #{old_project_ref}~321} }
end
context 'label referenced by text' do
let(:text) { '#1 and ~"group label"' }
+
it { is_expected.to eq %Q{#{old_project_ref}#1 and #{old_project_ref}~321} }
end
end
diff --git a/spec/lib/gitlab/git/commit_spec.rb b/spec/lib/gitlab/git/commit_spec.rb
index 63f443e19d233764d0133c26472599cec3b44331..7ec655eb113f45064bf48dfa7e4582f1e568c06d 100644
--- a/spec/lib/gitlab/git/commit_spec.rb
+++ b/spec/lib/gitlab/git/commit_spec.rb
@@ -542,6 +542,7 @@
skip 'move this test to gitaly-ruby' do
describe '#init_from_rugged' do
let(:gitlab_commit) { described_class.new(repository, rugged_commit) }
+
subject { gitlab_commit }
describe '#id' do
@@ -553,6 +554,7 @@
describe '#init_from_hash' do
let(:commit) { described_class.new(repository, sample_commit_hash) }
+
subject { commit }
describe '#id' do
@@ -608,6 +610,7 @@
describe '#to_hash' do
let(:hash) { commit.to_hash }
+
subject { hash }
it { is_expected.to be_kind_of Hash }
@@ -629,6 +632,7 @@
describe '#ref_names' do
let(:commit) { described_class.find(repository, 'master') }
+
subject { commit.ref_names(repository) }
it 'has 2 element' do
diff --git a/spec/lib/gitlab/git/diff_spec.rb b/spec/lib/gitlab/git/diff_spec.rb
index 456d6af7bd83a059e88307b33e8f1a0d934aa14e..ac606da5cc1b77fcb76922f0d2bd1def6b83637c 100644
--- a/spec/lib/gitlab/git/diff_spec.rb
+++ b/spec/lib/gitlab/git/diff_spec.rb
@@ -149,6 +149,7 @@
describe '.between' do
let(:diffs) { described_class.between(repository, 'feature', 'master') }
+
subject { diffs }
it { is_expected.to be_kind_of Gitlab::Git::DiffCollection }
diff --git a/spec/lib/gitlab/git/hook_env_spec.rb b/spec/lib/gitlab/git/hook_env_spec.rb
index ca6a4ad42a3a1c9e2c9121f7823b14c567ec1098..22b016cee3e04e24f14aa096cdd7dfecb8aee2dd 100644
--- a/spec/lib/gitlab/git/hook_env_spec.rb
+++ b/spec/lib/gitlab/git/hook_env_spec.rb
@@ -57,6 +57,7 @@
using RSpec::Parameterized::TableSyntax
let(:key) { 'GIT_OBJECT_DIRECTORY_RELATIVE' }
+
subject { described_class.to_env_hash(gl_repository) }
where(:input, :output) do
diff --git a/spec/lib/gitlab/git/merge_base_spec.rb b/spec/lib/gitlab/git/merge_base_spec.rb
index dbb4e3d0b3e81c6e3ed978d71ca1f9f569ba4b9f..fa95a1664ea78481845f6b4519ca6741432405e1 100644
--- a/spec/lib/gitlab/git/merge_base_spec.rb
+++ b/spec/lib/gitlab/git/merge_base_spec.rb
@@ -5,6 +5,7 @@
describe Gitlab::Git::MergeBase do
set(:project) { create(:project, :repository) }
let(:repository) { project.repository }
+
subject(:merge_base) { described_class.new(repository, refs) }
shared_context 'existing refs with a merge base', :existing_refs do
diff --git a/spec/lib/gitlab/git/remote_repository_spec.rb b/spec/lib/gitlab/git/remote_repository_spec.rb
index 556cc692231062d85684df945067cc64cac62890..b53eee293f047481f28df865c6d1418541ee570d 100644
--- a/spec/lib/gitlab/git/remote_repository_spec.rb
+++ b/spec/lib/gitlab/git/remote_repository_spec.rb
@@ -4,6 +4,7 @@
describe Gitlab::Git::RemoteRepository, :seed_helper do
let(:repository) { Gitlab::Git::Repository.new('default', TEST_REPO_PATH, '', 'group/project') }
+
subject { described_class.new(repository) }
describe '#empty?' do
diff --git a/spec/lib/gitlab/git/repository_spec.rb b/spec/lib/gitlab/git/repository_spec.rb
index 20a74af7a45a8d0b419653599267963b387e6301..6854d514dcc6d09575773e1538468f65d16cd3e4 100644
--- a/spec/lib/gitlab/git/repository_spec.rb
+++ b/spec/lib/gitlab/git/repository_spec.rb
@@ -212,6 +212,7 @@
describe '#ref_names' do
let(:ref_names) { repository.ref_names }
+
subject { ref_names }
it { is_expected.to be_kind_of Array }
diff --git a/spec/lib/gitlab/git/user_spec.rb b/spec/lib/gitlab/git/user_spec.rb
index 277b1c48355faaada4336b67564b4aba94e3766f..6761413320a03a00a2de35b1fe683d4d60b0e036 100644
--- a/spec/lib/gitlab/git/user_spec.rb
+++ b/spec/lib/gitlab/git/user_spec.rb
@@ -26,6 +26,7 @@
describe '.from_gitlab' do
context 'when no commit_email has been set' do
let(:user) { build(:user, email: 'alice@example.com', commit_email: nil) }
+
subject { described_class.from_gitlab(user) }
it { expect(subject).to eq(described_class.new(user.username, user.name, user.email, 'user-')) }
@@ -33,6 +34,7 @@
context 'when commit_email has been set' do
let(:user) { build(:user, email: 'alice@example.com', commit_email: 'bob@example.com') }
+
subject { described_class.from_gitlab(user) }
it { expect(subject).to eq(described_class.new(user.username, user.name, user.commit_email, 'user-')) }
diff --git a/spec/lib/gitlab/gitaly_client/commit_service_spec.rb b/spec/lib/gitlab/gitaly_client/commit_service_spec.rb
index 1abdabe17bb38665b29c9b26d35d86f87924d808..820578dfc6e75491edf23bf501871c1ed601fbe6 100644
--- a/spec/lib/gitlab/gitaly_client/commit_service_spec.rb
+++ b/spec/lib/gitlab/gitaly_client/commit_service_spec.rb
@@ -188,6 +188,7 @@
describe '#find_commit' do
let(:revision) { Gitlab::Git::EMPTY_TREE_ID }
+
it 'sends an RPC request' do
request = Gitaly::FindCommitRequest.new(
repository: repository_message, revision: revision
diff --git a/spec/lib/gitlab/gitaly_client/ref_service_spec.rb b/spec/lib/gitlab/gitaly_client/ref_service_spec.rb
index 2b4fe2ea5c044edf7bcd2fb74871fbc46289288a..d4a7f6e6df9799b3722939395a3036f6200bc816 100644
--- a/spec/lib/gitlab/gitaly_client/ref_service_spec.rb
+++ b/spec/lib/gitlab/gitaly_client/ref_service_spec.rb
@@ -22,6 +22,7 @@
describe '#remote_branches' do
let(:remote_name) { 'my_remote' }
+
subject { client.remote_branches(remote_name) }
it 'sends a find_all_remote_branches message' do
diff --git a/spec/lib/gitlab/google_code_import/client_spec.rb b/spec/lib/gitlab/google_code_import/client_spec.rb
index bd63cabecd6834205ebb3cf84490bcf3a28bed4f..2e929a62ebce7ce2f32e07edfeefe232bac3d05c 100644
--- a/spec/lib/gitlab/google_code_import/client_spec.rb
+++ b/spec/lib/gitlab/google_code_import/client_spec.rb
@@ -4,6 +4,7 @@
describe Gitlab::GoogleCodeImport::Client do
let(:raw_data) { JSON.parse(fixture_file("GoogleCodeProjectHosting.json")) }
+
subject { described_class.new(raw_data) }
describe "#valid?" do
diff --git a/spec/lib/gitlab/graphql/authorize/authorize_field_service_spec.rb b/spec/lib/gitlab/graphql/authorize/authorize_field_service_spec.rb
index aada9285b31f6fc10231889a668402e505ac16be..98659dbed5718ca3754fb97d04c9d8c487b13740 100644
--- a/spec/lib/gitlab/graphql/authorize/authorize_field_service_spec.rb
+++ b/spec/lib/gitlab/graphql/authorize/authorize_field_service_spec.rb
@@ -25,6 +25,7 @@ def type_with_field(field_type, field_authorizations = [], resolved_value = 'Res
end
let(:current_user) { double(:current_user) }
+
subject(:service) { described_class.new(field) }
describe '#authorized_resolve' do
@@ -34,6 +35,7 @@ def type_with_field(field_type, field_authorizations = [], resolved_value = 'Res
let(:schema) { GraphQL::Schema.define(query: query_type, mutation: nil)}
let(:query_context) { OpenStruct.new(schema: schema) }
let(:context) { GraphQL::Query::Context.new(query: OpenStruct.new(schema: schema, context: query_context), values: { current_user: current_user }, object: nil) }
+
subject(:resolved) { service.authorized_resolve.call(presented_type, {}, context) }
context 'scalar types' do
diff --git a/spec/lib/gitlab/graphql/authorize/authorize_resource_spec.rb b/spec/lib/gitlab/graphql/authorize/authorize_resource_spec.rb
index 8f02b97959844c944b9a351ac2f44ac0672d9b95..67cb064b966728e522fe45240ccfda247e00c3aa 100644
--- a/spec/lib/gitlab/graphql/authorize/authorize_resource_spec.rb
+++ b/spec/lib/gitlab/graphql/authorize/authorize_resource_spec.rb
@@ -27,6 +27,7 @@ def current_user
let(:user) { build(:user) }
let(:project) { build(:project) }
+
subject(:loading_resource) { fake_class.new(user, project) }
context 'when the user is allowed to perform the action' do
diff --git a/spec/lib/gitlab/graphql/connections/filterable_array_connection_spec.rb b/spec/lib/gitlab/graphql/connections/filterable_array_connection_spec.rb
index 1fda84f777e0792b087d7f6f14dfe2a07e4f4350..20e87daa0d6e180a40cbcb599c4b9aa9fbdab42b 100644
--- a/spec/lib/gitlab/graphql/connections/filterable_array_connection_spec.rb
+++ b/spec/lib/gitlab/graphql/connections/filterable_array_connection_spec.rb
@@ -6,6 +6,7 @@
let(:callback) { proc { |nodes| nodes } }
let(:all_nodes) { Gitlab::Graphql::FilterableArray.new(callback, 1, 2, 3, 4, 5) }
let(:arguments) { {} }
+
subject(:connection) do
described_class.new(all_nodes, arguments, max_page_size: 3)
end
diff --git a/spec/lib/gitlab/graphql/connections/keyset/connection_spec.rb b/spec/lib/gitlab/graphql/connections/keyset/connection_spec.rb
index 369550198633105e28fe8fca5f86cbcc2c930ec1..bd0fcbbdeb206d1fe342eca562d7a4dfe8cd71f6 100644
--- a/spec/lib/gitlab/graphql/connections/keyset/connection_spec.rb
+++ b/spec/lib/gitlab/graphql/connections/keyset/connection_spec.rb
@@ -5,6 +5,7 @@
describe Gitlab::Graphql::Connections::Keyset::Connection do
let(:nodes) { Project.all.order(id: :asc) }
let(:arguments) { {} }
+
subject(:connection) do
described_class.new(nodes, arguments, max_page_size: 3)
end
diff --git a/spec/lib/gitlab/hook_data/base_builder_spec.rb b/spec/lib/gitlab/hook_data/base_builder_spec.rb
index ce8610a21083f7abd2e39fbda47a84dc2664ec4c..4c3fd854c093e48fa42ad8babfc7ffa8459b81c8 100644
--- a/spec/lib/gitlab/hook_data/base_builder_spec.rb
+++ b/spec/lib/gitlab/hook_data/base_builder_spec.rb
@@ -15,6 +15,7 @@
context 'with an upload prefix specified' do
let(:project_with_path) { double(full_path: 'baz/bar') }
let(:object_with_project) { double(project: project_with_path) }
+
subject { subclass.new(object_with_project) }
where do
diff --git a/spec/lib/gitlab/i18n/translation_entry_spec.rb b/spec/lib/gitlab/i18n/translation_entry_spec.rb
index 3f0b922cc51fd5d8f6c1f5095c2033f448a820c5..880da38052ed06f816093af38dc192bbd07d4d0c 100644
--- a/spec/lib/gitlab/i18n/translation_entry_spec.rb
+++ b/spec/lib/gitlab/i18n/translation_entry_spec.rb
@@ -136,6 +136,7 @@
describe '#contains_unescaped_chars' do
let(:data) { { msgid: '' } }
let(:entry) { described_class.new(data, 2) }
+
it 'is true when the msgid is an array' do
string = '「100%確定ã€'
diff --git a/spec/lib/gitlab/import_export/lfs_restorer_spec.rb b/spec/lib/gitlab/import_export/lfs_restorer_spec.rb
index 75d6da48f330ee650891f15b3b027d1ccdc991af..a932dc3ee4e89f5889fec7ef4e10f2b7d070e6fb 100644
--- a/spec/lib/gitlab/import_export/lfs_restorer_spec.rb
+++ b/spec/lib/gitlab/import_export/lfs_restorer_spec.rb
@@ -9,6 +9,7 @@
let(:project) { create(:project) }
let(:shared) { project.import_export_shared }
let(:saver) { Gitlab::ImportExport::LfsSaver.new(project: project, shared: shared) }
+
subject(:restorer) { described_class.new(project: project, shared: shared) }
before do
diff --git a/spec/lib/gitlab/import_export/saver_spec.rb b/spec/lib/gitlab/import_export/saver_spec.rb
index 279d99dc8206720b1c134bbafbe22f286c8f590c..450ae2a2083dbbce06597dee7760ae71b61b5358 100644
--- a/spec/lib/gitlab/import_export/saver_spec.rb
+++ b/spec/lib/gitlab/import_export/saver_spec.rb
@@ -7,6 +7,7 @@
let!(:project) { create(:project, :public, name: 'project') }
let(:export_path) { "#{Dir.tmpdir}/project_tree_saver_spec" }
let(:shared) { project.import_export_shared }
+
subject { described_class.new(exportable: project, shared: shared) }
before do
diff --git a/spec/lib/gitlab/import_export/shared_spec.rb b/spec/lib/gitlab/import_export/shared_spec.rb
index 2b94610a07423f26805c82857a9c607f196165e3..8d522252e2d8ecd091457183b05ea1282ef9d79c 100644
--- a/spec/lib/gitlab/import_export/shared_spec.rb
+++ b/spec/lib/gitlab/import_export/shared_spec.rb
@@ -5,6 +5,7 @@
describe Gitlab::ImportExport::Shared do
let(:project) { build(:project) }
+
subject { project.import_export_shared }
context 'with a repository on disk' do
diff --git a/spec/lib/gitlab/json_cache_spec.rb b/spec/lib/gitlab/json_cache_spec.rb
index 39cdd42088edc93027ba1a9cc2b257cd5d1f71af..5ba6abbc656d2cbcdb8b6953164086ac25f552a5 100644
--- a/spec/lib/gitlab/json_cache_spec.rb
+++ b/spec/lib/gitlab/json_cache_spec.rb
@@ -7,6 +7,7 @@
let(:namespace) { 'geo' }
let(:key) { 'foo' }
let(:expanded_key) { "#{namespace}:#{key}:#{Gitlab::VERSION}:#{Rails.version}" }
+
set(:broadcast_message) { create(:broadcast_message) }
subject(:cache) { described_class.new(namespace: namespace, backend: backend) }
diff --git a/spec/lib/gitlab/kubernetes/config_map_spec.rb b/spec/lib/gitlab/kubernetes/config_map_spec.rb
index 64f973799262da24438de3d056dc7e6abd3c0bfa..0203772e069b2d5a6c82901398d57ec4aa5bcefc 100644
--- a/spec/lib/gitlab/kubernetes/config_map_spec.rb
+++ b/spec/lib/gitlab/kubernetes/config_map_spec.rb
@@ -18,6 +18,7 @@
describe '#generate' do
let(:resource) { ::Kubeclient::Resource.new(metadata: metadata, data: application.files) }
+
subject { config_map.generate }
it 'builds a Kubeclient Resource' do
diff --git a/spec/lib/gitlab/kubernetes/namespace_spec.rb b/spec/lib/gitlab/kubernetes/namespace_spec.rb
index 6dbb34c2930f289d3f90386eec172c469962eab4..16634cc48e6f9ffac9cae6c047206609fe9bafbe 100644
--- a/spec/lib/gitlab/kubernetes/namespace_spec.rb
+++ b/spec/lib/gitlab/kubernetes/namespace_spec.rb
@@ -5,6 +5,7 @@
describe Gitlab::Kubernetes::Namespace do
let(:name) { 'a_namespace' }
let(:client) { double('kubernetes client') }
+
subject { described_class.new(name, client) }
it { expect(subject.name).to eq(name) }
diff --git a/spec/lib/gitlab/kubernetes_spec.rb b/spec/lib/gitlab/kubernetes_spec.rb
index 31bfd20449d010b9bbaf7f5a900b13205fd1b5f2..40c3e7d0b3c72a4a7456e15931c53181a332783f 100644
--- a/spec/lib/gitlab/kubernetes_spec.rb
+++ b/spec/lib/gitlab/kubernetes_spec.rb
@@ -27,6 +27,7 @@
context 'with a path prefix in the API URL' do
let(:api_url) { 'https://example.com/prefix/' }
+
it { expect(result.path).to eq('/prefix/api/v1/namespaces/default/pods/pod1/exec') }
end
diff --git a/spec/lib/gitlab/legacy_github_import/importer_spec.rb b/spec/lib/gitlab/legacy_github_import/importer_spec.rb
index b54f30947aace06506fc70be42eb728b66078018..c6ee0a3c09416afb03e2887fdd04fd4fbb4ac4ed 100644
--- a/spec/lib/gitlab/legacy_github_import/importer_spec.rb
+++ b/spec/lib/gitlab/legacy_github_import/importer_spec.rb
@@ -265,6 +265,7 @@
context 'when importing a GitHub project' do
let(:api_root) { 'https://api.github.com' }
let(:repo_root) { 'https://github.com' }
+
subject { described_class.new(project) }
it_behaves_like 'Gitlab::LegacyGithubImport::Importer#execute'
@@ -287,6 +288,7 @@
context 'when importing a Gitea project' do
let(:api_root) { 'https://try.gitea.io/api/v1' }
let(:repo_root) { 'https://try.gitea.io' }
+
subject { described_class.new(project) }
before do
diff --git a/spec/lib/gitlab/legacy_github_import/milestone_formatter_spec.rb b/spec/lib/gitlab/legacy_github_import/milestone_formatter_spec.rb
index 9fa72b3cd9040dc45c306959a5e2e58b691ff270..f5d71888ac9725c7615fb545f8304013fb86159c 100644
--- a/spec/lib/gitlab/legacy_github_import/milestone_formatter_spec.rb
+++ b/spec/lib/gitlab/legacy_github_import/milestone_formatter_spec.rb
@@ -89,6 +89,7 @@
context 'when importing a Gitea project' do
let(:iid_attr) { :id }
+
before do
project.update(import_type: 'gitea')
end
diff --git a/spec/lib/gitlab/lets_encrypt/client_spec.rb b/spec/lib/gitlab/lets_encrypt/client_spec.rb
index cbb862cb0c9e7c5a4223982e694fd72abc26f836..e86de04b5cf77a46473337ed7a6a1e7c12fb504f 100644
--- a/spec/lib/gitlab/lets_encrypt/client_spec.rb
+++ b/spec/lib/gitlab/lets_encrypt/client_spec.rb
@@ -86,6 +86,7 @@
describe '#load_order' do
let(:url) { 'https://example.com/order' }
+
subject { client.load_order(url) }
before do
@@ -102,6 +103,7 @@
describe '#load_challenge' do
let(:url) { 'https://example.com/challenge' }
+
subject { client.load_challenge(url) }
before do
diff --git a/spec/lib/gitlab/markdown_cache/active_record/extension_spec.rb b/spec/lib/gitlab/markdown_cache/active_record/extension_spec.rb
index 6d89d22bd0eb02a06efe3917cd8fec2420fbe9ce..5b6c769d6ebb46f283347468b0c886e7e67cf72c 100644
--- a/spec/lib/gitlab/markdown_cache/active_record/extension_spec.rb
+++ b/spec/lib/gitlab/markdown_cache/active_record/extension_spec.rb
@@ -126,6 +126,7 @@
describe '#cached_html_up_to_date?' do
let(:thing) { klass.create(title: updated_markdown, title_html: html, cached_markdown_version: nil) }
+
subject { thing.cached_html_up_to_date?(:title) }
it 'returns false if markdown has been changed but html has not' do
diff --git a/spec/lib/gitlab/metrics/requests_rack_middleware_spec.rb b/spec/lib/gitlab/metrics/requests_rack_middleware_spec.rb
index 335670278c4e1676c4b4208d9b24c783799b5bd0..1fc6fdcf6225694db4bc55ef5edefa7a5cff328c 100644
--- a/spec/lib/gitlab/metrics/requests_rack_middleware_spec.rb
+++ b/spec/lib/gitlab/metrics/requests_rack_middleware_spec.rb
@@ -4,6 +4,7 @@
describe Gitlab::Metrics::RequestsRackMiddleware do
let(:app) { double('app') }
+
subject { described_class.new(app) }
describe '#call' do
diff --git a/spec/lib/gitlab/metrics/samplers/unicorn_sampler_spec.rb b/spec/lib/gitlab/metrics/samplers/unicorn_sampler_spec.rb
index cdfd95e3885dea418a46879f3979bf5f4669c764..a64aae73d4351a9934f986567a21c61afbd5ae61 100644
--- a/spec/lib/gitlab/metrics/samplers/unicorn_sampler_spec.rb
+++ b/spec/lib/gitlab/metrics/samplers/unicorn_sampler_spec.rb
@@ -52,6 +52,7 @@
context 'unicorn listens on tcp sockets' do
let(:tcp_socket_address) { '0.0.0.0:8080' }
let(:tcp_sockets) { [tcp_socket_address] }
+
before do
allow(unicorn).to receive(:listener_names).and_return(tcp_sockets)
end
diff --git a/spec/lib/gitlab/pagination/keyset_spec.rb b/spec/lib/gitlab/pagination/keyset_spec.rb
index 755c422c46a637e4944c077307256e10055b804e..5c2576d7b4514eb8dd5f5c02fb7a89d11817ae99 100644
--- a/spec/lib/gitlab/pagination/keyset_spec.rb
+++ b/spec/lib/gitlab/pagination/keyset_spec.rb
@@ -49,6 +49,7 @@
context 'with other order-by columns' do
let(:order_by) { { created_at: :desc, id: :desc } }
+
it 'returns false for Project' do
expect(subject.available?(request_context, Project.all)).to be_falsey
end
diff --git a/spec/lib/gitlab/phabricator_import/cache/map_spec.rb b/spec/lib/gitlab/phabricator_import/cache/map_spec.rb
index b6629fad45396debe728a26754907a1a3ecf1c7c..14a5d40d445429a2e689debbc3fc317c3f7d4b4a 100644
--- a/spec/lib/gitlab/phabricator_import/cache/map_spec.rb
+++ b/spec/lib/gitlab/phabricator_import/cache/map_spec.rb
@@ -5,6 +5,7 @@
describe Gitlab::PhabricatorImport::Cache::Map, :clean_gitlab_redis_cache do
set(:project) { create(:project) }
let(:redis) { Gitlab::Redis::Cache }
+
subject(:map) { described_class.new(project) }
describe '#get_gitlab_model' do
diff --git a/spec/lib/gitlab/phabricator_import/importer_spec.rb b/spec/lib/gitlab/phabricator_import/importer_spec.rb
index 99a6e4dad6b94dcd1a95aad9e552d748c2519dc2..2715b7853798a785115449ab7c4749dc87af852d 100644
--- a/spec/lib/gitlab/phabricator_import/importer_spec.rb
+++ b/spec/lib/gitlab/phabricator_import/importer_spec.rb
@@ -11,6 +11,7 @@
describe '#execute' do
let(:project) { create(:project, :import_scheduled) }
+
subject(:importer) { described_class.new(project) }
it 'sets a custom jid that will be kept up to date' do
diff --git a/spec/lib/gitlab/phabricator_import/project_creator_spec.rb b/spec/lib/gitlab/phabricator_import/project_creator_spec.rb
index fd17284eea2aeb2bbd82947b48a7856737d15bb9..0b6a71290edea6900d8dc3d0dd37d7578faa2763 100644
--- a/spec/lib/gitlab/phabricator_import/project_creator_spec.rb
+++ b/spec/lib/gitlab/phabricator_import/project_creator_spec.rb
@@ -8,6 +8,7 @@
phabricator_server_url: 'http://phab.example.com',
api_token: 'the-token' }
end
+
subject(:creator) { described_class.new(user, params) }
describe '#execute' do
diff --git a/spec/lib/gitlab/phabricator_import/user_finder_spec.rb b/spec/lib/gitlab/phabricator_import/user_finder_spec.rb
index 918ff28c8f5115548cc18a6fdf695235d7cfb305..14a00deeb16e6c2910ce2f6edb9a8d96a1f86e64 100644
--- a/spec/lib/gitlab/phabricator_import/user_finder_spec.rb
+++ b/spec/lib/gitlab/phabricator_import/user_finder_spec.rb
@@ -4,6 +4,7 @@
describe Gitlab::PhabricatorImport::UserFinder, :clean_gitlab_redis_cache do
let(:project) { create(:project, namespace: create(:group)) }
+
subject(:finder) { described_class.new(project, ['first-phid', 'second-phid']) }
before do
diff --git a/spec/lib/gitlab/project_search_results_spec.rb b/spec/lib/gitlab/project_search_results_spec.rb
index 99078f19361285e3904123c691b893088cc0297b..6f4844d454330b2c4df4b06c163f59589dcab5ff 100644
--- a/spec/lib/gitlab/project_search_results_spec.rb
+++ b/spec/lib/gitlab/project_search_results_spec.rb
@@ -53,6 +53,7 @@
context "when #{entity_type} is disabled" do
let(:project) { disabled_project }
+
it "hides #{blob_kind} from members" do
project.add_reporter(user)
diff --git a/spec/lib/gitlab/prometheus/queries/deployment_query_spec.rb b/spec/lib/gitlab/prometheus/queries/deployment_query_spec.rb
index 0ad2de218feac02b1441b7b1e4063856ba581f96..90d4e58ce212b5d187a19940c3a9be5373e570df 100644
--- a/spec/lib/gitlab/prometheus/queries/deployment_query_spec.rb
+++ b/spec/lib/gitlab/prometheus/queries/deployment_query_spec.rb
@@ -7,6 +7,7 @@
let(:deployment) { create(:deployment, environment: environment) }
let(:client) { double('prometheus_client') }
+
subject { described_class.new(client) }
around do |example|
diff --git a/spec/lib/gitlab/prometheus/queries/knative_invocation_query_spec.rb b/spec/lib/gitlab/prometheus/queries/knative_invocation_query_spec.rb
index 6361893c53c7ebc220b3851935e42454878d2b56..19dd05258598afa046cff5d17db25d4384dae0a4 100644
--- a/spec/lib/gitlab/prometheus/queries/knative_invocation_query_spec.rb
+++ b/spec/lib/gitlab/prometheus/queries/knative_invocation_query_spec.rb
@@ -9,6 +9,7 @@
let(:serverless_func) { Serverless::Function.new(project, 'test-name', 'test-ns') }
let(:client) { double('prometheus_client') }
+
subject { described_class.new(client) }
context 'verify queries' do
diff --git a/spec/lib/gitlab/prometheus_client_spec.rb b/spec/lib/gitlab/prometheus_client_spec.rb
index 86a1c14ed3f06d9be020027ecde7300e73c0166d..4f9315e28e9bc67f4bea8ed1728ce708afd9dee5 100644
--- a/spec/lib/gitlab/prometheus_client_spec.rb
+++ b/spec/lib/gitlab/prometheus_client_spec.rb
@@ -327,6 +327,7 @@
context "without response code" do
let(:response_error) { Gitlab::HTTP::ResponseError }
+
it 'raises PrometheusClient::Error' do
expect { subject.proxy('query', { query: prometheus_query }) }.to(
raise_error(Gitlab::PrometheusClient::Error, 'Network connection error')
diff --git a/spec/lib/gitlab/quick_actions/substitution_definition_spec.rb b/spec/lib/gitlab/quick_actions/substitution_definition_spec.rb
index e4f25bc35a93a0e79c94d07dca4342f074fe5ab2..d0bb032f7760ba0809d26ced92e2b2f66968c774 100644
--- a/spec/lib/gitlab/quick_actions/substitution_definition_spec.rb
+++ b/spec/lib/gitlab/quick_actions/substitution_definition_spec.rb
@@ -9,6 +9,7 @@
/sub_name I like this stuff
EOF
end
+
subject do
described_class.new(:sub_name, action_block: proc { |text| "#{text} foo" })
end
diff --git a/spec/lib/gitlab/slash_commands/command_spec.rb b/spec/lib/gitlab/slash_commands/command_spec.rb
index 5a8c721a63453641e6c89ab4543c4f7080225e4b..73b93589fac610603eef61368baf817f8b0a799a 100644
--- a/spec/lib/gitlab/slash_commands/command_spec.rb
+++ b/spec/lib/gitlab/slash_commands/command_spec.rb
@@ -113,11 +113,13 @@
context 'IssueMove is triggered' do
let(:params) { { text: 'issue move #78291 to gitlab/gitlab-ci' } }
+
it { is_expected.to eq(Gitlab::SlashCommands::IssueMove) }
end
context 'IssueComment is triggered' do
let(:params) { { text: "issue comment #503\ncomment body" } }
+
it { is_expected.to eq(Gitlab::SlashCommands::IssueComment) }
end
end
diff --git a/spec/lib/gitlab/slash_commands/issue_search_spec.rb b/spec/lib/gitlab/slash_commands/issue_search_spec.rb
index b766a9a1361f5f98c5ab62937142f7c8cbb66ab6..a142c8e4c92b23f7776fef09ee091bc2200fef97 100644
--- a/spec/lib/gitlab/slash_commands/issue_search_spec.rb
+++ b/spec/lib/gitlab/slash_commands/issue_search_spec.rb
@@ -42,6 +42,7 @@
describe 'self.match' do
let(:query) { "my search keywords" }
+
it 'matches the query' do
match = described_class.match("issue search #{query}")
diff --git a/spec/lib/gitlab/slash_commands/presenters/issue_comment_spec.rb b/spec/lib/gitlab/slash_commands/presenters/issue_comment_spec.rb
index b5ef417cb93faf3e053728310ea0b3fcb30e6bbb..3741563a744bba1b71807809fff5cc8cb257bb66 100644
--- a/spec/lib/gitlab/slash_commands/presenters/issue_comment_spec.rb
+++ b/spec/lib/gitlab/slash_commands/presenters/issue_comment_spec.rb
@@ -10,6 +10,7 @@
describe '#present' do
let(:attachment) { subject[:attachments].first }
+
subject { described_class.new(note).present }
it { is_expected.to be_a(Hash) }
diff --git a/spec/lib/gitlab/workhorse_spec.rb b/spec/lib/gitlab/workhorse_spec.rb
index 88bc5034da5df41c0c3f711d5f60f123101391ec..89381057f6b6fc74f3952b70d91a72692b12070b 100644
--- a/spec/lib/gitlab/workhorse_spec.rb
+++ b/spec/lib/gitlab/workhorse_spec.rb
@@ -116,6 +116,7 @@ def decode_workhorse_header(array)
describe '.send_git_patch' do
let(:diff_refs) { double(base_sha: "base", head_sha: "head") }
+
subject { described_class.send_git_patch(repository, diff_refs) }
it 'sets the header correctly' do
@@ -178,6 +179,7 @@ def workhorse(ca_pem: nil)
describe '.send_git_diff' do
let(:diff_refs) { double(base_sha: "base", head_sha: "head") }
+
subject { described_class.send_git_diff(repository, diff_refs) }
it 'sets the header correctly' do
diff --git a/spec/lib/json_web_token/rsa_token_spec.rb b/spec/lib/json_web_token/rsa_token_spec.rb
index a127c787e28aee1dcd1904895749c5f51c21449a..62fddbb97c765bdaf79f1a3463dd99cdcf0ec111 100644
--- a/spec/lib/json_web_token/rsa_token_spec.rb
+++ b/spec/lib/json_web_token/rsa_token_spec.rb
@@ -41,6 +41,7 @@
context 'for invalid key to raise an exception' do
let(:new_key) { OpenSSL::PKey::RSA.generate(512) }
+
subject { JWT.decode(rsa_encoded, new_key, true, { algorithm: 'RS256' }) }
it { expect {subject}.to raise_error(JWT::DecodeError) }
diff --git a/spec/services/award_emojis/add_service_spec.rb b/spec/services/award_emojis/add_service_spec.rb
index 037db39ba80a968f863d075d1abfe4e6ecbc01c6..8364e662735b75b7242d945a2ad1c930f17e0378 100644
--- a/spec/services/award_emojis/add_service_spec.rb
+++ b/spec/services/award_emojis/add_service_spec.rb
@@ -7,6 +7,7 @@
set(:project) { create(:project) }
set(:awardable) { create(:note, project: project) }
let(:name) { 'thumbsup' }
+
subject(:service) { described_class.new(awardable, name, user) }
describe '#execute' do
diff --git a/spec/services/award_emojis/destroy_service_spec.rb b/spec/services/award_emojis/destroy_service_spec.rb
index c4a7d5ec20e65523e00758708bca80028cd05207..6d54c0374644f0a2003e1de38be885f9cc4901b0 100644
--- a/spec/services/award_emojis/destroy_service_spec.rb
+++ b/spec/services/award_emojis/destroy_service_spec.rb
@@ -10,6 +10,7 @@
let!(:award_from_other_user) do
create(:award_emoji, name: name, awardable: awardable, user: create(:user))
end
+
subject(:service) { described_class.new(awardable, name, user) }
describe '#execute' do
diff --git a/spec/services/award_emojis/toggle_service_spec.rb b/spec/services/award_emojis/toggle_service_spec.rb
index 972a1d5fc066d486a79305fc2c2d8621de0dcf96..a8d110d04f769e878616bcfa489c8a2aaa8e14d8 100644
--- a/spec/services/award_emojis/toggle_service_spec.rb
+++ b/spec/services/award_emojis/toggle_service_spec.rb
@@ -7,6 +7,7 @@
set(:project) { create(:project, :public) }
set(:awardable) { create(:note, project: project) }
let(:name) { 'thumbsup' }
+
subject(:service) { described_class.new(awardable, name, user) }
describe '#execute' do
diff --git a/spec/services/branches/create_service_spec.rb b/spec/services/branches/create_service_spec.rb
index 444491ed6f385ecfe0331ffecccfc9b9bc7d6fcb..b0629c5e25abfa43c50ab6ccd66bf07bb50bb0df 100644
--- a/spec/services/branches/create_service_spec.rb
+++ b/spec/services/branches/create_service_spec.rb
@@ -4,6 +4,7 @@
describe Branches::CreateService do
let(:user) { create(:user) }
+
subject(:service) { described_class.new(project, user) }
describe '#execute' do
diff --git a/spec/services/branches/delete_service_spec.rb b/spec/services/branches/delete_service_spec.rb
index b4848978a6f9490753af1b0a3daec32259ade718..2219416d94d3f73b41bed52658b5220521cf9ab7 100644
--- a/spec/services/branches/delete_service_spec.rb
+++ b/spec/services/branches/delete_service_spec.rb
@@ -6,6 +6,7 @@
let(:project) { create(:project, :repository) }
let(:repository) { project.repository }
let(:user) { create(:user) }
+
subject(:service) { described_class.new(project, user) }
shared_examples 'a deleted branch' do |branch_name|
diff --git a/spec/services/branches/validate_new_service_spec.rb b/spec/services/branches/validate_new_service_spec.rb
index 460f28b5844c699e439580b4aa4e707bfab5332a..6d5078d3ccb717e4a2439acab48da7d3fb7663b7 100644
--- a/spec/services/branches/validate_new_service_spec.rb
+++ b/spec/services/branches/validate_new_service_spec.rb
@@ -4,6 +4,7 @@
describe Branches::ValidateNewService do
let(:project) { create(:project, :repository) }
+
subject(:service) { described_class.new(project) }
describe '#execute' do
diff --git a/spec/services/clusters/applications/check_installation_progress_service_spec.rb b/spec/services/clusters/applications/check_installation_progress_service_spec.rb
index 02fd4b63c89ea7f707deae6247a567dd0c186b99..335397ee9f5c33f0e1bf7876d1f2579991d95868 100644
--- a/spec/services/clusters/applications/check_installation_progress_service_spec.rb
+++ b/spec/services/clusters/applications/check_installation_progress_service_spec.rb
@@ -76,6 +76,7 @@
context 'when installation POD succeeded' do
let(:phase) { Gitlab::Kubernetes::Pod::SUCCEEDED }
+
before do
expect(service).to receive(:pod_phase).once.and_return(phase)
end
@@ -137,6 +138,7 @@
context 'when installation POD succeeded' do
let(:phase) { Gitlab::Kubernetes::Pod::SUCCEEDED }
+
before do
expect(service).to receive(:pod_phase).once.and_return(phase)
end
diff --git a/spec/services/clusters/applications/check_uninstall_progress_service_spec.rb b/spec/services/clusters/applications/check_uninstall_progress_service_spec.rb
index 68ad020822653db26fb6b22367deb30f38c21c09..a70b94a6fd6275fbf2125a3935762470d4e01775 100644
--- a/spec/services/clusters/applications/check_uninstall_progress_service_spec.rb
+++ b/spec/services/clusters/applications/check_uninstall_progress_service_spec.rb
@@ -46,6 +46,7 @@
context 'when installation POD succeeded' do
let(:phase) { Gitlab::Kubernetes::Pod::SUCCEEDED }
+
before do
expect_any_instance_of(Gitlab::Kubernetes::Helm::Api)
.to receive(:delete_pod!)
diff --git a/spec/services/clusters/kubernetes/fetch_kubernetes_token_service_spec.rb b/spec/services/clusters/kubernetes/fetch_kubernetes_token_service_spec.rb
index 145528616ee3765be39056e05bd1e15bcbecd1ad..fa4b6e497e5345bcd04351713e3af090f819ef20 100644
--- a/spec/services/clusters/kubernetes/fetch_kubernetes_token_service_spec.rb
+++ b/spec/services/clusters/kubernetes/fetch_kubernetes_token_service_spec.rb
@@ -26,6 +26,7 @@
context 'when params correct' do
let(:decoded_token) { 'xxx.token.xxx' }
let(:token) { Base64.encode64(decoded_token) }
+
context 'when the secret exists' do
before do
stub_kubeclient_get_secret(
diff --git a/spec/services/compare_service_spec.rb b/spec/services/compare_service_spec.rb
index fadd43635a67dafaa694a4e0260ff5c470b1ddc1..f6d8eb348d02820618c71c294b06c238431cdcbd 100644
--- a/spec/services/compare_service_spec.rb
+++ b/spec/services/compare_service_spec.rb
@@ -28,6 +28,7 @@
context 'compare with source branch that does not exist' do
let(:service) { described_class.new(project, 'non-existent-branch') }
+
subject { service.execute(project, 'non-existent-ref') }
it { expect(subject).to be_nil }
diff --git a/spec/services/issues/move_service_spec.rb b/spec/services/issues/move_service_spec.rb
index 7483688d63141c714bc7ab7c71b39c92f2eb6b92..e39af7bbb729952b18034a178b284cea145f8c71 100644
--- a/spec/services/issues/move_service_spec.rb
+++ b/spec/services/issues/move_service_spec.rb
@@ -191,6 +191,7 @@
context 'issue is not persisted' do
include_context 'user can move issue'
let(:old_issue) { build(:issue, project: old_project, author: author) }
+
it { expect { move }.to raise_error(StandardError, /permissions/) }
end
end
diff --git a/spec/services/issues/update_service_spec.rb b/spec/services/issues/update_service_spec.rb
index b8a0e11847963ed605740ece76bbfb07ac925790..64bca770d5b9e3dee1b9343be3c807dc111785e2 100644
--- a/spec/services/issues/update_service_spec.rb
+++ b/spec/services/issues/update_service_spec.rb
@@ -151,6 +151,7 @@ def update_issue(opts)
context 'when current user cannot admin issues in the project' do
let(:guest) { create(:user) }
+
before do
project.add_guest(guest)
end
diff --git a/spec/services/lfs/unlock_file_service_spec.rb b/spec/services/lfs/unlock_file_service_spec.rb
index 8e36617c0d6f1f141f7a0dd531bf5a167e756a23..61c0eacd870ae5e57ca39bfc73c0a2576b121a56 100644
--- a/spec/services/lfs/unlock_file_service_spec.rb
+++ b/spec/services/lfs/unlock_file_service_spec.rb
@@ -29,6 +29,7 @@
context 'when lock does not exists' do
let(:params) { { id: 123 } }
+
it "doesn't succeed" do
result = subject.execute
diff --git a/spec/services/merge_requests/get_urls_service_spec.rb b/spec/services/merge_requests/get_urls_service_spec.rb
index 9e7a5260ca417e2b4712dde2d13a2c3ad161929c..dcb8c8080a1937f84698829c2ad89011bac208b9 100644
--- a/spec/services/merge_requests/get_urls_service_spec.rb
+++ b/spec/services/merge_requests/get_urls_service_spec.rb
@@ -47,6 +47,7 @@
context 'pushing to default branch' do
let(:changes) { default_branch_changes }
+
it_behaves_like 'no_merge_request_url'
end
@@ -62,28 +63,33 @@
context 'pushing one completely new branch' do
let(:changes) { new_branch_changes }
+
it_behaves_like 'new_merge_request_link'
end
context 'pushing to existing branch but no merge request' do
let(:changes) { existing_branch_changes }
+
it_behaves_like 'new_merge_request_link'
end
context 'pushing to deleted branch' do
let(:changes) { deleted_branch_changes }
+
it_behaves_like 'no_merge_request_url'
end
context 'pushing to existing branch and merge request opened' do
let!(:merge_request) { create(:merge_request, source_project: project, source_branch: source_branch) }
let(:changes) { existing_branch_changes }
+
it_behaves_like 'show_merge_request_url'
end
context 'pushing to existing branch and merge request is reopened' do
let!(:merge_request) { create(:merge_request, :opened, source_project: project, source_branch: source_branch) }
let(:changes) { existing_branch_changes }
+
it_behaves_like 'show_merge_request_url'
end
@@ -105,12 +111,14 @@
context 'pushing to existing branch and merge request is closed' do
let!(:merge_request) { create(:merge_request, :closed, source_project: project, source_branch: source_branch) }
let(:changes) { existing_branch_changes }
+
it_behaves_like 'new_merge_request_link'
end
context 'pushing to existing branch and merge request is merged' do
let!(:merge_request) { create(:merge_request, :merged, source_project: project, source_branch: source_branch) }
let(:changes) { existing_branch_changes }
+
it_behaves_like 'new_merge_request_link'
end
diff --git a/spec/services/merge_requests/refresh_service_spec.rb b/spec/services/merge_requests/refresh_service_spec.rb
index 9e69f179da9611381a016414d006f76b63d2c12f..1ba216e8ff1a1614ad2b504aced978a704188f3f 100644
--- a/spec/services/merge_requests/refresh_service_spec.rb
+++ b/spec/services/merge_requests/refresh_service_spec.rb
@@ -608,6 +608,7 @@ def refresh
context 'marking the merge request as work in progress' do
let(:refresh_service) { service.new(@project, @user) }
+
before do
allow(refresh_service).to receive(:execute_hooks)
end
diff --git a/spec/services/merge_requests/resolved_discussion_notification_service_spec.rb b/spec/services/merge_requests/resolved_discussion_notification_service_spec.rb
index dc2bd5bf3d0f624fee061fb8ad5e9c1f52f2ff07..29896db58acc03e7a42779193ca5fcf442535c42 100644
--- a/spec/services/merge_requests/resolved_discussion_notification_service_spec.rb
+++ b/spec/services/merge_requests/resolved_discussion_notification_service_spec.rb
@@ -6,6 +6,7 @@
let(:merge_request) { create(:merge_request) }
let(:user) { create(:user) }
let(:project) { merge_request.project }
+
subject { described_class.new(project, user) }
describe "#execute" do
diff --git a/spec/services/notification_service_spec.rb b/spec/services/notification_service_spec.rb
index 25900043f11203dcebcffc3baf6382a0a19dc725..0d05b696e450b3abacbab12c3c504f615148334b 100644
--- a/spec/services/notification_service_spec.rb
+++ b/spec/services/notification_service_spec.rb
@@ -154,6 +154,7 @@
describe '#async' do
let(:async) { notification.async }
+
set(:key) { create(:personal_key) }
it 'returns an Async object with the correct parent' do
diff --git a/spec/services/projects/container_repository/delete_tags_service_spec.rb b/spec/services/projects/container_repository/delete_tags_service_spec.rb
index 1cfe3582e5623c8105bd9535cbf35c6ad54623fb..7ceb02c9cf8e4287400b653f9ba5bbf364dc834a 100644
--- a/spec/services/projects/container_repository/delete_tags_service_spec.rb
+++ b/spec/services/projects/container_repository/delete_tags_service_spec.rb
@@ -26,6 +26,7 @@
describe '#execute' do
let(:tags) { %w[A] }
+
subject { service.execute(repository) }
context 'without permissions' do
diff --git a/spec/services/projects/forks_count_service_spec.rb b/spec/services/projects/forks_count_service_spec.rb
index 1b44782468addea3d16e43ae1a9f21f06a889eb3..21a75eafc7abaf67afe4fcdfdea1259edb8b7601 100644
--- a/spec/services/projects/forks_count_service_spec.rb
+++ b/spec/services/projects/forks_count_service_spec.rb
@@ -4,6 +4,7 @@
describe Projects::ForksCountService, :use_clean_rails_memory_store_caching do
let(:project) { build(:project) }
+
subject { described_class.new(project) }
it_behaves_like 'a counter caching service'
diff --git a/spec/services/projects/open_issues_count_service_spec.rb b/spec/services/projects/open_issues_count_service_spec.rb
index 593a4df1f8f5f4ed3ec7e8ce9b08f16ad0fe07c9..04f1353c499adbe321910b5aa116bcb1970eeda5 100644
--- a/spec/services/projects/open_issues_count_service_spec.rb
+++ b/spec/services/projects/open_issues_count_service_spec.rb
@@ -4,6 +4,7 @@
describe Projects::OpenIssuesCountService, :use_clean_rails_memory_store_caching do
let(:project) { create(:project) }
+
subject { described_class.new(project) }
it_behaves_like 'a counter caching service'
diff --git a/spec/services/prometheus/adapter_service_spec.rb b/spec/services/prometheus/adapter_service_spec.rb
index 5e972a966eb83ab659df7e896c1f34f69d1f23ff..52e035e1f70613df8cd8a8efd990ac6b07bdd381 100644
--- a/spec/services/prometheus/adapter_service_spec.rb
+++ b/spec/services/prometheus/adapter_service_spec.rb
@@ -4,6 +4,7 @@
describe Prometheus::AdapterService do
let(:project) { create(:project) }
+
subject { described_class.new(project) }
describe '#prometheus_adapter' do
diff --git a/spec/services/quick_actions/interpret_service_spec.rb b/spec/services/quick_actions/interpret_service_spec.rb
index 788f83cc2334a75f65d2979f03f189655d5b7281..16aa74e7780c58b7d75bacaf51f68cf43160a509 100644
--- a/spec/services/quick_actions/interpret_service_spec.rb
+++ b/spec/services/quick_actions/interpret_service_spec.rb
@@ -1370,6 +1370,7 @@
context 'if issuable is a Commit' do
let(:content) { '/award :100:' }
let(:issuable) { commit }
+
it_behaves_like 'empty command'
end
end
@@ -1497,23 +1498,27 @@
context 'if the given label does not exist' do
let(:issuable) { issue }
let(:content) { '/board_move ~"Fake Label"' }
+
it_behaves_like 'empty command', 'Failed to move this issue because label was not found.'
end
context 'if multiple labels are given' do
let(:issuable) { issue }
let(:content) { %{/board_move ~"#{inreview.title}" ~"#{todo.title}"} }
+
it_behaves_like 'empty command', 'Failed to move this issue because only a single label can be provided.'
end
context 'if the given label is not a list on the board' do
let(:issuable) { issue }
let(:content) { %{/board_move ~"#{bug.title}"} }
+
it_behaves_like 'empty command', 'Failed to move this issue because label was not found.'
end
context 'if issuable is not an Issue' do
let(:issuable) { merge_request }
+
it_behaves_like 'empty command'
end
end
diff --git a/spec/services/search/group_service_spec.rb b/spec/services/search/group_service_spec.rb
index aac2f3fe4cbbfba76d9bf03e26cf308f50f73c3e..cfb672753b828a2a153b9bbed15db76f060d15a1 100644
--- a/spec/services/search/group_service_spec.rb
+++ b/spec/services/search/group_service_spec.rb
@@ -20,6 +20,7 @@
let!(:project3) { create(:project, :internal, namespace: nested_group.parent, name: "Outer #{term}") }
let(:results) { described_class.new(user, search_group, search: term).execute }
+
subject { results.objects('projects') }
context 'in parent group' do
diff --git a/spec/services/system_notes/issuables_service_spec.rb b/spec/services/system_notes/issuables_service_spec.rb
index ba484d95c9cc57cbf9758313630573683586cb21..c2f627c681b7a13cb7286c6680f3f5e5e27432a4 100644
--- a/spec/services/system_notes/issuables_service_spec.rb
+++ b/spec/services/system_notes/issuables_service_spec.rb
@@ -618,6 +618,7 @@ def build_note(old_assignees, new_assignees)
context 'when notable is an ExternalIssue' do
let(:noteable) { ExternalIssue.new('EXT-1234', project) }
+
it 'is truthy' do
mentioner = noteable.dup
expect(service.cross_reference_disallowed?(mentioner))
diff --git a/spec/services/todo_service_spec.rb b/spec/services/todo_service_spec.rb
index 0d7e17ad52ca93f67d60a8e73f43082a1d5fdb80..9b92590cb63257a69157d27c4edd82c525a71089 100644
--- a/spec/services/todo_service_spec.rb
+++ b/spec/services/todo_service_spec.rb
@@ -441,6 +441,7 @@
context 'leaving a note on a commit in a public project' do
let(:project) { create(:project, :repository, :public) }
+
it 'creates a todo for each valid mentioned user' do
expected_todo = base_commit_todo_attrs.merge(
action: Todo::MENTIONED,
diff --git a/spec/services/users/keys_count_service_spec.rb b/spec/services/users/keys_count_service_spec.rb
index 6b7493f343fd13faa6ea5db9fe1ebd39be0d70a9..83af051e728d3187398858aae34c166095e28b91 100644
--- a/spec/services/users/keys_count_service_spec.rb
+++ b/spec/services/users/keys_count_service_spec.rb
@@ -4,6 +4,7 @@
describe Users::KeysCountService, :use_clean_rails_memory_store_caching do
let(:user) { create(:user) }
+
subject { described_class.new(user) }
it_behaves_like 'a counter caching service'
diff --git a/spec/services/users/repair_ldap_blocked_service_spec.rb b/spec/services/users/repair_ldap_blocked_service_spec.rb
index 0205b40bc97c97fff147894a630383cb55784f0a..bf80cc79d622ea6929b2a2730f7256fc852ab24f 100644
--- a/spec/services/users/repair_ldap_blocked_service_spec.rb
+++ b/spec/services/users/repair_ldap_blocked_service_spec.rb
@@ -5,6 +5,7 @@
describe Users::RepairLdapBlockedService do
let(:user) { create(:omniauth_user, provider: 'ldapmain', state: 'ldap_blocked') }
let(:identity) { user.ldap_identity }
+
subject(:service) { described_class.new(user) }
describe '#execute' do
diff --git a/spec/services/users/set_status_service_spec.rb b/spec/services/users/set_status_service_spec.rb
index 7c26be483458c582d09d2359eadab3ffdf592fed..554f5e9dc5ece00a091bc133cad7e238c61342f8 100644
--- a/spec/services/users/set_status_service_spec.rb
+++ b/spec/services/users/set_status_service_spec.rb
@@ -4,6 +4,7 @@
describe Users::SetStatusService do
let(:current_user) { create(:user) }
+
subject(:service) { described_class.new(current_user, params) }
describe '#execute' do
diff --git a/spec/services/wikis/create_attachment_service_spec.rb b/spec/services/wikis/create_attachment_service_spec.rb
index f5899f292c898e7be7466f17e6a7844de81491d4..7a73a0a555f9ee81551a5f3d547f236e07bd518e 100644
--- a/spec/services/wikis/create_attachment_service_spec.rb
+++ b/spec/services/wikis/create_attachment_service_spec.rb
@@ -174,6 +174,7 @@
describe '#execute' do
let(:wiki) { project.wiki }
+
subject(:service_execute) { service.execute[:result] }
context 'creates branch if it does not exists' do