From 807308acfb7a77526140ec20736ea619e5e4255c Mon Sep 17 00:00:00 2001
From: Jay <jswain@gitlab.com>
Date: Thu, 2 Dec 2021 05:45:23 +0000
Subject: [PATCH] Fix "What's New" notification dot for Safari

---
 app/assets/stylesheets/framework/header.scss           | 2 +-
 app/assets/stylesheets/startup/startup-dark.scss       | 5 ++++-
 app/assets/stylesheets/startup/startup-general.scss    | 5 ++++-
 app/views/layouts/header/_default.html.haml            | 2 +-
 ee/app/assets/stylesheets/startup/startup-dark.scss    | 5 ++++-
 ee/app/assets/stylesheets/startup/startup-general.scss | 5 ++++-
 6 files changed, 18 insertions(+), 6 deletions(-)

diff --git a/app/assets/stylesheets/framework/header.scss b/app/assets/stylesheets/framework/header.scss
index ae46ff33ec09..44b099fc873d 100644
--- a/app/assets/stylesheets/framework/header.scss
+++ b/app/assets/stylesheets/framework/header.scss
@@ -523,9 +523,9 @@ $top-nav-hover-bg: var(--indigo-900-alpha-008, $indigo-900-alpha-008) !important
   background-color: $orange-300;
   height: 12px;
   width: 12px;
-  margin-top: -15px;
   pointer-events: none;
   visibility: hidden;
+  top: 3px;
 }
 
 .with-notifications .notification-dot {
diff --git a/app/assets/stylesheets/startup/startup-dark.scss b/app/assets/stylesheets/startup/startup-dark.scss
index f95dee962622..0680de32e867 100644
--- a/app/assets/stylesheets/startup/startup-dark.scss
+++ b/app/assets/stylesheets/startup/startup-dark.scss
@@ -912,9 +912,9 @@ input {
   background-color: #9e5400;
   height: 12px;
   width: 12px;
-  margin-top: -15px;
   pointer-events: none;
   visibility: hidden;
+  top: 3px;
 }
 .top-nav-toggle .dropdown-icon {
   margin-right: 0.5rem;
@@ -1953,6 +1953,9 @@ body.gl-dark {
     display: block;
   }
 }
+.gl-relative {
+  position: relative;
+}
 .gl-absolute {
   position: absolute;
 }
diff --git a/app/assets/stylesheets/startup/startup-general.scss b/app/assets/stylesheets/startup/startup-general.scss
index 8ac547de9c09..e6d7185e29c7 100644
--- a/app/assets/stylesheets/startup/startup-general.scss
+++ b/app/assets/stylesheets/startup/startup-general.scss
@@ -893,9 +893,9 @@ input {
   background-color: #d99530;
   height: 12px;
   width: 12px;
-  margin-top: -15px;
   pointer-events: none;
   visibility: hidden;
+  top: 3px;
 }
 .top-nav-toggle .dropdown-icon {
   margin-right: 0.5rem;
@@ -1631,6 +1631,9 @@ svg.s16 {
     display: block;
   }
 }
+.gl-relative {
+  position: relative;
+}
 .gl-absolute {
   position: absolute;
 }
diff --git a/app/views/layouts/header/_default.html.haml b/app/views/layouts/header/_default.html.haml
index 83e8ff79aec4..01dfecb585a7 100644
--- a/app/views/layouts/header/_default.html.haml
+++ b/app/views/layouts/header/_default.html.haml
@@ -94,7 +94,7 @@
                 %span.badge.badge-pill.todos-count.js-todos-count{ class: ('hidden' if todos_pending_count == 0) }
                   = todos_count_format(todos_pending_count)
           %li.nav-item.header-help.dropdown.d-none.d-md-block{ **tracking_attrs('main_navigation', 'click_question_mark_link', 'navigation') }
-            = link_to help_path, class: 'header-help-dropdown-toggle', data: { toggle: "dropdown" } do
+            = link_to help_path, class: 'header-help-dropdown-toggle gl-relative', data: { toggle: "dropdown" } do
               %span.gl-sr-only
                 = s_('Nav|Help')
               = sprite_icon('question-o')
diff --git a/ee/app/assets/stylesheets/startup/startup-dark.scss b/ee/app/assets/stylesheets/startup/startup-dark.scss
index f95dee962622..0680de32e867 100644
--- a/ee/app/assets/stylesheets/startup/startup-dark.scss
+++ b/ee/app/assets/stylesheets/startup/startup-dark.scss
@@ -912,9 +912,9 @@ input {
   background-color: #9e5400;
   height: 12px;
   width: 12px;
-  margin-top: -15px;
   pointer-events: none;
   visibility: hidden;
+  top: 3px;
 }
 .top-nav-toggle .dropdown-icon {
   margin-right: 0.5rem;
@@ -1953,6 +1953,9 @@ body.gl-dark {
     display: block;
   }
 }
+.gl-relative {
+  position: relative;
+}
 .gl-absolute {
   position: absolute;
 }
diff --git a/ee/app/assets/stylesheets/startup/startup-general.scss b/ee/app/assets/stylesheets/startup/startup-general.scss
index 8ac547de9c09..e6d7185e29c7 100644
--- a/ee/app/assets/stylesheets/startup/startup-general.scss
+++ b/ee/app/assets/stylesheets/startup/startup-general.scss
@@ -893,9 +893,9 @@ input {
   background-color: #d99530;
   height: 12px;
   width: 12px;
-  margin-top: -15px;
   pointer-events: none;
   visibility: hidden;
+  top: 3px;
 }
 .top-nav-toggle .dropdown-icon {
   margin-right: 0.5rem;
@@ -1631,6 +1631,9 @@ svg.s16 {
     display: block;
   }
 }
+.gl-relative {
+  position: relative;
+}
 .gl-absolute {
   position: absolute;
 }
-- 
GitLab