From 7fc9441be3d88cafac24d5b972aa1cf9a176ae77 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9my=20Coutable?= <remy@rymai.me> Date: Mon, 15 Apr 2024 17:27:53 +0200 Subject: [PATCH] Quarantine a flaky test The `RemoveWorkItemFromIssuesIndex.migrate migration process when documents are still present in the index removes documents from the index` test has been reported as flaky more then 1000 times. This MR quarantines the test. This is a discussion starting point to let the responsible group know about the flakiness so that they can take action: - accept the merge request and schedule to improve the test - close the merge request in favor of another merge request to delete the test Related to https://gitlab.com/gitlab-org/gitlab/-/issues/448370. This change was generated by [gitlab-housekeeper](https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-housekeeper) using the Keeps::QuarantineFlakyTests keep. To provide feedback on your experience with `gitlab-housekeeper` please comment in <https://gitlab.com/gitlab-org/gitlab/-/issues/442003>. Changelog: other --- .../20240124141337_remove_work_item_from_issues_index_spec.rb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ee/spec/elastic/migrate/20240124141337_remove_work_item_from_issues_index_spec.rb b/ee/spec/elastic/migrate/20240124141337_remove_work_item_from_issues_index_spec.rb index ae48dfea511d4..fc693a5422133 100644 --- a/ee/spec/elastic/migrate/20240124141337_remove_work_item_from_issues_index_spec.rb +++ b/ee/spec/elastic/migrate/20240124141337_remove_work_item_from_issues_index_spec.rb @@ -5,7 +5,8 @@ require File.expand_path('ee/elastic/migrate/20240124141337_remove_work_item_from_issues_index.rb') RSpec.describe RemoveWorkItemFromIssuesIndex, :elastic, :sidekiq_inline, feature_category: :global_search do - include_examples 'migration deletes documents based on schema version' do + include_examples 'migration deletes documents based on schema version', + quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/448370' do let(:version) { 20240124141337 } let(:objects) { create_list(:work_item, 3) } let(:expected_throttle_delay) { 1.minute } -- GitLab