From 71d9b917407e0eaf9d4e3d0bbd89f2bb5e972d54 Mon Sep 17 00:00:00 2001
From: Simon Tomlinson <stomlinson@gitlab.com>
Date: Tue, 23 May 2023 03:48:45 +0000
Subject: [PATCH] Fix spec failure caused by new view added in pg14
---
spec/lib/gitlab/database/pg_depend_spec.rb | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/spec/lib/gitlab/database/pg_depend_spec.rb b/spec/lib/gitlab/database/pg_depend_spec.rb
index 547a2c84b7617..ff5169ebabf29 100644
--- a/spec/lib/gitlab/database/pg_depend_spec.rb
+++ b/spec/lib/gitlab/database/pg_depend_spec.rb
@@ -13,8 +13,14 @@
connection.execute('CREATE EXTENSION IF NOT EXISTS pg_stat_statements;')
end
- it 'returns pg_stat_statements', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/410508' do
- expect(subject.pluck('relname')).to eq(['pg_stat_statements'])
+ it 'returns pg_stat_statements' do
+ expected_views = ['pg_stat_statements']
+
+ if Gitlab::Database::Reflection.new(described_class).version.to_f >= 14
+ expected_views << 'pg_stat_statements_info' # View added by pg_stat_statements starting in postgres 14
+ end
+
+ expect(subject.pluck('relname')).to match_array(expected_views)
end
end
end
--
GitLab