From 71d070417ca9675ce7b763cc9b6269fe8d01e28c Mon Sep 17 00:00:00 2001
From: Peter Leitzen <pleitzen@gitlab.com>
Date: Thu, 4 Nov 2021 10:41:53 +0100
Subject: [PATCH] Remove already disabled RuboCop rule Performance/OpenStruct
This cop has been superseded by Style/OpenStructUse but we forgot to
cleanup Performance/OpenStruct.
---
.rubocop.yml | 4 ----
.rubocop_manual_todo.yml | 14 --------------
2 files changed, 18 deletions(-)
diff --git a/.rubocop.yml b/.rubocop.yml
index 9b5ed0a38c30..dbf657316352 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -708,10 +708,6 @@ Cop/UserAdmin:
- 'spec/**/*.rb'
- 'ee/spec/**/*.rb'
-Performance/OpenStruct:
- Exclude:
- - 'ee/spec/**/*.rb'
-
# See https://gitlab.com/gitlab-org/gitlab/-/issues/327495
Style/RegexpLiteral:
Enabled: false
diff --git a/.rubocop_manual_todo.yml b/.rubocop_manual_todo.yml
index af2714fd660d..9aa9aadd8c0e 100644
--- a/.rubocop_manual_todo.yml
+++ b/.rubocop_manual_todo.yml
@@ -2172,20 +2172,6 @@ Cop/UserAdmin:
- 'lib/gitlab/visibility_level.rb'
- 'qa/qa/runtime/api/client.rb'
-# WIP https://gitlab.com/gitlab-org/gitlab/-/issues/325744
-Performance/OpenStruct:
- Exclude:
- - 'Guardfile'
- - 'app/finders/snippets_finder.rb'
- - 'app/helpers/application_settings_helper.rb'
- - 'ee/lib/gitlab/graphql/aggregations/epics/epic_node.rb'
- - 'ee/lib/gitlab/graphql/aggregations/epics/epic_node.rb'
- - 'lib/api/wikis.rb'
- - 'lib/gitlab/ci/ansi2html.rb'
- - 'lib/gitlab/git/diff_collection.rb'
- - 'lib/gitlab/import_export/after_export_strategies/base_after_export_strategy.rb'
- - 'lib/mattermost/session.rb'
-
# WIP: https://gitlab.com/gitlab-org/gitlab/-/issues/324629
Gitlab/DelegatePredicateMethods:
Exclude:
--
GitLab