From 6ec7e4751f381dc4b1551f7f1b5ec4e2522ae624 Mon Sep 17 00:00:00 2001
From: Kristina Brown <kristinafreybrown@gmail.com>
Date: Thu, 27 Feb 2025 12:46:23 -0800
Subject: [PATCH] Fix SpecifyExpected offenses
---
.rubocop_todo/rspec/specify_expected.yml | 2 --
spec/graphql/resolvers/users/groups_resolver_spec.rb | 10 +++++-----
.../filter/references/design_reference_filter_spec.rb | 2 +-
3 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/.rubocop_todo/rspec/specify_expected.yml b/.rubocop_todo/rspec/specify_expected.yml
index a41270adc352f..21d01b0f890c1 100644
--- a/.rubocop_todo/rspec/specify_expected.yml
+++ b/.rubocop_todo/rspec/specify_expected.yml
@@ -9,8 +9,6 @@ RSpec/SpecifyExpected:
- 'ee/spec/services/security/security_orchestration_policies/update_violations_service_spec.rb'
- 'spec/finders/ci/freeze_periods_finder_spec.rb'
- 'spec/finders/groups/user_groups_finder_spec.rb'
- - 'spec/graphql/resolvers/users/groups_resolver_spec.rb'
- - 'spec/lib/banzai/filter/references/design_reference_filter_spec.rb'
- 'spec/models/integrations/jira_tracker_data_spec.rb'
- 'spec/models/issue_spec.rb'
- 'spec/policies/merge_request_policy_spec.rb'
diff --git a/spec/graphql/resolvers/users/groups_resolver_spec.rb b/spec/graphql/resolvers/users/groups_resolver_spec.rb
index 1e0e001fbf754..0d39be834768e 100644
--- a/spec/graphql/resolvers/users/groups_resolver_spec.rb
+++ b/spec/graphql/resolvers/users/groups_resolver_spec.rb
@@ -32,7 +32,7 @@
context 'when permission is :create_projects' do
let(:group_arguments) { { permission_scope: :create_projects } }
- specify do
+ it 'returns expected groups' do
is_expected.to match(
[
public_maintainer_group,
@@ -47,7 +47,7 @@
context 'when permission is :transfer_projects' do
let(:group_arguments) { { permission_scope: :transfer_projects } }
- specify do
+ it 'returns expected groups' do
is_expected.to match(
[
public_maintainer_group,
@@ -58,7 +58,7 @@
end
end
- specify do
+ it 'returns expected additional groups' do
is_expected.to match(
[
public_maintainer_group,
@@ -73,7 +73,7 @@
context 'when search is provided' do
let(:group_arguments) { { search: 'maintainer' } }
- specify do
+ it 'returns expected groups' do
is_expected.to match(
[
public_maintainer_group,
@@ -96,7 +96,7 @@
enable_admin_mode!(current_user)
end
- specify do
+ it 'returns expected groups' do
is_expected.to match(
[
public_maintainer_group,
diff --git a/spec/lib/banzai/filter/references/design_reference_filter_spec.rb b/spec/lib/banzai/filter/references/design_reference_filter_spec.rb
index 05098e82c92cc..2a13474ad1484 100644
--- a/spec/lib/banzai/filter/references/design_reference_filter_spec.rb
+++ b/spec/lib/banzai/filter/references/design_reference_filter_spec.rb
@@ -131,7 +131,7 @@
describe '#data_attributes_for' do
let(:subject) { filter_instance.data_attributes_for(input_text, project, design) }
- specify do
+ it 'includes expected attributes' do
is_expected.to include(
issue: design.issue_id,
original: input_text,
--
GitLab