From 6d8fc9863e98b0ab2f8f26d990062fda4b310583 Mon Sep 17 00:00:00 2001 From: gdk <gdk@example.com> Date: Sun, 3 Nov 2024 23:23:58 +0000 Subject: [PATCH] Finalize migration BackfillDefaultBranchProtectionSettings This migration was finished at `2024-05-27 16:08:03 UTC`, you can confirm the status using our [batched background migration chatops commands](https://docs.gitlab.com/ee/development/database/batched_background_migrations.html#monitor-the-progress-and-status-of-a-batched-background-migration). To confirm it is finished you can run: ``` /chatops run batched_background_migrations status 1000547 ``` The last time this background migration was triggered was in [db/post_migrate/20240516160731_queue_backfill_default_branch_protection_settings.rb](https://gitlab.com/gitlab-org/gitlab/-/blob/master/db/post_migrate/20240516160731_queue_backfill_default_branch_protection_settings.rb) You can read more about the process for finalizing batched background migrations in https://docs.gitlab.com/ee/development/database/batched_background_migrations.html . As part of our process we want to ensure all batched background migrations have had at least one [required stop](https://docs.gitlab.com/ee/development/database/required_stops.html) to process the migration. Therefore we can finalize any batched background migration that was added before the last required stop. This change was generated by [gitlab-housekeeper](https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-housekeeper) using the Keeps::OverdueFinalizeBackgroundMigration keep. To provide feedback on your experience with `gitlab-housekeeper` please create an issue with the label ~"GitLab Housekeeper" and consider pinging the author of this keep. Changelog: other --- ...ill_default_branch_protection_settings.yml | 5 +++-- ...fill_default_branch_protection_settings.rb | 21 +++++++++++++++++++ db/schema_migrations/20241103232348 | 1 + 3 files changed, 25 insertions(+), 2 deletions(-) create mode 100644 db/post_migrate/20241103232348_finalize_backfill_default_branch_protection_settings.rb create mode 100644 db/schema_migrations/20241103232348 diff --git a/db/docs/batched_background_migrations/backfill_default_branch_protection_settings.yml b/db/docs/batched_background_migrations/backfill_default_branch_protection_settings.yml index 123c0fecf5fba..6a39d9166e50a 100644 --- a/db/docs/batched_background_migrations/backfill_default_branch_protection_settings.yml +++ b/db/docs/batched_background_migrations/backfill_default_branch_protection_settings.yml @@ -1,8 +1,9 @@ --- migration_job_name: BackfillDefaultBranchProtectionSettings -description: This migration backfills column default_branch_protection_defaults of namespace settings table +description: This migration backfills column default_branch_protection_defaults of + namespace settings table feature_category: source_code_management introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/153306 milestone: '17.1' queued_migration_version: 20240516160731 -finalized_by: # version of the migration that finalized this BBM +finalized_by: '20241103232348' diff --git a/db/post_migrate/20241103232348_finalize_backfill_default_branch_protection_settings.rb b/db/post_migrate/20241103232348_finalize_backfill_default_branch_protection_settings.rb new file mode 100644 index 0000000000000..c7c90904aa72a --- /dev/null +++ b/db/post_migrate/20241103232348_finalize_backfill_default_branch_protection_settings.rb @@ -0,0 +1,21 @@ +# frozen_string_literal: true + +class FinalizeBackfillDefaultBranchProtectionSettings < Gitlab::Database::Migration[2.2] + milestone '17.6' + + disable_ddl_transaction! + + restrict_gitlab_migration gitlab_schema: :gitlab_main + + def up + ensure_batched_background_migration_is_finished( + job_class_name: 'BackfillDefaultBranchProtectionSettings', + table_name: :namespaces, + column_name: :id, + job_arguments: [], + finalize: true + ) + end + + def down; end +end diff --git a/db/schema_migrations/20241103232348 b/db/schema_migrations/20241103232348 new file mode 100644 index 0000000000000..1149d61a967d5 --- /dev/null +++ b/db/schema_migrations/20241103232348 @@ -0,0 +1 @@ +c0fc454b6b019729923b587cd6ababe16f7c43c6efc9771e39c986962cd2a65e \ No newline at end of file -- GitLab