diff --git a/qa/qa/specs/features/browser_ui/3_create/merge_request/create_merge_request_from_push_notification_spec.rb b/qa/qa/specs/features/browser_ui/3_create/merge_request/create_merge_request_from_push_notification_spec.rb index ed44017db75069296f061aaed37613aaa7312f29..cabeab9e355dab4d1d32d99d3f6794fe6e3d8347 100644 --- a/qa/qa/specs/features/browser_ui/3_create/merge_request/create_merge_request_from_push_notification_spec.rb +++ b/qa/qa/specs/features/browser_ui/3_create/merge_request/create_merge_request_from_push_notification_spec.rb @@ -2,7 +2,7 @@ module QA RSpec.describe 'Create' do - describe 'Create a new merge request from the event notification after a push', :reliable, + describe 'new merge request from the event notification', :reliable, product_group: :code_review do let(:branch_name) { "merge-request-test-#{SecureRandom.hex(8)}" } let(:title) { "Merge from push event notification test #{SecureRandom.hex(8)}" } @@ -13,7 +13,7 @@ module QA end it( - 'creates a merge request after a push via the git CLI', + 'after a push via the git CLI creates a merge request', testcase: 'https://gitlab.com/gitlab-org/gitlab/-/quality/test_cases/360489' ) do Resource::Repository::ProjectPush.fabricate! do |push| @@ -34,7 +34,7 @@ module QA end it( - 'creates a merge request after a push via the API', + 'after a push via the API creates a merge request', testcase: 'https://gitlab.com/gitlab-org/gitlab/-/quality/test_cases/360490' ) do commit = Resource::Repository::Commit.fabricate_via_api! do |resource| diff --git a/qa/qa/specs/features/browser_ui/3_create/repository/push_protected_branch_spec.rb b/qa/qa/specs/features/browser_ui/3_create/repository/push_protected_branch_spec.rb index b06879e9140b7483a135bf9dd65a3ec76b73cfbc..1db253b03f548153514d7c2b133f7ceb0d9d1fb9 100644 --- a/qa/qa/specs/features/browser_ui/3_create/repository/push_protected_branch_spec.rb +++ b/qa/qa/specs/features/browser_ui/3_create/repository/push_protected_branch_spec.rb @@ -13,7 +13,7 @@ module QA end context 'when developers and maintainers are allowed to push to a protected branch' do - it 'user with push rights successfully pushes to the protected branch', testcase: 'https://gitlab.com/gitlab-org/gitlab/-/quality/test_cases/347756' do + it 'user with push rights successfully pushes', testcase: 'https://gitlab.com/gitlab-org/gitlab/-/quality/test_cases/347756' do create_protected_branch(allowed_to_push: { roles: Resource::ProtectedBranch::Roles::DEVS_AND_MAINTAINERS }) @@ -25,7 +25,7 @@ module QA end context 'when developers and maintainers are not allowed to push to a protected branch' do - it 'user without push rights fails to push to the protected branch', testcase: 'https://gitlab.com/gitlab-org/gitlab/-/quality/test_cases/347757' do + it 'user without push rights fails to push', testcase: 'https://gitlab.com/gitlab-org/gitlab/-/quality/test_cases/347757' do create_protected_branch(allowed_to_push: { roles: Resource::ProtectedBranch::Roles::NO_ONE }) diff --git a/qa/qa/specs/features/browser_ui/3_create/snippet/copy_snippet_file_contents_spec.rb b/qa/qa/specs/features/browser_ui/3_create/snippet/copy_snippet_file_contents_spec.rb index 667601b7bcab0eb9153e67695b1c50906111062a..2c33d777b0fe96a3c8dd95f5e4c34fc5043f1395 100644 --- a/qa/qa/specs/features/browser_ui/3_create/snippet/copy_snippet_file_contents_spec.rb +++ b/qa/qa/specs/features/browser_ui/3_create/snippet/copy_snippet_file_contents_spec.rb @@ -51,7 +51,7 @@ module QA end shared_examples 'copying snippet file contents' do |snippet_type, testcase| - it "copies file contents of a multi-file #{snippet_type} to a comment and verifies them", testcase: testcase do + it "copies a multi-file #{snippet_type} to a comment and verifies them", testcase: testcase do send(snippet_type).visit! files.each do |files|