diff --git a/.rubocop_manual_todo.yml b/.rubocop_manual_todo.yml
index d0079ae650e77eda5564fd8be8b84c2a9f21f16b..a8fc8d0ee232dabccdc2b936ff7412de2d62c69c 100644
--- a/.rubocop_manual_todo.yml
+++ b/.rubocop_manual_todo.yml
@@ -336,403 +336,6 @@ Rails/TimeZone:
# WIP: https://gitlab.com/gitlab-org/gitlab/-/issues/325836
RSpec/EmptyLineAfterFinalLetItBe:
Exclude:
- - ee/spec/controllers/subscriptions_controller_spec.rb
- - ee/spec/features/ci_shared_runner_warnings_spec.rb
- - ee/spec/features/integrations/jira/jira_issues_list_spec.rb
- - ee/spec/features/markdown/metrics_spec.rb
- - ee/spec/features/registrations/group_invites_during_signup_flow_spec.rb
- - ee/spec/features/subscriptions_spec.rb
- - ee/spec/lib/ee/api/entities/user_with_admin_spec.rb
- - ee/spec/lib/ee/api/entities/vulnerability_spec.rb
- - ee/spec/lib/ee/event_filter_spec.rb
- - ee/spec/lib/ee/gitlab/alert_management/payload/generic_spec.rb
- - ee/spec/lib/ee/gitlab/alert_management/payload_spec.rb
- - ee/spec/lib/ee/gitlab/ci/pipeline/chain/validate/external_spec.rb
- - ee/spec/lib/ee/gitlab/ci/pipeline/quota/activity_spec.rb
- - ee/spec/lib/ee/gitlab/ci/pipeline/quota/job_activity_spec.rb
- - ee/spec/lib/ee/gitlab/ci/pipeline/quota/size_spec.rb
- - ee/spec/lib/ee/gitlab/git_access_design_spec.rb
- - ee/spec/lib/ee/gitlab/git_access_snippet_spec.rb
- - ee/spec/lib/ee/gitlab/hook_data/issue_builder_spec.rb
- - ee/spec/lib/ee/gitlab/import_export/project/tree_restorer_spec.rb
- - ee/spec/lib/ee/gitlab/snippet_search_results_spec.rb
- - ee/spec/lib/elastic/latest/git_class_proxy_spec.rb
- - ee/spec/lib/gitlab/alert_management/payload/cilium_spec.rb
- - ee/spec/lib/gitlab/analytics/cycle_analytics/summary/group/stage_time_summary_spec.rb
- - ee/spec/lib/gitlab/checks/diff_check_spec.rb
- - ee/spec/lib/gitlab/code_owners/loader_spec.rb
- - ee/spec/lib/gitlab/git_access_spec.rb
- - ee/spec/lib/gitlab/git_access_wiki_spec.rb
- - ee/spec/lib/gitlab/graphql/aggregations/vulnerability_statistics/lazy_aggregate_spec.rb
- - ee/spec/lib/gitlab/insights/project_insights_config_spec.rb
- - ee/spec/lib/gitlab/sitemaps/url_extractor_spec.rb
- - ee/spec/requests/api/analytics/code_review_analytics_spec.rb
- - ee/spec/requests/api/audit_events_spec.rb
- - ee/spec/requests/api/commits_spec.rb
- - ee/spec/requests/api/dora/metrics_spec.rb
- - ee/spec/requests/api/epics_spec.rb
- - ee/spec/requests/api/geo_spec.rb
- - ee/spec/requests/api/graphql/boards/epic_board_list_epics_query_spec.rb
- - ee/spec/requests/api/graphql/current_user/todos_query_spec.rb
- - ee/spec/requests/api/graphql/group/epic/epic_issues_spec.rb
- - ee/spec/requests/api/graphql/group/epics_spec.rb
- - ee/spec/requests/api/graphql/mutations/analytics/devops_adoption/segments/create_spec.rb
- - ee/spec/requests/api/graphql/mutations/analytics/devops_adoption/segments/delete_spec.rb
- - ee/spec/requests/api/graphql/mutations/boards/create_spec.rb
- - ee/spec/requests/api/graphql/mutations/boards/epic_boards/create_spec.rb
- - ee/spec/requests/api/graphql/mutations/boards/epic_boards/update_spec.rb
- - ee/spec/requests/api/graphql/mutations/boards/issues/issue_move_list_spec.rb
- - ee/spec/requests/api/graphql/mutations/boards/lists/update_limit_metrics_spec.rb
- - ee/spec/requests/api/graphql/mutations/compliance_management/frameworks/destroy_spec.rb
- - ee/spec/requests/api/graphql/mutations/compliance_management/frameworks/update_spec.rb
- - ee/spec/requests/api/graphql/mutations/dast_scanner_profiles/update_spec.rb
- - ee/spec/requests/api/graphql/mutations/environments/canary_ingress/update_spec.rb
- - ee/spec/requests/api/graphql/mutations/epics/add_issue_spec.rb
- - ee/spec/requests/api/graphql/mutations/epics/set_subscription_spec.rb
- - ee/spec/requests/api/graphql/mutations/epics/update_spec.rb
- - ee/spec/requests/api/graphql/mutations/gitlab_subscriptions/activate_spec.rb
- - ee/spec/requests/api/graphql/mutations/incident_management/oncall_rotation/create_spec.rb
- - ee/spec/requests/api/graphql/mutations/incident_management/oncall_schedule/create_spec.rb
- - ee/spec/requests/api/graphql/mutations/incident_management/oncall_schedule/destroy_spec.rb
- - ee/spec/requests/api/graphql/mutations/incident_management/oncall_schedule/update_spec.rb
- - ee/spec/requests/api/graphql/mutations/issues/promote_to_epic_spec.rb
- - ee/spec/requests/api/graphql/mutations/issues/update_spec.rb
- - ee/spec/requests/api/graphql/mutations/iterations/create_spec.rb
- - ee/spec/requests/api/graphql/mutations/notes/create/note_spec.rb
- - ee/spec/requests/api/graphql/mutations/quality_management/test_cases/create_spec.rb
- - ee/spec/requests/api/graphql/namespace/compliance_frameworks_spec.rb
- - ee/spec/requests/api/graphql/project/alert_management/payload_fields_spec.rb
- - ee/spec/requests/api/graphql/project/requirements_management/requirements_spec.rb
- - ee/spec/requests/api/graphql/projects/compliance_frameworks_spec.rb
- - ee/spec/requests/api/groups_spec.rb
- - ee/spec/requests/api/internal/base_spec.rb
- - ee/spec/requests/api/issues_spec.rb
- - ee/spec/requests/api/ldap_spec.rb
- - ee/spec/requests/api/merge_request_approval_rules_spec.rb
- - ee/spec/requests/api/merge_request_approvals_spec.rb
- - ee/spec/requests/api/merge_requests_spec.rb
- - ee/spec/requests/api/merge_trains_spec.rb
- - ee/spec/requests/api/project_approval_rules_spec.rb
- - ee/spec/requests/api/project_approval_settings_spec.rb
- - ee/spec/requests/api/projects_spec.rb
- - ee/spec/requests/api/todos_spec.rb
- - ee/spec/requests/api/vulnerabilities_spec.rb
- - ee/spec/requests/api/vulnerability_issue_links_spec.rb
- - ee/spec/requests/api/wikis_spec.rb
- - ee/spec/requests/callout_spec.rb
- - ee/spec/requests/git_http_geo_spec.rb
- - ee/spec/requests/repositories/git_http_controller_spec.rb
- - ee/spec/services/alert_management/extract_alert_payload_fields_service_spec.rb
- - ee/spec/services/alert_management/process_prometheus_alert_service_spec.rb
- - ee/spec/services/approval_rules/create_service_spec.rb
- - ee/spec/services/audit_event_service_spec.rb
- - ee/spec/services/billable_members/destroy_service_spec.rb
- - ee/spec/services/boards/epic_boards/destroy_service_spec.rb
- - ee/spec/services/clusters/agent_tokens/create_service_spec.rb
- - ee/spec/services/compliance_management/frameworks/create_service_spec.rb
- - ee/spec/services/compliance_management/frameworks/update_service_spec.rb
- - ee/spec/services/dast_scanner_profiles/destroy_service_spec.rb
- - ee/spec/services/dast_scanner_profiles/update_service_spec.rb
- - ee/spec/services/dast_site_profiles/destroy_service_spec.rb
- - ee/spec/services/external_status_checks/create_service_spec.rb
- - ee/spec/services/external_status_checks/destroy_service_spec.rb
- - ee/spec/services/external_status_checks/update_service_spec.rb
- - ee/spec/services/gitlab_subscriptions/activate_service_spec.rb
- - ee/spec/services/gitlab_subscriptions/apply_trial_service_spec.rb
- - ee/spec/services/incident_management/incidents/upload_metric_service_spec.rb
- - ee/spec/services/incident_management/oncall_rotations/edit_service_spec.rb
- - ee/spec/services/merge_request_approval_settings/update_service_spec.rb
- - ee/spec/services/personal_access_tokens/create_service_audit_log_spec.rb
- - ee/spec/services/personal_access_tokens/groups/update_lifetime_service_spec.rb
- - ee/spec/services/push_rules/create_or_update_service_spec.rb
- - ee/spec/services/quality_management/test_cases/create_service_spec.rb
- - ee/spec/services/quick_actions/interpret_service_spec.rb
- - ee/spec/services/requirements_management/create_requirement_service_spec.rb
- - ee/spec/services/requirements_management/export_csv_service_spec.rb
- - ee/spec/services/requirements_management/update_requirement_service_spec.rb
- - ee/spec/services/resource_access_tokens/create_service_spec.rb
- - ee/spec/services/resource_access_tokens/revoke_service_spec.rb
- - spec/controllers/confirmations_controller_spec.rb
- - spec/controllers/dashboard/projects_controller_spec.rb
- - spec/controllers/invites_controller_spec.rb
- - spec/controllers/profiles/emails_controller_spec.rb
- - spec/controllers/users/terms_controller_spec.rb
- - spec/features/cycle_analytics_spec.rb
- - spec/features/dashboard/datetime_on_tooltips_spec.rb
- - spec/features/dashboard/merge_requests_spec.rb
- - spec/features/file_uploads/group_import_spec.rb
- - spec/features/file_uploads/project_import_spec.rb
- - spec/features/file_uploads/user_avatar_spec.rb
- - spec/features/issues/user_sees_breadcrumb_links_spec.rb
- - spec/features/markdown/metrics_spec.rb
- - spec/features/operations_sidebar_link_spec.rb
- - spec/features/participants_autocomplete_spec.rb
- - spec/features/snippets/embedded_snippet_spec.rb
- - spec/finders/alert_management/alerts_finder_spec.rb
- - spec/finders/ci/commit_statuses_finder_spec.rb
- - spec/finders/container_repositories_finder_spec.rb
- - spec/finders/deployments_finder_spec.rb
- - spec/finders/events_finder_spec.rb
- - spec/finders/group_descendants_finder_spec.rb
- - spec/finders/groups_finder_spec.rb
- - spec/finders/packages/conan/package_file_finder_spec.rb
- - spec/finders/packages/go/module_finder_spec.rb
- - spec/finders/packages/group_packages_finder_spec.rb
- - spec/finders/packages/nuget/package_finder_spec.rb
- - spec/finders/packages/package_file_finder_spec.rb
- - spec/finders/packages/package_finder_spec.rb
- - spec/finders/template_finder_spec.rb
- - spec/finders/todos_finder_spec.rb
- - spec/finders/user_recent_events_finder_spec.rb
- - spec/frontend/fixtures/pipelines.rb
- - spec/graphql/features/authorization_spec.rb
- - spec/graphql/gitlab_schema_spec.rb
- - spec/graphql/mutations/boards/lists/update_spec.rb
- - spec/graphql/mutations/custom_emoji/create_spec.rb
- - spec/graphql/mutations/discussions/toggle_resolve_spec.rb
- - spec/graphql/mutations/environments/canary_ingress/update_spec.rb
- - spec/graphql/mutations/issues/set_severity_spec.rb
- - spec/graphql/mutations/labels/create_spec.rb
- - spec/graphql/mutations/notes/reposition_image_diff_note_spec.rb
- - spec/lib/bulk_imports/groups/loaders/group_loader_spec.rb
- - spec/lib/extracts_path_spec.rb
- - spec/lib/extracts_ref_spec.rb
- - spec/lib/gitlab/cache/ci/project_pipeline_status_spec.rb
- - spec/lib/gitlab/closing_issue_extractor_spec.rb
- - spec/lib/gitlab/composer/cache_spec.rb
- - spec/lib/gitlab/data_builder/wiki_page_spec.rb
- - spec/lib/gitlab/deploy_key_access_spec.rb
- - spec/lib/gitlab/email/handler/service_desk_handler_spec.rb
- - spec/lib/gitlab/gitaly_client/operation_service_spec.rb
- - spec/lib/gitlab/gl_repository/repo_type_spec.rb
- - spec/lib/gitlab/group_search_results_spec.rb
- - spec/lib/gitlab/json_cache_spec.rb
- - spec/lib/gitlab/language_detection_spec.rb
- - spec/lib/gitlab/project_search_results_spec.rb
- - spec/lib/gitlab/prometheus/query_variables_spec.rb
- - spec/lib/gitlab/reactive_cache_set_cache_spec.rb
- - spec/lib/gitlab/reference_extractor_spec.rb
- - spec/lib/gitlab/search_results_spec.rb
- - spec/lib/gitlab/shell_spec.rb
- - spec/models/abuse_report_spec.rb
- - spec/models/alert_management/alert_spec.rb
- - spec/models/audit_event_spec.rb
- - spec/models/chat_name_spec.rb
- - spec/models/chat_team_spec.rb
- - spec/models/clusters/kubernetes_namespace_spec.rb
- - spec/models/commit_spec.rb
- - spec/models/deploy_token_spec.rb
- - spec/models/deployment_spec.rb
- - spec/models/diff_viewer/server_side_spec.rb
- - spec/models/environment_spec.rb
- - spec/models/event_collection_spec.rb
- - spec/models/label_note_spec.rb
- - spec/models/lfs_file_lock_spec.rb
- - spec/models/member_spec.rb
- - spec/models/merge_request_diff_spec.rb
- - spec/models/namespace/root_storage_statistics_spec.rb
- - spec/models/note_spec.rb
- - spec/models/notification_setting_spec.rb
- - spec/models/operations/feature_flag_spec.rb
- - spec/models/plan_limits_spec.rb
- - spec/models/prometheus_alert_spec.rb
- - spec/models/protected_branch/push_access_level_spec.rb
- - spec/models/repository_spec.rb
- - spec/models/snippet_repository_spec.rb
- - spec/models/snippet_spec.rb
- - spec/models/terraform/state_spec.rb
- - spec/models/u2f_registration_spec.rb
- - spec/models/user_spec.rb
- - spec/requests/api/api_spec.rb
- - spec/requests/api/award_emoji_spec.rb
- - spec/requests/api/branches_spec.rb
- - spec/requests/api/ci/pipelines_spec.rb
- - spec/requests/api/composer_packages_spec.rb
- - spec/requests/api/deploy_tokens_spec.rb
- - spec/requests/api/deployments_spec.rb
- - spec/requests/api/error_tracking_spec.rb
- - spec/requests/api/feature_flags_spec.rb
- - spec/requests/api/freeze_periods_spec.rb
- - spec/requests/api/generic_packages_spec.rb
- - spec/requests/api/graphql/boards/board_lists_query_spec.rb
- - spec/requests/api/graphql/ci/pipelines_spec.rb
- - spec/requests/api/graphql/current_user_todos_spec.rb
- - spec/requests/api/graphql/group/timelogs_spec.rb
- - spec/requests/api/graphql/issue_status_counts_spec.rb
- - spec/requests/api/graphql/metrics/dashboard_query_spec.rb
- - spec/requests/api/graphql/mutations/admin/sidekiq_queues/delete_jobs_spec.rb
- - spec/requests/api/graphql/mutations/alert_management/alerts/set_assignees_spec.rb
- - spec/requests/api/graphql/mutations/alert_management/alerts/todo/create_spec.rb
- - spec/requests/api/graphql/mutations/alert_management/alerts/update_alert_status_spec.rb
- - spec/requests/api/graphql/mutations/alert_management/http_integration/create_spec.rb
- - spec/requests/api/graphql/mutations/alert_management/prometheus_integration/create_spec.rb
- - spec/requests/api/graphql/mutations/award_emojis/add_spec.rb
- - spec/requests/api/graphql/mutations/award_emojis/toggle_spec.rb
- - spec/requests/api/graphql/mutations/boards/create_spec.rb
- - spec/requests/api/graphql/mutations/boards/destroy_spec.rb
- - spec/requests/api/graphql/mutations/boards/lists/destroy_spec.rb
- - spec/requests/api/graphql/mutations/boards/lists/update_spec.rb
- - spec/requests/api/graphql/mutations/branches/create_spec.rb
- - spec/requests/api/graphql/mutations/ci/ci_cd_settings_update_spec.rb
- - spec/requests/api/graphql/mutations/commits/create_spec.rb
- - spec/requests/api/graphql/mutations/container_expiration_policy/update_spec.rb
- - spec/requests/api/graphql/mutations/discussions/toggle_resolve_spec.rb
- - spec/requests/api/graphql/mutations/environments/canary_ingress/update_spec.rb
- - spec/requests/api/graphql/mutations/issues/set_locked_spec.rb
- - spec/requests/api/graphql/mutations/issues/set_severity_spec.rb
- - spec/requests/api/graphql/mutations/issues/update_spec.rb
- - spec/requests/api/graphql/mutations/jira_import/import_users_spec.rb
- - spec/requests/api/graphql/mutations/jira_import/start_spec.rb
- - spec/requests/api/graphql/mutations/labels/create_spec.rb
- - spec/requests/api/graphql/mutations/merge_requests/accept_spec.rb
- - spec/requests/api/graphql/mutations/merge_requests/create_spec.rb
- - spec/requests/api/graphql/mutations/metrics/dashboard/annotations/create_spec.rb
- - spec/requests/api/graphql/mutations/namespace/package_settings/update_spec.rb
- - spec/requests/api/graphql/mutations/notes/create/diff_note_spec.rb
- - spec/requests/api/graphql/mutations/notes/create/image_diff_note_spec.rb
- - spec/requests/api/graphql/mutations/notes/create/note_spec.rb
- - spec/requests/api/graphql/mutations/notes/reposition_image_diff_note_spec.rb
- - spec/requests/api/graphql/mutations/notes/update/image_diff_note_spec.rb
- - spec/requests/api/graphql/mutations/snippets/mark_as_spam_spec.rb
- - spec/requests/api/graphql/mutations/snippets/update_spec.rb
- - spec/requests/api/graphql/mutations/user_callouts/create_spec.rb
- - spec/requests/api/graphql/namespace/package_settings_spec.rb
- - spec/requests/api/graphql/project/alert_management/alert/issue_spec.rb
- - spec/requests/api/graphql/project/alert_management/alert_status_counts_spec.rb
- - spec/requests/api/graphql/project/error_tracking/sentry_detailed_error_request_spec.rb
- - spec/requests/api/graphql/project/error_tracking/sentry_errors_request_spec.rb
- - spec/requests/api/graphql/project/issue/designs/designs_spec.rb
- - spec/requests/api/graphql/project/project_pipeline_statistics_spec.rb
- - spec/requests/api/graphql/project_query_spec.rb
- - spec/requests/api/graphql/query_spec.rb
- - spec/requests/api/graphql/user/starred_projects_query_spec.rb
- - spec/requests/api/graphql/user_query_spec.rb
- - spec/requests/api/graphql_spec.rb
- - spec/requests/api/group_import_spec.rb
- - spec/requests/api/group_milestones_spec.rb
- - spec/requests/api/group_packages_spec.rb
- - spec/requests/api/groups_spec.rb
- - spec/requests/api/helpers_spec.rb
- - spec/requests/api/import_bitbucket_server_spec.rb
- - spec/requests/api/internal/base_spec.rb
- - spec/requests/api/lint_spec.rb
- - spec/requests/api/markdown_spec.rb
- - spec/requests/api/merge_requests_spec.rb
- - spec/requests/api/metrics/dashboard/annotations_spec.rb
- - spec/requests/api/metrics/user_starred_dashboards_spec.rb
- - spec/requests/api/nuget_project_packages_spec.rb
- - spec/requests/api/project_clusters_spec.rb
- - spec/requests/api/project_container_repositories_spec.rb
- - spec/requests/api/project_milestones_spec.rb
- - spec/requests/api/project_packages_spec.rb
- - spec/requests/api/pypi_packages_spec.rb
- - spec/requests/api/rubygem_packages_spec.rb
- - spec/requests/api/unleash_spec.rb
- - spec/requests/api/users_spec.rb
- - spec/requests/groups/email_campaigns_controller_spec.rb
- - spec/requests/import/gitlab_groups_controller_spec.rb
- - spec/requests/jwt_controller_spec.rb
- - spec/requests/lfs_http_spec.rb
- - spec/requests/product_analytics/collector_app_spec.rb
- - spec/requests/rack_attack_global_spec.rb
- - spec/services/admin/propagate_service_template_spec.rb
- - spec/services/alert_management/create_alert_issue_service_spec.rb
- - spec/services/audit_event_service_spec.rb
- - spec/services/auth/dependency_proxy_authentication_service_spec.rb
- - spec/services/auto_merge_service_spec.rb
- - spec/services/bulk_create_integration_service_spec.rb
- - spec/services/clusters/applications/prometheus_health_check_service_spec.rb
- - spec/services/container_expiration_policy_service_spec.rb
- - spec/services/dependency_proxy/find_or_create_manifest_service_spec.rb
- - spec/services/discussions/resolve_service_spec.rb
- - spec/services/discussions/unresolve_service_spec.rb
- - spec/services/git/branch_push_service_spec.rb
- - spec/services/import/bitbucket_server_service_spec.rb
- - spec/services/incident_management/incidents/create_service_spec.rb
- - spec/services/incident_management/pager_duty/create_incident_issue_service_spec.rb
- - spec/services/incident_management/pager_duty/process_webhook_service_spec.rb
- - spec/services/integrations/test/project_service_spec.rb
- - spec/services/issuable/bulk_update_service_spec.rb
- - spec/services/jira_connect/sync_service_spec.rb
- - spec/services/jira_import/start_import_service_spec.rb
- - spec/services/jira_import/users_importer_spec.rb
- - spec/services/markdown_content_rewriter_service_spec.rb
- - spec/services/members/create_service_spec.rb
- - spec/services/members/invite_service_spec.rb
- - spec/services/metrics/dashboard/annotations/create_service_spec.rb
- - spec/services/metrics/dashboard/gitlab_alert_embed_service_spec.rb
- - spec/services/metrics/users_starred_dashboards/create_service_spec.rb
- - spec/services/notes/copy_service_spec.rb
- - spec/services/notes/create_service_spec.rb
- - spec/services/notes/destroy_service_spec.rb
- - spec/services/notes/quick_actions_service_spec.rb
- - spec/services/notes/update_service_spec.rb
- - spec/services/notification_service_spec.rb
- - spec/services/packages/composer/create_package_service_spec.rb
- - spec/services/packages/conan/search_service_spec.rb
- - spec/services/packages/create_package_file_service_spec.rb
- - spec/services/packages/debian/find_or_create_package_service_spec.rb
- - spec/services/packages/generic/create_package_file_service_spec.rb
- - spec/services/packages/maven/find_or_create_package_service_spec.rb
- - spec/services/packages/nuget/search_service_spec.rb
- - spec/services/packages/rubygems/dependency_resolver_service_spec.rb
- - spec/services/pod_logs/base_service_spec.rb
- - spec/services/pod_logs/elasticsearch_service_spec.rb
- - spec/services/pod_logs/kubernetes_service_spec.rb
- - spec/services/projects/alerting/notify_service_spec.rb
- - spec/services/projects/create_service_spec.rb
- - spec/services/projects/destroy_rollback_service_spec.rb
- - spec/services/projects/destroy_service_spec.rb
- - spec/services/projects/gitlab_projects_import_service_spec.rb
- - spec/services/projects/group_links/create_service_spec.rb
- - spec/services/projects/group_links/destroy_service_spec.rb
- - spec/services/projects/group_links/update_service_spec.rb
- - spec/services/projects/prometheus/alerts/notify_service_spec.rb
- - spec/services/projects/transfer_service_spec.rb
- - spec/services/projects/update_pages_service_spec.rb
- - spec/services/prometheus/create_default_alerts_service_spec.rb
- - spec/services/quick_actions/interpret_service_spec.rb
- - spec/services/releases/create_evidence_service_spec.rb
- - spec/services/repositories/destroy_rollback_service_spec.rb
- - spec/services/repositories/destroy_service_spec.rb
- - spec/services/repositories/shell_destroy_service_spec.rb
- - spec/services/resource_access_tokens/create_service_spec.rb
- - spec/services/resource_access_tokens/revoke_service_spec.rb
- - spec/services/resource_events/change_labels_service_spec.rb
- - spec/services/resource_events/merge_into_notes_service_spec.rb
- - spec/services/security/ci_configuration/sast_create_service_spec.rb
- - spec/services/snippets/bulk_destroy_service_spec.rb
- - spec/services/snippets/create_service_spec.rb
- - spec/services/snippets/update_service_spec.rb
- - spec/services/spam/ham_service_spec.rb
- - spec/services/spam/spam_action_service_spec.rb
- - spec/services/spam/spam_verdict_service_spec.rb
- - spec/services/system_note_service_spec.rb
- - spec/services/system_notes/issuables_service_spec.rb
- - spec/services/test_hooks/project_service_spec.rb
- - spec/services/test_hooks/system_service_spec.rb
- - spec/services/users/approve_service_spec.rb
- - spec/services/users/reject_service_spec.rb
- - spec/services/users/validate_otp_service_spec.rb
- - spec/services/wiki_pages/event_create_service_spec.rb
- - spec/support/shared_examples/graphql/design_fields_shared_examples.rb
- - spec/support/shared_examples/graphql/mutations/set_assignees_shared_examples.rb
- - spec/support/shared_examples/quick_actions/issuable/issuable_quick_actions_shared_examples.rb
- - spec/support/shared_examples/services/container_registry_auth_service_shared_examples.rb
- - spec/support/shared_examples/services/packages_shared_examples.rb
- - spec/tasks/gitlab/db_rake_spec.rb
- - spec/tasks/gitlab/packages/composer_rake_spec.rb
- - spec/tasks/gitlab/snippets_rake_spec.rb
- - spec/uploaders/content_type_whitelist_spec.rb
- - spec/uploaders/dependency_proxy/file_uploader_spec.rb
- - spec/views/admin/application_settings/_eks.html.haml_spec.rb
- - spec/views/admin/application_settings/_package_registry.html.haml_spec.rb
- - spec/views/layouts/nav/sidebar/_project_security_link.html.haml_spec.rb
- - spec/views/projects/pipelines/new.html.haml_spec.rb
- - spec/views/projects/pipelines/show.html.haml_spec.rb
- - spec/views/search/_results.html.haml_spec.rb
- - spec/views/shared/_label_row.html.haml_spec.rb
- - spec/views/shared/milestones/_top.html.haml_spec.rb
RSpec/TimecopFreeze:
Exclude:
diff --git a/ee/spec/features/ci_shared_runner_warnings_spec.rb b/ee/spec/features/ci_shared_runner_warnings_spec.rb
index 367b1d727d46dbe86be9c1b9ded711dfb54d826c..6b6e376eb608d68284ef746aa339ee5ea30580c5 100644
--- a/ee/spec/features/ci_shared_runner_warnings_spec.rb
+++ b/ee/spec/features/ci_shared_runner_warnings_spec.rb
@@ -6,6 +6,7 @@
using RSpec::Parameterized::TableSyntax
let_it_be(:user) { create(:user) }
+
let(:project) { create(:project, :repository, namespace: group, shared_runners_enabled: true) }
let(:group) { create(:group) }
let(:pipeline) { create(:ci_empty_pipeline, project: project, sha: project.commit.sha, ref: 'master') }
diff --git a/ee/spec/features/integrations/jira/jira_issues_list_spec.rb b/ee/spec/features/integrations/jira/jira_issues_list_spec.rb
index 340894c43d3bdfa8893b1cee72da4c2fd182f763..a0ca0f476ee01871bf19c3b640bfb62dea03da11 100644
--- a/ee/spec/features/integrations/jira/jira_issues_list_spec.rb
+++ b/ee/spec/features/integrations/jira/jira_issues_list_spec.rb
@@ -5,6 +5,7 @@
RSpec.describe 'Jira issues list' do
let_it_be(:project, refind: true) { create(:project) }
let_it_be(:jira_integration) { create(:jira_integration, project: project, issues_enabled: true, project_key: 'GL') }
+
let(:user) { create(:user) }
before do
diff --git a/ee/spec/features/markdown/metrics_spec.rb b/ee/spec/features/markdown/metrics_spec.rb
index 11cdeabd7b60316afb704649d359b4124f7e5765..4f6bcf5030b51e893f8fc0b7e20bea8cca380bdb 100644
--- a/ee/spec/features/markdown/metrics_spec.rb
+++ b/ee/spec/features/markdown/metrics_spec.rb
@@ -85,6 +85,7 @@
end
let_it_be(:cluster) { create(:cluster, :provided_by_gcp, :project, projects: [project], user: user) }
+
let(:params) { [project.namespace.path, project.path, cluster.id] }
let(:query_params) { { group: 'Cluster Health', title: 'CPU Usage', y_label: 'CPU (cores)' } }
let(:metrics_url) { urls.metrics_namespace_project_cluster_url(*params, **query_params) }
diff --git a/ee/spec/features/registrations/group_invites_during_signup_flow_spec.rb b/ee/spec/features/registrations/group_invites_during_signup_flow_spec.rb
index 45c40ba9e3d8a4765b2152f4a076949ed8aa9bb6..29f75a2d2c9555be3c93d311676ab14d202eec7e 100644
--- a/ee/spec/features/registrations/group_invites_during_signup_flow_spec.rb
+++ b/ee/spec/features/registrations/group_invites_during_signup_flow_spec.rb
@@ -6,6 +6,7 @@
include Select2Helper
let_it_be(:user) { create(:user, setup_for_company: true) }
+
let(:path_params) { {} }
before do
diff --git a/ee/spec/lib/ee/api/entities/user_with_admin_spec.rb b/ee/spec/lib/ee/api/entities/user_with_admin_spec.rb
index cb2b2499c691a6a5f39bab04f5c32beb49735909..c231d4354ca21798de0ceacab8f354b844f5593e 100644
--- a/ee/spec/lib/ee/api/entities/user_with_admin_spec.rb
+++ b/ee/spec/lib/ee/api/entities/user_with_admin_spec.rb
@@ -6,6 +6,7 @@
subject { entity.as_json }
let_it_be(:user) { create(:user) }
+
let(:entity) { ::API::Entities::UserWithAdmin.new(user) }
context 'using_license_seat' do
diff --git a/ee/spec/lib/ee/api/entities/vulnerability_spec.rb b/ee/spec/lib/ee/api/entities/vulnerability_spec.rb
index 2b1a69056fe4e3bd0f7f154e78747ce57a38f2d5..e712f517eeafe96b43f6514023f0dcb54d818800 100644
--- a/ee/spec/lib/ee/api/entities/vulnerability_spec.rb
+++ b/ee/spec/lib/ee/api/entities/vulnerability_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe ::EE::API::Entities::Vulnerability do
let_it_be(:project) { create(:project, :with_vulnerability) }
+
let(:vulnerability) { project.vulnerabilities.first }
subject { described_class.new(vulnerability).as_json }
diff --git a/ee/spec/lib/ee/event_filter_spec.rb b/ee/spec/lib/ee/event_filter_spec.rb
index fb66be99aa7787951be72012df82343f1cf96f72..0cd849e8399eb4e39f974bab131adb42ff649bc0 100644
--- a/ee/spec/lib/ee/event_filter_spec.rb
+++ b/ee/spec/lib/ee/event_filter_spec.rb
@@ -8,6 +8,7 @@
let_it_be(:project) { create(:project, :public) }
let_it_be(:epic_event) { create(:event, :created, group: group, target: create(:epic, group: group)) }
let_it_be(:issue_event) { create(:event, :created, project: project, target: create(:issue, project: project)) }
+
let(:filtered_events) { described_class.new(filter).apply_filter(Event.all) }
context 'with the "epic" filter' do
diff --git a/ee/spec/lib/ee/gitlab/alert_management/payload/generic_spec.rb b/ee/spec/lib/ee/gitlab/alert_management/payload/generic_spec.rb
index ce14878ee5c6b35fc4b805bff06c9fbfd1c75fbe..5844786c1a0fa52e3bc7843de7743e809a51ac3a 100644
--- a/ee/spec/lib/ee/gitlab/alert_management/payload/generic_spec.rb
+++ b/ee/spec/lib/ee/gitlab/alert_management/payload/generic_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe Gitlab::AlertManagement::Payload::Generic do
let_it_be(:project) { create(:project) }
+
let(:raw_payload) { {} }
let(:parsed_payload) { described_class.new(project: project, payload: raw_payload) }
diff --git a/ee/spec/lib/ee/gitlab/alert_management/payload_spec.rb b/ee/spec/lib/ee/gitlab/alert_management/payload_spec.rb
index 26930044b6a32ddfd2a5da0a7eb89ee8db907ab4..41fe0283236b430fb786f6692cf06ba2791dc834 100644
--- a/ee/spec/lib/ee/gitlab/alert_management/payload_spec.rb
+++ b/ee/spec/lib/ee/gitlab/alert_management/payload_spec.rb
@@ -5,6 +5,7 @@
RSpec.describe Gitlab::AlertManagement::Payload do
describe '#parse' do
let_it_be(:project) { build_stubbed(:project) }
+
let(:payload) { {} }
context 'with the payload specifing cilium as monitoring tool' do
diff --git a/ee/spec/lib/ee/gitlab/ci/pipeline/chain/validate/external_spec.rb b/ee/spec/lib/ee/gitlab/ci/pipeline/chain/validate/external_spec.rb
index cbf9c75be715c2cbb8c65462611e98477d6c6208..2d1b6e5676e9e3a9754d847a293e9e9d60e28b63 100644
--- a/ee/spec/lib/ee/gitlab/ci/pipeline/chain/validate/external_spec.rb
+++ b/ee/spec/lib/ee/gitlab/ci/pipeline/chain/validate/external_spec.rb
@@ -6,6 +6,7 @@
let_it_be(:project) { create(:project) }
let_it_be(:user) { create(:user) }
let_it_be(:subscription) { create(:gitlab_subscription, :default, namespace: user.namespace) }
+
let(:pipeline) { build(:ci_empty_pipeline, user: user, project: project) }
let(:ci_yaml) do
diff --git a/ee/spec/lib/ee/gitlab/ci/pipeline/quota/activity_spec.rb b/ee/spec/lib/ee/gitlab/ci/pipeline/quota/activity_spec.rb
index 12020c875eb95aa39320c532797f19c07bcb1e25..092dbc8c6229cf63a7a8cfc6a54a2b08c8b20668 100644
--- a/ee/spec/lib/ee/gitlab/ci/pipeline/quota/activity_spec.rb
+++ b/ee/spec/lib/ee/gitlab/ci/pipeline/quota/activity_spec.rb
@@ -6,6 +6,7 @@
let_it_be(:namespace) { create(:namespace) }
let_it_be(:project, reload: true) { create(:project, namespace: namespace) }
let_it_be(:ultimate_plan, reload: true) { create(:ultimate_plan) }
+
let(:plan_limits) { create(:plan_limits, plan: ultimate_plan) }
let!(:subscription) { create(:gitlab_subscription, namespace: namespace, hosted_plan: ultimate_plan) }
diff --git a/ee/spec/lib/ee/gitlab/ci/pipeline/quota/job_activity_spec.rb b/ee/spec/lib/ee/gitlab/ci/pipeline/quota/job_activity_spec.rb
index 6134b2e1bcf3ff5b56434dd90f1afabcce0d9862..2cb3945c79a0f14049900751949069ea8189e2f6 100644
--- a/ee/spec/lib/ee/gitlab/ci/pipeline/quota/job_activity_spec.rb
+++ b/ee/spec/lib/ee/gitlab/ci/pipeline/quota/job_activity_spec.rb
@@ -7,6 +7,7 @@
let_it_be(:project, reload: true) { create(:project, namespace: namespace) }
let_it_be(:ultimate_plan, reload: true) { create(:ultimate_plan) }
let_it_be(:plan_limits, reload: true) { create(:plan_limits, plan: ultimate_plan) }
+
let!(:subscription) { create(:gitlab_subscription, namespace: namespace, hosted_plan: ultimate_plan) }
subject { described_class.new(namespace, project) }
diff --git a/ee/spec/lib/ee/gitlab/ci/pipeline/quota/size_spec.rb b/ee/spec/lib/ee/gitlab/ci/pipeline/quota/size_spec.rb
index f2949cff38108719e7058837a6e355f73560f534..57cd4c92798f885cad113aaac794373df9ad7666 100644
--- a/ee/spec/lib/ee/gitlab/ci/pipeline/quota/size_spec.rb
+++ b/ee/spec/lib/ee/gitlab/ci/pipeline/quota/size_spec.rb
@@ -7,6 +7,7 @@
let_it_be(:ultimate_plan, reload: true) { create(:ultimate_plan) }
let_it_be(:project, reload: true) { create(:project, :repository, namespace: namespace) }
let_it_be(:plan_limits) { create(:plan_limits, plan: ultimate_plan) }
+
let!(:subscription) { create(:gitlab_subscription, namespace: namespace, hosted_plan: ultimate_plan) }
let(:pipeline) { build_stubbed(:ci_pipeline, project: project) }
diff --git a/ee/spec/lib/ee/gitlab/git_access_design_spec.rb b/ee/spec/lib/ee/gitlab/git_access_design_spec.rb
index 59d34b2373bf82733f60adf2b06f5a8d7ad5297f..4e4327a21eea8f84d04ea298908dc43e00197b3c 100644
--- a/ee/spec/lib/ee/gitlab/git_access_design_spec.rb
+++ b/ee/spec/lib/ee/gitlab/git_access_design_spec.rb
@@ -7,6 +7,7 @@
let_it_be(:project) { create(:project) }
let_it_be(:user) { project.owner }
+
let(:actor) { :geo }
subject(:access) do
diff --git a/ee/spec/lib/ee/gitlab/git_access_snippet_spec.rb b/ee/spec/lib/ee/gitlab/git_access_snippet_spec.rb
index 25f5c08b956407e01159645d9a876bac4a4c93e4..902a51160d5ad770eaef8d9cbdc1e39f0a4643cd 100644
--- a/ee/spec/lib/ee/gitlab/git_access_snippet_spec.rb
+++ b/ee/spec/lib/ee/gitlab/git_access_snippet_spec.rb
@@ -7,6 +7,7 @@
let_it_be(:user) { create(:user) }
let_it_be(:project) { create(:project, :public) }
let_it_be(:snippet) { create(:project_snippet, :public, :repository, project: project) }
+
let(:actor) { :geo }
let(:authentication_abilities) { [:read_project, :download_code, :push_code] }
diff --git a/ee/spec/lib/ee/gitlab/hook_data/issue_builder_spec.rb b/ee/spec/lib/ee/gitlab/hook_data/issue_builder_spec.rb
index adefd544f545febec4a7cd355aebe02796f2ac89..93b32c8aafb6e202d705d7fd05f9cc9347c3fb18 100644
--- a/ee/spec/lib/ee/gitlab/hook_data/issue_builder_spec.rb
+++ b/ee/spec/lib/ee/gitlab/hook_data/issue_builder_spec.rb
@@ -3,6 +3,7 @@
RSpec.describe Gitlab::HookData::IssueBuilder do
let_it_be(:issue) { create(:issue) }
+
let(:builder) { described_class.new(issue) }
describe '#build' do
diff --git a/ee/spec/lib/ee/gitlab/import_export/project/tree_restorer_spec.rb b/ee/spec/lib/ee/gitlab/import_export/project/tree_restorer_spec.rb
index aa4ebf9b336e4ce62cf1fa8d62463af927327fec..3e89385c5d966557c89ce1f3034552caaf29f9d1 100644
--- a/ee/spec/lib/ee/gitlab/import_export/project/tree_restorer_spec.rb
+++ b/ee/spec/lib/ee/gitlab/import_export/project/tree_restorer_spec.rb
@@ -98,6 +98,7 @@
describe 'security_settings' do
let_it_be(:project) { create(:project, name: 'project', path: 'project') }
+
let(:user) { create(:user)}
before do
@@ -113,6 +114,7 @@
describe 'push_rules' do
let_it_be(:project) { create(:project, name: 'project', path: 'project') }
+
let(:user) { create(:user)}
before do
diff --git a/ee/spec/lib/ee/gitlab/snippet_search_results_spec.rb b/ee/spec/lib/ee/gitlab/snippet_search_results_spec.rb
index 8caab4f01e34b11cb92cce5a18beaddeab4bd677..c209e252d6dbebbda8aa7568ab1963650332394a 100644
--- a/ee/spec/lib/ee/gitlab/snippet_search_results_spec.rb
+++ b/ee/spec/lib/ee/gitlab/snippet_search_results_spec.rb
@@ -3,6 +3,7 @@
RSpec.describe Gitlab::SnippetSearchResults do
let_it_be(:snippet) { create(:snippet, title: 'foo', description: 'foo') }
+
let(:user) { snippet.author }
let(:com_value) { true }
diff --git a/ee/spec/lib/elastic/latest/git_class_proxy_spec.rb b/ee/spec/lib/elastic/latest/git_class_proxy_spec.rb
index 6b988de3b23e493fa1c13e0d52f43daa2a018348..c6a3eb2540b08715f10bbdc87cfa25c0deb22c64 100644
--- a/ee/spec/lib/elastic/latest/git_class_proxy_spec.rb
+++ b/ee/spec/lib/elastic/latest/git_class_proxy_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe Elastic::Latest::GitClassProxy, :elastic do
let_it_be(:project) { create(:project, :repository) }
+
let(:included_class) { Elastic::Latest::RepositoryClassProxy }
subject { included_class.new(project.repository) }
diff --git a/ee/spec/lib/gitlab/alert_management/payload/cilium_spec.rb b/ee/spec/lib/gitlab/alert_management/payload/cilium_spec.rb
index b0c50906f8c6ab0cc1d658fc734436fad10bd445..59e6ebb5827de15915762ec7f7a5c777426988fa 100644
--- a/ee/spec/lib/gitlab/alert_management/payload/cilium_spec.rb
+++ b/ee/spec/lib/gitlab/alert_management/payload/cilium_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe Gitlab::AlertManagement::Payload::Cilium do
let_it_be(:project) { build_stubbed(:project) }
+
let(:raw_payload) { build(:network_alert_payload) }
let(:parsed_payload) do
diff --git a/ee/spec/lib/gitlab/checks/diff_check_spec.rb b/ee/spec/lib/gitlab/checks/diff_check_spec.rb
index 5070da1425290ee1342edc5db1447209f4627785..5e264cb8767b49ccd5c30a10532aaf7ee74f7d6d 100644
--- a/ee/spec/lib/gitlab/checks/diff_check_spec.rb
+++ b/ee/spec/lib/gitlab/checks/diff_check_spec.rb
@@ -32,6 +32,7 @@
describe '#validate_code_owners?' do
let_it_be(:push_rule) { create(:push_rule, file_name_regex: 'READ*') }
+
let(:validate_code_owners) { subject.send(:validate_code_owners?) }
let(:protocol) { 'ssh' }
let(:push_allowed) { false }
@@ -256,6 +257,7 @@
context 'file lock rules' do
let_it_be(:push_rule) { create(:push_rule) }
let_it_be(:owner) { create(:user) }
+
let(:path_lock) { create(:path_lock, path: 'README', project: project) }
before do
diff --git a/ee/spec/lib/gitlab/code_owners/loader_spec.rb b/ee/spec/lib/gitlab/code_owners/loader_spec.rb
index 4c71796a431db0855288e8de38073cecaff7c5cb..cf8702f4e3acfd059f912c565245f43614c8b024 100644
--- a/ee/spec/lib/gitlab/code_owners/loader_spec.rb
+++ b/ee/spec/lib/gitlab/code_owners/loader_spec.rb
@@ -6,6 +6,7 @@
include FakeBlobHelpers
let_it_be(:group) { create(:group) }
let_it_be(:project) { create(:project, namespace: group) }
+
subject(:loader) { described_class.new(project, 'with-codeowners', paths) }
let(:codeowner_content) do
diff --git a/ee/spec/lib/gitlab/git_access_spec.rb b/ee/spec/lib/gitlab/git_access_spec.rb
index d5ac32d16db73618e61d48078d4f20e02a716502..4a00c4b282e4f7df2ca2428bcc4e317f9636c31b 100644
--- a/ee/spec/lib/gitlab/git_access_spec.rb
+++ b/ee/spec/lib/gitlab/git_access_spec.rb
@@ -749,6 +749,7 @@ def self.run_group_permission_checks(permissions_matrix)
let_it_be(:user) { create(:user, :two_factor_via_otp)}
let_it_be(:key) { create(:key, user: user) }
let_it_be(:actor) { key }
+
let(:protocol) { 'ssh' }
before do
diff --git a/ee/spec/lib/gitlab/git_access_wiki_spec.rb b/ee/spec/lib/gitlab/git_access_wiki_spec.rb
index bad7608c505432126bab7a6145ef7144f9dbcbea..ed2c5b740a428ac5336d558ef10108e26f2b3386 100644
--- a/ee/spec/lib/gitlab/git_access_wiki_spec.rb
+++ b/ee/spec/lib/gitlab/git_access_wiki_spec.rb
@@ -7,6 +7,7 @@
let_it_be(:user) { create(:user) }
let_it_be(:project) { create(:project, :wiki_repo) }
+
let(:wiki) { create(:project_wiki, project: project) }
let(:changes) { ['6f6d7e7ed 570e7b2ab refs/heads/master'] }
let(:authentication_abilities) { %i[read_project download_code push_code] }
@@ -24,6 +25,7 @@
describe 'group wiki access' do
let_it_be_with_refind(:group) { create(:group, :private, :wiki_repo) }
+
let(:wiki) { create(:group_wiki, group: group) }
describe '#push_access_check' do
diff --git a/ee/spec/lib/gitlab/graphql/aggregations/vulnerability_statistics/lazy_aggregate_spec.rb b/ee/spec/lib/gitlab/graphql/aggregations/vulnerability_statistics/lazy_aggregate_spec.rb
index e78324fea64de54f8d033b346f1a7f825cc90a71..1649c70cad5a9f4c395de9b561260be868193cb6 100644
--- a/ee/spec/lib/gitlab/graphql/aggregations/vulnerability_statistics/lazy_aggregate_spec.rb
+++ b/ee/spec/lib/gitlab/graphql/aggregations/vulnerability_statistics/lazy_aggregate_spec.rb
@@ -9,6 +9,7 @@
let_it_be(:vulnerable) { create(:group) }
let_it_be(:other_vulnerable) { create(:group) }
+
let(:include_subgroups) { true }
describe '#initialize' do
diff --git a/ee/spec/lib/gitlab/insights/project_insights_config_spec.rb b/ee/spec/lib/gitlab/insights/project_insights_config_spec.rb
index 2f217075412fa3695dc2b0d60b31e289fec8583f..0772b3be7188f7801c4af19fe2d4b063a390912b 100644
--- a/ee/spec/lib/gitlab/insights/project_insights_config_spec.rb
+++ b/ee/spec/lib/gitlab/insights/project_insights_config_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe Gitlab::Insights::ProjectInsightsConfig do
let_it_be(:project) { create(:project) }
+
let(:chart1) { { title: 'chart 1', description: 'description 1' } }
let(:chart2) { { title: 'chart 2', description: 'description 2' } }
diff --git a/ee/spec/lib/gitlab/sitemaps/url_extractor_spec.rb b/ee/spec/lib/gitlab/sitemaps/url_extractor_spec.rb
index 6cbee14def086406fca62c32b310985cbcf74206..2eea17916585cba7a17390c1a85c2189c77df016 100644
--- a/ee/spec/lib/gitlab/sitemaps/url_extractor_spec.rb
+++ b/ee/spec/lib/gitlab/sitemaps/url_extractor_spec.rb
@@ -69,6 +69,7 @@
describe '.extract_from_project' do
let_it_be_with_reload(:project) { create(:project) }
+
let(:project_feature) { project.project_feature }
subject { described_class.extract_from_project(project) }
diff --git a/ee/spec/requests/api/analytics/code_review_analytics_spec.rb b/ee/spec/requests/api/analytics/code_review_analytics_spec.rb
index eabc6af3dca984eaa089d2e1e610e35a763b92a3..33b1315211b8594218ddd06689e6284c7fb80c55 100644
--- a/ee/spec/requests/api/analytics/code_review_analytics_spec.rb
+++ b/ee/spec/requests/api/analytics/code_review_analytics_spec.rb
@@ -31,6 +31,7 @@
context 'with merge requests present' do
let_it_be(:label) { create :label, project: project }
let_it_be(:milestone) { create :milestone, project: project }
+
let!(:merge_request_1) { create(:merge_request, :opened, source_project: project, target_branch: 'mr1') }
let!(:merge_request_2) { create(:labeled_merge_request, :opened, source_project: project, labels: [label], target_branch: 'mr2') }
let!(:merge_request_3) { create(:labeled_merge_request, :opened, source_project: project, labels: [label], milestone: milestone, target_branch: 'mr3') }
diff --git a/ee/spec/requests/api/audit_events_spec.rb b/ee/spec/requests/api/audit_events_spec.rb
index 18a795d9ba8135432cad1d1de5d259f15cfdfd8b..58c51bee525215ccd09a7c0908721d66d3ab9d9a 100644
--- a/ee/spec/requests/api/audit_events_spec.rb
+++ b/ee/spec/requests/api/audit_events_spec.rb
@@ -156,6 +156,7 @@
describe 'GET /audit_events/:id' do
let_it_be(:user_audit_event) { create(:user_audit_event, created_at: Date.new(2000, 1, 10)) }
+
let(:url) { "/audit_events/#{user_audit_event.id}" }
context 'when authenticated, as a user' do
diff --git a/ee/spec/requests/api/commits_spec.rb b/ee/spec/requests/api/commits_spec.rb
index 1130c2b63fea2e5aec7d4e4876b3413ffefd9746..397d90cb4ee5baf759d9939d282d34c3b37e66ae 100644
--- a/ee/spec/requests/api/commits_spec.rb
+++ b/ee/spec/requests/api/commits_spec.rb
@@ -5,6 +5,7 @@
RSpec.describe API::Commits do
let_it_be(:user) { create(:user) }
let_it_be(:project) { create(:project, :repository, creator: user, path: "my.project") }
+
let(:project_id) { project.id }
before do
diff --git a/ee/spec/requests/api/dora/metrics_spec.rb b/ee/spec/requests/api/dora/metrics_spec.rb
index 836d32261cfd5496fc9633832ecf1425cd5348a0..a7df335ca1ac8e806ffe245cbca95036179c2da4 100644
--- a/ee/spec/requests/api/dora/metrics_spec.rb
+++ b/ee/spec/requests/api/dora/metrics_spec.rb
@@ -10,6 +10,7 @@
let_it_be(:production) { create(:environment, :production, project: project) }
let_it_be(:maintainer) { create(:user) }
let_it_be(:guest) { create(:user) }
+
let(:url) { "/projects/#{project.id}/dora/metrics" }
let(:params) { { metric: :deployment_frequency } }
let(:user) { maintainer }
@@ -59,6 +60,7 @@
let_it_be(:production) { create(:environment, :production, project: project) }
let_it_be(:maintainer) { create(:user) }
let_it_be(:guest) { create(:user) }
+
let(:url) { "/groups/#{group.id}/dora/metrics" }
let(:params) { { metric: :deployment_frequency } }
let(:user) { maintainer }
diff --git a/ee/spec/requests/api/epics_spec.rb b/ee/spec/requests/api/epics_spec.rb
index 16177fb63efa3c7d234824aa3bcf635025a4930d..eec046e5c946529d7ac78be35263c0b673c679cf 100644
--- a/ee/spec/requests/api/epics_spec.rb
+++ b/ee/spec/requests/api/epics_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe API::Epics do
let_it_be(:user) { create(:user) }
+
let(:group) { create(:group) }
let(:project) { create(:project, :public, group: group) }
let(:label) { create(:group_label, group: group) }
diff --git a/ee/spec/requests/api/geo_spec.rb b/ee/spec/requests/api/geo_spec.rb
index 571b7bf157500bfb66a587df8ebb4df93b5ec56e..1459f45c2633be292eace6e323a61da1038370c4 100644
--- a/ee/spec/requests/api/geo_spec.rb
+++ b/ee/spec/requests/api/geo_spec.rb
@@ -12,6 +12,7 @@
let_it_be(:user) { create(:user) }
let_it_be(:primary_node) { create(:geo_node, :primary) }
let_it_be(:secondary_node) { create(:geo_node) }
+
let(:geo_token_header) do
{ 'X-Gitlab-Token' => secondary_node.system_hook.token }
end
@@ -46,6 +47,7 @@
end
let_it_be(:resource) { create(:package_file, :npm) }
+
let(:replicator) { Geo::PackageFileReplicator.new(model_record_id: resource.id) }
context 'valid requests' do
diff --git a/ee/spec/requests/api/graphql/boards/epic_board_list_epics_query_spec.rb b/ee/spec/requests/api/graphql/boards/epic_board_list_epics_query_spec.rb
index f21fc6dae6103715ceac0b53b38ac4c5a4f13e90..84a13deda4f08c85857f090eb3ae026a1d776f30 100644
--- a/ee/spec/requests/api/graphql/boards/epic_board_list_epics_query_spec.rb
+++ b/ee/spec/requests/api/graphql/boards/epic_board_list_epics_query_spec.rb
@@ -19,6 +19,7 @@
let_it_be(:epic_pos1) { create(:epic_board_position, epic: epic1, epic_board: board, relative_position: 20) }
let_it_be(:epic_pos2) { create(:epic_board_position, epic: epic2, epic_board: board, relative_position: 10) }
+
let(:data_path) { [:group, :epicBoard, :lists, :nodes, 0, :epics] }
def pagination_query(params = {})
diff --git a/ee/spec/requests/api/graphql/current_user/todos_query_spec.rb b/ee/spec/requests/api/graphql/current_user/todos_query_spec.rb
index b2aae3ba5f78b5b44c265b3de6156bda5bb23e41..8744c53d6994143be4651d80b6e47bcc9209a7d3 100644
--- a/ee/spec/requests/api/graphql/current_user/todos_query_spec.rb
+++ b/ee/spec/requests/api/graphql/current_user/todos_query_spec.rb
@@ -7,6 +7,7 @@
let_it_be(:current_user) { create(:user) }
let_it_be(:epic_todo) { create(:todo, user: current_user, target: create(:epic)) }
+
let(:fields) do
<<~QUERY
nodes {
diff --git a/ee/spec/requests/api/graphql/group/epic/epic_issues_spec.rb b/ee/spec/requests/api/graphql/group/epic/epic_issues_spec.rb
index 3747622f6ee594a917e1f8c25cfd26864808758c..f9ccac5b8be6ba3d9a2a3befc06e6eaea87e74aa 100644
--- a/ee/spec/requests/api/graphql/group/epic/epic_issues_spec.rb
+++ b/ee/spec/requests/api/graphql/group/epic/epic_issues_spec.rb
@@ -111,6 +111,7 @@ def epic_fields(args)
let_it_be(:epic2) { create(:epic, group: group) }
let_it_be(:issue2) { create(:issue, project: project) }
let_it_be(:epic_issue3) { create(:epic_issue, epic: epic2, issue: issue2, relative_position: 3) }
+
let(:params) { { iids: [epic.iid, epic2.iid] } }
it 'returns issues for each epic' do
diff --git a/ee/spec/requests/api/graphql/group/epics_spec.rb b/ee/spec/requests/api/graphql/group/epics_spec.rb
index 20177c78e5c79fbf9d8c80fe7db2b7ed0cdb78a1..631425128473261daee36bfce93587b7c4041fcf 100644
--- a/ee/spec/requests/api/graphql/group/epics_spec.rb
+++ b/ee/spec/requests/api/graphql/group/epics_spec.rb
@@ -75,6 +75,7 @@ def query(params = {})
context 'with sort and pagination' do
let_it_be(:epic3) { create(:epic, group: group, start_date: 4.days.ago, end_date: 7.days.ago ) }
let_it_be(:epic4) { create(:epic, group: group, start_date: 5.days.ago, end_date: 6.days.ago ) }
+
let(:current_user) { user }
let(:data_path) { [:group, :epics] }
@@ -169,6 +170,7 @@ def global_ids(*epics)
context 'query performance' do
let_it_be(:child_epic) { create(:epic, group: group, parent: create(:epic, group: group)) }
+
let(:epic_node) do
<<~NODE
edges {
diff --git a/ee/spec/requests/api/graphql/mutations/boards/create_spec.rb b/ee/spec/requests/api/graphql/mutations/boards/create_spec.rb
index 1251f2e60f5221be1ee723996654d4068cf8aa82..a9a29da933f3314f443742cf2fa604fc94300fec 100644
--- a/ee/spec/requests/api/graphql/mutations/boards/create_spec.rb
+++ b/ee/spec/requests/api/graphql/mutations/boards/create_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe Mutations::Boards::Create do
let_it_be(:parent) { create(:group) }
+
let(:group_path) { parent.full_path }
let(:params) do
{
diff --git a/ee/spec/requests/api/graphql/mutations/boards/epic_boards/create_spec.rb b/ee/spec/requests/api/graphql/mutations/boards/epic_boards/create_spec.rb
index 969e760fb31c2814253b76306132e11cd7159718..e826c311482ba9203c2357436fae6a1a39dedacb 100644
--- a/ee/spec/requests/api/graphql/mutations/boards/epic_boards/create_spec.rb
+++ b/ee/spec/requests/api/graphql/mutations/boards/epic_boards/create_spec.rb
@@ -7,6 +7,7 @@
let_it_be(:current_user) { create(:user) }
let_it_be(:group) { create(:group) }
+
let(:name) { 'board name' }
let(:mutation) { graphql_mutation(:epic_board_create, params) }
let(:label) { create(:group_label, group: group) }
diff --git a/ee/spec/requests/api/graphql/mutations/boards/epic_boards/update_spec.rb b/ee/spec/requests/api/graphql/mutations/boards/epic_boards/update_spec.rb
index 385cced1676d7b7b6dc4f5d42629baad60c3284c..cf92c5b1939c94c6f305b949b28ba85ba477d017 100644
--- a/ee/spec/requests/api/graphql/mutations/boards/epic_boards/update_spec.rb
+++ b/ee/spec/requests/api/graphql/mutations/boards/epic_boards/update_spec.rb
@@ -8,6 +8,7 @@
let_it_be(:current_user) { create(:user) }
let_it_be(:group) { create(:group) }
let_it_be_with_reload(:board) { create(:epic_board, group: group, name: 'orig name') }
+
let(:name) { 'board name' }
let(:mutation) { graphql_mutation(:epic_board_update, params) }
let(:label) { create(:group_label, group: group) }
diff --git a/ee/spec/requests/api/graphql/mutations/boards/issues/issue_move_list_spec.rb b/ee/spec/requests/api/graphql/mutations/boards/issues/issue_move_list_spec.rb
index 52db432b1f21b92a4df1693c8df56ec300ef0e61..c7de4ba1659af2be37e60c0795688b185e44928a 100644
--- a/ee/spec/requests/api/graphql/mutations/boards/issues/issue_move_list_spec.rb
+++ b/ee/spec/requests/api/graphql/mutations/boards/issues/issue_move_list_spec.rb
@@ -55,6 +55,7 @@
context 'when user sets nil epic' do
let_it_be(:epic_issue) { create(:epic_issue, issue: issue1, epic: epic) }
+
let(:issue_move_params) do
{
epic_id: nil,
diff --git a/ee/spec/requests/api/graphql/mutations/boards/lists/update_limit_metrics_spec.rb b/ee/spec/requests/api/graphql/mutations/boards/lists/update_limit_metrics_spec.rb
index 8f3abeb46ef98eabd3ed547041dfd7fce000f9b5..f3bcc38366141ad995194538d9909c7b7a5bdef0 100644
--- a/ee/spec/requests/api/graphql/mutations/boards/lists/update_limit_metrics_spec.rb
+++ b/ee/spec/requests/api/graphql/mutations/boards/lists/update_limit_metrics_spec.rb
@@ -10,6 +10,7 @@
let_it_be(:user) { create(:user) }
let_it_be(:list) { create(:list, board: board) }
let_it_be(:forbidden_user) { create(:user) }
+
let(:current_user) { user }
let(:mutation_class) { Mutations::Boards::Lists::UpdateLimitMetrics }
diff --git a/ee/spec/requests/api/graphql/mutations/compliance_management/frameworks/destroy_spec.rb b/ee/spec/requests/api/graphql/mutations/compliance_management/frameworks/destroy_spec.rb
index c0f2ad716d605433c298db9b2a374fb1b8dd1549..4768356e52627f0fec5176ecb5038a2c845cdcf4 100644
--- a/ee/spec/requests/api/graphql/mutations/compliance_management/frameworks/destroy_spec.rb
+++ b/ee/spec/requests/api/graphql/mutations/compliance_management/frameworks/destroy_spec.rb
@@ -6,6 +6,7 @@
include GraphqlHelpers
let_it_be(:framework) { create(:compliance_framework) }
+
let(:mutation) { graphql_mutation(:destroy_compliance_framework, { id: global_id_of(framework) }) }
subject { post_graphql_mutation(mutation, current_user: current_user) }
diff --git a/ee/spec/requests/api/graphql/mutations/compliance_management/frameworks/update_spec.rb b/ee/spec/requests/api/graphql/mutations/compliance_management/frameworks/update_spec.rb
index 042d5af2ca507ae15e448ba7a78ff5dc2b3fffca..059e420277cdc425aad65ad96e045528f21422a8 100644
--- a/ee/spec/requests/api/graphql/mutations/compliance_management/frameworks/update_spec.rb
+++ b/ee/spec/requests/api/graphql/mutations/compliance_management/frameworks/update_spec.rb
@@ -6,6 +6,7 @@
include GraphqlHelpers
let_it_be(:framework) { create(:compliance_framework) }
+
let(:mutation) { graphql_mutation(:update_compliance_framework, { id: global_id_of(framework), **params }) }
let(:current_user) { framework.namespace.owner }
let(:params) do
diff --git a/ee/spec/requests/api/graphql/mutations/dast_scanner_profiles/update_spec.rb b/ee/spec/requests/api/graphql/mutations/dast_scanner_profiles/update_spec.rb
index ac9b96cc2e405fe301e44f267c58c540d5c7abc9..39932851e9513a4ae855cceb28576174a36cdec6 100644
--- a/ee/spec/requests/api/graphql/mutations/dast_scanner_profiles/update_spec.rb
+++ b/ee/spec/requests/api/graphql/mutations/dast_scanner_profiles/update_spec.rb
@@ -9,6 +9,7 @@
let!(:dast_scanner_profile_1) { create(:dast_scanner_profile, project: project) }
let_it_be(:new_profile_name) { SecureRandom.hex }
+
let(:new_target_timeout) { dast_scanner_profile.target_timeout + 1 }
let(:new_spider_timeout) { dast_scanner_profile.spider_timeout + 1 }
let(:new_scan_type) { (DastScannerProfile.scan_types.keys - [DastScannerProfile.last.scan_type]).first }
diff --git a/ee/spec/requests/api/graphql/mutations/environments/canary_ingress/update_spec.rb b/ee/spec/requests/api/graphql/mutations/environments/canary_ingress/update_spec.rb
index f009c281c33d7aecf8f557aac1425e14869a9a08..a2db4b60c707d30de0cb49486cc235146c87b637 100644
--- a/ee/spec/requests/api/graphql/mutations/environments/canary_ingress/update_spec.rb
+++ b/ee/spec/requests/api/graphql/mutations/environments/canary_ingress/update_spec.rb
@@ -13,6 +13,7 @@
let_it_be(:deployment) { create(:deployment, :success, environment: environment, project: project) }
let_it_be(:maintainer) { create(:user) }
let_it_be(:developer) { create(:user) }
+
let(:environment_id) { environment.to_global_id.to_s }
let(:weight) { 25 }
let(:actor) { developer }
diff --git a/ee/spec/requests/api/graphql/mutations/epics/add_issue_spec.rb b/ee/spec/requests/api/graphql/mutations/epics/add_issue_spec.rb
index 07cf13e7ecf377b150e2011e784622078df2d280..0ae08eaecfd9a2961f5312614c3d572077545ede 100644
--- a/ee/spec/requests/api/graphql/mutations/epics/add_issue_spec.rb
+++ b/ee/spec/requests/api/graphql/mutations/epics/add_issue_spec.rb
@@ -8,6 +8,7 @@
let_it_be(:current_user) { create(:user) }
let_it_be(:group) { create(:group) }
let_it_be(:project) { create(:project, namespace: group) }
+
let(:epic) { create(:epic, group: group) }
let(:issue) { create(:issue, project: project) }
diff --git a/ee/spec/requests/api/graphql/mutations/epics/set_subscription_spec.rb b/ee/spec/requests/api/graphql/mutations/epics/set_subscription_spec.rb
index 9c3b3b500b33e8ff50402dbe9413ac43b83f1fdc..799e89cb62cf755cca22edaa5eb9169345a7cee9 100644
--- a/ee/spec/requests/api/graphql/mutations/epics/set_subscription_spec.rb
+++ b/ee/spec/requests/api/graphql/mutations/epics/set_subscription_spec.rb
@@ -7,6 +7,7 @@
let_it_be(:current_user) { create(:user) }
let_it_be(:group) { create(:group) }
+
let(:epic) { create(:epic, group: group) }
let(:subscribed_state) { true }
diff --git a/ee/spec/requests/api/graphql/mutations/epics/update_spec.rb b/ee/spec/requests/api/graphql/mutations/epics/update_spec.rb
index 3a761b14e1905cc02202da8c350a22b5b0a51528..16ab1be7ededdb4af278943c1d61209da1a7a196 100644
--- a/ee/spec/requests/api/graphql/mutations/epics/update_spec.rb
+++ b/ee/spec/requests/api/graphql/mutations/epics/update_spec.rb
@@ -7,6 +7,7 @@
let_it_be(:current_user) { create(:user) }
let_it_be(:group) { create(:group) }
+
let(:label_1) { create(:group_label, group: group) }
let(:label_2) { create(:group_label, group: group) }
let(:label_3) { create(:group_label, group: group) }
diff --git a/ee/spec/requests/api/graphql/mutations/gitlab_subscriptions/activate_spec.rb b/ee/spec/requests/api/graphql/mutations/gitlab_subscriptions/activate_spec.rb
index 97c4742e154a8f1b7c70ccb51872474f0129bbb0..934cf8f812c66ac1b66b39d460afcbfb0ca1404a 100644
--- a/ee/spec/requests/api/graphql/mutations/gitlab_subscriptions/activate_spec.rb
+++ b/ee/spec/requests/api/graphql/mutations/gitlab_subscriptions/activate_spec.rb
@@ -7,6 +7,7 @@
let_it_be(:current_user) { create(:admin) }
let_it_be(:license_key) { build(:gitlab_license).export }
+
let(:activation_code) { 'activation_code' }
let(:mutation) do
graphql_mutation(:gitlab_subscription_activate, { activation_code: activation_code })
diff --git a/ee/spec/requests/api/graphql/mutations/incident_management/oncall_rotation/create_spec.rb b/ee/spec/requests/api/graphql/mutations/incident_management/oncall_rotation/create_spec.rb
index ae380949269cacb99567a68ac918b48946e9f538..d6142035aeb112205da2fb9222db01ea476db6ea 100644
--- a/ee/spec/requests/api/graphql/mutations/incident_management/oncall_rotation/create_spec.rb
+++ b/ee/spec/requests/api/graphql/mutations/incident_management/oncall_rotation/create_spec.rb
@@ -8,6 +8,7 @@
let_it_be(:current_user) { create(:user) }
let_it_be(:project) { create(:project) }
let_it_be(:schedule) { create(:incident_management_oncall_schedule, project: project) }
+
let(:args) do
{
project_path: project.full_path,
diff --git a/ee/spec/requests/api/graphql/mutations/incident_management/oncall_schedule/create_spec.rb b/ee/spec/requests/api/graphql/mutations/incident_management/oncall_schedule/create_spec.rb
index c13fed639a9f6b9ebf7aa8e08e5ac29a5828edff..110edd3afd9b5646caeaabcff175925aa85da834 100644
--- a/ee/spec/requests/api/graphql/mutations/incident_management/oncall_schedule/create_spec.rb
+++ b/ee/spec/requests/api/graphql/mutations/incident_management/oncall_schedule/create_spec.rb
@@ -7,6 +7,7 @@
let_it_be(:current_user) { create(:user) }
let_it_be(:project) { create(:project) }
+
let(:variables) do
{
project_path: project.full_path,
diff --git a/ee/spec/requests/api/graphql/mutations/incident_management/oncall_schedule/destroy_spec.rb b/ee/spec/requests/api/graphql/mutations/incident_management/oncall_schedule/destroy_spec.rb
index c5b2dc4ff9d53c43ab91126d0925229ab7bd698a..439330f3da4d21d4e6584e177254ff2bdf40765e 100644
--- a/ee/spec/requests/api/graphql/mutations/incident_management/oncall_schedule/destroy_spec.rb
+++ b/ee/spec/requests/api/graphql/mutations/incident_management/oncall_schedule/destroy_spec.rb
@@ -8,6 +8,7 @@
let_it_be(:user) { create(:user) }
let_it_be(:project) { create(:project) }
let_it_be(:oncall_schedule) { create(:incident_management_oncall_schedule, project: project) }
+
let(:variables) { { project_path: project.full_path, iid: oncall_schedule.iid.to_s } }
let(:mutation) do
diff --git a/ee/spec/requests/api/graphql/mutations/incident_management/oncall_schedule/update_spec.rb b/ee/spec/requests/api/graphql/mutations/incident_management/oncall_schedule/update_spec.rb
index 31579809c85b33ab3a39b935f17ca823c2e992fd..b71dd1b3b0b8e13750c6901cc446660c91a9f625 100644
--- a/ee/spec/requests/api/graphql/mutations/incident_management/oncall_schedule/update_spec.rb
+++ b/ee/spec/requests/api/graphql/mutations/incident_management/oncall_schedule/update_spec.rb
@@ -8,6 +8,7 @@
let_it_be(:user) { create(:user) }
let_it_be(:project) { create(:project) }
let_it_be(:oncall_schedule) { create(:incident_management_oncall_schedule, project: project) }
+
let(:variables) do
{
project_path: project.full_path,
diff --git a/ee/spec/requests/api/graphql/mutations/issues/promote_to_epic_spec.rb b/ee/spec/requests/api/graphql/mutations/issues/promote_to_epic_spec.rb
index 55ef2df65d0185d48c74627ca1828dd1c9cc21bb..c1e7393275aa85e401e86dbed2091f065a14476b 100644
--- a/ee/spec/requests/api/graphql/mutations/issues/promote_to_epic_spec.rb
+++ b/ee/spec/requests/api/graphql/mutations/issues/promote_to_epic_spec.rb
@@ -12,6 +12,7 @@
let_it_be(:project) { create(:project, group: group) }
let_it_be(:issue) { create(:issue, project: project) }
let_it_be(:user) { create(:user) }
+
let(:input) { { group_path: new_epic_group&.full_path } }
let(:mutation) do
diff --git a/ee/spec/requests/api/graphql/mutations/notes/create/note_spec.rb b/ee/spec/requests/api/graphql/mutations/notes/create/note_spec.rb
index 576325e87f91e59aa393f0e367805fd408332d38..b1efe7aaf42a47217ee15e2ec971247d8690f399 100644
--- a/ee/spec/requests/api/graphql/mutations/notes/create/note_spec.rb
+++ b/ee/spec/requests/api/graphql/mutations/notes/create/note_spec.rb
@@ -6,6 +6,7 @@
include GraphqlHelpers
let_it_be(:current_user) { create(:user) }
+
let(:epic) { create(:epic, group: group) }
let(:mutation) do
variables = {
diff --git a/ee/spec/requests/api/graphql/mutations/quality_management/test_cases/create_spec.rb b/ee/spec/requests/api/graphql/mutations/quality_management/test_cases/create_spec.rb
index 4aa64158e01b690d8ef2351dafeee43dfd626389..99bbcfaea686b5d27d5d33002046446b5862ee18 100644
--- a/ee/spec/requests/api/graphql/mutations/quality_management/test_cases/create_spec.rb
+++ b/ee/spec/requests/api/graphql/mutations/quality_management/test_cases/create_spec.rb
@@ -8,6 +8,7 @@
let_it_be_with_refind(:project) { create(:project, :private) }
let_it_be(:current_user) { create(:user) }
let_it_be(:label) { create(:label, project: project) }
+
let(:variables) { { project_path: project.full_path, title: 'foo', description: 'bar', label_ids: [label.id] } }
let(:mutation) do
diff --git a/ee/spec/requests/api/graphql/namespace/compliance_frameworks_spec.rb b/ee/spec/requests/api/graphql/namespace/compliance_frameworks_spec.rb
index 79ddaa17b35ee728046c9b8eb2e352b5a308cc8f..4e2e7b273dd6235cdaddd37579e1ced67d3f4e54 100644
--- a/ee/spec/requests/api/graphql/namespace/compliance_frameworks_spec.rb
+++ b/ee/spec/requests/api/graphql/namespace/compliance_frameworks_spec.rb
@@ -8,6 +8,7 @@
let_it_be(:namespace) { create(:namespace) }
let_it_be(:compliance_framework_1) { create(:compliance_framework, namespace: namespace, name: 'Test1') }
let_it_be(:compliance_framework_2) { create(:compliance_framework, namespace: namespace, name: 'Test2') }
+
let(:path) { %i[namespace compliance_frameworks nodes] }
let!(:query) do
diff --git a/ee/spec/requests/api/graphql/project/alert_management/payload_fields_spec.rb b/ee/spec/requests/api/graphql/project/alert_management/payload_fields_spec.rb
index 387de8775249b48d877181615d48315d30d69b56..e7fdd57b1a39b6ab63c5ead77789e6349434e4b9 100644
--- a/ee/spec/requests/api/graphql/project/alert_management/payload_fields_spec.rb
+++ b/ee/spec/requests/api/graphql/project/alert_management/payload_fields_spec.rb
@@ -8,6 +8,7 @@
let_it_be_with_refind(:project) { create(:project) }
let_it_be(:maintainer) { create(:user) }
let_it_be(:developer) { create(:user) }
+
let(:current_user) { maintainer }
let(:license) { true }
let(:feature_flag) { true }
diff --git a/ee/spec/requests/api/graphql/project/requirements_management/requirements_spec.rb b/ee/spec/requests/api/graphql/project/requirements_management/requirements_spec.rb
index cfee98be50db352fba2651064946fc36d2eef03a..d81a3b1f83ae7a0dd085c40ef6b4f81e844e2839 100644
--- a/ee/spec/requests/api/graphql/project/requirements_management/requirements_spec.rb
+++ b/ee/spec/requests/api/graphql/project/requirements_management/requirements_spec.rb
@@ -65,6 +65,7 @@
context 'query performance with test reports' do
let_it_be(:test_report) { create(:test_report, requirement: requirement, state: "passed") }
+
let(:fields) do
<<~QUERY
edges {
@@ -172,6 +173,7 @@ def match_single_result(requirement)
context 'for MISSING status' do
let_it_be(:requirement3) { create(:requirement, project: filter_project, author: other_user, title: 'need test report') }
+
let(:params) { '(lastTestReportState: MISSING)' }
it 'returns filtered requirements' do
diff --git a/ee/spec/requests/api/graphql/projects/compliance_frameworks_spec.rb b/ee/spec/requests/api/graphql/projects/compliance_frameworks_spec.rb
index 4cc1f3da4249e311ea153f77298f737d825717f7..f6b2fb49326faa156ef2eaddf798aa8200715546 100644
--- a/ee/spec/requests/api/graphql/projects/compliance_frameworks_spec.rb
+++ b/ee/spec/requests/api/graphql/projects/compliance_frameworks_spec.rb
@@ -8,6 +8,7 @@
let_it_be(:current_user) { create(:user) }
let_it_be(:project_members) { create_list(:project_member, 2, :maintainer, user: current_user) }
let_it_be(:project_ids) { project_members.map { |p| global_id_of(p.source) } }
+
let(:query) do
graphql_query_for(
:projects, { ids: project_ids }, "nodes { #{query_nodes(:compliance_frameworks)} }"
@@ -43,6 +44,7 @@
context 'projects can have a compliance framework' do
let_it_be(:compliance_projects) { create_list(:project, 2, :with_compliance_framework) }
let_it_be(:non_compliance_project) { create(:project) }
+
let(:projects) { compliance_projects + [non_compliance_project] }
let(:project_ids) { projects.map { |p| global_id_of(p) } }
@@ -70,6 +72,7 @@
let_it_be(:framework) { create(:compliance_framework) }
let_it_be(:project_1) { create(:project, compliance_framework_setting: create(:compliance_framework_project_setting, compliance_management_framework: framework )) }
let_it_be(:project_2) { create(:project, compliance_framework_setting: create(:compliance_framework_project_setting, compliance_management_framework: framework )) }
+
let(:projects) { [project_1, project_2] }
let(:project_ids) { projects.map { |p| global_id_of(p) } }
let(:query) do
diff --git a/ee/spec/requests/api/internal/base_spec.rb b/ee/spec/requests/api/internal/base_spec.rb
index ee830c28913a678cc3cf67034175049dc4494cc3..440835b1b7dec908ade9fdf34fa410fdb7bbd10f 100644
--- a/ee/spec/requests/api/internal/base_spec.rb
+++ b/ee/spec/requests/api/internal/base_spec.rb
@@ -10,11 +10,13 @@
let_it_be(:primary_node, reload: true) { create(:geo_node, :primary, url: primary_url) }
let_it_be(:secondary_node, reload: true) { create(:geo_node, url: secondary_url) }
let_it_be(:user) { create(:user) }
+
let(:secret_token) { Gitlab::Shell.secret_token }
describe 'POST /internal/post_receive', :geo do
let(:key) { create(:key, user: user) }
let_it_be(:project, reload: true) { create(:project, :repository, :wiki_repo) }
+
let(:gl_repository) { "project-#{project.id}" }
let(:reference_counter) { double('ReferenceCounter') }
@@ -197,6 +199,7 @@ def check_access_by_alias(alias_name)
context 'ip restriction' do
let_it_be(:group) { create(:group)}
let_it_be(:project) { create(:project, :repository, namespace: group) }
+
let(:params) do
{
key_id: key.id,
@@ -310,6 +313,7 @@ def lfs_auth_user(user_id, project)
describe 'POST /internal/personal_access_token' do
let_it_be(:key) { create(:key, user: user) }
+
let(:instance_level_max_personal_access_token_lifetime) { nil }
before do
@@ -361,6 +365,7 @@ def lfs_auth_user(user_id, project)
describe 'POST /internal/two_factor_otp_check' do
let_it_be(:key) { create(:key, user: user) }
+
let(:key_id) { key.id }
let(:otp) { '123456'}
diff --git a/ee/spec/requests/api/issues_spec.rb b/ee/spec/requests/api/issues_spec.rb
index c698869c924e84c9922d4b7092c2b67520fa73f5..aaa8f3c7329aa3d0d49be5a8ec0e1ce741a9a1a5 100644
--- a/ee/spec/requests/api/issues_spec.rb
+++ b/ee/spec/requests/api/issues_spec.rb
@@ -673,6 +673,7 @@
end
let_it_be(:issue) { create(:incident, project: project) }
+
let!(:image) { create(:issuable_metric_image, issue: issue) }
subject { get api("/projects/#{project.id}/issues/#{issue.iid}/metric_images", user2) }
diff --git a/ee/spec/requests/api/ldap_spec.rb b/ee/spec/requests/api/ldap_spec.rb
index 721cbeba67c9318fdadc4fb7e713fd352b0b6bbb..0879c2f60efb155d2acb03072bb249d971c577a8 100644
--- a/ee/spec/requests/api/ldap_spec.rb
+++ b/ee/spec/requests/api/ldap_spec.rb
@@ -8,6 +8,7 @@
let_it_be(:user) { create(:user) }
let_it_be(:admin) { create(:admin) }
+
let(:adapter) { ldap_adapter }
before do
diff --git a/ee/spec/requests/api/merge_request_approval_rules_spec.rb b/ee/spec/requests/api/merge_request_approval_rules_spec.rb
index cb2b91948901ff5cc33b5bb475e60dbdbdf9cf78..f177297f9353db05c78934015bd5111d658b6b0c 100644
--- a/ee/spec/requests/api/merge_request_approval_rules_spec.rb
+++ b/ee/spec/requests/api/merge_request_approval_rules_spec.rb
@@ -6,6 +6,7 @@
let_it_be(:user) { create(:user) }
let_it_be(:other_user) { create(:user) }
let_it_be(:project) { create(:project, :public, :repository, creator: user, namespace: user.namespace) }
+
let(:merge_request) { create(:merge_request, author: user, source_project: project, target_project: project) }
shared_examples_for 'a protected API endpoint for merge request approval rule action' do
diff --git a/ee/spec/requests/api/merge_request_approvals_spec.rb b/ee/spec/requests/api/merge_request_approvals_spec.rb
index 13d3a93b2f60a67e9a32f850af9be213412fd7b1..d6945fd09990d2c800764d35f8e9849929f78de6 100644
--- a/ee/spec/requests/api/merge_request_approvals_spec.rb
+++ b/ee/spec/requests/api/merge_request_approvals_spec.rb
@@ -9,6 +9,7 @@
let_it_be(:project, reload: true) { create(:project, :public, :repository, creator: user, namespace: user.namespace, only_allow_merge_if_pipeline_succeeds: false) }
let_it_be(:approver) { create :user }
let_it_be(:group) { create :group }
+
let(:merge_request) { create(:merge_request, :simple, author: user, assignees: [user], source_project: project, target_project: project, title: "Test", created_at: Time.now) }
shared_examples_for 'an API endpoint for getting merge request approval state' do
diff --git a/ee/spec/requests/api/merge_requests_spec.rb b/ee/spec/requests/api/merge_requests_spec.rb
index 163d8d65f81a939ba224513a108e785aec3c6ab3..2682910f4b7d97ca15344f35b49554b6347595dc 100644
--- a/ee/spec/requests/api/merge_requests_spec.rb
+++ b/ee/spec/requests/api/merge_requests_spec.rb
@@ -12,6 +12,7 @@
let_it_be(:milestone1) { create(:milestone, title: '0.9', project: project) }
let_it_be(:label) { create(:label, title: 'label', color: '#FFAABB', project: project) }
let_it_be(:label2) { create(:label, title: 'a-test', color: '#FFFFFF', project: project) }
+
let(:base_time) { Time.now }
let!(:merge_request) { create(:merge_request, :simple, milestone: milestone1, author: user, assignees: [user, user2], source_project: project, target_project: project, title: "Test", created_at: base_time) }
diff --git a/ee/spec/requests/api/merge_trains_spec.rb b/ee/spec/requests/api/merge_trains_spec.rb
index 497f241c7dda25eb992decd72a8a371ee91786a3..a5be18122d5ed28187e7d5503cfd4c2cbaa1619e 100644
--- a/ee/spec/requests/api/merge_trains_spec.rb
+++ b/ee/spec/requests/api/merge_trains_spec.rb
@@ -5,6 +5,7 @@
let_it_be(:project) { create(:project, :repository) }
let_it_be(:developer) { create(:user) }
let_it_be(:guest) { create(:user) }
+
let(:user) { developer }
before_all do
diff --git a/ee/spec/requests/api/project_approval_rules_spec.rb b/ee/spec/requests/api/project_approval_rules_spec.rb
index a37a65ceb7d6a53e6c63bb0b3c93cc479cb3d87d..216a86a78ec41440f495b79aa3ff58a9e8c0caa1 100644
--- a/ee/spec/requests/api/project_approval_rules_spec.rb
+++ b/ee/spec/requests/api/project_approval_rules_spec.rb
@@ -13,6 +13,7 @@
describe 'GET /projects/:id/approval_rules/:approval_rule_id' do
let_it_be(:private_project) { create(:project, :private, creator: user, namespace: user.namespace) }
+
let!(:approval_rule) { create(:approval_project_rule, project: private_project) }
let(:url) { "/projects/#{private_project.id}/approval_rules/#{approval_rule.id}" }
@@ -118,6 +119,7 @@
context 'when project is archived' do
let_it_be(:archived_project) { create(:project, :archived, creator: user) }
+
let(:url) { "/projects/#{archived_project.id}/approval_rules" }
context 'when user has normal permissions' do
diff --git a/ee/spec/requests/api/project_approval_settings_spec.rb b/ee/spec/requests/api/project_approval_settings_spec.rb
index 53039c6b668c862a4bfc1c8f7ff609b8e2a8f96c..b6422f935edc5dd843db414bfa6cfcb9cd953ce8 100644
--- a/ee/spec/requests/api/project_approval_settings_spec.rb
+++ b/ee/spec/requests/api/project_approval_settings_spec.rb
@@ -119,6 +119,7 @@
context 'when project is archived' do
let_it_be(:archived_project) { create(:project, :archived, creator: user) }
+
let(:url) { "/projects/#{archived_project.id}/approval_settings" }
context 'when user has normal permissions' do
diff --git a/ee/spec/requests/api/projects_spec.rb b/ee/spec/requests/api/projects_spec.rb
index c60d680f34984a2b4d99fd1d1a935e32911ac7c8..7f1c9aa85f23b06e46f09f2c8e6316abc5d5dc36 100644
--- a/ee/spec/requests/api/projects_spec.rb
+++ b/ee/spec/requests/api/projects_spec.rb
@@ -7,6 +7,7 @@
let(:user) { create(:user) }
let_it_be(:another_user) { create(:user) }
+
let(:project) { create(:project, namespace: user.namespace) }
shared_examples 'inaccessable by reporter role and lower' do
@@ -603,6 +604,7 @@
describe 'GET projects/:id/audit_events' do
let_it_be(:user) { create(:user) }
let_it_be(:project) { create(:project, :public, namespace: user.namespace) }
+
let(:path) { "/projects/#{project.id}/audit_events" }
it_behaves_like 'inaccessable by reporter role and lower'
diff --git a/ee/spec/requests/api/todos_spec.rb b/ee/spec/requests/api/todos_spec.rb
index 1e6a09f2c28a1a72f0fd52fa69eae42ecefcac03..0d78b13c3f49a969c393939224aeff7ef128b3b4 100644
--- a/ee/spec/requests/api/todos_spec.rb
+++ b/ee/spec/requests/api/todos_spec.rb
@@ -5,6 +5,7 @@
RSpec.describe API::Todos do
let_it_be(:group) { create(:group) }
let_it_be(:project) { create(:project, group: group) }
+
let(:user) { create(:user) }
let(:epic) { create(:epic, group: group) }
diff --git a/ee/spec/requests/api/vulnerabilities_spec.rb b/ee/spec/requests/api/vulnerabilities_spec.rb
index dbbfbe31d5ec8e872dc0cd274c0c49a060206c9b..3b4812365245130a241eb5fc01b73110a2f0d15f 100644
--- a/ee/spec/requests/api/vulnerabilities_spec.rb
+++ b/ee/spec/requests/api/vulnerabilities_spec.rb
@@ -10,6 +10,7 @@
end
let_it_be(:user) { create(:user) }
+
let(:project_vulnerabilities_path) { "/projects/#{project.id}/vulnerabilities" }
describe 'GET /projects/:id/vulnerabilities' do
@@ -62,6 +63,7 @@
let_it_be(:project) { create(:project, :with_vulnerabilities) }
let_it_be(:vulnerability) { project.vulnerabilities.first }
let_it_be(:finding) { create(:vulnerabilities_finding, vulnerability: vulnerability) }
+
let(:vulnerability_id) { vulnerability.id }
subject(:get_vulnerability) { get api("/vulnerabilities/#{vulnerability_id}", user) }
@@ -106,6 +108,7 @@
describe 'POST /projects/:id/vulnerabilities' do
let_it_be(:project) { create(:project) }
+
let(:finding) { create(:vulnerabilities_finding, project: project) }
let(:finding_id) { finding.id }
let(:expected_error_messages) { { 'base' => ['finding is not found or is already attached to a vulnerability'] } }
@@ -181,6 +184,7 @@
end
let_it_be(:project) { create(:project, :with_vulnerabilities) }
+
let(:vulnerability) { project.vulnerabilities.first }
let(:vulnerability_id) { vulnerability.id }
@@ -268,6 +272,7 @@
end
let_it_be(:project) { create(:project, :with_vulnerabilities) }
+
let(:vulnerability) { project.vulnerabilities.first }
let(:vulnerability_id) { vulnerability.id }
@@ -325,6 +330,7 @@
end
let_it_be(:project) { create(:project, :with_vulnerabilities) }
+
let(:vulnerability) { project.vulnerabilities.first }
let(:vulnerability_id) { vulnerability.id }
diff --git a/ee/spec/requests/api/vulnerability_issue_links_spec.rb b/ee/spec/requests/api/vulnerability_issue_links_spec.rb
index c445a38f42283980348b656af94d2c8b1ae2fef8..e2327f0e4f0cd214c5508ba071747101c69b7b9a 100644
--- a/ee/spec/requests/api/vulnerability_issue_links_spec.rb
+++ b/ee/spec/requests/api/vulnerability_issue_links_spec.rb
@@ -15,6 +15,7 @@
describe 'GET /vulnerabilities/:id/issue_links' do
let_it_be(:vulnerability) { create(:vulnerability, :with_issue_links, project: project) }
let_it_be(:vulnerability_id) { vulnerability.id }
+
let(:vulnerability_issue_links_path) { "/vulnerabilities/#{vulnerability_id}/issue_links" }
subject(:get_issue_links) { get api(vulnerability_issue_links_path, user) }
@@ -92,6 +93,7 @@
describe 'POST /vulnerabilities/:id/issue_links' do
let_it_be(:issue) { create(:issue, project: project) }
let_it_be(:vulnerability) { create(:vulnerability, project: project) }
+
let(:vulnerability_id) { vulnerability.id }
let(:target_issue_iid) { issue.iid }
let(:params) { { target_issue_iid: target_issue_iid } }
diff --git a/ee/spec/requests/callout_spec.rb b/ee/spec/requests/callout_spec.rb
index a043e43760a794512cda9ef4ff0555bd28e879df..ff5789cb451e9e3d03c3c79195105cf7fd7640df 100644
--- a/ee/spec/requests/callout_spec.rb
+++ b/ee/spec/requests/callout_spec.rb
@@ -7,6 +7,7 @@
describe 'new_user_signups_cap_reached' do
let_it_be(:user) { create(:admin) }
+
let(:billable_users) { [double(:billable_user)] }
let(:help_page_href) { help_page_path('user/admin_area/settings/sign_up_restrictions.md') }
let(:expected_content) { 'Your instance has reached its user cap' }
diff --git a/ee/spec/requests/git_http_geo_spec.rb b/ee/spec/requests/git_http_geo_spec.rb
index 5f8a1f1193ee9078d6976639ba03dfc8379ad10e..efd06e34ef92b126baba13c79d0a6e29e2ec61ca 100644
--- a/ee/spec/requests/git_http_geo_spec.rb
+++ b/ee/spec/requests/git_http_geo_spec.rb
@@ -141,6 +141,7 @@ def make_request
context 'but has not successfully synced' do
let_it_be(:project_with_repo_but_not_synced) { create(:project, :repository, :private) }
let_it_be(:project) { project_with_repo_but_not_synced }
+
let(:redirect_url) { "#{primary_url}/#{project_with_repo_but_not_synced.full_path}.git/info/refs?service=git-upload-pack" }
before do
@@ -177,6 +178,7 @@ def make_request
context 'when the repository does not exist' do
let_it_be(:project) { project_no_repo }
+
let(:redirect_url) { "#{primary_url}/#{project.full_path}.git/info/refs?service=git-upload-pack" }
it_behaves_like 'a Geo 302 redirect to Primary'
@@ -222,6 +224,7 @@ def make_request
end
let_it_be(:project) { project_with_repo }
+
let(:endpoint_path) { "/#{project.full_path}.git/info/refs" }
let(:redirect_url) { "#{redirected_primary_url}?service=git-receive-pack" }
@@ -257,6 +260,7 @@ def make_request
context 'when the repository does not exist' do
let_it_be(:project) { project_no_repo }
+
let(:redirect_url) { "#{primary_url}/#{project.full_path}.git/git-upload-pack" }
it_behaves_like 'a Geo 302 redirect to Primary'
@@ -280,6 +284,7 @@ def make_request
let(:args) { {} }
let_it_be(:project) { project_with_repo }
+
let(:endpoint_path) { "/#{project.full_path}.git/info/lfs/objects/batch" }
subject do
@@ -353,6 +358,7 @@ def make_request
context 'when the repository does not exist' do
let_it_be(:project) { project_no_repo }
+
let(:redirect_url) { redirected_primary_url }
it_behaves_like 'a Geo 302 redirect to Primary'
@@ -412,6 +418,7 @@ def make_request
context 'when the repository does not exist' do
let_it_be(:project) { project_no_repo }
+
let(:redirect_url) { redirected_primary_url }
it_behaves_like 'a Geo 302 redirect to Primary'
@@ -433,6 +440,7 @@ def make_request
end
let_it_be(:project) { project_with_repo }
+
let(:endpoint_path) { "/#{project.full_path}.git/#{path}" }
let(:redirect_url) { redirected_primary_url }
@@ -472,6 +480,7 @@ def make_request
let(:identifier) { "user-#{user.id}" }
let_it_be(:project) { project_with_repo }
+
let(:gl_repository) { "project-#{project.id}" }
let(:endpoint_path) { "#{::Gitlab::Geo::GitPushHttp::PATH_PREFIX}/#{secondary.id}/#{project.full_path}.git/git-receive-pack" }
@@ -505,6 +514,7 @@ def make_request
end
let_it_be(:project) { project_with_repo }
+
let(:endpoint_path) { "/#{project.full_path}.git/git-receive-pack" }
context 'when gl_id is provided in JWT token' do
@@ -638,6 +648,7 @@ def make_request
end
let_it_be(:project) { project_with_repo }
+
let(:repository_path) { project.full_path }
it 'returns unauthorized error' do
diff --git a/ee/spec/requests/repositories/git_http_controller_spec.rb b/ee/spec/requests/repositories/git_http_controller_spec.rb
index b40dada2a662df55ee2fd00d2d7c03bf11fe82f7..2f3d9eac0ac53b475212b0e861401fd3cb151080 100644
--- a/ee/spec/requests/repositories/git_http_controller_spec.rb
+++ b/ee/spec/requests/repositories/git_http_controller_spec.rb
@@ -8,6 +8,7 @@
let_it_be(:user) { create(:user) }
let_it_be(:project) { create(:project, :repository, :private) }
+
let(:env) { { user: user.username, password: user.password } }
let(:path) { "#{project.full_path}.git" }
@@ -136,6 +137,7 @@
let_it_be(:group) { create(:group, :wiki_repo) }
let_it_be(:user) { create(:user) }
+
let(:path) { "#{group.wiki.full_path}.git" }
before_all do
diff --git a/ee/spec/services/alert_management/extract_alert_payload_fields_service_spec.rb b/ee/spec/services/alert_management/extract_alert_payload_fields_service_spec.rb
index f1bad09794a8d297405543f73c85cf1f88b5a350..157b7d549cf16e667a961e3381716cd9bbdf6a64 100644
--- a/ee/spec/services/alert_management/extract_alert_payload_fields_service_spec.rb
+++ b/ee/spec/services/alert_management/extract_alert_payload_fields_service_spec.rb
@@ -7,6 +7,7 @@
let_it_be(:user_with_permissions) { create(:user) }
let_it_be(:user_without_permissions) { create(:user) }
let_it_be(:user) { user_with_permissions }
+
let(:payload) { { foo: 'bar' } }
let(:payload_json) { Gitlab::Json.generate(payload) }
let(:params) { { payload: payload_json } }
diff --git a/ee/spec/services/alert_management/process_prometheus_alert_service_spec.rb b/ee/spec/services/alert_management/process_prometheus_alert_service_spec.rb
index a4d4528816029a1afb765c53cb843f98faf1f2d3..4d1878e0c27ed2c352c8f09e26ca8cfab8efa61d 100644
--- a/ee/spec/services/alert_management/process_prometheus_alert_service_spec.rb
+++ b/ee/spec/services/alert_management/process_prometheus_alert_service_spec.rb
@@ -31,6 +31,7 @@
let_it_be(:schedule) { create(:incident_management_oncall_schedule, project: project) }
let_it_be(:rotation) { create(:incident_management_oncall_rotation, schedule: schedule) }
let_it_be(:participant) { create(:incident_management_oncall_participant, :with_developer_access, rotation: rotation) }
+
let(:users) { [participant.user] }
before do
diff --git a/ee/spec/services/approval_rules/create_service_spec.rb b/ee/spec/services/approval_rules/create_service_spec.rb
index dd22ef9ee177ddfdb2ab06d5c14005880c9655d9..fbce9a6ae7d400994676259dc81422ceaf227fcd 100644
--- a/ee/spec/services/approval_rules/create_service_spec.rb
+++ b/ee/spec/services/approval_rules/create_service_spec.rb
@@ -230,6 +230,7 @@
context 'when project rule id is present' do
let_it_be(:project_user) { create(:user) }
let_it_be(:public_group) { create(:group, :public) }
+
let(:project_user_approvers) { [project_user] }
let(:group_user_approvers) { [public_group] }
let(:merge_request_approvers) { {} }
diff --git a/ee/spec/services/audit_event_service_spec.rb b/ee/spec/services/audit_event_service_spec.rb
index b47cce1804f2afbb2e917411a7b3fbe4989d123a..e8044e4c6037c321b56b1952debc6226f455e7e4 100644
--- a/ee/spec/services/audit_event_service_spec.rb
+++ b/ee/spec/services/audit_event_service_spec.rb
@@ -6,6 +6,7 @@
let(:project) { build_stubbed(:project) }
let_it_be(:user) { create(:user, current_sign_in_ip: '192.168.68.104') }
let_it_be(:project_member) { create(:project_member, user: user, expires_at: 1.day.from_now) }
+
let(:request_ip_address) { '127.0.0.1' }
let(:details) { { action: :destroy, ip_address: request_ip_address } }
@@ -453,6 +454,7 @@
describe '#for_project' do
let_it_be(:current_user) { create(:user, name: 'Test User') }
let_it_be(:project) { create(:project) }
+
let(:action) { :destroy }
let(:options) { { action: action } }
@@ -476,6 +478,7 @@
describe '#for_group' do
let_it_be(:user) { create(:user, name: 'Test User') }
let_it_be(:group) { create(:group) }
+
let(:action) { :destroy }
let(:options) { { action: action } }
let(:service) { described_class.new(user, group, options).for_group }
diff --git a/ee/spec/services/billable_members/destroy_service_spec.rb b/ee/spec/services/billable_members/destroy_service_spec.rb
index 4f0407914793625d5e4fb349008b968742eac64b..642c3457837ee968dc14ec4e5761dc4b03d24269 100644
--- a/ee/spec/services/billable_members/destroy_service_spec.rb
+++ b/ee/spec/services/billable_members/destroy_service_spec.rb
@@ -6,6 +6,7 @@
describe '#execute' do
let_it_be(:current_user) { create(:user) }
let_it_be(:root_group) { create(:group) }
+
let(:group) { root_group }
let(:user_id) { nil }
diff --git a/ee/spec/services/boards/epic_boards/destroy_service_spec.rb b/ee/spec/services/boards/epic_boards/destroy_service_spec.rb
index 9567656bff475e22f5e3c7d6d7fdc356f0a98de2..ee99df23d96ce7c76515c31523497c0f09e3db91 100644
--- a/ee/spec/services/boards/epic_boards/destroy_service_spec.rb
+++ b/ee/spec/services/boards/epic_boards/destroy_service_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe Boards::EpicBoards::DestroyService do
let_it_be(:parent) { create(:group) }
+
let(:boards) { parent.epic_boards }
let(:board_factory) { :epic_board }
diff --git a/ee/spec/services/clusters/agent_tokens/create_service_spec.rb b/ee/spec/services/clusters/agent_tokens/create_service_spec.rb
index 3ce936bc662c1c9f51bddd1433f509f4708e385e..1775a8febe9768d1e0f115594f5d655b46e985ef 100644
--- a/ee/spec/services/clusters/agent_tokens/create_service_spec.rb
+++ b/ee/spec/services/clusters/agent_tokens/create_service_spec.rb
@@ -6,6 +6,7 @@
subject(:service) { described_class.new(container: project, current_user: user, params: params) }
let_it_be(:user) { create(:user) }
+
let(:cluster_agent) { create(:cluster_agent) }
let(:project) { cluster_agent.project }
let(:params) { { agent_id: cluster_agent.id, description: 'token description', name: 'token name' } }
diff --git a/ee/spec/services/compliance_management/frameworks/create_service_spec.rb b/ee/spec/services/compliance_management/frameworks/create_service_spec.rb
index c909abf503661fe0c8b0645c1526f839a249c61d..fec3a06ddc4ef573fa087f078f0d38879db4f565 100644
--- a/ee/spec/services/compliance_management/frameworks/create_service_spec.rb
+++ b/ee/spec/services/compliance_management/frameworks/create_service_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe ComplianceManagement::Frameworks::CreateService do
let_it_be_with_refind(:namespace) { create(:namespace) }
+
let(:params) do
{
name: 'GDPR',
@@ -36,6 +37,7 @@
context 'namespace has a parent' do
let_it_be(:user) { create(:user) }
let_it_be_with_reload(:group) { create(:group, :with_hierarchy) }
+
let(:descendant) { group.descendants.first }
before do
diff --git a/ee/spec/services/compliance_management/frameworks/update_service_spec.rb b/ee/spec/services/compliance_management/frameworks/update_service_spec.rb
index ea3ebd6612c459307abd7b3ae125e6292d376d5f..ed068b8e9b10c790f7e3c44f1b80640da81c8d84 100644
--- a/ee/spec/services/compliance_management/frameworks/update_service_spec.rb
+++ b/ee/spec/services/compliance_management/frameworks/update_service_spec.rb
@@ -5,6 +5,7 @@
RSpec.describe ComplianceManagement::Frameworks::UpdateService do
let_it_be_with_refind(:namespace) { create(:namespace) }
let_it_be_with_refind(:framework) { create(:compliance_framework, namespace: namespace) }
+
let(:current_user) { namespace.owner }
let(:params) { { color: '#000001', description: 'New Description', name: 'New Name' } }
diff --git a/ee/spec/services/external_status_checks/create_service_spec.rb b/ee/spec/services/external_status_checks/create_service_spec.rb
index 43685429ea846a6bb947a36f0820e1cdcc71b2cd..310db1dcf64e3b381a4616accb3f7b6a9d6c6890 100644
--- a/ee/spec/services/external_status_checks/create_service_spec.rb
+++ b/ee/spec/services/external_status_checks/create_service_spec.rb
@@ -5,6 +5,7 @@
RSpec.describe ExternalStatusChecks::CreateService do
let_it_be(:project) { create(:project) }
let_it_be(:protected_branch) { create(:protected_branch, project: project) }
+
let(:user) { project.owner }
let(:params) do
{
diff --git a/ee/spec/services/external_status_checks/destroy_service_spec.rb b/ee/spec/services/external_status_checks/destroy_service_spec.rb
index 4d0f3dd2a35a3cd940363247f7925a000d247a38..029d17433ad83bc166d39976d4cb79afe8d98b4c 100644
--- a/ee/spec/services/external_status_checks/destroy_service_spec.rb
+++ b/ee/spec/services/external_status_checks/destroy_service_spec.rb
@@ -5,6 +5,7 @@
RSpec.describe ExternalStatusChecks::DestroyService do
let_it_be(:project) { create(:project) }
let_it_be(:rule) { create(:external_status_check, project: project) }
+
let(:current_user) { project.owner }
subject { described_class.new(container: project, current_user: current_user).execute(rule) }
diff --git a/ee/spec/services/external_status_checks/update_service_spec.rb b/ee/spec/services/external_status_checks/update_service_spec.rb
index 25057b444f37abdf44025dcb755f7b72f9e5a47e..dfe88ebca654f500a94165d84be4d438d6732ce0 100644
--- a/ee/spec/services/external_status_checks/update_service_spec.rb
+++ b/ee/spec/services/external_status_checks/update_service_spec.rb
@@ -6,6 +6,7 @@
let_it_be(:project) { create(:project) }
let_it_be(:check) { create(:external_status_check, project: project) }
let_it_be(:protected_branch) { create(:protected_branch, project: project) }
+
let(:current_user) { project.owner }
let(:params) { { id: project.id, check_id: check.id, external_url: 'http://newvalue.com', name: 'new name', protected_branch_ids: [protected_branch.id] } }
diff --git a/ee/spec/services/gitlab_subscriptions/activate_service_spec.rb b/ee/spec/services/gitlab_subscriptions/activate_service_spec.rb
index 626c2624469e64d474601a36f90a216cb45fb43b..e9ed4457420a6f86c4a16e6352cf9a68cf85ab3a 100644
--- a/ee/spec/services/gitlab_subscriptions/activate_service_spec.rb
+++ b/ee/spec/services/gitlab_subscriptions/activate_service_spec.rb
@@ -11,6 +11,7 @@
end
let_it_be(:license_key) { build(:gitlab_license).export }
+
let(:cloud_license_enabled) { true }
let(:activation_code) { 'activation_code' }
diff --git a/ee/spec/services/gitlab_subscriptions/apply_trial_service_spec.rb b/ee/spec/services/gitlab_subscriptions/apply_trial_service_spec.rb
index f26f0a20e020df667e943c920ae2ae7411ebdaa9..e398fe58a454c6de82105bf0f8c2a3a17db87f6b 100644
--- a/ee/spec/services/gitlab_subscriptions/apply_trial_service_spec.rb
+++ b/ee/spec/services/gitlab_subscriptions/apply_trial_service_spec.rb
@@ -6,6 +6,7 @@
subject(:execute) { described_class.new.execute(apply_trial_params) }
let_it_be(:namespace) { create(:namespace) }
+
let(:apply_trial_params) do
{
trial_user: {
diff --git a/ee/spec/services/incident_management/incidents/upload_metric_service_spec.rb b/ee/spec/services/incident_management/incidents/upload_metric_service_spec.rb
index 7e04f320a18aaa25251afc1b9efc9cbcf54ed23a..80d72b49739c480a6ef03603b54611f7e246681c 100644
--- a/ee/spec/services/incident_management/incidents/upload_metric_service_spec.rb
+++ b/ee/spec/services/incident_management/incidents/upload_metric_service_spec.rb
@@ -8,6 +8,7 @@
let_it_be_with_refind(:project) { create(:project) }
let_it_be_with_refind(:issuable) { create(:incident, project: project) }
let_it_be_with_refind(:current_user) { create(:user) }
+
let(:params) do
{
file: fixture_file_upload('spec/fixtures/rails_sample.jpg', 'image/jpg'),
diff --git a/ee/spec/services/incident_management/oncall_rotations/edit_service_spec.rb b/ee/spec/services/incident_management/oncall_rotations/edit_service_spec.rb
index 2156961f4bdc5bdfc5df4b11d974825416b4f828..e22fd95bf57380771e09676c965a43823e0f48ae 100644
--- a/ee/spec/services/incident_management/oncall_rotations/edit_service_spec.rb
+++ b/ee/spec/services/incident_management/oncall_rotations/edit_service_spec.rb
@@ -9,6 +9,7 @@
let_it_be_with_refind(:oncall_schedule) { create(:incident_management_oncall_schedule, :utc, project: project) }
let_it_be_with_refind(:oncall_rotation) { create(:incident_management_oncall_rotation, :with_participants, schedule: oncall_schedule, participants_count: 2) }
+
let(:current_user) { user_with_permissions }
let(:params) { rotation_params }
let(:service) { described_class.new(oncall_rotation, current_user, params) }
diff --git a/ee/spec/services/merge_request_approval_settings/update_service_spec.rb b/ee/spec/services/merge_request_approval_settings/update_service_spec.rb
index 01bd5756663b96c49708cd7f95b93b381175e1e9..9e5fa5f64314374f0759404b0d2e61f9f209890d 100644
--- a/ee/spec/services/merge_request_approval_settings/update_service_spec.rb
+++ b/ee/spec/services/merge_request_approval_settings/update_service_spec.rb
@@ -5,6 +5,7 @@
RSpec.describe MergeRequestApprovalSettings::UpdateService do
let_it_be_with_reload(:group) { create(:group) }
let_it_be(:user) { create(:user) }
+
let(:params) { { allow_author_approval: true } }
subject(:service) do
diff --git a/ee/spec/services/personal_access_tokens/create_service_audit_log_spec.rb b/ee/spec/services/personal_access_tokens/create_service_audit_log_spec.rb
index 04f3a599e012e881a06cb6fc1fbe4c9fea4cc227..8f2eda8a67120ed3d5f4ba1dfbf2583694bf74d2 100644
--- a/ee/spec/services/personal_access_tokens/create_service_audit_log_spec.rb
+++ b/ee/spec/services/personal_access_tokens/create_service_audit_log_spec.rb
@@ -5,6 +5,7 @@
RSpec.describe PersonalAccessTokens::CreateService do
describe '#execute' do
let_it_be(:user) { create(:user) }
+
let(:params) { { name: 'admin-token', impersonation: true, scopes: [:api], expires_at: Date.today + 1.month } }
context 'when non-admin user' do
diff --git a/ee/spec/services/personal_access_tokens/groups/update_lifetime_service_spec.rb b/ee/spec/services/personal_access_tokens/groups/update_lifetime_service_spec.rb
index d4a9b1ab7e8c641eec8912ad2d00ef150de2c8f8..70cfee032f6a1f967bb3894eaff3811a0c2a132b 100644
--- a/ee/spec/services/personal_access_tokens/groups/update_lifetime_service_spec.rb
+++ b/ee/spec/services/personal_access_tokens/groups/update_lifetime_service_spec.rb
@@ -7,6 +7,7 @@
describe '#execute', :clean_gitlab_redis_shared_state do
let_it_be(:group) { create(:group_with_managed_accounts)}
+
subject { described_class.new(group) }
let(:lease_key) { "personal_access_tokens/groups/update_lifetime_service:group_id:#{group.id}" }
diff --git a/ee/spec/services/push_rules/create_or_update_service_spec.rb b/ee/spec/services/push_rules/create_or_update_service_spec.rb
index d42b4b6fcb9649026ee648478ffca67acd4cb74c..c8822ffadbbe8c16b3ec5be3dc03ea434a41a03b 100644
--- a/ee/spec/services/push_rules/create_or_update_service_spec.rb
+++ b/ee/spec/services/push_rules/create_or_update_service_spec.rb
@@ -5,6 +5,7 @@
RSpec.describe PushRules::CreateOrUpdateService, '#execute' do
let_it_be_with_reload(:project) { create(:project) }
let_it_be(:user) { create(:user) }
+
let(:params) { { max_file_size: 28 } }
subject { described_class.new(container: project, current_user: user, params: params) }
diff --git a/ee/spec/services/quality_management/test_cases/create_service_spec.rb b/ee/spec/services/quality_management/test_cases/create_service_spec.rb
index 768206eb0db371240bcc4469a5ece12c55189b26..73357ad8a6b142c9e4d221c56411938aec75d4d2 100644
--- a/ee/spec/services/quality_management/test_cases/create_service_spec.rb
+++ b/ee/spec/services/quality_management/test_cases/create_service_spec.rb
@@ -7,6 +7,7 @@
let_it_be_with_refind(:project) { create(:project, :empty_repo) }
let(:description) { 'test case description' }
let_it_be(:label) { create(:label, project: project) }
+
let(:service) { described_class.new(project, user, title: title, description: description, label_ids: [label.id]) }
describe '#execute' do
diff --git a/ee/spec/services/quick_actions/interpret_service_spec.rb b/ee/spec/services/quick_actions/interpret_service_spec.rb
index 756edc602c326e1e103e55ef8fe5ca7e76593302..3d092b1c600785790f6f66d107522cfef7a67106 100644
--- a/ee/spec/services/quick_actions/interpret_service_spec.rb
+++ b/ee/spec/services/quick_actions/interpret_service_spec.rb
@@ -12,6 +12,7 @@
let_it_be_with_refind(:group) { create(:group) }
let_it_be_with_refind(:project) { create(:project, :repository, :public, group: group) }
let_it_be_with_reload(:issue) { create(:issue, project: project) }
+
let(:service) { described_class.new(project, current_user) }
before do
diff --git a/ee/spec/services/requirements_management/create_requirement_service_spec.rb b/ee/spec/services/requirements_management/create_requirement_service_spec.rb
index bd02bc629c50701c23c5c9ff858e25771af83484..86db3252a439cbe1fe2503766991e6729529963d 100644
--- a/ee/spec/services/requirements_management/create_requirement_service_spec.rb
+++ b/ee/spec/services/requirements_management/create_requirement_service_spec.rb
@@ -6,6 +6,7 @@
let_it_be(:project) { create(:project)}
let_it_be(:user) { create(:user) }
let_it_be(:other_user) { create(:user) }
+
let(:params) { { title: 'foo', author_id: other_user.id, created_at: 2.days.ago } }
subject { described_class.new(project: project, current_user: user, params: params).execute }
diff --git a/ee/spec/services/requirements_management/export_csv_service_spec.rb b/ee/spec/services/requirements_management/export_csv_service_spec.rb
index 1ebf5b96beba10fefdc02e31fecac43fb0d12be5..e92bd22e994e9967a97acd006cd1d0eb08fa5b67 100644
--- a/ee/spec/services/requirements_management/export_csv_service_spec.rb
+++ b/ee/spec/services/requirements_management/export_csv_service_spec.rb
@@ -7,6 +7,7 @@
let_it_be(:group) { create_default(:group) }
let_it_be(:project) { create_default(:project, :public) }
let_it_be_with_reload(:requirement) { create(:requirement, state: :opened, author: user) }
+
let(:fields) { [] }
subject { described_class.new(RequirementsManagement::Requirement.all, project, fields) }
@@ -39,6 +40,7 @@ def csv
context 'includes' do
let_it_be(:report) { create(:test_report, requirement: requirement, state: :passed, build: nil, author: user) }
+
let(:time_format) { '%Y-%m-%d %H:%M:%S %Z' }
it 'includes the columns required for import' do
diff --git a/ee/spec/services/requirements_management/update_requirement_service_spec.rb b/ee/spec/services/requirements_management/update_requirement_service_spec.rb
index 24d88f00130fd91e0d5d048666c8b8775f0bd3ca..d7bd439a21d23dcc50f1c079bfbaaf536d9dcc10 100644
--- a/ee/spec/services/requirements_management/update_requirement_service_spec.rb
+++ b/ee/spec/services/requirements_management/update_requirement_service_spec.rb
@@ -6,6 +6,7 @@
let_it_be(:project) { create(:project)}
let_it_be(:user) { create(:user) }
let_it_be(:requirement) { create(:requirement, project: project) }
+
let(:params) do
{
title: 'foo',
diff --git a/spec/controllers/confirmations_controller_spec.rb b/spec/controllers/confirmations_controller_spec.rb
index c9a0ae981fc696bb41d16bfcbd68c5fe767fecbe..401ee36b387b851b9396021b67af4120f9b0e7ec 100644
--- a/spec/controllers/confirmations_controller_spec.rb
+++ b/spec/controllers/confirmations_controller_spec.rb
@@ -18,6 +18,7 @@ def perform_request
context 'user is already confirmed' do
let_it_be_with_reload(:user) { create(:user, :unconfirmed) }
+
let(:confirmation_token) { user.confirmation_token }
before do
@@ -57,6 +58,7 @@ def perform_request
context 'user accesses the link after the expiry of confirmation token has passed' do
let_it_be_with_reload(:user) { create(:user, :unconfirmed) }
+
let(:confirmation_token) { user.confirmation_token }
before do
diff --git a/spec/controllers/dashboard/projects_controller_spec.rb b/spec/controllers/dashboard/projects_controller_spec.rb
index ed8dc1eb7cb0944169b745065cd526e300932050..0d9bd1467783a6d8e4af98fe29f47624e59b6147 100644
--- a/spec/controllers/dashboard/projects_controller_spec.rb
+++ b/spec/controllers/dashboard/projects_controller_spec.rb
@@ -15,6 +15,7 @@
context 'user logged in' do
let_it_be(:project) { create(:project, name: 'Project 1') }
let_it_be(:project2) { create(:project, name: 'Project Two') }
+
let(:projects) { [project, project2] }
before_all do
diff --git a/spec/controllers/invites_controller_spec.rb b/spec/controllers/invites_controller_spec.rb
index 7c06ed9ae62ebabe659e91533a6c0f27de00e072..0d9cde88ecab27ce8bdbc564701aac063f42997e 100644
--- a/spec/controllers/invites_controller_spec.rb
+++ b/spec/controllers/invites_controller_spec.rb
@@ -5,6 +5,7 @@
RSpec.describe InvitesController do
let_it_be(:user) { create(:user) }
let_it_be(:member, reload: true) { create(:project_member, :invited, invite_email: user.email) }
+
let(:raw_invite_token) { member.raw_invite_token }
let(:project_members) { member.source.users }
let(:md5_member_global_id) { Digest::MD5.hexdigest(member.to_global_id.to_s) }
diff --git a/spec/controllers/profiles/emails_controller_spec.rb b/spec/controllers/profiles/emails_controller_spec.rb
index 950120ae56408a92b37f39e981a10c1ee7046f53..ce16632472fd77b14c52e4e706164a67cccd82d0 100644
--- a/spec/controllers/profiles/emails_controller_spec.rb
+++ b/spec/controllers/profiles/emails_controller_spec.rb
@@ -63,6 +63,7 @@
describe '#resend_confirmation_instructions' do
let_it_be(:email) { create(:email, user: user) }
+
let(:params) { { id: email.id } }
subject { put(:resend_confirmation_instructions, params: params) }
diff --git a/spec/controllers/users/terms_controller_spec.rb b/spec/controllers/users/terms_controller_spec.rb
index 0acc300818780eef574f9d8cd461be6ced2e1e1a..30b8eb5a958d19c4cc1d0b3a6d6a2579f6d5df5b 100644
--- a/spec/controllers/users/terms_controller_spec.rb
+++ b/spec/controllers/users/terms_controller_spec.rb
@@ -6,6 +6,7 @@
include TermsHelper
let_it_be(:user) { create(:user) }
+
let(:term) { create(:term) }
before do
diff --git a/spec/features/cycle_analytics_spec.rb b/spec/features/cycle_analytics_spec.rb
index 8c7564535b5c32ffa147920d3a0ca8b34d01ff18..d0f8767884efd0294e1e67b7cdec772c85f3f668 100644
--- a/spec/features/cycle_analytics_spec.rb
+++ b/spec/features/cycle_analytics_spec.rb
@@ -6,6 +6,7 @@
let_it_be(:user) { create(:user) }
let_it_be(:guest) { create(:user) }
let_it_be(:project) { create(:project, :repository) }
+
let(:issue) { create(:issue, project: project, created_at: 2.days.ago) }
let(:milestone) { create(:milestone, project: project) }
let(:mr) { create_merge_request_closing_issue(user, project, issue, commit_message: "References #{issue.to_reference}") }
diff --git a/spec/features/dashboard/datetime_on_tooltips_spec.rb b/spec/features/dashboard/datetime_on_tooltips_spec.rb
index 442b8904974375b173a906800639a0060310341c..bf9f6895d24b0060bd32b08d68d0ecc8f186565e 100644
--- a/spec/features/dashboard/datetime_on_tooltips_spec.rb
+++ b/spec/features/dashboard/datetime_on_tooltips_spec.rb
@@ -5,6 +5,7 @@
RSpec.describe 'Tooltips on .timeago dates', :js do
let_it_be(:user) { create(:user) }
let_it_be(:project) { create(:project, name: 'test', namespace: user.namespace) }
+
let(:created_date) { 1.day.ago.beginning_of_minute - 1.hour }
before_all do
diff --git a/spec/features/dashboard/merge_requests_spec.rb b/spec/features/dashboard/merge_requests_spec.rb
index 26b376be660488276a273b0be9ede5fde0e45131..aa2485d4236c43023b57c0e8789d6a4ed5a4d07c 100644
--- a/spec/features/dashboard/merge_requests_spec.rb
+++ b/spec/features/dashboard/merge_requests_spec.rb
@@ -53,6 +53,7 @@
context 'merge requests exist' do
let_it_be(:author_user) { create(:user) }
+
let(:label) { create(:label) }
let!(:assigned_merge_request) do
@@ -181,6 +182,7 @@
context 'merge request review', :js do
let_it_be(:author_user) { create(:user) }
+
let!(:review_requested_merge_request) do
create(:merge_request,
reviewers: [current_user],
diff --git a/spec/features/file_uploads/group_import_spec.rb b/spec/features/file_uploads/group_import_spec.rb
index 0f9d05c3975c2a386fc152c2d17c6bc2f07edda7..a8592f99bd6f76bda07cffc65eedd6811a51af2d 100644
--- a/spec/features/file_uploads/group_import_spec.rb
+++ b/spec/features/file_uploads/group_import_spec.rb
@@ -7,6 +7,7 @@
let_it_be(:user) { create(:user, :admin) }
let_it_be(:personal_access_token) { create(:personal_access_token, user: user) }
+
let(:api_path) { '/groups/import' }
let(:url) { capybara_url(api(api_path, personal_access_token: personal_access_token)) }
let(:file) { fixture_file_upload('spec/fixtures/group_export.tar.gz') }
diff --git a/spec/features/file_uploads/project_import_spec.rb b/spec/features/file_uploads/project_import_spec.rb
index 1bf16f46c63add89f5941d19393e853d61ba02c8..82b6f490d2abf570a9b7467fcff07045ef9dd876 100644
--- a/spec/features/file_uploads/project_import_spec.rb
+++ b/spec/features/file_uploads/project_import_spec.rb
@@ -7,6 +7,7 @@
let_it_be(:user) { create(:user, :admin) }
let_it_be(:personal_access_token) { create(:personal_access_token, user: user) }
+
let(:api_path) { '/projects/import' }
let(:url) { capybara_url(api(api_path, personal_access_token: personal_access_token)) }
let(:file) { fixture_file_upload('spec/features/projects/import_export/test_project_export.tar.gz') }
diff --git a/spec/features/file_uploads/user_avatar_spec.rb b/spec/features/file_uploads/user_avatar_spec.rb
index 043115be61a3061192febcc8d2498cbf90dd2f42..c30e3452201570d3c16f4140164f14f83d38c60a 100644
--- a/spec/features/file_uploads/user_avatar_spec.rb
+++ b/spec/features/file_uploads/user_avatar_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe 'Upload a user avatar', :js do
let_it_be(:user, reload: true) { create(:user) }
+
let(:file) { fixture_file_upload('spec/fixtures/banana_sample.gif') }
before do
diff --git a/spec/features/issues/user_sees_breadcrumb_links_spec.rb b/spec/features/issues/user_sees_breadcrumb_links_spec.rb
index f5793758a9b2e32068abb5f31a61b074f5da875d..9f8cd2a769d1c333c73e4daddebd6c3dd086823f 100644
--- a/spec/features/issues/user_sees_breadcrumb_links_spec.rb
+++ b/spec/features/issues/user_sees_breadcrumb_links_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe 'New issue breadcrumb' do
let_it_be(:project, reload: true) { create(:project) }
+
let(:user) { project.creator }
before do
diff --git a/spec/features/markdown/metrics_spec.rb b/spec/features/markdown/metrics_spec.rb
index f9781f6c702f6ebd7e8c97b416863a19136cfac7..bc4eea119c07324f45c364c8e7ba7cc01aa8dbe8 100644
--- a/spec/features/markdown/metrics_spec.rb
+++ b/spec/features/markdown/metrics_spec.rb
@@ -180,6 +180,7 @@
end
let_it_be(:cluster) { create(:cluster, :provided_by_gcp, :project, projects: [project], user: user) }
+
let(:params) { [project.namespace.path, project.path, cluster.id] }
let(:query_params) { { group: 'Cluster Health', title: 'CPU Usage', y_label: 'CPU (cores)' } }
let(:metrics_url) { urls.namespace_project_cluster_url(*params, **query_params) }
diff --git a/spec/features/participants_autocomplete_spec.rb b/spec/features/participants_autocomplete_spec.rb
index 2781cfffbafbf0a035cad92b0d2e3e42837f06ac..cc805e7d369d9edc7998c84874cc608876a7805e 100644
--- a/spec/features/participants_autocomplete_spec.rb
+++ b/spec/features/participants_autocomplete_spec.rb
@@ -6,6 +6,7 @@
let_it_be(:project) { create(:project, :public, :repository) }
let_it_be(:user) { create(:user) }
let_it_be(:author) { create(:user) }
+
let(:note) { create(:note, noteable: noteable, project: noteable.project) }
before do
diff --git a/spec/features/snippets/embedded_snippet_spec.rb b/spec/features/snippets/embedded_snippet_spec.rb
index b799fb2fc008e5897a7c8da5a4816fc52d326c16..ff876d8cc4fd0948c3dc8af1b4b089e910ed4644 100644
--- a/spec/features/snippets/embedded_snippet_spec.rb
+++ b/spec/features/snippets/embedded_snippet_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe 'Embedded Snippets' do
let_it_be(:snippet) { create(:personal_snippet, :public, :repository) }
+
let(:blobs) { snippet.blobs.first(3) }
it 'loads snippet', :js do
diff --git a/spec/finders/alert_management/alerts_finder_spec.rb b/spec/finders/alert_management/alerts_finder_spec.rb
index 3a88db5d8542c578b495d3d87d252079190b366c..7fcbc7b20a14536d78513491e46806e872015715 100644
--- a/spec/finders/alert_management/alerts_finder_spec.rb
+++ b/spec/finders/alert_management/alerts_finder_spec.rb
@@ -266,6 +266,7 @@
context 'assignee username given' do
let_it_be(:assignee) { create(:user) }
let_it_be(:alert) { create(:alert_management_alert, project: project, assignees: [assignee]) }
+
let(:params) { { assignee_username: username } }
context 'with valid assignee_username' do
diff --git a/spec/finders/ci/commit_statuses_finder_spec.rb b/spec/finders/ci/commit_statuses_finder_spec.rb
index 05a1a98cfe046aa5c2d1c9cc3eb57f19f0bda537..2e26e38f4b46f1ed6ab83002e2ee858c0ce9d0e8 100644
--- a/spec/finders/ci/commit_statuses_finder_spec.rb
+++ b/spec/finders/ci/commit_statuses_finder_spec.rb
@@ -9,6 +9,7 @@
context 'tag refs' do
let_it_be(:tags) { TagsFinder.new(project.repository, {}).execute }
+
let(:subject) { described_class.new(project, project.repository, user, tags).execute }
context 'no pipelines' do
@@ -131,6 +132,7 @@
context 'CI pipelines visible to' do
let_it_be(:tags) { TagsFinder.new(project.repository, {}).execute }
+
let(:subject) { described_class.new(project, project.repository, user, tags).execute }
before do
diff --git a/spec/finders/container_repositories_finder_spec.rb b/spec/finders/container_repositories_finder_spec.rb
index 983f6dba28bdd14e9abdf791cf2eb087a785f71a..d247d61ecdb2985266e8344fda6a674a7167b59f 100644
--- a/spec/finders/container_repositories_finder_spec.rb
+++ b/spec/finders/container_repositories_finder_spec.rb
@@ -9,6 +9,7 @@
let_it_be(:group) { create(:group) }
let_it_be(:project) { create(:project, group: group) }
let_it_be(:project_repository) { create(:container_repository, name: 'my_image', project: project) }
+
let(:params) { {} }
before do
diff --git a/spec/finders/deployments_finder_spec.rb b/spec/finders/deployments_finder_spec.rb
index bd03b254f40465c49c5e6f969131ba05bc81c3d1..6d9d0c33de335948f1a767a1800a484f84f3613a 100644
--- a/spec/finders/deployments_finder_spec.rb
+++ b/spec/finders/deployments_finder_spec.rb
@@ -68,6 +68,7 @@
context 'at project scope' do
let_it_be(:project) { create(:project, :public, :test_repo) }
+
let(:base_params) { { project: project } }
describe 'filtering' do
@@ -76,6 +77,7 @@
let_it_be(:deployment_2) { create(:deployment, :success, project: project, updated_at: 47.hours.ago) }
let_it_be(:deployment_3) { create(:deployment, :success, project: project, updated_at: 4.days.ago) }
let_it_be(:deployment_4) { create(:deployment, :success, project: project, updated_at: 1.hour.ago) }
+
let(:params) { { **base_params, updated_before: 1.day.ago, updated_after: 3.days.ago, order_by: :updated_at } }
it 'returns deployments with matched updated_at' do
@@ -268,6 +270,7 @@
let_it_be(:group_project_1) { create(:project, :public, :test_repo, group: group) }
let_it_be(:group_project_2) { create(:project, :public, :test_repo, group: group) }
let_it_be(:subgroup_project_1) { create(:project, :public, :test_repo, group: subgroup) }
+
let(:base_params) { { group: group } }
describe 'ordering' do
diff --git a/spec/finders/events_finder_spec.rb b/spec/finders/events_finder_spec.rb
index fe2e449f03ddecac296e46077ba5e66e6b090332..5ecd38cd9cc3b2d0e62076ec9a86743c8bd3e58b 100644
--- a/spec/finders/events_finder_spec.rb
+++ b/spec/finders/events_finder_spec.rb
@@ -22,6 +22,7 @@
let!(:other_developer_event) { create(:event, :created, project: project1, author: other_user, target: opened_merge_request3 ) }
let_it_be(:public_project) { create(:project, :public, creator_id: user.id, namespace: user.namespace) }
+
let(:confidential_issue) { create(:closed_issue, confidential: true, project: public_project, author: user) }
let!(:confidential_event) { create(:event, :closed, project: public_project, author: user, target: confidential_issue) }
diff --git a/spec/finders/group_descendants_finder_spec.rb b/spec/finders/group_descendants_finder_spec.rb
index 3c3bb13a6295124ce21157bfc9b1cd2488453894..01c6eb0590753b8cb0f08ed3d9a71abfcc31c6ec 100644
--- a/spec/finders/group_descendants_finder_spec.rb
+++ b/spec/finders/group_descendants_finder_spec.rb
@@ -5,6 +5,7 @@
RSpec.describe GroupDescendantsFinder do
let_it_be(:user) { create(:user) }
let_it_be(:group) { create(:group) }
+
let(:params) { {} }
subject(:finder) do
diff --git a/spec/finders/groups_finder_spec.rb b/spec/finders/groups_finder_spec.rb
index d69720ae98e5bcda7eebd1d3388bb6a7d72bd28d..481e2983dd79d7c49b939ffad6bb94448c572c53 100644
--- a/spec/finders/groups_finder_spec.rb
+++ b/spec/finders/groups_finder_spec.rb
@@ -180,6 +180,7 @@
let_it_be(:internal_sub_subgroup) { create(:group, :internal, parent: public_subgroup) }
let_it_be(:private_sub_subgroup) { create(:group, :private, parent: public_subgroup) }
let_it_be(:public_sub_subgroup) { create(:group, :public, parent: public_subgroup) }
+
let(:params) { { include_parent_descendants: true, parent: parent_group } }
context 'with nil parent' do
diff --git a/spec/finders/packages/conan/package_file_finder_spec.rb b/spec/finders/packages/conan/package_file_finder_spec.rb
index d0c9efa14182f75b78f336472d8341de03ff0a7c..c2f445c58f711da8c76262f5adc35c38e3f516b2 100644
--- a/spec/finders/packages/conan/package_file_finder_spec.rb
+++ b/spec/finders/packages/conan/package_file_finder_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe ::Packages::Conan::PackageFileFinder do
let_it_be(:package) { create(:conan_package) }
let_it_be(:package_file) { package.package_files.first }
+
let(:package_file_name) { package_file.file_name }
let(:params) { {} }
diff --git a/spec/finders/packages/go/module_finder_spec.rb b/spec/finders/packages/go/module_finder_spec.rb
index e5c8827fc8dcca03b1ff0b4e09c1d63451571c94..a93fd85552964863323491c5b718ad9cd6b6745c 100644
--- a/spec/finders/packages/go/module_finder_spec.rb
+++ b/spec/finders/packages/go/module_finder_spec.rb
@@ -5,6 +5,7 @@
RSpec.describe Packages::Go::ModuleFinder do
let_it_be(:project) { create :project }
let_it_be(:other_project) { create :project }
+
let(:finder) { described_class.new project, module_name }
shared_examples 'an invalid path' do
diff --git a/spec/finders/packages/group_packages_finder_spec.rb b/spec/finders/packages/group_packages_finder_spec.rb
index 29b2f0fffd72d3dccbbde792185b434933894b13..d7f62bdfbb43c54d8a957da9e854a7849ee0de43 100644
--- a/spec/finders/packages/group_packages_finder_spec.rb
+++ b/spec/finders/packages/group_packages_finder_spec.rb
@@ -129,6 +129,7 @@ def self.package_types
context 'with package_name' do
let_it_be(:named_package) { create(:maven_package, project: project, name: 'maven') }
+
let(:params) { { package_name: package_name } }
context 'as complete name' do
diff --git a/spec/finders/packages/nuget/package_finder_spec.rb b/spec/finders/packages/nuget/package_finder_spec.rb
index 59cca2d06dc305df237b4151ff0ad1562b1d82c6..4ad02ce7da802c6080f32aba4544f2adee8e0de7 100644
--- a/spec/finders/packages/nuget/package_finder_spec.rb
+++ b/spec/finders/packages/nuget/package_finder_spec.rb
@@ -11,6 +11,7 @@
let_it_be(:package3) { create(:nuget_package, name: 'Another.Dummy.Package', project: project) }
let_it_be(:other_package_1) { create(:nuget_package, name: package1.name, version: package1.version) }
let_it_be(:other_package_2) { create(:nuget_package, name: package1.name, version: package2.version) }
+
let(:package_name) { package1.name }
let(:package_version) { nil }
let(:limit) { 50 }
@@ -57,6 +58,7 @@
let_it_be(:package4) { create(:nuget_package, name: package1.name, project: project) }
let_it_be(:package5) { create(:nuget_package, name: package1.name, project: project) }
let_it_be(:package6) { create(:nuget_package, name: package1.name, project: project) }
+
let(:limit) { 2 }
it { is_expected.to match_array([package5, package6]) }
diff --git a/spec/finders/packages/package_file_finder_spec.rb b/spec/finders/packages/package_file_finder_spec.rb
index ab58f75fcae2db148c84291bb11b3fb80924839e..8014f04d9173b5a3a779060a7ad6dfe3bfa37f27 100644
--- a/spec/finders/packages/package_file_finder_spec.rb
+++ b/spec/finders/packages/package_file_finder_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe Packages::PackageFileFinder do
let_it_be(:package) { create(:maven_package) }
let_it_be(:package_file) { package.package_files.first }
+
let(:package_file_name) { package_file.file_name }
let(:params) { {} }
diff --git a/spec/finders/packages/package_finder_spec.rb b/spec/finders/packages/package_finder_spec.rb
index 2bb4f05a41dce8bc421746e16b44f216e8ba2ba2..1b0c88a4771496377e0672bd5879c339281ce265 100644
--- a/spec/finders/packages/package_finder_spec.rb
+++ b/spec/finders/packages/package_finder_spec.rb
@@ -25,6 +25,7 @@
context 'processing packages' do
let_it_be(:nuget_package) { create(:nuget_package, :processing, project: project) }
+
let(:package_id) { nuget_package.id }
it 'are not returned' do
diff --git a/spec/finders/template_finder_spec.rb b/spec/finders/template_finder_spec.rb
index b7339288c51925073cf1224184f03723e492b902..97eecf8a89dc98461087f2e566c1506552300155 100644
--- a/spec/finders/template_finder_spec.rb
+++ b/spec/finders/template_finder_spec.rb
@@ -123,6 +123,7 @@
describe '#execute' do
let_it_be(:project) { nil }
+
let(:params) { {} }
subject(:result) { described_class.new(type, project, params).execute }
@@ -149,6 +150,7 @@
describe '#template_names' do
let_it_be(:project) { nil }
+
let(:params) { {} }
subject(:result) { described_class.new(type, project, params).template_names.values.flatten.map { |el| OpenStruct.new(el) } }
diff --git a/spec/finders/todos_finder_spec.rb b/spec/finders/todos_finder_spec.rb
index 577ad80ede1de0fdeecfb729b16024ce0693e9e7..5611a67e9776519e5c40b9a45b9ca2a98c425042 100644
--- a/spec/finders/todos_finder_spec.rb
+++ b/spec/finders/todos_finder_spec.rb
@@ -9,6 +9,7 @@
let_it_be(:project) { create(:project, :repository, namespace: group) }
let_it_be(:issue) { create(:issue, project: project) }
let_it_be(:merge_request) { create(:merge_request, source_project: project) }
+
let(:finder) { described_class }
before_all do
@@ -153,6 +154,7 @@
context 'by groups' do
context 'with subgroups' do
let_it_be(:subgroup) { create(:group, parent: group) }
+
let!(:todo3) { create(:todo, user: user, group: subgroup, target: issue) }
it 'returns todos from subgroups when filtered by a group' do
diff --git a/spec/finders/user_recent_events_finder_spec.rb b/spec/finders/user_recent_events_finder_spec.rb
index 5a9243d150d0946819016eca96a72db3d5621673..74c563b9bf6698a7f035f10d308bf93da0b42dea 100644
--- a/spec/finders/user_recent_events_finder_spec.rb
+++ b/spec/finders/user_recent_events_finder_spec.rb
@@ -12,6 +12,7 @@
let!(:internal_event) { create(:event, project: internal_project, author: project_owner) }
let!(:public_event) { create(:event, project: public_project, author: project_owner) }
let_it_be(:issue) { create(:issue, project: public_project) }
+
let(:limit) { nil }
let(:params) { { limit: limit } }
@@ -43,6 +44,7 @@
context 'events from multiple users' do
let_it_be(:second_user, reload: true) { create(:user) }
let_it_be(:private_project_second_user) { create(:project, :private, creator: second_user) }
+
let(:internal_project_second_user) { create(:project, :internal, creator: second_user) }
let(:public_project_second_user) { create(:project, :public, creator: second_user) }
let!(:private_event_second_user) { create(:event, project: private_project_second_user, author: second_user) }
diff --git a/spec/frontend/fixtures/pipelines.rb b/spec/frontend/fixtures/pipelines.rb
index 2a538352abe59d2c54dc93ed5edaa4044da6be65..f695b74ec8738ccd3eab9e6b0dca7d21d344c1bf 100644
--- a/spec/frontend/fixtures/pipelines.rb
+++ b/spec/frontend/fixtures/pipelines.rb
@@ -13,6 +13,7 @@
let!(:build_pipeline_without_author) { create(:ci_build, pipeline: pipeline_without_author, stage: 'test') }
let_it_be(:pipeline_without_commit) { create(:ci_pipeline, status: :success, project: project, sha: '0000') }
+
let!(:build_pipeline_without_commit) { create(:ci_build, pipeline: pipeline_without_commit, stage: 'test') }
let(:commit) { create(:commit, project: project) }
diff --git a/spec/graphql/features/authorization_spec.rb b/spec/graphql/features/authorization_spec.rb
index 64e423e2bf8f681ab5303f9d9041957dd4ab7ae5..0dc3a9c85e7dcbc0b9e0338bc48162980d6880ea 100644
--- a/spec/graphql/features/authorization_spec.rb
+++ b/spec/graphql/features/authorization_spec.rb
@@ -7,6 +7,7 @@
include Graphql::ResolverFactories
let_it_be(:user) { create(:user) }
+
let(:permission_single) { :foo }
let(:permission_collection) { [:foo, :bar] }
let(:test_object) { double(name: 'My name') }
diff --git a/spec/graphql/gitlab_schema_spec.rb b/spec/graphql/gitlab_schema_spec.rb
index 1f2c518f83ccd82c794cb6c475c5d9cb1f653ad5..06505536b09eb5ac5d84b1ce5ba1a833b220a02d 100644
--- a/spec/graphql/gitlab_schema_spec.rb
+++ b/spec/graphql/gitlab_schema_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe GitlabSchema do
let_it_be(:connections) { GitlabSchema.connections.all_wrappers }
+
let(:user) { build :user }
it 'uses batch loading' do
diff --git a/spec/graphql/mutations/custom_emoji/create_spec.rb b/spec/graphql/mutations/custom_emoji/create_spec.rb
index 118c5d67188e36c87d4900d15ac24e5225df0daa..7c98e53a72cb74d4c9ae842a8e489ccdf05c96a4 100644
--- a/spec/graphql/mutations/custom_emoji/create_spec.rb
+++ b/spec/graphql/mutations/custom_emoji/create_spec.rb
@@ -5,6 +5,7 @@
RSpec.describe Mutations::CustomEmoji::Create do
let_it_be(:group) { create(:group) }
let_it_be(:user) { create(:user) }
+
let(:args) { { group_path: group.full_path, name: 'tanuki', url: 'https://about.gitlab.com/images/press/logo/png/gitlab-icon-rgb.png' } }
before do
diff --git a/spec/graphql/mutations/discussions/toggle_resolve_spec.rb b/spec/graphql/mutations/discussions/toggle_resolve_spec.rb
index 162b1249ab5d6e74a8e22de6c511490bf55950bf..b03c6cb094f1c3207be2496c7693415f460e90d2 100644
--- a/spec/graphql/mutations/discussions/toggle_resolve_spec.rb
+++ b/spec/graphql/mutations/discussions/toggle_resolve_spec.rb
@@ -140,6 +140,7 @@
context 'when discussion is on a merge request' do
let_it_be(:noteable) { create(:merge_request, source_project: project) }
+
let(:discussion) { create(:diff_note_on_merge_request, noteable: noteable, project: project).to_discussion }
it_behaves_like 'a working resolve method'
@@ -147,6 +148,7 @@
context 'when discussion is on a design' do
let_it_be(:noteable) { create(:design, :with_file, issue: create(:issue, project: project)) }
+
let(:discussion) { create(:diff_note_on_design, noteable: noteable, project: project).to_discussion }
it_behaves_like 'a working resolve method'
diff --git a/spec/graphql/mutations/environments/canary_ingress/update_spec.rb b/spec/graphql/mutations/environments/canary_ingress/update_spec.rb
index c022828cf098d0641e9c74c43c508121d9e49f1c..2715a908f859bfcc6ff6147118e5bc5d05094988 100644
--- a/spec/graphql/mutations/environments/canary_ingress/update_spec.rb
+++ b/spec/graphql/mutations/environments/canary_ingress/update_spec.rb
@@ -7,6 +7,7 @@
let_it_be(:environment) { create(:environment, project: project) }
let_it_be(:maintainer) { create(:user) }
let_it_be(:reporter) { create(:user) }
+
let(:user) { maintainer }
subject(:mutation) { described_class.new(object: nil, context: { current_user: user }, field: nil) }
diff --git a/spec/graphql/mutations/issues/set_severity_spec.rb b/spec/graphql/mutations/issues/set_severity_spec.rb
index 7698118ae3ee558fd62da1ea9880612392883407..401db6cdb4471860bd76a8c8c03e8fdc888fcb37 100644
--- a/spec/graphql/mutations/issues/set_severity_spec.rb
+++ b/spec/graphql/mutations/issues/set_severity_spec.rb
@@ -5,6 +5,7 @@
RSpec.describe Mutations::Issues::SetSeverity do
let_it_be(:user) { create(:user) }
let_it_be(:issue) { create(:incident) }
+
let(:mutation) { described_class.new(object: nil, context: { current_user: user }, field: nil) }
specify { expect(described_class).to require_graphql_authorizations(:update_issue) }
diff --git a/spec/graphql/mutations/labels/create_spec.rb b/spec/graphql/mutations/labels/create_spec.rb
index b2dd94f31bbc20a6e01e4f52254aba391318c506..53a1704112596469111b6a1a5de21a9ff0efb1d1 100644
--- a/spec/graphql/mutations/labels/create_spec.rb
+++ b/spec/graphql/mutations/labels/create_spec.rb
@@ -45,6 +45,7 @@
context 'when creating a project label' do
let_it_be(:parent) { create(:project) }
+
let(:extra_params) { { project_path: parent.full_path } }
it_behaves_like 'create labels mutation'
@@ -52,6 +53,7 @@
context 'when creating a group label' do
let_it_be(:parent) { create(:group) }
+
let(:extra_params) { { group_path: parent.full_path } }
it_behaves_like 'create labels mutation'
diff --git a/spec/graphql/mutations/notes/reposition_image_diff_note_spec.rb b/spec/graphql/mutations/notes/reposition_image_diff_note_spec.rb
index d88b196cbff4beb7c47a881885bda6708b73f510..e78f755d5c70b64ee8a6c0f328f719de6b32d509 100644
--- a/spec/graphql/mutations/notes/reposition_image_diff_note_spec.rb
+++ b/spec/graphql/mutations/notes/reposition_image_diff_note_spec.rb
@@ -12,6 +12,7 @@
let_it_be(:noteable) { create(:merge_request) }
let_it_be(:project) { noteable.project }
+
let(:note) { create(:image_diff_note_on_merge_request, noteable: noteable, project: project) }
let(:mutation) do
diff --git a/spec/lib/bulk_imports/groups/loaders/group_loader_spec.rb b/spec/lib/bulk_imports/groups/loaders/group_loader_spec.rb
index 533955b057cf8ce5f0851013a45c3dd7b3b4b494..de0b56045b32849a0fb41007c4932c41c52d304c 100644
--- a/spec/lib/bulk_imports/groups/loaders/group_loader_spec.rb
+++ b/spec/lib/bulk_imports/groups/loaders/group_loader_spec.rb
@@ -9,6 +9,7 @@
let_it_be(:entity) { create(:bulk_import_entity, bulk_import: bulk_import) }
let_it_be(:tracker) { create(:bulk_import_tracker, entity: entity) }
let_it_be(:context) { BulkImports::Pipeline::Context.new(tracker) }
+
let(:service_double) { instance_double(::Groups::CreateService) }
let(:data) { { foo: :bar } }
diff --git a/spec/lib/extracts_path_spec.rb b/spec/lib/extracts_path_spec.rb
index b69cbbf0ec0f302375dbfae7f1a9165e2fad3618..57eda63854d159b44a1e1c86b5093c4980ef0981 100644
--- a/spec/lib/extracts_path_spec.rb
+++ b/spec/lib/extracts_path_spec.rb
@@ -9,6 +9,7 @@
let_it_be(:owner) { create(:user) }
let_it_be(:container) { create(:project, :repository, creator: owner) }
+
let(:request) { double('request') }
before do
diff --git a/spec/lib/extracts_ref_spec.rb b/spec/lib/extracts_ref_spec.rb
index 5433a51298146966ca771254e8e04d810ac2fa66..3cdce150de93a0cd7861b884ed2935f351532df4 100644
--- a/spec/lib/extracts_ref_spec.rb
+++ b/spec/lib/extracts_ref_spec.rb
@@ -8,6 +8,7 @@
let_it_be(:owner) { create(:user) }
let_it_be(:container) { create(:snippet, :repository, author: owner) }
+
let(:ref) { sample_commit[:id] }
let(:params) { { path: sample_commit[:line_code_path], ref: ref } }
diff --git a/spec/lib/gitlab/cache/ci/project_pipeline_status_spec.rb b/spec/lib/gitlab/cache/ci/project_pipeline_status_spec.rb
index 9bd89abae8323002e7938ebe4cf3f7a88a305d99..c0e4d1b535520dd30ed53a7be6e49d6affe66c05 100644
--- a/spec/lib/gitlab/cache/ci/project_pipeline_status_spec.rb
+++ b/spec/lib/gitlab/cache/ci/project_pipeline_status_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe Gitlab::Cache::Ci::ProjectPipelineStatus, :clean_gitlab_redis_cache do
let_it_be(:project) { create(:project, :repository) }
+
let(:pipeline_status) { described_class.new(project) }
let(:cache_key) { pipeline_status.cache_key }
diff --git a/spec/lib/gitlab/closing_issue_extractor_spec.rb b/spec/lib/gitlab/closing_issue_extractor_spec.rb
index 37349c30224bb2802347fd69cdfcc0cbede7df8e..279486aa2a15536ae502d66c82c2a1eb42a76c5a 100644
--- a/spec/lib/gitlab/closing_issue_extractor_spec.rb
+++ b/spec/lib/gitlab/closing_issue_extractor_spec.rb
@@ -7,6 +7,7 @@
let_it_be(:project2) { create(:project) }
let_it_be(:issue) { create(:issue, project: project) }
let_it_be(:issue2) { create(:issue, project: project2) }
+
let(:reference) { issue.to_reference }
let(:cross_reference) { issue2.to_reference(project) }
@@ -351,6 +352,7 @@
context 'with multiple references' do
let_it_be(:other_issue) { create(:issue, project: project) }
let_it_be(:third_issue) { create(:issue, project: project) }
+
let(:reference2) { other_issue.to_reference }
let(:reference3) { third_issue.to_reference }
diff --git a/spec/lib/gitlab/composer/cache_spec.rb b/spec/lib/gitlab/composer/cache_spec.rb
index 00318ac14f9472b79d6b45a3f2a7ad42f78ce518..071771960c642e96b2f88d7b91a15b0ed7cdcb33 100644
--- a/spec/lib/gitlab/composer/cache_spec.rb
+++ b/spec/lib/gitlab/composer/cache_spec.rb
@@ -7,6 +7,7 @@
let_it_be(:json) { { 'name' => package_name } }
let_it_be(:group) { create(:group) }
let_it_be(:project) { create(:project, :custom_repo, files: { 'composer.json' => json.to_json }, group: group) }
+
let(:branch) { project.repository.find_branch('master') }
let(:sha_regex) { /^[A-Fa-f0-9]{64}$/ }
diff --git a/spec/lib/gitlab/deploy_key_access_spec.rb b/spec/lib/gitlab/deploy_key_access_spec.rb
index e186e993d8fcf94362de13e6267def5768098a06..83b97c8ba25dcaa70a299191b0f828fea19a321e 100644
--- a/spec/lib/gitlab/deploy_key_access_spec.rb
+++ b/spec/lib/gitlab/deploy_key_access_spec.rb
@@ -5,6 +5,7 @@
RSpec.describe Gitlab::DeployKeyAccess do
let_it_be(:user) { create(:user) }
let_it_be(:deploy_key) { create(:deploy_key, user: user) }
+
let(:project) { create(:project, :repository) }
let(:protected_branch) { create(:protected_branch, :no_one_can_push, project: project) }
diff --git a/spec/lib/gitlab/email/handler/service_desk_handler_spec.rb b/spec/lib/gitlab/email/handler/service_desk_handler_spec.rb
index f6b618163f0a7c5ecb886ef708b921372900845d..fbdf9b186062b383dece4f996ad7c934b43cbf36 100644
--- a/spec/lib/gitlab/email/handler/service_desk_handler_spec.rb
+++ b/spec/lib/gitlab/email/handler/service_desk_handler_spec.rb
@@ -12,6 +12,7 @@
let(:email_raw) { email_fixture('emails/service_desk.eml') }
let_it_be(:group) { create(:group, :private, name: "email") }
+
let(:expected_description) do
"Service desk stuff!\n\n```\na = b\n```\n\n`/label ~label1`\n`/assign @user1`\n`/close`\n"
end
@@ -178,6 +179,7 @@ def set_template_file(file_name, content)
context 'when using service desk key' do
let_it_be(:service_desk_key) { 'mykey' }
+
let(:email_raw) { service_desk_fixture('emails/service_desk_custom_address.eml') }
let(:receiver) { Gitlab::Email::ServiceDeskReceiver.new(email_raw) }
@@ -209,6 +211,7 @@ def set_template_file(file_name, content)
context 'when there are multiple projects with same key' do
let_it_be(:project_with_same_key) { create(:project, group: group, service_desk_enabled: true) }
+
let(:email_raw) { service_desk_fixture('emails/service_desk_custom_address.eml', slug: project_with_same_key.full_path_slug.to_s) }
before do
diff --git a/spec/lib/gitlab/gitaly_client/operation_service_spec.rb b/spec/lib/gitlab/gitaly_client/operation_service_spec.rb
index 9a17140a1e074718fd47b8a2ca203f5ff51d5e37..3789bc76a94241eda8983efa1c0963779cd2e43c 100644
--- a/spec/lib/gitlab/gitaly_client/operation_service_spec.rb
+++ b/spec/lib/gitlab/gitaly_client/operation_service_spec.rb
@@ -5,6 +5,7 @@
RSpec.describe Gitlab::GitalyClient::OperationService do
let_it_be(:user) { create(:user) }
let_it_be(:project) { create(:project, :repository) }
+
let(:repository) { project.repository.raw }
let(:client) { described_class.new(repository) }
let(:gitaly_user) { Gitlab::Git::User.from_gitlab(user).to_gitaly }
diff --git a/spec/lib/gitlab/gl_repository/repo_type_spec.rb b/spec/lib/gitlab/gl_repository/repo_type_spec.rb
index 629e6c9685897f32a51d3cdeb29a387082751c07..71a4c693f9d701d8147f36a00b1354993c28109a 100644
--- a/spec/lib/gitlab/gl_repository/repo_type_spec.rb
+++ b/spec/lib/gitlab/gl_repository/repo_type_spec.rb
@@ -5,6 +5,7 @@
let_it_be(:project) { create(:project) }
let_it_be(:personal_snippet) { create(:personal_snippet, author: project.owner) }
let_it_be(:project_snippet) { create(:project_snippet, project: project, author: project.owner) }
+
let(:project_path) { project.repository.full_path }
let(:wiki_path) { project.wiki.repository.full_path }
let(:design_path) { project.design_repository.full_path }
diff --git a/spec/lib/gitlab/group_search_results_spec.rb b/spec/lib/gitlab/group_search_results_spec.rb
index 009f66d21088f03c1f1a6cf31fff47a851ed77d6..ec96a069b8fff11b7203c69ff5ec891760fcee77 100644
--- a/spec/lib/gitlab/group_search_results_spec.rb
+++ b/spec/lib/gitlab/group_search_results_spec.rb
@@ -8,6 +8,7 @@
let_it_be(:group) { create(:group) }
let_it_be(:user) { create(:user) }
let_it_be(:project) { create(:project, :public, group: group) }
+
let(:filters) { {} }
let(:limit_projects) { Project.all }
let(:query) { 'gob' }
diff --git a/spec/lib/gitlab/json_cache_spec.rb b/spec/lib/gitlab/json_cache_spec.rb
index 563b3d35823195600e44dab6730528fc23d0c02a..8265c3449bb717cd51ecf19df7d19b9027e3e81b 100644
--- a/spec/lib/gitlab/json_cache_spec.rb
+++ b/spec/lib/gitlab/json_cache_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe Gitlab::JsonCache do
let_it_be(:broadcast_message) { create(:broadcast_message) }
+
let(:backend) { double('backend').as_null_object }
let(:namespace) { 'geo' }
let(:key) { 'foo' }
diff --git a/spec/lib/gitlab/language_detection_spec.rb b/spec/lib/gitlab/language_detection_spec.rb
index 14523be8ec6437bce4fceb613aca3e581d098efd..9430ecf7baf955735f33fe0b65e951ff802ac249 100644
--- a/spec/lib/gitlab/language_detection_spec.rb
+++ b/spec/lib/gitlab/language_detection_spec.rb
@@ -6,6 +6,7 @@
let_it_be(:project) { create(:project, :repository) }
let_it_be(:ruby) { create(:programming_language, name: 'Ruby') }
let_it_be(:haskell) { create(:programming_language, name: 'Haskell') }
+
let(:repository) { project.repository }
let(:detection) do
[{ value: 66.63, label: "Ruby", color: "#701516", highlight: "#701516" },
diff --git a/spec/lib/gitlab/project_search_results_spec.rb b/spec/lib/gitlab/project_search_results_spec.rb
index 2f28b8dfce0efb5cb7c2dcec5f2f8cfdfe9fd518..3400b274b823d75eece1fbe91bd783657154fc0c 100644
--- a/spec/lib/gitlab/project_search_results_spec.rb
+++ b/spec/lib/gitlab/project_search_results_spec.rb
@@ -7,6 +7,7 @@
let_it_be(:user) { create(:user) }
let_it_be(:project) { create(:project) }
+
let(:query) { 'hello world' }
let(:repository_ref) { nil }
let(:filters) { {} }
@@ -266,6 +267,7 @@
let_it_be(:closed_result) { create(:issue, :closed, project: project, title: 'foo closed') }
let_it_be(:opened_result) { create(:issue, :opened, project: project, title: 'foo opened') }
let_it_be(:confidential_result) { create(:issue, :confidential, project: project, title: 'foo confidential') }
+
let(:query) { 'foo' }
before do
diff --git a/spec/lib/gitlab/prometheus/query_variables_spec.rb b/spec/lib/gitlab/prometheus/query_variables_spec.rb
index 1dbdb892a5d1d898078c48078e409d995b8ba5e2..d9cac3e106413a2da653976fea05f77a1dcdf321 100644
--- a/spec/lib/gitlab/prometheus/query_variables_spec.rb
+++ b/spec/lib/gitlab/prometheus/query_variables_spec.rb
@@ -5,6 +5,7 @@
RSpec.describe Gitlab::Prometheus::QueryVariables do
describe '.call' do
let_it_be_with_refind(:environment) { create(:environment) }
+
let(:project) { environment.project }
let(:slug) { environment.slug }
let(:params) { {} }
diff --git a/spec/lib/gitlab/reactive_cache_set_cache_spec.rb b/spec/lib/gitlab/reactive_cache_set_cache_spec.rb
index 19fb2ada4760ef8ad0cc497203ad84c27b3efc89..f405b2ad86e5f693a3579184d24c74c0ac8ca487 100644
--- a/spec/lib/gitlab/reactive_cache_set_cache_spec.rb
+++ b/spec/lib/gitlab/reactive_cache_set_cache_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe Gitlab::ReactiveCacheSetCache, :clean_gitlab_redis_cache do
let_it_be(:project) { create(:project) }
+
let(:cache_prefix) { 'cache_prefix' }
let(:expires_in) { 10.minutes }
let(:cache) { described_class.new(expires_in: expires_in) }
diff --git a/spec/lib/gitlab/reference_extractor_spec.rb b/spec/lib/gitlab/reference_extractor_spec.rb
index e040ddb1be4f81e9e0d83159fe110c87c7aa5ce6..f6e69aa65332a6de0e72b90bdfbae4d8dbb6ab66 100644
--- a/spec/lib/gitlab/reference_extractor_spec.rb
+++ b/spec/lib/gitlab/reference_extractor_spec.rb
@@ -315,6 +315,7 @@ def prefixes
describe '#references' do
let_it_be(:user) { create(:user) }
let_it_be(:issue) { create(:issue, project: project) }
+
let(:text) { "Ref. #{issue.to_reference}" }
subject { described_class.new(project, user) }
diff --git a/spec/lib/gitlab/search_results_spec.rb b/spec/lib/gitlab/search_results_spec.rb
index a1b18172a31365df07d150eb00b30fc8675ed8e7..06dc9b3307a14cb9142552a4cd07b43ba787901e 100644
--- a/spec/lib/gitlab/search_results_spec.rb
+++ b/spec/lib/gitlab/search_results_spec.rb
@@ -11,6 +11,7 @@
let_it_be(:project) { create(:project, name: 'foo') }
let_it_be(:issue) { create(:issue, project: project, title: 'foo') }
let_it_be(:milestone) { create(:milestone, project: project, title: 'foo') }
+
let(:merge_request) { create(:merge_request, source_project: project, title: 'foo') }
let(:query) { 'foo' }
let(:filters) { {} }
diff --git a/spec/lib/gitlab/shell_spec.rb b/spec/lib/gitlab/shell_spec.rb
index b0dc34e8abf2672ae5459e4de8719bf64a877ce6..891b363970997c69d1d6864df05b0c5d6b3f1d14 100644
--- a/spec/lib/gitlab/shell_spec.rb
+++ b/spec/lib/gitlab/shell_spec.rb
@@ -5,6 +5,7 @@
RSpec.describe Gitlab::Shell do
let_it_be(:project) { create(:project, :repository) }
+
let(:repository) { project.repository }
let(:gitlab_shell) { described_class.new }
diff --git a/spec/models/abuse_report_spec.rb b/spec/models/abuse_report_spec.rb
index a97574fa5242fd065241514aeb290e2a89fc8963..e87996fc1f0758e0e48aea6f8d9b5044cf320058 100644
--- a/spec/models/abuse_report_spec.rb
+++ b/spec/models/abuse_report_spec.rb
@@ -5,6 +5,7 @@
RSpec.describe AbuseReport do
let_it_be(:report, reload: true) { create(:abuse_report) }
let_it_be(:user, reload: true) { create(:admin) }
+
subject { report }
it { expect(subject).to be_valid }
diff --git a/spec/models/alert_management/alert_spec.rb b/spec/models/alert_management/alert_spec.rb
index 80a45b1c1be4347585f26d3c0d9235618467f680..18d486740b8f8effba62dee7915404f86c790ad3 100644
--- a/spec/models/alert_management/alert_spec.rb
+++ b/spec/models/alert_management/alert_spec.rb
@@ -100,6 +100,7 @@
describe 'fingerprint' do
let_it_be(:fingerprint) { 'fingerprint' }
let_it_be(:project3, refind: true) { create(:project) }
+
let(:new_alert) { build(:alert_management_alert, fingerprint: fingerprint, project: project3) }
subject { new_alert }
diff --git a/spec/models/chat_name_spec.rb b/spec/models/chat_name_spec.rb
index 4d77bd531582405b8c61d1728e13ed23f6501852..9ed00003ac12da9246afa1b14cef7c863b9746aa 100644
--- a/spec/models/chat_name_spec.rb
+++ b/spec/models/chat_name_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe ChatName do
let_it_be(:chat_name) { create(:chat_name) }
+
subject { chat_name }
it { is_expected.to belong_to(:integration) }
diff --git a/spec/models/chat_team_spec.rb b/spec/models/chat_team_spec.rb
index 08fd05324aa69ac1af0dcc6e477deadb5e2e4b00..2e8cdb7a31608946064252db416ab09a3e2b2c7a 100644
--- a/spec/models/chat_team_spec.rb
+++ b/spec/models/chat_team_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe ChatTeam do
let_it_be(:chat_team) { create(:chat_team) }
+
subject { chat_team }
# Associations
diff --git a/spec/models/clusters/kubernetes_namespace_spec.rb b/spec/models/clusters/kubernetes_namespace_spec.rb
index 3b903fe34f94755728641c81e935a8cc59a61c94..e70cd15baca0a6bc35bfa18c00277da938666eb8 100644
--- a/spec/models/clusters/kubernetes_namespace_spec.rb
+++ b/spec/models/clusters/kubernetes_namespace_spec.rb
@@ -62,6 +62,7 @@
describe 'namespace uniqueness validation' do
let_it_be(:cluster) { create(:cluster, :project, :provided_by_gcp) }
+
let(:kubernetes_namespace) { build(:cluster_kubernetes_namespace, cluster: cluster, namespace: 'my-namespace') }
subject { kubernetes_namespace }
diff --git a/spec/models/commit_spec.rb b/spec/models/commit_spec.rb
index 8ffc198fc4d6f434c0c0ed549e9b4421ec3fc022..63fe69236301ff5979859a4daf01176e8a373842 100644
--- a/spec/models/commit_spec.rb
+++ b/spec/models/commit_spec.rb
@@ -6,6 +6,7 @@
let_it_be(:project) { create(:project, :public, :repository) }
let_it_be(:personal_snippet) { create(:personal_snippet, :repository) }
let_it_be(:project_snippet) { create(:project_snippet, :repository) }
+
let(:commit) { project.commit }
describe 'modules' do
diff --git a/spec/models/deploy_token_spec.rb b/spec/models/deploy_token_spec.rb
index dfc37f9e66166a1062ec560311c13c7cb203221e..c9f7895a616f8927ec0fa7f38867dfa649a54238 100644
--- a/spec/models/deploy_token_spec.rb
+++ b/spec/models/deploy_token_spec.rb
@@ -242,6 +242,7 @@
context 'and when the token is of group type' do
let_it_be(:group) { create(:group) }
+
let(:deploy_token) { create(:deploy_token, :group) }
before do
diff --git a/spec/models/deployment_spec.rb b/spec/models/deployment_spec.rb
index bcd237cbd38b42bcfd26bd622a66bada50ea19e2..a0e5e9cbfe4df0eb072a47f23e4370964f47d8ee 100644
--- a/spec/models/deployment_spec.rb
+++ b/spec/models/deployment_spec.rb
@@ -80,6 +80,7 @@
let_it_be(:staging) { create(:environment, :staging, project: project) }
let_it_be(:other_project) { create(:project, :repository) }
let_it_be(:other_production) { create(:environment, :production, project: other_project) }
+
let(:environment_name) { production.name }
context 'when deployment belongs to the environment' do
@@ -488,6 +489,7 @@
let_it_be(:project) { create(:project, :repository) }
let_it_be(:commits) { project.repository.commits('master', limit: 2) }
let_it_be(:deployments) { commits.reverse.map { |commit| create(:deployment, project: project, sha: commit.id) } }
+
let(:sha) { commits.map(&:id) }
it 'finds the latest deployment with sha' do
@@ -823,6 +825,7 @@
describe '#update_merge_request_metrics!' do
let_it_be(:project) { create(:project, :repository) }
+
let(:environment) { build(:environment, environment_tier, project: project) }
let!(:deployment) { create(:deployment, :success, project: project, environment: environment) }
let!(:merge_request) { create(:merge_request, :simple, :merged_last_month, project: project) }
diff --git a/spec/models/diff_viewer/server_side_spec.rb b/spec/models/diff_viewer/server_side_spec.rb
index 686dd1249be70b545aac2b0e7dca73d936520faa..28660b0d4b9c50c379d505a0163c2d45d0b829df 100644
--- a/spec/models/diff_viewer/server_side_spec.rb
+++ b/spec/models/diff_viewer/server_side_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe DiffViewer::ServerSide do
let_it_be(:project) { create(:project, :repository) }
+
let(:commit) { project.commit_by(oid: '570e7b2abdd848b95f2f578043fc23bd6f6fd24d') }
let!(:diff_file) { commit.diffs.diff_file_with_new_path('files/ruby/popen.rb') }
diff --git a/spec/models/environment_spec.rb b/spec/models/environment_spec.rb
index ff4c8ae950df1cdb90a54f558e6e5cf3a8d539b6..18a172b72d7abaf740ab15f78cc3f07fc7c2568d 100644
--- a/spec/models/environment_spec.rb
+++ b/spec/models/environment_spec.rb
@@ -219,6 +219,7 @@
let_it_be(:project) { create(:project, :repository) }
let_it_be(:user) { create(:user) }
+
let(:environments) { Environment.all }
before_all do
@@ -760,6 +761,7 @@
describe '#last_visible_pipeline' do
let(:user) { create(:user) }
let_it_be(:project) { create(:project, :repository) }
+
let(:environment) { create(:environment, project: project) }
let(:commit) { project.commit }
@@ -1462,6 +1464,7 @@
let_it_be(:project) { create(:project, :repository) }
let_it_be(:environment, reload: true) { create(:environment, project: project) }
+
let!(:deployment) { create(:deployment, project: project, environment: environment, deployable: build) }
let!(:build) { create(:ci_build, :running, project: project, environment: environment) }
diff --git a/spec/models/event_collection_spec.rb b/spec/models/event_collection_spec.rb
index aca2a8c3a2f50b1e55485e508f3dd95737e50bee..107447c9630281ae1a7ef536f3e69434b9639186 100644
--- a/spec/models/event_collection_spec.rb
+++ b/spec/models/event_collection_spec.rb
@@ -28,6 +28,7 @@
let_it_be(:closed_issue_event) { create(:closed_issue_event, project: project, author: user) }
let_it_be(:wiki_page_event) { create(:wiki_page_event, project: project) }
let_it_be(:design_event) { create(:design_event, project: project) }
+
let(:push_events) { push_event_payloads.map(&:event) }
it 'returns an Array of events', :aggregate_failures do
diff --git a/spec/models/label_note_spec.rb b/spec/models/label_note_spec.rb
index 0bf202ce2b1b4ff04548b611a74f7ec5c9d8e550..ee4822c653d33f36d09387ba613978285ffb751f 100644
--- a/spec/models/label_note_spec.rb
+++ b/spec/models/label_note_spec.rb
@@ -7,6 +7,7 @@
let_it_be(:user) { create(:user) }
let_it_be(:label) { create(:label, project: project) }
let_it_be(:label2) { create(:label, project: project) }
+
let(:resource_parent) { project }
context 'when resource is issue' do
diff --git a/spec/models/lfs_file_lock_spec.rb b/spec/models/lfs_file_lock_spec.rb
index d3f79c7c7cf5f1a0f40df2ba1a2c56b77f85d0a9..5afad6c184fb1f756e7dfa50babffdd43471e827 100644
--- a/spec/models/lfs_file_lock_spec.rb
+++ b/spec/models/lfs_file_lock_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe LfsFileLock do
let_it_be(:lfs_file_lock, reload: true) { create(:lfs_file_lock) }
+
subject { lfs_file_lock }
it { is_expected.to belong_to(:project) }
diff --git a/spec/models/member_spec.rb b/spec/models/member_spec.rb
index 600fe96c3f97218f7cd36bdb1d35984f0897d992..520a74b2227b1b3f2782fb9aa77ebb3b4e8856cc 100644
--- a/spec/models/member_spec.rb
+++ b/spec/models/member_spec.rb
@@ -30,6 +30,7 @@
context "when an invite email is provided" do
let_it_be(:project) { create(:project) }
+
let(:member) { build(:project_member, source: project, invite_email: "user@example.com", user: nil) }
it "doesn't require a user" do
@@ -98,6 +99,7 @@
context 'project bots' do
let_it_be(:project_bot) { create(:user, :project_bot) }
+
let(:new_member) { build(:project_member, user_id: project_bot.id) }
context 'not a member of any group or project' do
diff --git a/spec/models/merge_request_diff_spec.rb b/spec/models/merge_request_diff_spec.rb
index 4eeeca263e8d40bb65372b471c160c3094b44ef6..f7917d5db5fcd86ddf098d9492a969e0d7e7424c 100644
--- a/spec/models/merge_request_diff_spec.rb
+++ b/spec/models/merge_request_diff_spec.rb
@@ -111,6 +111,7 @@
let(:closed_recently) { recently_closed_mr.merge_request_diff }
let_it_be(:recently_merged_mr) { create(:merge_request, :merged) }
+
let(:merged_recently) { recently_merged_mr.merge_request_diff }
before do
diff --git a/spec/models/namespace/root_storage_statistics_spec.rb b/spec/models/namespace/root_storage_statistics_spec.rb
index b725d2366a14b2f903bdadc5708e03f687c1edfd..51c191069ece9f4c3505dc6d7155c1f4a719eb06 100644
--- a/spec/models/namespace/root_storage_statistics_spec.rb
+++ b/spec/models/namespace/root_storage_statistics_spec.rb
@@ -99,6 +99,7 @@
context 'with a personal namespace' do
let_it_be(:user) { create(:user) }
+
let(:namespace) { user.namespace }
it_behaves_like 'data refresh'
diff --git a/spec/models/note_spec.rb b/spec/models/note_spec.rb
index d9f566f9383ca5fc9c248bb6d57cf1b3199a4e83..2afe9a0f29b3336b944e54bf5274425d93d963fe 100644
--- a/spec/models/note_spec.rb
+++ b/spec/models/note_spec.rb
@@ -455,6 +455,7 @@ def retrieve_participants
describe "#system_note_viewable_by?(user)" do
let_it_be(:note) { create(:note) }
let_it_be(:user) { create(:user) }
+
let!(:metadata) { create(:system_note_metadata, note: note, action: "branch") }
context "when system_note_metadata is not present" do
@@ -536,6 +537,7 @@ def retrieve_participants
context "when there is a reference to a label" do
let_it_be(:private_label) { create(:label, project: private_project) }
+
let(:note) do
create :note,
noteable: ext_issue, project: ext_proj,
@@ -550,6 +552,7 @@ def retrieve_participants
context "when there are two references in note" do
let_it_be(:ext_issue2) { create(:issue, project: ext_proj) }
+
let(:note) do
create :note,
noteable: ext_issue2, project: ext_proj,
@@ -1239,6 +1242,7 @@ def retrieve_participants
describe 'expiring ETag cache' do
let_it_be(:issue) { create(:issue) }
+
let(:note) { build(:note, project: issue.project, noteable: issue) }
def expect_expiration(noteable)
diff --git a/spec/models/notification_setting_spec.rb b/spec/models/notification_setting_spec.rb
index 010b7455f85ca576fa12276c15de16357b6f15ea..3f1684327e786044e28c09aefac0ea68ff8409cb 100644
--- a/spec/models/notification_setting_spec.rb
+++ b/spec/models/notification_setting_spec.rb
@@ -51,6 +51,7 @@
context 'notification_email' do
let_it_be(:user) { create(:user) }
+
subject { described_class.new(source_id: 1, source_type: 'Project', user_id: user.id) }
it 'allows to change email to verified one' do
diff --git a/spec/models/operations/feature_flag_spec.rb b/spec/models/operations/feature_flag_spec.rb
index 55682e12642d847669a8302871ebdc16a023552d..cb9da2aea346b4d2b871984f036876ce698c1767 100644
--- a/spec/models/operations/feature_flag_spec.rb
+++ b/spec/models/operations/feature_flag_spec.rb
@@ -251,6 +251,7 @@
describe '.for_unleash_client' do
let_it_be(:project) { create(:project) }
+
let!(:feature_flag) do
create(:operations_feature_flag, project: project,
name: 'feature1', active: true, version: 2)
diff --git a/spec/models/plan_limits_spec.rb b/spec/models/plan_limits_spec.rb
index 07347dfb6ecc845a5e706f2a186103a71499ae69..9078d72e0446492409584e99a76a78c95f25748c 100644
--- a/spec/models/plan_limits_spec.rb
+++ b/spec/models/plan_limits_spec.rb
@@ -5,6 +5,7 @@
RSpec.describe PlanLimits do
let_it_be(:project) { create(:project) }
let_it_be(:plan_limits) { create(:plan_limits) }
+
let(:project_hooks_count) { 2 }
before do
diff --git a/spec/models/prometheus_alert_spec.rb b/spec/models/prometheus_alert_spec.rb
index 8e517e1764e8fbfab8f73687f4fedf5f84bb8735..bfe2c7cc2a459b56287bb2b8cf9d65a075a6292a 100644
--- a/spec/models/prometheus_alert_spec.rb
+++ b/spec/models/prometheus_alert_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe PrometheusAlert do
let_it_be(:project) { build(:project) }
+
let(:metric) { build(:prometheus_metric) }
describe '.distinct_projects' do
diff --git a/spec/models/protected_branch/push_access_level_spec.rb b/spec/models/protected_branch/push_access_level_spec.rb
index 17a589f04859ec844f8e907a9f2822136a990954..fb8a396269c78fac61cee8a1fc8c4c37e5199bd1 100644
--- a/spec/models/protected_branch/push_access_level_spec.rb
+++ b/spec/models/protected_branch/push_access_level_spec.rb
@@ -40,6 +40,7 @@
let_it_be(:protected_branch) { create(:protected_branch, :no_one_can_push, project: project) }
let_it_be(:user) { create(:user) }
let_it_be(:deploy_key) { create(:deploy_key, user: user) }
+
let!(:deploy_keys_project) { create(:deploy_keys_project, project: project, deploy_key: deploy_key, can_push: can_push) }
let(:can_push) { true }
diff --git a/spec/models/repository_spec.rb b/spec/models/repository_spec.rb
index b6f09babb4b6cbc71e9d65624f00cbc595fffed9..4b0435baa98c64f19986be5fc0c498a7d4b4dd0a 100644
--- a/spec/models/repository_spec.rb
+++ b/spec/models/repository_spec.rb
@@ -41,6 +41,7 @@ def expect_to_raise_storage_error
describe '#branch_names_contains' do
let_it_be(:project) { create(:project, :repository) }
+
let(:repository) { project.repository }
subject { repository.branch_names_contains(sample_commit.id) }
@@ -398,6 +399,7 @@ def create_commit_with_invalid_utf8_path
describe '#new_commits' do
let_it_be(:project) { create(:project, :repository) }
+
let(:repository) { project.repository }
subject { repository.new_commits(rev) }
@@ -426,6 +428,7 @@ def create_commit_with_invalid_utf8_path
describe '#commits_by' do
let_it_be(:project) { create(:project, :repository) }
+
let(:oids) { TestEnv::BRANCH_SHA.values }
subject { project.repository.commits_by(oids: oids) }
@@ -2984,6 +2987,7 @@ def expect_contributors(*contributors)
describe '#merge_base' do
let_it_be(:project) { create(:project, :repository) }
+
subject(:repository) { project.repository }
it 'only makes one gitaly call' do
@@ -3082,6 +3086,7 @@ def expect_contributors(*contributors)
describe "#blobs_metadata" do
let_it_be(:project) { create(:project, :repository) }
+
let(:repository) { project.repository }
def expect_metadata_blob(thing)
diff --git a/spec/models/snippet_repository_spec.rb b/spec/models/snippet_repository_spec.rb
index 11196f065296211d96e3dd276e72cc0b920f99ce..40a28b9e0cc914018d4e7061df62da808988b974 100644
--- a/spec/models/snippet_repository_spec.rb
+++ b/spec/models/snippet_repository_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe SnippetRepository do
let_it_be(:user) { create(:user) }
+
let(:snippet) { create(:personal_snippet, :repository, author: user) }
let(:snippet_repository) { snippet.snippet_repository }
let(:commit_opts) { { branch_name: 'master', message: 'whatever' } }
diff --git a/spec/models/snippet_spec.rb b/spec/models/snippet_spec.rb
index 06e9899c0bd53769568e7dc00e6ef9dd3c6f7ef5..474a73a4df128032d8a2c01de54e3070eaca0fdc 100644
--- a/spec/models/snippet_spec.rb
+++ b/spec/models/snippet_spec.rb
@@ -722,6 +722,7 @@ def to_json(params = {})
describe '#list_files' do
let_it_be(:snippet) { create(:snippet, :repository) }
+
let(:ref) { 'test-ref' }
subject { snippet.list_files(ref) }
diff --git a/spec/models/terraform/state_spec.rb b/spec/models/terraform/state_spec.rb
index 1319e2adb03c1c38975ad1d2f31e5a871b04d9a4..a113ae372032ff6fb69f000d3f2b9d1c3eba4b7f 100644
--- a/spec/models/terraform/state_spec.rb
+++ b/spec/models/terraform/state_spec.rb
@@ -16,6 +16,7 @@
describe 'scopes' do
describe '.ordered_by_name' do
let_it_be(:project) { create(:project) }
+
let(:names) { %w(state_d state_b state_a state_c) }
subject { described_class.ordered_by_name }
diff --git a/spec/models/u2f_registration_spec.rb b/spec/models/u2f_registration_spec.rb
index 1f2e4d1e447d24f638fdb2378c8b807083e6fe12..aba2f27d104861fbce7f60c5070916dc505d2a34 100644
--- a/spec/models/u2f_registration_spec.rb
+++ b/spec/models/u2f_registration_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe U2fRegistration do
let_it_be(:user) { create(:user) }
+
let(:u2f_registration) do
device = U2F::FakeU2F.new(FFaker::BaconIpsum.characters(5))
create(:u2f_registration, name: 'u2f_device',
diff --git a/spec/models/user_spec.rb b/spec/models/user_spec.rb
index e5c86e69ffc5140a96a6ca15903109297a3380c9..45f1ad719627440602d179da429131225877bc19 100644
--- a/spec/models/user_spec.rb
+++ b/spec/models/user_spec.rb
@@ -991,6 +991,7 @@
let_it_be(:valid_token_and_notified) { create(:personal_access_token, user: user2, expires_at: 2.days.from_now, expire_notification_delivered: true) }
let_it_be(:valid_token1) { create(:personal_access_token, user: user2, expires_at: 2.days.from_now) }
let_it_be(:valid_token2) { create(:personal_access_token, user: user2, expires_at: 2.days.from_now) }
+
let(:users) { described_class.with_expiring_and_not_notified_personal_access_tokens(from) }
context 'in one day' do
@@ -4208,6 +4209,7 @@ def add_user(access)
describe '#source_groups_of_two_factor_authentication_requirement' do
let_it_be(:group_not_requiring_2FA) { create :group }
+
let(:user) { create :user }
before do
diff --git a/spec/requests/api/api_spec.rb b/spec/requests/api/api_spec.rb
index 46430e55ff252a0eb65904f2cc32f6871db0fa58..81620fce448eeb014f4ab3d5288ad6e55c204092 100644
--- a/spec/requests/api/api_spec.rb
+++ b/spec/requests/api/api_spec.rb
@@ -81,6 +81,7 @@
let_it_be(:maven_metadatum) { package.maven_metadatum }
let_it_be(:package_file) { package.package_files.first }
let_it_be(:deploy_token) { create(:deploy_token) }
+
let(:headers_with_deploy_token) do
{
Gitlab::Auth::AuthFinders::DEPLOY_TOKEN_HEADER => deploy_token.token
@@ -138,6 +139,7 @@
describe 'Marginalia comments' do
context 'GET /user/:id' do
let_it_be(:user) { create(:user) }
+
let(:component_map) do
{
"application" => "test",
diff --git a/spec/requests/api/award_emoji_spec.rb b/spec/requests/api/award_emoji_spec.rb
index 1c825949ae808c9af5a1b39dc0adb064e799d116..07a9f7dfd742f36df212a6b8f69383042a8297b6 100644
--- a/spec/requests/api/award_emoji_spec.rb
+++ b/spec/requests/api/award_emoji_spec.rb
@@ -8,6 +8,7 @@
let_it_be(:issue) { create(:issue, project: project) }
let_it_be(:award_emoji) { create(:award_emoji, awardable: issue, user: user) }
let_it_be(:note) { create(:note, project: project, noteable: issue) }
+
let!(:merge_request) { create(:merge_request, source_project: project, target_project: project) }
let!(:downvote) { create(:award_emoji, :downvote, awardable: merge_request, user: user) }
diff --git a/spec/requests/api/branches_spec.rb b/spec/requests/api/branches_spec.rb
index 36fbe86ac767795c1141dc74dbc98583c53276b0..e0a279d6ea441e68d0c12def9ba1456c2c6e06bc 100644
--- a/spec/requests/api/branches_spec.rb
+++ b/spec/requests/api/branches_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe API::Branches do
let_it_be(:user) { create(:user) }
+
let(:project) { create(:project, :repository, creator: user, path: 'my.project') }
let(:guest) { create(:user).tap { |u| project.add_guest(u) } }
let(:branch_name) { 'feature' }
diff --git a/spec/requests/api/ci/pipelines_spec.rb b/spec/requests/api/ci/pipelines_spec.rb
index 092cd00630e055a19b82e2f476752a38e9736d84..eb6c08618443f8c13450968351dfe528e41b1127 100644
--- a/spec/requests/api/ci/pipelines_spec.rb
+++ b/spec/requests/api/ci/pipelines_spec.rb
@@ -491,6 +491,7 @@
describe 'GET /projects/:id/pipelines/:pipeline_id/bridges' do
let_it_be(:bridge) { create(:ci_bridge, pipeline: pipeline) }
+
let(:downstream_pipeline) { create(:ci_pipeline) }
let!(:pipeline_source) do
diff --git a/spec/requests/api/composer_packages_spec.rb b/spec/requests/api/composer_packages_spec.rb
index 4120edabea34244aeca5012824724595a172856b..e75725cacbafc0ec316e86b331e6226870a39252 100644
--- a/spec/requests/api/composer_packages_spec.rb
+++ b/spec/requests/api/composer_packages_spec.rb
@@ -9,6 +9,7 @@
let_it_be(:personal_access_token) { create(:personal_access_token, user: user) }
let_it_be(:package_name) { 'package-name' }
let_it_be(:project, reload: true) { create(:project, :custom_repo, files: { 'composer.json' => { name: package_name }.to_json }, group: group) }
+
let(:snowplow_gitlab_standard_context) { { project: project, namespace: project.namespace, user: user } }
let(:headers) { {} }
diff --git a/spec/requests/api/deploy_tokens_spec.rb b/spec/requests/api/deploy_tokens_spec.rb
index e8426270622708fa6b1c45905ff991f20401f896..38380fa4460d927add2408cc3091ad3d1447c1c8 100644
--- a/spec/requests/api/deploy_tokens_spec.rb
+++ b/spec/requests/api/deploy_tokens_spec.rb
@@ -7,6 +7,7 @@
let_it_be(:creator) { create(:user) }
let_it_be(:project) { create(:project, creator_id: creator.id) }
let_it_be(:group) { create(:group) }
+
let!(:deploy_token) { create(:deploy_token, projects: [project]) }
let!(:revoked_deploy_token) { create(:deploy_token, projects: [project], revoked: true) }
let!(:expired_deploy_token) { create(:deploy_token, projects: [project], expires_at: '1988-01-11T04:33:04-0600') }
diff --git a/spec/requests/api/deployments_spec.rb b/spec/requests/api/deployments_spec.rb
index bbfe37cb70b486c36eefe810565a60abb86cd5bc..38c96cd37af26d0be1dce1b46229f14410dd1516 100644
--- a/spec/requests/api/deployments_spec.rb
+++ b/spec/requests/api/deployments_spec.rb
@@ -456,6 +456,7 @@ def expect_deployments(ordered_deployments)
context 'when a user member of the deployment project' do
let_it_be(:project2) { create(:project) }
+
let!(:merge_request1) { create(:merge_request, source_project: project, target_project: project) }
let!(:merge_request2) { create(:merge_request, source_project: project, target_project: project, state: 'closed') }
let!(:merge_request3) { create(:merge_request, source_project: project2, target_project: project2) }
diff --git a/spec/requests/api/error_tracking_spec.rb b/spec/requests/api/error_tracking_spec.rb
index 8c9ca1b6a9db2ffc98cd8c7ca6925367f8f11cdf..39121af7bc33baa887ce11919946dc24b99efaaf 100644
--- a/spec/requests/api/error_tracking_spec.rb
+++ b/spec/requests/api/error_tracking_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe API::ErrorTracking do
let_it_be(:user) { create(:user) }
+
let(:setting) { create(:project_error_tracking_setting) }
let(:project) { setting.project }
diff --git a/spec/requests/api/feature_flags_spec.rb b/spec/requests/api/feature_flags_spec.rb
index 2cd52c0a5e5fc0a812d0ee1988ecad8338ffafa9..8edf8825fb215f8ca65a651a11df859327a5ba6f 100644
--- a/spec/requests/api/feature_flags_spec.rb
+++ b/spec/requests/api/feature_flags_spec.rb
@@ -8,6 +8,7 @@
let_it_be(:developer) { create(:user) }
let_it_be(:reporter) { create(:user) }
let_it_be(:non_project_member) { create(:user) }
+
let(:user) { developer }
before_all do
diff --git a/spec/requests/api/freeze_periods_spec.rb b/spec/requests/api/freeze_periods_spec.rb
index 5589d4d543d8372152f5e3b423e232e81fcda148..3da992301d50dc8bc0ee7cf798e4a4a6d1a479bf 100644
--- a/spec/requests/api/freeze_periods_spec.rb
+++ b/spec/requests/api/freeze_periods_spec.rb
@@ -6,6 +6,7 @@
let_it_be(:project) { create(:project, :repository, :private) }
let_it_be(:user) { create(:user) }
let_it_be(:admin) { create(:admin) }
+
let(:api_user) { user }
let(:invalid_cron) { '0 0 0 * *' }
let(:last_freeze_period) { project.freeze_periods.last }
diff --git a/spec/requests/api/graphql/boards/board_lists_query_spec.rb b/spec/requests/api/graphql/boards/board_lists_query_spec.rb
index cd94ce9107194413ae241ab23b54e40526dcf40b..2d52cddcacc3a7ae4f8c3f63e48be9cb2b845459 100644
--- a/spec/requests/api/graphql/boards/board_lists_query_spec.rb
+++ b/spec/requests/api/graphql/boards/board_lists_query_spec.rb
@@ -66,6 +66,7 @@ def query(list_params = params)
describe 'sorting and pagination' do
let_it_be(:current_user) { user }
+
let(:data_path) { [board_parent_type, :boards, :nodes, 0, :lists] }
def pagination_query(params)
diff --git a/spec/requests/api/graphql/ci/pipelines_spec.rb b/spec/requests/api/graphql/ci/pipelines_spec.rb
index f207636283fa7db6d08e9c3f69db7a490332fdc8..6587061094de897f94669180703ffa718caa20d7 100644
--- a/spec/requests/api/graphql/ci/pipelines_spec.rb
+++ b/spec/requests/api/graphql/ci/pipelines_spec.rb
@@ -229,6 +229,7 @@
let_it_be(:pipeline) { create(:ci_pipeline, project: project, user: user) }
let_it_be(:upstream_project) { create(:project, :repository, :public) }
let_it_be(:upstream_pipeline) { create(:ci_pipeline, project: upstream_project, user: user) }
+
let(:upstream_pipelines_graphql_data) { graphql_data.dig(*%w[project pipelines nodes]).first['upstream'] }
let(:query) do
diff --git a/spec/requests/api/graphql/current_user_todos_spec.rb b/spec/requests/api/graphql/current_user_todos_spec.rb
index b657f15d0e9849205f2e7839ce5eee5af8d2cd03..7f37abba74aa76a8328816529b9a4e8c10495b8d 100644
--- a/spec/requests/api/graphql/current_user_todos_spec.rb
+++ b/spec/requests/api/graphql/current_user_todos_spec.rb
@@ -10,6 +10,7 @@
let_it_be(:todoable) { create(:issue, project: project) }
let_it_be(:done_todo) { create(:todo, state: :done, target: todoable, user: current_user) }
let_it_be(:pending_todo) { create(:todo, state: :pending, target: todoable, user: current_user) }
+
let(:state) { 'null' }
let(:todoable_response) do
diff --git a/spec/requests/api/graphql/issue_status_counts_spec.rb b/spec/requests/api/graphql/issue_status_counts_spec.rb
index 3d8817c3bc52ba9b2b3176914ab20b1dddc01817..89ecbf44b107cc60c0196dd5d5052a332821feec 100644
--- a/spec/requests/api/graphql/issue_status_counts_spec.rb
+++ b/spec/requests/api/graphql/issue_status_counts_spec.rb
@@ -9,6 +9,7 @@
let_it_be(:issue_opened) { create(:issue, project: project) }
let_it_be(:issue_closed) { create(:issue, :closed, project: project) }
let_it_be(:other_project_issue) { create(:issue) }
+
let(:params) { {} }
let(:fields) do
diff --git a/spec/requests/api/graphql/metrics/dashboard_query_spec.rb b/spec/requests/api/graphql/metrics/dashboard_query_spec.rb
index e01f59ee6a05ba6eca61fee899fd7bdb65c39b0a..1b84acff0e22777b5ed6c40bd0ec80ba1899a4f5 100644
--- a/spec/requests/api/graphql/metrics/dashboard_query_spec.rb
+++ b/spec/requests/api/graphql/metrics/dashboard_query_spec.rb
@@ -6,6 +6,7 @@
include GraphqlHelpers
let_it_be(:current_user) { create(:user) }
+
let(:project) { create(:project) }
let(:environment) { create(:environment, project: project) }
diff --git a/spec/requests/api/graphql/mutations/admin/sidekiq_queues/delete_jobs_spec.rb b/spec/requests/api/graphql/mutations/admin/sidekiq_queues/delete_jobs_spec.rb
index b8cde32877b13c597868094876b1382b48d663b0..1692cfbcf842c4323f677d238452d49e3ba87afa 100644
--- a/spec/requests/api/graphql/mutations/admin/sidekiq_queues/delete_jobs_spec.rb
+++ b/spec/requests/api/graphql/mutations/admin/sidekiq_queues/delete_jobs_spec.rb
@@ -6,6 +6,7 @@
include GraphqlHelpers
let_it_be(:admin) { create(:admin) }
+
let(:queue) { 'authorized_projects' }
let(:variables) { { user: admin.username, queue_name: queue } }
diff --git a/spec/requests/api/graphql/mutations/alert_management/alerts/set_assignees_spec.rb b/spec/requests/api/graphql/mutations/alert_management/alerts/set_assignees_spec.rb
index cd5cefa0a9a5575374f5eabe1e109120375bdcea..fcef7b4e3ec730d9eb042d0d2e50a503ea92d135 100644
--- a/spec/requests/api/graphql/mutations/alert_management/alerts/set_assignees_spec.rb
+++ b/spec/requests/api/graphql/mutations/alert_management/alerts/set_assignees_spec.rb
@@ -8,6 +8,7 @@
let_it_be(:project) { create(:project) }
let_it_be(:current_user) { create(:user) }
let_it_be(:alert) { create(:alert_management_alert, project: project) }
+
let(:input) { { assignee_usernames: [current_user.username] } }
let(:mutation) do
diff --git a/spec/requests/api/graphql/mutations/alert_management/alerts/todo/create_spec.rb b/spec/requests/api/graphql/mutations/alert_management/alerts/todo/create_spec.rb
index cd423d7764ab09ffb02cf4f228dea6cc099e712b..4830796434515fa1e92587151e1fe7047452ad1b 100644
--- a/spec/requests/api/graphql/mutations/alert_management/alerts/todo/create_spec.rb
+++ b/spec/requests/api/graphql/mutations/alert_management/alerts/todo/create_spec.rb
@@ -7,6 +7,7 @@
let_it_be(:user) { create(:user) }
let_it_be(:project) { create(:project) }
+
let(:alert) { create(:alert_management_alert, project: project) }
let(:mutation) do
diff --git a/spec/requests/api/graphql/mutations/alert_management/alerts/update_alert_status_spec.rb b/spec/requests/api/graphql/mutations/alert_management/alerts/update_alert_status_spec.rb
index ff55656a2aeae15c1b94f9c05db606c3d07fb3c6..802d8d6c5a1c69985446ffe7b62c8e1af896705e 100644
--- a/spec/requests/api/graphql/mutations/alert_management/alerts/update_alert_status_spec.rb
+++ b/spec/requests/api/graphql/mutations/alert_management/alerts/update_alert_status_spec.rb
@@ -7,6 +7,7 @@
let_it_be(:user) { create(:user) }
let_it_be(:project) { create(:project) }
+
let(:alert) { create(:alert_management_alert, project: project) }
let(:input) { { status: 'ACKNOWLEDGED' } }
diff --git a/spec/requests/api/graphql/mutations/alert_management/http_integration/create_spec.rb b/spec/requests/api/graphql/mutations/alert_management/http_integration/create_spec.rb
index e594d67aab4e750bbde7f0148ae28751f9663eb1..ff93da2153f08ebae3383be1bbde4db8273800fe 100644
--- a/spec/requests/api/graphql/mutations/alert_management/http_integration/create_spec.rb
+++ b/spec/requests/api/graphql/mutations/alert_management/http_integration/create_spec.rb
@@ -7,6 +7,7 @@
let_it_be(:current_user) { create(:user) }
let_it_be(:project) { create(:project) }
+
let(:variables) do
{
project_path: project.full_path,
diff --git a/spec/requests/api/graphql/mutations/alert_management/prometheus_integration/create_spec.rb b/spec/requests/api/graphql/mutations/alert_management/prometheus_integration/create_spec.rb
index dd7806bdbe0d88c7b22c38aef8b4c569bcbc8097..4c359d9b357582324e1f0c9974489f835c657099 100644
--- a/spec/requests/api/graphql/mutations/alert_management/prometheus_integration/create_spec.rb
+++ b/spec/requests/api/graphql/mutations/alert_management/prometheus_integration/create_spec.rb
@@ -7,6 +7,7 @@
let_it_be(:current_user) { create(:user) }
let_it_be(:project) { create(:project) }
+
let(:variables) do
{
project_path: project.full_path,
diff --git a/spec/requests/api/graphql/mutations/award_emojis/add_spec.rb b/spec/requests/api/graphql/mutations/award_emojis/add_spec.rb
index b39062f2e71b997e6086d8f8b05ddeeede1905e0..fdf5503a3a2a8bc431a64471541626a66b0270dd 100644
--- a/spec/requests/api/graphql/mutations/award_emojis/add_spec.rb
+++ b/spec/requests/api/graphql/mutations/award_emojis/add_spec.rb
@@ -8,6 +8,7 @@
let_it_be(:current_user) { create(:user) }
let_it_be(:project) { create(:project) }
let_it_be(:awardable) { create(:note, project: project) }
+
let(:emoji_name) { 'thumbsup' }
let(:mutation) do
variables = {
diff --git a/spec/requests/api/graphql/mutations/award_emojis/toggle_spec.rb b/spec/requests/api/graphql/mutations/award_emojis/toggle_spec.rb
index 170e7ff3b449f8a6fa2354e1a4089e61aa7f0089..6b26e37e30c450612f58ca8af3e5e17961915658 100644
--- a/spec/requests/api/graphql/mutations/award_emojis/toggle_spec.rb
+++ b/spec/requests/api/graphql/mutations/award_emojis/toggle_spec.rb
@@ -8,6 +8,7 @@
let_it_be(:current_user) { create(:user) }
let_it_be(:project, reload: true) { create(:project) }
let_it_be(:awardable) { create(:note, project: project) }
+
let(:emoji_name) { 'thumbsup' }
let(:mutation) do
variables = {
diff --git a/spec/requests/api/graphql/mutations/boards/create_spec.rb b/spec/requests/api/graphql/mutations/boards/create_spec.rb
index c5f981262ea0db8547e5beacb05e5ce2f236e7da..22d05f36f0f8977f0acaf5f365ef66628b0bcdbe 100644
--- a/spec/requests/api/graphql/mutations/boards/create_spec.rb
+++ b/spec/requests/api/graphql/mutations/boards/create_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe Mutations::Boards::Create do
let_it_be(:parent) { create(:project) }
+
let(:project_path) { parent.full_path }
let(:params) do
{
diff --git a/spec/requests/api/graphql/mutations/branches/create_spec.rb b/spec/requests/api/graphql/mutations/branches/create_spec.rb
index fc09f57a38978201a745d8f9b77169995ceb3a07..2f19de2af541c8320ba4fd314e26fd2bf2691cb3 100644
--- a/spec/requests/api/graphql/mutations/branches/create_spec.rb
+++ b/spec/requests/api/graphql/mutations/branches/create_spec.rb
@@ -7,6 +7,7 @@
let_it_be(:current_user) { create(:user) }
let_it_be(:project) { create(:project, :public, :empty_repo) }
+
let(:input) { { project_path: project.full_path, name: new_branch, ref: ref } }
let(:new_branch) { 'new_branch' }
let(:ref) { 'master' }
diff --git a/spec/requests/api/graphql/mutations/commits/create_spec.rb b/spec/requests/api/graphql/mutations/commits/create_spec.rb
index 375d4f10b4049cfbf25b5b98906953650880fdba..619cba99c4e91179d545408152e7a05b6adf0068 100644
--- a/spec/requests/api/graphql/mutations/commits/create_spec.rb
+++ b/spec/requests/api/graphql/mutations/commits/create_spec.rb
@@ -7,6 +7,7 @@
let_it_be(:current_user) { create(:user) }
let_it_be(:project) { create(:project, :public, :repository) }
+
let(:input) { { project_path: project.full_path, branch: branch, message: message, actions: actions } }
let(:branch) { 'master' }
let(:message) { 'Commit message' }
diff --git a/spec/requests/api/graphql/mutations/container_expiration_policy/update_spec.rb b/spec/requests/api/graphql/mutations/container_expiration_policy/update_spec.rb
index 23e8e36648342e36283d83319902ef23bec7879e..0156142dc6fb41c106ad038a67bdc6d84d2f815c 100644
--- a/spec/requests/api/graphql/mutations/container_expiration_policy/update_spec.rb
+++ b/spec/requests/api/graphql/mutations/container_expiration_policy/update_spec.rb
@@ -53,6 +53,7 @@
RSpec.shared_examples 'rejecting invalid regex for' do |field_name|
context "for field #{field_name}" do
let_it_be(:invalid_regex) { '*production' }
+
let(:params) do
{
:project_path => project.full_path,
diff --git a/spec/requests/api/graphql/mutations/discussions/toggle_resolve_spec.rb b/spec/requests/api/graphql/mutations/discussions/toggle_resolve_spec.rb
index 450996bf76b088a20e4f216dd3a7dcbc08cf4f31..632a934cd9590a4d1554cafcd68c752b0ed4736a 100644
--- a/spec/requests/api/graphql/mutations/discussions/toggle_resolve_spec.rb
+++ b/spec/requests/api/graphql/mutations/discussions/toggle_resolve_spec.rb
@@ -7,6 +7,7 @@
let_it_be(:project) { create(:project, :public, :repository) }
let_it_be(:noteable) { create(:merge_request, source_project: project) }
+
let(:discussion) do
create(:diff_note_on_merge_request, noteable: noteable, project: project).to_discussion
end
diff --git a/spec/requests/api/graphql/mutations/environments/canary_ingress/update_spec.rb b/spec/requests/api/graphql/mutations/environments/canary_ingress/update_spec.rb
index f25a49291a62a05986b5d444aa8c37729ec14247..3771ae0746e5c5ee32dac53a9c07b3ba4dcc09f0 100644
--- a/spec/requests/api/graphql/mutations/environments/canary_ingress/update_spec.rb
+++ b/spec/requests/api/graphql/mutations/environments/canary_ingress/update_spec.rb
@@ -13,6 +13,7 @@
let_it_be(:deployment) { create(:deployment, :success, environment: environment, project: project) }
let_it_be(:maintainer) { create(:user) }
let_it_be(:developer) { create(:user) }
+
let(:environment_id) { environment.to_global_id.to_s }
let(:weight) { 25 }
let(:actor) { developer }
diff --git a/spec/requests/api/graphql/mutations/issues/set_locked_spec.rb b/spec/requests/api/graphql/mutations/issues/set_locked_spec.rb
index 4989d096925e99549b3cd4ecf9020dac25780ec1..435ed0f9eb2c943fad1647937ad9feabd9d90471 100644
--- a/spec/requests/api/graphql/mutations/issues/set_locked_spec.rb
+++ b/spec/requests/api/graphql/mutations/issues/set_locked_spec.rb
@@ -8,6 +8,7 @@
let_it_be(:current_user) { create(:user) }
let_it_be(:issue) { create(:issue) }
let_it_be(:project) { issue.project }
+
let(:input) { { locked: true } }
let(:mutation) do
diff --git a/spec/requests/api/graphql/mutations/issues/set_severity_spec.rb b/spec/requests/api/graphql/mutations/issues/set_severity_spec.rb
index 96fd2368765cb05cf1b0931debadef008dbbb6f1..41997f151a2f8a91b7a0635a7f11409643d552a9 100644
--- a/spec/requests/api/graphql/mutations/issues/set_severity_spec.rb
+++ b/spec/requests/api/graphql/mutations/issues/set_severity_spec.rb
@@ -6,6 +6,7 @@
include GraphqlHelpers
let_it_be(:user) { create(:user) }
+
let(:incident) { create(:incident) }
let(:project) { incident.project }
let(:input) { { severity: 'CRITICAL' } }
diff --git a/spec/requests/api/graphql/mutations/issues/update_spec.rb b/spec/requests/api/graphql/mutations/issues/update_spec.rb
index adfa2a2bc084e3782fa13c04d65cb30338f46044..b3e1ab62e543aca558359f7f1357a430fb30378a 100644
--- a/spec/requests/api/graphql/mutations/issues/update_spec.rb
+++ b/spec/requests/api/graphql/mutations/issues/update_spec.rb
@@ -8,6 +8,7 @@
let_it_be(:current_user) { create(:user) }
let_it_be(:project) { create(:project, :public) }
let_it_be(:issue) { create(:issue, project: project) }
+
let(:input) do
{
'iid' => issue.iid.to_s,
diff --git a/spec/requests/api/graphql/mutations/jira_import/import_users_spec.rb b/spec/requests/api/graphql/mutations/jira_import/import_users_spec.rb
index 00b93984f982ef96e8ff0edf2b84183739b0a176..45cc70f09fd4f606474f9b14123d9d930c93973c 100644
--- a/spec/requests/api/graphql/mutations/jira_import/import_users_spec.rb
+++ b/spec/requests/api/graphql/mutations/jira_import/import_users_spec.rb
@@ -8,6 +8,7 @@
let_it_be(:user) { create(:user) }
let_it_be(:project) { create(:project) }
+
let(:importer) { instance_double(JiraImport::UsersImporter) }
let(:project_path) { project.full_path }
let(:start_at) { 7 }
diff --git a/spec/requests/api/graphql/mutations/jira_import/start_spec.rb b/spec/requests/api/graphql/mutations/jira_import/start_spec.rb
index 75668c9e6ae535c2b0c3360139629c78598087ed..b14305281af67b9221e2959b14f48a084a1def67 100644
--- a/spec/requests/api/graphql/mutations/jira_import/start_spec.rb
+++ b/spec/requests/api/graphql/mutations/jira_import/start_spec.rb
@@ -8,6 +8,7 @@
let_it_be(:user) { create(:user) }
let_it_be(:project, reload: true) { create(:project) }
+
let(:jira_project_key) { 'AA' }
let(:project_path) { project.full_path }
diff --git a/spec/requests/api/graphql/mutations/labels/create_spec.rb b/spec/requests/api/graphql/mutations/labels/create_spec.rb
index 2828440830698808e1077d40612cb05073200204..d19411f6c1d76619d469be19c923904019098b47 100644
--- a/spec/requests/api/graphql/mutations/labels/create_spec.rb
+++ b/spec/requests/api/graphql/mutations/labels/create_spec.rb
@@ -61,6 +61,7 @@ def mutation_response
context 'when creating a project label' do
let_it_be(:parent) { create(:project) }
+
let(:extra_params) { { project_path: parent.full_path } }
it_behaves_like 'labels create mutation'
@@ -68,6 +69,7 @@ def mutation_response
context 'when creating a group label' do
let_it_be(:parent) { create(:group) }
+
let(:extra_params) { { group_path: parent.full_path } }
it_behaves_like 'labels create mutation'
diff --git a/spec/requests/api/graphql/mutations/merge_requests/accept_spec.rb b/spec/requests/api/graphql/mutations/merge_requests/accept_spec.rb
index 2725b33d5288c0fc2df0f9d777beacbe8df08b78..19a7c72ba80d35860e26235e2a4df608c027760e 100644
--- a/spec/requests/api/graphql/mutations/merge_requests/accept_spec.rb
+++ b/spec/requests/api/graphql/mutations/merge_requests/accept_spec.rb
@@ -7,6 +7,7 @@
let_it_be(:current_user) { create(:user) }
let_it_be(:project) { create(:project, :public, :repository) }
+
let!(:merge_request) { create(:merge_request, source_project: project) }
let(:input) do
{
diff --git a/spec/requests/api/graphql/mutations/merge_requests/create_spec.rb b/spec/requests/api/graphql/mutations/merge_requests/create_spec.rb
index bf759521dc037bda267c58b85c66ed73a02a6bf7..3a4508489a1b9fa45a1668bd76398b497d072e61 100644
--- a/spec/requests/api/graphql/mutations/merge_requests/create_spec.rb
+++ b/spec/requests/api/graphql/mutations/merge_requests/create_spec.rb
@@ -6,6 +6,7 @@
include GraphqlHelpers
let_it_be(:current_user) { create(:user) }
+
let(:project) { create(:project, :public, :repository) }
let(:input) do
{
diff --git a/spec/requests/api/graphql/mutations/metrics/dashboard/annotations/create_spec.rb b/spec/requests/api/graphql/mutations/metrics/dashboard/annotations/create_spec.rb
index 2a39757e103cbbb4021ae69c0de5f0c014d22ddd..5bc3c68cf26b7c745a071937aac3309acf96cb05 100644
--- a/spec/requests/api/graphql/mutations/metrics/dashboard/annotations/create_spec.rb
+++ b/spec/requests/api/graphql/mutations/metrics/dashboard/annotations/create_spec.rb
@@ -9,6 +9,7 @@
let_it_be(:project) { create(:project, :private, :repository) }
let_it_be(:environment) { create(:environment, project: project) }
let_it_be(:cluster) { create(:cluster, projects: [project]) }
+
let(:dashboard_path) { 'config/prometheus/common_metrics.yml' }
let(:starting_at) { Time.current.iso8601 }
let(:ending_at) { 1.hour.from_now.iso8601 }
diff --git a/spec/requests/api/graphql/mutations/namespace/package_settings/update_spec.rb b/spec/requests/api/graphql/mutations/namespace/package_settings/update_spec.rb
index 202e7e7c33382956dcfd68b7ad8e68ebb4427e24..d335642d3217dec22b2fe1438bf5e01057a377c8 100644
--- a/spec/requests/api/graphql/mutations/namespace/package_settings/update_spec.rb
+++ b/spec/requests/api/graphql/mutations/namespace/package_settings/update_spec.rb
@@ -126,6 +126,7 @@
context 'without existing package settings' do
let_it_be(:namespace, reload: true) { create(:group) }
+
let(:package_settings) { namespace.package_settings }
where(:user_role, :shared_examples_name) do
diff --git a/spec/requests/api/graphql/mutations/notes/create/diff_note_spec.rb b/spec/requests/api/graphql/mutations/notes/create/diff_note_spec.rb
index b5aaf304812b782c764fb4a12561d983cc177df5..8f3ae9f26f6973792ed3ae3771a3f7bbce7da69d 100644
--- a/spec/requests/api/graphql/mutations/notes/create/diff_note_spec.rb
+++ b/spec/requests/api/graphql/mutations/notes/create/diff_note_spec.rb
@@ -6,6 +6,7 @@
include GraphqlHelpers
let_it_be(:current_user) { create(:user) }
+
let(:noteable) { create(:merge_request, source_project: project, target_project: project) }
let(:project) { create(:project, :repository) }
let(:diff_refs) { noteable.diff_refs }
diff --git a/spec/requests/api/graphql/mutations/notes/create/image_diff_note_spec.rb b/spec/requests/api/graphql/mutations/notes/create/image_diff_note_spec.rb
index 0e5744fb64f8644d0e2b5c000c4f87e0487afca6..8f2438cb741b027bbf54294b9f3fb8fc9e40b84e 100644
--- a/spec/requests/api/graphql/mutations/notes/create/image_diff_note_spec.rb
+++ b/spec/requests/api/graphql/mutations/notes/create/image_diff_note_spec.rb
@@ -6,6 +6,7 @@
include GraphqlHelpers
let_it_be(:current_user) { create(:user) }
+
let(:noteable) { create(:merge_request, source_project: project, target_project: project) }
let(:project) { create(:project, :repository) }
let(:diff_refs) { noteable.diff_refs }
diff --git a/spec/requests/api/graphql/mutations/notes/create/note_spec.rb b/spec/requests/api/graphql/mutations/notes/create/note_spec.rb
index 8dd8ed361bae6f8ce95ce469b74f724fe7542686..87c752393ead508f8ecacfe76693d2e10c14b78a 100644
--- a/spec/requests/api/graphql/mutations/notes/create/note_spec.rb
+++ b/spec/requests/api/graphql/mutations/notes/create/note_spec.rb
@@ -6,6 +6,7 @@
include GraphqlHelpers
let_it_be(:current_user) { create(:user) }
+
let(:noteable) { create(:merge_request, source_project: project, target_project: project) }
let(:project) { create(:project) }
let(:discussion) { nil }
diff --git a/spec/requests/api/graphql/mutations/notes/reposition_image_diff_note_spec.rb b/spec/requests/api/graphql/mutations/notes/reposition_image_diff_note_spec.rb
index 4efa7f9d5093d3ca256ffdbc7acfd7678e622564..89e3a71280f6730f6ddd882eec18f8fdd9cb50d3 100644
--- a/spec/requests/api/graphql/mutations/notes/reposition_image_diff_note_spec.rb
+++ b/spec/requests/api/graphql/mutations/notes/reposition_image_diff_note_spec.rb
@@ -7,6 +7,7 @@
let_it_be(:noteable) { create(:merge_request) }
let_it_be(:project) { noteable.project }
+
let(:note) { create(:image_diff_note_on_merge_request, noteable: noteable, project: project) }
let(:new_position) { { x: 10 } }
let(:current_user) { project.creator }
diff --git a/spec/requests/api/graphql/mutations/notes/update/image_diff_note_spec.rb b/spec/requests/api/graphql/mutations/notes/update/image_diff_note_spec.rb
index 1ce09881fde982051c55f191fdaabdbbc886ea6a..cfd0b34b815d491bb3440d314ad41b860c631b89 100644
--- a/spec/requests/api/graphql/mutations/notes/update/image_diff_note_spec.rb
+++ b/spec/requests/api/graphql/mutations/notes/update/image_diff_note_spec.rb
@@ -26,6 +26,7 @@
let_it_be(:updated_height) { 100 }
let_it_be(:updated_x) { 5 }
let_it_be(:updated_y) { 10 }
+
let(:updated_position) do
{
width: updated_width,
diff --git a/spec/requests/api/graphql/mutations/snippets/mark_as_spam_spec.rb b/spec/requests/api/graphql/mutations/snippets/mark_as_spam_spec.rb
index 4d4993105916935b88a1852682cf6dfd180015e3..43d846cb2972bb9e50ac395bf074c14390b9f1a2 100644
--- a/spec/requests/api/graphql/mutations/snippets/mark_as_spam_spec.rb
+++ b/spec/requests/api/graphql/mutations/snippets/mark_as_spam_spec.rb
@@ -10,6 +10,7 @@
let_it_be(:other_user) { create(:user) }
let_it_be(:snippet) { create(:personal_snippet) }
let_it_be(:user_agent_detail) { create(:user_agent_detail, subject: snippet) }
+
let(:current_user) { snippet.author }
let(:snippet_gid) { snippet.to_global_id.to_s }
diff --git a/spec/requests/api/graphql/mutations/snippets/update_spec.rb b/spec/requests/api/graphql/mutations/snippets/update_spec.rb
index a3a6ce65e9fab34e88be81079bd7cdd5eb1587bc..eb7e6f840fe61624d7f30bc189c90df534e58f76 100644
--- a/spec/requests/api/graphql/mutations/snippets/update_spec.rb
+++ b/spec/requests/api/graphql/mutations/snippets/update_spec.rb
@@ -9,6 +9,7 @@
let_it_be(:original_description) { 'Initial description' }
let_it_be(:original_title) { 'Initial title' }
let_it_be(:original_file_name) { 'Initial file_name' }
+
let(:updated_content) { 'Updated content' }
let(:updated_description) { 'Updated description' }
let(:updated_title) { 'Updated_title' }
@@ -139,6 +140,7 @@ def blob_at(filename)
describe 'ProjectSnippet' do
let_it_be(:project) { create(:project, :private) }
+
let(:snippet) do
create(:project_snippet,
:private,
diff --git a/spec/requests/api/graphql/mutations/user_callouts/create_spec.rb b/spec/requests/api/graphql/mutations/user_callouts/create_spec.rb
index cb67a60ebe4cead7d3f5bf116d8f6d08f5aa8a75..716983f01d26f1f3972807f4db0f24a4c5b45956 100644
--- a/spec/requests/api/graphql/mutations/user_callouts/create_spec.rb
+++ b/spec/requests/api/graphql/mutations/user_callouts/create_spec.rb
@@ -6,6 +6,7 @@
include GraphqlHelpers
let_it_be(:current_user) { create(:user) }
+
let(:feature_name) { ::UserCallout.feature_names.each_key.first }
let(:input) do
diff --git a/spec/requests/api/graphql/namespace/package_settings_spec.rb b/spec/requests/api/graphql/namespace/package_settings_spec.rb
index 6af098e902f889447f10ab38a43583f2ac012bc7..42fd07dbdc78aceaa8f945093297ba736d6e5dcd 100644
--- a/spec/requests/api/graphql/namespace/package_settings_spec.rb
+++ b/spec/requests/api/graphql/namespace/package_settings_spec.rb
@@ -8,6 +8,7 @@
let_it_be(:package_settings) { create(:namespace_package_setting) }
let_it_be(:namespace) { package_settings.namespace }
let_it_be(:current_user) { namespace.owner }
+
let(:package_settings_response) { graphql_data.dig('namespace', 'packageSettings') }
let(:fields) { all_graphql_fields_for('PackageSettings') }
diff --git a/spec/requests/api/graphql/project/alert_management/alert/issue_spec.rb b/spec/requests/api/graphql/project/alert_management/alert/issue_spec.rb
index 9724de4fedbebb216f5a64fc19d91abc6491fb25..05a98a9dd9c33de6b13fb47f7c07ca6734ab54af 100644
--- a/spec/requests/api/graphql/project/alert_management/alert/issue_spec.rb
+++ b/spec/requests/api/graphql/project/alert_management/alert/issue_spec.rb
@@ -7,6 +7,7 @@
let_it_be(:project) { create(:project) }
let_it_be(:current_user) { create(:user) }
+
let(:payload) { {} }
let(:query) { 'avg(metric) > 1.0' }
diff --git a/spec/requests/api/graphql/project/alert_management/alert_status_counts_spec.rb b/spec/requests/api/graphql/project/alert_management/alert_status_counts_spec.rb
index 9fbf5aaa41fdf0b89583682602848db88a65dc5b..ecd93d169d32844971e3e2dcea9759315a6eb52d 100644
--- a/spec/requests/api/graphql/project/alert_management/alert_status_counts_spec.rb
+++ b/spec/requests/api/graphql/project/alert_management/alert_status_counts_spec.rb
@@ -9,6 +9,7 @@
let_it_be(:alert_resolved) { create(:alert_management_alert, :resolved, project: project) }
let_it_be(:alert_triggered) { create(:alert_management_alert, project: project) }
let_it_be(:other_project_alert) { create(:alert_management_alert) }
+
let(:params) { {} }
let(:fields) do
diff --git a/spec/requests/api/graphql/project/error_tracking/sentry_detailed_error_request_spec.rb b/spec/requests/api/graphql/project/error_tracking/sentry_detailed_error_request_spec.rb
index b2b42137acfe49d58245ca482a5cbe91b5bc765d..14fabaaf0328d4c72f29679debf879d37113f19e 100644
--- a/spec/requests/api/graphql/project/error_tracking/sentry_detailed_error_request_spec.rb
+++ b/spec/requests/api/graphql/project/error_tracking/sentry_detailed_error_request_spec.rb
@@ -8,6 +8,7 @@
let_it_be(:project_setting) { create(:project_error_tracking_setting, project: project) }
let_it_be(:current_user) { project.owner }
let_it_be(:sentry_detailed_error) { build(:detailed_error_tracking_error) }
+
let(:sentry_gid) { sentry_detailed_error.to_global_id.to_s }
let(:fields) do
<<~QUERY
diff --git a/spec/requests/api/graphql/project/error_tracking/sentry_errors_request_spec.rb b/spec/requests/api/graphql/project/error_tracking/sentry_errors_request_spec.rb
index c7d327a62af0761787fdcac8bab60e6ef6d68d98..e71e5a48ddccc227cbaf5071a1367070489028a1 100644
--- a/spec/requests/api/graphql/project/error_tracking/sentry_errors_request_spec.rb
+++ b/spec/requests/api/graphql/project/error_tracking/sentry_errors_request_spec.rb
@@ -17,6 +17,7 @@
describe 'getting a detailed sentry error' do
let_it_be(:sentry_detailed_error) { build(:detailed_error_tracking_error) }
+
let(:sentry_gid) { sentry_detailed_error.to_global_id.to_s }
let(:detailed_fields) do
@@ -193,6 +194,7 @@
describe 'getting a stack trace' do
let_it_be(:sentry_stack_trace) { build(:error_tracking_error_event) }
+
let(:sentry_gid) { global_id_of(Gitlab::ErrorTracking::DetailedError.new(id: 1)) }
let(:stack_trace_fields) do
diff --git a/spec/requests/api/graphql/project/issue/designs/designs_spec.rb b/spec/requests/api/graphql/project/issue/designs/designs_spec.rb
index decab900a43dd704785551cb16036ad621c22c1c..def41efddde00af835662e41cbb8e23e356855cb 100644
--- a/spec/requests/api/graphql/project/issue/designs/designs_spec.rb
+++ b/spec/requests/api/graphql/project/issue/designs/designs_spec.rb
@@ -8,6 +8,7 @@
let_it_be(:design) { create(:design, :with_smaller_image_versions, versions_count: 1) }
let_it_be(:current_user) { design.project.owner }
+
let(:design_query) do
<<~NODE
designs {
@@ -124,6 +125,7 @@ def response_ids(data = graphql_data)
context 'with versions' do
let_it_be(:version) { design.versions.take }
+
let(:design_query) do
<<~NODE
designs {
@@ -165,6 +167,7 @@ def response_ids(data = graphql_data)
let_it_be(:issue) { design.issue }
let_it_be(:second_design, reload: true) { create(:design, :with_smaller_image_versions, issue: issue, versions_count: 1) }
let_it_be(:deleted_design) { create(:design, :with_versions, issue: issue, deleted: true, versions_count: 1) }
+
let(:all_versions) { issue.design_versions.ordered.reverse }
let(:design_query) do
<<~NODE
diff --git a/spec/requests/api/graphql/project/project_pipeline_statistics_spec.rb b/spec/requests/api/graphql/project/project_pipeline_statistics_spec.rb
index 7d157563f5f311757d6cec16ebb47cff057afd2b..39a68d98d846e6f39ccf3d467edf5e5952d2b5d3 100644
--- a/spec/requests/api/graphql/project/project_pipeline_statistics_spec.rb
+++ b/spec/requests/api/graphql/project/project_pipeline_statistics_spec.rb
@@ -6,6 +6,7 @@
include GraphqlHelpers
let_it_be(:project) { create(:project) }
+
let(:user) { create(:user) }
let(:fields) do
diff --git a/spec/requests/api/graphql/project_query_spec.rb b/spec/requests/api/graphql/project_query_spec.rb
index 54375d4de1d5627e51ee78c521bfe8d1cc48a159..e44a7efb3547c4fa667052a51b03c91fc33d8189 100644
--- a/spec/requests/api/graphql/project_query_spec.rb
+++ b/spec/requests/api/graphql/project_query_spec.rb
@@ -8,6 +8,7 @@
let_it_be(:group) { create(:group) }
let_it_be(:project, reload: true) { create(:project, :repository, group: group) }
let_it_be(:current_user) { create(:user) }
+
let(:project_fields) { all_graphql_fields_for('project'.to_s.classify, max_depth: 1) }
let(:query) do
diff --git a/spec/requests/api/graphql/query_spec.rb b/spec/requests/api/graphql/query_spec.rb
index 6bd0703c1216f9eeb15b3063e83c2f11c84ccef8..ecc7fffaef7403e972ab11f470fd4dcdcea8dc72 100644
--- a/spec/requests/api/graphql/query_spec.rb
+++ b/spec/requests/api/graphql/query_spec.rb
@@ -8,6 +8,7 @@
let_it_be(:project) { create(:project) }
let_it_be(:issue) { create(:issue, project: project) }
let_it_be(:developer) { create(:user) }
+
let(:current_user) { developer }
describe '.designManagement' do
@@ -15,6 +16,7 @@
let_it_be(:version) { create(:design_version, issue: issue) }
let_it_be(:design) { version.designs.first }
+
let(:query_result) { graphql_data.dig(*path) }
let(:query) { graphql_query_for(:design_management, nil, dm_fields) }
diff --git a/spec/requests/api/graphql/user/starred_projects_query_spec.rb b/spec/requests/api/graphql/user/starred_projects_query_spec.rb
index 6cb02068f2aa1bb61f766a82ddca34c6fcbc0552..a8c087d1fbf0ee5de3c81822cc879387ae0a20d8 100644
--- a/spec/requests/api/graphql/user/starred_projects_query_spec.rb
+++ b/spec/requests/api/graphql/user/starred_projects_query_spec.rb
@@ -60,6 +60,7 @@
context 'the current user is a member of a private project the user starred' do
let_it_be(:other_user) { create(:user) }
+
let(:current_user) { other_user }
before do
diff --git a/spec/requests/api/graphql/user_query_spec.rb b/spec/requests/api/graphql/user_query_spec.rb
index 60520906e875deacc59039fb82fdce1738966f31..59b805bb25ba59bceb76804aef547fd3762eee08 100644
--- a/spec/requests/api/graphql/user_query_spec.rb
+++ b/spec/requests/api/graphql/user_query_spec.rb
@@ -402,6 +402,7 @@
context 'we request the groupMemberships' do
let_it_be(:membership_a) { create(:group_member, user: user) }
+
let(:group_memberships) { graphql_data_at(:user, :group_memberships, :nodes) }
let(:user_fields) { 'groupMemberships { nodes { id } }' }
@@ -424,6 +425,7 @@
context 'we request the projectMemberships' do
let_it_be(:membership_a) { create(:project_member, user: user) }
+
let(:project_memberships) { graphql_data_at(:user, :project_memberships, :nodes) }
let(:user_fields) { 'projectMemberships { nodes { id } }' }
diff --git a/spec/requests/api/graphql_spec.rb b/spec/requests/api/graphql_spec.rb
index a336d74b13597048444d69c69c1f6d9ee38e6401..650d525b604d29176a1f12137203a03591f03baf 100644
--- a/spec/requests/api/graphql_spec.rb
+++ b/spec/requests/api/graphql_spec.rb
@@ -175,6 +175,7 @@
describe 'resolver complexity' do
let_it_be(:project) { create(:project, :public) }
+
let(:query) do
graphql_query_for(
'project',
@@ -210,6 +211,7 @@
describe 'complexity limits' do
let_it_be(:project) { create(:project, :public) }
+
let!(:user) { create(:user) }
let(:query_fields) do
diff --git a/spec/requests/api/group_import_spec.rb b/spec/requests/api/group_import_spec.rb
index f632e49bf3a468b1fba3b0338862093ee6bc8574..efad633451845e8a1e26100cb4d06c9153e73868 100644
--- a/spec/requests/api/group_import_spec.rb
+++ b/spec/requests/api/group_import_spec.rb
@@ -9,6 +9,7 @@
let_it_be(:user) { create(:user) }
let_it_be(:group) { create(:group) }
+
let(:path) { '/groups/import' }
let(:file) { File.join('spec', 'fixtures', 'group_export.tar.gz') }
let(:export_path) { "#{Dir.tmpdir}/group_export_spec" }
diff --git a/spec/requests/api/group_milestones_spec.rb b/spec/requests/api/group_milestones_spec.rb
index e3e0164e5a7f0e1755ec5d660fc2d092b603757c..2312d35c815739ba18135643be29a7bc26220eca 100644
--- a/spec/requests/api/group_milestones_spec.rb
+++ b/spec/requests/api/group_milestones_spec.rb
@@ -9,6 +9,7 @@
let_it_be(:group_member) { create(:group_member, group: group, user: user) }
let_it_be(:closed_milestone) { create(:closed_milestone, group: group, title: 'version1', description: 'closed milestone') }
let_it_be(:milestone) { create(:milestone, group: group, title: 'version2', description: 'open milestone') }
+
let(:route) { "/groups/#{group.id}/milestones" }
it_behaves_like 'group and project milestones', "/groups/:id/milestones"
diff --git a/spec/requests/api/group_packages_spec.rb b/spec/requests/api/group_packages_spec.rb
index 792aa2c1f203da091c41d3949e5707cef9fcaec2..a2b0b35c76a7fbbdb62f53253c994de173e164ae 100644
--- a/spec/requests/api/group_packages_spec.rb
+++ b/spec/requests/api/group_packages_spec.rb
@@ -6,6 +6,7 @@
let_it_be(:group) { create(:group, :public) }
let_it_be(:project) { create(:project, :public, namespace: group, name: 'project A') }
let_it_be(:user) { create(:user) }
+
let(:params) { {} }
subject { get api(url), params: params }
@@ -17,6 +18,7 @@
context 'with sorting' do
let_it_be(:package1) { create(:npm_package, project: project, version: '3.1.0', name: "@#{project.root_namespace.path}/foo1") }
let_it_be(:package2) { create(:nuget_package, project: project, version: '2.0.4') }
+
let(:package3) { create(:maven_package, project: project, version: '1.1.1', name: 'zzz') }
before do
diff --git a/spec/requests/api/groups_spec.rb b/spec/requests/api/groups_spec.rb
index 8d2ae8cc16d0a14aa213d98a3a70794b23f6a19b..ad7a2e3b1fb7f1001776d9528568da1e84f6a11f 100644
--- a/spec/requests/api/groups_spec.rb
+++ b/spec/requests/api/groups_spec.rb
@@ -1432,6 +1432,7 @@ def make_upload_request
let_it_be(:sub_child_group1) { create(:group, parent: child_group1) }
let_it_be(:child_group2) { create(:group, :private, parent: group2) }
let_it_be(:sub_child_group2) { create(:group, :private, parent: child_group2) }
+
let(:response_groups) { json_response.map { |group| group['name'] } }
context 'when unauthenticated' do
diff --git a/spec/requests/api/helpers_spec.rb b/spec/requests/api/helpers_spec.rb
index ce0018d6d0da7444b06569b1f14714c3942211ec..8961f3177b67ab22232cc7d0df8c1555aa0f3acc 100644
--- a/spec/requests/api/helpers_spec.rb
+++ b/spec/requests/api/helpers_spec.rb
@@ -10,6 +10,7 @@
include TermsHelper
let_it_be(:user, reload: true) { create(:user) }
+
let(:admin) { create(:admin) }
let(:key) { create(:key, user: user) }
diff --git a/spec/requests/api/import_bitbucket_server_spec.rb b/spec/requests/api/import_bitbucket_server_spec.rb
index dac139064dac0422a90aebe65b2b31c5a8627162..2225f737f36431179c72959a3c94a49b509757d9 100644
--- a/spec/requests/api/import_bitbucket_server_spec.rb
+++ b/spec/requests/api/import_bitbucket_server_spec.rb
@@ -14,6 +14,7 @@
describe "POST /import/bitbucket_server" do
context 'with no optional parameters' do
let_it_be(:project) { create(:project) }
+
let(:client) { double(BitbucketServer::Client) }
before do
@@ -48,6 +49,7 @@
context 'with a new project name' do
let_it_be(:project) { create(:project, name: 'new-name') }
+
let(:client) { instance_double(BitbucketServer::Client) }
before do
@@ -83,6 +85,7 @@
context 'with an invalid URL' do
let_it_be(:project) { create(:project, name: 'new-name') }
+
let(:client) { instance_double(BitbucketServer::Client) }
before do
diff --git a/spec/requests/api/internal/base_spec.rb b/spec/requests/api/internal/base_spec.rb
index 5f1454f6c5d3a76d7837ce5c3da5139ad5d5990d..49756df61c6ff9c21a92850c35d498332997fd3d 100644
--- a/spec/requests/api/internal/base_spec.rb
+++ b/spec/requests/api/internal/base_spec.rb
@@ -9,6 +9,7 @@
let_it_be(:project, reload: true) { create(:project, :repository, :wiki_repo) }
let_it_be(:personal_snippet) { create(:personal_snippet, :repository, author: user) }
let_it_be(:project_snippet) { create(:project_snippet, :repository, author: user, project: project) }
+
let(:key) { create(:key, user: user) }
let(:secret_token) { Gitlab::Shell.secret_token }
let(:gl_repository) { "project-#{project.id}" }
diff --git a/spec/requests/api/lint_spec.rb b/spec/requests/api/lint_spec.rb
index 57aa0f36192461d5dfa4b8d9beb9be0ab39a7434..7fe516d3daa3c0386b76a37de0364d8f8dfa69db 100644
--- a/spec/requests/api/lint_spec.rb
+++ b/spec/requests/api/lint_spec.rb
@@ -19,6 +19,7 @@
context 'when authenticated' do
let_it_be(:api_user) { create(:user) }
+
it 'returns authorized' do
post api('/ci/lint', api_user), params: { content: 'content' }
@@ -43,6 +44,7 @@
context 'when authenticated' do
let_it_be(:api_user) { create(:user) }
+
it 'returns authentication success' do
post api('/ci/lint', api_user), params: { content: 'content' }
diff --git a/spec/requests/api/markdown_spec.rb b/spec/requests/api/markdown_spec.rb
index 35d91963ac921fa51d588b6000bdd4b330646f3e..faf671d350f18879b88dccb3cb3965765d5bbb7e 100644
--- a/spec/requests/api/markdown_spec.rb
+++ b/spec/requests/api/markdown_spec.rb
@@ -52,6 +52,7 @@
context "when arguments are valid" do
let_it_be(:project) { create(:project) }
let_it_be(:issue) { create(:issue, project: project) }
+
let(:issue_url) { "http://#{Gitlab.config.gitlab.host}/#{issue.project.namespace.path}/#{issue.project.path}/-/issues/#{issue.iid}" }
let(:text) { ":tada: Hello world! :100: #{issue.to_reference}" }
diff --git a/spec/requests/api/merge_requests_spec.rb b/spec/requests/api/merge_requests_spec.rb
index 691d1133724f4237550a6b3ef93d218c064d5cbc..a2137ec6ed5d0f4d54f1fe251e1321ce8c33aefa 100644
--- a/spec/requests/api/merge_requests_spec.rb
+++ b/spec/requests/api/merge_requests_spec.rb
@@ -2007,6 +2007,7 @@
context 'forked projects', :sidekiq_might_not_need_inline do
let_it_be(:user2) { create(:user) }
+
let(:project) { create(:project, :public, :repository) }
let!(:forked_project) { fork_project(project, user2, repository: true) }
let!(:unrelated_project) { create(:project, namespace: create(:user).namespace, creator_id: user2.id) }
@@ -2887,6 +2888,7 @@
context "forked projects" do
let_it_be(:user2) { create(:user) }
+
let(:project) { create(:project, :public, :repository) }
let!(:forked_project) { fork_project(project, user2, repository: true) }
let(:merge_request) do
diff --git a/spec/requests/api/metrics/dashboard/annotations_spec.rb b/spec/requests/api/metrics/dashboard/annotations_spec.rb
index 07de2925ee2e73f237cfe067be9b0f90837db213..79a38702354c7d4eb4cc19ccd56ee86baa33fcac 100644
--- a/spec/requests/api/metrics/dashboard/annotations_spec.rb
+++ b/spec/requests/api/metrics/dashboard/annotations_spec.rb
@@ -6,6 +6,7 @@
let_it_be(:user) { create(:user) }
let_it_be(:project) { create(:project, :private, :repository, namespace: user.namespace) }
let_it_be(:environment) { create(:environment, project: project) }
+
let(:dashboard) { 'config/prometheus/common_metrics.yml' }
let(:starting_at) { Time.now.iso8601 }
let(:ending_at) { 1.hour.from_now.iso8601 }
diff --git a/spec/requests/api/metrics/user_starred_dashboards_spec.rb b/spec/requests/api/metrics/user_starred_dashboards_spec.rb
index 533dff05f270b4a676c73a479d5b30ea1e4ca523..7f019e1226a9254b1a45ae7b540eca5258c6de38 100644
--- a/spec/requests/api/metrics/user_starred_dashboards_spec.rb
+++ b/spec/requests/api/metrics/user_starred_dashboards_spec.rb
@@ -7,6 +7,7 @@
let_it_be(:dashboard_yml) { fixture_file('lib/gitlab/metrics/dashboard/sample_dashboard.yml') }
let_it_be(:dashboard) { '.gitlab/dashboards/find&seek.yml' }
let_it_be(:project) { create(:project, :private, :repository, :custom_repo, namespace: user.namespace, files: { dashboard => dashboard_yml }) }
+
let(:url) { "/projects/#{project.id}/metrics/user_starred_dashboards" }
let(:params) do
{
diff --git a/spec/requests/api/nuget_project_packages_spec.rb b/spec/requests/api/nuget_project_packages_spec.rb
index a9e695dacbbb188baf6745d7af1dfb61f736699b..f608f296295563f697aa42124101c10945e4df53 100644
--- a/spec/requests/api/nuget_project_packages_spec.rb
+++ b/spec/requests/api/nuget_project_packages_spec.rb
@@ -162,6 +162,7 @@
include_context 'workhorse headers'
let_it_be(:file_name) { 'package.nupkg' }
+
let(:url) { "/projects/#{target.id}/packages/nuget" }
let(:headers) { {} }
let(:params) { { package: temp_file(file_name) } }
@@ -197,6 +198,7 @@
include_context 'workhorse headers'
let_it_be(:file_name) { 'package.snupkg' }
+
let(:url) { "/projects/#{target.id}/packages/nuget/symbolpackage" }
let(:headers) { {} }
let(:params) { { package: temp_file(file_name) } }
diff --git a/spec/requests/api/project_clusters_spec.rb b/spec/requests/api/project_clusters_spec.rb
index f784f677c259f16f6f4023aa326d7b6585cc4151..253b61e5865210c89ce91ad99d54c43e47bf1eed 100644
--- a/spec/requests/api/project_clusters_spec.rb
+++ b/spec/requests/api/project_clusters_spec.rb
@@ -335,6 +335,7 @@
let(:namespace) { 'new-namespace' }
let(:platform_kubernetes_attributes) { { namespace: namespace } }
let_it_be(:management_project) { create(:project, namespace: project.namespace) }
+
let(:management_project_id) { management_project.id }
let(:update_params) do
diff --git a/spec/requests/api/project_container_repositories_spec.rb b/spec/requests/api/project_container_repositories_spec.rb
index 695d2c3fe2ce6952bfc74c94f018291c634612b9..1170a9ba6cbb9b350800000a766632ad795effee 100644
--- a/spec/requests/api/project_container_repositories_spec.rb
+++ b/spec/requests/api/project_container_repositories_spec.rb
@@ -11,6 +11,7 @@
let_it_be(:developer) { create(:user) }
let_it_be(:reporter) { create(:user) }
let_it_be(:guest) { create(:user) }
+
let(:root_repository) { create(:container_repository, :root, project: project) }
let(:test_repository) { create(:container_repository, project: project) }
let(:root_repository2) { create(:container_repository, :root, project: project2) }
diff --git a/spec/requests/api/project_milestones_spec.rb b/spec/requests/api/project_milestones_spec.rb
index 71535e66353c718b1345aa58ec61edaaf2c7039d..606279ec20a0291cc48206a7c6e6b4978087be37 100644
--- a/spec/requests/api/project_milestones_spec.rb
+++ b/spec/requests/api/project_milestones_spec.rb
@@ -21,6 +21,7 @@
let_it_be(:group) { create(:group, :private, parent: ancestor_group) }
let_it_be(:ancestor_group_milestone) { create(:milestone, group: ancestor_group) }
let_it_be(:group_milestone) { create(:milestone, group: group) }
+
let(:params) { { include_parent_milestones: true } }
shared_examples 'listing all milestones' do
diff --git a/spec/requests/api/pypi_packages_spec.rb b/spec/requests/api/pypi_packages_spec.rb
index 86925e6a0ba86c2e5c1644be86d65e9db2dbd860..e66326db2a2fafae10f6b4061adbfd999bd1b0b8 100644
--- a/spec/requests/api/pypi_packages_spec.rb
+++ b/spec/requests/api/pypi_packages_spec.rb
@@ -14,6 +14,7 @@
let_it_be(:deploy_token) { create(:deploy_token, read_package_registry: true, write_package_registry: true) }
let_it_be(:project_deploy_token) { create(:project_deploy_token, deploy_token: deploy_token, project: project) }
let_it_be(:job) { create(:ci_build, :running, user: user, project: project) }
+
let(:headers) { {} }
context 'simple API endpoint' do
@@ -117,6 +118,7 @@
include_context 'workhorse headers'
let_it_be(:file_name) { 'package.whl' }
+
let(:url) { "/projects/#{project.id}/packages/pypi" }
let(:headers) { {} }
let(:requires_python) { '>=3.7' }
diff --git a/spec/requests/api/rubygem_packages_spec.rb b/spec/requests/api/rubygem_packages_spec.rb
index 7d863b55bbe6a8f6c7713b073bff7a2a39159805..9b104520b52d340da3a02d240ca2cc051e4d818c 100644
--- a/spec/requests/api/rubygem_packages_spec.rb
+++ b/spec/requests/api/rubygem_packages_spec.rb
@@ -14,6 +14,7 @@
let_it_be(:deploy_token) { create(:deploy_token, read_package_registry: true, write_package_registry: true) }
let_it_be(:project_deploy_token) { create(:project_deploy_token, deploy_token: deploy_token, project: project) }
let_it_be(:headers) { {} }
+
let(:snowplow_gitlab_standard_context) { { project: project, namespace: project.namespace, user: user } }
let(:tokens) do
@@ -244,6 +245,7 @@
let(:url) { "/projects/#{project.id}/packages/rubygems/api/v1/gems" }
let_it_be(:file_name) { 'package.gem' }
+
let(:headers) { {} }
let(:params) { { file: temp_file(file_name) } }
let(:file_key) { :file }
diff --git a/spec/requests/api/unleash_spec.rb b/spec/requests/api/unleash_spec.rb
index 9989f8d28bd709123d956591fd7404897c966d35..0718710f15c843d5fb2e17e9ceaf50a74d4ae54a 100644
--- a/spec/requests/api/unleash_spec.rb
+++ b/spec/requests/api/unleash_spec.rb
@@ -6,6 +6,7 @@
include FeatureFlagHelpers
let_it_be(:project, refind: true) { create(:project) }
+
let(:project_id) { project.id }
let(:params) { }
let(:headers) { }
diff --git a/spec/requests/api/users_spec.rb b/spec/requests/api/users_spec.rb
index a9231b65c8f32aafd379abda48a0779512650af8..a1bf023c8524c277c0d9340c1ee26908a3425ae6 100644
--- a/spec/requests/api/users_spec.rb
+++ b/spec/requests/api/users_spec.rb
@@ -8,6 +8,7 @@
let_it_be(:key) { create(:key, user: user) }
let_it_be(:gpg_key) { create(:gpg_key, user: user) }
let_it_be(:email) { create(:email, user: user) }
+
let(:omniauth_user) { create(:omniauth_user) }
let(:ldap_blocked_user) { create(:omniauth_user, provider: 'ldapmain', state: 'ldap_blocked') }
let(:private_user) { create(:user, private_profile: true) }
@@ -2967,6 +2968,7 @@ def update_password(user, admin, password = User.random_password)
let_it_be(:user) { create(:user) }
let_it_be(:project) { create(:project) }
let_it_be(:group) { create(:group) }
+
let(:requesting_user) { create(:user) }
before_all do
diff --git a/spec/requests/import/gitlab_groups_controller_spec.rb b/spec/requests/import/gitlab_groups_controller_spec.rb
index c65caf2ebf0b8c1d12e7064abf612a28ddbd1c4b..1f6487986a39a75dd57384b37ddcf245c9b4a151 100644
--- a/spec/requests/import/gitlab_groups_controller_spec.rb
+++ b/spec/requests/import/gitlab_groups_controller_spec.rb
@@ -8,6 +8,7 @@
include_context 'workhorse headers'
let_it_be(:user) { create(:user) }
+
let(:import_path) { "#{Dir.tmpdir}/gitlab_groups_controller_spec" }
before do
diff --git a/spec/requests/jwt_controller_spec.rb b/spec/requests/jwt_controller_spec.rb
index 5b5658da97ef98f070b6b52c73cd3bb7624ce2ae..55577a5dc65f6eb31c4fc8302f8ce4aa789cee83 100644
--- a/spec/requests/jwt_controller_spec.rb
+++ b/spec/requests/jwt_controller_spec.rb
@@ -227,6 +227,7 @@ def credentials(login, password)
let_it_be(:group_deploy_token) { create(:deploy_token, :group, groups: [group]) }
let_it_be(:project_deploy_token) { create(:deploy_token, :project, projects: [project]) }
let_it_be(:service_name) { 'dependency_proxy' }
+
let(:headers) { { authorization: credentials(credential_user, credential_password) } }
let(:params) { { account: credential_user, client_id: 'docker', offline_token: true, service: service_name } }
diff --git a/spec/requests/lfs_http_spec.rb b/spec/requests/lfs_http_spec.rb
index fda8b2ecec6485d5d58bd119771f43debf4ced63..975026c724e2aa00ee2d0dc26f4b75eb50967966 100644
--- a/spec/requests/lfs_http_spec.rb
+++ b/spec/requests/lfs_http_spec.rb
@@ -105,6 +105,7 @@
context 'when deploy key is authorized' do
let_it_be(:key) { create(:deploy_key) }
+
let(:authorization) { authorize_deploy_key }
before do
@@ -344,6 +345,7 @@ def authorization_in_action(action)
context 'when user password is expired' do
let_it_be(:user) { create(:user, password_expires_at: 1.minute.ago)}
+
let(:role) { :reporter}
it_behaves_like 'LFS http 401 response'
@@ -351,6 +353,7 @@ def authorization_in_action(action)
context 'when user is blocked' do
let_it_be(:user) { create(:user, :blocked)}
+
let(:role) { :reporter}
it_behaves_like 'LFS http 401 response'
@@ -405,6 +408,7 @@ def authorization_in_action(action)
context 'administrator', :enable_admin_mode do
let_it_be(:user) { create(:admin) }
+
let(:build) { create(:ci_build, :running, pipeline: pipeline, user: user) }
it_behaves_like 'can download LFS only from own projects', renew_authorization: true
@@ -458,6 +462,7 @@ def authorization_in_action(action)
describe 'upload' do
let_it_be(:project) { create(:project, :public) }
+
let(:body) { upload_body(sample_object) }
shared_examples 'pushes new LFS objects' do |renew_authorization:|
@@ -984,6 +989,7 @@ def authorization_in_action(action)
describe 'to a forked project' do
let_it_be(:upstream_project) { create(:project, :public) }
let_it_be(:project_owner) { create(:user) }
+
let(:project) { fork_project(upstream_project, project_owner) }
describe 'when user is authenticated' do
diff --git a/spec/requests/product_analytics/collector_app_spec.rb b/spec/requests/product_analytics/collector_app_spec.rb
index b87610841e77d8424203c7a7e925f574314b3a3f..0d55d167a6fbc56c5138d7914e6c6284b4d6a606 100644
--- a/spec/requests/product_analytics/collector_app_spec.rb
+++ b/spec/requests/product_analytics/collector_app_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe 'ProductAnalytics::CollectorApp' do
let_it_be(:project) { create(:project) }
+
let(:params) { {} }
let(:raw_event) { Gitlab::Json.parse(fixture_file('product_analytics/event.json')) }
diff --git a/spec/requests/rack_attack_global_spec.rb b/spec/requests/rack_attack_global_spec.rb
index f24f815e9c61f8799ed16833533f496f0d8148dd..f7b1b4726f6a6bb919886c2f42522d2d2597e13a 100644
--- a/spec/requests/rack_attack_global_spec.rb
+++ b/spec/requests/rack_attack_global_spec.rb
@@ -221,6 +221,7 @@ def do_request
let_it_be(:token) { create(:personal_access_token, user: user) }
let_it_be(:other_user) { create(:user) }
let_it_be(:other_user_token) { create(:personal_access_token, user: other_user) }
+
let(:throttle_setting_prefix) { 'throttle_authenticated_api' }
let(:api_partial_url) { '/todos' }
diff --git a/spec/services/admin/propagate_service_template_spec.rb b/spec/services/admin/propagate_service_template_spec.rb
index 1bcf9af78cef99659351aa97cf22879076efaaf8..c8ca3173f99c5c9b9a0f6d8dae55b501bbb62bdc 100644
--- a/spec/services/admin/propagate_service_template_spec.rb
+++ b/spec/services/admin/propagate_service_template_spec.rb
@@ -5,6 +5,7 @@
RSpec.describe Admin::PropagateServiceTemplate do
describe '.propagate' do
let_it_be(:project) { create(:project) }
+
let!(:service_template) do
Integrations::Pushover.create!(
template: true,
diff --git a/spec/services/alert_management/create_alert_issue_service_spec.rb b/spec/services/alert_management/create_alert_issue_service_spec.rb
index 695e90ebd9296d4ea0c57a8bc7b46148fb379902..55f8e47717c06d03cabd72578395684b47d77b82 100644
--- a/spec/services/alert_management/create_alert_issue_service_spec.rb
+++ b/spec/services/alert_management/create_alert_issue_service_spec.rb
@@ -15,6 +15,7 @@
let_it_be(:generic_alert, reload: true) { create(:alert_management_alert, :triggered, project: project, payload: payload) }
let_it_be(:prometheus_alert, reload: true) { create(:alert_management_alert, :triggered, :prometheus, project: project, payload: payload) }
+
let(:alert) { generic_alert }
let(:alert_presenter) { alert.present }
let(:created_issue) { Issue.last! }
diff --git a/spec/services/audit_event_service_spec.rb b/spec/services/audit_event_service_spec.rb
index 997f506c269ebcbd76f214432558967d6eb7ebb3..2654ea1ac223af07058d414f591d8f17ae920f68 100644
--- a/spec/services/audit_event_service_spec.rb
+++ b/spec/services/audit_event_service_spec.rb
@@ -6,6 +6,7 @@
let_it_be(:project) { create(:project) }
let_it_be(:user) { create(:user, :with_sign_ins) }
let_it_be(:project_member) { create(:project_member, user: user) }
+
let(:service) { described_class.new(user, project, { action: :destroy }) }
let(:logger) { instance_double(Gitlab::AuditJsonLogger) }
diff --git a/spec/services/auth/dependency_proxy_authentication_service_spec.rb b/spec/services/auth/dependency_proxy_authentication_service_spec.rb
index 1fd1677c7dae96f7a1f51652fc8b52b8899ec060..35e6d59b456fa84dc5dd1ec2f90783b0d7abd256 100644
--- a/spec/services/auth/dependency_proxy_authentication_service_spec.rb
+++ b/spec/services/auth/dependency_proxy_authentication_service_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe Auth::DependencyProxyAuthenticationService do
let_it_be(:user) { create(:user) }
+
let(:service) { Auth::DependencyProxyAuthenticationService.new(nil, user) }
before do
diff --git a/spec/services/auto_merge_service_spec.rb b/spec/services/auto_merge_service_spec.rb
index 3f7a26aa00e820d55fd7e4eb529fc38ca09e3752..335c608c2068c5d8a3f7f37d7fb14f4ebb9cff41 100644
--- a/spec/services/auto_merge_service_spec.rb
+++ b/spec/services/auto_merge_service_spec.rb
@@ -5,6 +5,7 @@
RSpec.describe AutoMergeService do
let_it_be(:project) { create(:project, :repository) }
let_it_be(:user) { create(:user) }
+
let(:service) { described_class.new(project, user) }
before_all do
diff --git a/spec/services/bulk_create_integration_service_spec.rb b/spec/services/bulk_create_integration_service_spec.rb
index ebfd988f26eed373174fa1548874cf9406e0b350..4b0029e27cba255ee75f8ed32e4607b47691e84a 100644
--- a/spec/services/bulk_create_integration_service_spec.rb
+++ b/spec/services/bulk_create_integration_service_spec.rb
@@ -11,6 +11,7 @@
let_it_be(:excluded_group) { create(:group) }
let_it_be(:excluded_project) { create(:project, group: excluded_group) }
+
let(:instance_integration) { create(:jira_integration, :instance) }
let(:template_integration) { create(:jira_integration, :template) }
let(:excluded_attributes) { %w[id project_id group_id inherit_from_id instance template created_at updated_at] }
diff --git a/spec/services/clusters/applications/prometheus_health_check_service_spec.rb b/spec/services/clusters/applications/prometheus_health_check_service_spec.rb
index ee47d00f70066306a11851ebe3ba790df3f282e1..e6c7b147ab71ec301a0847f9ad89492a9c9c5b65 100644
--- a/spec/services/clusters/applications/prometheus_health_check_service_spec.rb
+++ b/spec/services/clusters/applications/prometheus_health_check_service_spec.rb
@@ -42,6 +42,7 @@
context 'when cluster is project_type' do
let_it_be(:project) { create(:project) }
let_it_be(:integration) { create(:alert_management_http_integration, project: project) }
+
let(:applications_prometheus_healthy) { true }
let(:prometheus) { create(:clusters_applications_prometheus, status: prometheus_status_value, healthy: applications_prometheus_healthy) }
let(:cluster) { create(:cluster, :project, application_prometheus: prometheus, projects: [project]) }
diff --git a/spec/services/container_expiration_policy_service_spec.rb b/spec/services/container_expiration_policy_service_spec.rb
index 4294e6b3f06cd04747f58d839fdb2e9a5ac57fc1..41dd890dd35f1c47758fde604bc7123ba50705c9 100644
--- a/spec/services/container_expiration_policy_service_spec.rb
+++ b/spec/services/container_expiration_policy_service_spec.rb
@@ -5,6 +5,7 @@
RSpec.describe ContainerExpirationPolicyService do
let_it_be(:user) { create(:user) }
let_it_be(:container_expiration_policy) { create(:container_expiration_policy, :runnable) }
+
let(:project) { container_expiration_policy.project }
let(:container_repository) { create(:container_repository, project: project) }
diff --git a/spec/services/dependency_proxy/find_or_create_manifest_service_spec.rb b/spec/services/dependency_proxy/find_or_create_manifest_service_spec.rb
index 40a2f954786ae4b3966a8c9390e5ffa8f66c3ef8..1c8ae860d1026e2b8c962c35d66430851a885a29 100644
--- a/spec/services/dependency_proxy/find_or_create_manifest_service_spec.rb
+++ b/spec/services/dependency_proxy/find_or_create_manifest_service_spec.rb
@@ -7,6 +7,7 @@
let_it_be(:image) { 'alpine' }
let_it_be(:tag) { 'latest' }
let_it_be(:dependency_proxy_manifest) { create(:dependency_proxy_manifest, file_name: "#{image}:#{tag}.json") }
+
let(:manifest) { dependency_proxy_manifest.file.read }
let(:group) { dependency_proxy_manifest.group }
let(:token) { Digest::SHA256.hexdigest('123') }
diff --git a/spec/services/discussions/resolve_service_spec.rb b/spec/services/discussions/resolve_service_spec.rb
index 24de1d90526ccac87e12d245a790527d81210493..9cc27973bcb9a3d291d05486018c0e001c8fb701 100644
--- a/spec/services/discussions/resolve_service_spec.rb
+++ b/spec/services/discussions/resolve_service_spec.rb
@@ -7,6 +7,7 @@
let_it_be(:project) { create(:project, :repository) }
let_it_be(:user) { create(:user, developer_projects: [project]) }
let_it_be(:merge_request) { create(:merge_request, :merge_when_pipeline_succeeds, source_project: project) }
+
let(:discussion) { create(:diff_note_on_merge_request, noteable: merge_request, project: project).to_discussion }
let(:service) { described_class.new(project, user, one_or_more_discussions: discussion) }
@@ -100,6 +101,7 @@
context 'when discussion is not for a merge request' do
let_it_be(:design) { create(:design, :with_file, issue: create(:issue, project: project)) }
+
let(:discussion) { create(:diff_note_on_design, noteable: design, project: project).to_discussion }
it 'does not execute the notification service' do
diff --git a/spec/services/discussions/unresolve_service_spec.rb b/spec/services/discussions/unresolve_service_spec.rb
index 6298a00a4740b34720b896ba13c90162735033c4..0009239232c4f47094ee9844d0d919d169d91782 100644
--- a/spec/services/discussions/unresolve_service_spec.rb
+++ b/spec/services/discussions/unresolve_service_spec.rb
@@ -7,6 +7,7 @@
let_it_be(:project) { create(:project, :repository) }
let_it_be(:user) { create(:user, developer_projects: [project]) }
let_it_be(:merge_request) { create(:merge_request, :merge_when_pipeline_succeeds, source_project: project) }
+
let(:discussion) { create(:diff_note_on_merge_request, noteable: merge_request, project: project).to_discussion }
let(:service) { described_class.new(discussion, user) }
diff --git a/spec/services/git/branch_push_service_spec.rb b/spec/services/git/branch_push_service_spec.rb
index d52e3a0b6fae0e99234429b70f3216bf09602229..53f5dd8b647b368c77147dbca226771784b1c0e1 100644
--- a/spec/services/git/branch_push_service_spec.rb
+++ b/spec/services/git/branch_push_service_spec.rb
@@ -7,6 +7,7 @@
let_it_be(:user) { create(:user) }
let_it_be(:project, reload: true) { create(:project, :repository) }
+
let(:blankrev) { Gitlab::Git::BLANK_SHA }
let(:oldrev) { sample_commit.parent_id }
let(:newrev) { sample_commit.id }
@@ -707,6 +708,7 @@ def execute_service(project, user, change, push_options = {})
context 'Jira Connect hooks' do
let_it_be(:project) { create(:project, :repository) }
+
let(:branch_to_sync) { nil }
let(:commits_to_sync) { [] }
let(:params) do
diff --git a/spec/services/import/bitbucket_server_service_spec.rb b/spec/services/import/bitbucket_server_service_spec.rb
index c548e87b04027f0b1879329f1f510fe972b55377..56d93625b91cf8af2bc239890f4667a5b2c7788e 100644
--- a/spec/services/import/bitbucket_server_service_spec.rb
+++ b/spec/services/import/bitbucket_server_service_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe Import::BitbucketServerService do
let_it_be(:user) { create(:user) }
+
let(:base_uri) { "https://test:7990" }
let(:token) { "asdasd12345" }
let(:secret) { "sekrettt" }
diff --git a/spec/services/incident_management/incidents/create_service_spec.rb b/spec/services/incident_management/incidents/create_service_spec.rb
index 4601bd807d0ac4b04b346ce343474f19e06bbf82..0f32a4b54255dd802de1e5645e1b8ec44e64e275 100644
--- a/spec/services/incident_management/incidents/create_service_spec.rb
+++ b/spec/services/incident_management/incidents/create_service_spec.rb
@@ -5,6 +5,7 @@
RSpec.describe IncidentManagement::Incidents::CreateService do
let_it_be(:project) { create(:project) }
let_it_be(:user) { User.alert_bot }
+
let(:description) { 'Incident description' }
describe '#execute' do
diff --git a/spec/services/incident_management/pager_duty/create_incident_issue_service_spec.rb b/spec/services/incident_management/pager_duty/create_incident_issue_service_spec.rb
index 73ad0532e0778e3e6eee7298aa1a4462abda157f..fb536df5d1751a36b467d9c441bc61b29b60794a 100644
--- a/spec/services/incident_management/pager_duty/create_incident_issue_service_spec.rb
+++ b/spec/services/incident_management/pager_duty/create_incident_issue_service_spec.rb
@@ -5,6 +5,7 @@
RSpec.describe IncidentManagement::PagerDuty::CreateIncidentIssueService do
let_it_be(:project, reload: true) { create(:project) }
let_it_be(:user) { User.alert_bot }
+
let(:webhook_payload) { Gitlab::Json.parse(fixture_file('pager_duty/webhook_incident_trigger.json')) }
let(:parsed_payload) { ::PagerDuty::WebhookPayloadParser.call(webhook_payload) }
let(:incident_payload) { parsed_payload.first['incident'] }
diff --git a/spec/services/incident_management/pager_duty/process_webhook_service_spec.rb b/spec/services/incident_management/pager_duty/process_webhook_service_spec.rb
index 0caffb16f4289edba6245e31307d38912419bea2..8b6eb21c25d78f2b0918f96a019211b0e264dc54 100644
--- a/spec/services/incident_management/pager_duty/process_webhook_service_spec.rb
+++ b/spec/services/incident_management/pager_duty/process_webhook_service_spec.rb
@@ -95,6 +95,7 @@
context 'when both tokens are nil' do
let_it_be(:incident_management_setting) { create(:project_incident_management_setting, project: project, pagerduty_active: false) }
+
let(:token) { nil }
before do
diff --git a/spec/services/integrations/test/project_service_spec.rb b/spec/services/integrations/test/project_service_spec.rb
index 2e09dea11f162b1245e60391ae626d4e515bd7c5..32f9f632d7ab212ea0738368a516944d25b86b33 100644
--- a/spec/services/integrations/test/project_service_spec.rb
+++ b/spec/services/integrations/test/project_service_spec.rb
@@ -132,6 +132,7 @@
context 'deployment' do
let_it_be(:project) { create(:project, :test_repo) }
+
let(:deployment) { build(:deployment) }
let(:event) { 'deployment' }
@@ -169,6 +170,7 @@
context 'wiki_page' do
let_it_be(:project) { create(:project, :wiki_repo) }
+
let(:event) { 'wiki_page' }
it 'returns error message if wiki disabled' do
diff --git a/spec/services/issuable/bulk_update_service_spec.rb b/spec/services/issuable/bulk_update_service_spec.rb
index dfdfb57111cf446b48a379ad6b11e12bf1634648..55e0e799c19cb1426b64384cf02c0b0a868b7b0e 100644
--- a/spec/services/issuable/bulk_update_service_spec.rb
+++ b/spec/services/issuable/bulk_update_service_spec.rb
@@ -314,6 +314,7 @@ def create_issue_with_labels(labels)
context 'with issuables at a group level' do
let_it_be(:group) { create(:group) }
+
let(:parent) { group }
before do
diff --git a/spec/services/jira_connect/sync_service_spec.rb b/spec/services/jira_connect/sync_service_spec.rb
index edd0bad70f50ac446127cfb90da20f3660dd74d3..c20aecaaef093ead219285062cb88688d21c3484 100644
--- a/spec/services/jira_connect/sync_service_spec.rb
+++ b/spec/services/jira_connect/sync_service_spec.rb
@@ -7,6 +7,7 @@
describe '#execute' do
let_it_be(:project) { create(:project, :repository) }
+
let(:client) { Atlassian::JiraConnect::Client }
let(:info) { { a: 'Some', b: 'Info' } }
diff --git a/spec/services/jira_import/start_import_service_spec.rb b/spec/services/jira_import/start_import_service_spec.rb
index 36d639cd72453c33da2305f9fe15b49b995d8085..e04e3314158a87c052eae46db2c0812d9cb6b9b9 100644
--- a/spec/services/jira_import/start_import_service_spec.rb
+++ b/spec/services/jira_import/start_import_service_spec.rb
@@ -7,6 +7,7 @@
let_it_be(:user) { create(:user) }
let_it_be(:project, reload: true) { create(:project) }
+
let(:key) { 'KEY' }
let(:mapping) do
[
diff --git a/spec/services/markdown_content_rewriter_service_spec.rb b/spec/services/markdown_content_rewriter_service_spec.rb
index 47332bec31989a7cf1d87f942a6f588acc00496b..37c8a210ba58c9a0cace38f957889b82eca2b5e8 100644
--- a/spec/services/markdown_content_rewriter_service_spec.rb
+++ b/spec/services/markdown_content_rewriter_service_spec.rb
@@ -6,6 +6,7 @@
let_it_be(:user) { create(:user) }
let_it_be(:source_parent) { create(:project, :public) }
let_it_be(:target_parent) { create(:project, :public) }
+
let(:content) { 'My content' }
describe '#initialize' do
@@ -34,6 +35,7 @@
# to prove they run correctly.
context 'when content contains a reference' do
let_it_be(:issue) { create(:issue, project: source_parent) }
+
let(:content) { "See ##{issue.iid}" }
it 'rewrites content' do
diff --git a/spec/services/members/create_service_spec.rb b/spec/services/members/create_service_spec.rb
index ffe63a8a94b08d70353f648915b5f84f4c361dd4..62bccde19638190f6c3e793ad99695cd815e43d4 100644
--- a/spec/services/members/create_service_spec.rb
+++ b/spec/services/members/create_service_spec.rb
@@ -8,6 +8,7 @@
let_it_be(:member) { create(:user) }
let_it_be(:user_ids) { member.id.to_s }
let_it_be(:access_level) { Gitlab::Access::GUEST }
+
let(:additional_params) { { invite_source: '_invite_source_' } }
let(:params) { { user_ids: user_ids, access_level: access_level }.merge(additional_params) }
diff --git a/spec/services/members/invite_service_spec.rb b/spec/services/members/invite_service_spec.rb
index c530e3d0c5310b3edaab946ea1b14d3b390b495c..dd82facaf14b3c5d118bd4a541a1a8d99d5818ad 100644
--- a/spec/services/members/invite_service_spec.rb
+++ b/spec/services/members/invite_service_spec.rb
@@ -7,6 +7,7 @@
let_it_be(:user) { project.owner }
let_it_be(:project_user) { create(:user) }
let_it_be(:namespace) { project.namespace }
+
let(:params) { {} }
let(:base_params) { { access_level: Gitlab::Access::GUEST, source: project, invite_source: '_invite_source_' } }
diff --git a/spec/services/metrics/dashboard/annotations/create_service_spec.rb b/spec/services/metrics/dashboard/annotations/create_service_spec.rb
index c3fe7238047337821c4f56324bec80e96d9ad456..8f5484fcabe311a694bbc6641f7b552d84a90bbc 100644
--- a/spec/services/metrics/dashboard/annotations/create_service_spec.rb
+++ b/spec/services/metrics/dashboard/annotations/create_service_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe Metrics::Dashboard::Annotations::CreateService do
let_it_be(:user) { create(:user) }
+
let(:description) { 'test annotation' }
let(:dashboard_path) { 'config/prometheus/common_metrics.yml' }
let(:starting_at) { 15.minutes.ago }
diff --git a/spec/services/metrics/dashboard/gitlab_alert_embed_service_spec.rb b/spec/services/metrics/dashboard/gitlab_alert_embed_service_spec.rb
index d5928b1b5afd8a5bff0ea9b0b797db06353c6d37..2905e4599f3970ed3cd3adee9261d14246f4ddde 100644
--- a/spec/services/metrics/dashboard/gitlab_alert_embed_service_spec.rb
+++ b/spec/services/metrics/dashboard/gitlab_alert_embed_service_spec.rb
@@ -8,6 +8,7 @@
let_it_be(:alert) { create(:prometheus_alert) }
let_it_be(:project) { alert.project }
let_it_be(:user) { create(:user) }
+
let(:alert_id) { alert.id }
before_all do
diff --git a/spec/services/metrics/users_starred_dashboards/create_service_spec.rb b/spec/services/metrics/users_starred_dashboards/create_service_spec.rb
index 910b556b8dd75f2acec99374ece089e6e50e545d..1435e39e458a39154b702b81ef6b4c7df1d30de2 100644
--- a/spec/services/metrics/users_starred_dashboards/create_service_spec.rb
+++ b/spec/services/metrics/users_starred_dashboards/create_service_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe Metrics::UsersStarredDashboards::CreateService do
let_it_be(:user) { create(:user) }
+
let(:dashboard_path) { 'config/prometheus/common_metrics.yml' }
let(:service_instance) { described_class.new(user, project, dashboard_path) }
let(:project) { create(:project) }
diff --git a/spec/services/notes/copy_service_spec.rb b/spec/services/notes/copy_service_spec.rb
index d9b6bafd7ffedc205702df5a948523e6f0e2f8ff..dd11fa15ea83534734da40a177d960733563ef08 100644
--- a/spec/services/notes/copy_service_spec.rb
+++ b/spec/services/notes/copy_service_spec.rb
@@ -16,6 +16,7 @@
let_it_be(:group) { create(:group) }
let_it_be(:from_project) { create(:project, :public, group: group) }
let_it_be(:to_project) { create(:project, :public, group: group) }
+
let(:from_noteable) { create(:issue, project: from_project) }
let(:to_noteable) { create(:issue, project: to_project) }
diff --git a/spec/services/notes/create_service_spec.rb b/spec/services/notes/create_service_spec.rb
index 5b4d6188b66da117d5c2a1497a7374f064bc774d..6621ad1f294fdd147ae693993b9b3685d3b0bd00 100644
--- a/spec/services/notes/create_service_spec.rb
+++ b/spec/services/notes/create_service_spec.rb
@@ -6,6 +6,7 @@
let_it_be(:project) { create(:project, :repository) }
let_it_be(:issue) { create(:issue, project: project) }
let_it_be(:user) { create(:user) }
+
let(:opts) do
{ note: 'Awesome comment', noteable_type: 'Issue', noteable_id: issue.id, confidential: true }
end
@@ -295,6 +296,7 @@
context 'for merge requests' do
let_it_be(:merge_request) { create(:merge_request, source_project: project, labels: [bug_label]) }
+
let(:issuable) { merge_request }
let(:note_params) { opts.merge(noteable_type: 'MergeRequest', noteable_id: merge_request.id) }
let(:merge_request_quick_actions) do
diff --git a/spec/services/notes/destroy_service_spec.rb b/spec/services/notes/destroy_service_spec.rb
index eebbdcc33b8906caefef15ecfc71db79eeec7491..55acdabef82351a381bb05fef4bb6f51a79ace46 100644
--- a/spec/services/notes/destroy_service_spec.rb
+++ b/spec/services/notes/destroy_service_spec.rb
@@ -5,6 +5,7 @@
RSpec.describe Notes::DestroyService do
let_it_be(:project) { create(:project, :public) }
let_it_be(:issue) { create(:issue, project: project) }
+
let(:user) { issue.author }
describe '#execute' do
diff --git a/spec/services/notes/quick_actions_service_spec.rb b/spec/services/notes/quick_actions_service_spec.rb
index cb7d0163cac876b6f67d9d1aeef01699084c08d3..0a56f01ebba4b34c41d30a44ccbf98ea1497eb2e 100644
--- a/spec/services/notes/quick_actions_service_spec.rb
+++ b/spec/services/notes/quick_actions_service_spec.rb
@@ -43,6 +43,7 @@
context '/relate' do
let_it_be(:issue) { create(:issue, project: project) }
let_it_be(:other_issue) { create(:issue, project: project) }
+
let(:note_text) { "/relate #{other_issue.to_reference}" }
let(:note) { create(:note_on_issue, noteable: issue, project: project, note: note_text) }
diff --git a/spec/services/notes/update_service_spec.rb b/spec/services/notes/update_service_spec.rb
index 000f3d26efa681ba279b8ca1512372630fce8edf..71ac1641ca518b1fee0170815371c90e869907ed 100644
--- a/spec/services/notes/update_service_spec.rb
+++ b/spec/services/notes/update_service_spec.rb
@@ -273,6 +273,7 @@ def update_note(opts)
context 'for a personal snippet' do
let_it_be(:snippet) { create(:personal_snippet, :public) }
+
let(:note) { create(:note, project: nil, noteable: snippet, author: user, note: "Note on a snippet with reference #{issue.to_reference}" ) }
it 'does not create todos' do
diff --git a/spec/services/notification_service_spec.rb b/spec/services/notification_service_spec.rb
index 63ef007350d0804879cbb39ac69559cccb26913a..6b1291042dd3c0e0d862f14cefb1a0b7fede43a4 100644
--- a/spec/services/notification_service_spec.rb
+++ b/spec/services/notification_service_spec.rb
@@ -361,6 +361,7 @@
let_it_be_with_reload(:issue) { create(:issue, project: project, assignees: [assignee]) }
let_it_be(:mentioned_issue) { create(:issue, assignees: issue.assignees) }
let_it_be_with_reload(:author) { create(:user) }
+
let(:note) { create(:note_on_issue, author: author, noteable: issue, project_id: issue.project_id, note: '@mention referenced, @unsubscribed_mentioned and @outsider also') }
subject { notification.new_note(note) }
@@ -641,6 +642,7 @@
let_it_be(:issue) { create(:issue, project: project, assignees: [assignee]) }
let_it_be(:mentioned_issue) { create(:issue, assignees: issue.assignees) }
let_it_be(:author) { create(:user) }
+
let(:note) { create(:note_on_issue, author: author, noteable: issue, project_id: issue.project_id, note: '@all mentioned') }
before_all do
diff --git a/spec/services/packages/composer/create_package_service_spec.rb b/spec/services/packages/composer/create_package_service_spec.rb
index 526c7b4929b0a70fb4b7748d71f3f512bcc71666..553d58fdd86726159c0c41d715b3d5919358207b 100644
--- a/spec/services/packages/composer/create_package_service_spec.rb
+++ b/spec/services/packages/composer/create_package_service_spec.rb
@@ -8,6 +8,7 @@
let_it_be(:json) { { name: package_name }.to_json }
let_it_be(:project) { create(:project, :custom_repo, files: { 'composer.json' => json } ) }
let_it_be(:user) { create(:user) }
+
let(:params) do
{
branch: branch,
diff --git a/spec/services/packages/conan/search_service_spec.rb b/spec/services/packages/conan/search_service_spec.rb
index 39d284ee0886c42fafce8139c8710562c7bf54b8..55dcdfe646de7a4d472e5541ba9eb9e3d798d2ee 100644
--- a/spec/services/packages/conan/search_service_spec.rb
+++ b/spec/services/packages/conan/search_service_spec.rb
@@ -5,6 +5,7 @@
RSpec.describe Packages::Conan::SearchService do
let_it_be(:user) { create(:user) }
let_it_be(:project) { create(:project, :public) }
+
let!(:conan_package) { create(:conan_package, project: project) }
let!(:conan_package2) { create(:conan_package, project: project) }
diff --git a/spec/services/packages/create_package_file_service_spec.rb b/spec/services/packages/create_package_file_service_spec.rb
index e4b4b15ebf999107ad84c1e0d653908cafc050b2..2ff00ea856870e1c38ab5dfb3e67952ad4112d62 100644
--- a/spec/services/packages/create_package_file_service_spec.rb
+++ b/spec/services/packages/create_package_file_service_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe Packages::CreatePackageFileService do
let_it_be(:package) { create(:maven_package) }
let_it_be(:user) { create(:user) }
+
let(:service) { described_class.new(package, params) }
describe '#execute' do
diff --git a/spec/services/packages/debian/find_or_create_package_service_spec.rb b/spec/services/packages/debian/find_or_create_package_service_spec.rb
index 3582b1f1dc3e25b4c889e1feefcde60bd2db6a82..f06f86b014664045a48502a90fc28a20fe60d56a 100644
--- a/spec/services/packages/debian/find_or_create_package_service_spec.rb
+++ b/spec/services/packages/debian/find_or_create_package_service_spec.rb
@@ -6,6 +6,7 @@
let_it_be(:distribution) { create(:debian_project_distribution) }
let_it_be(:project) { distribution.project }
let_it_be(:user) { create(:user) }
+
let(:params) { { name: 'foo', version: '1.0+debian', distribution_name: distribution.codename } }
subject(:service) { described_class.new(project, user, params) }
diff --git a/spec/services/packages/maven/find_or_create_package_service_spec.rb b/spec/services/packages/maven/find_or_create_package_service_spec.rb
index 803371af4bf1a26915a12b93f78b064e55970f75..d8b48af0121396b23a13cc49744e4aae3080346a 100644
--- a/spec/services/packages/maven/find_or_create_package_service_spec.rb
+++ b/spec/services/packages/maven/find_or_create_package_service_spec.rb
@@ -91,6 +91,7 @@
context 'with a build' do
let_it_be(:pipeline) { create(:ci_pipeline, user: user) }
+
let(:build) { double('build', pipeline: pipeline) }
let(:params) { { path: param_path, file_name: file_name, build: build } }
@@ -103,6 +104,7 @@
let_it_be_with_refind(:package_settings) { create(:namespace_package_setting, :group, maven_duplicates_allowed: false) }
let_it_be_with_refind(:group) { package_settings.namespace }
let_it_be_with_refind(:project) { create(:project, group: group) }
+
let!(:existing_package) { create(:maven_package, name: path, version: version, project: project) }
it { expect { subject }.not_to change { project.package_files.count } }
diff --git a/spec/services/packages/nuget/search_service_spec.rb b/spec/services/packages/nuget/search_service_spec.rb
index 1838065c5be300ef714a5a1b134f31acefdb3082..66c91487a8f4c1773ce22bee648ccd1acd821e46 100644
--- a/spec/services/packages/nuget/search_service_spec.rb
+++ b/spec/services/packages/nuget/search_service_spec.rb
@@ -13,6 +13,7 @@
let_it_be(:package_d) { create(:nuget_package, project: project, name: 'FooBarD') }
let_it_be(:other_package_a) { create(:nuget_package, name: 'DummyPackageA') }
let_it_be(:other_package_a) { create(:nuget_package, name: 'DummyPackageB') }
+
let(:search_term) { 'ummy' }
let(:per_page) { 5 }
let(:padding) { 0 }
diff --git a/spec/services/packages/rubygems/dependency_resolver_service_spec.rb b/spec/services/packages/rubygems/dependency_resolver_service_spec.rb
index 78abfc96ed54b6273eae4f60733a7cc8acd7a57f..f23ed0e5fbc48e6485f1fdd2da5fa1bface7ca6e 100644
--- a/spec/services/packages/rubygems/dependency_resolver_service_spec.rb
+++ b/spec/services/packages/rubygems/dependency_resolver_service_spec.rb
@@ -5,6 +5,7 @@
let_it_be(:project) { create(:project, :private) }
let_it_be(:package) { create(:package, project: project) }
let_it_be(:user) { create(:user) }
+
let(:gem_name) { package.name }
let(:service) { described_class.new(project, user, gem_name: gem_name) }
diff --git a/spec/services/pod_logs/base_service_spec.rb b/spec/services/pod_logs/base_service_spec.rb
index 6f7731fda3af184f4dcd7cccc568cbc2ec918189..d2f6300ab659ed1ffd8a67ebef2b8e5471ed0cf6 100644
--- a/spec/services/pod_logs/base_service_spec.rb
+++ b/spec/services/pod_logs/base_service_spec.rb
@@ -6,6 +6,7 @@
include KubernetesHelpers
let_it_be(:cluster) { create(:cluster, :provided_by_gcp, environment_scope: '*') }
+
let(:namespace) { 'autodevops-deploy-9-production' }
let(:pod_name) { 'pod-1' }
diff --git a/spec/services/pod_logs/elasticsearch_service_spec.rb b/spec/services/pod_logs/elasticsearch_service_spec.rb
index 598b162aee43cd7f85616a91d806b72c945be1fb..1111d9b9307e05132c551f73d6c916bd4b73228f 100644
--- a/spec/services/pod_logs/elasticsearch_service_spec.rb
+++ b/spec/services/pod_logs/elasticsearch_service_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe ::PodLogs::ElasticsearchService do
let_it_be(:cluster) { create(:cluster, :provided_by_gcp, environment_scope: '*') }
+
let(:namespace) { 'autodevops-deploy-9-production' }
let(:pod_name) { 'pod-1' }
diff --git a/spec/services/pod_logs/kubernetes_service_spec.rb b/spec/services/pod_logs/kubernetes_service_spec.rb
index 3e31ff15c1bf97ecc8888566f863a29a74f66248..c06a87830ca8f3bdaca36e43f31ddefe0e6fb1c9 100644
--- a/spec/services/pod_logs/kubernetes_service_spec.rb
+++ b/spec/services/pod_logs/kubernetes_service_spec.rb
@@ -6,6 +6,7 @@
include KubernetesHelpers
let_it_be(:cluster) { create(:cluster, :provided_by_gcp, environment_scope: '*') }
+
let(:namespace) { 'autodevops-deploy-9-production' }
let(:pod_name) { 'pod-1' }
diff --git a/spec/services/projects/create_service_spec.rb b/spec/services/projects/create_service_spec.rb
index 5dc0c46a98f5a7252eacbf6a8bd995ea663be8bb..e99ac8bb3d99a6f55b518251aa743efdce690b27 100644
--- a/spec/services/projects/create_service_spec.rb
+++ b/spec/services/projects/create_service_spec.rb
@@ -190,6 +190,7 @@
let_it_be(:group) { create(:group) }
let_it_be(:shared_group) { create(:group) }
let_it_be(:shared_group_user) { create(:user) }
+
let(:opts) do
{
name: 'GitLab',
@@ -221,6 +222,7 @@
let_it_be(:subgroup_for_projects) { create(:group, :private, parent: group) }
let_it_be(:subgroup_for_access) { create(:group, :private, parent: group) }
let_it_be(:group_maintainer) { create(:user) }
+
let(:group_access_level) { Gitlab::Access::REPORTER }
let(:subgroup_access_level) { Gitlab::Access::DEVELOPER }
let(:share_max_access_level) { Gitlab::Access::MAINTAINER }
diff --git a/spec/services/projects/destroy_rollback_service_spec.rb b/spec/services/projects/destroy_rollback_service_spec.rb
index f63939337b894777f51f665077b096a011c44ff5..3eaacc8c1e70f15c05512282d541fa005f72a4d3 100644
--- a/spec/services/projects/destroy_rollback_service_spec.rb
+++ b/spec/services/projects/destroy_rollback_service_spec.rb
@@ -5,6 +5,7 @@
RSpec.describe Projects::DestroyRollbackService do
let_it_be(:user) { create(:user) }
let_it_be(:project) { create(:project, :repository, namespace: user.namespace) }
+
let(:repository) { project.repository }
let(:repository_storage) { project.repository_storage }
diff --git a/spec/services/projects/destroy_service_spec.rb b/spec/services/projects/destroy_service_spec.rb
index c6b2b1e2b21730e596813da3c4da89270b9e0af6..4a76347ea456fc89235e29cbe213463ba5ab518e 100644
--- a/spec/services/projects/destroy_service_spec.rb
+++ b/spec/services/projects/destroy_service_spec.rb
@@ -6,6 +6,7 @@
include ProjectForksHelper
let_it_be(:user) { create(:user) }
+
let!(:project) { create(:project, :repository, namespace: user.namespace) }
let(:path) { project.repository.disk_path }
let(:remove_path) { removal_path(path) }
diff --git a/spec/services/projects/gitlab_projects_import_service_spec.rb b/spec/services/projects/gitlab_projects_import_service_spec.rb
index 09d093a991683ae8bc6e0dd21b8f504b0b5cc018..d32e720a49ff06b289fb8fb9c521f45da4976a1e 100644
--- a/spec/services/projects/gitlab_projects_import_service_spec.rb
+++ b/spec/services/projects/gitlab_projects_import_service_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe Projects::GitlabProjectsImportService do
let_it_be(:namespace) { create(:namespace) }
+
let(:path) { 'test-path' }
let(:file) { fixture_file_upload('spec/fixtures/project_export.tar.gz') }
let(:overwrite) { false }
diff --git a/spec/services/projects/group_links/create_service_spec.rb b/spec/services/projects/group_links/create_service_spec.rb
index 9bc780fe17726f8af98d44f91234dc965ef9172f..65b0037d667e45f76d72c02f164cef8fb284881f 100644
--- a/spec/services/projects/group_links/create_service_spec.rb
+++ b/spec/services/projects/group_links/create_service_spec.rb
@@ -6,6 +6,7 @@
let_it_be(:user) { create :user }
let_it_be(:group) { create :group }
let_it_be(:project) { create :project }
+
let(:group_access) { Gitlab::Access::DEVELOPER }
let(:opts) do
{
diff --git a/spec/services/projects/group_links/destroy_service_spec.rb b/spec/services/projects/group_links/destroy_service_spec.rb
index d60e9a01e54c181ffc68b8322830e275c65de317..d65afb68bfe4a7608abafdd404d9f6f18881cc0e 100644
--- a/spec/services/projects/group_links/destroy_service_spec.rb
+++ b/spec/services/projects/group_links/destroy_service_spec.rb
@@ -6,6 +6,7 @@
let_it_be(:user) { create :user }
let_it_be(:project) { create(:project, :private) }
let_it_be(:group) { create(:group) }
+
let!(:group_link) { create(:project_group_link, project: project, group: group) }
subject { described_class.new(project, user) }
diff --git a/spec/services/projects/group_links/update_service_spec.rb b/spec/services/projects/group_links/update_service_spec.rb
index 467aef3bc7ed23992ce303af070f4a2319da2bfe..4a38fb0c7d93c136abec71b4bf2ada746503b754 100644
--- a/spec/services/projects/group_links/update_service_spec.rb
+++ b/spec/services/projects/group_links/update_service_spec.rb
@@ -6,6 +6,7 @@
let_it_be(:user) { create :user }
let_it_be(:group) { create :group }
let_it_be(:project) { create :project }
+
let!(:link) { create(:project_group_link, project: project, group: group) }
let(:expiry_date) { 1.month.from_now.to_date }
diff --git a/spec/services/projects/transfer_service_spec.rb b/spec/services/projects/transfer_service_spec.rb
index 8d4a70dbe89b5a1e431ae0229f5ddbd02e9b2d4c..b71677a5e8f084ff5f71e42d92b91ee69259a783 100644
--- a/spec/services/projects/transfer_service_spec.rb
+++ b/spec/services/projects/transfer_service_spec.rb
@@ -8,6 +8,7 @@
let_it_be(:user) { create(:user) }
let_it_be(:group) { create(:group) }
let_it_be(:group_integration) { create(:integrations_slack, group: group, project: nil, webhook: 'http://group.slack.com') }
+
let(:project) { create(:project, :repository, :legacy_storage, namespace: user.namespace) }
subject(:execute_transfer) { described_class.new(project, user).execute(group).tap { project.reload } }
diff --git a/spec/services/projects/update_pages_service_spec.rb b/spec/services/projects/update_pages_service_spec.rb
index b11607bc213aaa8176acc7069e6d6726b358dd26..5898504b463b2fb6cad7a171ecad38a8ea88e5a8 100644
--- a/spec/services/projects/update_pages_service_spec.rb
+++ b/spec/services/projects/update_pages_service_spec.rb
@@ -5,6 +5,7 @@
RSpec.describe Projects::UpdatePagesService do
let_it_be(:project, refind: true) { create(:project, :repository) }
let_it_be(:pipeline) { create(:ci_pipeline, project: project, sha: project.commit('HEAD').sha) }
+
let(:build) { create(:ci_build, pipeline: pipeline, ref: 'HEAD') }
let(:invalid_file) { fixture_file_upload('spec/fixtures/dk.png') }
diff --git a/spec/services/prometheus/create_default_alerts_service_spec.rb b/spec/services/prometheus/create_default_alerts_service_spec.rb
index e149161d881029ae5cbbbfeba2ba536e616801f3..0880799b5893b9acfaffe17ae4745cf673451727 100644
--- a/spec/services/prometheus/create_default_alerts_service_spec.rb
+++ b/spec/services/prometheus/create_default_alerts_service_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe Prometheus::CreateDefaultAlertsService do
let_it_be(:project) { create(:project, :repository) }
+
let(:instance) { described_class.new(project: project) }
let(:expected_alerts) { described_class::DEFAULT_ALERTS }
diff --git a/spec/services/quick_actions/interpret_service_spec.rb b/spec/services/quick_actions/interpret_service_spec.rb
index 4af76bc65ab8d29b8e6b4455c47f0d88ee8f64dc..d7f5c39e4579a042aa86f14154a90d96d6a11fa8 100644
--- a/spec/services/quick_actions/interpret_service_spec.rb
+++ b/spec/services/quick_actions/interpret_service_spec.rb
@@ -15,6 +15,7 @@
let_it_be(:inprogress) { create(:label, project: project, title: 'In Progress') }
let_it_be(:helmchart) { create(:label, project: project, title: 'Helm Chart Registry') }
let_it_be(:bug) { create(:label, project: project, title: 'Bug') }
+
let(:service) { described_class.new(project, developer) }
before_all do
diff --git a/spec/services/releases/create_evidence_service_spec.rb b/spec/services/releases/create_evidence_service_spec.rb
index 818d20f0468dc374900ec253ff13064acc46f253..0ac15a7291d13cccc59dd57700d5e6cc1f456f46 100644
--- a/spec/services/releases/create_evidence_service_spec.rb
+++ b/spec/services/releases/create_evidence_service_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe Releases::CreateEvidenceService do
let_it_be(:project) { create(:project) }
+
let(:release) { create(:release, project: project) }
let(:service) { described_class.new(release) }
diff --git a/spec/services/repositories/destroy_rollback_service_spec.rb b/spec/services/repositories/destroy_rollback_service_spec.rb
index 9cc41a4c7f8f636189efd85adad3da28ba5c7667..717e52f0e4038b63e59541700d9897b1d5984135 100644
--- a/spec/services/repositories/destroy_rollback_service_spec.rb
+++ b/spec/services/repositories/destroy_rollback_service_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe Repositories::DestroyRollbackService do
let_it_be(:user) { create(:user) }
+
let!(:project) { create(:project, :repository, namespace: user.namespace) }
let(:repository) { project.repository }
let(:path) { repository.disk_path }
diff --git a/spec/services/repositories/destroy_service_spec.rb b/spec/services/repositories/destroy_service_spec.rb
index 81bda2130a6edcc329005a361709fa951ab08890..240f837e97306a8f1ae6fd17ac0aa2587302f642 100644
--- a/spec/services/repositories/destroy_service_spec.rb
+++ b/spec/services/repositories/destroy_service_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe Repositories::DestroyService do
let_it_be(:user) { create(:user) }
+
let!(:project) { create(:project, :repository, namespace: user.namespace) }
let(:repository) { project.repository }
let(:path) { repository.disk_path }
diff --git a/spec/services/repositories/shell_destroy_service_spec.rb b/spec/services/repositories/shell_destroy_service_spec.rb
index 9020ef7b20991b46a53328d33a26ba6be7cd7d48..65168a1784a6a2dddde37c479360699cfc8ac29c 100644
--- a/spec/services/repositories/shell_destroy_service_spec.rb
+++ b/spec/services/repositories/shell_destroy_service_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe Repositories::ShellDestroyService do
let_it_be(:user) { create(:user) }
+
let!(:project) { create(:project, :repository, namespace: user.namespace) }
let(:path) { project.repository.disk_path }
let(:remove_path) { "#{path}+#{project.id}#{described_class::DELETED_FLAG}" }
diff --git a/spec/services/resource_access_tokens/create_service_spec.rb b/spec/services/resource_access_tokens/create_service_spec.rb
index 517ed086713dc7b586b493d87e90c2512884551c..bd7c44c6e0399e459ebf4bc91a95ee8b865c8d43 100644
--- a/spec/services/resource_access_tokens/create_service_spec.rb
+++ b/spec/services/resource_access_tokens/create_service_spec.rb
@@ -176,6 +176,7 @@
context "when access provisioning fails" do
let_it_be(:bot_user) { create(:user, :project_bot) }
+
let(:unpersisted_member) { build(:project_member, source: resource, user: bot_user) }
before do
diff --git a/spec/services/resource_access_tokens/revoke_service_spec.rb b/spec/services/resource_access_tokens/revoke_service_spec.rb
index 99adb4bb7a0d63ce96c0f2ef157640df3569f357..4f4e2ab0c9935e325451850970b4e14887e73276 100644
--- a/spec/services/resource_access_tokens/revoke_service_spec.rb
+++ b/spec/services/resource_access_tokens/revoke_service_spec.rb
@@ -6,6 +6,7 @@
subject { described_class.new(user, resource, access_token).execute }
let_it_be(:user) { create(:user) }
+
let(:access_token) { create(:personal_access_token, user: resource_bot) }
describe '#execute', :sidekiq_inline do
@@ -80,6 +81,7 @@
context 'when resource is a project' do
let_it_be(:resource) { create(:project, :private) }
+
let(:resource_bot) { create(:user, :project_bot) }
before do
diff --git a/spec/services/resource_events/change_labels_service_spec.rb b/spec/services/resource_events/change_labels_service_spec.rb
index 8eac6ae0b498c4c66725d9c2b3aa0a64ec8bc429..012168ef719594413fd20016c5dece7641efb92b 100644
--- a/spec/services/resource_events/change_labels_service_spec.rb
+++ b/spec/services/resource_events/change_labels_service_spec.rb
@@ -5,6 +5,7 @@
RSpec.describe ResourceEvents::ChangeLabelsService do
let_it_be(:project) { create(:project) }
let_it_be(:author) { create(:user) }
+
let(:resource) { create(:issue, project: project) }
describe '.change_labels' do
diff --git a/spec/services/resource_events/merge_into_notes_service_spec.rb b/spec/services/resource_events/merge_into_notes_service_spec.rb
index 6209294f4ce91e6be5a07a0ce22b73b45583b849..abe00e72f2044b0593a97349ad866bd73a29c618 100644
--- a/spec/services/resource_events/merge_into_notes_service_spec.rb
+++ b/spec/services/resource_events/merge_into_notes_service_spec.rb
@@ -21,6 +21,7 @@ def create_note(params)
let_it_be(:resource) { create(:issue, project: project) }
let_it_be(:label) { create(:label, project: project) }
let_it_be(:label2) { create(:label, project: project) }
+
let(:time) { Time.current }
describe '#execute' do
diff --git a/spec/services/snippets/bulk_destroy_service_spec.rb b/spec/services/snippets/bulk_destroy_service_spec.rb
index 8a6250a8b4596813e4edcee81e21347a67a1e097..2f399d1018893a2cd32429a966631210bc12d49c 100644
--- a/spec/services/snippets/bulk_destroy_service_spec.rb
+++ b/spec/services/snippets/bulk_destroy_service_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe Snippets::BulkDestroyService do
let_it_be(:project) { create(:project) }
+
let(:user) { create(:user) }
let!(:personal_snippet) { create(:personal_snippet, :repository, author: user) }
let!(:project_snippet) { create(:project_snippet, :repository, project: project, author: user) }
diff --git a/spec/services/snippets/create_service_spec.rb b/spec/services/snippets/create_service_spec.rb
index 0b73808433ff7171529e92871dbd2bd43d219c31..0eb73c8edd26e926c826a399220cce856c75c9d1 100644
--- a/spec/services/snippets/create_service_spec.rb
+++ b/spec/services/snippets/create_service_spec.rb
@@ -6,6 +6,7 @@
describe '#execute' do
let_it_be(:user) { create(:user) }
let_it_be(:admin) { create(:user, :admin) }
+
let(:action) { :create }
let(:opts) { base_opts.merge(extra_opts) }
let(:base_opts) do
diff --git a/spec/services/snippets/update_service_spec.rb b/spec/services/snippets/update_service_spec.rb
index 7fac500f224e49332f724e6e16674e571d091600..f61d33e2436e76f12ec6a847396755dc93ccc902 100644
--- a/spec/services/snippets/update_service_spec.rb
+++ b/spec/services/snippets/update_service_spec.rb
@@ -6,6 +6,7 @@
describe '#execute', :aggregate_failures do
let_it_be(:user) { create(:user) }
let_it_be(:admin) { create :user, admin: true }
+
let(:action) { :update }
let(:visibility_level) { Gitlab::VisibilityLevel::PRIVATE }
let(:base_opts) do
@@ -729,6 +730,7 @@ def blob(path)
context 'when Project Snippet' do
let_it_be(:project) { create(:project) }
+
let!(:snippet) { create(:project_snippet, :repository, author: user, project: project) }
before do
diff --git a/spec/services/spam/ham_service_spec.rb b/spec/services/spam/ham_service_spec.rb
index c947de6cf9210c8bd2b944054d74f58af8a1b121..0101a8e77047aa67ee61935b56aadda70a6a82c0 100644
--- a/spec/services/spam/ham_service_spec.rb
+++ b/spec/services/spam/ham_service_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe Spam::HamService do
let_it_be(:user) { create(:user) }
+
let!(:spam_log) { create(:spam_log, user: user, submitted_as_ham: false) }
let(:fake_akismet_service) { double(:akismet_service) }
diff --git a/spec/services/spam/spam_verdict_service_spec.rb b/spec/services/spam/spam_verdict_service_spec.rb
index 9ff2e0ddf55898b7af9b0567c00425272a3a57b4..659c21b7d4f05758553809c2c1c80a51aae16c53 100644
--- a/spec/services/spam/spam_verdict_service_spec.rb
+++ b/spec/services/spam/spam_verdict_service_spec.rb
@@ -17,6 +17,7 @@
let(:check_for_spam) { true }
let_it_be(:user) { create(:user) }
let_it_be(:issue) { create(:issue, author: user) }
+
let(:service) do
described_class.new(user: user, target: issue, options: {})
end
diff --git a/spec/services/system_note_service_spec.rb b/spec/services/system_note_service_spec.rb
index 395fada574e939d0600ed84f109f3b0f87935b64..e9bd40b058b17c6d01f2993461b99ed3bcb3d39b 100644
--- a/spec/services/system_note_service_spec.rb
+++ b/spec/services/system_note_service_spec.rb
@@ -11,6 +11,7 @@
let_it_be(:group) { create(:group) }
let_it_be(:project) { create(:project, :repository, group: group) }
let_it_be(:author) { create(:user) }
+
let(:noteable) { create(:issue, project: project) }
let(:issue) { noteable }
diff --git a/spec/services/system_notes/issuables_service_spec.rb b/spec/services/system_notes/issuables_service_spec.rb
index d2d9eba2bc647808b83dd7379f4fa6393b65a6b1..1ea3c241d27be18167805743d728831e1b48bab6 100644
--- a/spec/services/system_notes/issuables_service_spec.rb
+++ b/spec/services/system_notes/issuables_service_spec.rb
@@ -8,6 +8,7 @@
let_it_be(:group) { create(:group) }
let_it_be(:project) { create(:project, :repository, group: group) }
let_it_be(:author) { create(:user) }
+
let(:noteable) { create(:issue, project: project) }
let(:issue) { noteable }
diff --git a/spec/services/test_hooks/project_service_spec.rb b/spec/services/test_hooks/project_service_spec.rb
index a87e612e3781317e812d70a391e4512f4ce3d2ed..cd6284b4a87d38da84d48da4bbca93e32dc67e45 100644
--- a/spec/services/test_hooks/project_service_spec.rb
+++ b/spec/services/test_hooks/project_service_spec.rb
@@ -9,6 +9,7 @@
describe '#execute' do
let_it_be(:project) { create(:project, :repository) }
+
let(:hook) { create(:project_hook, project: project) }
let(:trigger) { 'not_implemented_events' }
let(:service) { described_class.new(hook, current_user, trigger) }
@@ -163,6 +164,7 @@
context 'wiki_page_events' do
let_it_be(:project) { create(:project, :wiki_repo) }
+
let(:trigger) { 'wiki_page_events' }
let(:trigger_key) { :wiki_page_hooks }
diff --git a/spec/services/test_hooks/system_service_spec.rb b/spec/services/test_hooks/system_service_spec.rb
index e500a1057ab4223394ec10ef0334c37844f43bb5..a13ae471b4b402f28e3104a6d2a584ebe283ba2b 100644
--- a/spec/services/test_hooks/system_service_spec.rb
+++ b/spec/services/test_hooks/system_service_spec.rb
@@ -7,6 +7,7 @@
describe '#execute' do
let_it_be(:project) { create(:project, :repository) }
+
let(:hook) { create(:system_hook) }
let(:service) { described_class.new(hook, project.owner, trigger) }
let(:success_result) { { status: :success, http_status: 200, message: 'ok' } }
diff --git a/spec/services/users/approve_service_spec.rb b/spec/services/users/approve_service_spec.rb
index 9999e674c7d97114d0de449e367c32f2af19afbd..078dde546c9669a30683d4a8e4b494010dc7cdd9 100644
--- a/spec/services/users/approve_service_spec.rb
+++ b/spec/services/users/approve_service_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe Users::ApproveService do
let_it_be(:current_user) { create(:admin) }
+
let(:user) { create(:user, :blocked_pending_approval) }
subject(:execute) { described_class.new(current_user).execute(user) }
diff --git a/spec/services/users/reject_service_spec.rb b/spec/services/users/reject_service_spec.rb
index b9aaff5cde5dd5e0b1abb7ce0b680ef5ca51a472..b0094a7c47e2ca951bac99dbeb588bd85489bb6f 100644
--- a/spec/services/users/reject_service_spec.rb
+++ b/spec/services/users/reject_service_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe Users::RejectService do
let_it_be(:current_user) { create(:admin) }
+
let(:user) { create(:user, :blocked_pending_approval) }
subject(:execute) { described_class.new(current_user).execute(user) }
diff --git a/spec/services/users/validate_otp_service_spec.rb b/spec/services/users/validate_otp_service_spec.rb
index 42f0c10488c720ed5520fdfbedcceb5277975de1..46b80b2149f390900ea99771a4c9d51a2832479d 100644
--- a/spec/services/users/validate_otp_service_spec.rb
+++ b/spec/services/users/validate_otp_service_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe Users::ValidateOtpService do
let_it_be(:user) { create(:user) }
+
let(:otp_code) { 42 }
subject(:validate) { described_class.new(user).execute(otp_code) }
diff --git a/spec/services/wiki_pages/event_create_service_spec.rb b/spec/services/wiki_pages/event_create_service_spec.rb
index 974f2591763fb70881b4fabaeb98a51cb93d2144..6bc6a678189fce29ba3b830d09523c35721a7f94 100644
--- a/spec/services/wiki_pages/event_create_service_spec.rb
+++ b/spec/services/wiki_pages/event_create_service_spec.rb
@@ -10,6 +10,7 @@
describe '#execute' do
let_it_be(:page) { create(:wiki_page, project: project) }
+
let(:slug) { generate(:sluggified_title) }
let(:action) { :created }
let(:fingerprint) { page.sha }
diff --git a/spec/support/shared_examples/graphql/design_fields_shared_examples.rb b/spec/support/shared_examples/graphql/design_fields_shared_examples.rb
index 9c2eb3e5a5ce2913f50588281e421e26fe999e5e..efbcfaf0e91bf9be8a37bbd4d0a2da214b77e6f4 100644
--- a/spec/support/shared_examples/graphql/design_fields_shared_examples.rb
+++ b/spec/support/shared_examples/graphql/design_fields_shared_examples.rb
@@ -27,6 +27,7 @@
describe '#image' do
let_it_be(:current_user) { create(:user) }
+
let(:schema) { GitlabSchema }
let(:query) { GraphQL::Query.new(schema) }
let(:context) { query.context }
diff --git a/spec/support/shared_examples/quick_actions/issuable/issuable_quick_actions_shared_examples.rb b/spec/support/shared_examples/quick_actions/issuable/issuable_quick_actions_shared_examples.rb
index 3cdba315d1f90b2c00e88ffd4123ececb0b32c73..4d142199c951eb2ba257dd1cc8fc3d0ab6d845e1 100644
--- a/spec/support/shared_examples/quick_actions/issuable/issuable_quick_actions_shared_examples.rb
+++ b/spec/support/shared_examples/quick_actions/issuable/issuable_quick_actions_shared_examples.rb
@@ -233,6 +233,7 @@ def skip_access_check
context 'when user can update issuable' do
let_it_be(:developer) { create(:user) }
+
let(:note_author) { developer }
before do
@@ -260,6 +261,7 @@ def skip_access_check
context 'when user cannot update issuable' do
let_it_be(:non_member) { create(:user) }
+
let(:note_author) { non_member }
it 'applies commands that user can execute' do
diff --git a/spec/support/shared_examples/services/container_registry_auth_service_shared_examples.rb b/spec/support/shared_examples/services/container_registry_auth_service_shared_examples.rb
index ba176b616c370fc08784948b30a4c7f4f556606e..d8794ef269340065e5389b20e4572595a4671764 100644
--- a/spec/support/shared_examples/services/container_registry_auth_service_shared_examples.rb
+++ b/spec/support/shared_examples/services/container_registry_auth_service_shared_examples.rb
@@ -159,6 +159,7 @@
describe '#full_access_token' do
let_it_be(:project) { create(:project) }
+
let(:token) { described_class.full_access_token(project.full_path) }
subject { { token: token } }
@@ -172,6 +173,7 @@
describe '#pull_access_token' do
let_it_be(:project) { create(:project) }
+
let(:token) { described_class.pull_access_token(project.full_path) }
subject { { token: token } }
@@ -432,6 +434,7 @@
context 'for external user' do
context 'disallow anyone to pull or push images' do
let_it_be(:current_user) { create(:user, external: true) }
+
let(:current_params) do
{ scopes: ["repository:#{project.full_path}:pull,push"] }
end
@@ -442,6 +445,7 @@
context 'disallow anyone to delete images' do
let_it_be(:current_user) { create(:user, external: true) }
+
let(:current_params) do
{ scopes: ["repository:#{project.full_path}:*"] }
end
@@ -452,6 +456,7 @@
context 'disallow anyone to delete images since registry 2.7' do
let_it_be(:current_user) { create(:user, external: true) }
+
let(:current_params) do
{ scopes: ["repository:#{project.full_path}:delete"] }
end
diff --git a/spec/support/shared_examples/services/packages_shared_examples.rb b/spec/support/shared_examples/services/packages_shared_examples.rb
index 72878e925dcca95b11bb457364ef35995bc038f7..6bc4f171d9c97a97a2f4641723d553cf8aea644e 100644
--- a/spec/support/shared_examples/services/packages_shared_examples.rb
+++ b/spec/support/shared_examples/services/packages_shared_examples.rb
@@ -43,6 +43,7 @@
RSpec.shared_examples 'assigns status to package' do
context 'with status param' do
let_it_be(:status) { 'hidden' }
+
let(:params) { super().merge(status: status) }
it 'assigns the status to the package' do
diff --git a/spec/tasks/gitlab/db_rake_spec.rb b/spec/tasks/gitlab/db_rake_spec.rb
index 08ca6c32b493fead02241cdb1139ca53a460f8f2..3de96a776f30c9fd5d5f535fa35d1f3ae78cf814 100644
--- a/spec/tasks/gitlab/db_rake_spec.rb
+++ b/spec/tasks/gitlab/db_rake_spec.rb
@@ -126,6 +126,7 @@
let_it_be(:test_task_name) { 'gitlab:db:_test_multiple_structure_cleans' }
let_it_be(:structure_file) { 'db/structure.sql' }
let_it_be(:input) { 'this is structure data' }
+
let(:output) { StringIO.new }
before do
diff --git a/spec/tasks/gitlab/packages/composer_rake_spec.rb b/spec/tasks/gitlab/packages/composer_rake_spec.rb
index 78013714de506c56a9789447a2674d6dc74da96c..f4f43bf77d84bb8791441719184a3fdd3e75d454 100644
--- a/spec/tasks/gitlab/packages/composer_rake_spec.rb
+++ b/spec/tasks/gitlab/packages/composer_rake_spec.rb
@@ -10,6 +10,7 @@
let_it_be(:group) { create(:group) }
let_it_be(:project) { create(:project, :custom_repo, files: { 'composer.json' => json.to_json }, group: group) }
let_it_be(:project2) { create(:project, :custom_repo, files: { 'composer.json' => json2.to_json }, group: group) }
+
let!(:package) { create(:composer_package, :with_metadatum, project: project, name: package_name, version: '1.0.0', json: json) }
let!(:package2) { create(:composer_package, :with_metadatum, project: project, name: package_name, version: '2.0.0', json: json) }
let!(:package3) { create(:composer_package, :with_metadatum, project: project2, name: package_name2, version: '3.0.0', json: json2) }
diff --git a/spec/tasks/gitlab/snippets_rake_spec.rb b/spec/tasks/gitlab/snippets_rake_spec.rb
index d40b784b3a01368bc2e30e72dcff62b092559c09..c55bded1d5a87e9ea91ead24e7f1b2f0ca7563b9 100644
--- a/spec/tasks/gitlab/snippets_rake_spec.rb
+++ b/spec/tasks/gitlab/snippets_rake_spec.rb
@@ -5,6 +5,7 @@
RSpec.describe 'gitlab:snippets namespace rake task', :silence_stdout do
let_it_be(:user) { create(:user)}
let_it_be(:migrated) { create(:personal_snippet, :repository, author: user) }
+
let(:non_migrated) { create_list(:personal_snippet, 3, author: user) }
let(:non_migrated_ids) { non_migrated.pluck(:id) }
diff --git a/spec/uploaders/content_type_whitelist_spec.rb b/spec/uploaders/content_type_whitelist_spec.rb
index cf7463369abed3e70879b8a6de0ea6e0b97c90c3..0cafc7a3ae29df1251a5ab9e055b7de5192853dc 100644
--- a/spec/uploaders/content_type_whitelist_spec.rb
+++ b/spec/uploaders/content_type_whitelist_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe ContentTypeWhitelist do
let_it_be(:model) { build_stubbed(:user) }
+
let!(:uploader) do
stub_const('DummyUploader', Class.new(CarrierWave::Uploader::Base))
diff --git a/spec/uploaders/dependency_proxy/file_uploader_spec.rb b/spec/uploaders/dependency_proxy/file_uploader_spec.rb
index 6e94a661d6d846b38fb25a6f78177ce8a8c9c2e1..eb12e7dffa5600b734312aec775d960e8c8d11f8 100644
--- a/spec/uploaders/dependency_proxy/file_uploader_spec.rb
+++ b/spec/uploaders/dependency_proxy/file_uploader_spec.rb
@@ -5,6 +5,7 @@
describe 'DependencyProxy::Blob uploader' do
let_it_be(:blob) { create(:dependency_proxy_blob) }
let_it_be(:path) { Gitlab.config.dependency_proxy.storage_path }
+
let(:uploader) { described_class.new(blob, :file) }
subject { uploader }
@@ -30,6 +31,7 @@
let_it_be(:manifest) { create(:dependency_proxy_manifest) }
let_it_be(:initial_content_type) { 'application/json' }
let_it_be(:fixture_file) { fixture_file_upload('spec/fixtures/dependency_proxy/manifest', initial_content_type) }
+
let(:uploader) { described_class.new(manifest, :file) }
subject { uploader }
diff --git a/spec/views/admin/application_settings/_eks.html.haml_spec.rb b/spec/views/admin/application_settings/_eks.html.haml_spec.rb
index 2f45eaadc9f0503e40582ff1504585ede0851c0f..e407970c7a4e6477a1f1194d7732e0624385e628 100644
--- a/spec/views/admin/application_settings/_eks.html.haml_spec.rb
+++ b/spec/views/admin/application_settings/_eks.html.haml_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe 'admin/application_settings/_eks' do
let_it_be(:admin) { create(:admin) }
+
let(:page) { Capybara::Node::Simple.new(rendered) }
before do
diff --git a/spec/views/admin/application_settings/_package_registry.html.haml_spec.rb b/spec/views/admin/application_settings/_package_registry.html.haml_spec.rb
index e0aa2fc8d56e9be1d5babfe29f4c8c52dd2f8b6d..72e32643a4981ba31599fd8eaa3128ece00c5187 100644
--- a/spec/views/admin/application_settings/_package_registry.html.haml_spec.rb
+++ b/spec/views/admin/application_settings/_package_registry.html.haml_spec.rb
@@ -6,6 +6,7 @@
let_it_be(:admin) { create(:admin) }
let_it_be(:default_plan_limits) { create(:plan_limits, :default_plan, :with_package_file_sizes) }
let_it_be(:application_setting) { build(:application_setting) }
+
let(:page) { Capybara::Node::Simple.new(rendered) }
before do
diff --git a/spec/views/projects/pipelines/show.html.haml_spec.rb b/spec/views/projects/pipelines/show.html.haml_spec.rb
index 5b5c05527de7b60efb1dd61113b26d6cf2a63783..fcae587f8c81c913e02a9c74d8c2e990ac8e06db 100644
--- a/spec/views/projects/pipelines/show.html.haml_spec.rb
+++ b/spec/views/projects/pipelines/show.html.haml_spec.rb
@@ -6,6 +6,7 @@
include Devise::Test::ControllerHelpers
let_it_be(:project) { create(:project, :repository) }
let_it_be(:user) { create(:user) }
+
let(:pipeline) { create(:ci_pipeline, project: project) }
let(:presented_pipeline) { pipeline.present(current_user: user) }
diff --git a/spec/views/search/_results.html.haml_spec.rb b/spec/views/search/_results.html.haml_spec.rb
index 11f2a4082e7db1ab8e3d9bba657c0e3fe256f6cc..024e4cef9fddf613ba2585505009f3eac7c3d711 100644
--- a/spec/views/search/_results.html.haml_spec.rb
+++ b/spec/views/search/_results.html.haml_spec.rb
@@ -32,6 +32,7 @@
let_it_be(:project) { create(:project) }
let_it_be(:issue) { create(:issue, project: project, title: '*') }
let_it_be(:note) { create(:discussion_note_on_issue, noteable: issue, project: issue.project, note: '```"helloworld"```') }
+
let(:scope) { 'notes' }
let(:search_objects) { Note.page(1).per(2) }
let(:term) { 'helloworld' }
diff --git a/spec/views/shared/_label_row.html.haml_spec.rb b/spec/views/shared/_label_row.html.haml_spec.rb
index e9a0bfdcd4ea46b036d306663435e603a9731af5..6fe74b6633bf97ce9b5f8077b50cfae6f3d960a3 100644
--- a/spec/views/shared/_label_row.html.haml_spec.rb
+++ b/spec/views/shared/_label_row.html.haml_spec.rb
@@ -3,6 +3,7 @@
RSpec.describe 'shared/_label_row.html.haml' do
let_it_be(:group) { create(:group) }
+
let(:label) { build_stubbed(:group_label, group: group).present(issuable_subject: group) }
before do
@@ -11,6 +12,7 @@
context 'with a project context' do
let_it_be(:project) { create(:project, group: group) }
+
let(:label) { build_stubbed(:label, project: project).present(issuable_subject: project) }
before do
@@ -42,6 +44,7 @@
context 'with a subgroup context' do
let_it_be(:subgroup) { create(:group, parent: group) }
+
let(:label) { build_stubbed(:group_label, group: subgroup).present(issuable_subject: subgroup) }
before do
diff --git a/spec/views/shared/milestones/_top.html.haml_spec.rb b/spec/views/shared/milestones/_top.html.haml_spec.rb
index 1aa971709f101f25b9ccbf2c69309ff8a8e3934c..aa989d3e44157f079e442ec15db101399dc72a53 100644
--- a/spec/views/shared/milestones/_top.html.haml_spec.rb
+++ b/spec/views/shared/milestones/_top.html.haml_spec.rb
@@ -4,6 +4,7 @@
RSpec.describe 'shared/milestones/_top.html.haml' do
let_it_be(:group) { create(:group) }
+
let(:project) { create(:project, group: group) }
let(:milestone) { create(:milestone, project: project) }