From 68f9dbc934631b57bdc43f745049430177ec83b8 Mon Sep 17 00:00:00 2001
From: Terri Chu <tchu@gitlab.com>
Date: Tue, 17 Sep 2024 10:15:22 -0400
Subject: [PATCH] Update instructions for Delete migration keep
---
.../search/advanced_search_migration_styleguide.md | 1 +
keeps/delete_obsolete_advanced_search_migrations.rb | 7 ++++++-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/doc/development/search/advanced_search_migration_styleguide.md b/doc/development/search/advanced_search_migration_styleguide.md
index 30211dd874834..e2468f458e18f 100644
--- a/doc/development/search/advanced_search_migration_styleguide.md
+++ b/doc/development/search/advanced_search_migration_styleguide.md
@@ -509,5 +509,6 @@ recent obsolete migration.
The MR assignee must:
+1. Backup migrations from the default branch to the [migration graveyard](https://gitlab.com/gitlab-org/search-team/migration-graveyard)
1. Verify that no references to the migration or spec files exist in the `.rubocop_todo/` directory.
1. Push any required changes to the merge request.
diff --git a/keeps/delete_obsolete_advanced_search_migrations.rb b/keeps/delete_obsolete_advanced_search_migrations.rb
index 6eded3b3b33d9..0ba71ff5a0d2f 100644
--- a/keeps/delete_obsolete_advanced_search_migrations.rb
+++ b/keeps/delete_obsolete_advanced_search_migrations.rb
@@ -82,7 +82,7 @@ def create_remove_obsolete_change
'maintenance::removal',
GROUP_LABEL
]
- change.reviewers = groups_helper.pick_reviewer(group_data, change.identifiers)
+ change.assignees = groups_helper.pick_reviewer(group_data, change.identifiers)
change.changelog_ee = true
# rubocop:disable Gitlab/DocUrl -- Not running inside rails application
@@ -96,6 +96,11 @@ def create_remove_obsolete_change
[required stop](https://docs.gitlab.com/ee/development/database/required_stops.html) as obsolete migrations
before removing the migration code from the project. Therefore we can remove code for all Advanced search
migrations that were made obsolete before the last required stop.
+
+ ## Tasks to complete before merging
+
+ - [ ] Update the archive of migrations in https://gitlab.com/gitlab-org/search-team/migration-graveyard
+ - [ ] Remove references to affected migration or spec files from Rubocop TODOs
MARKDOWN
# rubocop:enable Gitlab/DocUrl
--
GitLab