diff --git a/doc/development/search/advanced_search_migration_styleguide.md b/doc/development/search/advanced_search_migration_styleguide.md index 30211dd874834d288e93298786cb120c8c0a00a4..e2468f458e18f3e1d0818fdca73146cd87fb0864 100644 --- a/doc/development/search/advanced_search_migration_styleguide.md +++ b/doc/development/search/advanced_search_migration_styleguide.md @@ -509,5 +509,6 @@ recent obsolete migration. The MR assignee must: +1. Backup migrations from the default branch to the [migration graveyard](https://gitlab.com/gitlab-org/search-team/migration-graveyard) 1. Verify that no references to the migration or spec files exist in the `.rubocop_todo/` directory. 1. Push any required changes to the merge request. diff --git a/keeps/delete_obsolete_advanced_search_migrations.rb b/keeps/delete_obsolete_advanced_search_migrations.rb index 6eded3b3b33d9751b6470b8dd308eceb1a101df1..0ba71ff5a0d2fcde314f255bf089f7420095507a 100644 --- a/keeps/delete_obsolete_advanced_search_migrations.rb +++ b/keeps/delete_obsolete_advanced_search_migrations.rb @@ -82,7 +82,7 @@ def create_remove_obsolete_change 'maintenance::removal', GROUP_LABEL ] - change.reviewers = groups_helper.pick_reviewer(group_data, change.identifiers) + change.assignees = groups_helper.pick_reviewer(group_data, change.identifiers) change.changelog_ee = true # rubocop:disable Gitlab/DocUrl -- Not running inside rails application @@ -96,6 +96,11 @@ def create_remove_obsolete_change [required stop](https://docs.gitlab.com/ee/development/database/required_stops.html) as obsolete migrations before removing the migration code from the project. Therefore we can remove code for all Advanced search migrations that were made obsolete before the last required stop. + + ## Tasks to complete before merging + + - [ ] Update the archive of migrations in https://gitlab.com/gitlab-org/search-team/migration-graveyard + - [ ] Remove references to affected migration or spec files from Rubocop TODOs MARKDOWN # rubocop:enable Gitlab/DocUrl