From 663e565ceff616f29ca4410ce43d80e4f0878780 Mon Sep 17 00:00:00 2001 From: Ashraf Khamis <akhamis@gitlab.com> Date: Fri, 22 Nov 2024 19:37:11 +0000 Subject: [PATCH] Use title case for To-Do List in docs and UI --- app/assets/javascripts/behaviors/shortcuts/keybindings.js | 2 +- .../javascripts/super_sidebar/components/user_bar.vue | 2 +- doc/user/todos.md | 6 +++--- locale/gitlab.pot | 5 +---- spec/frontend/super_sidebar/components/user_bar_spec.js | 2 +- 5 files changed, 7 insertions(+), 10 deletions(-) diff --git a/app/assets/javascripts/behaviors/shortcuts/keybindings.js b/app/assets/javascripts/behaviors/shortcuts/keybindings.js index 61b7c1e199e88..10c22609858cb 100644 --- a/app/assets/javascripts/behaviors/shortcuts/keybindings.js +++ b/app/assets/javascripts/behaviors/shortcuts/keybindings.js @@ -104,7 +104,7 @@ export const GO_TO_YOUR_REVIEW_REQUESTS = { export const GO_TO_YOUR_TODO_LIST = { id: 'globalShortcuts.goToYourTodoList', - description: __('Go to your To-Do list'), + description: __('Go to your To-Do List'), defaultKeys: ['shift+t'], }; diff --git a/app/assets/javascripts/super_sidebar/components/user_bar.vue b/app/assets/javascripts/super_sidebar/components/user_bar.vue index a327d6ebb1bf3..910cb8150a7c9 100644 --- a/app/assets/javascripts/super_sidebar/components/user_bar.vue +++ b/app/assets/javascripts/super_sidebar/components/user_bar.vue @@ -51,7 +51,7 @@ export default { { kbdOpen: '<kbd>', kbdClose: '</kbd>' }, false, ), - todoList: __('To-Do list'), + todoList: __('To-Do List'), stopImpersonating: __('Stop impersonating'), searchBtnText: __('Search or go to…'), }, diff --git a/doc/user/todos.md b/doc/user/todos.md index 5e6ceba0148dc..4a5ec81ccec21 100644 --- a/doc/user/todos.md +++ b/doc/user/todos.md @@ -24,7 +24,7 @@ You can use the To-Do List to track [actions](#actions-that-create-to-do-items) To access your To-Do List: -On the left sidebar, at the top, select **To-Do list** (**{task-done}**). +On the left sidebar, at the top, select **To-Do List** (**{task-done}**). ### Search the To-Do List @@ -129,12 +129,12 @@ Hi, please message @frank :incoming_envelope: If you marked a to-do item as done by mistake, you can re-add it from the **Done** tab: -1. On the left sidebar, at the top, select To-Do list (**{task-done}**). +1. On the left sidebar, at the top, select **To-Do List** (**{task-done}**). 1. At the top, select **Done**. 1. [Find the to-do item](#search-the-to-do-list) you want to re-add. 1. Next to this to-do item, select **Re-add this to-do item** **{redo}**. -The to-do item is now visible in the **To Do** tab of the To-Do list. +The to-do item is now visible in the **To Do** tab of the To-Do List. ## Actions that mark a to-do item as done diff --git a/locale/gitlab.pot b/locale/gitlab.pot index 752585acf3965..ca4bef54b6b71 100644 --- a/locale/gitlab.pot +++ b/locale/gitlab.pot @@ -25925,7 +25925,7 @@ msgstr "" msgid "Go to wiki" msgstr "" -msgid "Go to your To-Do list" +msgid "Go to your To-Do List" msgstr "" msgid "Go to your fork" @@ -57680,9 +57680,6 @@ msgstr "" msgid "To-Do List" msgstr "" -msgid "To-Do list" -msgstr "" - msgid "To-do item successfully marked as done." msgstr "" diff --git a/spec/frontend/super_sidebar/components/user_bar_spec.js b/spec/frontend/super_sidebar/components/user_bar_spec.js index 89986bd830ca0..f77b3740e6197 100644 --- a/spec/frontend/super_sidebar/components/user_bar_spec.js +++ b/spec/frontend/super_sidebar/components/user_bar_spec.js @@ -132,7 +132,7 @@ describe('UserBar component', () => { it('renders it', () => { const todosCounter = findTodosCounter(); expect(todosCounter.props('href')).toBe(mockSidebarData.todos_dashboard_path); - expect(todosCounter.props('label')).toBe('To-Do list'); + expect(todosCounter.props('label')).toBe('To-Do List'); expect(todosCounter.attributes('data-track-action')).toBe('click_link'); expect(todosCounter.attributes('data-track-label')).toBe('todos_link'); expect(todosCounter.attributes('data-track-property')).toBe('nav_core_menu'); -- GitLab