From 643b4f09e052b89fab01e3f60734ebe9a014882e Mon Sep 17 00:00:00 2001 From: Auto-quarantining bot <gitlab-auto-quarantine-bot@gitlab.com> Date: Mon, 10 Feb 2025 03:12:23 +0000 Subject: [PATCH] Quarantine a flaky test The `` MergeRequestDiffEntity#version_index when @merge_request_diffs.size > 1 returns difference between size and diff index `` test matches one of the following conditions: 1. has either ~"flakiness::1" or ~"flakiness::2" label set, which means the number of reported failures is at or above 95 percentile, indicating unusually high failure count. 2. has ~"severity::1" label set, which means the number of reported failures [spiked and exceeded its daily threshold](https://gitlab.com/gitlab-org/ruby/gems/gitlab_quality-test_tooling/-/blob/c9bc10536b1f8d2d4a03c3e0b6099a40fe67ad26/lib/gitlab_quality/test_tooling/report/concerns/issue_reports.rb#L51). This MR quarantines the test. This is a discussion starting point to let the responsible group know about the flakiness so that they can take action: - accept the merge request and schedule the associated issue to improve the test - close the merge request in favor of another merge request to delete the test Please follow the [Flaky tests management process](https://handbook.gitlab.com/handbook/engineering/infrastructure/engineering-productivity/flaky-tests-management-and-processes/#flaky-tests-management-process) to help us increase `master` stability. Please let us know your feedback in the [Engineering Productivity issue tracker](https://gitlab.com/gitlab-org/quality/engineering-productivity/team/-/issues). Related to https://gitlab.com/gitlab-org/gitlab/-/issues/445703. This change was generated by [gitlab-housekeeper](https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-housekeeper) using the Keeps::QuarantineFlakyTests keep. To provide feedback on your experience with `gitlab-housekeeper` please create an issue with the label ~"GitLab Housekeeper" and consider pinging the author of this keep. Changelog: other --- spec/serializers/merge_request_diff_entity_spec.rb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/spec/serializers/merge_request_diff_entity_spec.rb b/spec/serializers/merge_request_diff_entity_spec.rb index 59cdcb4ec4ae6..20d11f684337a 100644 --- a/spec/serializers/merge_request_diff_entity_spec.rb +++ b/spec/serializers/merge_request_diff_entity_spec.rb @@ -76,7 +76,8 @@ def initialize_entity(merge_request, merge_request_diff) context 'when @merge_request_diffs.size > 1' do let(:merge_request) { create(:merge_request_with_multiple_diffs) } - it 'returns difference between size and diff index' do + it 'returns difference between size and diff index', + quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/445703' do expect(merge_request_diffs.size).to eq(2) # diff index: 0 -- GitLab