From 63e6af2d9d9654a74689c48d6b7b32fa58bc04fc Mon Sep 17 00:00:00 2001 From: Samantha Ming <sming@gitlab.com> Date: Mon, 6 May 2024 15:02:27 +0200 Subject: [PATCH] Revert deprecation for securityReportFindings This endpoint is being used for the pipeline security tab. This MR revert the GraphQL deprecations notice for pipeline security tab. --- ...5-1-project-pipeline-securityReportFindings.yml | 14 -------------- doc/update/deprecations.md | 14 -------------- 2 files changed, 28 deletions(-) delete mode 100644 data/deprecations/15-1-project-pipeline-securityReportFindings.yml diff --git a/data/deprecations/15-1-project-pipeline-securityReportFindings.yml b/data/deprecations/15-1-project-pipeline-securityReportFindings.yml deleted file mode 100644 index 40fe3bf5bfffe..0000000000000 --- a/data/deprecations/15-1-project-pipeline-securityReportFindings.yml +++ /dev/null @@ -1,14 +0,0 @@ -- title: "project.pipeline.securityReportFindings GraphQL query" # (required) The name of the feature to be deprecated - announcement_milestone: "15.1" # (required) The milestone when this feature was first announced as deprecated. - removal_milestone: "17.0" # (required) The milestone when this feature is planned to be removed - breaking_change: true # (required) If this deprecation is a breaking change, set this value to true - reporter: matt_wilson # (required) GitLab username of the person reporting the deprecation - stage: Secure # (required) String value of the stage that the feature was created in. e.g., Growth - issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/343475 # (required) Link to the deprecation issue in GitLab - body: | # (required) Do not modify this line, instead modify the lines below. - Previous work helped [align the vulnerabilities calls for pipeline security tabs](https://gitlab.com/gitlab-org/gitlab/-/issues/343469) to match the vulnerabilities calls for project-level and group-level vulnerability reports. This helped the frontend have a more consistent interface. The old `project.pipeline.securityReportFindings` query was formatted differently than other vulnerability data calls. Now that it has been replaced with the new `project.pipeline.vulnerabilities` field, the old `project.pipeline.securityReportFindings` is being deprecated and will be removed in GitLab 17.0. -# The following items are not published on the docs page, but may be used in the future. - tiers: Ultimate # (optional - may be required in the future) An array of tiers that the feature is available in currently. e.g., [Free, Silver, Gold, Core, Premium, Ultimate] - documentation_url: # (optional) This is a link to the current documentation page - image_url: # (optional) This is a link to a thumbnail image depicting the feature - video_url: # (optional) Use the youtube thumbnail URL with the structure of https://img.youtube.com/vi/UNIQUEID/hqdefault.jpg diff --git a/doc/update/deprecations.md b/doc/update/deprecations.md index ec5bd8380b1f0..6f5e17879273e 100644 --- a/doc/update/deprecations.md +++ b/doc/update/deprecations.md @@ -2297,20 +2297,6 @@ From 17.0, npm and Yarn packages will be uploaded asynchronously. This is a brea As a workaround, you should use the [packages API](https://docs.gitlab.com/ee/api/packages.html) to check for packages. -</div> - -<div class="deprecation breaking-change" data-milestone="17.0"> - -### project.pipeline.securityReportFindings GraphQL query - -<div class="deprecation-notes"> -- Announced in GitLab <span class="milestone">15.1</span> -- Removal in GitLab <span class="milestone">17.0</span> ([breaking change](https://docs.gitlab.com/ee/update/terminology.html#breaking-change)) -- To discuss this change or learn more, see the [deprecation issue](https://gitlab.com/gitlab-org/gitlab/-/issues/343475). -</div> - -Previous work helped [align the vulnerabilities calls for pipeline security tabs](https://gitlab.com/gitlab-org/gitlab/-/issues/343469) to match the vulnerabilities calls for project-level and group-level vulnerability reports. This helped the frontend have a more consistent interface. The old `project.pipeline.securityReportFindings` query was formatted differently than other vulnerability data calls. Now that it has been replaced with the new `project.pipeline.vulnerabilities` field, the old `project.pipeline.securityReportFindings` is being deprecated and will be removed in GitLab 17.0. - </div> </div> -- GitLab