From 639c93b4f2bd492a214065b5fdc47da2f5d8614d Mon Sep 17 00:00:00 2001
From: Douwe Maan <douwe@gitlab.com>
Date: Fri, 6 Feb 2015 11:21:42 +0100
Subject: [PATCH] Don't have Markdown preview fail for long content by using
POST rather than GET.
See https://github.com/gitlabhq/gitlabhq/issues/8611.
---
CHANGELOG | 1 +
app/assets/javascripts/dropzone_input.js.coffee | 2 +-
config/routes.rb | 2 +-
spec/routing/project_routing_spec.rb | 4 ++--
4 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/CHANGELOG b/CHANGELOG
index 235a99b43270f..ed7375e27ed01 100644
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -61,6 +61,7 @@ v 7.8.0
-
- API: Add support for editing an existing project (Mika Mäenpää and Hannes Rosenögger)
-
+ - Don't have Markdown preview fail for long comments/wiki pages.
-
- When test web hook - show error message instead of 500 error page if connection to hook url was reset
- Added support for firing system hooks on group create/destroy and adding/removing users to group (Boyan Tabakov)
diff --git a/app/assets/javascripts/dropzone_input.js.coffee b/app/assets/javascripts/dropzone_input.js.coffee
index abb5bf519ee54..d98d548293743 100644
--- a/app/assets/javascripts/dropzone_input.js.coffee
+++ b/app/assets/javascripts/dropzone_input.js.coffee
@@ -50,7 +50,7 @@ class @DropzoneInput
preview.text "Nothing to preview."
else
preview.text "Loading..."
- $.get($(this).data("url"),
+ $.post($(this).data("url"),
md_text: mdText
).success (previewData) ->
preview.html previewData
diff --git a/config/routes.rb b/config/routes.rb
index f0abd876ecda9..66faf5312b488 100644
--- a/config/routes.rb
+++ b/config/routes.rb
@@ -209,7 +209,7 @@
post :unarchive
post :upload_image
post :toggle_star
- get :markdown_preview
+ post :markdown_preview
get :autocomplete_sources
end
diff --git a/spec/routing/project_routing_spec.rb b/spec/routing/project_routing_spec.rb
index e36b266a1ff33..b8f9d2bf20a78 100644
--- a/spec/routing/project_routing_spec.rb
+++ b/spec/routing/project_routing_spec.rb
@@ -60,7 +60,7 @@
# project GET /:id(.:format) projects#show
# PUT /:id(.:format) projects#update
# DELETE /:id(.:format) projects#destroy
-# markdown_preview_project GET /:id/markdown_preview(.:format) projects#markdown_preview
+# markdown_preview_project POST /:id/markdown_preview(.:format) projects#markdown_preview
describe ProjectsController, 'routing' do
it 'to #create' do
post('/projects').should route_to('projects#create')
@@ -91,7 +91,7 @@
end
it 'to #markdown_preview' do
- get('/gitlab/gitlabhq/markdown_preview').should(
+ post('/gitlab/gitlabhq/markdown_preview').should(
route_to('projects#markdown_preview', id: 'gitlab/gitlabhq')
)
end
--
GitLab