diff --git a/spec/graphql/types/project_type_spec.rb b/spec/graphql/types/project_type_spec.rb index bc9621e9fc8242607d6f7937d8ebddd977c8fb12..6dfa88680e8b66f1a813460cbd1d695af05dbd18 100644 --- a/spec/graphql/types/project_type_spec.rb +++ b/spec/graphql/types/project_type_spec.rb @@ -1154,6 +1154,7 @@ subject { GitlabSchema.execute(query, context: { current_user: current_user }).as_json } let_it_be(:current_user) { create(:user) } + let_it_be(:project) { create(:project, :empty_repo) } let(:query) do %( @@ -1170,18 +1171,12 @@ subject.dig('data', 'project', 'protectableBranches') end - let_it_be(:project) { create(:project, :empty_repo) } - before_all do project.add_maintainer(current_user) end describe 'an empty repository' do - before_all do - project.repository.branch_names.each do |branch_name| - project.repository.delete_branch(branch_name) - end - end + let(:project) { create(:project, :empty_repo, maintainers: current_user) } it 'returns an empty array' do expect(protectable_branches).to be_empty diff --git a/spec/support/rspec_order_todo.yml b/spec/support/rspec_order_todo.yml index 55920528863d524b0b19ad90ca14f80601fbf93d..5dae8a460d5240a14b820888ca8679c0883fd459 100644 --- a/spec/support/rspec_order_todo.yml +++ b/spec/support/rspec_order_todo.yml @@ -4172,294 +4172,6 @@ - './spec/graphql/resolvers/work_items_resolver_spec.rb' - './spec/graphql/resolvers/work_items/types_resolver_spec.rb' - './spec/graphql/subscriptions/issuable_updated_spec.rb' -- './spec/graphql/types/access_level_enum_spec.rb' -- './spec/graphql/types/access_level_type_spec.rb' -- './spec/graphql/types/admin/analytics/usage_trends/measurement_identifier_enum_spec.rb' -- './spec/graphql/types/admin/analytics/usage_trends/measurement_type_spec.rb' -- './spec/graphql/types/alert_management/alert_status_count_type_spec.rb' -- './spec/graphql/types/alert_management/alert_type_spec.rb' -- './spec/graphql/types/alert_management/domain_filter_enum_spec.rb' -- './spec/graphql/types/alert_management/http_integration_type_spec.rb' -- './spec/graphql/types/alert_management/integration_type_enum_spec.rb' -- './spec/graphql/types/alert_management/integration_type_spec.rb' -- './spec/graphql/types/alert_management/prometheus_integration_type_spec.rb' -- './spec/graphql/types/alert_management/severity_enum_spec.rb' -- './spec/graphql/types/alert_management/status_enum_spec.rb' -- './spec/graphql/types/availability_enum_spec.rb' -- './spec/graphql/types/award_emojis/award_emoji_type_spec.rb' -- './spec/graphql/types/base_argument_spec.rb' -- './spec/graphql/types/base_edge_spec.rb' -- './spec/graphql/types/base_enum_spec.rb' -- './spec/graphql/types/base_field_spec.rb' -- './spec/graphql/types/base_object_spec.rb' -- './spec/graphql/types/blob_viewers/type_enum_spec.rb' -- './spec/graphql/types/blob_viewer_type_spec.rb' -- './spec/graphql/types/board_list_type_spec.rb' -- './spec/graphql/types/boards/board_issue_input_type_spec.rb' -- './spec/graphql/types/board_type_spec.rb' -- './spec/graphql/types/branch_type_spec.rb' -- './spec/graphql/types/ci/analytics_type_spec.rb' -- './spec/graphql/types/ci/config/config_type_spec.rb' -- './spec/graphql/types/ci/config/group_type_spec.rb' -- './spec/graphql/types/ci/config/include_type_enum_spec.rb' -- './spec/graphql/types/ci/config/include_type_spec.rb' -- './spec/graphql/types/ci/config/job_restriction_type_spec.rb' -- './spec/graphql/types/ci/config/job_type_spec.rb' -- './spec/graphql/types/ci/config/need_type_spec.rb' -- './spec/graphql/types/ci/config/stage_type_spec.rb' -- './spec/graphql/types/ci_configuration/sast/analyzers_entity_input_type_spec.rb' -- './spec/graphql/types/ci_configuration/sast/analyzers_entity_type_spec.rb' -- './spec/graphql/types/ci_configuration/sast/entity_input_type_spec.rb' -- './spec/graphql/types/ci_configuration/sast/entity_type_spec.rb' -- './spec/graphql/types/ci_configuration/sast/input_type_spec.rb' -- './spec/graphql/types/ci_configuration/sast/options_entity_spec.rb' -- './spec/graphql/types/ci_configuration/sast/type_spec.rb' -- './spec/graphql/types/ci_configuration/sast/ui_component_size_enum_spec.rb' -- './spec/graphql/types/ci/detailed_status_type_spec.rb' -- './spec/graphql/types/ci/group_type_spec.rb' -- './spec/graphql/types/ci/group_variable_type_spec.rb' -- './spec/graphql/types/ci/instance_variable_type_spec.rb' -- './spec/graphql/types/ci/job_artifact_file_type_enum_spec.rb' -- './spec/graphql/types/ci/job_artifact_type_spec.rb' -- './spec/graphql/types/ci/job_kind_enum_spec.rb' -- './spec/graphql/types/ci/job_need_union_spec.rb' -- './spec/graphql/types/ci/job_status_enum_spec.rb' -- './spec/graphql/types/ci/job_token_scope_type_spec.rb' -- './spec/graphql/types/ci/job_type_spec.rb' -- './spec/graphql/types/ci/manual_variable_type_spec.rb' -- './spec/graphql/types/ci/pipeline_counts_type_spec.rb' -- './spec/graphql/types/ci/pipeline_merge_request_event_type_enum_spec.rb' -- './spec/graphql/types/ci/pipeline_message_type_spec.rb' -- './spec/graphql/types/ci/pipeline_scope_enum_spec.rb' -- './spec/graphql/types/ci/pipeline_status_enum_spec.rb' -- './spec/graphql/types/ci/pipeline_type_spec.rb' -- './spec/graphql/types/ci/project_variable_type_spec.rb' -- './spec/graphql/types/ci/recent_failures_type_spec.rb' -- './spec/graphql/types/ci/runner_architecture_type_spec.rb' -- './spec/graphql/types/ci/runner_platform_type_spec.rb' -- './spec/graphql/types/ci/runner_setup_type_spec.rb' -- './spec/graphql/types/ci/runner_type_spec.rb' -- './spec/graphql/types/ci/runner_upgrade_status_enum_spec.rb' -- './spec/graphql/types/ci/runner_web_url_edge_spec.rb' -- './spec/graphql/types/ci/stage_type_spec.rb' -- './spec/graphql/types/ci/status_action_type_spec.rb' -- './spec/graphql/types/ci/template_type_spec.rb' -- './spec/graphql/types/ci/test_case_status_enum_spec.rb' -- './spec/graphql/types/ci/test_case_type_spec.rb' -- './spec/graphql/types/ci/test_report_summary_type_spec.rb' -- './spec/graphql/types/ci/test_report_total_type_spec.rb' -- './spec/graphql/types/ci/test_suite_summary_type_spec.rb' -- './spec/graphql/types/ci/test_suite_type_spec.rb' -- './spec/graphql/types/ci/variable_input_type_spec.rb' -- './spec/graphql/types/ci/variable_interface_spec.rb' -- './spec/graphql/types/ci/variable_type_enum_spec.rb' -- './spec/graphql/types/clusters/agent_activity_event_type_spec.rb' -- './spec/graphql/types/clusters/agent_token_status_enum_spec.rb' -- './spec/graphql/types/clusters/agent_token_type_spec.rb' -- './spec/graphql/types/clusters/agent_type_spec.rb' -- './spec/graphql/types/color_type_spec.rb' -- './spec/graphql/types/commit_action_mode_enum_spec.rb' -- './spec/graphql/types/commit_encoding_enum_spec.rb' -- './spec/graphql/types/commit_type_spec.rb' -- './spec/graphql/types/container_expiration_policy_cadence_enum_spec.rb' -- './spec/graphql/types/container_expiration_policy_keep_enum_spec.rb' -- './spec/graphql/types/container_expiration_policy_older_than_enum_spec.rb' -- './spec/graphql/types/container_expiration_policy_type_spec.rb' -- './spec/graphql/types/container_repository_cleanup_status_enum_spec.rb' -- './spec/graphql/types/container_repository_details_type_spec.rb' -- './spec/graphql/types/container_repository_sort_enum_spec.rb' -- './spec/graphql/types/container_repository_status_enum_spec.rb' -- './spec/graphql/types/container_repository_tag_type_spec.rb' -- './spec/graphql/types/container_repository_type_spec.rb' -- './spec/graphql/types/container_respository_tags_sort_enum_spec.rb' -- './spec/graphql/types/countable_connection_type_spec.rb' -- './spec/graphql/types/current_user_todos_type_spec.rb' -- './spec/graphql/types/custom_emoji_type_spec.rb' -- './spec/graphql/types/customer_relations/contact_sort_enum_spec.rb' -- './spec/graphql/types/customer_relations/contact_state_counts_type_spec.rb' -- './spec/graphql/types/customer_relations/contact_type_spec.rb' -- './spec/graphql/types/customer_relations/organization_sort_enum_spec.rb' -- './spec/graphql/types/customer_relations/organization_state_counts_type_spec.rb' -- './spec/graphql/types/customer_relations/organization_type_spec.rb' -- './spec/graphql/types/dependency_proxy/blob_type_spec.rb' -- './spec/graphql/types/dependency_proxy/group_setting_type_spec.rb' -- './spec/graphql/types/dependency_proxy/image_ttl_group_policy_type_spec.rb' -- './spec/graphql/types/dependency_proxy/manifest_type_spec.rb' -- './spec/graphql/types/deployment_tier_enum_spec.rb' -- './spec/graphql/types/design_management/design_at_version_type_spec.rb' -- './spec/graphql/types/design_management/design_collection_copy_state_enum_spec.rb' -- './spec/graphql/types/design_management/design_collection_type_spec.rb' -- './spec/graphql/types/design_management/design_type_spec.rb' -- './spec/graphql/types/design_management/design_version_event_enum_spec.rb' -- './spec/graphql/types/design_management_type_spec.rb' -- './spec/graphql/types/design_management/version_type_spec.rb' -- './spec/graphql/types/diff_refs_type_spec.rb' -- './spec/graphql/types/duration_type_spec.rb' -- './spec/graphql/types/environment_type_spec.rb' -- './spec/graphql/types/error_tracking/sentry_detailed_error_type_spec.rb' -- './spec/graphql/types/error_tracking/sentry_error_collection_type_spec.rb' -- './spec/graphql/types/error_tracking/sentry_error_stack_trace_entry_type_spec.rb' -- './spec/graphql/types/error_tracking/sentry_error_stack_trace_type_spec.rb' -- './spec/graphql/types/error_tracking/sentry_error_type_spec.rb' -- './spec/graphql/types/eventable_type_spec.rb' -- './spec/graphql/types/event_type_spec.rb' -- './spec/graphql/types/evidence_type_spec.rb' -- './spec/graphql/types/global_id_type_spec.rb' -- './spec/graphql/types/grafana_integration_type_spec.rb' -- './spec/graphql/types/group_invitation_type_spec.rb' -- './spec/graphql/types/group_member_relation_enum_spec.rb' -- './spec/graphql/types/group_member_type_spec.rb' -- './spec/graphql/types/group_type_spec.rb' -- './spec/graphql/types/invitation_interface_spec.rb' -- './spec/graphql/types/issuable_searchable_field_enum_spec.rb' -- './spec/graphql/types/issuable_severity_enum_spec.rb' -- './spec/graphql/types/issuable_sort_enum_spec.rb' -- './spec/graphql/types/issuable_state_enum_spec.rb' -- './spec/graphql/types/issuable_type_spec.rb' -- './spec/graphql/types/issue_sort_enum_spec.rb' -- './spec/graphql/types/issue_state_enum_spec.rb' -- './spec/graphql/types/issue_status_count_type_spec.rb' -- './spec/graphql/types/issue_type_enum_spec.rb' -- './spec/graphql/types/issue_type_spec.rb' -- './spec/graphql/types/jira_import_type_spec.rb' -- './spec/graphql/types/jira_user_type_spec.rb' -- './spec/graphql/types/kas/agent_configuration_type_spec.rb' -- './spec/graphql/types/kas/agent_connection_type_spec.rb' -- './spec/graphql/types/kas/agent_metadata_type_spec.rb' -- './spec/graphql/types/label_type_spec.rb' -- './spec/graphql/types/limited_countable_connection_type_spec.rb' -- './spec/graphql/types/member_interface_spec.rb' -- './spec/graphql/types/merge_request_connection_type_spec.rb' -- './spec/graphql/types/merge_request_review_state_enum_spec.rb' -- './spec/graphql/types/merge_requests/assignee_type_spec.rb' -- './spec/graphql/types/merge_requests/author_type_spec.rb' -- './spec/graphql/types/merge_request_sort_enum_spec.rb' -- './spec/graphql/types/merge_requests/participant_type_spec.rb' -- './spec/graphql/types/merge_requests/reviewer_type_spec.rb' -- './spec/graphql/types/merge_request_state_enum_spec.rb' -- './spec/graphql/types/merge_request_state_event_enum_spec.rb' -- './spec/graphql/types/merge_request_type_spec.rb' -- './spec/graphql/types/metadata/kas_type_spec.rb' -- './spec/graphql/types/metadata_type_spec.rb' -- './spec/graphql/types/metrics/dashboards/annotation_type_spec.rb' -- './spec/graphql/types/milestone_stats_type_spec.rb' -- './spec/graphql/types/milestone_type_spec.rb' -- './spec/graphql/types/mutation_type_spec.rb' -- './spec/graphql/types/namespace/package_settings_type_spec.rb' -- './spec/graphql/types/namespace_type_spec.rb' -- './spec/graphql/types/notes/diff_position_type_spec.rb' -- './spec/graphql/types/notes/discussion_type_spec.rb' -- './spec/graphql/types/notes/noteable_interface_spec.rb' -- './spec/graphql/types/notes/note_type_spec.rb' -- './spec/graphql/types/packages/cleanup/keep_duplicated_package_files_enum_spec.rb' -- './spec/graphql/types/packages/cleanup/policy_type_spec.rb' -- './spec/graphql/types/packages/composer/json_type_spec.rb' -- './spec/graphql/types/packages/composer/metadatum_type_spec.rb' -- './spec/graphql/types/packages/conan/file_metadatum_type_spec.rb' -- './spec/graphql/types/packages/conan/metadatum_file_type_enum_spec.rb' -- './spec/graphql/types/packages/conan/metadatum_type_spec.rb' -- './spec/graphql/types/packages/helm/dependency_type_spec.rb' -- './spec/graphql/types/packages/helm/file_metadatum_type_spec.rb' -- './spec/graphql/types/packages/helm/maintainer_type_spec.rb' -- './spec/graphql/types/packages/helm/metadata_type_spec.rb' -- './spec/graphql/types/packages/maven/metadatum_type_spec.rb' -- './spec/graphql/types/packages/nuget/dependency_link_metdatum_type_spec.rb' -- './spec/graphql/types/packages/nuget/metadatum_type_spec.rb' -- './spec/graphql/types/packages/package_base_type_spec.rb' -- './spec/graphql/types/packages/package_dependency_link_type_spec.rb' -- './spec/graphql/types/packages/package_dependency_type_enum_spec.rb' -- './spec/graphql/types/packages/package_dependency_type_spec.rb' -- './spec/graphql/types/packages/package_details_type_spec.rb' -- './spec/graphql/types/packages/package_file_type_spec.rb' -- './spec/graphql/types/packages/package_group_sort_enum_spec.rb' -- './spec/graphql/types/packages/package_sort_enum_spec.rb' -- './spec/graphql/types/packages/package_status_enum_spec.rb' -- './spec/graphql/types/packages/package_type_enum_spec.rb' -- './spec/graphql/types/packages/package_type_spec.rb' -- './spec/graphql/types/packages/pypi/metadatum_type_spec.rb' -- './spec/graphql/types/packages/tag_type_spec.rb' -- './spec/graphql/types/permission_types/base_permission_type_spec.rb' -- './spec/graphql/types/permission_types/ci/job_spec.rb' -- './spec/graphql/types/permission_types/ci/runner_spec.rb' -- './spec/graphql/types/permission_types/issue_spec.rb' -- './spec/graphql/types/permission_types/merge_request_spec.rb' -- './spec/graphql/types/permission_types/merge_request_type_spec.rb' -- './spec/graphql/types/permission_types/note_spec.rb' -- './spec/graphql/types/permission_types/project_spec.rb' -- './spec/graphql/types/permission_types/snippet_spec.rb' -- './spec/graphql/types/permission_types/user_spec.rb' -- './spec/graphql/types/permission_types/work_item_spec.rb' -- './spec/graphql/types/project_invitation_type_spec.rb' -- './spec/graphql/types/project_member_relation_enum_spec.rb' -- './spec/graphql/types/project_member_type_spec.rb' -- './spec/graphql/types/projects/base_service_type_spec.rb' -- './spec/graphql/types/projects/jira_project_type_spec.rb' -- './spec/graphql/types/projects/jira_service_type_spec.rb' -- './spec/graphql/types/projects/service_type_enum_spec.rb' -- './spec/graphql/types/projects/service_type_spec.rb' -- './spec/graphql/types/project_statistics_type_spec.rb' -- './spec/graphql/types/projects/topic_type_spec.rb' -- './spec/graphql/types/project_type_spec.rb' -- './spec/graphql/types/prometheus_alert_type_spec.rb' -- './spec/graphql/types/query_complexity_type_spec.rb' -- './spec/graphql/types/query_type_spec.rb' -- './spec/graphql/types/range_input_type_spec.rb' -- './spec/graphql/types/release_asset_link_input_type_spec.rb' -- './spec/graphql/types/release_asset_link_type_spec.rb' -- './spec/graphql/types/release_assets_input_type_spec.rb' -- './spec/graphql/types/release_assets_type_spec.rb' -- './spec/graphql/types/release_links_type_spec.rb' -- './spec/graphql/types/release_source_type_spec.rb' -- './spec/graphql/types/release_type_spec.rb' -- './spec/graphql/types/repository/blob_type_spec.rb' -- './spec/graphql/types/repository_type_spec.rb' -- './spec/graphql/types/resolvable_interface_spec.rb' -- './spec/graphql/types/root_storage_statistics_type_spec.rb' -- './spec/graphql/types/saved_reply_type_spec.rb' -- './spec/graphql/types/security/report_types_enum_spec.rb' -- './spec/graphql/types/snippets/blob_action_enum_spec.rb' -- './spec/graphql/types/snippets/blob_action_input_type_spec.rb' -- './spec/graphql/types/snippets/blob_type_spec.rb' -- './spec/graphql/types/snippets/blob_viewer_type_spec.rb' -- './spec/graphql/types/snippet_type_spec.rb' -- './spec/graphql/types/subscription_type_spec.rb' -- './spec/graphql/types/terraform/state_type_spec.rb' -- './spec/graphql/types/terraform/state_version_type_spec.rb' -- './spec/graphql/types/timeframe_type_spec.rb' -- './spec/graphql/types/timelog_type_spec.rb' -- './spec/graphql/types/time_tracking/timelog_category_type_spec.rb' -- './spec/graphql/types/time_type_spec.rb' -- './spec/graphql/types/todoable_interface_spec.rb' -- './spec/graphql/types/todo_type_spec.rb' -- './spec/graphql/types/tree/blob_type_spec.rb' -- './spec/graphql/types/tree/submodule_type_spec.rb' -- './spec/graphql/types/tree/tree_entry_type_spec.rb' -- './spec/graphql/types/tree/tree_type_spec.rb' -- './spec/graphql/types/tree/type_enum_spec.rb' -- './spec/graphql/types/untrusted_regexp_spec.rb' -- './spec/graphql/types/upload_type_spec.rb' -- './spec/graphql/types/user_callout_feature_name_enum_spec.rb' -- './spec/graphql/types/user_callout_type_spec.rb' -- './spec/graphql/types/user_merge_request_interaction_type_spec.rb' -- './spec/graphql/types/user_preferences_type_spec.rb' -- './spec/graphql/types/user_status_type_spec.rb' -- './spec/graphql/types/user_type_spec.rb' -- './spec/graphql/types/work_item_id_type_spec.rb' -- './spec/graphql/types/work_items/widget_interface_spec.rb' -- './spec/graphql/types/work_items/widgets/assignees_input_type_spec.rb' -- './spec/graphql/types/work_items/widgets/assignees_type_spec.rb' -- './spec/graphql/types/work_items/widgets/description_input_type_spec.rb' -- './spec/graphql/types/work_items/widgets/description_type_spec.rb' -- './spec/graphql/types/work_items/widgets/hierarchy_type_spec.rb' -- './spec/graphql/types/work_items/widgets/hierarchy_update_input_type_spec.rb' -- './spec/graphql/types/work_items/widgets/labels_type_spec.rb' -- './spec/graphql/types/work_items/widgets/start_and_due_date_type_spec.rb' -- './spec/graphql/types/work_items/widgets/start_and_due_date_update_input_type_spec.rb' -- './spec/graphql/types/work_items/widget_type_enum_spec.rb' -- './spec/graphql/types/work_item_type_spec.rb' -- './spec/haml_lint/linter/documentation_links_spec.rb' -- './spec/haml_lint/linter/inline_javascript_spec.rb' -- './spec/haml_lint/linter/no_plain_nodes_spec.rb' - './spec/helpers/access_tokens_helper_spec.rb' - './spec/helpers/admin/application_settings/settings_helper_spec.rb' - './spec/helpers/admin/background_migrations_helper_spec.rb'