From 5a5d5709c79a7ad6980d901428bacede456bf6bd Mon Sep 17 00:00:00 2001 From: Rajendra Kadam <rkadam@gitlab.com> Date: Mon, 19 Jul 2021 11:28:46 +0530 Subject: [PATCH] Change helper text to service ping --- .../metrics_and_profiling/usage_statistics.js | 8 ++++---- .../metrics_and_profiling/usage_statistics_spec.js | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/app/assets/javascripts/pages/admin/application_settings/metrics_and_profiling/usage_statistics.js b/app/assets/javascripts/pages/admin/application_settings/metrics_and_profiling/usage_statistics.js index 9ccb6381a3f0e..bf27b1a81ff9f 100644 --- a/app/assets/javascripts/pages/admin/application_settings/metrics_and_profiling/usage_statistics.js +++ b/app/assets/javascripts/pages/admin/application_settings/metrics_and_profiling/usage_statistics.js @@ -1,10 +1,10 @@ import { __ } from '~/locale'; -export const HELPER_TEXT_USAGE_PING_DISABLED = __( +export const HELPER_TEXT_SERVICE_PING_DISABLED = __( 'To enable Registration Features, make sure "Enable service ping" is checked.', ); -export const HELPER_TEXT_USAGE_PING_ENABLED = __( +export const HELPER_TEXT_SERVICE_PING_ENABLED = __( 'You can enable Registration Features because Service Ping is enabled. To continue using Registration Features in the future, you will also need to register with GitLab via a new cloud licensing service.', ); @@ -18,8 +18,8 @@ function setHelperText(usagePingCheckbox) { ); helperTextId.textContent = usagePingCheckbox.checked - ? HELPER_TEXT_USAGE_PING_ENABLED - : HELPER_TEXT_USAGE_PING_DISABLED; + ? HELPER_TEXT_SERVICE_PING_ENABLED + : HELPER_TEXT_SERVICE_PING_DISABLED; usagePingFeaturesLabel.classList.toggle('gl-cursor-not-allowed', !usagePingCheckbox.checked); diff --git a/spec/frontend/pages/admin/application_settings/metrics_and_profiling/usage_statistics_spec.js b/spec/frontend/pages/admin/application_settings/metrics_and_profiling/usage_statistics_spec.js index 48e51f09c096b..858c7b76ac861 100644 --- a/spec/frontend/pages/admin/application_settings/metrics_and_profiling/usage_statistics_spec.js +++ b/spec/frontend/pages/admin/application_settings/metrics_and_profiling/usage_statistics_spec.js @@ -1,6 +1,6 @@ import initSetHelperText, { - HELPER_TEXT_USAGE_PING_DISABLED, - HELPER_TEXT_USAGE_PING_ENABLED, + HELPER_TEXT_SERVICE_PING_DISABLED, + HELPER_TEXT_SERVICE_PING_ENABLED, } from '~/pages/admin/application_settings/metrics_and_profiling/usage_statistics'; describe('UsageStatistics', () => { @@ -23,12 +23,12 @@ describe('UsageStatistics', () => { const expectEnabledUsagePingFeaturesCheckBox = () => { expect(usagePingFeaturesCheckBox.classList.contains('gl-cursor-not-allowed')).toBe(false); - expect(usagePingFeaturesHelperText.textContent).toEqual(HELPER_TEXT_USAGE_PING_ENABLED); + expect(usagePingFeaturesHelperText.textContent).toEqual(HELPER_TEXT_SERVICE_PING_ENABLED); }; const expectDisabledUsagePingFeaturesCheckBox = () => { expect(usagePingFeaturesLabel.classList.contains('gl-cursor-not-allowed')).toBe(true); - expect(usagePingFeaturesHelperText.textContent).toEqual(HELPER_TEXT_USAGE_PING_DISABLED); + expect(usagePingFeaturesHelperText.textContent).toEqual(HELPER_TEXT_SERVICE_PING_DISABLED); }; describe('Registration Features checkbox', () => { -- GitLab