From 58ceb231fc9366ffb959653486cf193f635fe908 Mon Sep 17 00:00:00 2001
From: Kamil Trzcinski <ayufan@ayufan.eu>
Date: Thu, 2 Mar 2017 20:43:52 +0100
Subject: [PATCH] Use testCases instead of dataList
---
internal/builds/register_test.go | 9 ++++++---
internal/helper/helpers_test.go | 2 +-
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/internal/builds/register_test.go b/internal/builds/register_test.go
index 519738a31bbc..0d03387f0601 100644
--- a/internal/builds/register_test.go
+++ b/internal/builds/register_test.go
@@ -53,10 +53,13 @@ func TestRegisterHandlerInvalidJsonPayload(t *testing.T) {
}
func TestRegisterHandlerMissingData(t *testing.T) {
- dataList := []string{`{"token":"token"}`, `{"last_update":"data"}`}
+ testCases := []string{
+ `{"token":"token"}`,
+ `{"last_update":"data"}`,
+ }
- for _, data := range dataList {
- expectHandler(t, data, "application/json", http.StatusOK,
+ for _, testCase := range testCases {
+ expectHandler(t, testCase, "application/json", http.StatusOK,
"fails on argument validation and proxies request to upstream")
}
}
diff --git a/internal/helper/helpers_test.go b/internal/helper/helpers_test.go
index e816ef68de39..c26766a8655d 100644
--- a/internal/helper/helpers_test.go
+++ b/internal/helper/helpers_test.go
@@ -68,7 +68,7 @@ func TestReadRequestBodyLimit(t *testing.T) {
rw := httptest.NewRecorder()
req, _ := http.NewRequest("POST", "/test", bytes.NewBuffer(data))
- result, err := ReadRequestBody(rw, req, 2)
+ _, err := ReadRequestBody(rw, req, 2)
assert.Error(t, err)
}
--
GitLab