diff --git a/internal/builds/register_test.go b/internal/builds/register_test.go index 519738a31bbc99731e169c7d2e543fb584bb9b2f..0d03387f06011728e5a7f9875ee187003690edf0 100644 --- a/internal/builds/register_test.go +++ b/internal/builds/register_test.go @@ -53,10 +53,13 @@ func TestRegisterHandlerInvalidJsonPayload(t *testing.T) { } func TestRegisterHandlerMissingData(t *testing.T) { - dataList := []string{`{"token":"token"}`, `{"last_update":"data"}`} + testCases := []string{ + `{"token":"token"}`, + `{"last_update":"data"}`, + } - for _, data := range dataList { - expectHandler(t, data, "application/json", http.StatusOK, + for _, testCase := range testCases { + expectHandler(t, testCase, "application/json", http.StatusOK, "fails on argument validation and proxies request to upstream") } } diff --git a/internal/helper/helpers_test.go b/internal/helper/helpers_test.go index e816ef68de39b090603fb7b8b4e1cbafe4dc00a9..c26766a8655d33067863dc1e4730c0c09b3621d0 100644 --- a/internal/helper/helpers_test.go +++ b/internal/helper/helpers_test.go @@ -68,7 +68,7 @@ func TestReadRequestBodyLimit(t *testing.T) { rw := httptest.NewRecorder() req, _ := http.NewRequest("POST", "/test", bytes.NewBuffer(data)) - result, err := ReadRequestBody(rw, req, 2) + _, err := ReadRequestBody(rw, req, 2) assert.Error(t, err) }