From 57a35133e18c43c0c110371c4b3e6012af215a11 Mon Sep 17 00:00:00 2001 From: Aleksei Lipniagov <alipniagov@gitlab.com> Date: Wed, 16 Jun 2021 12:41:37 +0300 Subject: [PATCH] Utilize load balancing for BuildQueueWorker Update BuildQueueWorker to utilize readonly database replicas. Changelog: performance --- app/workers/build_queue_worker.rb | 2 +- .../development/load_balancing_for_build_queue_worker.yml | 8 -------- spec/workers/build_queue_worker_spec.rb | 1 - 3 files changed, 1 insertion(+), 10 deletions(-) delete mode 100644 config/feature_flags/development/load_balancing_for_build_queue_worker.yml diff --git a/app/workers/build_queue_worker.rb b/app/workers/build_queue_worker.rb index aa3c03f773e9a..4ab08bbd7fed7 100644 --- a/app/workers/build_queue_worker.rb +++ b/app/workers/build_queue_worker.rb @@ -10,7 +10,7 @@ class BuildQueueWorker # rubocop:disable Scalability/IdempotentWorker feature_category :continuous_integration urgency :high worker_resource_boundary :cpu - data_consistency :sticky, feature_flag: :load_balancing_for_build_queue_worker + data_consistency :sticky # rubocop: disable CodeReuse/ActiveRecord def perform(build_id) diff --git a/config/feature_flags/development/load_balancing_for_build_queue_worker.yml b/config/feature_flags/development/load_balancing_for_build_queue_worker.yml deleted file mode 100644 index 1b80372ab823b..0000000000000 --- a/config/feature_flags/development/load_balancing_for_build_queue_worker.yml +++ /dev/null @@ -1,8 +0,0 @@ ---- -name: load_balancing_for_build_queue_worker -introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/63212 -rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/332586 -milestone: '14.0' -type: development -group: group::memory -default_enabled: false diff --git a/spec/workers/build_queue_worker_spec.rb b/spec/workers/build_queue_worker_spec.rb index 5f8510abf2303..0786722e64777 100644 --- a/spec/workers/build_queue_worker_spec.rb +++ b/spec/workers/build_queue_worker_spec.rb @@ -26,6 +26,5 @@ it_behaves_like 'worker with data consistency', described_class, - feature_flag: :load_balancing_for_build_queue_worker, data_consistency: :sticky end -- GitLab