From 5134fbf13ff9fe1fa5025bba8f97842371c039ea Mon Sep 17 00:00:00 2001 From: "Sincheol (David) Kim" <dkim@gitlab.com> Date: Wed, 21 Feb 2024 03:40:06 +0000 Subject: [PATCH] Default enable collapse_generated_diff_files feature Changelog: added --- .../development/collapse_generated_diff_files.yml | 2 +- doc/api/merge_requests.md | 1 + doc/user/project/merge_requests/changes.md | 7 +------ 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/config/feature_flags/development/collapse_generated_diff_files.yml b/config/feature_flags/development/collapse_generated_diff_files.yml index 5d5cf5d98a0bf..0992f0d7e7b28 100644 --- a/config/feature_flags/development/collapse_generated_diff_files.yml +++ b/config/feature_flags/development/collapse_generated_diff_files.yml @@ -5,4 +5,4 @@ rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/432670 milestone: '16.7' type: development group: group::code review -default_enabled: false +default_enabled: true diff --git a/doc/api/merge_requests.md b/doc/api/merge_requests.md index ab3be2a8cb80d..51508c8ea3792 100644 --- a/doc/api/merge_requests.md +++ b/doc/api/merge_requests.md @@ -1118,6 +1118,7 @@ Example response: ## List merge request diffs > - `generated_file` was [introduced](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/141576) in GitLab 16.9 [with a flag](../administration/feature_flags.md) named `collapse_generated_diff_files`. Disabled by default. +> - [Enabled on GitLab.com and self-managed](https://gitlab.com/gitlab-org/gitlab/-/issues/432670) in GitLab 16.10. List diffs of the files changed in a merge request. diff --git a/doc/user/project/merge_requests/changes.md b/doc/user/project/merge_requests/changes.md index efb01316dcfa4..48b63140e5a9e 100644 --- a/doc/user/project/merge_requests/changes.md +++ b/doc/user/project/merge_requests/changes.md @@ -68,12 +68,7 @@ DETAILS: **Offering:** Self-managed > - [Introduced](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/140180) in GitLab 16.8 [with a flag](../../../administration/feature_flags.md) named `collapse_generated_diff_files`. Disabled by default. - -FLAG: -On self-managed GitLab, by default this feature is not available. To make it available, -an administrator can [enable the feature flag](../../../administration/feature_flags.md) -named `collapse_generated_diff_files`. -On GitLab.com, this feature is not available. +> - [Enabled on GitLab.com and self-managed](https://gitlab.com/gitlab-org/gitlab/-/issues/432670) in GitLab 16.10. To help reviewers focus on the files needed to perform a code review, GitLab collapses several common types of generated files. These files are collapsed by default, because -- GitLab