From 511b9a876b9a2e5ab8294b7f56a004bba99f2e04 Mon Sep 17 00:00:00 2001
From: Marcel Amirault <mamirault@gitlab.com>
Date: Wed, 27 Jul 2022 17:08:27 +0900
Subject: [PATCH] Fix deprecation and removal for cobertura keyword
The change is a breaking change, but the deprecation
and removal show breaking_change: false
---
data/deprecations/14-7-deprecate-artifacts-keyword.yml | 2 +-
data/removals/15_0/15-0-removal-artifacts-keyword.yml | 2 +-
doc/update/deprecations.md | 6 +++++-
doc/update/removals.md | 4 ++++
4 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/data/deprecations/14-7-deprecate-artifacts-keyword.yml b/data/deprecations/14-7-deprecate-artifacts-keyword.yml
index 29b5ec39193d..26fd6b485df2 100644
--- a/data/deprecations/14-7-deprecate-artifacts-keyword.yml
+++ b/data/deprecations/14-7-deprecate-artifacts-keyword.yml
@@ -3,7 +3,7 @@
announcement_date: "2022-01-22"
removal_milestone: "15.0"
removal_date: "2022-05-22"
- breaking_change: false
+ breaking_change: true
body: |
Currently, test coverage visualizations in GitLab only support Cobertura reports. Starting 15.0, the
`artifacts:reports:cobertura` keyword will be replaced by
diff --git a/data/removals/15_0/15-0-removal-artifacts-keyword.yml b/data/removals/15_0/15-0-removal-artifacts-keyword.yml
index 29edd922eae6..15c9a5ee27ad 100644
--- a/data/removals/15_0/15-0-removal-artifacts-keyword.yml
+++ b/data/removals/15_0/15-0-removal-artifacts-keyword.yml
@@ -3,7 +3,7 @@
announcement_date: "2022-02-22"
removal_milestone: "15.0"
removal_date: "2022-05-22"
- breaking_change: false
+ breaking_change: true
body: |
As of GitLab 15.0, the [`artifacts:reports:cobertura`](https://docs.gitlab.com/ee/ci/yaml/artifacts_reports.html#artifactsreportscobertura-removed)
keyword has been [replaced](https://gitlab.com/gitlab-org/gitlab/-/issues/344533) by
diff --git a/doc/update/deprecations.md b/doc/update/deprecations.md
index a99ea1a3ef4e..39ed17067e36 100644
--- a/doc/update/deprecations.md
+++ b/doc/update/deprecations.md
@@ -1496,12 +1496,16 @@ Tracing in GitLab is an integration with Jaeger, an open-source end-to-end distr
</div>
-<div class="deprecation removal-150">
+<div class="deprecation removal-150 breaking-change">
### `artifacts:reports:cobertura` keyword
Planned removal: GitLab <span class="removal-milestone">15.0</span> (2022-05-22)
+WARNING:
+This is a [breaking change](https://docs.gitlab.com/ee/development/contributing/#breaking-changes).
+Review the details carefully before upgrading.
+
Currently, test coverage visualizations in GitLab only support Cobertura reports. Starting 15.0, the
`artifacts:reports:cobertura` keyword will be replaced by
[`artifacts:reports:coverage_report`](https://gitlab.com/gitlab-org/gitlab/-/issues/344533). Cobertura will be the
diff --git a/doc/update/removals.md b/doc/update/removals.md
index fa5c016d3ab2..841b96f59b8a 100644
--- a/doc/update/removals.md
+++ b/doc/update/removals.md
@@ -621,6 +621,10 @@ The `Managed-Cluster-Applications.gitlab-ci.yml` CI/CD template is being removed
### `artifacts:reports:cobertura` keyword
+WARNING:
+This is a [breaking change](https://docs.gitlab.com/ee/development/contributing/#breaking-changes).
+Review the details carefully before upgrading.
+
As of GitLab 15.0, the [`artifacts:reports:cobertura`](https://docs.gitlab.com/ee/ci/yaml/artifacts_reports.html#artifactsreportscobertura-removed)
keyword has been [replaced](https://gitlab.com/gitlab-org/gitlab/-/issues/344533) by
[`artifacts:reports:coverage_report`](https://docs.gitlab.com/ee/ci/yaml/artifacts_reports.html#artifactsreportscoverage_report).
--
GitLab