diff --git a/.gitlab/CODEOWNERS b/.gitlab/CODEOWNERS index b42a8039f4750b2880e657ae2efec8bb362b2a88..99bab9a26483e7e92b3df2744011848f60857513 100644 --- a/.gitlab/CODEOWNERS +++ b/.gitlab/CODEOWNERS @@ -1369,7 +1369,6 @@ lib/gitlab/checks/** /app/views/projects/pipelines/ /app/views/projects/triggers/ /app/workers/build_queue_worker.rb -/app/workers/build_success_worker.rb /app/workers/ci_platform_metrics_update_cron_worker.rb /app/workers/create_pipeline_worker.rb /app/workers/expire_build_artifacts_worker.rb diff --git a/.rubocop_todo/gitlab/namespaced_class.yml b/.rubocop_todo/gitlab/namespaced_class.yml index d535eded4d15b820a7c08f737708a2cdd3b4d32f..af578c4c1d137efe3adb6643d287aeffdbd27054 100644 --- a/.rubocop_todo/gitlab/namespaced_class.yml +++ b/.rubocop_todo/gitlab/namespaced_class.yml @@ -712,7 +712,6 @@ Gitlab/NamespacedClass: - 'app/workers/auto_merge_process_worker.rb' - 'app/workers/background_migration_worker.rb' - 'app/workers/build_queue_worker.rb' - - 'app/workers/build_success_worker.rb' - 'app/workers/bulk_import_worker.rb' - 'app/workers/chat_notification_worker.rb' - 'app/workers/ci_platform_metrics_update_cron_worker.rb' diff --git a/.rubocop_todo/sidekiq_load_balancing/worker_data_consistency.yml b/.rubocop_todo/sidekiq_load_balancing/worker_data_consistency.yml index c49d40401262c7e7eddf36f938e6e25e839b5868..8a3919d016087fb06647ba5ba6948d541f2d445e 100644 --- a/.rubocop_todo/sidekiq_load_balancing/worker_data_consistency.yml +++ b/.rubocop_todo/sidekiq_load_balancing/worker_data_consistency.yml @@ -12,7 +12,6 @@ SidekiqLoadBalancing/WorkerDataConsistency: - 'app/workers/authorized_projects_worker.rb' - 'app/workers/auto_devops/disable_worker.rb' - 'app/workers/auto_merge_process_worker.rb' - - 'app/workers/build_success_worker.rb' - 'app/workers/bulk_import_worker.rb' - 'app/workers/bulk_imports/entity_worker.rb' - 'app/workers/bulk_imports/export_request_worker.rb' diff --git a/.rubocop_todo/style/inline_disable_annotation.yml b/.rubocop_todo/style/inline_disable_annotation.yml index 523d93fd9bb94bed7a0a4fa8bfe6ac69a8e2accd..d890a1a65d7b59ff6a19525a78d28521172f7f56 100644 --- a/.rubocop_todo/style/inline_disable_annotation.yml +++ b/.rubocop_todo/style/inline_disable_annotation.yml @@ -789,7 +789,6 @@ Style/InlineDisableAnnotation: - 'app/workers/background_migration_worker.rb' - 'app/workers/batched_git_ref_updates/cleanup_scheduler_worker.rb' - 'app/workers/build_queue_worker.rb' - - 'app/workers/build_success_worker.rb' - 'app/workers/bulk_imports/finish_batched_pipeline_worker.rb' - 'app/workers/bulk_imports/pipeline_batch_worker.rb' - 'app/workers/bulk_imports/pipeline_worker.rb' diff --git a/app/workers/all_queues.yml b/app/workers/all_queues.yml index 4affed6ddfcdd21a837b47b46b77967caa808258..d9ebf30f9e0031cfefe7fe3a46003fd90161f1a0 100644 --- a/app/workers/all_queues.yml +++ b/app/workers/all_queues.yml @@ -2145,15 +2145,6 @@ :weight: 5 :idempotent: false :tags: [] -- :name: pipeline_processing:build_success - :worker_name: BuildSuccessWorker - :feature_category: :continuous_integration - :has_external_dependencies: false - :urgency: :high - :resource_boundary: :unknown - :weight: 5 - :idempotent: false - :tags: [] - :name: pipeline_processing:ci_build_finished :worker_name: Ci::BuildFinishedWorker :feature_category: :continuous_integration diff --git a/app/workers/build_success_worker.rb b/app/workers/build_success_worker.rb deleted file mode 100644 index b937dbf298a214800f6ad509268b27de61dc0cda..0000000000000000000000000000000000000000 --- a/app/workers/build_success_worker.rb +++ /dev/null @@ -1,17 +0,0 @@ -# frozen_string_literal: true - -# Deprecated and will be removed in 17.0. -# Use `Environments::StopJobSuccessWorker` instead. -class BuildSuccessWorker # rubocop:disable Scalability/IdempotentWorker - include ApplicationWorker - - data_consistency :always - - sidekiq_options retry: 3 - include PipelineQueue - - queue_namespace :pipeline_processing - urgency :high - - def perform(build_id); end -end diff --git a/spec/workers/every_sidekiq_worker_spec.rb b/spec/workers/every_sidekiq_worker_spec.rb index 6a022e3dad7557e8f2b91171f886f4cd71698abc..80ac02ab4f5014105eecb60a15014d573ca2a858 100644 --- a/spec/workers/every_sidekiq_worker_spec.rb +++ b/spec/workers/every_sidekiq_worker_spec.rb @@ -135,7 +135,6 @@ 'BackgroundMigrationWorker' => 3, 'BackgroundMigration::CiDatabaseWorker' => 3, 'BuildQueueWorker' => 3, - 'BuildSuccessWorker' => 3, 'BulkImportWorker' => 3, 'BulkImports::ExportRequestWorker' => 5, 'BulkImports::EntityWorker' => 3,