diff --git a/.rubocop_todo/capybara/visibility_matcher.yml b/.rubocop_todo/capybara/visibility_matcher.yml
index c75c165331441785a20a49c7871c0ac2574ce723..62f20efd8a696c8e9bc671dd40ffad844d8cf61e 100644
--- a/.rubocop_todo/capybara/visibility_matcher.yml
+++ b/.rubocop_todo/capybara/visibility_matcher.yml
@@ -7,7 +7,6 @@ Capybara/VisibilityMatcher:
- 'ee/spec/features/epics/update_epic_spec.rb'
- 'ee/spec/features/groups/analytics/cycle_analytics/filters_and_data_spec.rb'
- 'ee/spec/features/groups/issues_spec.rb'
- - 'ee/spec/features/groups/settings/protected_environments_spec.rb'
- 'ee/spec/features/issues/related_issues_spec.rb'
- 'ee/spec/features/projects/settings/ee/repository_mirrors_settings_spec.rb'
- 'ee/spec/features/promotion_spec.rb'
diff --git a/.rubocop_todo/database/avoid_using_pluck_without_limit.yml b/.rubocop_todo/database/avoid_using_pluck_without_limit.yml
index 7304b7479f4bf33620b0e807f8ca0be9c6870078..a430ea735ef8a4a3adf7fa7b6426718cf1de3a39 100644
--- a/.rubocop_todo/database/avoid_using_pluck_without_limit.yml
+++ b/.rubocop_todo/database/avoid_using_pluck_without_limit.yml
@@ -145,8 +145,6 @@ Database/AvoidUsingPluckWithoutLimit:
- 'ee/app/services/epics/update_dates_service.rb'
- 'ee/app/services/gitlab_subscriptions/preview_billable_user_change_service.rb'
- 'ee/app/services/security/merge_request_security_report_generation_service.rb'
- - 'ee/app/services/security/scan_result_policies/sync_any_merge_request_rules_service.rb'
- - 'ee/app/services/security/scan_result_policies/update_approvals_service.rb'
- 'ee/app/services/security/security_orchestration_policies/default_branch_updation_check_service.rb'
- 'ee/app/services/security/security_orchestration_policies/fetch_policy_approvers_service.rb'
- 'ee/app/services/security/security_orchestration_policies/policy_branches_service.rb'
diff --git a/.rubocop_todo/gettext/static_identifier.yml b/.rubocop_todo/gettext/static_identifier.yml
index af2c0d3c5e365c1cf2415199bc5cadff6d9d4f1a..939ec830ddabecf72673b27ef07a6b97b538fd75 100644
--- a/.rubocop_todo/gettext/static_identifier.yml
+++ b/.rubocop_todo/gettext/static_identifier.yml
@@ -2,16 +2,13 @@
Gettext/StaticIdentifier:
Exclude:
- 'app/graphql/types/project_type.rb'
- - 'app/models/integrations/apple_app_store.rb'
- 'app/models/integrations/confluence.rb'
- - 'app/models/integrations/google_play.rb'
- 'app/services/import/fogbugz_service.rb'
- 'app/services/issuable_links/create_service.rb'
- 'app/services/issues/set_crm_contacts_service.rb'
- 'app/services/projects/create_from_template_service.rb'
- 'app/services/security/ci_configuration/base_create_service.rb'
- 'app/services/users/banned_user_base_service.rb'
- - 'ee/app/controllers/admin/licenses_controller.rb'
- 'ee/app/mailers/ee/emails/admin_notification.rb'
- 'ee/app/mailers/emails/namespace_storage_usage_mailer.rb'
- 'ee/app/models/integrations/github.rb'
diff --git a/.rubocop_todo/gitlab/avoid_current_organization.yml b/.rubocop_todo/gitlab/avoid_current_organization.yml
index 59158f4ddf96e18b79f4dd1cc15d88d6bc456847..e5e11026f33e61a287ee108e570695365911f4a3 100644
--- a/.rubocop_todo/gitlab/avoid_current_organization.yml
+++ b/.rubocop_todo/gitlab/avoid_current_organization.yml
@@ -2,6 +2,5 @@
Gitlab/AvoidCurrentOrganization:
Details: grace period
Exclude:
- - 'app/services/snippets/create_service.rb'
- 'lib/gitlab/current_settings.rb'
- 'lib/gitlab/github_gists_import/importer/gist_importer.rb'
diff --git a/.rubocop_todo/gitlab/avoid_gitlab_instance_checks.yml b/.rubocop_todo/gitlab/avoid_gitlab_instance_checks.yml
index b2535c448161f2b29c27300ec64ac0e69bb237c9..0f72a56fbf8f5445ddd6b8c160e7d187494d8668 100644
--- a/.rubocop_todo/gitlab/avoid_gitlab_instance_checks.yml
+++ b/.rubocop_todo/gitlab/avoid_gitlab_instance_checks.yml
@@ -6,7 +6,6 @@ Gitlab/AvoidGitlabInstanceChecks:
- 'app/helpers/application_settings_helper.rb'
- 'app/helpers/groups_helper.rb'
- 'app/helpers/integrations_helper.rb'
- - 'app/helpers/packages_helper.rb'
- 'app/helpers/projects_helper.rb'
- 'app/helpers/sidebars_helper.rb'
- 'app/helpers/users/callouts_helper.rb'
@@ -15,7 +14,6 @@ Gitlab/AvoidGitlabInstanceChecks:
- 'app/models/ci/build.rb'
- 'app/models/ci/runner.rb'
- 'app/models/concerns/protected_ref_access.rb'
- - 'app/models/container_repository.rb'
- 'app/models/integrations/jira.rb'
- 'app/models/member.rb'
- 'app/models/namespace.rb'
diff --git a/.rubocop_todo/gitlab/bounded_contexts.yml b/.rubocop_todo/gitlab/bounded_contexts.yml
index 1344216ad6b39c46bfaedcb3c446f0ebd1f575f1..160362540f5bbad76d958b5f0e134b8688d83718 100644
--- a/.rubocop_todo/gitlab/bounded_contexts.yml
+++ b/.rubocop_todo/gitlab/bounded_contexts.yml
@@ -556,10 +556,6 @@ Gitlab/BoundedContexts:
- 'app/graphql/types/noteable_type.rb'
- 'app/graphql/types/pages_deployment_type.rb'
- 'app/graphql/types/permission_types/base_permission_type.rb'
- - 'app/graphql/types/permission_types/ci/job.rb'
- - 'app/graphql/types/permission_types/ci/pipeline.rb'
- - 'app/graphql/types/permission_types/ci/pipeline_schedules.rb'
- - 'app/graphql/types/permission_types/ci/runner.rb'
- 'app/graphql/types/permission_types/container_repository.rb'
- 'app/graphql/types/permission_types/container_repository_tag.rb'
- 'app/graphql/types/permission_types/custom_emoji.rb'
@@ -1772,8 +1768,6 @@ Gitlab/BoundedContexts:
- 'app/services/remote_mirrors/sync_service.rb'
- 'app/services/repository_archive_clean_up_service.rb'
- 'app/services/reset_project_cache_service.rb'
- - 'app/services/resource_access_tokens/create_service.rb'
- - 'app/services/resource_access_tokens/revoke_service.rb'
- 'app/services/resource_events/base_change_timebox_service.rb'
- 'app/services/resource_events/base_synthetic_notes_builder_service.rb'
- 'app/services/resource_events/change_labels_service.rb'
@@ -1823,15 +1817,6 @@ Gitlab/BoundedContexts:
- 'app/services/timelogs/create_service.rb'
- 'app/services/timelogs/delete_service.rb'
- 'app/services/todo_service.rb'
- - 'app/services/todos/allowed_target_filter_service.rb'
- - 'app/services/todos/destroy/base_service.rb'
- - 'app/services/todos/destroy/confidential_issue_service.rb'
- - 'app/services/todos/destroy/design_service.rb'
- - 'app/services/todos/destroy/destroyed_issuable_service.rb'
- - 'app/services/todos/destroy/entity_leave_service.rb'
- - 'app/services/todos/destroy/group_private_service.rb'
- - 'app/services/todos/destroy/project_private_service.rb'
- - 'app/services/todos/destroy/unauthorized_features_service.rb'
- 'app/services/topics/merge_service.rb'
- 'app/services/two_factor/base_service.rb'
- 'app/services/two_factor/destroy_otp_service.rb'
@@ -2571,7 +2556,6 @@ Gitlab/BoundedContexts:
- 'ee/app/graphql/types/pending_group_member_type.rb'
- 'ee/app/graphql/types/permission_types/dast_site_profile.rb'
- 'ee/app/graphql/types/permission_types/epic.rb'
- - 'ee/app/graphql/types/permission_types/merge_trains/car.rb'
- 'ee/app/graphql/types/permission_types/pipeline_security_report_finding.rb'
- 'ee/app/graphql/types/permission_types/requirement.rb'
- 'ee/app/graphql/types/permission_types/vulnerability.rb'
@@ -2774,7 +2758,6 @@ Gitlab/BoundedContexts:
- 'ee/app/models/concerns/ee/mentionable.rb'
- 'ee/app/models/concerns/ee/mentionable/reference_regexes.rb'
- 'ee/app/models/concerns/ee/milestoneable.rb'
- - 'ee/app/models/concerns/ee/noteable.rb'
- 'ee/app/models/concerns/ee/participable.rb'
- 'ee/app/models/concerns/ee/project_features_compatibility.rb'
- 'ee/app/models/concerns/ee/project_security_scanners_information.rb'
@@ -3278,8 +3261,6 @@ Gitlab/BoundedContexts:
- 'ee/app/services/ee/protected_refs/access_level_params.rb'
- 'ee/app/services/ee/quick_actions/interpret_service.rb'
- 'ee/app/services/ee/quick_actions/target_service.rb'
- - 'ee/app/services/ee/resource_access_tokens/create_service.rb'
- - 'ee/app/services/ee/resource_access_tokens/revoke_service.rb'
- 'ee/app/services/ee/resource_events/change_labels_service.rb'
- 'ee/app/services/ee/resource_events/merge_into_notes_service.rb'
- 'ee/app/services/ee/resource_events/synthetic_iteration_notes_builder_service.rb'
@@ -3290,7 +3271,6 @@ Gitlab/BoundedContexts:
- 'ee/app/services/ee/system_notes/issuables_service.rb'
- 'ee/app/services/ee/system_notes/merge_requests_service.rb'
- 'ee/app/services/ee/todo_service.rb'
- - 'ee/app/services/ee/todos/destroy/entity_leave_service.rb'
- 'ee/app/services/ee/two_factor/destroy_service.rb'
- 'ee/app/services/ee/verify_pages_domain_service.rb'
- 'ee/app/services/ee/wiki_pages/base_service.rb'
@@ -3435,8 +3415,8 @@ Gitlab/BoundedContexts:
- 'ee/app/services/package_metadata/ingestion/compressed_package/ingestion_service.rb'
- 'ee/app/services/package_metadata/ingestion/compressed_package/license_ingestion_task.rb'
- 'ee/app/services/package_metadata/ingestion/compressed_package/package_ingestion_task.rb'
- - 'ee/app/services/package_metadata/ingestion/cve_enrichment/ingestion_service.rb'
- 'ee/app/services/package_metadata/ingestion/cve_enrichment/cve_enrichment_ingestion_task.rb'
+ - 'ee/app/services/package_metadata/ingestion/cve_enrichment/ingestion_service.rb'
- 'ee/app/services/package_metadata/ingestion/data_map.rb'
- 'ee/app/services/package_metadata/ingestion/ingestion_service.rb'
- 'ee/app/services/package_metadata/ingestion/tasks/base.rb'
@@ -3497,7 +3477,6 @@ Gitlab/BoundedContexts:
- 'ee/app/services/timebox/event_aggregation_service.rb'
- 'ee/app/services/timebox/report_service.rb'
- 'ee/app/services/timebox_report_service.rb'
- - 'ee/app/services/todos/destroy/confidential_epic_service.rb'
- 'ee/app/services/user_permissions/export_service.rb'
- 'ee/app/services/users_ops_dashboard_projects/base_service.rb'
- 'ee/app/services/users_ops_dashboard_projects/destroy_service.rb'
@@ -3516,7 +3495,6 @@ Gitlab/BoundedContexts:
- 'ee/app/services/vulnerability_scanners/list_service.rb'
- 'ee/app/uploaders/ee/object_storage.rb'
- 'ee/app/validators/ee/json_schema_validator.rb'
- - 'ee/app/validators/host_validator.rb'
- 'ee/app/validators/ldap_filter_validator.rb'
- 'ee/app/validators/password/complexity_validator.rb'
- 'ee/app/validators/user_existence_validator.rb'
diff --git a/.rubocop_todo/gitlab/feature_available_usage.yml b/.rubocop_todo/gitlab/feature_available_usage.yml
index bfdfba161363ca6fd127e1822efbdbb2c524bc2b..0c9b5d3b38dd31ca25441e7c8796bfc17178586e 100644
--- a/.rubocop_todo/gitlab/feature_available_usage.yml
+++ b/.rubocop_todo/gitlab/feature_available_usage.yml
@@ -90,7 +90,6 @@ Gitlab/FeatureAvailableUsage:
- 'ee/app/workers/group_saml_group_sync_worker.rb'
- 'ee/lib/ee/api/entities/approval_state.rb'
- 'ee/lib/ee/api/entities/board.rb'
- - 'ee/lib/ee/api/entities/issue.rb'
- 'ee/lib/ee/api/entities/project.rb'
- 'ee/lib/ee/api/helpers.rb'
- 'ee/lib/ee/api/projects.rb'
diff --git a/.rubocop_todo/gitlab/feature_flag_without_actor.yml b/.rubocop_todo/gitlab/feature_flag_without_actor.yml
index 6f57316c204c9ff86cee604413ad0ea546794412..afa8e6b8b47923fb0d05503b1ff0eb8dafea4e4b 100644
--- a/.rubocop_todo/gitlab/feature_flag_without_actor.yml
+++ b/.rubocop_todo/gitlab/feature_flag_without_actor.yml
@@ -27,13 +27,11 @@ Gitlab/FeatureFlagWithoutActor:
- 'app/graphql/types/project_type.rb'
- 'app/helpers/auto_devops_helper.rb'
- 'app/helpers/bizible_helper.rb'
- - 'app/helpers/environments_helper.rb'
- 'app/helpers/one_trust_helper.rb'
- 'app/helpers/projects/topics_helper.rb'
- 'app/helpers/projects_helper.rb'
- 'app/helpers/routing/pseudonymization_helper.rb'
- 'app/models/ci/pipeline.rb'
- - 'app/models/ci/runner.rb'
- 'app/models/ci/secure_file.rb'
- 'app/models/clusters/instance.rb'
- 'app/models/concerns/counter_attribute.rb'
@@ -49,15 +47,11 @@ Gitlab/FeatureFlagWithoutActor:
- 'app/models/snippet.rb'
- 'app/models/user.rb'
- 'app/policies/project_policy.rb'
- - 'app/presenters/blob_presenter.rb'
- 'app/presenters/ci/build_runner_presenter.rb'
- - 'app/presenters/projects/security/configuration_presenter.rb'
- 'app/serializers/admin/abuse_report_entity.rb'
- 'app/serializers/web_ide_terminal_entity.rb'
- 'app/services/ci/job_artifacts/update_unknown_locked_status_service.rb'
- - 'app/services/ci/queue/pending_builds_strategy.rb'
- 'app/services/ci/register_job_service.rb'
- - 'app/services/ci/stuck_builds/drop_running_service.rb'
- 'app/services/click_house/sync_strategies/audit_event_sync_strategy.rb'
- 'app/services/concerns/measurable.rb'
- 'app/services/groups/participants_service.rb'
@@ -101,7 +95,6 @@ Gitlab/FeatureFlagWithoutActor:
- 'ee/app/controllers/ee/admin/application_settings_controller.rb'
- 'ee/app/controllers/ee/omniauth_callbacks_controller.rb'
- 'ee/app/controllers/groups/billings_controller.rb'
- - 'ee/app/controllers/users/base_identity_verification_controller.rb'
- 'ee/app/finders/ee/merge_requests_finder.rb'
- 'ee/app/graphql/resolvers/ai/code_suggestions_access_resolver.rb'
- 'ee/app/graphql/resolvers/ai/user_chat_access_resolver.rb'
@@ -113,7 +106,6 @@ Gitlab/FeatureFlagWithoutActor:
- 'ee/app/models/ee/integration.rb'
- 'ee/app/models/integrations/git_guardian.rb'
- 'ee/app/models/namespaces/free_user_cap/root_size.rb'
- - 'ee/app/models/search/zoekt.rb'
- 'ee/app/policies/ee/global_policy.rb'
- 'ee/app/policies/ee/project_policy.rb'
- 'ee/app/policies/ee/user_policy.rb'
@@ -121,12 +113,10 @@ Gitlab/FeatureFlagWithoutActor:
- 'ee/app/presenters/ee/project_presenter.rb'
- 'ee/app/services/ee/notification_service.rb'
- 'ee/app/services/ee/users/build_service.rb'
- - 'ee/app/services/geo/framework_repository_sync_service.rb'
- 'ee/app/services/gitlab_subscriptions/fetch_subscription_plans_service.rb'
- 'ee/app/services/llm/chat_service.rb'
- 'ee/app/services/phone_verification/telesign_client/risk_score_service.rb'
- 'ee/app/services/phone_verification/users/rate_limit_service.rb'
- - 'ee/app/services/phone_verification/users/record_user_data_service.rb'
- 'ee/app/services/phone_verification/users/send_verification_code_service.rb'
- 'ee/app/services/search/zoekt/scheduling_service.rb'
- 'ee/app/views/admin/application_settings/_ee_package_registry.haml'
@@ -136,8 +126,6 @@ Gitlab/FeatureFlagWithoutActor:
- 'ee/app/views/admin/geo/shared/_replication_nav.haml'
- 'ee/app/views/projects/on_demand_scans/index.html.haml'
- 'ee/app/views/projects/settings/merge_requests/_merge_trains_settings.html.haml'
- - 'ee/app/workers/elastic/migration_worker.rb'
- - 'ee/app/workers/gitlab_subscriptions/add_on_purchases/schedule_bulk_refresh_user_assignments_worker.rb'
- 'ee/app/workers/search/index_curation_worker.rb'
- 'ee/app/workers/search/zoekt/scheduling_worker.rb'
- 'ee/app/workers/security/scan_execution_policies/create_pipeline_worker.rb'
@@ -155,7 +143,6 @@ Gitlab/FeatureFlagWithoutActor:
- 'ee/lib/ee/gitlab/git_access.rb'
- 'ee/lib/gitlab/elastic/bulk_indexer.rb'
- 'ee/lib/gitlab/elastic/client.rb'
- - 'ee/lib/gitlab/elastic/document_reference.rb'
- 'ee/lib/gitlab/elastic/indexer.rb'
- 'ee/lib/gitlab/geo/replication/blob_downloader.rb'
- 'ee/lib/gitlab/geo/replicator.rb'
@@ -170,14 +157,12 @@ Gitlab/FeatureFlagWithoutActor:
- 'ee/spec/lib/gitlab/product_analytics/developments/setup_spec.rb'
- 'ee/spec/models/gitlab_subscriptions/features_spec.rb'
- 'lib/api/features.rb'
- - 'lib/api/helpers/internal_helpers.rb'
- 'lib/api/helpers/packages/dependency_proxy_helpers.rb'
- 'lib/api/integrations.rb'
- 'lib/api/internal/base.rb'
- 'lib/api/markdown.rb'
- 'lib/api/pagination_params.rb'
- 'lib/api/repositories.rb'
- - 'lib/api/support/git_access_actor.rb'
- 'lib/api/usage_data_non_sql_metrics.rb'
- 'lib/api/usage_data_queries.rb'
- 'lib/banzai/filter/references/user_reference_filter.rb'
@@ -211,7 +196,6 @@ Gitlab/FeatureFlagWithoutActor:
- 'lib/gitlab/gitaly_client/commit_service.rb'
- 'lib/gitlab/grape_logging/loggers/response_logger.rb'
- 'lib/gitlab/internal_events.rb'
- - 'lib/gitlab/json.rb'
- 'lib/gitlab/lograge/custom_options.rb'
- 'lib/gitlab/memory/reports/heap_dump.rb'
- 'lib/gitlab/memory/reports/jemalloc_stats.rb'
diff --git a/.rubocop_todo/gitlab/namespaced_class.yml b/.rubocop_todo/gitlab/namespaced_class.yml
index 46cdd5dcaf5872fc39e847f6ccd33171c172683a..db3d2be7ec48bc66094714c391209fa019631b2e 100644
--- a/.rubocop_todo/gitlab/namespaced_class.yml
+++ b/.rubocop_todo/gitlab/namespaced_class.yml
@@ -853,7 +853,6 @@ Gitlab/NamespacedClass:
- 'ee/app/models/board_label.rb'
- 'ee/app/models/board_user_preference.rb'
- 'ee/app/models/burndown.rb'
- - 'ee/app/models/click_house_model.rb'
- 'ee/app/models/dast_scanner_profile.rb'
- 'ee/app/models/dast_site.rb'
- 'ee/app/models/dast_site_profile.rb'
@@ -986,7 +985,6 @@ Gitlab/NamespacedClass:
- 'ee/app/services/ldap_group_reset_service.rb'
- 'ee/app/services/start_pull_mirroring_service.rb'
- 'ee/app/services/timebox_report_service.rb'
- - 'ee/app/validators/host_validator.rb'
- 'ee/app/validators/ldap_filter_validator.rb'
- 'ee/app/workers/active_user_count_threshold_worker.rb'
- 'ee/app/workers/adjourned_group_deletion_worker.rb'
diff --git a/.rubocop_todo/gitlab/no_find_in_workers.yml b/.rubocop_todo/gitlab/no_find_in_workers.yml
index d407df5da09b96cf19da380f281312e2c6665263..883f7fa8968c0f99e29489ea1af21e5abfda31ce 100644
--- a/.rubocop_todo/gitlab/no_find_in_workers.yml
+++ b/.rubocop_todo/gitlab/no_find_in_workers.yml
@@ -65,7 +65,6 @@ Gitlab/NoFindInWorkers:
- 'app/workers/upload_checksum_worker.rb'
- 'app/workers/wikis/git_garbage_collect_worker.rb'
- 'app/workers/work_items/import_work_items_csv_worker.rb'
- - 'ee/app/workers/abuse/new_abuse_report_worker.rb'
- 'ee/app/workers/adjourned_project_deletion_worker.rb'
- 'ee/app/workers/admin_emails_worker.rb'
- 'ee/app/workers/analytics/devops_adoption/create_snapshot_worker.rb'
@@ -93,4 +92,3 @@ Gitlab/NoFindInWorkers:
- 'ee/app/workers/requirements_management/import_requirements_csv_worker.rb'
- 'ee/app/workers/search/zoekt/namespace_indexer_worker.rb'
- 'ee/app/workers/work_items/rolledup_dates/bulk_update_handler.rb'
- - 'ee/app/workers/work_items/rolledup_dates/update_rolledup_dates_worker.rb'
diff --git a/.rubocop_todo/gitlab/rails/safe_format.yml b/.rubocop_todo/gitlab/rails/safe_format.yml
index d8dc42c272bdb48f03fa8dfc5975566e828a4ccd..7f566f73b151048e13d6fb228fcbdc48f24e6158 100644
--- a/.rubocop_todo/gitlab/rails/safe_format.yml
+++ b/.rubocop_todo/gitlab/rails/safe_format.yml
@@ -15,27 +15,7 @@ Gitlab/Rails/SafeFormat:
- 'app/helpers/search_helper.rb'
- 'app/helpers/sourcegraph_helper.rb'
- 'app/helpers/whats_new_helper.rb'
- - 'app/models/integrations/apple_app_store.rb'
- - 'app/models/integrations/asana.rb'
- - 'app/models/integrations/bamboo.rb'
- 'app/models/integrations/beyond_identity.rb'
- - 'app/models/integrations/bugzilla.rb'
- - 'app/models/integrations/clickup.rb'
- - 'app/models/integrations/confluence.rb'
- - 'app/models/integrations/custom_issue_tracker.rb'
- - 'app/models/integrations/datadog.rb'
- - 'app/models/integrations/discord.rb'
- - 'app/models/integrations/ewm.rb'
- - 'app/models/integrations/external_wiki.rb'
- - 'app/models/integrations/google_play.rb'
- - 'app/models/integrations/hangouts_chat.rb'
- - 'app/models/integrations/irker.rb'
- - 'app/models/integrations/jenkins.rb'
- - 'app/models/integrations/mattermost.rb'
- - 'app/models/integrations/pivotaltracker.rb'
- - 'app/models/integrations/redmine.rb'
- - 'app/models/integrations/unify_circuit.rb'
- - 'app/models/integrations/youtrack.rb'
- 'app/services/jira/requests/base.rb'
- 'app/services/security/ci_configuration/base_create_service.rb'
- 'ee/app/components/namespaces/free_user_cap/enforcement_alert_component.rb'
diff --git a/.rubocop_todo/gitlab/strong_memoize_attr.yml b/.rubocop_todo/gitlab/strong_memoize_attr.yml
index 7d4332cce1a08302f5eb2de9cde95cca8b423962..3deca08d68a66c63aac3a1e94b94ed2756b0c543 100644
--- a/.rubocop_todo/gitlab/strong_memoize_attr.yml
+++ b/.rubocop_todo/gitlab/strong_memoize_attr.yml
@@ -38,7 +38,6 @@ Gitlab/StrongMemoizeAttr:
- 'app/finders/ci/pipelines_for_merge_request_finder.rb'
- 'app/finders/cluster_ancestors_finder.rb'
- 'app/finders/concerns/finder_with_group_hierarchy.rb'
- - 'app/finders/crm/contacts_finder.rb'
- 'app/finders/crm/organizations_finder.rb'
- 'app/finders/groups/accepting_group_transfers_finder.rb'
- 'app/finders/issuable_finder.rb'
@@ -256,8 +255,8 @@ Gitlab/StrongMemoizeAttr:
- 'ee/app/helpers/ee/ci/runners_helper.rb'
- 'ee/app/helpers/ee/preferences_helper.rb'
- 'ee/app/helpers/ee/timeboxes_helper.rb'
- - 'ee/app/helpers/subscriptions_helper.rb'
- 'ee/app/helpers/gitlab_subscriptions/trials_helper.rb'
+ - 'ee/app/helpers/subscriptions_helper.rb'
- 'ee/app/models/approval_merge_request_rule.rb'
- 'ee/app/models/approval_state.rb'
- 'ee/app/models/approval_wrapped_any_approver_rule.rb'
@@ -286,7 +285,6 @@ Gitlab/StrongMemoizeAttr:
- 'ee/app/models/ee/namespace.rb'
- 'ee/app/models/ee/project.rb'
- 'ee/app/models/ee/snippet.rb'
- - 'ee/app/models/ee/work_item.rb'
- 'ee/app/models/gitlab/seat_link_data.rb'
- 'ee/app/models/gitlab_subscription.rb'
- 'ee/app/models/issuables_analytics.rb'
diff --git a/.rubocop_todo/graphql/descriptions.yml b/.rubocop_todo/graphql/descriptions.yml
index 1788d0978a80123f3f3ae6407e2560460e9709c6..4ed725473692a105aaef7c54ea6e68ecb1d2a618 100644
--- a/.rubocop_todo/graphql/descriptions.yml
+++ b/.rubocop_todo/graphql/descriptions.yml
@@ -17,7 +17,6 @@ Graphql/Descriptions:
- 'app/graphql/types/milestone_sort_enum.rb'
- 'app/graphql/types/milestone_type.rb'
- 'app/graphql/types/namespace/package_settings_type.rb'
- - 'app/graphql/types/notes/discussion_type.rb'
- 'app/graphql/types/notes/noteable_interface.rb'
- 'app/graphql/types/packages/cleanup/policy_type.rb'
- 'app/graphql/types/packages/package_details_type.rb'
diff --git a/.rubocop_todo/layout/array_alignment.yml b/.rubocop_todo/layout/array_alignment.yml
index a80b94cb47bd62cf083aa0f6a64295b2d15694b0..e84469449783e1509f2bcf269a7e57e04567f875 100644
--- a/.rubocop_todo/layout/array_alignment.yml
+++ b/.rubocop_todo/layout/array_alignment.yml
@@ -55,7 +55,6 @@ Layout/ArrayAlignment:
- 'ee/spec/requests/api/graphql/group/epics_spec.rb'
- 'ee/spec/requests/api/graphql/mutations/compliance_management/frameworks/create_spec.rb'
- 'ee/spec/requests/api/graphql/mutations/releases/update_spec.rb'
- - 'ee/spec/requests/api/ldap_group_links_spec.rb'
- 'ee/spec/requests/api/license_spec.rb'
- 'ee/spec/requests/api/members_spec.rb'
- 'ee/spec/requests/api/saml_group_links_spec.rb'
diff --git a/.rubocop_todo/layout/class_structure.yml b/.rubocop_todo/layout/class_structure.yml
index 0238fdc900eedfa7bafe5727897b80f5c8a41543..bce5340ed79553f39f5d7cf46a274dede7f92009 100644
--- a/.rubocop_todo/layout/class_structure.yml
+++ b/.rubocop_todo/layout/class_structure.yml
@@ -129,7 +129,6 @@ Layout/ClassStructure:
- 'app/models/packages/sem_ver.rb'
- 'app/models/personal_access_token.rb'
- 'app/models/project_statistics.rb'
- - 'app/models/protected_branch.rb'
- 'app/models/release.rb'
- 'app/models/release_highlight.rb'
- 'app/models/repository.rb'
@@ -210,7 +209,6 @@ Layout/ClassStructure:
- 'ee/app/models/approval_merge_request_rule.rb'
- 'ee/app/models/approval_state.rb'
- 'ee/app/models/boards/epic_board.rb'
- - 'ee/app/models/ci/finished_build_ch_sync_event.rb'
- 'ee/app/models/ci/minutes/namespace_monthly_usage.rb'
- 'ee/app/models/dast/site_profile_secret_variable.rb'
- 'ee/app/models/dast_site_profile.rb'
@@ -236,14 +234,7 @@ Layout/ClassStructure:
- 'ee/app/models/vulnerabilities/identifier.rb'
- 'ee/app/models/vulnerabilities/projects_grade.rb'
- 'ee/app/models/work_items/widgets/rolledup_dates.rb'
- - 'ee/app/replicators/geo/ci_secure_file_replicator.rb'
- - 'ee/app/replicators/geo/dependency_proxy_blob_replicator.rb'
- - 'ee/app/replicators/geo/dependency_proxy_manifest_replicator.rb'
- - 'ee/app/replicators/geo/job_artifact_replicator.rb'
- 'ee/app/replicators/geo/lfs_object_replicator.rb'
- - 'ee/app/replicators/geo/merge_request_diff_replicator.rb'
- - 'ee/app/replicators/geo/pages_deployment_replicator.rb'
- - 'ee/app/replicators/geo/pipeline_artifact_replicator.rb'
- 'ee/app/replicators/geo/terraform_state_version_replicator.rb'
- 'ee/app/services/ai/store_repository_xray_service.rb'
- 'ee/app/services/analytics/value_stream_dashboard/top_level_group_counter_service.rb'
@@ -260,8 +251,6 @@ Layout/ClassStructure:
- 'ee/app/services/path_locks/unlock_service.rb'
- 'ee/app/services/personal_access_tokens/rotation_verifier_service.rb'
- 'ee/app/services/search/zoekt/callback_service.rb'
- - 'ee/app/services/search/zoekt/routing_service.rb'
- - 'ee/app/services/search/zoekt/task_presenter_service.rb'
- 'ee/app/services/search/zoekt/task_serializer_service.rb'
- 'ee/app/services/security/ingestion/tasks/update_vulnerability_uuids.rb'
- 'ee/app/services/security/security_orchestration_policies/on_demand_scan_pipeline_configuration_service.rb'
@@ -279,7 +268,6 @@ Layout/ClassStructure:
- 'ee/app/workers/search/wiki/elastic_delete_group_wiki_worker.rb'
- 'ee/app/workers/security/orchestration_policy_rule_schedule_namespace_worker.rb'
- 'ee/app/workers/zoekt/indexer_worker.rb'
- - 'ee/lib/code_suggestions/tasks/base.rb'
- 'ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules.rb'
- 'ee/lib/gitlab/analytics/cycle_analytics/stage_events/label_based_stage_event.rb'
- 'ee/lib/gitlab/analytics/cycle_analytics/summary/base_time.rb'
@@ -339,7 +327,6 @@ Layout/ClassStructure:
- 'lib/gitlab/background_migration/job_coordinator.rb'
- 'lib/gitlab/background_migration/project_namespaces/backfill_project_namespaces.rb'
- 'lib/gitlab/background_task.rb'
- - 'lib/gitlab/backup_logger.rb'
- 'lib/gitlab/checks/container_moved.rb'
- 'lib/gitlab/checks/post_push_message.rb'
- 'lib/gitlab/checks/project_created.rb'
@@ -352,7 +339,6 @@ Layout/ClassStructure:
- 'lib/gitlab/ci/config/interpolation/config.rb'
- 'lib/gitlab/ci/config/interpolation/context.rb'
- 'lib/gitlab/ci/config/yaml/tags/base.rb'
- - 'lib/gitlab/ci/parsers/security/validators/schema_validator.rb'
- 'lib/gitlab/ci/pipeline/expression/lexeme/and.rb'
- 'lib/gitlab/ci/pipeline/expression/lexeme/base.rb'
- 'lib/gitlab/ci/pipeline/expression/lexeme/equals.rb'
@@ -452,7 +438,6 @@ Layout/ClassStructure:
- 'lib/gitlab/untrusted_regexp.rb'
- 'lib/gitlab/utils/safe_inline_hash.rb'
- 'lib/gitlab/web_hooks/recursion_detection/uuid.rb'
- - 'lib/gitlab/wiki_pages/front_matter_parser.rb'
- 'lib/gitlab/workhorse.rb'
- 'lib/gitlab/x509/certificate.rb'
- 'lib/json_web_token/hmac_token.rb'
diff --git a/.rubocop_todo/layout/empty_line_after_magic_comment.yml b/.rubocop_todo/layout/empty_line_after_magic_comment.yml
index 2c7a62a30e30ce9c0fff997955665858846feb1b..18a30e7616c109f4ae87b2557e575d561616c3d1 100644
--- a/.rubocop_todo/layout/empty_line_after_magic_comment.yml
+++ b/.rubocop_todo/layout/empty_line_after_magic_comment.yml
@@ -42,7 +42,6 @@ Layout/EmptyLineAfterMagicComment:
- 'app/models/packages.rb'
- 'app/models/packages/cleanup.rb'
- 'app/models/packages/conan.rb'
- - 'app/models/packages/dependency.rb'
- 'app/models/packages/dependency_link.rb'
- 'app/models/packages/maven.rb'
- 'app/models/packages/maven/metadatum.rb'
@@ -84,7 +83,6 @@ Layout/EmptyLineAfterMagicComment:
- 'app/services/merge_requests/mergeability/check_base_service.rb'
- 'app/services/merge_requests/mergeability/check_discussions_status_service.rb'
- 'app/services/merge_requests/mergeability/run_checks_service.rb'
- - 'app/services/packages/create_dependency_service.rb'
- 'app/services/packages/create_package_file_service.rb'
- 'app/services/packages/npm/create_tag_service.rb'
- 'app/services/packages/nuget/create_dependency_service.rb'
@@ -269,7 +267,6 @@ Layout/EmptyLineAfterMagicComment:
- 'ee/spec/models/protected_environment_spec.rb'
- 'ee/spec/models/protected_environments/approval_rule_spec.rb'
- 'ee/spec/models/protected_environments/deploy_access_level_spec.rb'
- - 'ee/spec/models/vulnerabilities/finding_spec.rb'
- 'ee/spec/models/work_items/progress_spec.rb'
- 'ee/spec/policies/app_sec/fuzzing/coverage/corpus_policy_spec.rb'
- 'ee/spec/policies/deployment_policy_spec.rb'
@@ -309,7 +306,6 @@ Layout/EmptyLineAfterMagicComment:
- 'ee/spec/services/epics/issue_promote_service_spec.rb'
- 'ee/spec/services/epics/reopen_service_spec.rb'
- 'ee/spec/services/issue_feature_flags/list_service_spec.rb'
- - 'ee/spec/services/licenses/destroy_service_spec.rb'
- 'ee/spec/services/milestones/update_service_spec.rb'
- 'ee/spec/services/protected_environments/create_service_spec.rb'
- 'ee/spec/services/protected_environments/destroy_service_spec.rb'
@@ -472,7 +468,6 @@ Layout/EmptyLineAfterMagicComment:
- 'spec/lib/gitlab/markdown_cache/redis/extension_spec.rb'
- 'spec/lib/gitlab/markdown_cache/redis/store_spec.rb'
- 'spec/lib/gitlab/metrics/environment_spec.rb'
- - 'spec/lib/gitlab/metrics/rails_slis_spec.rb'
- 'spec/lib/gitlab/middleware/handle_malformed_strings_spec.rb'
- 'spec/lib/gitlab/middleware/request_context_spec.rb'
- 'spec/lib/gitlab/request_endpoints_spec.rb'
@@ -499,7 +494,6 @@ Layout/EmptyLineAfterMagicComment:
- 'spec/models/packages/composer/cache_file_spec.rb'
- 'spec/models/packages/composer/metadatum_spec.rb'
- 'spec/models/packages/dependency_link_spec.rb'
- - 'spec/models/packages/dependency_spec.rb'
- 'spec/models/packages/maven/metadatum_spec.rb'
- 'spec/models/packages/npm_spec.rb'
- 'spec/models/packages/package_file_build_info_spec.rb'
@@ -508,7 +502,6 @@ Layout/EmptyLineAfterMagicComment:
- 'spec/models/packages/rpm/repository_file_spec.rb'
- 'spec/policies/design_management/design_policy_spec.rb'
- 'spec/requests/api/composer_packages_spec.rb'
- - 'spec/requests/api/conan_project_packages_spec.rb'
- 'spec/requests/api/debian_group_packages_spec.rb'
- 'spec/requests/api/feature_flags_spec.rb'
- 'spec/requests/api/graphql/ci/ci_cd_setting_spec.rb'
diff --git a/.rubocop_todo/layout/extra_spacing.yml b/.rubocop_todo/layout/extra_spacing.yml
index 8f003c1f5217025094008d9c7a17344b12b76e0e..2b352fdfd97d2bd9cc6e1beea3f2a651b0bc18d2 100644
--- a/.rubocop_todo/layout/extra_spacing.yml
+++ b/.rubocop_todo/layout/extra_spacing.yml
@@ -14,7 +14,6 @@ Layout/ExtraSpacing:
- 'ee/spec/requests/api/internal/base_spec.rb'
- 'ee/spec/services/app_sec/fuzzing/api/ci_configuration_create_service_spec.rb'
- 'ee/spec/services/ci/create_pipeline_service/dast_configuration_spec.rb'
- - 'spec/lib/api/helpers/packages/npm_spec.rb'
- 'spec/lib/gitlab/database/background_migration/batch_optimizer_spec.rb'
- 'spec/lib/gitlab/database/no_new_tables_with_gitlab_main_schema_spec.rb'
- 'spec/lib/gitlab/database/reindexing/index_selection_spec.rb'
diff --git a/.rubocop_todo/layout/first_hash_element_indentation.yml b/.rubocop_todo/layout/first_hash_element_indentation.yml
index ade3a4492976e848a622586c7d43a792a35e37fd..b5b6af90ddf8811db7acebe9740b24bbaccf8018 100644
--- a/.rubocop_todo/layout/first_hash_element_indentation.yml
+++ b/.rubocop_todo/layout/first_hash_element_indentation.yml
@@ -12,7 +12,6 @@ Layout/FirstHashElementIndentation:
- 'ee/spec/requests/api/graphql/mutations/iterations/create_spec.rb'
- 'ee/spec/requests/api/merge_requests_spec.rb'
- 'ee/spec/requests/ee/projects/deploy_tokens_controller_spec.rb'
- - 'ee/spec/requests/groups/group_members_controller_spec.rb'
- 'ee/spec/services/approval_rules/project_rule_destroy_service_spec.rb'
- 'ee/spec/services/deploy_keys/create_service_spec.rb'
- 'ee/spec/services/ee/alert_management/http_integrations/create_service_spec.rb'
@@ -51,7 +50,6 @@ Layout/FirstHashElementIndentation:
- 'spec/controllers/projects/jobs_controller_spec.rb'
- 'spec/controllers/projects/merge_requests/creations_controller_spec.rb'
- 'spec/controllers/projects/milestones_controller_spec.rb'
- - 'spec/controllers/projects/notes_controller_spec.rb'
- 'spec/controllers/projects/pipelines_controller_spec.rb'
- 'spec/controllers/projects/project_members_controller_spec.rb'
- 'spec/controllers/projects/tags_controller_spec.rb'
diff --git a/.rubocop_todo/layout/line_break_after_final_mixin.yml b/.rubocop_todo/layout/line_break_after_final_mixin.yml
index ff487ba596d07d93ee53b25ff6d44297aea11e5e..a79e07865989a150b7c442886cc23186ab4dfb31 100644
--- a/.rubocop_todo/layout/line_break_after_final_mixin.yml
+++ b/.rubocop_todo/layout/line_break_after_final_mixin.yml
@@ -5,8 +5,6 @@ Layout/LineBreakAfterFinalMixin:
- 'app/graphql/resolvers/integrations/exclusions_resolver.rb'
- 'app/graphql/resolvers/projects/deploy_key_resolver.rb'
- 'app/models/alert_management/metric_image.rb'
- - 'app/models/ci/pipeline.rb'
- - 'app/models/container_registry/protection/rule.rb'
- 'app/models/integrations/pushover.rb'
- 'app/models/integrations/telegram.rb'
- 'app/models/plan_limits.rb'
diff --git a/.rubocop_todo/layout/line_continuation_spacing.yml b/.rubocop_todo/layout/line_continuation_spacing.yml
index b63363c9a10506aeaef16712f7bc5405c9c408a4..8b735765722999186f81b1072f1b6929450142b2 100644
--- a/.rubocop_todo/layout/line_continuation_spacing.yml
+++ b/.rubocop_todo/layout/line_continuation_spacing.yml
@@ -62,7 +62,6 @@ Layout/LineContinuationSpacing:
- 'ee/spec/helpers/ee/labels_helper_spec.rb'
- 'ee/spec/helpers/push_rules_helper_spec.rb'
- 'ee/spec/lib/audit/group_merge_request_approval_setting_changes_auditor_spec.rb'
- - 'ee/spec/lib/ee/gitlab/ci/parsers/security/validators/schema_validator_spec.rb'
- 'ee/spec/lib/ee/gitlab/ci/pipeline/quota/size_spec.rb'
- 'ee/spec/lib/gitlab/ci/pipeline/chain/limit/size_spec.rb'
- 'ee/spec/lib/gitlab/git_access_spec.rb'
@@ -106,10 +105,8 @@ Layout/LineContinuationSpacing:
- 'lib/gitlab/database/shared_model.rb'
- 'lib/gitlab/i18n/po_linter.rb'
- 'qa/qa/specs/features/ee/api/9_data_stores/elasticsearch/nightly_elasticsearch_test_spec.rb'
- - 'qa/qa/support/page_error_checker.rb'
- 'qa/qa/tools/test_resources_handler.rb'
- 'qa/spec/resource/user_spec.rb'
- - 'qa/spec/support/page_error_checker_spec.rb'
- 'rubocop/cop/graphql/authorize_types.rb'
- 'rubocop/cop/graphql/descriptions.rb'
- 'rubocop/cop/graphql/graphql_name_position.rb'
@@ -129,7 +126,6 @@ Layout/LineContinuationSpacing:
- 'spec/features/users/login_spec.rb'
- 'spec/finders/groups/projects_requiring_authorizations_refresh/on_direct_membership_finder_spec.rb'
- 'spec/lib/gitlab/auth/otp/strategies/forti_token_cloud_spec.rb'
- - 'spec/lib/gitlab/ci/parsers/security/validators/schema_validator_spec.rb'
- 'spec/lib/gitlab/ci/trace/stream_spec.rb'
- 'spec/lib/gitlab/closing_issue_extractor_spec.rb'
- 'spec/lib/gitlab/database/background_migration/batched_migration_runner_spec.rb'
diff --git a/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml b/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml
index 322374d21fae751b1516b636400483f7b4225c18..02e24315ed57307443aaab50e32da629d69ef043 100644
--- a/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml
+++ b/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml
@@ -36,7 +36,6 @@ Layout/LineEndStringConcatenationIndentation:
- 'app/models/integrations/pivotaltracker.rb'
- 'app/models/integrations/teamcity.rb'
- 'app/models/work_items/parent_link.rb'
- - 'app/presenters/ci/pipeline_presenter.rb'
- 'app/serializers/import/github_failure_entity.rb'
- 'app/services/ci/components/fetch_service.rb'
- 'app/services/concerns/ci/job_token_scope/edit_scope_validations.rb'
@@ -116,7 +115,6 @@ Layout/LineEndStringConcatenationIndentation:
- 'ee/app/graphql/mutations/vulnerabilities/bulk_dismiss.rb'
- 'ee/app/graphql/mutations/vulnerabilities/remove_all_from_project.rb'
- 'ee/app/graphql/resolvers/analytics/contribution_analytics/contributions_resolver.rb'
- - 'ee/app/graphql/resolvers/analytics/value_stream_dashboard/count_resolver.rb'
- 'ee/app/graphql/resolvers/google_cloud/artifact_registry/artifact_resolver.rb'
- 'ee/app/graphql/resolvers/pipeline_security_report_findings_resolver.rb'
- 'ee/app/graphql/resolvers/security_orchestration/scan_execution_policy_resolver.rb'
@@ -227,7 +225,6 @@ Layout/LineEndStringConcatenationIndentation:
- 'ee/spec/features/gitlab_subscriptions/seat_count_alert_spec.rb'
- 'ee/spec/features/groups/contribution_analytics_spec.rb'
- 'ee/spec/features/groups/group_overview_spec.rb'
- - 'ee/spec/features/groups/usage_quotas/code_suggestions_usage_tab_spec.rb'
- 'ee/spec/features/merge_request/user_merges_with_namespace_storage_limits_spec.rb'
- 'ee/spec/features/projects/google_cloud/artifact_registry_spec.rb'
- 'ee/spec/features/projects/members/import_project_members_spec.rb'
@@ -255,8 +252,6 @@ Layout/LineEndStringConcatenationIndentation:
- 'ee/spec/lib/ee/gitlab/namespace_storage_size_error_message_spec.rb'
- 'ee/spec/lib/gitlab/ci/config/entry/secret_spec.rb'
- 'ee/spec/lib/gitlab/ci/pipeline/chain/limit/size_spec.rb'
- - 'ee/spec/lib/gitlab/ci/templates/Security/bas_latest_ci_yaml_spec.rb'
- - 'ee/spec/lib/gitlab/ci/templates/api_discovery_gitlab_ci_yaml_spec.rb'
- 'ee/spec/lib/gitlab/ci/yaml_processor_spec.rb'
- 'ee/spec/lib/gitlab/database/desired_sharding_key_spec.rb'
- 'ee/spec/lib/gitlab/geo/every_repository_type_replicated_spec.rb'
@@ -331,7 +326,6 @@ Layout/LineEndStringConcatenationIndentation:
- 'ee/spec/requests/api/graphql/mutations/vulnerabilities/create_external_issue_link_spec.rb'
- 'ee/spec/requests/api/graphql/mutations/vulnerabilities/create_issue_link_spec.rb'
- 'ee/spec/requests/api/graphql/mutations/vulnerabilities/destroy_external_issue_link_spec.rb'
- - 'ee/spec/requests/api/graphql/mutations/work_items/convert_spec.rb'
- 'ee/spec/requests/api/graphql/mutations/work_items/update_spec.rb'
- 'ee/spec/requests/api/graphql/product_analytics/visualizations_spec.rb'
- 'ee/spec/requests/api/graphql/project/google_cloud/artifact_registry/docker_images_spec.rb'
@@ -341,9 +335,8 @@ Layout/LineEndStringConcatenationIndentation:
- 'ee/spec/requests/api/member_roles_spec.rb'
- 'ee/spec/requests/api/members_spec.rb'
- 'ee/spec/requests/api/projects_spec.rb'
- - 'ee/spec/requests/groups/protected_environments_controller_spec.rb'
- - 'ee/spec/requests/gitlab_subscriptions/trials/duo_pro_controller_spec.rb'
- 'ee/spec/requests/gitlab_subscriptions/trials_controller_spec.rb'
+ - 'ee/spec/requests/groups/protected_environments_controller_spec.rb'
- 'ee/spec/requests/users/registrations_identity_verification_controller_spec.rb'
- 'ee/spec/serializers/integrations/field_entity_spec.rb'
- 'ee/spec/services/ai/store_repository_xray_service_spec.rb'
@@ -363,9 +356,7 @@ Layout/LineEndStringConcatenationIndentation:
- 'ee/spec/services/geo/container_repository_sync_spec.rb'
- 'ee/spec/services/gitlab_subscriptions/add_on_purchases/create_service_spec.rb'
- 'ee/spec/services/gitlab_subscriptions/add_on_purchases/update_service_spec.rb'
- - 'ee/spec/services/llm/git_command_service_spec.rb'
- 'ee/spec/services/merge_requests/merge_service_spec.rb'
- - 'ee/spec/services/merge_trains/create_pipeline_service_spec.rb'
- 'ee/spec/services/package_metadata/advisory_data_object_spec.rb'
- 'ee/spec/services/package_metadata/data_object_fabricator_spec.rb'
- 'ee/spec/services/phone_verification/telesign_client/risk_score_service_spec.rb'
@@ -386,9 +377,9 @@ Layout/LineEndStringConcatenationIndentation:
- 'ee/spec/tasks/duo_pro/bulk_user_assignment_spec.rb'
- 'ee/spec/uploaders/every_gitlab_uploader_spec.rb'
- 'ee/spec/views/admin/application_settings/_ee_package_registry.html.haml_spec.rb'
+ - 'ee/spec/views/gitlab_subscriptions/trials/duo_pro/_advantages_list.html.haml_spec.rb'
- 'ee/spec/views/groups/billings/index.html.haml_spec.rb'
- 'ee/spec/views/subscriptions/groups/edit.html.haml_spec.rb'
- - 'ee/spec/views/gitlab_subscriptions/trials/duo_pro/_advantages_list.html.haml_spec.rb'
- 'ee/spec/workers/groups/enterprise_users/bulk_associate_by_domain_worker_spec.rb'
- 'ee/spec/workers/vulnerabilities/mark_dropped_as_resolved_worker_spec.rb'
- 'lib/api/ci/job_artifacts.rb'
@@ -439,7 +430,6 @@ Layout/LineEndStringConcatenationIndentation:
- 'lib/gitlab/github_import/importer/events/changed_reviewer.rb'
- 'lib/gitlab/hook_data/base_builder.rb'
- 'lib/gitlab/i18n/po_linter.rb'
- - 'lib/gitlab/internal_events.rb'
- 'lib/gitlab/mailgun/webhook_processors/member_invites.rb'
- 'lib/gitlab/pages/deployment_validations.rb'
- 'lib/gitlab/path_regex.rb'
@@ -462,10 +452,6 @@ Layout/LineEndStringConcatenationIndentation:
- 'qa/qa/ee/page/project/analyze/analytics_dashboards/dashboard.rb'
- 'qa/qa/ee/page/project/analyze/analytics_dashboards/setup.rb'
- 'qa/qa/ee/page/project/analyze/dashboard_setup.rb'
- - 'qa/qa/ee/page/project/secure/new_on_demand_scan.rb'
- - 'qa/qa/ee/page/project/secure/pipeline_security.rb'
- - 'qa/qa/ee/page/project/secure/vulnerability_details.rb'
- - 'qa/qa/ee/resource/license.rb'
- 'qa/qa/ee/scenario/test/geo.rb'
- 'qa/qa/page/admin/overview/users/index.rb'
- 'qa/qa/page/base.rb'
@@ -484,7 +470,6 @@ Layout/LineEndStringConcatenationIndentation:
- 'qa/qa/tools/revoke_user_personal_access_tokens.rb'
- 'qa/qa/tools/test_resources_handler.rb'
- 'qa/spec/resource/user_spec.rb'
- - 'qa/spec/support/page_error_checker_spec.rb'
- 'qa/spec/support/system_logs/kibana_spec.rb'
- 'rubocop/check_graceful_task.rb'
- 'rubocop/cop/api/base.rb'
@@ -579,11 +564,8 @@ Layout/LineEndStringConcatenationIndentation:
- 'spec/lib/gitlab/ci/config/external/file/remote_spec.rb'
- 'spec/lib/gitlab/ci/config/interpolation/interpolator_spec.rb'
- 'spec/lib/gitlab/ci/config/yaml/loader_spec.rb'
- - 'spec/lib/gitlab/ci/parsers/security/validators/schema_validator_spec.rb'
- - 'spec/lib/gitlab/ci/status/bridge/factory_spec.rb'
- 'spec/lib/gitlab/ci/status/build/manual_spec.rb'
- 'spec/lib/gitlab/ci/status/stage/play_manual_spec.rb'
- - 'spec/lib/gitlab/ci/templates/terraform_latest_gitlab_ci_yaml_spec.rb'
- 'spec/lib/gitlab/ci/trace/stream_spec.rb'
- 'spec/lib/gitlab/ci/variables/downstream/generator_spec.rb'
- 'spec/lib/gitlab/closing_issue_extractor_spec.rb'
@@ -638,7 +620,6 @@ Layout/LineEndStringConcatenationIndentation:
- 'spec/requests/api/graphql/mutations/achievements/update_user_achievement_priorities_spec.rb'
- 'spec/requests/api/graphql/mutations/ci/runner/create_spec.rb'
- 'spec/requests/api/graphql/mutations/clusters/agent_tokens/agent_tokens/create_spec.rb'
- - 'spec/requests/api/graphql/mutations/container_registry/protection/rule/create_spec.rb'
- 'spec/requests/api/graphql/mutations/issues/bulk_update_spec.rb'
- 'spec/requests/api/graphql/mutations/merge_requests/set_milestone_spec.rb'
- 'spec/requests/api/graphql/mutations/ml/models/delete_spec.rb'
@@ -666,7 +647,6 @@ Layout/LineEndStringConcatenationIndentation:
- 'spec/serializers/profile/event_entity_spec.rb'
- 'spec/services/alert_management/alerts/update_service_spec.rb'
- 'spec/services/bulk_imports/create_service_spec.rb'
- - 'spec/services/ci/catalog/resources/release_service_spec.rb'
- 'spec/services/ci/catalog/resources/validate_service_spec.rb'
- 'spec/services/ci/components/fetch_service_spec.rb'
- 'spec/services/feature_flags/update_service_spec.rb'
@@ -717,7 +697,6 @@ Layout/LineEndStringConcatenationIndentation:
- 'spec/support/shared_examples/services/security/ci_configuration/create_service_shared_examples.rb'
- 'spec/support/shared_examples/workers/background_migration_worker_shared_examples.rb'
- 'spec/tasks/gitlab/db/decomposition/connection_status_rake_spec.rb'
- - 'spec/tooling/lib/tooling/job_metrics_spec.rb'
- 'spec/uploaders/file_mover_spec.rb'
- 'spec/views/layouts/_head.html.haml_spec.rb'
- 'spec/views/profiles/preferences/show.html.haml_spec.rb'
diff --git a/.rubocop_todo/layout/line_length.yml b/.rubocop_todo/layout/line_length.yml
index 0bb22a10b517cae14a466341c3974c07bed53dd7..a55ce540348564240c364a85f8ca342513be313a 100644
--- a/.rubocop_todo/layout/line_length.yml
+++ b/.rubocop_todo/layout/line_length.yml
@@ -126,7 +126,6 @@ Layout/LineLength:
- 'app/graphql/mutations/todos/mark_all_done.rb'
- 'app/graphql/resolvers/container_repository_tags_resolver.rb'
- 'app/graphql/resolvers/project_merge_requests_resolver.rb'
- - 'app/graphql/resolvers/user_discussions_count_resolver.rb'
- 'app/graphql/types/admin/sidekiq_queues/delete_jobs_response_type.rb'
- 'app/graphql/types/alert_management/prometheus_integration_type.rb'
- 'app/graphql/types/alert_management/status_enum.rb'
@@ -164,7 +163,6 @@ Layout/LineLength:
- 'app/graphql/types/packages/conan/file_metadatum_type.rb'
- 'app/graphql/types/packages/helm/dependency_type.rb'
- 'app/graphql/types/packages/helm/metadata_type.rb'
- - 'app/graphql/types/packages/metadata_type.rb'
- 'app/graphql/types/packages/nuget/dependency_link_metadatum_type.rb'
- 'app/graphql/types/packages/package_dependency_link_type.rb'
- 'app/graphql/types/packages/package_details_type.rb'
@@ -192,7 +190,6 @@ Layout/LineLength:
- 'app/helpers/diff_helper.rb'
- 'app/helpers/dropdowns_helper.rb'
- 'app/helpers/emails_helper.rb'
- - 'app/helpers/environments_helper.rb'
- 'app/helpers/events_helper.rb'
- 'app/helpers/export_helper.rb'
- 'app/helpers/external_link_helper.rb'
@@ -237,11 +234,9 @@ Layout/LineLength:
- 'app/mailers/emails/pages_domains.rb'
- 'app/mailers/emails/profile.rb'
- 'app/mailers/previews/notify_preview.rb'
- - 'app/models/alert_management/alert.rb'
- 'app/models/analytics/cycle_analytics/aggregation.rb'
- 'app/models/analytics/cycle_analytics/issue_stage_event.rb'
- 'app/models/analytics/cycle_analytics/merge_request_stage_event.rb'
- - 'app/models/analytics/cycle_analytics/stage_event_hash.rb'
- 'app/models/application_record.rb'
- 'app/models/application_setting.rb'
- 'app/models/application_setting_implementation.rb'
@@ -313,25 +308,19 @@ Layout/LineLength:
- 'app/models/integrations/chat_message/pipeline_message.rb'
- 'app/models/integrations/chat_message/wiki_page_message.rb'
- 'app/models/integrations/confluence.rb'
- - 'app/models/integrations/custom_issue_tracker.rb'
- 'app/models/integrations/datadog.rb'
- 'app/models/integrations/discord.rb'
- 'app/models/integrations/drone_ci.rb'
- 'app/models/integrations/emails_on_push.rb'
- - 'app/models/integrations/ewm.rb'
- - 'app/models/integrations/external_wiki.rb'
- 'app/models/integrations/harbor.rb'
- 'app/models/integrations/jenkins.rb'
- - 'app/models/integrations/mattermost.rb'
- 'app/models/integrations/matrix.rb'
- 'app/models/integrations/microsoft_teams.rb'
- 'app/models/integrations/pipelines_email.rb'
- 'app/models/integrations/pivotaltracker.rb'
- 'app/models/integrations/prometheus.rb'
- 'app/models/integrations/pushover.rb'
- - 'app/models/integrations/redmine.rb'
- 'app/models/integrations/teamcity.rb'
- - 'app/models/integrations/unify_circuit.rb'
- 'app/models/integrations/webex_teams.rb'
- 'app/models/integrations/youtrack.rb'
- 'app/models/integrations/zentao.rb'
@@ -391,9 +380,7 @@ Layout/LineLength:
- 'app/presenters/blob_presenter.rb'
- 'app/presenters/ci/build_runner_presenter.rb'
- 'app/presenters/ci/pipeline_presenter.rb'
- - 'app/presenters/clusters/cluster_presenter.rb'
- 'app/presenters/commit_status_presenter.rb'
- - 'app/presenters/gitlab/blame_presenter.rb'
- 'app/presenters/group_clusterable_presenter.rb'
- 'app/presenters/instance_clusterable_presenter.rb'
- 'app/presenters/merge_request_presenter.rb'
@@ -504,7 +491,6 @@ Layout/LineLength:
- 'app/services/merge_requests/squash_service.rb'
- 'app/services/merge_requests/update_service.rb'
- 'app/services/notes/build_service.rb'
- - 'app/services/notes/resolve_service.rb'
- 'app/services/notification_recipients/builder/default.rb'
- 'app/services/notification_service.rb'
- 'app/services/packages/conan/create_package_file_service.rb'
@@ -533,7 +519,6 @@ Layout/LineLength:
- 'app/services/projects/destroy_service.rb'
- 'app/services/projects/fork_service.rb'
- 'app/services/projects/hashed_storage/base_attachment_service.rb'
- - 'app/services/projects/lfs_pointers/lfs_download_service.rb'
- 'app/services/projects/operations/update_service.rb'
- 'app/services/projects/overwrite_project_service.rb'
- 'app/services/projects/transfer_service.rb'
@@ -606,7 +591,6 @@ Layout/LineLength:
- 'config/initializers/active_record_keyset_pagination.rb'
- 'config/initializers/active_record_schema_versions.rb'
- 'config/initializers/carrierwave_s3_encryption_headers_patch.rb'
- - 'config/initializers/deprecations.rb'
- 'config/initializers/devise_dynamic_password_length_validation.rb'
- 'config/initializers/direct_upload_support.rb'
- 'config/initializers/doorkeeper.rb'
@@ -632,7 +616,6 @@ Layout/LineLength:
- 'danger/feature_flag/Dangerfile'
- 'danger/roulette/Dangerfile'
- 'danger/vue_shared_documentation/Dangerfile'
- - 'ee/app/controllers/admin/licenses_controller.rb'
- 'ee/app/controllers/concerns/audit_events/date_range.rb'
- 'ee/app/controllers/concerns/credentials_inventory_actions.rb'
- 'ee/app/controllers/concerns/ee/issuable_collections.rb'
@@ -1028,7 +1011,6 @@ Layout/LineLength:
- 'ee/lib/analytics/devops_adoption/snapshot_calculator.rb'
- 'ee/lib/analytics/productivity_analytics_request_params.rb'
- 'ee/lib/api/audit_events.rb'
- - 'ee/lib/api/ci/minutes.rb'
- 'ee/lib/api/dependencies.rb'
- 'ee/lib/api/epic_issues.rb'
- 'ee/lib/api/epic_links.rb'
@@ -1053,7 +1035,6 @@ Layout/LineLength:
- 'ee/lib/ee/api/entities/dependency.rb'
- 'ee/lib/ee/api/entities/epic.rb'
- 'ee/lib/ee/api/entities/group.rb'
- - 'ee/lib/ee/api/entities/issue.rb'
- 'ee/lib/ee/api/entities/member.rb'
- 'ee/lib/ee/api/entities/namespace.rb'
- 'ee/lib/ee/api/entities/project.rb'
@@ -1159,7 +1140,6 @@ Layout/LineLength:
- 'ee/lib/world.rb'
- 'ee/spec/controllers/admin/elasticsearch_controller_spec.rb'
- 'ee/spec/controllers/admin/impersonations_controller_spec.rb'
- - 'ee/spec/controllers/admin/licenses_controller_spec.rb'
- 'ee/spec/controllers/admin/projects_controller_spec.rb'
- 'ee/spec/controllers/admin/users_controller_spec.rb'
- 'ee/spec/controllers/concerns/ee/routable_actions/sso_enforcement_redirect_spec.rb'
@@ -1202,7 +1182,6 @@ Layout/LineLength:
- 'ee/spec/factories/ci/reports/security/locations/dependency_scanning.rb'
- 'ee/spec/factories/compliance_management/frameworks.rb'
- 'ee/spec/factories/iterations.rb'
- - 'ee/spec/factories/namespaces.rb'
- 'ee/spec/factories/vulnerabilities/exports.rb'
- 'ee/spec/factories/vulnerabilities/findings.rb'
- 'ee/spec/features/admin/admin_audit_logs_spec.rb'
@@ -1279,7 +1258,6 @@ Layout/LineLength:
- 'ee/spec/features/projects_spec.rb'
- 'ee/spec/features/promotion_spec.rb'
- 'ee/spec/features/read_only_spec.rb'
- - 'ee/spec/features/search/elastic/project_search_spec.rb'
- 'ee/spec/features/search/elastic/snippet_search_spec.rb'
- 'ee/spec/features/subscriptions_spec.rb'
- 'ee/spec/features/users/login_spec.rb'
@@ -1365,7 +1343,6 @@ Layout/LineLength:
- 'ee/spec/graphql/resolvers/incident_management/oncall_schedule_resolver_spec.rb'
- 'ee/spec/graphql/resolvers/iterations/cadences_resolver_spec.rb'
- 'ee/spec/graphql/resolvers/iterations_resolver_spec.rb'
- - 'ee/spec/graphql/resolvers/pipeline_security_report_findings_resolver_spec.rb'
- 'ee/spec/graphql/resolvers/requirements_management/requirements_resolver_spec.rb'
- 'ee/spec/graphql/resolvers/requirements_management/test_reports_resolver_spec.rb'
- 'ee/spec/graphql/resolvers/security_report_summary_resolver_spec.rb'
@@ -1385,7 +1362,6 @@ Layout/LineLength:
- 'ee/spec/graphql/types/issue_type_spec.rb'
- 'ee/spec/graphql/types/project_type_spec.rb'
- 'ee/spec/graphql/types/vulnerability_details/file_location_type_spec.rb'
- - 'ee/spec/graphql/types/vulnerability_evidence_type_spec.rb'
- 'ee/spec/graphql/types/vulnerability_report_type_enum_spec.rb'
- 'ee/spec/graphql/types/vulnerability_response_type_spec.rb'
- 'ee/spec/graphql/types/vulnerability_type_spec.rb'
@@ -1924,7 +1900,6 @@ Layout/LineLength:
- 'ee/spec/services/ci/process_build_service_spec.rb'
- 'ee/spec/services/ci/sync_reports_to_approval_rules_service_spec.rb'
- 'ee/spec/services/compliance_management/frameworks/update_service_spec.rb'
- - 'ee/spec/services/dashboard/operations/list_service_spec.rb'
- 'ee/spec/services/dashboard/projects/create_service_spec.rb'
- 'ee/spec/services/deployments/approval_service_spec.rb'
- 'ee/spec/services/deployments/auto_rollback_service_spec.rb'
@@ -2052,7 +2027,6 @@ Layout/LineLength:
- 'ee/spec/services/system_notes/merge_train_service_spec.rb'
- 'ee/spec/services/timebox_report_service_spec.rb'
- 'ee/spec/services/todo_service_spec.rb'
- - 'ee/spec/services/user_permissions/export_service_spec.rb'
- 'ee/spec/services/vulnerabilities/dismiss_service_spec.rb'
- 'ee/spec/services/vulnerabilities/historical_statistics/adjustment_service_spec.rb'
- 'ee/spec/services/vulnerabilities/manually_create_service_spec.rb'
@@ -2592,7 +2566,6 @@ Layout/LineLength:
- 'lib/tasks/gitlab/update_templates.rake'
- 'lib/tasks/gitlab/user_management.rake'
- 'lib/tasks/gitlab/workhorse.rake'
- - 'lib/tasks/migrate/schema_check.rake'
- 'lib/tasks/tanuki_emoji.rake'
- 'lib/tasks/test.rake'
- 'qa/qa/ee/page/group/secure/show.rb'
@@ -2643,7 +2616,6 @@ Layout/LineLength:
- 'qa/qa/specs/features/browser_ui/2_plan/related_issues/related_issues_spec.rb'
- 'qa/qa/specs/features/browser_ui/2_plan/transient/comment_on_discussion_spec.rb'
- 'qa/qa/specs/features/browser_ui/3_create/merge_request/create_merge_request_via_template_spec.rb'
- - 'qa/qa/specs/features/browser_ui/3_create/merge_request/merge_merge_request_from_fork_spec.rb'
- 'qa/qa/specs/features/browser_ui/3_create/merge_request/rebase_merge_request_spec.rb'
- 'qa/qa/specs/features/browser_ui/3_create/merge_request/squash_merge_request_spec.rb'
- 'qa/qa/specs/features/browser_ui/3_create/merge_request/view_merge_request_diff_patch_spec.rb'
@@ -2672,19 +2644,8 @@ Layout/LineLength:
- 'qa/qa/specs/features/browser_ui/4_verify/pipeline/merge_mr_when_pipline_is_blocked_spec.rb'
- 'qa/qa/specs/features/browser_ui/4_verify/pipeline/trigger_matrix_spec.rb'
- 'qa/qa/specs/features/browser_ui/4_verify/runner/register_runner_spec.rb'
- - 'qa/qa/specs/features/browser_ui/5_package/package_registry/composer_registry_spec.rb'
- - 'qa/qa/specs/features/browser_ui/5_package/package_registry/generic_repository_spec.rb'
- - 'qa/qa/specs/features/browser_ui/5_package/package_registry/helm_registry_spec.rb'
- - 'qa/qa/specs/features/browser_ui/5_package/package_registry/maven/maven_group_level_spec.rb'
- - 'qa/qa/specs/features/browser_ui/5_package/package_registry/maven_gradle_repository_spec.rb'
- - 'qa/qa/specs/features/browser_ui/5_package/package_registry/npm/npm_instance_level_spec.rb'
- - 'qa/qa/specs/features/browser_ui/5_package/package_registry/npm/npm_project_level_spec.rb'
- - 'qa/qa/specs/features/browser_ui/5_package/package_registry/nuget/nuget_group_level_spec.rb'
- - 'qa/qa/specs/features/browser_ui/5_package/package_registry/pypi_repository_spec.rb'
- - 'qa/qa/specs/features/browser_ui/5_package/package_registry/rubygems_registry_spec.rb'
- 'qa/qa/specs/features/ee/api/2_plan/epics_milestone_dates_spec.rb'
- 'qa/qa/specs/features/ee/api/3_create/wiki/group_wiki_repository_storage_move_spec.rb'
- - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/license/cloud_activation_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/license/license_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/2_plan/burndown_chart/burndown_chart_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/2_plan/custom_email/custom_email_spec.rb'
@@ -2715,11 +2676,8 @@ Layout/LineLength:
- 'qa/qa/specs/features/ee/browser_ui/4_verify/pipeline_subscription_with_group_owned_project_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/4_verify/transient/merge_trains_transient_bug_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/5_package/dependency_proxy_sso_spec.rb'
- - 'qa/qa/specs/parallel_runner.rb'
- - 'qa/qa/support/run.rb'
- 'qa/qa/support/ssh.rb'
- 'qa/qa/tools/delete_subgroups.rb'
- - 'qa/qa/tools/delete_test_ssh_keys.rb'
- 'qa/qa/tools/delete_test_users.rb'
- 'qa/qa/tools/generate_perf_testdata.rb'
- 'qa/qa/tools/initialize_gitlab_auth.rb'
@@ -2862,7 +2820,6 @@ Layout/LineLength:
- 'spec/factories/keys.rb'
- 'spec/factories/namespaces.rb'
- 'spec/factories/notes.rb'
- - 'spec/factories/packages/package_files.rb'
- 'spec/factories/projects.rb'
- 'spec/factories/usage_data.rb'
- 'spec/features/action_cable_logging_spec.rb'
@@ -2964,7 +2921,6 @@ Layout/LineLength:
- 'spec/features/merge_request/user_selects_branches_for_new_mr_spec.rb'
- 'spec/features/merge_request/user_squashes_merge_request_spec.rb'
- 'spec/features/merge_request/user_suggests_changes_on_diff_spec.rb'
- - 'spec/features/merge_request/user_toggles_whitespace_changes_spec.rb'
- 'spec/features/merge_requests/filters_generic_behavior_spec.rb'
- 'spec/features/merge_requests/user_exports_as_csv_spec.rb'
- 'spec/features/merge_requests/user_filters_by_approvals_spec.rb'
@@ -3127,7 +3083,6 @@ Layout/LineLength:
- 'spec/graphql/mutations/release_asset_links/update_spec.rb'
- 'spec/graphql/mutations/releases/delete_spec.rb'
- 'spec/graphql/mutations/releases/update_spec.rb'
- - 'spec/graphql/mutations/security/ci_configuration/configure_sast_spec.rb'
- 'spec/graphql/resolvers/admin/analytics/usage_trends/measurements_resolver_spec.rb'
- 'spec/graphql/resolvers/alert_management/alert_resolver_spec.rb'
- 'spec/graphql/resolvers/base_resolver_spec.rb'
@@ -3156,7 +3111,6 @@ Layout/LineLength:
- 'spec/graphql/resolvers/users/groups_resolver_spec.rb'
- 'spec/graphql/resolvers/users/participants_resolver_spec.rb'
- 'spec/graphql/resolvers/users/snippets_resolver_spec.rb'
- - 'spec/graphql/subscriptions/issuable_updated_spec.rb'
- 'spec/graphql/types/access_level_enum_spec.rb'
- 'spec/graphql/types/admin/analytics/usage_trends/measurement_type_spec.rb'
- 'spec/graphql/types/award_emojis/award_emoji_type_spec.rb'
@@ -3165,7 +3119,6 @@ Layout/LineLength:
- 'spec/graphql/types/container_expiration_policy_type_spec.rb'
- 'spec/graphql/types/environment_type_spec.rb'
- 'spec/graphql/types/global_id_type_spec.rb'
- - 'spec/graphql/types/group_type_spec.rb'
- 'spec/graphql/types/issue_sort_enum_spec.rb'
- 'spec/graphql/types/issue_type_spec.rb'
- 'spec/graphql/types/merge_request_type_spec.rb'
@@ -3181,7 +3134,6 @@ Layout/LineLength:
- 'spec/graphql/types/tree/blob_type_spec.rb'
- 'spec/graphql/types/tree/submodule_type_spec.rb'
- 'spec/graphql/types/tree/tree_entry_type_spec.rb'
- - 'spec/graphql/types/user_type_spec.rb'
- 'spec/graphql/types/work_item_id_type_spec.rb'
- 'spec/helpers/admin/deploy_key_helper_spec.rb'
- 'spec/helpers/application_helper_spec.rb'
@@ -3199,7 +3151,6 @@ Layout/LineLength:
- 'spec/helpers/dev_ops_report_helper_spec.rb'
- 'spec/helpers/diff_helper_spec.rb'
- 'spec/helpers/emails_helper_spec.rb'
- - 'spec/helpers/environments_helper_spec.rb'
- 'spec/helpers/external_link_helper_spec.rb'
- 'spec/helpers/gitlab_routing_helper_spec.rb'
- 'spec/helpers/gitlab_script_tag_helper_spec.rb'
@@ -3580,7 +3531,6 @@ Layout/LineLength:
- 'spec/lib/gitlab/metrics/boot_time_tracker_spec.rb'
- 'spec/lib/gitlab/metrics/elasticsearch_rack_middleware_spec.rb'
- 'spec/lib/gitlab/metrics/method_call_spec.rb'
- - 'spec/lib/gitlab/metrics/rails_slis_spec.rb'
- 'spec/lib/gitlab/metrics/requests_rack_middleware_spec.rb'
- 'spec/lib/gitlab/metrics/samplers/threads_sampler_spec.rb'
- 'spec/lib/gitlab/metrics/subscribers/active_record_spec.rb'
@@ -3868,7 +3818,6 @@ Layout/LineLength:
- 'spec/presenters/blobs/notebook_presenter_spec.rb'
- 'spec/presenters/ci/pipeline_artifacts/code_quality_mr_diff_presenter_spec.rb'
- 'spec/presenters/ci/pipeline_presenter_spec.rb'
- - 'spec/presenters/clusters/cluster_presenter_spec.rb'
- 'spec/presenters/commit_status_presenter_spec.rb'
- 'spec/presenters/gitlab/blame_presenter_spec.rb'
- 'spec/presenters/merge_request_presenter_spec.rb'
@@ -4077,7 +4026,6 @@ Layout/LineLength:
- 'spec/serializers/accessibility_error_entity_spec.rb'
- 'spec/serializers/accessibility_reports_comparer_entity_spec.rb'
- 'spec/serializers/analytics/cycle_analytics/stage_entity_spec.rb'
- - 'spec/serializers/base_discussion_entity_spec.rb'
- 'spec/serializers/build_details_entity_spec.rb'
- 'spec/serializers/clusters/kubernetes_error_entity_spec.rb'
- 'spec/serializers/codequality_degradation_entity_spec.rb'
@@ -4165,12 +4113,10 @@ Layout/LineLength:
- 'spec/services/environments/schedule_to_delete_review_apps_service_spec.rb'
- 'spec/services/environments/stop_service_spec.rb'
- 'spec/services/events/destroy_service_spec.rb'
- - 'spec/services/feature_flags/create_service_spec.rb'
- 'spec/services/feature_flags/update_service_spec.rb'
- 'spec/services/files/delete_service_spec.rb'
- 'spec/services/files/multi_service_spec.rb'
- 'spec/services/files/update_service_spec.rb'
- - 'spec/services/git/branch_hooks_service_spec.rb'
- 'spec/services/git/branch_push_service_spec.rb'
- 'spec/services/groups/autocomplete_service_spec.rb'
- 'spec/services/groups/transfer_service_spec.rb'
@@ -4186,7 +4132,6 @@ Layout/LineLength:
- 'spec/services/incident_management/pager_duty/process_webhook_service_spec.rb'
- 'spec/services/integrations/propagate_service_spec.rb'
- 'spec/services/issuable/bulk_update_service_spec.rb'
- - 'spec/services/issuable/common_system_notes_service_spec.rb'
- 'spec/services/issuable/destroy_service_spec.rb'
- 'spec/services/issue_links/create_service_spec.rb'
- 'spec/services/issues/after_create_service_spec.rb'
@@ -4325,7 +4270,6 @@ Layout/LineLength:
- 'spec/services/test_hooks/system_service_spec.rb'
- 'spec/services/todo_service_spec.rb'
- 'spec/services/todos/allowed_target_filter_service_spec.rb'
- - 'spec/services/users/create_service_spec.rb'
- 'spec/services/web_hooks/log_execution_service_spec.rb'
- 'spec/services/work_items/create_and_link_service_spec.rb'
- 'spec/services/work_items/create_from_task_service_spec.rb'
@@ -4591,7 +4535,6 @@ Layout/LineLength:
- 'spec/workers/container_expiration_policy_worker_spec.rb'
- 'spec/workers/create_pipeline_worker_spec.rb'
- 'spec/workers/dependency_proxy/image_ttl_group_policy_worker_spec.rb'
- - 'spec/workers/deployments/hooks_worker_spec.rb'
- 'spec/workers/deployments/update_environment_worker_spec.rb'
- 'spec/workers/disallow_two_factor_for_subgroups_worker_spec.rb'
- 'spec/workers/email_receiver_worker_spec.rb'
diff --git a/.rubocop_todo/layout/space_inside_parens.yml b/.rubocop_todo/layout/space_inside_parens.yml
index 469d54bf7fdaaa89b88a59700ee3c5511e736781..c8e9901dfdd9c6a9c2cf92b2735c2e67b036f29f 100644
--- a/.rubocop_todo/layout/space_inside_parens.yml
+++ b/.rubocop_todo/layout/space_inside_parens.yml
@@ -69,7 +69,6 @@ Layout/SpaceInsideParens:
- 'spec/models/ml/candidate_metric_spec.rb'
- 'spec/models/ml/candidate_spec.rb'
- 'spec/policies/clusters/agent_policy_spec.rb'
- - 'spec/policies/user_policy_spec.rb'
- 'spec/presenters/ci/build_presenter_spec.rb'
- 'spec/presenters/packages/conan/package_presenter_spec.rb'
- 'spec/requests/jwt_controller_spec.rb'
diff --git a/.rubocop_todo/lint/assignment_in_condition.yml b/.rubocop_todo/lint/assignment_in_condition.yml
index 80f49caa577b643195150a0c9a282289b90449ed..710684f3e799be51e58b5c9e9801f3989891f386 100644
--- a/.rubocop_todo/lint/assignment_in_condition.yml
+++ b/.rubocop_todo/lint/assignment_in_condition.yml
@@ -115,7 +115,6 @@ Lint/AssignmentInCondition:
- 'ee/app/services/incident_management/pending_escalations/create_service.rb'
- 'ee/app/services/security/security_orchestration_policies/rule_schedule_service.rb'
- 'ee/app/services/security/security_orchestration_policies/validate_policy_service.rb'
- - 'ee/app/services/vulnerabilities/starboard_vulnerability_create_service.rb'
- 'ee/app/validators/vulnerabilities/cvss_vector_validator.rb'
- 'ee/db/fixtures/development/20_burndown.rb'
- 'ee/lib/ee/api/entities/approval_state.rb'
diff --git a/.rubocop_todo/lint/empty_block.yml b/.rubocop_todo/lint/empty_block.yml
index 68be69a2dc6d7aca0438317b67e3827565b01cdd..67dd2e6edea994126c539e01f34df6ae578b86b6 100644
--- a/.rubocop_todo/lint/empty_block.yml
+++ b/.rubocop_todo/lint/empty_block.yml
@@ -91,7 +91,6 @@ Lint/EmptyBlock:
- 'spec/lib/gitlab/database/migration_helpers/v2_spec.rb'
- 'spec/lib/gitlab/database/migrations/instrumentation_spec.rb'
- 'spec/lib/gitlab/database/migrations/lock_retries_helpers_spec.rb'
- - 'spec/lib/gitlab/database/migrations/observers/transaction_duration_spec.rb'
- 'spec/lib/gitlab/database/shared_model_spec.rb'
- 'spec/lib/gitlab/database/with_lock_retries_outside_transaction_spec.rb'
- 'spec/lib/gitlab/database/with_lock_retries_spec.rb'
diff --git a/.rubocop_todo/lint/missing_cop_enable_directive.yml b/.rubocop_todo/lint/missing_cop_enable_directive.yml
index ea2116c7beb952767554facb326e163b8fbcc4d0..31c3334e27af109cd844498a42e5ca8254c3d020 100644
--- a/.rubocop_todo/lint/missing_cop_enable_directive.yml
+++ b/.rubocop_todo/lint/missing_cop_enable_directive.yml
@@ -5,7 +5,6 @@ Lint/MissingCopEnableDirective:
- 'app/graphql/types/access_level_type.rb'
- 'app/graphql/types/base_enum.rb'
- 'app/graphql/types/boards/board_issue_input_base_type.rb'
- - 'app/graphql/types/ci/analytics_type.rb'
- 'app/graphql/types/ci/build_need_type.rb'
- 'app/graphql/types/ci/config/config_type.rb'
- 'app/graphql/types/ci/config/group_type.rb'
@@ -44,7 +43,6 @@ Lint/MissingCopEnableDirective:
- 'app/graphql/types/packages/package_dependency_type.rb'
- 'app/graphql/types/repository/blob_type.rb'
- 'app/graphql/types/snippets/blob_connection_type.rb'
- - 'app/graphql/types/user_preferences_type.rb'
- 'app/graphql/types/user_status_type.rb'
- 'app/models/commit_collection.rb'
- 'app/models/concerns/batch_destroy_dependent_associations.rb'
@@ -109,7 +107,6 @@ Lint/MissingCopEnableDirective:
- 'ee/app/graphql/types/vulnerable_package_type.rb'
- 'ee/app/services/ee/ci/queue/build_queue_service.rb'
- 'ee/app/workers/ci/runners/stale_group_runners_prune_cron_worker.rb'
- - 'ee/app/workers/groups/export_memberships_worker.rb'
- 'ee/lib/api/ldap_group_links.rb'
- 'ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/delete_invalid_epic_issues_spec.rb'
diff --git a/.rubocop_todo/lint/redundant_cop_disable_directive.yml b/.rubocop_todo/lint/redundant_cop_disable_directive.yml
index 147f47325ddbbabecb397320f75c6b8ee5803d06..67db782d1d30e63ce9d16cc1036e212ff62512bc 100644
--- a/.rubocop_todo/lint/redundant_cop_disable_directive.yml
+++ b/.rubocop_todo/lint/redundant_cop_disable_directive.yml
@@ -1,7 +1,7 @@
---
# Cop supports --autocorrect.
Lint/RedundantCopDisableDirective:
- # Offense count: 567
+ # Offense count: 576
# Temporarily disabled due to too many offenses
Enabled: false
Exclude:
@@ -25,6 +25,7 @@ Lint/RedundantCopDisableDirective:
- 'app/graphql/gitlab_schema.rb'
- 'app/graphql/resolvers/ci/pipeline_job_artifacts_resolver.rb'
- 'app/graphql/resolvers/concerns/caching_array_resolver.rb'
+ - 'app/graphql/resolvers/labels_resolver.rb'
- 'app/graphql/resolvers/work_item_references_resolver.rb'
- 'app/graphql/types/base_enum.rb'
- 'app/graphql/types/board_list_type.rb'
@@ -32,6 +33,7 @@ Lint/RedundantCopDisableDirective:
- 'app/graphql/types/ci/catalog/resources/verification_level_enum.rb'
- 'app/graphql/types/ci/runner_web_url_edge.rb'
- 'app/graphql/types/commit_signatures/verification_status_enum.rb'
+ - 'app/graphql/types/issuables/labels/search_field_list_enum.rb'
- 'app/graphql/types/packages/helm/dependency_type.rb'
- 'app/graphql/types/projects/service_type_enum.rb'
- 'app/helpers/diff_helper.rb'
@@ -51,6 +53,8 @@ Lint/RedundantCopDisableDirective:
- 'app/models/merge_request_diff_commit.rb'
- 'app/models/ml/model_version.rb'
- 'app/models/user.rb'
+ - 'app/models/work_items/type.rb'
+ - 'app/policies/issue_policy.rb'
- 'app/presenters/ci/build_runner_presenter.rb'
- 'app/presenters/dev_ops_report/metric_presenter.rb'
- 'app/serializers/diffs_entity.rb'
@@ -61,8 +65,10 @@ Lint/RedundantCopDisableDirective:
- 'app/services/ci/retry_job_service.rb'
- 'app/services/ci/runners/bulk_delete_runners_service.rb'
- 'app/services/database/consistency_check_service.rb'
+ - 'app/services/design_management/copy_design_collection/copy_service.rb'
- 'app/services/groups/destroy_service.rb'
- 'app/services/groups/import_export/import_service.rb'
+ - 'app/services/import/placeholder_references/push_service.rb'
- 'app/services/issuable_base_service.rb'
- 'app/services/issues/export_csv_service.rb'
- 'app/services/issues/referenced_merge_requests_service.rb'
@@ -91,12 +97,13 @@ Lint/RedundantCopDisableDirective:
- 'app/workers/run_pipeline_schedule_worker.rb'
- 'config/initializers/fog_google_list_objects_match_glob_support.rb'
- 'config/initializers/grape_validators.rb'
- - 'config/initializers/irb.rb'
- 'config/initializers/sprockets_patch.rb'
- 'config/initializers/warden.rb'
- 'config/initializers/wikicloth_redos_patch.rb'
- 'config/initializers/wikicloth_ruby_3_patch.rb'
- 'config/routes/api.rb'
+ - 'db/migrate/20240701145111_add_namespace_import_users_table.rb'
+ - 'db/migrate/20240829163210_create_instance_integrations_table.rb'
- 'db/post_migrate/20230724123547_cleanup_conversion_big_int_ci_build_needs_self_managed.rb'
- 'db/post_migrate/20231017064317_swap_columns_for_ci_pipeline_variables_pipeline_id_bigint.rb'
- 'db/post_migrate/20231019003052_swap_columns_for_ci_pipelines_pipeline_id_bigint_v2.rb'
@@ -105,6 +112,7 @@ Lint/RedundantCopDisableDirective:
- 'db/post_migrate/20231024080150_cleanup_ci_sources_pipelines_pipeline_id_bigint.rb'
- 'db/post_migrate/20231025031337_cleanup_ci_pipeline_messages_pipeline_id_bigint.rb'
- 'db/post_migrate/20231031204841_requeue_backfill_has_remediations_of_vulnerability_reads.rb'
+ - 'db/post_migrate/20231201204712_requeue2_backfill_has_remediations_of_vulnerability_reads.rb'
- 'db/post_migrate/20240123040846_swap_columns_for_system_note_metadata_id.rb'
- 'db/post_migrate/20240131000657_prepare_async_index_for_p_ci_builds_part2.rb'
- 'db/post_migrate/20240206050011_sync_index_for_p_ci_builds_part2.rb'
@@ -118,7 +126,8 @@ Lint/RedundantCopDisableDirective:
- 'db/post_migrate/20240424103758_prepare_async_index_for_builds_part6.rb'
- 'db/post_migrate/20240430015450_sync_index_for_builds_user_id_bigint.rb'
- 'db/post_migrate/20240430015514_swap_columns_for_p_ci_builds_user_id.rb'
- - 'ee/app/controllers/concerns/ee/groups/params.rb'
+ - 'db/post_migrate/20240902014331_sync_fk_referencing_p_ci_pipelines.rb'
+ - 'db/post_migrate/20240917143249_partition_ci_build_trace_metadata3.rb'
- 'ee/app/controllers/ee/admin/application_settings_controller.rb'
- 'ee/app/controllers/ee/groups/group_members_controller.rb'
- 'ee/app/controllers/ee/projects/settings/ci_cd_controller.rb'
@@ -127,6 +136,8 @@ Lint/RedundantCopDisableDirective:
- 'ee/app/finders/epics/with_issues_finder.rb'
- 'ee/app/finders/geo/registry_finder.rb'
- 'ee/app/finders/groups/users_finder.rb'
+ - 'ee/app/finders/search/groups_finder.rb'
+ - 'ee/app/finders/search/projects_finder.rb'
- 'ee/app/finders/status_page/incident_comments_finder.rb'
- 'ee/app/finders/status_page/incidents_finder.rb'
- 'ee/app/graphql/resolvers/analytics/contribution_analytics/contributions_resolver.rb'
@@ -143,6 +154,7 @@ Lint/RedundantCopDisableDirective:
- 'ee/app/models/ai/ai_resource/concerns/noteable.rb'
- 'ee/app/models/approver.rb'
- 'ee/app/models/approver_group.rb'
+ - 'ee/app/models/ci/finished_build_ch_sync_event.rb'
- 'ee/app/models/dast/branch.rb'
- 'ee/app/models/ee/epic.rb'
- 'ee/app/models/ee/group.rb'
@@ -162,8 +174,8 @@ Lint/RedundantCopDisableDirective:
- 'ee/app/services/ee/boards/issues/list_service.rb'
- 'ee/app/services/ee/ci/queue/build_queue_service.rb'
- 'ee/app/services/ee/notification_recipients/builder/base.rb'
- - 'ee/app/services/search/zoekt/routing_service.rb'
- 'ee/app/services/security/ingestion/tasks/ingest_vulnerabilities/mark_resolved_as_detected.rb'
+ - 'ee/app/services/security/scan_result_policies/sync_any_merge_request_rules_service.rb'
- 'ee/app/services/security/security_orchestration_policies/process_scan_result_policy_service.rb'
- 'ee/app/services/security/token_revocation_service.rb'
- 'ee/app/services/software_license_policies/bulk_create_scan_result_policy_service.rb'
@@ -171,6 +183,7 @@ Lint/RedundantCopDisableDirective:
- 'ee/app/workers/members_destroyer/clean_up_group_protected_branch_rules_worker.rb'
- 'ee/app/workers/scan_security_report_secrets_worker.rb'
- 'ee/app/workers/security/orchestration_policy_rule_schedule_worker.rb'
+ - 'ee/app/workers/security/scan_execution_policies/create_pipeline_worker.rb'
- 'ee/app/workers/vulnerabilities/mark_dropped_as_resolved_worker.rb'
- 'ee/db/fixtures/development/93_vsd_overview_counts.rb'
- 'ee/db/geo/migrate/20210504143244_add_verification_to_merge_request_diff_registry.rb'
@@ -183,14 +196,16 @@ Lint/RedundantCopDisableDirective:
- 'ee/lib/ee/api/helpers/internal_helpers.rb'
- 'ee/lib/ee/gitlab/background_migration/backfill_dismissal_reason_in_vulnerability_reads.rb'
- 'ee/lib/ee/gitlab/background_migration/backfill_missing_vulnerability_dismissal_details.rb'
+ - 'ee/lib/ee/gitlab/background_migration/backfill_zoekt_replicas.rb'
- 'ee/lib/ee/gitlab/background_migration/create_compliance_standards_adherence.rb'
+ - 'ee/lib/ee/gitlab/background_migration/create_vulnerability_links.rb'
+ - 'ee/lib/ee/gitlab/background_migration/migrate_vulnerabilities_feedback_to_vulnerabilities_state_transition.rb'
- 'ee/lib/ee/gitlab/background_migration/populate_denormalized_columns_for_sbom_occurrences.rb'
- 'ee/lib/ee/gitlab/background_migration/purge_stale_security_scans.rb'
- 'ee/lib/ee/gitlab/usage_data.rb'
- 'ee/lib/elastic/latest/git_class_proxy.rb'
- 'ee/lib/gitlab/analytics/type_of_work/tasks_by_type.rb'
- 'ee/lib/gitlab/duo/developments/feature_flag_enabler.rb'
- - 'ee/lib/gitlab/llm/chain/tools/summarize_comments/executor.rb'
- 'ee/lib/gitlab/status_page/storage/object.rb'
- 'ee/lib/langsmith/run_helpers.rb'
- 'ee/spec/controllers/concerns/gitlab_subscriptions/seat_count_alert_spec.rb'
@@ -210,13 +225,13 @@ Lint/RedundantCopDisableDirective:
- 'ee/spec/lib/ee/gitlab/background_migration/populate_denormalized_columns_for_sbom_occurrences_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/purge_security_scans_with_empty_finding_data_spec.rb'
- 'ee/spec/lib/ee/gitlab/issuable_metadata_spec.rb'
+ - 'ee/spec/lib/gitlab/elastic/client_spec.rb'
- 'ee/spec/lib/gitlab/geo/log_helpers_spec.rb'
- 'ee/spec/lib/gitlab/llm/completions/chat_real_requests_spec.rb'
- 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_secure_pipelines_metric_spec.rb'
- 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_security_scans_metric_spec.rb'
- 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_user_merge_requests_for_projects_with_applied_scan_result_policies_metric_spec.rb'
- 'ee/spec/lib/gitlab/usage/metrics/instrumentations/protected_environment_approval_rules_required_approvals_average_metric_spec.rb'
- - 'ee/spec/requests/api/conan_project_packages_spec.rb'
- 'ee/spec/requests/api/vulnerability_findings_spec.rb'
- 'ee/spec/requests/git_http_geo_spec.rb'
- 'ee/spec/serializers/vulnerabilities/external_issue_link_entity_spec.rb'
@@ -224,6 +239,7 @@ Lint/RedundantCopDisableDirective:
- 'ee/spec/support/shared_examples/features/dashboard_saml_reauth_banner_shared_examples.rb'
- 'ee/spec/support/shared_examples/models/elasticsearch_indexed_container_shared_examples.rb'
- 'ee/spec/support/shared_examples/models/geo_verifiable_registry_shared_examples.rb'
+ - 'ee/spec/views/admin/users/show.html.haml_spec.rb'
- 'lib/api/api.rb'
- 'lib/api/ci/variables.rb'
- 'lib/api/commit_statuses.rb'
@@ -231,6 +247,7 @@ Lint/RedundantCopDisableDirective:
- 'lib/api/entities/tag.rb'
- 'lib/api/helpers.rb'
- 'lib/api/issue_links.rb'
+ - 'lib/api/submodules.rb'
- 'lib/backup/options.rb'
- 'lib/bulk_imports/pipeline/runner.rb'
- 'lib/container_registry/tag.rb'
@@ -241,18 +258,22 @@ Lint/RedundantCopDisableDirective:
- 'lib/gitlab/analytics/cycle_analytics/base_query_builder.rb'
- 'lib/gitlab/analytics/cycle_analytics/records_fetcher.rb'
- 'lib/gitlab/application_context.rb'
+ - 'lib/gitlab/background_migration/backfill_desired_sharding_key_partition_job.rb'
- 'lib/gitlab/background_migration/backfill_epic_basic_fields_to_work_item_record.rb'
- 'lib/gitlab/background_migration/backfill_finding_id_in_vulnerabilities.rb'
- 'lib/gitlab/background_migration/backfill_imported_issue_search_data.rb'
- 'lib/gitlab/background_migration/backfill_issue_search_data.rb'
+ - 'lib/gitlab/background_migration/backfill_issue_search_data_namespace_id.rb'
- 'lib/gitlab/background_migration/backfill_iteration_cadence_id_for_boards.rb'
- 'lib/gitlab/background_migration/backfill_missing_vulnerability_dismissal_details.rb'
- 'lib/gitlab/background_migration/backfill_nuget_normalized_version.rb'
+ - 'lib/gitlab/background_migration/backfill_or_drop_ci_pipeline_on_project_id.rb'
- 'lib/gitlab/background_migration/backfill_project_statistics_storage_size_without_pipeline_artifacts_size_job.rb'
- 'lib/gitlab/background_migration/backfill_workspace_personal_access_token.rb'
- 'lib/gitlab/background_migration/batching_strategies/loose_index_scan_batching_strategy.rb'
- 'lib/gitlab/background_migration/convert_credit_card_validation_data_to_hashes.rb'
- 'lib/gitlab/background_migration/create_compliance_standards_adherence.rb'
+ - 'lib/gitlab/background_migration/create_vulnerability_links.rb'
- 'lib/gitlab/background_migration/delete_invalid_epic_issues.rb'
- 'lib/gitlab/background_migration/delete_orphans_approval_merge_request_rules2.rb'
- 'lib/gitlab/background_migration/delete_orphans_approval_project_rules2.rb'
@@ -268,11 +289,13 @@ Lint/RedundantCopDisableDirective:
- 'lib/gitlab/background_migration/migrate_approver_to_approval_rules_in_batch.rb'
- 'lib/gitlab/background_migration/migrate_job_artifact_registry_to_ssf.rb'
- 'lib/gitlab/background_migration/migrate_shared_vulnerability_scanners.rb'
+ - 'lib/gitlab/background_migration/migrate_vulnerabilities_feedback_to_vulnerabilities_state_transition.rb'
- 'lib/gitlab/background_migration/populate_denormalized_columns_for_sbom_occurrences.rb'
- 'lib/gitlab/background_migration/populate_latest_pipeline_ids.rb'
- 'lib/gitlab/background_migration/populate_resolved_on_default_branch_column.rb'
- 'lib/gitlab/background_migration/populate_vulnerability_dismissal_fields.rb'
- 'lib/gitlab/background_migration/purge_stale_security_scans.rb'
+ - 'lib/gitlab/background_migration/resolve_vulnerabilities_for_removed_analyzers.rb'
- 'lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url.rb'
- 'lib/gitlab/background_migration/update_workspaces_config_version.rb'
- 'lib/gitlab/background_migration/update_workspaces_config_version3.rb'
@@ -316,10 +339,12 @@ Lint/RedundantCopDisableDirective:
- 'lib/gitlab/health_checks/metric.rb'
- 'lib/gitlab/health_checks/probes/status.rb'
- 'lib/gitlab/health_checks/result.rb'
+ - 'lib/gitlab/lfs_token.rb'
- 'lib/gitlab/middleware/release_env.rb'
- 'lib/gitlab/object_hierarchy.rb'
- 'lib/gitlab/pagination/keyset/column_order_definition.rb'
- 'lib/gitlab/pagination/keyset/pager.rb'
+ - 'lib/gitlab/patch/old_redis_cache_store.rb'
- 'lib/gitlab/patch/redis_cache_store.rb'
- 'lib/gitlab/profiler.rb'
- 'lib/gitlab/project_search_results.rb'
@@ -346,7 +371,6 @@ Lint/RedundantCopDisableDirective:
- 'qa/qa/vendor/one_password/cli.rb'
- 'rubocop/cop/gettext/static_identifier.rb'
- 'rubocop/cop/gitlab/feature_available_usage.rb'
- - 'rubocop/cop/graphql/id_type.rb'
- 'rubocop/cop/migration/add_reference.rb'
- 'rubocop/cop/rake/require.rb'
- 'rubocop/cop/rspec/factory_bot/inline_association.rb'
@@ -372,11 +396,6 @@ Lint/RedundantCopDisableDirective:
- 'spec/features/issues/user_edits_issue_spec.rb'
- 'spec/features/merge_request/user_edits_mr_spec.rb'
- 'spec/frontend/fixtures/merge_requests.rb'
- - 'spec/graphql/mutations/clusters/agent_tokens/create_spec.rb'
- - 'spec/graphql/mutations/clusters/agents/create_spec.rb'
- - 'spec/graphql/mutations/clusters/agents/delete_spec.rb'
- - 'spec/graphql/mutations/commits/create_spec.rb'
- - 'spec/lib/api/helpers/packages/npm_spec.rb'
- 'spec/lib/backup/manager_spec.rb'
- 'spec/lib/gitlab/avatar_cache_spec.rb'
- 'spec/lib/gitlab/background_migration/backfill_finding_id_in_vulnerabilities_spec.rb'
@@ -389,6 +408,8 @@ Lint/RedundantCopDisableDirective:
- 'spec/lib/gitlab/background_migration/drop_vulnerabilities_without_finding_id_spec.rb'
- 'spec/lib/gitlab/background_migration/fix_vulnerability_reads_has_issues_spec.rb'
- 'spec/lib/gitlab/background_migration/populate_vulnerability_dismissal_fields_spec.rb'
+ - 'spec/lib/gitlab/background_migration/resolve_vulnerabilities_for_removed_analyzers_spec.rb'
+ - 'spec/lib/gitlab/ci/parsers/security/validators/schema_validator_spec.rb'
- 'spec/lib/gitlab/database/health_status/indicators/patroni_apdex_spec.rb'
- 'spec/lib/gitlab/database/health_status/indicators/prometheus_alert_indicator_spec.rb'
- 'spec/lib/gitlab/database/health_status/indicators/wal_rate_spec.rb'
@@ -424,9 +445,11 @@ Lint/RedundantCopDisableDirective:
- 'spec/scripts/duo_chat/reporter_spec.rb'
- 'spec/services/alert_management/metric_images/upload_service_spec.rb'
- 'spec/services/boards/lists/list_service_spec.rb'
+ - 'spec/services/pages_domains/create_acme_order_service_spec.rb'
- 'spec/support/finder_collection.rb'
- 'spec/support/forgery_protection.rb'
- 'spec/support/helpers/database/multiple_databases_helpers.rb'
+ - 'spec/support/helpers/graphql_helpers.rb'
- 'spec/support/helpers/migrations_helpers/vulnerabilities_findings_helper.rb'
- 'spec/support/helpers/snowplow_helpers.rb'
- 'spec/support/helpers/wait_for_requests.rb'
@@ -437,6 +460,7 @@ Lint/RedundantCopDisableDirective:
- 'spec/support/shared_examples/models/concerns/incident_management/escalatable_shared_examples.rb'
- 'spec/support/shared_examples/models/concerns/protected_ref_access_shared_examples.rb'
- 'spec/support/shared_examples/models/concerns/protected_ref_deploy_key_access_shared_examples.rb'
+ - 'spec/support/shared_examples/models/cycle_analytics_stage_shared_examples.rb'
- 'spec/support/shared_examples/models/packages/debian/distribution_key_shared_examples.rb'
- 'spec/support/shared_examples/requests/api/rubygems_packages_shared_examples.rb'
- 'tooling/danger/ignored_model_columns.rb'
diff --git a/.rubocop_todo/lint/symbol_conversion.yml b/.rubocop_todo/lint/symbol_conversion.yml
index 16d1196995396d9f65f6cb0f638b8bb5510dfef1..07b159a68f5bfe642963cc4250e7b212098ceb5a 100644
--- a/.rubocop_todo/lint/symbol_conversion.yml
+++ b/.rubocop_todo/lint/symbol_conversion.yml
@@ -42,7 +42,6 @@ Lint/SymbolConversion:
- 'ee/app/policies/ee/project_policy.rb'
- 'ee/app/services/security/security_orchestration_policies/ci_action/base.rb'
- 'ee/app/services/vulnerabilities/manually_create_service.rb'
- - 'ee/app/workers/security/store_scans_worker.rb'
- 'ee/lib/api/concerns/dependency_proxy/packages_helpers.rb'
- 'ee/lib/ee/api/helpers.rb'
- 'ee/lib/gitlab/geo/replicator.rb'
diff --git a/.rubocop_todo/lint/unmodified_reduce_accumulator.yml b/.rubocop_todo/lint/unmodified_reduce_accumulator.yml
deleted file mode 100644
index 84c5d380e7b37e7d2eab64f1192b7de0cabdb968..0000000000000000000000000000000000000000
--- a/.rubocop_todo/lint/unmodified_reduce_accumulator.yml
+++ /dev/null
@@ -1,4 +0,0 @@
----
-Lint/UnmodifiedReduceAccumulator:
- Exclude:
- - 'qa/qa/specs/runner.rb'
diff --git a/.rubocop_todo/lint/unused_block_argument.yml b/.rubocop_todo/lint/unused_block_argument.yml
index 1c4030f1dfbd81b8c65ccd6914fb21dfdf57f1ea..628bbca606525c0b94c6dedcf5e388a748330bb3 100644
--- a/.rubocop_todo/lint/unused_block_argument.yml
+++ b/.rubocop_todo/lint/unused_block_argument.yml
@@ -167,7 +167,6 @@ Lint/UnusedBlockArgument:
- 'lib/api/entities/resource_label_event.rb'
- 'lib/api/entities/shared_group_with_project.rb'
- 'lib/api/entities/snippet.rb'
- - 'lib/api/entities/todo.rb'
- 'lib/api/entities/tree_object.rb'
- 'lib/api/entities/user_basic.rb'
- 'lib/api/group_variables.rb'
@@ -256,7 +255,6 @@ Lint/UnusedBlockArgument:
- 'spec/factories/ci/job_artifacts.rb'
- 'spec/factories/ci/pipelines.rb'
- 'spec/factories/ci/processable.rb'
- - 'spec/factories/ci/reports/sbom/reports.rb'
- 'spec/factories/ci/runners.rb'
- 'spec/factories/clusters/clusters.rb'
- 'spec/factories/clusters/platforms/kubernetes.rb'
@@ -275,7 +273,6 @@ Lint/UnusedBlockArgument:
- 'spec/features/merge_request/user_suggests_changes_on_diff_spec.rb'
- 'spec/fixtures/lib/generators/gitlab/usage_metric_generator/sample_numbers_metric.rb'
- 'spec/graphql/features/authorization_spec.rb'
- - 'spec/graphql/types/base_object_spec.rb'
- 'spec/initializers/secret_token_spec.rb'
- 'spec/lib/api/helpers/pagination_strategies_spec.rb'
- 'spec/lib/banzai/filter/audio_link_filter_spec.rb'
@@ -313,7 +310,6 @@ Lint/UnusedBlockArgument:
- 'spec/models/concerns/ci/partitionable_spec.rb'
- 'spec/models/concerns/each_batch_spec.rb'
- 'spec/models/container_repository_spec.rb'
- - 'spec/models/network/graph_spec.rb'
- 'spec/requests/api/graphql/gitlab_schema_spec.rb'
- 'spec/requests/git_http_spec.rb'
- 'spec/requests/projects/google_cloud/deployments_controller_spec.rb'
@@ -323,7 +319,6 @@ Lint/UnusedBlockArgument:
- 'spec/services/ci/job_token_scope/remove_project_service_spec.rb'
- 'spec/services/ci/pipelines/add_job_service_spec.rb'
- 'spec/services/issues/relative_position_rebalancing_service_spec.rb'
- - 'spec/services/packages/create_event_service_spec.rb'
- 'spec/services/projects/lfs_pointers/lfs_object_download_list_service_spec.rb'
- 'spec/services/repository_archive_clean_up_service_spec.rb'
- 'spec/services/snippets/update_service_spec.rb'
diff --git a/.rubocop_todo/lint/unused_method_argument.yml b/.rubocop_todo/lint/unused_method_argument.yml
index e0532b259e6b115755f9f8455494c3d9c8b5c4f9..ee3b08a2ade2b7e47fc8b8f864f5a1c9263f8fc4 100644
--- a/.rubocop_todo/lint/unused_method_argument.yml
+++ b/.rubocop_todo/lint/unused_method_argument.yml
@@ -99,7 +99,6 @@ Lint/UnusedMethodArgument:
- 'app/models/concerns/issuable.rb'
- 'app/models/concerns/mentionable.rb'
- 'app/models/concerns/note_on_diff.rb'
- - 'app/models/concerns/protected_ref.rb'
- 'app/models/concerns/reactive_caching.rb'
- 'app/models/concerns/referable.rb'
- 'app/models/concerns/subscribable.rb'
@@ -153,8 +152,6 @@ Lint/UnusedMethodArgument:
- 'app/services/groups/transfer_service.rb'
- 'app/services/groups/update_service.rb'
- 'app/services/import/gitlab_projects/file_acquisition_strategies/file_upload.rb'
- - 'app/services/import/gitlab_projects/file_acquisition_strategies/remote_file.rb'
- - 'app/services/import/gitlab_projects/file_acquisition_strategies/remote_file_s3.rb'
- 'app/services/issues/export_csv_service.rb'
- 'app/services/issues/move_service.rb'
- 'app/services/jira/requests/base.rb'
@@ -240,7 +237,6 @@ Lint/UnusedMethodArgument:
- 'ee/app/services/audit_events/runners_token_audit_event_service.rb'
- 'ee/app/services/boards/epic_lists/update_service.rb'
- 'ee/app/services/concerns/incident_management/oncall_rotations/shared_rotation_logic.rb'
- - 'ee/app/services/ee/merge_requests/merge_base_service.rb'
- 'ee/app/services/epics/related_epic_links/create_service.rb'
- 'ee/app/services/epics/transfer_service.rb'
- 'ee/app/services/group_saml/identity/destroy_service.rb'
@@ -406,7 +402,6 @@ Lint/UnusedMethodArgument:
- 'lib/gitlab/github_import/representation/pull_request.rb'
- 'lib/gitlab/github_import/representation/pull_request_review.rb'
- 'lib/gitlab/github_import/representation/user.rb'
- - 'lib/gitlab/graphql/authorize/connection_filter_extension.rb'
- 'lib/gitlab/graphql/board/issues_connection_extension.rb'
- 'lib/gitlab/graphql/calls_gitaly/field_extension.rb'
- 'lib/gitlab/graphql/connection_redaction.rb'
@@ -498,7 +493,6 @@ Lint/UnusedMethodArgument:
- 'spec/graphql/resolvers/base_resolver_spec.rb'
- 'spec/graphql/resolvers/concerns/looks_ahead_spec.rb'
- 'spec/graphql/types/base_field_spec.rb'
- - 'spec/graphql/types/base_object_spec.rb'
- 'spec/helpers/markup_helper_spec.rb'
- 'spec/initializers/rack_multipart_patch_spec.rb'
- 'spec/lib/banzai/object_renderer_spec.rb'
diff --git a/.rubocop_todo/naming/heredoc_delimiter_naming.yml b/.rubocop_todo/naming/heredoc_delimiter_naming.yml
index c6d7b3e36c9c1123eeec6009aaf870da1d9a7143..2ffc692006bdc3e50f2f36ef68467de3e98ff108 100644
--- a/.rubocop_todo/naming/heredoc_delimiter_naming.yml
+++ b/.rubocop_todo/naming/heredoc_delimiter_naming.yml
@@ -34,7 +34,6 @@ Naming/HeredocDelimiterNaming:
- 'lib/gitlab/utils/delegator_override/validator.rb'
- 'lib/tasks/gitlab/docs/compile_deprecations.rake'
- 'lib/tasks/gitlab/password.rake'
- - 'qa/qa/specs/features/browser_ui/5_package/package_registry/generic_repository_spec.rb'
- 'rubocop/cop/database/multiple_databases.rb'
- 'rubocop/cop/database/rescue_query_canceled.rb'
- 'rubocop/cop/database/rescue_statement_timeout.rb'
diff --git a/.rubocop_todo/performance/active_record_subtransaction_methods.yml b/.rubocop_todo/performance/active_record_subtransaction_methods.yml
index d5c0f0027d07dbbd07543bd77f0ad97f14f597dd..a372a8b61e9ebf0c9a31150cf23d23797d456009 100644
--- a/.rubocop_todo/performance/active_record_subtransaction_methods.yml
+++ b/.rubocop_todo/performance/active_record_subtransaction_methods.yml
@@ -20,7 +20,6 @@ Performance/ActiveRecordSubtransactionMethods:
- 'app/services/lfs/file_transformer.rb'
- 'app/services/merge_requests/approval_service.rb'
- 'app/services/namespaces/statistics_refresher_service.rb'
- - 'app/services/packages/rubygems/create_dependencies_service.rb'
- 'app/services/projects/create_service.rb'
- 'app/services/projects/lfs_pointers/lfs_download_service.rb'
- 'app/services/service_desk_settings/update_service.rb'
diff --git a/.rubocop_todo/performance/regexp_match.yml b/.rubocop_todo/performance/regexp_match.yml
deleted file mode 100644
index 72a7499c0e105eda8a3e80bae9a6c8c1d4733916..0000000000000000000000000000000000000000
--- a/.rubocop_todo/performance/regexp_match.yml
+++ /dev/null
@@ -1,33 +0,0 @@
----
-# Cop supports --autocorrect.
-Performance/RegexpMatch:
- Exclude:
- - 'config/initializers/wikicloth_redos_patch.rb'
- - 'ee/app/controllers/concerns/audit_events/enforces_valid_date_params.rb'
- - 'ee/lib/ee/banzai/filter/references/vulnerability_reference_filter.rb'
- - 'ee/lib/gitlab/llm/chain/utils/text_processing.rb'
- - 'ee/lib/gitlab/middleware/ip_restrictor.rb'
- - 'ee/spec/spec_helper.rb'
- - 'lib/api/helpers.rb'
- - 'lib/api/helpers/common_helpers.rb'
- - 'lib/api/validations/validators/bulk_imports.rb'
- - 'lib/banzai/color_parser.rb'
- - 'lib/banzai/filter/ascii_doc_sanitization_filter.rb'
- - 'lib/banzai/filter/references/abstract_reference_filter.rb'
- - 'lib/banzai/filter/references/reference_filter.rb'
- - 'lib/bulk_imports/path_normalization.rb'
- - 'lib/feature/definition.rb'
- - 'lib/tasks/gitlab/update_templates.rake'
- - 'lib/uploaded_file.rb'
- - 'qa/qa/flow/integrations/slack.rb'
- - 'qa/qa/git/location.rb'
- - 'qa/qa/resource/api_fabricator.rb'
- - 'qa/qa/runtime/search.rb'
- - 'qa/qa/service/cluster_provider/k3d.rb'
- - 'qa/qa/tools/ci/ff_changes.rb'
- - 'scripts/failed_tests.rb'
- - 'scripts/lint-docs-blueprints.rb'
- - 'scripts/perf/query_limiting_report.rb'
- - 'scripts/qa/testcases-check'
- - 'scripts/trigger-build.rb'
- - 'sidekiq_cluster/cli.rb'
diff --git a/.rubocop_todo/performance/string_identifier_argument.yml b/.rubocop_todo/performance/string_identifier_argument.yml
index 72d23f957c5246cfa9c9ce0728d1c7f2e73b6464..afbf8d66626b2afafb00d40c2c69e68c9d0afeda 100644
--- a/.rubocop_todo/performance/string_identifier_argument.yml
+++ b/.rubocop_todo/performance/string_identifier_argument.yml
@@ -5,7 +5,6 @@ Performance/StringIdentifierArgument:
- 'app/controllers/concerns/import/github_oauth.rb'
- 'app/controllers/import/github_controller.rb'
- 'app/graphql/types/project_type.rb'
- - 'app/helpers/namespaces_helper.rb'
- 'app/models/concerns/atomic_internal_id.rb'
- 'app/models/concerns/cache_markdown_field.rb'
- 'app/models/concerns/cascading_namespace_setting_attribute.rb'
diff --git a/.rubocop_todo/rails/file_path.yml b/.rubocop_todo/rails/file_path.yml
index 02a688f9520e88c1a07e8cbcbe51ed9542362793..2b188bff15a7bc63e80658c8a08ff6924a67c83c 100644
--- a/.rubocop_todo/rails/file_path.yml
+++ b/.rubocop_todo/rails/file_path.yml
@@ -89,7 +89,6 @@ Rails/FilePath:
- 'spec/features/uploads/user_uploads_file_to_note_spec.rb'
- 'spec/helpers/blob_helper_spec.rb'
- 'spec/helpers/startupjs_helper_spec.rb'
- - 'spec/lib/gitlab/ci/parsers/security/validators/schema_validator_spec.rb'
- 'spec/lib/gitlab/database/schema_migrations/context_spec.rb'
- 'spec/lib/gitlab/feature_categories_spec.rb'
- 'spec/lib/gitlab/file_hook_spec.rb'
diff --git a/.rubocop_todo/rails/helper_instance_variable.yml b/.rubocop_todo/rails/helper_instance_variable.yml
index d51d21efa2d1bd7cd525ed442052b3dd96b0365a..c4812f05ce4517ab9a3f0be3307fb012f28a3b6a 100644
--- a/.rubocop_todo/rails/helper_instance_variable.yml
+++ b/.rubocop_todo/rails/helper_instance_variable.yml
@@ -45,7 +45,6 @@ Rails/HelperInstanceVariable:
- 'app/helpers/tags_helper.rb'
- 'app/helpers/timeboxes_helper.rb'
- 'app/helpers/tree_helper.rb'
- - 'app/helpers/users_helper.rb'
- 'app/helpers/web_ide_button_helper.rb'
- 'app/helpers/webpack_helper.rb'
- 'app/helpers/wiki_helper.rb'
diff --git a/.rubocop_todo/rails/output_safety.yml b/.rubocop_todo/rails/output_safety.yml
index 55028aa9d7c8ecc4a1bafeac7a1e1bd20c2e010c..39b90f656194dab9e86e3478c0e47633e43fb6f3 100644
--- a/.rubocop_todo/rails/output_safety.yml
+++ b/.rubocop_todo/rails/output_safety.yml
@@ -4,14 +4,12 @@ Rails/OutputSafety:
- 'app/controllers/concerns/confirm_email_warning.rb'
- 'app/controllers/groups_controller.rb'
- 'app/controllers/profiles/two_factor_auths_controller.rb'
- - 'app/controllers/projects/mirrors_controller.rb'
- 'app/controllers/projects/pipeline_schedules_controller.rb'
- 'app/controllers/projects/protected_refs_controller.rb'
- 'app/controllers/search_controller.rb'
- 'app/graphql/types/ci/job_trace_type.rb'
- 'app/graphql/types/project_type.rb'
- 'app/helpers/admin/broadcast_messages_helper.rb'
- - 'app/helpers/auth_helper.rb'
- 'app/helpers/commits_helper.rb'
- 'app/helpers/diff_helper.rb'
- 'app/helpers/dropdowns_helper.rb'
@@ -46,7 +44,6 @@ Rails/OutputSafety:
- 'app/models/concerns/restricted_signup.rb'
- 'app/presenters/ci/pipeline_presenter.rb'
- 'app/presenters/key_presenter.rb'
- - 'app/presenters/project_presenter.rb'
- 'app/serializers/analytics/cycle_analytics/stage_entity.rb'
- 'app/serializers/build_details_entity.rb'
- 'app/serializers/entity_date_helper.rb'
@@ -65,8 +62,6 @@ Rails/OutputSafety:
- 'ee/app/components/namespaces/storage/pre_enforcement_alert_component.rb'
- 'ee/app/components/namespaces/storage/repository_limit_alert_component.rb'
- 'ee/app/components/namespaces/storage/user_pre_enforcement_alert_component.rb'
- - 'ee/app/controllers/admin/elasticsearch_controller.rb'
- - 'ee/app/controllers/admin/licenses_controller.rb'
- 'ee/app/controllers/ee/projects/issues_controller.rb'
- 'ee/app/controllers/ee/repositories/lfs_api_controller.rb'
- 'ee/app/helpers/billing_plans_helper.rb'
@@ -82,7 +77,6 @@ Rails/OutputSafety:
- 'ee/lib/gitlab/expiring_subscription_message.rb'
- 'ee/lib/gitlab/licenses/submit_license_usage_data_banner.rb'
- 'ee/lib/gitlab/manual_quarterly_co_term_banner.rb'
- - 'ee/spec/controllers/admin/licenses_controller_spec.rb'
- 'lib/banzai/filter/references/milestone_reference_filter.rb'
- 'lib/banzai/filter/spaced_link_filter.rb'
- 'lib/banzai/object_renderer.rb'
diff --git a/.rubocop_todo/rails/pluck.yml b/.rubocop_todo/rails/pluck.yml
index d65344a88f02bbd3060e486c9a8975903605f8c8..5ec4d4a097c5afe441b2ab031c0060a7b6b74c58 100644
--- a/.rubocop_todo/rails/pluck.yml
+++ b/.rubocop_todo/rails/pluck.yml
@@ -113,9 +113,6 @@ Rails/Pluck:
- 'lib/tasks/gitlab/info.rake'
- 'qa/qa/specs/features/browser_ui/1_manage/integrations/jira/jira_basic_integration_spec.rb'
- 'qa/qa/tools/ci/qa_changes.rb'
- - 'qa/qa/tools/delete_test_ssh_keys.rb'
- - 'qa/qa/tools/delete_test_users.rb'
- - 'scripts/internal_events/cli/helpers/metric_options.rb'
- 'scripts/perf/query_limiting_report.rb'
- 'spec/config/mail_room_spec.rb'
- 'spec/controllers/autocomplete_controller_spec.rb'
diff --git a/.rubocop_todo/rails/strong_params.yml b/.rubocop_todo/rails/strong_params.yml
index c54a93cccea87391a68a0d685c64576cce6fd5f1..d56d262e1dd850cc0ca1ddfada10690d137c3188 100644
--- a/.rubocop_todo/rails/strong_params.yml
+++ b/.rubocop_todo/rails/strong_params.yml
@@ -40,7 +40,6 @@ Rails/StrongParams:
- 'app/controllers/concerns/oauth_applications.rb'
- 'app/controllers/concerns/page_limiter.rb'
- 'app/controllers/concerns/params_backward_compatibility.rb'
- - 'app/controllers/concerns/preferred_language_switcher.rb'
- 'app/controllers/concerns/preview_markdown.rb'
- 'app/controllers/concerns/renders_blob.rb'
- 'app/controllers/concerns/requires_allowlisted_monitoring_client.rb'
@@ -198,7 +197,6 @@ Rails/StrongParams:
- 'app/controllers/projects/tags_controller.rb'
- 'app/controllers/projects/templates_controller.rb'
- 'app/controllers/projects/todos_controller.rb'
- - 'app/controllers/projects/tree_controller.rb'
- 'app/controllers/projects/triggers_controller.rb'
- 'app/controllers/projects/uploads_controller.rb'
- 'app/controllers/projects/web_ide_schemas_controller.rb'
@@ -263,11 +261,11 @@ Rails/StrongParams:
- 'ee/app/controllers/ee/projects/mirrors_controller.rb'
- 'ee/app/controllers/ee/projects/project_members_controller.rb'
- 'ee/app/controllers/ee/projects_controller.rb'
- - 'ee/app/controllers/ee/registrations_controller.rb'
- 'ee/app/controllers/ee/repositories/git_http_client_controller.rb'
- 'ee/app/controllers/ee/repositories/git_http_controller.rb'
- 'ee/app/controllers/ee/sessions_controller.rb'
- 'ee/app/controllers/ee/users_controller.rb'
+ - 'ee/app/controllers/gitlab_subscriptions/trials_controller.rb'
- 'ee/app/controllers/groups/analytics/application_controller.rb'
- 'ee/app/controllers/groups/analytics/ci_cd_analytics_controller.rb'
- 'ee/app/controllers/groups/analytics/coverage_reports_controller.rb'
@@ -304,14 +302,12 @@ Rails/StrongParams:
- 'ee/app/controllers/projects/analytics/issues_analytics_controller.rb'
- 'ee/app/controllers/projects/approver_groups_controller.rb'
- 'ee/app/controllers/projects/approvers_controller.rb'
- - 'ee/app/controllers/projects/dependencies_controller.rb'
- 'ee/app/controllers/projects/feature_flag_issues_controller.rb'
- 'ee/app/controllers/projects/integrations/jira/issues_controller.rb'
- 'ee/app/controllers/projects/issue_feature_flags_controller.rb'
- 'ee/app/controllers/projects/iterations_controller.rb'
- 'ee/app/controllers/projects/metrics_controller.rb'
- 'ee/app/controllers/projects/on_demand_scans_controller.rb'
- - 'ee/app/controllers/projects/path_locks_controller.rb'
- 'ee/app/controllers/projects/protected_environments_controller.rb'
- 'ee/app/controllers/projects/quality/test_cases_controller.rb'
- 'ee/app/controllers/projects/security/dast_scanner_profiles_controller.rb'
@@ -330,7 +326,6 @@ Rails/StrongParams:
- 'ee/app/controllers/smartcard_controller.rb'
- 'ee/app/controllers/subscriptions/groups_controller.rb'
- 'ee/app/controllers/subscriptions/hand_raise_leads_controller.rb'
- - 'ee/app/controllers/gitlab_subscriptions/trials_controller.rb'
- 'ee/app/controllers/subscriptions_controller.rb'
- 'ee/app/controllers/users/base_identity_verification_controller.rb'
- 'ee/app/controllers/users/registrations_identity_verification_controller.rb'
diff --git a/.rubocop_todo/rspec/any_instance_of.yml b/.rubocop_todo/rspec/any_instance_of.yml
index 42f55c43e8cb2647ee66e7aa75002bd36f79920b..6e96bb883605f61ee93b1f5b9ced894c08fb164a 100644
--- a/.rubocop_todo/rspec/any_instance_of.yml
+++ b/.rubocop_todo/rspec/any_instance_of.yml
@@ -242,7 +242,6 @@ RSpec/AnyInstanceOf:
- 'spec/services/issuable/destroy_service_spec.rb'
- 'spec/services/issues/close_service_spec.rb'
- 'spec/services/issues/reopen_service_spec.rb'
- - 'spec/services/members/destroy_service_spec.rb'
- 'spec/services/merge_requests/add_todo_when_build_fails_service_spec.rb'
- 'spec/services/merge_requests/build_service_spec.rb'
- 'spec/services/merge_requests/merge_service_spec.rb'
@@ -271,7 +270,6 @@ RSpec/AnyInstanceOf:
- 'spec/services/users/destroy_service_spec.rb'
- 'spec/spec_helper.rb'
- 'spec/support/capybara.rb'
- - 'spec/support/helpers/api_helpers.rb'
- 'spec/support/helpers/graphql_helpers.rb'
- 'spec/support/helpers/ldap_helpers.rb'
- 'spec/support/helpers/login_helpers.rb'
diff --git a/.rubocop_todo/rspec/before_all_role_assignment.yml b/.rubocop_todo/rspec/before_all_role_assignment.yml
index 118ca600071f867c912af3caae6c5582d4a40b1e..59ba447a8bae2bc782a07d3b9ac6224d09ce87f4 100644
--- a/.rubocop_todo/rspec/before_all_role_assignment.yml
+++ b/.rubocop_todo/rspec/before_all_role_assignment.yml
@@ -286,7 +286,6 @@ RSpec/BeforeAllRoleAssignment:
- 'ee/spec/lib/gitlab/git_access_spec.rb'
- 'ee/spec/lib/gitlab/git_access_wiki_spec.rb'
- 'ee/spec/lib/gitlab/llm/chain/tools/gitlab_documentation/executor_spec.rb'
- - 'ee/spec/lib/gitlab/llm/chain/tools/summarize_comments/executor_spec.rb'
- 'ee/spec/lib/gitlab/quick_actions/users_extractor_spec.rb'
- 'ee/spec/lib/gitlab/reference_extractor_spec.rb'
- 'ee/spec/models/analytics/cycle_analytics/group_level_spec.rb'
@@ -425,7 +424,6 @@ RSpec/BeforeAllRoleAssignment:
- 'ee/spec/requests/api/graphql/project/branch_rules/approval_project_rules_spec.rb'
- 'ee/spec/requests/api/graphql/project/branch_rules/branch_protection_spec.rb'
- 'ee/spec/requests/api/graphql/project/branch_rules/external_status_checks_spec.rb'
- - 'ee/spec/requests/api/graphql/project/branch_rules_spec.rb'
- 'ee/spec/requests/api/graphql/project/dast_profile_schedule_spec.rb'
- 'ee/spec/requests/api/graphql/project/dast_profile_spec.rb'
- 'ee/spec/requests/api/graphql/project/dast_profiles_spec.rb'
@@ -511,7 +509,6 @@ RSpec/BeforeAllRoleAssignment:
- 'ee/spec/requests/registrations/groups_controller_spec.rb'
- 'ee/spec/requests/repositories/git_http_controller_spec.rb'
- 'ee/spec/serializers/clusters/environment_entity_spec.rb'
- - 'ee/spec/serializers/dependency_list_serializer_spec.rb'
- 'ee/spec/serializers/ee/deployment_entity_spec.rb'
- 'ee/spec/serializers/ee/issue_sidebar_basic_entity_spec.rb'
- 'ee/spec/serializers/epics/related_epic_entity_spec.rb'
@@ -611,7 +608,6 @@ RSpec/BeforeAllRoleAssignment:
- 'ee/spec/services/llm/generate_commit_message_service_spec.rb'
- 'ee/spec/services/llm/generate_description_service_spec.rb'
- 'ee/spec/services/llm/generate_summary_service_spec.rb'
- - 'ee/spec/services/llm/git_command_service_spec.rb'
- 'ee/spec/services/llm/merge_requests/summarize_review_service_spec.rb'
- 'ee/spec/services/members/activate_service_spec.rb'
- 'ee/spec/services/merge_trains/create_pipeline_service_spec.rb'
@@ -762,7 +758,6 @@ RSpec/BeforeAllRoleAssignment:
- 'spec/features/issues/user_resets_their_incoming_email_token_spec.rb'
- 'spec/features/markdown/keyboard_shortcuts_spec.rb'
- 'spec/features/merge_request/user_can_see_draft_toggle_spec.rb'
- - 'spec/features/merge_request/user_closes_reopens_merge_request_state_spec.rb'
- 'spec/features/merge_request/user_comments_on_whitespace_hidden_diff_spec.rb'
- 'spec/features/merge_request/user_creates_discussion_on_diff_file_spec.rb'
- 'spec/features/merge_request/user_creates_merge_request_spec.rb'
@@ -1126,7 +1121,6 @@ RSpec/BeforeAllRoleAssignment:
- 'spec/requests/api/graphql/project/merge_request_spec.rb'
- 'spec/requests/api/graphql/project/milestones_spec.rb'
- 'spec/requests/api/graphql/project/project_members_spec.rb'
- - 'spec/requests/api/graphql/project/project_pipeline_statistics_spec.rb'
- 'spec/requests/api/graphql/project/project_statistics_redirect_spec.rb'
- 'spec/requests/api/graphql/project/runners_spec.rb'
- 'spec/requests/api/graphql/project/user_access_authorized_agents_spec.rb'
@@ -1271,7 +1265,6 @@ RSpec/BeforeAllRoleAssignment:
- 'spec/services/members/unassign_issuables_service_spec.rb'
- 'spec/services/members/update_service_spec.rb'
- 'spec/services/merge_requests/add_spent_time_service_spec.rb'
- - 'spec/services/merge_requests/post_merge_service_spec.rb'
- 'spec/services/merge_requests/retarget_chain_service_spec.rb'
- 'spec/services/merge_requests/update_assignees_service_spec.rb'
- 'spec/services/merge_requests/update_reviewers_service_spec.rb'
diff --git a/.rubocop_todo/rspec/context_wording.yml b/.rubocop_todo/rspec/context_wording.yml
index 5fcf45b06dbb0ed92b474ad57d7e8645c6aac82b..2e46ccf62cc7b646683f07810c4d48fc7e4d464a 100644
--- a/.rubocop_todo/rspec/context_wording.yml
+++ b/.rubocop_todo/rspec/context_wording.yml
@@ -5,7 +5,6 @@ RSpec/ContextWording:
- 'ee/spec/controllers/admin/audit_logs_controller_spec.rb'
- 'ee/spec/controllers/admin/dev_ops_report_controller_spec.rb'
- 'ee/spec/controllers/admin/emails_controller_spec.rb'
- - 'ee/spec/controllers/admin/licenses_controller_spec.rb'
- 'ee/spec/controllers/admin/push_rules_controller_spec.rb'
- 'ee/spec/controllers/admin/users_controller_spec.rb'
- 'ee/spec/controllers/autocomplete_controller_spec.rb'
@@ -615,7 +614,6 @@ RSpec/ContextWording:
- 'ee/spec/services/boards/epics/move_service_spec.rb'
- 'ee/spec/services/boards/lists/update_service_spec.rb'
- 'ee/spec/services/ci/copy_cross_database_associations_service_spec.rb'
- - 'ee/spec/services/ee/ci/create_pipeline_service_spec.rb'
- 'ee/spec/services/ci/minutes/update_project_and_namespace_usage_service_spec.rb'
- 'ee/spec/services/ci/pipeline_trigger_service_spec.rb'
- 'ee/spec/services/ci/register_job_service_spec.rb'
@@ -633,6 +631,7 @@ RSpec/ContextWording:
- 'ee/spec/services/ee/boards/issues/list_service_spec.rb'
- 'ee/spec/services/ee/boards/issues/move_service_spec.rb'
- 'ee/spec/services/ee/boards/lists/create_service_spec.rb'
+ - 'ee/spec/services/ee/ci/create_pipeline_service_spec.rb'
- 'ee/spec/services/ee/ci/job_artifacts/destroy_batch_service_spec.rb'
- 'ee/spec/services/ee/git/branch_push_service_spec.rb'
- 'ee/spec/services/ee/groups/autocomplete_service_spec.rb'
@@ -657,7 +656,6 @@ RSpec/ContextWording:
- 'ee/spec/services/ee/notes/post_process_service_spec.rb'
- 'ee/spec/services/ee/notes/quick_actions_service_spec.rb'
- 'ee/spec/services/ee/notification_service_spec.rb'
- - 'ee/spec/services/ee/personal_access_tokens/revoke_service_spec.rb'
- 'ee/spec/services/ee/preview_markdown_service_spec.rb'
- 'ee/spec/services/ee/protected_branches/create_service_spec.rb'
- 'ee/spec/services/ee/resource_events/merge_into_notes_service_spec.rb'
@@ -676,7 +674,6 @@ RSpec/ContextWording:
- 'ee/spec/services/epics/epic_links/list_service_spec.rb'
- 'ee/spec/services/epics/related_epic_links/create_service_spec.rb'
- 'ee/spec/services/epics/related_epic_links/destroy_service_spec.rb'
- - 'ee/spec/services/epics/update_dates_service_spec.rb'
- 'ee/spec/services/epics/update_service_spec.rb'
- 'ee/spec/services/external_status_checks/dispatch_service_spec.rb'
- 'ee/spec/services/geo/container_repository_sync_service_spec.rb'
@@ -756,7 +753,6 @@ RSpec/ContextWording:
- 'ee/spec/services/system_notes/vulnerabilities_service_spec.rb'
- 'ee/spec/services/timebox_report_service_spec.rb'
- 'ee/spec/services/todo_service_spec.rb'
- - 'ee/spec/services/user_permissions/export_service_spec.rb'
- 'ee/spec/services/vulnerability_exports/export_service_spec.rb'
- 'ee/spec/support/features/manual_quarterly_co_term_banner_examples.rb'
- 'ee/spec/support/protected_tags/access_control_shared_examples.rb'
@@ -841,13 +837,10 @@ RSpec/ContextWording:
- 'ee/spec/workers/post_receive_spec.rb'
- 'ee/spec/workers/project_import_schedule_worker_spec.rb'
- 'ee/spec/workers/requirements_management/process_requirements_reports_worker_spec.rb'
- - 'ee/spec/workers/security/store_scans_worker_spec.rb'
- 'ee/spec/workers/security/track_secure_scans_worker_spec.rb'
- 'ee/spec/workers/sync_seat_link_worker_spec.rb'
- 'qa/qa/specs/features/browser_ui/2_plan/milestone/assign_milestone_spec.rb'
- 'qa/qa/specs/features/browser_ui/4_verify/testing/endpoint_coverage_spec.rb'
- - 'qa/qa/specs/features/browser_ui/5_package/package_registry/maven/maven_group_level_spec.rb'
- - 'qa/qa/specs/features/browser_ui/5_package/package_registry/pypi_repository_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/license/cloud_activation_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/license/license_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/13_secure/enable_scanning_from_configuration_spec.rb'
@@ -1002,7 +995,6 @@ RSpec/ContextWording:
- 'spec/features/boards/reload_boards_on_browser_back_spec.rb'
- 'spec/features/boards/sidebar_assignee_spec.rb'
- 'spec/features/boards/sidebar_labels_in_namespaces_spec.rb'
- - 'spec/features/boards/sidebar_labels_spec.rb'
- 'spec/features/boards/user_visits_board_spec.rb'
- 'spec/features/commits_spec.rb'
- 'spec/features/dashboard/activity_spec.rb'
@@ -2134,7 +2126,6 @@ RSpec/ContextWording:
- 'spec/presenters/search_service_presenter_spec.rb'
- 'spec/presenters/user_presenter_spec.rb'
- 'spec/presenters/web_hook_log_presenter_spec.rb'
- - 'spec/requests/admin/integrations_controller_spec.rb'
- 'spec/requests/api/access_requests_spec.rb'
- 'spec/requests/api/admin/ci/variables_spec.rb'
- 'spec/requests/api/admin/instance_clusters_spec.rb'
@@ -2465,7 +2456,6 @@ RSpec/ContextWording:
- 'spec/services/incident_management/incidents/create_service_spec.rb'
- 'spec/services/incident_management/issuable_escalation_statuses/create_service_spec.rb'
- 'spec/services/integrations/test/project_service_spec.rb'
- - 'spec/services/issuable/common_system_notes_service_spec.rb'
- 'spec/services/issue_links/list_service_spec.rb'
- 'spec/services/issues/build_service_spec.rb'
- 'spec/services/issues/clone_service_spec.rb'
diff --git a/.rubocop_todo/rspec/example_wording.yml b/.rubocop_todo/rspec/example_wording.yml
index f7437b6905b8644c16698c428d6e04e3a1738b0c..1224a9cc73edd7fa07f82bafe7981b7b6c9ae502 100644
--- a/.rubocop_todo/rspec/example_wording.yml
+++ b/.rubocop_todo/rspec/example_wording.yml
@@ -48,7 +48,6 @@ RSpec/ExampleWording:
- 'spec/models/deployment_spec.rb'
- 'spec/models/packages/maven/metadatum_spec.rb'
- 'spec/models/packages/package_spec.rb'
- - 'spec/models/packages/pypi/metadatum_spec.rb'
- 'spec/models/project_spec.rb'
- 'spec/models/releases/link_spec.rb'
- 'spec/models/user_spec.rb'
diff --git a/.rubocop_todo/rspec/expect_change.yml b/.rubocop_todo/rspec/expect_change.yml
index 998fa2a8d34199db9a966fda6903c351120db536..af7bcae363dcb7978c6b6e5db5483c55da24d900 100644
--- a/.rubocop_todo/rspec/expect_change.yml
+++ b/.rubocop_todo/rspec/expect_change.yml
@@ -213,7 +213,6 @@ RSpec/ExpectChange:
- 'spec/lib/gitlab/github_import/importer/events/changed_reviewer_spec.rb'
- 'spec/lib/gitlab/github_import/importer/note_importer_spec.rb'
- 'spec/lib/gitlab/github_import/importer/protected_branch_importer_spec.rb'
- - 'spec/lib/gitlab/import_export/after_export_strategies/web_upload_strategy_spec.rb'
- 'spec/lib/gitlab/import_export/base/relation_object_saver_spec.rb'
- 'spec/lib/gitlab/import_export/importer_spec.rb'
- 'spec/lib/gitlab/legacy_github_import/label_formatter_spec.rb'
@@ -301,7 +300,6 @@ RSpec/ExpectChange:
- 'spec/services/incident_management/pager_duty/create_incident_issue_service_spec.rb'
- 'spec/services/incident_management/timeline_events/create_service_spec.rb'
- 'spec/services/issuable/bulk_update_service_spec.rb'
- - 'spec/services/issuable/common_system_notes_service_spec.rb'
- 'spec/services/issues/create_service_spec.rb'
- 'spec/services/issues/export_csv_service_spec.rb'
- 'spec/services/issues/move_service_spec.rb'
diff --git a/.rubocop_todo/rspec/expect_in_hook.yml b/.rubocop_todo/rspec/expect_in_hook.yml
index e9607f67d7dc1fa45b248e413a79df37440951af..743b8d7df529cddaf399651ffe06196692fb8551 100644
--- a/.rubocop_todo/rspec/expect_in_hook.yml
+++ b/.rubocop_todo/rspec/expect_in_hook.yml
@@ -66,7 +66,6 @@ RSpec/ExpectInHook:
- 'ee/spec/services/projects/update_mirror_service_spec.rb'
- 'ee/spec/support/shared_examples/lib/gitlab/graphql/issuables_lazy_links_aggregate_shared_examples.rb'
- 'ee/spec/support/shared_examples/models/concerns/elastic/cannot_read_cross_project_shared_examples.rb'
- - 'ee/spec/support/shared_examples/models/concerns/verifiable_replicator_shared_examples.rb'
- 'ee/spec/support/shared_examples/services/base_sync_service_shared_examples.rb'
- 'ee/spec/support/shared_examples/status_page/reference_links_examples.rb'
- 'ee/spec/tasks/gitlab/license_rake_spec.rb'
@@ -76,10 +75,6 @@ RSpec/ExpectInHook:
- 'ee/spec/workers/elastic_indexing_control_worker_spec.rb'
- 'ee/spec/workers/geo/secondary/registry_consistency_worker_spec.rb'
- 'ee/spec/workers/geo/verification_state_backfill_worker_spec.rb'
- - 'qa/qa/specs/features/browser_ui/5_package/dependency_proxy/dependency_proxy_spec.rb'
- - 'qa/qa/specs/features/browser_ui/5_package/package_registry/composer_registry_spec.rb'
- - 'qa/qa/specs/features/browser_ui/5_package/package_registry/generic_repository_spec.rb'
- - 'qa/qa/specs/features/browser_ui/5_package/package_registry/pypi_repository_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/license/cloud_activation_spec.rb'
- 'spec/commands/metrics_server/metrics_server_spec.rb'
- 'spec/controllers/autocomplete_controller_spec.rb'
diff --git a/.rubocop_todo/rspec/factory_bot/avoid_create.yml b/.rubocop_todo/rspec/factory_bot/avoid_create.yml
index 06142783f02861dd92b53853a97760ca6455cbf5..2e1cfa97dd6307baf1da80319cfbdd1148446ad3 100644
--- a/.rubocop_todo/rspec/factory_bot/avoid_create.yml
+++ b/.rubocop_todo/rspec/factory_bot/avoid_create.yml
@@ -47,6 +47,7 @@ RSpec/FactoryBot/AvoidCreate:
- 'ee/spec/helpers/ee/users/callouts_helper_spec.rb'
- 'ee/spec/helpers/ee/wiki_helper_spec.rb'
- 'ee/spec/helpers/epics_helper_spec.rb'
+ - 'ee/spec/helpers/gitlab_subscriptions/trials_helper_spec.rb'
- 'ee/spec/helpers/gitlab_subscriptions/upcoming_reconciliation_helper_spec.rb'
- 'ee/spec/helpers/groups/security_features_helper_spec.rb'
- 'ee/spec/helpers/incident_management/escalation_policy_helper_spec.rb'
@@ -70,7 +71,6 @@ RSpec/FactoryBot/AvoidCreate:
- 'ee/spec/helpers/security_helper_spec.rb'
- 'ee/spec/helpers/subscriptions_helper_spec.rb'
- 'ee/spec/helpers/timeboxes_helper_spec.rb'
- - 'ee/spec/helpers/gitlab_subscriptions/trials_helper_spec.rb'
- 'ee/spec/helpers/users/identity_verification_helper_spec.rb'
- 'ee/spec/helpers/users_helper_spec.rb'
- 'ee/spec/helpers/vulnerabilities_helper_spec.rb'
diff --git a/.rubocop_todo/rspec/factory_bot/strategy_in_callback.yml b/.rubocop_todo/rspec/factory_bot/strategy_in_callback.yml
index cfa42cc460366ed7a0fda722b1e88e7a6193d17f..e3fcec9b3c395bfd92661b129ea00e7f7baa33ad 100644
--- a/.rubocop_todo/rspec/factory_bot/strategy_in_callback.yml
+++ b/.rubocop_todo/rspec/factory_bot/strategy_in_callback.yml
@@ -34,7 +34,6 @@ RSpec/FactoryBot/StrategyInCallback:
- 'spec/factories/design_management/designs.rb'
- 'spec/factories/design_management/versions.rb'
- 'spec/factories/environments.rb'
- - 'spec/factories/group_members.rb'
- 'spec/factories/groups.rb'
- 'spec/factories/integrations.rb'
- 'spec/factories/issues.rb'
diff --git a/.rubocop_todo/rspec/feature_category.yml b/.rubocop_todo/rspec/feature_category.yml
index 4207869a26bd77cb6eb7556a906a5848044a3453..c653d76672a66c78ac6537a675817ed7e9ca1291 100644
--- a/.rubocop_todo/rspec/feature_category.yml
+++ b/.rubocop_todo/rspec/feature_category.yml
@@ -102,7 +102,6 @@ RSpec/FeatureCategory:
- 'ee/spec/graphql/ee/types/mutation_type_spec.rb'
- 'ee/spec/graphql/ee/types/notes/noteable_interface_spec.rb'
- 'ee/spec/graphql/ee/types/repository/blob_type_spec.rb'
- - 'ee/spec/graphql/ee/types/todoable_interface_spec.rb'
- 'ee/spec/graphql/ee/types/user_merge_request_interaction_type_spec.rb'
- 'ee/spec/graphql/mutations/app_sec/fuzzing/coverage/corpus/create_spec.rb'
- 'ee/spec/graphql/mutations/audit_events/streaming/headers/destroy_spec.rb'
@@ -120,7 +119,6 @@ RSpec/FeatureCategory:
- 'ee/spec/graphql/mutations/compliance_management/frameworks/destroy_spec.rb'
- 'ee/spec/graphql/mutations/compliance_management/frameworks/update_spec.rb'
- 'ee/spec/graphql/mutations/dast/profiles/delete_spec.rb'
- - 'ee/spec/graphql/mutations/dast_on_demand_scans/create_spec.rb'
- 'ee/spec/graphql/mutations/dast_scanner_profiles/delete_spec.rb'
- 'ee/spec/graphql/mutations/dast_site_profiles/create_spec.rb'
- 'ee/spec/graphql/mutations/dast_site_profiles/delete_spec.rb'
@@ -164,7 +162,6 @@ RSpec/FeatureCategory:
- 'ee/spec/graphql/mutations/security/ci_configuration/configure_container_scanning_spec.rb'
- 'ee/spec/graphql/mutations/security/ci_configuration/configure_dependency_scanning_spec.rb'
- 'ee/spec/graphql/mutations/security_policy/commit_scan_execution_policy_spec.rb'
- - 'ee/spec/graphql/mutations/security_policy/create_security_policy_project_spec.rb'
- 'ee/spec/graphql/mutations/security_policy/unassign_security_policy_project_spec.rb'
- 'ee/spec/graphql/mutations/todos/create_spec.rb'
- 'ee/spec/graphql/representation/vulnerability_scanner_entry_spec.rb'
@@ -182,7 +179,6 @@ RSpec/FeatureCategory:
- 'ee/spec/graphql/resolvers/boards/epic_lists_resolvers_spec.rb'
- 'ee/spec/graphql/resolvers/ci/code_coverage_activities_resolver_spec.rb'
- 'ee/spec/graphql/resolvers/ci/code_coverage_summary_resolver_spec.rb'
- - 'ee/spec/graphql/resolvers/clusters/agents_resolver_spec.rb'
- 'ee/spec/graphql/resolvers/dast_site_profile_resolver_spec.rb'
- 'ee/spec/graphql/resolvers/dast_site_validation_resolver_spec.rb'
- 'ee/spec/graphql/resolvers/epic_ancestors_resolver_spec.rb'
@@ -204,10 +200,7 @@ RSpec/FeatureCategory:
- 'ee/spec/graphql/resolvers/requirements_management/requirements_resolver_spec.rb'
- 'ee/spec/graphql/resolvers/requirements_management/test_reports_resolver_spec.rb'
- 'ee/spec/graphql/resolvers/security_report_summary_resolver_spec.rb'
- - 'ee/spec/graphql/resolvers/user_discussions_count_resolver_spec.rb'
- - 'ee/spec/graphql/resolvers/user_notes_count_resolver_spec.rb'
- 'ee/spec/graphql/resolvers/vulnerabilities_grade_resolver_spec.rb'
- - 'ee/spec/graphql/types/admin/cloud_licenses/current_license_type_spec.rb'
- 'ee/spec/graphql/types/admin/cloud_licenses/license_history_entry_type_spec.rb'
- 'ee/spec/graphql/types/admin/cloud_licenses/subscription_future_entry_type_spec.rb'
- 'ee/spec/graphql/types/alert_management/payload_alert_field_name_enum_spec.rb'
@@ -358,7 +351,6 @@ RSpec/FeatureCategory:
- 'ee/spec/graphql/types/vulnerable_package_type_spec.rb'
- 'ee/spec/graphql/types/vulnerable_projects_by_grade_type_spec.rb'
- 'ee/spec/graphql/types/work_items/type_spec.rb'
- - 'ee/spec/graphql/types/work_items/widget_interface_spec.rb'
- 'ee/spec/graphql/types/work_items/widgets/progress_type_spec.rb'
- 'ee/spec/graphql/types/work_items/widgets/status_input_type_spec.rb'
- 'ee/spec/graphql/types/work_items/widgets/status_type_spec.rb'
@@ -366,7 +358,6 @@ RSpec/FeatureCategory:
- 'ee/spec/helpers/analytics/code_review_helper_spec.rb'
- 'ee/spec/helpers/application_helper_spec.rb'
- 'ee/spec/helpers/boards_helper_spec.rb'
- - 'ee/spec/helpers/credentials_inventory_helper_spec.rb'
- 'ee/spec/helpers/ee/access_tokens_helper_spec.rb'
- 'ee/spec/helpers/ee/admin/identities_helper_spec.rb'
- 'ee/spec/helpers/ee/auth_helper_spec.rb'
@@ -374,7 +365,6 @@ RSpec/FeatureCategory:
- 'ee/spec/helpers/ee/branches_helper_spec.rb'
- 'ee/spec/helpers/ee/ci/pipeline_editor_helper_spec.rb'
- 'ee/spec/helpers/ee/dashboard_helper_spec.rb'
- - 'ee/spec/helpers/ee/emails_helper_spec.rb'
- 'ee/spec/helpers/ee/events_helper_spec.rb'
- 'ee/spec/helpers/ee/export_helper_spec.rb'
- 'ee/spec/helpers/ee/feature_flags_helper_spec.rb'
@@ -402,7 +392,6 @@ RSpec/FeatureCategory:
- 'ee/spec/helpers/epics_helper_spec.rb'
- 'ee/spec/helpers/gitlab_subscriptions/upcoming_reconciliation_helper_spec.rb'
- 'ee/spec/helpers/groups/ldap_sync_helper_spec.rb'
- - 'ee/spec/helpers/groups/security_features_helper_spec.rb'
- 'ee/spec/helpers/incident_management/oncall_schedule_helper_spec.rb'
- 'ee/spec/helpers/kerberos_helper_spec.rb'
- 'ee/spec/helpers/manual_quarterly_co_term_banner_helper_spec.rb'
@@ -419,7 +408,6 @@ RSpec/FeatureCategory:
- 'ee/spec/helpers/routing/pseudonymization_helper_spec.rb'
- 'ee/spec/helpers/seat_count_alert_helper_spec.rb'
- 'ee/spec/helpers/timeboxes_helper_spec.rb'
- - 'ee/spec/initializers/1_settings_spec.rb'
- 'ee/spec/initializers/database_config_spec.rb'
- 'ee/spec/initializers/fog_google_https_private_urls_spec.rb'
- 'ee/spec/initializers/session_store_spec.rb'
@@ -486,13 +474,11 @@ RSpec/FeatureCategory:
- 'ee/spec/lib/ee/gitlab/auth/ldap/sync/external_users_spec.rb'
- 'ee/spec/lib/ee/gitlab/auth/ldap/sync/groups_spec.rb'
- 'ee/spec/lib/ee/gitlab/auth/ldap/sync/proxy_spec.rb'
- - 'ee/spec/lib/ee/gitlab/auth/request_authenticator_spec.rb'
- 'ee/spec/lib/ee/gitlab/auth/saml/identity_linker_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/backfill_iteration_cadence_id_for_boards_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_check_progress_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_in_batch_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_spec.rb'
- - 'ee/spec/lib/ee/gitlab/ci/matching/runner_matcher_spec.rb'
- 'ee/spec/lib/ee/gitlab/ci/pipeline/chain/validate/external_spec.rb'
- 'ee/spec/lib/ee/gitlab/ci/pipeline/quota/size_spec.rb'
- 'ee/spec/lib/ee/gitlab/ci/status/build/manual_spec.rb'
@@ -585,7 +571,6 @@ RSpec/FeatureCategory:
- 'ee/spec/lib/gitlab/bullet/exclusions_spec.rb'
- 'ee/spec/lib/gitlab/cache_spec.rb'
- 'ee/spec/lib/gitlab/ci/config/entry/dast_configuration_spec.rb'
- - 'ee/spec/lib/gitlab/ci/config/entry/secret_spec.rb'
- 'ee/spec/lib/gitlab/ci/config/entry/vault/engine_spec.rb'
- 'ee/spec/lib/gitlab/ci/config/entry/vault/secret_spec.rb'
- 'ee/spec/lib/gitlab/ci/parsers/license_compliance/license_scanning_spec.rb'
@@ -675,7 +660,6 @@ RSpec/FeatureCategory:
- 'ee/spec/lib/gitlab/regex_spec.rb'
- 'ee/spec/lib/gitlab/return_to_location_spec.rb'
- 'ee/spec/lib/gitlab/search/aggregation_spec.rb'
- - 'ee/spec/lib/gitlab/search/client_spec.rb'
- 'ee/spec/lib/gitlab/search/recent_epics_spec.rb'
- 'ee/spec/lib/gitlab/search_context/builder_spec.rb'
- 'ee/spec/lib/gitlab/sidekiq_config_spec.rb'
@@ -732,7 +716,6 @@ RSpec/FeatureCategory:
- 'ee/spec/lib/incident_management/oncall_shift_generator_spec.rb'
- 'ee/spec/lib/omni_auth/strategies/group_saml_spec.rb'
- 'ee/spec/lib/omni_auth/strategies/kerberos_spec.rb'
- - 'ee/spec/lib/peek/views/elasticsearch_spec.rb'
- 'ee/spec/lib/quality/seeders/vulnerabilities_spec.rb'
- 'ee/spec/lib/system_check/app/search_check_spec.rb'
- 'ee/spec/mailers/ci_minutes_usage_mailer_spec.rb'
@@ -774,7 +757,6 @@ RSpec/FeatureCategory:
- 'ee/spec/models/commit_spec.rb'
- 'ee/spec/models/compliance_management/compliance_framework/project_settings_spec.rb'
- 'ee/spec/models/concerns/approver_migrate_hook_spec.rb'
- - 'ee/spec/models/concerns/ee/issuable_spec.rb'
- 'ee/spec/models/concerns/ee/milestoneable_spec.rb'
- 'ee/spec/models/concerns/ee/noteable_spec.rb'
- 'ee/spec/models/concerns/ee/participable_spec.rb'
@@ -812,7 +794,6 @@ RSpec/FeatureCategory:
- 'ee/spec/models/ee/event_collection_spec.rb'
- 'ee/spec/models/ee/event_spec.rb'
- 'ee/spec/models/ee/gpg_key_spec.rb'
- - 'ee/spec/models/ee/group_group_link_spec.rb'
- 'ee/spec/models/ee/groups/feature_setting_spec.rb'
- 'ee/spec/models/ee/incident_management/project_incident_management_setting_spec.rb'
- 'ee/spec/models/ee/key_spec.rb'
@@ -916,7 +897,6 @@ RSpec/FeatureCategory:
- 'ee/spec/policies/incident_management/oncall_shift_policy_spec.rb'
- 'ee/spec/policies/instance_security_dashboard_policy_spec.rb'
- 'ee/spec/policies/issuable_policy_spec.rb'
- - 'ee/spec/policies/merge_requests/external_status_check_policy_spec.rb'
- 'ee/spec/policies/note_policy_spec.rb'
- 'ee/spec/policies/path_lock_policy_spec.rb'
- 'ee/spec/policies/project_snippet_policy_spec.rb'
@@ -1041,10 +1021,6 @@ RSpec/FeatureCategory:
- 'ee/spec/services/app_sec/dast/profiles/destroy_service_spec.rb'
- 'ee/spec/services/app_sec/dast/site_profile_secret_variables/create_or_update_service_spec.rb'
- 'ee/spec/services/app_sec/dast/site_profile_secret_variables/destroy_service_spec.rb'
- - 'ee/spec/services/app_sec/dast/site_profiles/audit/update_service_spec.rb'
- - 'ee/spec/services/app_sec/dast/site_profiles/create_service_spec.rb'
- - 'ee/spec/services/app_sec/dast/site_profiles/destroy_service_spec.rb'
- - 'ee/spec/services/app_sec/dast/site_profiles/update_service_spec.rb'
- 'ee/spec/services/app_sec/dast/site_tokens/find_or_create_service_spec.rb'
- 'ee/spec/services/app_sec/dast/site_validations/find_or_create_service_spec.rb'
- 'ee/spec/services/app_sec/dast/site_validations/revoke_service_spec.rb'
@@ -1123,7 +1099,6 @@ RSpec/FeatureCategory:
- 'ee/spec/views/admin/push_rules/_merge_request_approvals.html.haml_spec.rb'
- 'ee/spec/views/admin/users/index.html.haml_spec.rb'
- 'ee/spec/views/clusters/clusters/show.html.haml_spec.rb'
- - 'ee/spec/views/compliance_management/compliance_framework/_compliance_frameworks_info.html.haml_spec.rb'
- 'ee/spec/views/groups/hook_logs/show.html.haml_spec.rb'
- 'ee/spec/views/groups/hooks/edit.html.haml_spec.rb'
- 'ee/spec/views/groups/security/discover/show.html.haml_spec.rb'
@@ -1183,7 +1158,6 @@ RSpec/FeatureCategory:
- 'spec/components/diffs/stats_component_spec.rb'
- 'spec/components/layouts/horizontal_section_component_spec.rb'
- 'spec/components/pajamas/alert_component_spec.rb'
- - 'spec/components/pajamas/avatar_component_spec.rb'
- 'spec/components/pajamas/badge_component_spec.rb'
- 'spec/components/pajamas/banner_component_spec.rb'
- 'spec/components/pajamas/checkbox_component_spec.rb'
@@ -1242,7 +1216,6 @@ RSpec/FeatureCategory:
- 'spec/controllers/dashboard/labels_controller_spec.rb'
- 'spec/controllers/dashboard/milestones_controller_spec.rb'
- 'spec/controllers/dashboard/snippets_controller_spec.rb'
- - 'spec/controllers/dashboard/todos_controller_spec.rb'
- 'spec/controllers/explore/snippets_controller_spec.rb'
- 'spec/controllers/google_api/authorizations_controller_spec.rb'
- 'spec/controllers/groups/application_controller_spec.rb'
@@ -1252,7 +1225,6 @@ RSpec/FeatureCategory:
- 'spec/controllers/groups/group_links_controller_spec.rb'
- 'spec/controllers/groups/imports_controller_spec.rb'
- 'spec/controllers/groups/packages_controller_spec.rb'
- - 'spec/controllers/groups/registry/repositories_controller_spec.rb'
- 'spec/controllers/groups/releases_controller_spec.rb'
- 'spec/controllers/groups/settings/applications_controller_spec.rb'
- 'spec/controllers/groups/settings/repository_controller_spec.rb'
@@ -1306,7 +1278,6 @@ RSpec/FeatureCategory:
- 'spec/controllers/projects/releases_controller_spec.rb'
- 'spec/controllers/projects/security/configuration_controller_spec.rb'
- 'spec/controllers/projects/service_ping_controller_spec.rb'
- - 'spec/controllers/projects/settings/integration_hook_logs_controller_spec.rb'
- 'spec/controllers/projects/settings/merge_requests_controller_spec.rb'
- 'spec/controllers/projects/snippets/blobs_controller_spec.rb'
- 'spec/controllers/projects/snippets_controller_spec.rb'
@@ -1332,7 +1303,6 @@ RSpec/FeatureCategory:
- 'spec/docs_screenshots/container_registry_docs.rb'
- 'spec/docs_screenshots/wiki_docs.rb'
- 'spec/features/admin/dashboard_spec.rb'
- - 'spec/features/milestones/user_views_milestones_spec.rb'
- 'spec/features/projects/feature_flags/user_creates_feature_flag_spec.rb'
- 'spec/features/projects/issues/viewing_issues_with_external_authorization_enabled_spec.rb'
- 'spec/features/projects/members/anonymous_user_sees_members_spec.rb'
@@ -1353,7 +1323,6 @@ RSpec/FeatureCategory:
- 'spec/finders/boards/boards_finder_spec.rb'
- 'spec/finders/boards/visits_finder_spec.rb'
- 'spec/finders/bulk_imports/entities_finder_spec.rb'
- - 'spec/finders/bulk_imports/imports_finder_spec.rb'
- 'spec/finders/ci/commit_statuses_finder_spec.rb'
- 'spec/finders/ci/daily_build_group_report_results_finder_spec.rb'
- 'spec/finders/ci/job_artifacts_finder_spec.rb'
@@ -1372,7 +1341,6 @@ RSpec/FeatureCategory:
- 'spec/finders/concerns/finder_with_group_hierarchy_spec.rb'
- 'spec/finders/container_repositories_finder_spec.rb'
- 'spec/finders/context_commits_finder_spec.rb'
- - 'spec/finders/crm/contacts_finder_spec.rb'
- 'spec/finders/crm/organizations_finder_spec.rb'
- 'spec/finders/database/batched_background_migrations_finder_spec.rb'
- 'spec/finders/deploy_tokens/tokens_finder_spec.rb'
@@ -1404,19 +1372,15 @@ RSpec/FeatureCategory:
- 'spec/finders/packages/build_infos_finder_spec.rb'
- 'spec/finders/packages/conan/package_file_finder_spec.rb'
- 'spec/finders/packages/debian/distributions_finder_spec.rb'
- - 'spec/finders/packages/generic/package_finder_spec.rb'
- 'spec/finders/packages/go/module_finder_spec.rb'
- 'spec/finders/packages/go/package_finder_spec.rb'
- 'spec/finders/packages/go/version_finder_spec.rb'
- 'spec/finders/packages/group_or_project_package_finder_spec.rb'
- 'spec/finders/packages/helm/package_files_finder_spec.rb'
- 'spec/finders/packages/helm/packages_finder_spec.rb'
- - 'spec/finders/packages/npm/package_finder_spec.rb'
- 'spec/finders/packages/package_file_finder_spec.rb'
- 'spec/finders/packages/package_finder_spec.rb'
- 'spec/finders/packages/packages_finder_spec.rb'
- - 'spec/finders/packages/pypi/package_finder_spec.rb'
- - 'spec/finders/packages/pypi/packages_finder_spec.rb'
- 'spec/finders/packages/tags_finder_spec.rb'
- 'spec/finders/projects/export_job_finder_spec.rb'
- 'spec/finders/projects/groups_finder_spec.rb'
@@ -1477,22 +1441,9 @@ RSpec/FeatureCategory:
- 'spec/frontend/fixtures/webauthn.rb'
- 'spec/graphql/features/authorization_spec.rb'
- 'spec/graphql/gitlab_schema_spec.rb'
- - 'spec/graphql/mutations/alert_management/alerts/set_assignees_spec.rb'
- - 'spec/graphql/mutations/alert_management/alerts/todo/create_spec.rb'
- - 'spec/graphql/mutations/alert_management/create_alert_issue_spec.rb'
- - 'spec/graphql/mutations/alert_management/http_integration/create_spec.rb'
- - 'spec/graphql/mutations/alert_management/http_integration/destroy_spec.rb'
- - 'spec/graphql/mutations/alert_management/http_integration/reset_token_spec.rb'
- - 'spec/graphql/mutations/alert_management/http_integration/update_spec.rb'
- - 'spec/graphql/mutations/alert_management/prometheus_integration/create_spec.rb'
- - 'spec/graphql/mutations/alert_management/prometheus_integration/reset_token_spec.rb'
- - 'spec/graphql/mutations/alert_management/prometheus_integration/update_spec.rb'
- - 'spec/graphql/mutations/alert_management/update_alert_status_spec.rb'
- 'spec/graphql/mutations/boards/issues/issue_move_list_spec.rb'
- 'spec/graphql/mutations/boards/lists/create_spec.rb'
- 'spec/graphql/mutations/boards/lists/update_spec.rb'
- - 'spec/graphql/mutations/boards/update_spec.rb'
- - 'spec/graphql/mutations/branches/create_spec.rb'
- 'spec/graphql/mutations/clusters/agent_tokens/create_spec.rb'
- 'spec/graphql/mutations/clusters/agent_tokens/revoke_spec.rb'
- 'spec/graphql/mutations/clusters/agents/create_spec.rb'
@@ -1507,35 +1458,9 @@ RSpec/FeatureCategory:
- 'spec/graphql/mutations/customer_relations/contacts/update_spec.rb'
- 'spec/graphql/mutations/customer_relations/organizations/create_spec.rb'
- 'spec/graphql/mutations/customer_relations/organizations/update_spec.rb'
- - 'spec/graphql/mutations/design_management/delete_spec.rb'
- - 'spec/graphql/mutations/design_management/move_spec.rb'
- - 'spec/graphql/mutations/design_management/upload_spec.rb'
- 'spec/graphql/mutations/discussions/toggle_resolve_spec.rb'
- 'spec/graphql/mutations/environments/canary_ingress/update_spec.rb'
- - 'spec/graphql/mutations/groups/update_spec.rb'
- - 'spec/graphql/mutations/incident_management/timeline_event/create_spec.rb'
- - 'spec/graphql/mutations/incident_management/timeline_event/destroy_spec.rb'
- - 'spec/graphql/mutations/incident_management/timeline_event/promote_from_note_spec.rb'
- - 'spec/graphql/mutations/incident_management/timeline_event/update_spec.rb'
- - 'spec/graphql/mutations/incident_management/timeline_event_tag/create_spec.rb'
- - 'spec/graphql/mutations/issues/create_spec.rb'
- - 'spec/graphql/mutations/issues/move_spec.rb'
- - 'spec/graphql/mutations/issues/set_assignees_spec.rb'
- - 'spec/graphql/mutations/issues/set_confidential_spec.rb'
- - 'spec/graphql/mutations/issues/set_due_date_spec.rb'
- - 'spec/graphql/mutations/issues/set_escalation_status_spec.rb'
- - 'spec/graphql/mutations/issues/set_locked_spec.rb'
- - 'spec/graphql/mutations/issues/set_severity_spec.rb'
- 'spec/graphql/mutations/issues/set_subscription_spec.rb'
- - 'spec/graphql/mutations/labels/create_spec.rb'
- - 'spec/graphql/mutations/merge_requests/accept_spec.rb'
- - 'spec/graphql/mutations/merge_requests/create_spec.rb'
- - 'spec/graphql/mutations/merge_requests/set_assignees_spec.rb'
- - 'spec/graphql/mutations/merge_requests/set_draft_spec.rb'
- - 'spec/graphql/mutations/merge_requests/set_labels_spec.rb'
- - 'spec/graphql/mutations/merge_requests/set_locked_spec.rb'
- - 'spec/graphql/mutations/merge_requests/set_milestone_spec.rb'
- - 'spec/graphql/mutations/merge_requests/set_reviewers_spec.rb'
- 'spec/graphql/mutations/merge_requests/set_subscription_spec.rb'
- 'spec/graphql/mutations/notes/reposition_image_diff_note_spec.rb'
- 'spec/graphql/mutations/pages/mark_onboarding_complete_spec.rb'
@@ -1570,7 +1495,6 @@ RSpec/FeatureCategory:
- 'spec/graphql/resolvers/ci/test_suite_resolver_spec.rb'
- 'spec/graphql/resolvers/clusters/agent_activity_events_resolver_spec.rb'
- 'spec/graphql/resolvers/clusters/agent_tokens_resolver_spec.rb'
- - 'spec/graphql/resolvers/clusters/agents_resolver_spec.rb'
- 'spec/graphql/resolvers/commit_pipelines_resolver_spec.rb'
- 'spec/graphql/resolvers/concerns/caching_array_resolver_spec.rb'
- 'spec/graphql/resolvers/concerns/looks_ahead_spec.rb'
@@ -1616,7 +1540,6 @@ RSpec/FeatureCategory:
- 'spec/graphql/resolvers/package_details_resolver_spec.rb'
- 'spec/graphql/resolvers/package_pipelines_resolver_spec.rb'
- 'spec/graphql/resolvers/packages_base_resolver_spec.rb'
- - 'spec/graphql/resolvers/project_issues_resolver_spec.rb'
- 'spec/graphql/resolvers/project_members_resolver_spec.rb'
- 'spec/graphql/resolvers/project_merge_requests_resolver_spec.rb'
- 'spec/graphql/resolvers/project_milestones_resolver_spec.rb'
@@ -1666,7 +1589,6 @@ RSpec/FeatureCategory:
- 'spec/graphql/types/board_type_spec.rb'
- 'spec/graphql/types/boards/board_issue_input_type_spec.rb'
- 'spec/graphql/types/branch_type_spec.rb'
- - 'spec/graphql/types/ci/analytics_type_spec.rb'
- 'spec/graphql/types/ci/config/config_type_spec.rb'
- 'spec/graphql/types/ci/config/group_type_spec.rb'
- 'spec/graphql/types/ci/config/include_type_enum_spec.rb'
@@ -1708,7 +1630,6 @@ RSpec/FeatureCategory:
- 'spec/graphql/types/clusters/agent_activity_event_type_spec.rb'
- 'spec/graphql/types/clusters/agent_token_status_enum_spec.rb'
- 'spec/graphql/types/clusters/agent_token_type_spec.rb'
- - 'spec/graphql/types/clusters/agent_type_spec.rb'
- 'spec/graphql/types/color_type_spec.rb'
- 'spec/graphql/types/commit_action_mode_enum_spec.rb'
- 'spec/graphql/types/commit_encoding_enum_spec.rb'
@@ -1868,8 +1789,6 @@ RSpec/FeatureCategory:
- 'spec/graphql/types/time_tracking/timelog_category_type_spec.rb'
- 'spec/graphql/types/time_type_spec.rb'
- 'spec/graphql/types/timeframe_type_spec.rb'
- - 'spec/graphql/types/todo_type_spec.rb'
- - 'spec/graphql/types/todoable_interface_spec.rb'
- 'spec/graphql/types/tree/blob_type_spec.rb'
- 'spec/graphql/types/tree/submodule_type_spec.rb'
- 'spec/graphql/types/tree/tree_entry_type_spec.rb'
@@ -1890,12 +1809,9 @@ RSpec/FeatureCategory:
- 'spec/graphql/types/work_items/widgets/hierarchy_update_input_type_spec.rb'
- 'spec/graphql/types/work_items/widgets/labels_type_spec.rb'
- 'spec/graphql/types/work_items/widgets/labels_update_input_type_spec.rb'
- - 'spec/graphql/types/work_items/widgets/start_and_due_date_type_spec.rb'
- - 'spec/graphql/types/work_items/widgets/start_and_due_date_update_input_type_spec.rb'
- 'spec/graphql/types/x509_certificate_type_spec.rb'
- 'spec/graphql/types/x509_issuer_type_spec.rb'
- 'spec/haml_lint/linter/inline_javascript_spec.rb'
- - 'spec/helpers/access_tokens_helper_spec.rb'
- 'spec/helpers/admin/application_settings/settings_helper_spec.rb'
- 'spec/helpers/admin/background_migrations_helper_spec.rb'
- 'spec/helpers/admin/deploy_key_helper_spec.rb'
@@ -1920,8 +1836,6 @@ RSpec/FeatureCategory:
- 'spec/helpers/cookies_helper_spec.rb'
- 'spec/helpers/dashboard_helper_spec.rb'
- 'spec/helpers/dev_ops_report_helper_spec.rb'
- - 'spec/helpers/dropdowns_helper_spec.rb'
- - 'spec/helpers/emails_helper_spec.rb'
- 'spec/helpers/emoji_helper_spec.rb'
- 'spec/helpers/enable_search_settings_helper_spec.rb'
- 'spec/helpers/explore_helper_spec.rb'
@@ -1932,10 +1846,8 @@ RSpec/FeatureCategory:
- 'spec/helpers/gitlab_routing_helper_spec.rb'
- 'spec/helpers/gitlab_script_tag_helper_spec.rb'
- 'spec/helpers/graph_helper_spec.rb'
- - 'spec/helpers/groups/group_members_helper_spec.rb'
- 'spec/helpers/hooks_helper_spec.rb'
- 'spec/helpers/icons_helper_spec.rb'
- - 'spec/helpers/import_helper_spec.rb'
- 'spec/helpers/instance_configuration_helper_spec.rb'
- 'spec/helpers/invite_members_helper_spec.rb'
- 'spec/helpers/issuables_description_templates_helper_spec.rb'
@@ -1944,9 +1856,7 @@ RSpec/FeatureCategory:
- 'spec/helpers/lazy_image_tag_helper_spec.rb'
- 'spec/helpers/listbox_helper_spec.rb'
- 'spec/helpers/members_helper_spec.rb'
- - 'spec/helpers/milestones_helper_spec.rb'
- 'spec/helpers/notifications_helper_spec.rb'
- - 'spec/helpers/notify_helper_spec.rb'
- 'spec/helpers/numbers_helper_spec.rb'
- 'spec/helpers/one_trust_helper_spec.rb'
- 'spec/helpers/operations_helper_spec.rb'
@@ -1954,7 +1864,6 @@ RSpec/FeatureCategory:
- 'spec/helpers/pagination_helper_spec.rb'
- 'spec/helpers/preferences_helper_spec.rb'
- 'spec/helpers/preferred_language_switcher_helper_spec.rb'
- - 'spec/helpers/profiles_helper_spec.rb'
- 'spec/helpers/programming_languages_helper_spec.rb'
- 'spec/helpers/projects/alert_management_helper_spec.rb'
- 'spec/helpers/projects/error_tracking_helper_spec.rb'
@@ -1962,7 +1871,6 @@ RSpec/FeatureCategory:
- 'spec/helpers/projects/incidents_helper_spec.rb'
- 'spec/helpers/projects/pages_helper_spec.rb'
- 'spec/helpers/projects/pipeline_helper_spec.rb'
- - 'spec/helpers/projects/project_members_helper_spec.rb'
- 'spec/helpers/projects/security/configuration_helper_spec.rb'
- 'spec/helpers/projects/terraform_helper_spec.rb'
- 'spec/helpers/recaptcha_helper_spec.rb'
@@ -1973,7 +1881,6 @@ RSpec/FeatureCategory:
- 'spec/helpers/sourcegraph_helper_spec.rb'
- 'spec/helpers/ssh_keys_helper_spec.rb'
- 'spec/helpers/startupjs_helper_spec.rb'
- - 'spec/helpers/stat_anchors_helper_spec.rb'
- 'spec/helpers/subscribable_banner_helper_spec.rb'
- 'spec/helpers/tab_helper_spec.rb'
- 'spec/helpers/time_helper_spec.rb'
@@ -1986,7 +1893,6 @@ RSpec/FeatureCategory:
- 'spec/helpers/web_ide_button_helper_spec.rb'
- 'spec/helpers/webpack_helper_spec.rb'
- 'spec/helpers/whats_new_helper_spec.rb'
- - 'spec/helpers/wiki_page_version_helper_spec.rb'
- 'spec/helpers/x509_helper_spec.rb'
- 'spec/initializers/0_postgresql_types_spec.rb'
- 'spec/initializers/100_patch_omniauth_oauth2_spec.rb'
@@ -2001,7 +1907,6 @@ RSpec/FeatureCategory:
- 'spec/initializers/direct_upload_support_spec.rb'
- 'spec/initializers/doorkeeper_spec.rb'
- 'spec/initializers/fog_google_https_private_urls_spec.rb'
- - 'spec/initializers/forbid_sidekiq_in_transactions_spec.rb'
- 'spec/initializers/global_id_spec.rb'
- 'spec/initializers/google_api_client_spec.rb'
- 'spec/initializers/hashie_mash_permitted_patch_spec.rb'
@@ -2100,7 +2005,6 @@ RSpec/FeatureCategory:
- 'spec/lib/bulk_imports/file_downloads/filename_fetch_spec.rb'
- 'spec/lib/bulk_imports/groups/extractors/subgroups_extractor_spec.rb'
- 'spec/lib/bulk_imports/groups/transformers/subgroup_to_entity_transformer_spec.rb'
- - 'spec/lib/bulk_imports/pipeline/context_spec.rb'
- 'spec/lib/bulk_imports/pipeline/extracted_data_spec.rb'
- 'spec/lib/bulk_imports/pipeline_spec.rb'
- 'spec/lib/bulk_imports/retry_pipeline_error_spec.rb'
@@ -2133,7 +2037,6 @@ RSpec/FeatureCategory:
- 'spec/lib/gitlab/alert_management/payload/generic_spec.rb'
- 'spec/lib/gitlab/alert_management/payload/prometheus_spec.rb'
- 'spec/lib/gitlab/alert_management/payload_spec.rb'
- - 'spec/lib/gitlab/allowable_spec.rb'
- 'spec/lib/gitlab/analytics/cycle_analytics/aggregated/base_query_builder_spec.rb'
- 'spec/lib/gitlab/analytics/cycle_analytics/base_query_builder_spec.rb'
- 'spec/lib/gitlab/analytics/cycle_analytics/median_spec.rb'
@@ -2158,7 +2061,6 @@ RSpec/FeatureCategory:
- 'spec/lib/gitlab/api_authentication/token_type_builder_spec.rb'
- 'spec/lib/gitlab/app_json_logger_spec.rb'
- 'spec/lib/gitlab/app_text_logger_spec.rb'
- - 'spec/lib/gitlab/application_context_spec.rb'
- 'spec/lib/gitlab/application_rate_limiter/base_strategy_spec.rb'
- 'spec/lib/gitlab/application_rate_limiter/increment_per_action_spec.rb'
- 'spec/lib/gitlab/application_rate_limiter/increment_per_actioned_resource_spec.rb'
@@ -2194,7 +2096,6 @@ RSpec/FeatureCategory:
- 'spec/lib/gitlab/auth/otp/strategies/forti_authenticator/manual_otp_spec.rb'
- 'spec/lib/gitlab/auth/otp/strategies/forti_authenticator/push_otp_spec.rb'
- 'spec/lib/gitlab/auth/otp/strategies/forti_token_cloud_spec.rb'
- - 'spec/lib/gitlab/auth/request_authenticator_spec.rb'
- 'spec/lib/gitlab/auth/result_spec.rb'
- 'spec/lib/gitlab/auth/saml/auth_hash_spec.rb'
- 'spec/lib/gitlab/auth/saml/config_spec.rb'
@@ -2208,7 +2109,6 @@ RSpec/FeatureCategory:
- 'spec/lib/gitlab/avatar_cache_spec.rb'
- 'spec/lib/gitlab/background_migration/backfill_integrations_enable_ssl_verification_spec.rb'
- 'spec/lib/gitlab/background_migration/backfill_namespace_id_of_vulnerability_reads_spec.rb'
- - 'spec/lib/gitlab/background_migration/backfill_note_discussion_id_spec.rb'
- 'spec/lib/gitlab/background_migration/backfill_project_feature_package_registry_access_level_spec.rb'
- 'spec/lib/gitlab/background_migration/backfill_topics_title_spec.rb'
- 'spec/lib/gitlab/background_migration/backfill_vulnerability_reads_cluster_agent_spec.rb'
@@ -2241,7 +2141,6 @@ RSpec/FeatureCategory:
- 'spec/lib/gitlab/cache/request_cache_spec.rb'
- 'spec/lib/gitlab/cache_spec.rb'
- 'spec/lib/gitlab/changelog/committer_spec.rb'
- - 'spec/lib/gitlab/changelog/config_spec.rb'
- 'spec/lib/gitlab/changelog/generator_spec.rb'
- 'spec/lib/gitlab/changelog/release_spec.rb'
- 'spec/lib/gitlab/chat/command_spec.rb'
@@ -2326,7 +2225,6 @@ RSpec/FeatureCategory:
- 'spec/lib/gitlab/ci/config/normalizer/matrix_strategy_spec.rb'
- 'spec/lib/gitlab/ci/config/normalizer/number_strategy_spec.rb'
- 'spec/lib/gitlab/ci/config/normalizer_spec.rb'
- - 'spec/lib/gitlab/ci/mask_secret_spec.rb'
- 'spec/lib/gitlab/ci/matching/build_matcher_spec.rb'
- 'spec/lib/gitlab/ci/matching/runner_matcher_spec.rb'
- 'spec/lib/gitlab/ci/parsers/accessibility/pa11y_spec.rb'
@@ -2338,7 +2236,6 @@ RSpec/FeatureCategory:
- 'spec/lib/gitlab/ci/parsers/terraform/tfplan_spec.rb'
- 'spec/lib/gitlab/ci/parsers/test/junit_spec.rb'
- 'spec/lib/gitlab/ci/parsers_spec.rb'
- - 'spec/lib/gitlab/ci/pipeline/chain/assign_partition_spec.rb'
- 'spec/lib/gitlab/ci/pipeline/chain/build_spec.rb'
- 'spec/lib/gitlab/ci/pipeline/chain/command_spec.rb'
- 'spec/lib/gitlab/ci/pipeline/chain/create_spec.rb'
@@ -2378,7 +2275,6 @@ RSpec/FeatureCategory:
- 'spec/lib/gitlab/ci/reports/accessibility_reports_spec.rb'
- 'spec/lib/gitlab/ci/reports/codequality_reports_comparer_spec.rb'
- 'spec/lib/gitlab/ci/reports/codequality_reports_spec.rb'
- - 'spec/lib/gitlab/ci/reports/coverage_report_generator_spec.rb'
- 'spec/lib/gitlab/ci/reports/coverage_report_spec.rb'
- 'spec/lib/gitlab/ci/reports/reports_comparer_spec.rb'
- 'spec/lib/gitlab/ci/reports/security/aggregated_report_spec.rb'
@@ -2486,7 +2382,6 @@ RSpec/FeatureCategory:
- 'spec/lib/gitlab/cluster/lifecycle_events_spec.rb'
- 'spec/lib/gitlab/cluster/mixins/puma_cluster_spec.rb'
- 'spec/lib/gitlab/cluster/rack_timeout_observer_spec.rb'
- - 'spec/lib/gitlab/code_navigation_path_spec.rb'
- 'spec/lib/gitlab/color_schemes_spec.rb'
- 'spec/lib/gitlab/color_spec.rb'
- 'spec/lib/gitlab/conan_token_spec.rb'
@@ -2725,7 +2620,6 @@ RSpec/FeatureCategory:
- 'spec/lib/gitlab/git/lfs_pointer_file_spec.rb'
- 'spec/lib/gitlab/git/merge_base_spec.rb'
- 'spec/lib/gitlab/git/patches/collection_spec.rb'
- - 'spec/lib/gitlab/git/patches/commit_patches_spec.rb'
- 'spec/lib/gitlab/git/patches/patch_spec.rb'
- 'spec/lib/gitlab/git/pre_receive_error_spec.rb'
- 'spec/lib/gitlab/git/push_spec.rb'
@@ -2753,13 +2647,7 @@ RSpec/FeatureCategory:
- 'spec/lib/gitlab/gitaly_client/remote_service_spec.rb'
- 'spec/lib/gitlab/gitaly_client/util_spec.rb'
- 'spec/lib/gitlab/github_import/importer/events/base_importer_spec.rb'
- - 'spec/lib/gitlab/github_import/importer/events/changed_assignee_spec.rb'
- - 'spec/lib/gitlab/github_import/importer/events/changed_label_spec.rb'
- - 'spec/lib/gitlab/github_import/importer/events/changed_milestone_spec.rb'
- 'spec/lib/gitlab/github_import/importer/events/changed_reviewer_spec.rb'
- - 'spec/lib/gitlab/github_import/importer/events/closed_spec.rb'
- - 'spec/lib/gitlab/github_import/importer/events/renamed_spec.rb'
- - 'spec/lib/gitlab/github_import/importer/events/reopened_spec.rb'
- 'spec/lib/gitlab/github_import/importer/issue_and_label_links_importer_spec.rb'
- 'spec/lib/gitlab/github_import/importer/label_links_importer_spec.rb'
- 'spec/lib/gitlab/github_import/importer/lfs_object_importer_spec.rb'
@@ -2845,7 +2733,6 @@ RSpec/FeatureCategory:
- 'spec/lib/gitlab/hook_data/group_builder_spec.rb'
- 'spec/lib/gitlab/hook_data/group_member_builder_spec.rb'
- 'spec/lib/gitlab/hook_data/key_builder_spec.rb'
- - 'spec/lib/gitlab/hook_data/merge_request_builder_spec.rb'
- 'spec/lib/gitlab/hook_data/project_builder_spec.rb'
- 'spec/lib/gitlab/hook_data/project_member_builder_spec.rb'
- 'spec/lib/gitlab/hook_data/release_builder_spec.rb'
@@ -2960,7 +2847,6 @@ RSpec/FeatureCategory:
- 'spec/lib/gitlab/legacy_github_import/release_formatter_spec.rb'
- 'spec/lib/gitlab/legacy_github_import/wiki_formatter_spec.rb'
- 'spec/lib/gitlab/lfs/client_spec.rb'
- - 'spec/lib/gitlab/lfs_token_spec.rb'
- 'spec/lib/gitlab/local_and_remote_storage_migration/artifact_migrater_spec.rb'
- 'spec/lib/gitlab/local_and_remote_storage_migration/pages_deployment_migrater_spec.rb'
- 'spec/lib/gitlab/log_timestamp_formatter_spec.rb'
@@ -2972,7 +2858,6 @@ RSpec/FeatureCategory:
- 'spec/lib/gitlab/mailgun/webhook_processors/member_invites_spec.rb'
- 'spec/lib/gitlab/manifest_import/manifest_spec.rb'
- 'spec/lib/gitlab/manifest_import/metadata_spec.rb'
- - 'spec/lib/gitlab/markdown_cache/active_record/extension_spec.rb'
- 'spec/lib/gitlab/markdown_cache/field_data_spec.rb'
- 'spec/lib/gitlab/markdown_cache/redis/extension_spec.rb'
- 'spec/lib/gitlab/markdown_cache/redis/store_spec.rb'
@@ -3048,7 +2933,6 @@ RSpec/FeatureCategory:
- 'spec/lib/gitlab/pagination/keyset/in_operator_optimization/column_data_spec.rb'
- 'spec/lib/gitlab/pagination/keyset/in_operator_optimization/order_by_column_data_spec.rb'
- 'spec/lib/gitlab/pagination/keyset/in_operator_optimization/order_by_columns_spec.rb'
- - 'spec/lib/gitlab/pagination/keyset/in_operator_optimization/query_builder_spec.rb'
- 'spec/lib/gitlab/pagination/keyset/in_operator_optimization/strategies/order_values_loader_strategy_spec.rb'
- 'spec/lib/gitlab/pagination/keyset/in_operator_optimization/strategies/record_loader_strategy_spec.rb'
- 'spec/lib/gitlab/pagination/keyset/iterator_spec.rb'
@@ -3094,7 +2978,6 @@ RSpec/FeatureCategory:
- 'spec/lib/gitlab/quick_actions/users_extractor_spec.rb'
- 'spec/lib/gitlab/reactive_cache_set_cache_spec.rb'
- 'spec/lib/gitlab/redis/boolean_spec.rb'
- - 'spec/lib/gitlab/redis/cache_spec.rb'
- 'spec/lib/gitlab/redis/hll_spec.rb'
- 'spec/lib/gitlab/redis/queues_spec.rb'
- 'spec/lib/gitlab/redis/rate_limiting_spec.rb'
@@ -3235,7 +3118,6 @@ RSpec/FeatureCategory:
- 'spec/lib/gitlab/tracking/helpers/weak_password_error_event_spec.rb'
- 'spec/lib/gitlab/tracking/incident_management_spec.rb'
- 'spec/lib/gitlab/tracking/service_ping_context_spec.rb'
- - 'spec/lib/gitlab/tree_summary_spec.rb'
- 'spec/lib/gitlab/unicode_spec.rb'
- 'spec/lib/gitlab/untrusted_regexp/ruby_syntax_spec.rb'
- 'spec/lib/gitlab/uploads_transfer_spec.rb'
@@ -3323,7 +3205,6 @@ RSpec/FeatureCategory:
- 'spec/lib/gitlab/webpack/file_loader_spec.rb'
- 'spec/lib/gitlab/webpack/graphql_known_operations_spec.rb'
- 'spec/lib/gitlab/webpack/manifest_spec.rb'
- - 'spec/lib/gitlab/wiki_file_finder_spec.rb'
- 'spec/lib/gitlab/wiki_pages/front_matter_parser_spec.rb'
- 'spec/lib/gitlab/word_diff/chunk_collection_spec.rb'
- 'spec/lib/gitlab/word_diff/line_processor_spec.rb'
@@ -3336,7 +3217,6 @@ RSpec/FeatureCategory:
- 'spec/lib/gitlab/zentao/query_spec.rb'
- 'spec/lib/gitlab/zoom_link_extractor_spec.rb'
- 'spec/lib/gitlab_edition_spec.rb'
- - 'spec/lib/gitlab_spec.rb'
- 'spec/lib/google_api/auth_spec.rb'
- 'spec/lib/google_api/cloud_platform/client_spec.rb'
- 'spec/lib/grafana/client_spec.rb'
@@ -3436,20 +3316,16 @@ RSpec/FeatureCategory:
- 'spec/models/board_group_recent_visit_spec.rb'
- 'spec/models/board_project_recent_visit_spec.rb'
- 'spec/models/board_spec.rb'
- - 'spec/models/bulk_imports/configuration_spec.rb'
- 'spec/models/bulk_imports/file_transfer_spec.rb'
- 'spec/models/chat_team_spec.rb'
- 'spec/models/ci/build_trace_chunk_spec.rb'
- 'spec/models/ci/build_trace_chunks/database_spec.rb'
- 'spec/models/ci/build_trace_chunks/fog_spec.rb'
- 'spec/models/ci/build_trace_chunks/redis_spec.rb'
- - 'spec/models/ci/deleted_object_spec.rb'
- 'spec/models/ci/group_spec.rb'
- 'spec/models/ci/instance_variable_spec.rb'
- - 'spec/models/ci/namespace_mirror_spec.rb'
- 'spec/models/ci/persistent_ref_spec.rb'
- 'spec/models/ci/pipeline_schedule_variable_spec.rb'
- - 'spec/models/ci/project_mirror_spec.rb'
- 'spec/models/ci/resource_spec.rb'
- 'spec/models/ci/trigger_request_spec.rb'
- 'spec/models/ci/unit_test_failure_spec.rb'
@@ -3467,20 +3343,17 @@ RSpec/FeatureCategory:
- 'spec/models/commit_range_spec.rb'
- 'spec/models/commit_signatures/gpg_signature_spec.rb'
- 'spec/models/commit_signatures/x509_commit_signature_spec.rb'
- - 'spec/models/commit_spec.rb'
- 'spec/models/concerns/access_requestable_spec.rb'
- 'spec/models/concerns/after_commit_queue_spec.rb'
- 'spec/models/concerns/approvable_spec.rb'
- 'spec/models/concerns/as_cte_spec.rb'
- 'spec/models/concerns/atomic_internal_id_spec.rb'
- - 'spec/models/concerns/avatarable_spec.rb'
- 'spec/models/concerns/awardable_spec.rb'
- 'spec/models/concerns/batch_destroy_dependent_associations_spec.rb'
- 'spec/models/concerns/batch_nullify_dependent_associations_spec.rb'
- 'spec/models/concerns/blob_language_from_git_attributes_spec.rb'
- 'spec/models/concerns/blocks_unsafe_serialization_spec.rb'
- 'spec/models/concerns/bulk_insertable_associations_spec.rb'
- - 'spec/models/concerns/cache_markdown_field_spec.rb'
- 'spec/models/concerns/cacheable_attributes_spec.rb'
- 'spec/models/concerns/case_sensitivity_spec.rb'
- 'spec/models/concerns/checksummable_spec.rb'
@@ -3555,8 +3428,6 @@ RSpec/FeatureCategory:
- 'spec/models/context_commits_diff_spec.rb'
- 'spec/models/custom_emoji_spec.rb'
- 'spec/models/customer_relations/contact_state_counts_spec.rb'
- - 'spec/models/customer_relations/issue_contact_spec.rb'
- - 'spec/models/customer_relations/organization_spec.rb'
- 'spec/models/cycle_analytics/project_level_stage_adapter_spec.rb'
- 'spec/models/dependency_proxy/blob_spec.rb'
- 'spec/models/dependency_proxy/group_setting_spec.rb'
@@ -3596,12 +3467,10 @@ RSpec/FeatureCategory:
- 'spec/models/gpg_key_spec.rb'
- 'spec/models/gpg_key_subkey_spec.rb'
- 'spec/models/grafana_integration_spec.rb'
- - 'spec/models/group/crm_settings_spec.rb'
- 'spec/models/group_custom_attribute_spec.rb'
- 'spec/models/group_deploy_key_spec.rb'
- 'spec/models/group_deploy_keys_group_spec.rb'
- 'spec/models/group_deploy_token_spec.rb'
- - 'spec/models/group_group_link_spec.rb'
- 'spec/models/group_import_state_spec.rb'
- 'spec/models/group_label_spec.rb'
- 'spec/models/groups/feature_setting_spec.rb'
@@ -3651,7 +3520,6 @@ RSpec/FeatureCategory:
- 'spec/models/legacy_diff_note_spec.rb'
- 'spec/models/lfs_download_object_spec.rb'
- 'spec/models/lfs_file_lock_spec.rb'
- - 'spec/models/lfs_object_spec.rb'
- 'spec/models/lfs_objects_project_spec.rb'
- 'spec/models/license_template_spec.rb'
- 'spec/models/list_spec.rb'
@@ -3667,7 +3535,6 @@ RSpec/FeatureCategory:
- 'spec/models/namespace/aggregation_schedule_spec.rb'
- 'spec/models/namespace_ci_cd_setting_spec.rb'
- 'spec/models/namespace_statistics_spec.rb'
- - 'spec/models/namespaces/project_namespace_spec.rb'
- 'spec/models/namespaces/sync_event_spec.rb'
- 'spec/models/namespaces/user_namespace_spec.rb'
- 'spec/models/notification_setting_spec.rb'
@@ -3704,7 +3571,6 @@ RSpec/FeatureCategory:
- 'spec/models/preloaders/merge_request_diff_preloader_spec.rb'
- 'spec/models/preloaders/project_policy_preloader_spec.rb'
- 'spec/models/programming_language_spec.rb'
- - 'spec/models/project_auto_devops_spec.rb'
- 'spec/models/project_custom_attribute_spec.rb'
- 'spec/models/project_deploy_token_spec.rb'
- 'spec/models/project_import_data_spec.rb'
@@ -3740,7 +3606,6 @@ RSpec/FeatureCategory:
- 'spec/models/synthetic_note_spec.rb'
- 'spec/models/system_note_metadata_spec.rb'
- 'spec/models/term_agreement_spec.rb'
- - 'spec/models/todo_spec.rb'
- 'spec/models/trending_project_spec.rb'
- 'spec/models/upload_spec.rb'
- 'spec/models/uploads/fog_spec.rb'
@@ -3752,7 +3617,6 @@ RSpec/FeatureCategory:
- 'spec/models/user_mentions/merge_request_user_mention_spec.rb'
- 'spec/models/user_mentions/snippet_user_mention_spec.rb'
- 'spec/models/user_status_spec.rb'
- - 'spec/models/users/banned_user_spec.rb'
- 'spec/models/users/callout_spec.rb'
- 'spec/models/users/ghost_user_migration_spec.rb'
- 'spec/models/users/group_callout_spec.rb'
@@ -3764,7 +3628,6 @@ RSpec/FeatureCategory:
- 'spec/models/web_ide_terminal_spec.rb'
- 'spec/models/webauthn_registration_spec.rb'
- 'spec/models/wiki_directory_spec.rb'
- - 'spec/models/wiki_page/meta_spec.rb'
- 'spec/models/wiki_page/slug_spec.rb'
- 'spec/models/work_items/hierarchy_restriction_spec.rb'
- 'spec/models/work_items/widgets/assignees_spec.rb'
@@ -3772,7 +3635,6 @@ RSpec/FeatureCategory:
- 'spec/models/work_items/widgets/description_spec.rb'
- 'spec/models/work_items/widgets/labels_spec.rb'
- 'spec/models/work_items/widgets/milestone_spec.rb'
- - 'spec/models/work_items/widgets/start_and_due_date_spec.rb'
- 'spec/models/x509_certificate_spec.rb'
- 'spec/models/x509_issuer_spec.rb'
- 'spec/models/zoom_meeting_spec.rb'
@@ -3870,7 +3732,6 @@ RSpec/FeatureCategory:
- 'spec/presenters/user_presenter_spec.rb'
- 'spec/presenters/web_hook_log_presenter_spec.rb'
- 'spec/rack_servers/puma_spec.rb'
- - 'spec/requests/api/graphql/ci/runners_spec.rb'
- 'spec/requests/api/graphql/mutations/merge_requests/accept_spec.rb'
- 'spec/requests/api/graphql/mutations/merge_requests/set_labels_spec.rb'
- 'spec/requests/api/resource_state_events_spec.rb'
@@ -3878,10 +3739,8 @@ RSpec/FeatureCategory:
- 'spec/routing/admin_routing_spec.rb'
- 'spec/routing/environments_spec.rb'
- 'spec/routing/git_http_routing_spec.rb'
- - 'spec/routing/group_routing_spec.rb'
- 'spec/routing/notifications_routing_spec.rb'
- 'spec/routing/openid_connect_spec.rb'
- - 'spec/routing/project_routing_spec.rb'
- 'spec/routing/projects/security/configuration_controller_routing_spec.rb'
- 'spec/routing/routing_spec.rb'
- 'spec/routing/uploads_routing_spec.rb'
@@ -3944,7 +3803,6 @@ RSpec/FeatureCategory:
- 'spec/rubocop/cop/graphql/enum_names_spec.rb'
- 'spec/rubocop/cop/graphql/enum_values_spec.rb'
- 'spec/rubocop/cop/graphql/graphql_name_position_spec.rb'
- - 'spec/rubocop/cop/graphql/id_type_spec.rb'
- 'spec/rubocop/cop/graphql/json_type_spec.rb'
- 'spec/rubocop/cop/graphql/old_types_spec.rb'
- 'spec/rubocop/cop/graphql/resolver_type_spec.rb'
@@ -4036,7 +3894,6 @@ RSpec/FeatureCategory:
- 'spec/serializers/analytics_issue_serializer_spec.rb'
- 'spec/serializers/analytics_merge_request_serializer_spec.rb'
- 'spec/serializers/analytics_summary_serializer_spec.rb'
- - 'spec/serializers/base_discussion_entity_spec.rb'
- 'spec/serializers/blob_entity_spec.rb'
- 'spec/serializers/build_action_entity_spec.rb'
- 'spec/serializers/build_artifact_entity_spec.rb'
@@ -4125,7 +3982,6 @@ RSpec/FeatureCategory:
- 'spec/serializers/issue_board_entity_spec.rb'
- 'spec/serializers/issue_entity_spec.rb'
- 'spec/serializers/issue_serializer_spec.rb'
- - 'spec/serializers/issue_sidebar_basic_entity_spec.rb'
- 'spec/serializers/jira_connect/app_data_serializer_spec.rb'
- 'spec/serializers/jira_connect/group_entity_spec.rb'
- 'spec/serializers/jira_connect/subscription_entity_spec.rb'
@@ -4270,7 +4126,6 @@ RSpec/FeatureCategory:
- 'spec/validators/ip_address_validator_spec.rb'
- 'spec/validators/iso8601_date_validator_spec.rb'
- 'spec/validators/js_regex_validator_spec.rb'
- - 'spec/validators/json_schema_validator_spec.rb'
- 'spec/validators/named_ecdsa_key_validator_spec.rb'
- 'spec/validators/namespace_path_validator_spec.rb'
- 'spec/validators/nested_attributes_duplicates_validator_spec.rb'
diff --git a/.rubocop_todo/rspec/file_path.yml b/.rubocop_todo/rspec/file_path.yml
index 0e0c08a18a1e7cf1ff051e5c74a07df2cbb89366..cd09349b3cce0a147c56a5eb44dbeee0a3f6b519 100644
--- a/.rubocop_todo/rspec/file_path.yml
+++ b/.rubocop_todo/rspec/file_path.yml
@@ -64,8 +64,8 @@ RSpec/FilePath:
- 'spec/services/ci/create_pipeline_service/pre_post_stages_spec.rb'
- 'spec/services/ci/create_pipeline_service/rate_limit_spec.rb'
- 'spec/services/ci/create_pipeline_service/rules_spec.rb'
- - 'spec/services/ci/create_pipeline_service/scripts_spec.rb'
- 'spec/services/ci/create_pipeline_service/run_spec.rb'
+ - 'spec/services/ci/create_pipeline_service/scripts_spec.rb'
- 'spec/services/ci/create_pipeline_service/tags_spec.rb'
- 'spec/services/ci/create_pipeline_service/variables_spec.rb'
- 'spec/services/ci/create_pipeline_service/workflow_auto_cancel_spec.rb'
diff --git a/.rubocop_todo/rspec/instance_variable.yml b/.rubocop_todo/rspec/instance_variable.yml
index abf7eac1f5cf28eacd680f70926adf41d24b4c18..666e81d23aba2827d78a2e7bb066fff14c5e31a0 100644
--- a/.rubocop_todo/rspec/instance_variable.yml
+++ b/.rubocop_todo/rspec/instance_variable.yml
@@ -55,7 +55,6 @@ RSpec/InstanceVariable:
- 'spec/features/merge_request/user_sees_pipelines_spec.rb'
- 'spec/features/merge_requests/user_lists_merge_requests_spec.rb'
- 'spec/features/projects/diffs/diff_show_spec.rb'
- - 'spec/features/triggers_spec.rb'
- 'spec/finders/admin/plans_finder_spec.rb'
- 'spec/finders/groups_finder_spec.rb'
- 'spec/frontend/fixtures/listbox.rb'
diff --git a/.rubocop_todo/rspec/named_subject.yml b/.rubocop_todo/rspec/named_subject.yml
index f457bc05d02c9c0f0358986da6002a90d8368101..402ff1721f52732e2876d5617f9ec123bbcc0d33 100644
--- a/.rubocop_todo/rspec/named_subject.yml
+++ b/.rubocop_todo/rspec/named_subject.yml
@@ -198,15 +198,14 @@ RSpec/NamedSubject:
- 'ee/spec/helpers/ee/projects/incidents_helper_spec.rb'
- 'ee/spec/helpers/ee/projects/pipeline_helper_spec.rb'
- 'ee/spec/helpers/ee/subscribable_banner_helper_spec.rb'
+ - 'ee/spec/helpers/gitlab_subscriptions/trials_helper_spec.rb'
- 'ee/spec/helpers/groups/ldap_sync_helper_spec.rb'
- 'ee/spec/helpers/kerberos_helper_spec.rb'
- 'ee/spec/helpers/license_helper_spec.rb'
- - 'ee/spec/helpers/nav/new_dropdown_helper_spec.rb'
- 'ee/spec/helpers/projects/security/dast_profiles_helper_spec.rb'
- 'ee/spec/helpers/projects_helper_spec.rb'
- 'ee/spec/helpers/search_helper_spec.rb'
- 'ee/spec/helpers/secrets_helper_spec.rb'
- - 'ee/spec/helpers/gitlab_subscriptions/trials_helper_spec.rb'
- 'ee/spec/helpers/users/group_callouts_helper_spec.rb'
- 'ee/spec/helpers/users_helper_spec.rb'
- 'ee/spec/helpers/vulnerabilities_helper_spec.rb'
@@ -253,7 +252,6 @@ RSpec/NamedSubject:
- 'ee/spec/lib/bulk_imports/groups/pipelines/iterations_cadences_pipeline_spec.rb'
- 'ee/spec/lib/bulk_imports/groups/pipelines/iterations_pipeline_spec.rb'
- 'ee/spec/lib/code_suggestions/prompts/code_completion/vertex_ai_spec.rb'
- - 'ee/spec/lib/code_suggestions/tasks/base_spec.rb'
- 'ee/spec/lib/ee/api/entities/dependency_list_export_spec.rb'
- 'ee/spec/lib/ee/api/entities/deployment_extended_spec.rb'
- 'ee/spec/lib/ee/api/entities/experiment_spec.rb'
@@ -438,7 +436,6 @@ RSpec/NamedSubject:
- 'ee/spec/lib/gitlab/llm/templates/categorize_question_spec.rb'
- 'ee/spec/lib/gitlab/llm/templates/generate_commit_message_spec.rb'
- 'ee/spec/lib/gitlab/llm/templates/summarize_review_spec.rb'
- - 'ee/spec/lib/gitlab/llm/vertex_ai/completions/summarize_review_spec.rb'
- 'ee/spec/lib/gitlab/llm/vertex_ai/model_configurations/chat_spec.rb'
- 'ee/spec/lib/gitlab/llm/vertex_ai/model_configurations/code_chat_spec.rb'
- 'ee/spec/lib/gitlab/llm/vertex_ai/model_configurations/code_completion_spec.rb'
@@ -453,7 +450,6 @@ RSpec/NamedSubject:
- 'ee/spec/lib/gitlab/proxy_spec.rb'
- 'ee/spec/lib/gitlab/reference_extractor_spec.rb'
- 'ee/spec/lib/gitlab/search/aggregation_spec.rb'
- - 'ee/spec/lib/gitlab/search/client_spec.rb'
- 'ee/spec/lib/gitlab/search_context/builder_spec.rb'
- 'ee/spec/lib/gitlab/sitemaps/generator_spec.rb'
- 'ee/spec/lib/gitlab/sitemaps/sitemap_file_spec.rb'
@@ -749,7 +745,6 @@ RSpec/NamedSubject:
- 'ee/spec/requests/git_http_geo_spec.rb'
- 'ee/spec/requests/groups/dependencies_controller_spec.rb'
- 'ee/spec/requests/groups/epics/epic_links_controller_spec.rb'
- - 'ee/spec/requests/groups/group_members_controller_spec.rb'
- 'ee/spec/requests/groups/protected_branches_controller_spec.rb'
- 'ee/spec/requests/groups/protected_environments_controller_spec.rb'
- 'ee/spec/requests/groups/security/credentials_controller_spec.rb'
@@ -912,10 +907,7 @@ RSpec/NamedSubject:
- 'ee/spec/services/ee/groups/autocomplete_service_spec.rb'
- 'ee/spec/services/ee/groups/deploy_tokens/create_service_spec.rb'
- 'ee/spec/services/ee/groups/deploy_tokens/destroy_service_spec.rb'
- - 'ee/spec/services/ee/groups/deploy_tokens/revoke_service_spec.rb'
- - 'ee/spec/services/ee/groups/group_links/create_service_spec.rb'
- 'ee/spec/services/ee/groups/group_links/destroy_service_spec.rb'
- - 'ee/spec/services/ee/groups/group_links/update_service_spec.rb'
- 'ee/spec/services/ee/ip_restrictions/update_service_spec.rb'
- 'ee/spec/services/ee/issuable/bulk_update_service_spec.rb'
- 'ee/spec/services/ee/issuable/common_system_notes_service_spec.rb'
@@ -935,7 +927,6 @@ RSpec/NamedSubject:
- 'ee/spec/services/ee/notes/post_process_service_spec.rb'
- 'ee/spec/services/ee/notification_service_spec.rb'
- 'ee/spec/services/ee/null_notification_service_spec.rb'
- - 'ee/spec/services/ee/personal_access_tokens/revoke_service_spec.rb'
- 'ee/spec/services/ee/post_receive_service_spec.rb'
- 'ee/spec/services/ee/projects/autocomplete_service_spec.rb'
- 'ee/spec/services/ee/projects/deploy_tokens/create_service_spec.rb'
@@ -961,7 +952,6 @@ RSpec/NamedSubject:
- 'ee/spec/services/epics/related_epic_links/destroy_service_spec.rb'
- 'ee/spec/services/epics/related_epic_links/list_service_spec.rb'
- 'ee/spec/services/epics/reopen_service_spec.rb'
- - 'ee/spec/services/epics/tree_reorder_service_spec.rb'
- 'ee/spec/services/epics/update_service_spec.rb'
- 'ee/spec/services/external_status_checks/dispatch_service_spec.rb'
- 'ee/spec/services/external_status_checks/retry_service_spec.rb'
@@ -1190,7 +1180,6 @@ RSpec/NamedSubject:
- 'qa/spec/service/docker_run/gitlab_runner_spec.rb'
- 'qa/spec/service/docker_run/k3s_spec.rb'
- 'qa/spec/service/shellout_spec.rb'
- - 'qa/spec/specs/parallel_runner_spec.rb'
- 'qa/spec/specs/runner_spec.rb'
- 'qa/spec/support/helpers/masker_spec.rb'
- 'qa/spec/support/repeater_spec.rb'
@@ -1558,7 +1547,6 @@ RSpec/NamedSubject:
- 'spec/lib/api/helpers/caching_spec.rb'
- 'spec/lib/api/helpers/import_github_helpers_spec.rb'
- 'spec/lib/api/helpers/packages/dependency_proxy_helpers_spec.rb'
- - 'spec/lib/api/helpers/packages/npm_spec.rb'
- 'spec/lib/api/helpers/packages_helpers_spec.rb'
- 'spec/lib/api/helpers/pagination_spec.rb'
- 'spec/lib/api/helpers/pagination_strategies_spec.rb'
@@ -1739,7 +1727,6 @@ RSpec/NamedSubject:
- 'spec/lib/gitlab/checks/snippet_check_spec.rb'
- 'spec/lib/gitlab/ci/ansi2json/parser_spec.rb'
- 'spec/lib/gitlab/ci/ansi2json/result_spec.rb'
- - 'spec/lib/gitlab/ci/ansi2json/style_spec.rb'
- 'spec/lib/gitlab/ci/artifact_file_reader_spec.rb'
- 'spec/lib/gitlab/ci/artifacts/decompressed_artifact_size_validator_spec.rb'
- 'spec/lib/gitlab/ci/artifacts/metrics_spec.rb'
@@ -2457,7 +2444,6 @@ RSpec/NamedSubject:
- 'spec/models/ci/job_token/allowlist_spec.rb'
- 'spec/models/ci/job_token/project_scope_link_spec.rb'
- 'spec/models/ci/job_token/scope_spec.rb'
- - 'spec/models/ci/pending_build_spec.rb'
- 'spec/models/ci/persistent_ref_spec.rb'
- 'spec/models/ci/pipeline_artifact_spec.rb'
- 'spec/models/ci/pipeline_message_spec.rb'
@@ -2574,8 +2560,8 @@ RSpec/NamedSubject:
- 'spec/models/integrations/google_play_spec.rb'
- 'spec/models/integrations/irker_spec.rb'
- 'spec/models/integrations/jenkins_spec.rb'
- - 'spec/models/integrations/mattermost_slash_commands_spec.rb'
- 'spec/models/integrations/matrix_spec.rb'
+ - 'spec/models/integrations/mattermost_slash_commands_spec.rb'
- 'spec/models/integrations/pipelines_email_spec.rb'
- 'spec/models/integrations/pivotaltracker_spec.rb'
- 'spec/models/integrations/pushover_spec.rb'
@@ -2595,7 +2581,6 @@ RSpec/NamedSubject:
- 'spec/models/legacy_diff_discussion_spec.rb'
- 'spec/models/lfs_download_object_spec.rb'
- 'spec/models/lfs_object_spec.rb'
- - 'spec/models/lfs_objects_project_spec.rb'
- 'spec/models/loose_foreign_keys/modification_tracker_spec.rb'
- 'spec/models/member_spec.rb'
- 'spec/models/merge_request_diff_commit_spec.rb'
@@ -2608,7 +2593,6 @@ RSpec/NamedSubject:
- 'spec/models/ml/candidate_spec.rb'
- 'spec/models/ml/experiment_spec.rb'
- 'spec/models/ml/model_spec.rb'
- - 'spec/models/namespace/package_setting_spec.rb'
- 'spec/models/namespace/traversal_hierarchy_spec.rb'
- 'spec/models/namespace_setting_spec.rb'
- 'spec/models/namespace_spec.rb'
@@ -2847,7 +2831,6 @@ RSpec/NamedSubject:
- 'spec/serializers/analytics_issue_serializer_spec.rb'
- 'spec/serializers/analytics_merge_request_serializer_spec.rb'
- 'spec/serializers/analytics_summary_serializer_spec.rb'
- - 'spec/serializers/base_discussion_entity_spec.rb'
- 'spec/serializers/blob_entity_spec.rb'
- 'spec/serializers/build_action_entity_spec.rb'
- 'spec/serializers/build_artifact_entity_spec.rb'
@@ -3131,9 +3114,7 @@ RSpec/NamedSubject:
- 'spec/services/keys/destroy_service_spec.rb'
- 'spec/services/keys/expiry_notification_service_spec.rb'
- 'spec/services/lfs/file_transformer_spec.rb'
- - 'spec/services/lfs/lock_file_service_spec.rb'
- 'spec/services/lfs/locks_finder_service_spec.rb'
- - 'spec/services/lfs/unlock_file_service_spec.rb'
- 'spec/services/markdown_content_rewriter_service_spec.rb'
- 'spec/services/mattermost/create_team_service_spec.rb'
- 'spec/services/members/invitation_reminder_email_service_spec.rb'
@@ -3261,7 +3242,6 @@ RSpec/NamedSubject:
- 'spec/services/projects/readme_renderer_service_spec.rb'
- 'spec/services/projects/transfer_service_spec.rb'
- 'spec/services/projects/unlink_fork_service_spec.rb'
- - 'spec/services/projects/update_pages_service_spec.rb'
- 'spec/services/projects/update_repository_storage_service_spec.rb'
- 'spec/services/releases/create_service_spec.rb'
- 'spec/services/releases/destroy_service_spec.rb'
diff --git a/.rubocop_todo/rspec/overwriting_setup.yml b/.rubocop_todo/rspec/overwriting_setup.yml
index 2bca06918fc07e5d1698c62bcbb71864539218c9..7ecc2d7495052bf3403777509d50f80f2e48e956 100644
--- a/.rubocop_todo/rspec/overwriting_setup.yml
+++ b/.rubocop_todo/rspec/overwriting_setup.yml
@@ -12,5 +12,4 @@ RSpec/OverwritingSetup:
- 'spec/models/todo_spec.rb'
- 'spec/models/user_spec.rb'
- 'spec/policies/ci/build_policy_spec.rb'
- - 'spec/services/packages/nuget/search_service_spec.rb'
- 'spec/services/projects/container_repository/gitlab/cleanup_tags_service_spec.rb'
diff --git a/.rubocop_todo/rspec/return_from_stub.yml b/.rubocop_todo/rspec/return_from_stub.yml
index 4968db776ea6fa747e592ec0b42e65efcebdd0bc..e8dc99d559507a23a4493bddd72c785109c03c32 100644
--- a/.rubocop_todo/rspec/return_from_stub.yml
+++ b/.rubocop_todo/rspec/return_from_stub.yml
@@ -37,7 +37,6 @@ RSpec/ReturnFromStub:
- 'ee/spec/views/admin/groups/_form.html.haml_spec.rb'
- 'ee/spec/views/shared/_mirror_update_button.html.haml_spec.rb'
- 'ee/spec/workers/ee/ci/build_finished_worker_spec.rb'
- - 'qa/spec/specs/runner_spec.rb'
- 'spec/benchmarks/banzai_benchmark.rb'
- 'spec/config/settings_spec.rb'
- 'spec/controllers/admin/application_settings_controller_spec.rb'
diff --git a/.rubocop_todo/rspec/scattered_let.yml b/.rubocop_todo/rspec/scattered_let.yml
index 76fbcc06c6e4099835b91c12d4e4169ec29ceefd..93432cb19c30e602f64241e562b72d06733c54c7 100644
--- a/.rubocop_todo/rspec/scattered_let.yml
+++ b/.rubocop_todo/rspec/scattered_let.yml
@@ -79,7 +79,6 @@ RSpec/ScatteredLet:
- 'spec/graphql/resolvers/design_management/version_in_collection_resolver_spec.rb'
- 'spec/graphql/resolvers/group_milestones_resolver_spec.rb'
- 'spec/graphql/resolvers/users/groups_resolver_spec.rb'
- - 'spec/graphql/types/base_object_spec.rb'
- 'spec/graphql/types/ci/job_token_scope_type_spec.rb'
- 'spec/graphql/types/environment_type_spec.rb'
- 'spec/graphql/types/project_type_spec.rb'
diff --git a/.rubocop_todo/rspec/verified_doubles.yml b/.rubocop_todo/rspec/verified_doubles.yml
index a8e51cf5a7301c213c6e27db91c91495e5461bd3..381cceaa90ea59ef5b4d6c6a356fa6fa5d78428b 100644
--- a/.rubocop_todo/rspec/verified_doubles.yml
+++ b/.rubocop_todo/rspec/verified_doubles.yml
@@ -91,7 +91,6 @@ RSpec/VerifiedDoubles:
- 'ee/spec/serializers/blocking_merge_request_entity_spec.rb'
- 'ee/spec/serializers/clusters/environment_entity_spec.rb'
- 'ee/spec/serializers/dashboard_operations_project_entity_spec.rb'
- - 'ee/spec/serializers/dependency_entity_spec.rb'
- 'ee/spec/serializers/ee/admin/user_entity_spec.rb'
- 'ee/spec/serializers/ee/build_details_entity_spec.rb'
- 'ee/spec/serializers/ee/ci/job_entity_spec.rb'
@@ -411,7 +410,6 @@ RSpec/VerifiedDoubles:
- 'spec/lib/gitlab/cleanup/remote_uploads_spec.rb'
- 'spec/lib/gitlab/cluster/rack_timeout_observer_spec.rb'
- 'spec/lib/gitlab/color_schemes_spec.rb'
- - 'spec/lib/gitlab/conan_token_spec.rb'
- 'spec/lib/gitlab/config/entry/configurable_spec.rb'
- 'spec/lib/gitlab/config/entry/factory_spec.rb'
- 'spec/lib/gitlab/config/entry/simplifiable_spec.rb'
diff --git a/.rubocop_todo/search/namespaced_class.yml b/.rubocop_todo/search/namespaced_class.yml
index 0da08684429813da6f1f76dc5b30174532a28ef8..28479ab5826cc8eb5a3d60b6a498ebdf76621ee1 100644
--- a/.rubocop_todo/search/namespaced_class.yml
+++ b/.rubocop_todo/search/namespaced_class.yml
@@ -5,7 +5,6 @@ Search/NamespacedClass:
- 'app/controllers/search_controller.rb'
- 'app/graphql/resolvers/concerns/project_search_arguments.rb'
- 'app/graphql/resolvers/concerns/search_arguments.rb'
- - 'app/graphql/types/issuable_searchable_field_enum.rb'
- 'app/helpers/enable_search_settings_helper.rb'
- 'app/helpers/search_helper.rb'
- 'app/models/concerns/optionally_search.rb'
@@ -18,7 +17,6 @@ Search/NamespacedClass:
- 'app/services/search_service.rb'
- 'ee/app/controllers/admin/elasticsearch_controller.rb'
- 'ee/app/controllers/ee/search_controller.rb'
- - 'ee/app/graphql/types/iteration_searchable_field_enum.rb'
- 'ee/app/helpers/ee/search_helper.rb'
- 'ee/app/models/concerns/elastic/application_versioned_search.rb'
- 'ee/app/models/concerns/elastic/maintain_elasticsearch_on_group_update.rb'
@@ -161,8 +159,6 @@ Search/NamespacedClass:
- 'lib/api/entities/nuget/search_result_version.rb'
- 'lib/api/entities/nuget/search_results.rb'
- 'lib/api/helpers/search_helpers.rb'
- - 'lib/gitlab/background_migration/backfill_imported_issue_search_data.rb'
- - 'lib/gitlab/background_migration/backfill_issue_search_data.rb'
- 'lib/gitlab/elasticsearch/logger.rb'
- 'lib/gitlab/github_import/clients/search_repos.rb'
- 'lib/gitlab/group_search_results.rb'
diff --git a/.rubocop_todo/sidekiq_load_balancing/worker_data_consistency.yml b/.rubocop_todo/sidekiq_load_balancing/worker_data_consistency.yml
index 87c574cc1f1a8374584c0ba892b9f39c5c73d4d2..8880b8cef9b293a3ce283e56be7a1544edb86adf 100644
--- a/.rubocop_todo/sidekiq_load_balancing/worker_data_consistency.yml
+++ b/.rubocop_todo/sidekiq_load_balancing/worker_data_consistency.yml
@@ -11,7 +11,6 @@ SidekiqLoadBalancing/WorkerDataConsistency:
- 'app/workers/authorized_project_update/user_refresh_from_replica_worker.rb'
- 'app/workers/authorized_projects_worker.rb'
- 'app/workers/auto_devops/disable_worker.rb'
- - 'app/workers/auto_merge_process_worker.rb'
- 'app/workers/bulk_import_worker.rb'
- 'app/workers/bulk_imports/entity_worker.rb'
- 'app/workers/bulk_imports/export_request_worker.rb'
@@ -198,7 +197,6 @@ SidekiqLoadBalancing/WorkerDataConsistency:
- 'app/workers/pipeline_metrics_worker.rb'
- 'app/workers/pipeline_process_worker.rb'
- 'app/workers/pipeline_schedule_worker.rb'
- - 'app/workers/post_receive.rb'
- 'app/workers/process_commit_worker.rb'
- 'app/workers/project_cache_worker.rb'
- 'app/workers/project_destroy_worker.rb'
@@ -310,9 +308,7 @@ SidekiqLoadBalancing/WorkerDataConsistency:
- 'ee/app/workers/dependencies/export_worker.rb'
- 'ee/app/workers/deployments/auto_rollback_worker.rb'
- 'ee/app/workers/dora/daily_metrics/refresh_worker.rb'
- - 'ee/app/workers/elastic_association_indexer_worker.rb'
- 'ee/app/workers/elastic_cluster_reindexing_cron_worker.rb'
- - 'ee/app/workers/elastic_commit_indexer_worker.rb'
- 'ee/app/workers/elastic_delete_project_worker.rb'
- 'ee/app/workers/elastic_full_index_worker.rb'
- 'ee/app/workers/elastic_indexing_control_worker.rb'
diff --git a/.rubocop_todo/style/arguments_forwarding.yml b/.rubocop_todo/style/arguments_forwarding.yml
index 901a08dbb32adc5bc847afd94287edfad49d8db2..0aa5fa1124fa96bd690991e802bb0371c0dc6105 100644
--- a/.rubocop_todo/style/arguments_forwarding.yml
+++ b/.rubocop_todo/style/arguments_forwarding.yml
@@ -64,11 +64,9 @@ Style/ArgumentsForwarding:
- 'ee/lib/gitlab/elastic/expr_name.rb'
- 'ee/lib/gitlab/license_scanning/package_licenses.rb'
- 'ee/lib/gitlab/llm/chain/concerns/ai_dependent.rb'
- - 'ee/lib/gitlab/llm/chain/tools/summarize_comments/executor.rb'
- 'ee/lib/gitlab/llm/chain/tools/tool.rb'
- 'ee/lib/gitlab/llm/chat_storage.rb'
- 'ee/lib/gitlab/llm/concerns/exponential_backoff.rb'
- - 'ee/lib/gitlab/llm/tanuki_bot.rb'
- 'ee/lib/gitlab/package_metadata/connector/gcp.rb'
- 'ee/lib/search/zoekt/cache.rb'
- 'ee/lib/security/scan_result_policies/policy_violation_comment.rb'
diff --git a/.rubocop_todo/style/block_delimiters.yml b/.rubocop_todo/style/block_delimiters.yml
index f96817a45d678c36d571af5b4a1bbbaef37cf830..008e4da60777c13684e29d1134ec3b1da9d61268 100644
--- a/.rubocop_todo/style/block_delimiters.yml
+++ b/.rubocop_todo/style/block_delimiters.yml
@@ -26,7 +26,6 @@ Style/BlockDelimiters:
- 'ee/spec/models/protected_environments/deploy_access_level_spec.rb'
- 'ee/spec/models/security/finding_spec.rb'
- 'ee/spec/models/vulnerabilities/feedback_spec.rb'
- - 'ee/spec/services/ee/personal_access_tokens/create_service_spec.rb'
- 'ee/spec/services/gitlab_subscriptions/reconciliations/calculate_seat_count_data_service_spec.rb'
- 'ee/spec/services/package_metadata/advisory_data_object_spec.rb'
- 'ee/spec/services/package_metadata/compressed_package_data_object_spec.rb'
diff --git a/.rubocop_todo/style/empty_method.yml b/.rubocop_todo/style/empty_method.yml
index c1f45ba5469fa21b5f93b8aa701e72ade9885fa7..c0e0fb57bca10f6bae0d89a191503485d49a1373 100644
--- a/.rubocop_todo/style/empty_method.yml
+++ b/.rubocop_todo/style/empty_method.yml
@@ -2,29 +2,6 @@
# Cop supports --autocorrect.
Style/EmptyMethod:
Exclude:
- - 'ee/app/controllers/admin/emails_controller.rb'
- - 'ee/app/controllers/admin/geo/settings_controller.rb'
- - 'ee/app/controllers/admin/push_rules_controller.rb'
- - 'ee/app/controllers/groups/analytics/ci_cd_analytics_controller.rb'
- - 'ee/app/controllers/groups/analytics/cycle_analytics_controller.rb'
- - 'ee/app/controllers/groups/analytics/devops_adoption_controller.rb'
- - 'ee/app/controllers/groups/ldap_group_links_controller.rb'
- - 'ee/app/controllers/groups/settings/reporting_controller.rb'
- - 'ee/app/controllers/projects/analytics/code_reviews_controller.rb'
- - 'ee/app/controllers/projects/analytics/merge_request_analytics_controller.rb'
- - 'ee/app/controllers/projects/incident_management/escalation_policies_controller.rb'
- - 'ee/app/controllers/projects/incident_management/oncall_schedules_controller.rb'
- - 'ee/app/controllers/projects/on_demand_scans_controller.rb'
- - 'ee/app/controllers/projects/security/api_fuzzing_configuration_controller.rb'
- - 'ee/app/controllers/projects/security/corpus_management_controller.rb'
- - 'ee/app/controllers/projects/security/dast_configuration_controller.rb'
- - 'ee/app/controllers/projects/security/dast_profiles_controller.rb'
- - 'ee/app/controllers/projects/security/dast_scanner_profiles_controller.rb'
- - 'ee/app/controllers/projects/security/dast_site_profiles_controller.rb'
- - 'ee/app/controllers/projects/security/sast_configuration_controller.rb'
- - 'ee/app/models/ee/epic.rb'
- - 'ee/app/services/feature_flag_issues/destroy_service.rb'
- - 'ee/db/geo/migrate/20170906174622_remove_duplicates_from_project_registry.rb'
- 'lib/api/helpers/packages/conan/api_helpers.rb'
- 'lib/api/helpers/projects_helpers.rb'
- 'lib/api/projects_relation_builder.rb'
diff --git a/.rubocop_todo/style/format_string.yml b/.rubocop_todo/style/format_string.yml
index bc97f071fc0df81cf7f74a9a3438b89aa24bebcd..97740cdee5bf3c3b3b8e2262761855d2b47618f5 100644
--- a/.rubocop_todo/style/format_string.yml
+++ b/.rubocop_todo/style/format_string.yml
@@ -27,7 +27,6 @@ Style/FormatString:
- 'app/controllers/users_controller.rb'
- 'app/finders/todos_finder.rb'
- 'app/graphql/mutations/release_asset_links/create.rb'
- - 'app/helpers/auth_helper.rb'
- 'app/helpers/button_helper.rb'
- 'app/helpers/ci/builds_helper.rb'
- 'app/helpers/ci/runners_helper.rb'
@@ -70,24 +69,11 @@ Style/FormatString:
- 'app/models/diff_viewer/base.rb'
- 'app/models/integrations/asana.rb'
- 'app/models/integrations/chat_message/pipeline_message.rb'
- - 'app/models/integrations/confluence.rb'
- - 'app/models/integrations/custom_issue_tracker.rb'
- 'app/models/integrations/datadog.rb'
- - 'app/models/integrations/discord.rb'
- 'app/models/integrations/emails_on_push.rb'
- - 'app/models/integrations/ewm.rb'
- - 'app/models/integrations/external_wiki.rb'
- 'app/models/integrations/irker.rb'
- - 'app/models/integrations/jenkins.rb'
- - 'app/models/integrations/mattermost.rb'
- 'app/models/integrations/pipelines_email.rb'
- - 'app/models/integrations/pivotaltracker.rb'
- - 'app/models/integrations/pumble.rb'
- 'app/models/integrations/pushover.rb'
- - 'app/models/integrations/redmine.rb'
- - 'app/models/integrations/unify_circuit.rb'
- - 'app/models/integrations/webex_teams.rb'
- - 'app/models/integrations/youtrack.rb'
- 'app/models/integrations/zentao.rb'
- 'app/models/merge_request_diff.rb'
- 'app/models/milestone.rb'
@@ -98,7 +84,6 @@ Style/FormatString:
- 'app/models/user.rb'
- 'app/models/wiki_page.rb'
- 'app/presenters/ci/pipeline_presenter.rb'
- - 'app/presenters/key_presenter.rb'
- 'app/presenters/merge_request_presenter.rb'
- 'app/presenters/project_presenter.rb'
- 'app/serializers/build_details_entity.rb'
@@ -138,7 +123,6 @@ Style/FormatString:
- 'ee/app/components/namespaces/free_user_cap/enforcement_alert_component.rb'
- 'ee/app/components/namespaces/free_user_cap/usage_quota_alert_component.rb'
- 'ee/app/components/namespaces/free_user_cap/usage_quota_trial_alert_component.rb'
- - 'ee/app/controllers/admin/licenses_controller.rb'
- 'ee/app/controllers/concerns/audit_events/date_range.rb'
- 'ee/app/controllers/ee/projects/issues_controller.rb'
- 'ee/app/controllers/ee/projects_controller.rb'
@@ -207,7 +191,6 @@ Style/FormatString:
- 'ee/lib/gitlab/geo.rb'
- 'ee/lib/gitlab/licenses/submit_license_usage_data_banner.rb'
- 'ee/lib/gitlab/manual_quarterly_co_term_banner.rb'
- - 'ee/spec/controllers/admin/licenses_controller_spec.rb'
- 'ee/spec/controllers/groups/security/policies_controller_spec.rb'
- 'ee/spec/features/admin/admin_settings_spec.rb'
- 'ee/spec/features/admin/admin_users_spec.rb'
diff --git a/.rubocop_todo/style/guard_clause.yml b/.rubocop_todo/style/guard_clause.yml
index 4838e0a5f90817665b07470623ea14942e8bfb8a..dcc0e67717b0778d002835ef2a848c290f0fa8ce 100644
--- a/.rubocop_todo/style/guard_clause.yml
+++ b/.rubocop_todo/style/guard_clause.yml
@@ -105,7 +105,6 @@ Style/GuardClause:
- 'app/models/packages/conan/file_metadatum.rb'
- 'app/models/packages/maven/metadatum.rb'
- 'app/models/packages/package.rb'
- - 'app/models/packages/pypi/metadatum.rb'
- 'app/models/pages_domain.rb'
- 'app/models/personal_access_token.rb'
- 'app/models/project.rb'
@@ -316,15 +315,12 @@ Style/GuardClause:
- 'ee/app/services/security/override_uuids_service.rb'
- 'ee/app/services/timebox_report_service.rb'
- 'ee/app/services/vulnerabilities/security_finding/create_issue_service.rb'
- - 'ee/app/validators/host_validator.rb'
- 'ee/app/validators/user_existence_validator.rb'
- - 'ee/app/workers/ee/ci/build_finished_worker.rb'
- 'ee/app/workers/ee/post_receive.rb'
- 'ee/app/workers/elastic_namespace_rollout_worker.rb'
- 'ee/app/workers/epics/new_epic_issue_worker.rb'
- 'ee/app/workers/geo/scheduler/scheduler_worker.rb'
- 'ee/app/workers/scan_security_report_secrets_worker.rb'
- - 'ee/app/workers/sync_seat_link_request_worker.rb'
- 'ee/db/geo/migrate/20180314175612_add_partial_index_to_project_registy_verification_failure_columns.rb'
- 'ee/db/geo/migrate/20180315222132_add_partial_index_to_project_registy_checksum_columns.rb'
- 'ee/db/geo/migrate/20180412213305_add_index_to_artifact_id_on_job_artifact_registry.rb'
@@ -487,7 +483,6 @@ Style/GuardClause:
- 'lib/gitlab/sanitizers/exif.rb'
- 'lib/gitlab/search/abuse_validators/no_abusive_coercion_from_string_validator.rb'
- 'lib/gitlab/search/abuse_validators/no_abusive_term_length_validator.rb'
- - 'lib/gitlab/search/params.rb'
- 'lib/gitlab/shell.rb'
- 'lib/gitlab/sidekiq_config/cli_methods.rb'
- 'lib/gitlab/sidekiq_middleware/size_limiter/compressor.rb'
diff --git a/.rubocop_todo/style/hash_each_methods.yml b/.rubocop_todo/style/hash_each_methods.yml
index ca73b60b31cf9be2d6136c62b913f967b5000dcd..e5b5e247e0063d70e5f152416b20fd390b7a66f8 100644
--- a/.rubocop_todo/style/hash_each_methods.yml
+++ b/.rubocop_todo/style/hash_each_methods.yml
@@ -84,7 +84,6 @@ Style/HashEachMethods:
- 'lib/gitlab/database/load_balancing/configuration.rb'
- 'lib/gitlab/database/load_balancing/service_discovery/sampler.rb'
- 'lib/gitlab/dependency_linker/podspec_json_linker.rb'
- - 'lib/gitlab/internal_events.rb'
- 'lib/gitlab/language_data.rb'
- 'lib/gitlab/metrics/samplers/ruby_sampler.rb'
- 'lib/gitlab/metrics/subscribers/active_record.rb'
diff --git a/.rubocop_todo/style/if_unless_modifier.yml b/.rubocop_todo/style/if_unless_modifier.yml
index 4393113f5cfed69e392e6310c1e5d217ec44ec3f..9785bf3a6381a7d284c45da9fd4aa03018987043 100644
--- a/.rubocop_todo/style/if_unless_modifier.yml
+++ b/.rubocop_todo/style/if_unless_modifier.yml
@@ -99,7 +99,6 @@ Style/IfUnlessModifier:
- 'app/models/packages/go/module.rb'
- 'app/models/packages/maven/metadatum.rb'
- 'app/models/packages/package.rb'
- - 'app/models/packages/pypi/metadatum.rb'
- 'app/models/pages_domain.rb'
- 'app/models/project.rb'
- 'app/models/project_team.rb'
@@ -167,7 +166,6 @@ Style/IfUnlessModifier:
- 'app/services/issues/relative_position_rebalancing_service.rb'
- 'app/services/issues/update_service.rb'
- 'app/services/lfs/lock_file_service.rb'
- - 'app/services/members/destroy_service.rb'
- 'app/services/merge_requests/add_context_service.rb'
- 'app/services/merge_requests/base_service.rb'
- 'app/services/merge_requests/build_service.rb'
@@ -201,7 +199,6 @@ Style/IfUnlessModifier:
- 'app/services/projects/git_deduplication_service.rb'
- 'app/services/projects/import_export/export_service.rb'
- 'app/services/projects/import_service.rb'
- - 'app/services/projects/lfs_pointers/lfs_download_service.rb'
- 'app/services/projects/operations/update_service.rb'
- 'app/services/projects/overwrite_project_service.rb'
- 'app/services/projects/update_repository_storage_service.rb'
@@ -213,7 +210,6 @@ Style/IfUnlessModifier:
- 'app/services/spam/spam_action_service.rb'
- 'app/services/spam/spam_verdict_service.rb'
- 'app/services/system_notes/issuables_service.rb'
- - 'app/services/tags/destroy_service.rb'
- 'app/services/users/approve_service.rb'
- 'app/services/users/build_service.rb'
- 'app/services/users/respond_to_terms_service.rb'
@@ -266,7 +262,6 @@ Style/IfUnlessModifier:
- 'config/initializers_before_autoloader/002_sidekiq.rb'
- 'config/routes.rb'
- 'danger/database/Dangerfile'
- - 'ee/app/controllers/admin/elasticsearch_controller.rb'
- 'ee/app/controllers/admin/emails_controller.rb'
- 'ee/app/controllers/admin/geo/application_controller.rb'
- 'ee/app/controllers/admin/geo/settings_controller.rb'
@@ -299,7 +294,6 @@ Style/IfUnlessModifier:
- 'ee/app/graphql/resolvers/iterations/cadences_resolver.rb'
- 'ee/app/helpers/ee/integrations_helper.rb'
- 'ee/app/helpers/ee/issues_helper.rb'
- - 'ee/app/helpers/ee/labels_helper.rb'
- 'ee/app/helpers/ee/merge_requests_helper.rb'
- 'ee/app/helpers/ee/notes_helper.rb'
- 'ee/app/helpers/ee/projects/pipeline_helper.rb'
@@ -369,7 +363,6 @@ Style/IfUnlessModifier:
- 'ee/app/services/ee/issuable_base_service.rb'
- 'ee/app/services/ee/issues/base_service.rb'
- 'ee/app/services/ee/merge_requests/refresh_service.rb'
- - 'ee/app/services/ee/milestones/update_service.rb'
- 'ee/app/services/ee/notes/update_service.rb'
- 'ee/app/services/ee/projects/create_service.rb'
- 'ee/app/services/ee/projects/destroy_service.rb'
@@ -377,7 +370,6 @@ Style/IfUnlessModifier:
- 'ee/app/services/ee/todo_service.rb'
- 'ee/app/services/ee/users/update_service.rb'
- 'ee/app/services/elastic/indexing_control_service.rb'
- - 'ee/app/services/elastic/process_bookkeeping_service.rb'
- 'ee/app/services/epics/base_service.rb'
- 'ee/app/services/epics/create_service.rb'
- 'ee/app/services/epics/epic_links/create_service.rb'
@@ -413,7 +405,6 @@ Style/IfUnlessModifier:
- 'ee/app/services/vulnerability_feedback/create_service.rb'
- 'ee/app/services/vulnerability_feedback/destroy_service.rb'
- 'ee/app/services/vulnerability_feedback_module/update_service.rb'
- - 'ee/app/validators/host_validator.rb'
- 'ee/app/validators/password/complexity_validator.rb'
- 'ee/app/workers/app_sec/dast/profile_schedule_worker.rb'
- 'ee/app/workers/audit_events/audit_event_streaming_worker.rb'
@@ -482,7 +473,6 @@ Style/IfUnlessModifier:
- 'ee/spec/finders/custom_project_templates_finder_spec.rb'
- 'ee/spec/finders/security/findings_finder_spec.rb'
- 'ee/spec/finders/security/pipeline_vulnerabilities_finder_spec.rb'
- - 'ee/spec/helpers/ee/users/callouts_helper_spec.rb'
- 'ee/spec/lib/gitlab/analytics/cycle_analytics/data_collector_spec.rb'
- 'ee/spec/models/concerns/elastic/note_spec.rb'
- 'ee/spec/models/push_rule_spec.rb'
@@ -577,7 +567,6 @@ Style/IfUnlessModifier:
- 'lib/gitlab/checks/push_file_count_check.rb'
- 'lib/gitlab/ci/ansi2html.rb'
- 'lib/gitlab/ci/ansi2json/converter.rb'
- - 'lib/gitlab/ci/ansi2json/style.rb'
- 'lib/gitlab/ci/build/artifacts/metadata.rb'
- 'lib/gitlab/ci/build/artifacts/path.rb'
- 'lib/gitlab/ci/build/policy/kubernetes.rb'
@@ -711,7 +700,6 @@ Style/IfUnlessModifier:
- 'lib/gitlab/runtime.rb'
- 'lib/gitlab/sanitizers/exif.rb'
- 'lib/gitlab/sanitizers/svg.rb'
- - 'lib/gitlab/search/params.rb'
- 'lib/gitlab/search_context.rb'
- 'lib/gitlab/sidekiq_config.rb'
- 'lib/gitlab/sidekiq_config/cli_methods.rb'
@@ -731,7 +719,6 @@ Style/IfUnlessModifier:
- 'lib/google_api/auth.rb'
- 'lib/mattermost/client.rb'
- 'lib/mattermost/session.rb'
- - 'lib/microsoft_teams/notifier.rb'
- 'lib/sidebars/groups/menus/packages_registries_menu.rb'
- 'lib/sidebars/menu.rb'
- 'lib/sidebars/projects/menus/ci_cd_menu.rb'
@@ -758,8 +745,6 @@ Style/IfUnlessModifier:
- 'qa/qa/resource/snippet.rb'
- 'qa/qa/scenario/bootable.rb'
- 'qa/qa/service/praefect_manager.rb'
- - 'qa/qa/specs/features/browser_ui/5_package/package_registry/nuget/nuget_group_level_spec.rb'
- - 'qa/qa/specs/parallel_runner.rb'
- 'qa/qa/tools/generate_perf_testdata.rb'
- 'rubocop/cop/api/grape_array_missing_coerce.rb'
- 'rubocop/cop/avoid_keyword_arguments_in_sidekiq_workers.rb'
diff --git a/.rubocop_todo/style/inline_disable_annotation.yml b/.rubocop_todo/style/inline_disable_annotation.yml
index b41eb33cc33c4e4aeed6fb7e61abd19abecea641..d19d66ce46434773495efab92b5a46ce80456ce1 100644
--- a/.rubocop_todo/style/inline_disable_annotation.yml
+++ b/.rubocop_todo/style/inline_disable_annotation.yml
@@ -164,7 +164,6 @@ Style/InlineDisableAnnotation:
- 'app/graphql/gitlab_schema.rb'
- 'app/graphql/graphql_triggers.rb'
- 'app/graphql/mutations/issues/update.rb'
- - 'app/graphql/mutations/metrics/dashboard/annotations/delete.rb'
- 'app/graphql/mutations/projects/sync_fork.rb'
- 'app/graphql/mutations/releases/create.rb'
- 'app/graphql/mutations/work_items/export.rb'
@@ -198,7 +197,6 @@ Style/InlineDisableAnnotation:
- 'app/graphql/types/branch_protections/merge_access_level_type.rb'
- 'app/graphql/types/branch_protections/push_access_level_type.rb'
- 'app/graphql/types/branch_type.rb'
- - 'app/graphql/types/ci/analytics_type.rb'
- 'app/graphql/types/ci/build_need_type.rb'
- 'app/graphql/types/ci/catalog/resource_type.rb'
- 'app/graphql/types/ci/code_quality_report_summary_type.rb'
@@ -306,7 +304,6 @@ Style/InlineDisableAnnotation:
- 'app/graphql/types/tree/tree_entry_type.rb'
- 'app/graphql/types/tree/tree_type.rb'
- 'app/graphql/types/user_callout_type.rb'
- - 'app/graphql/types/user_preferences_type.rb'
- 'app/graphql/types/user_status_type.rb'
- 'app/graphql/types/work_item_id_type.rb'
- 'app/graphql/types/work_items/widgets/assignees_type.rb'
@@ -319,7 +316,6 @@ Style/InlineDisableAnnotation:
- 'app/graphql/types/work_items/widgets/milestone_type.rb'
- 'app/graphql/types/work_items/widgets/notes_type.rb'
- 'app/graphql/types/work_items/widgets/notifications_type.rb'
- - 'app/graphql/types/work_items/widgets/start_and_due_date_type.rb'
- 'app/graphql/types/x509_certificate_type.rb'
- 'app/graphql/types/x509_issuer_type.rb'
- 'app/helpers/application_helper.rb'
@@ -371,7 +367,6 @@ Style/InlineDisableAnnotation:
- 'app/models/clusters/cluster.rb'
- 'app/models/commit.rb'
- 'app/models/commit_collection.rb'
- - 'app/models/commit_status.rb'
- 'app/models/concerns/approvable.rb'
- 'app/models/concerns/async_devise_email.rb'
- 'app/models/concerns/atomic_internal_id.rb'
@@ -433,12 +428,10 @@ Style/InlineDisableAnnotation:
- 'app/models/group_deploy_key.rb'
- 'app/models/hooks/web_hook.rb'
- 'app/models/hooks/web_hook_log.rb'
- - 'app/models/integrations/apple_app_store.rb'
- 'app/models/integrations/base_chat_notification.rb'
- 'app/models/integrations/base_slash_commands.rb'
- 'app/models/integrations/base_third_party_wiki.rb'
- 'app/models/integrations/google_play.rb'
- - 'app/models/integrations/pumble.rb'
- 'app/models/issue.rb'
- 'app/models/key.rb'
- 'app/models/label.rb'
@@ -594,7 +587,6 @@ Style/InlineDisableAnnotation:
- 'app/services/ci/runners/set_runner_associated_projects_service.rb'
- 'app/services/ci/stuck_builds/drop_helpers.rb'
- 'app/services/ci/stuck_builds/drop_pending_service.rb'
- - 'app/services/ci/stuck_builds/drop_running_service.rb'
- 'app/services/ci/track_failed_build_service.rb'
- 'app/services/ci/unlock_artifacts_service.rb'
- 'app/services/ci/unlock_pipeline_service.rb'
@@ -722,7 +714,6 @@ Style/InlineDisableAnnotation:
- 'app/services/todos/destroy/entity_leave_service.rb'
- 'app/services/todos/destroy/unauthorized_features_service.rb'
- 'app/services/topics/merge_service.rb'
- - 'app/services/uploads/destroy_service.rb'
- 'app/services/user_project_access_changed_service.rb'
- 'app/services/users/activate_service.rb'
- 'app/services/users/assigned_issues_count_service.rb'
@@ -1144,7 +1135,6 @@ Style/InlineDisableAnnotation:
- 'ee/app/controllers/projects/approvers_controller.rb'
- 'ee/app/controllers/projects/path_locks_controller.rb'
- 'ee/app/controllers/projects/quality/test_cases_controller.rb'
- - 'ee/app/controllers/registrations/welcome_controller.rb'
- 'ee/app/controllers/sitemap_controller.rb'
- 'ee/app/finders/approval_rules/group_finder.rb'
- 'ee/app/finders/autocomplete/group_subgroups_finder.rb'
@@ -1335,7 +1325,6 @@ Style/InlineDisableAnnotation:
- 'ee/app/models/approval_project_rules_user.rb'
- 'ee/app/models/approver.rb'
- 'ee/app/models/approver_group.rb'
- - 'ee/app/models/ci/finished_build_ch_sync_event.rb'
- 'ee/app/models/ci/minutes/namespace_monthly_usage.rb'
- 'ee/app/models/concerns/elastic/application_versioned_search.rb'
- 'ee/app/models/concerns/epics/metadata_cache_update.rb'
@@ -1411,7 +1400,6 @@ Style/InlineDisableAnnotation:
- 'ee/app/services/ee/groups/autocomplete_service.rb'
- 'ee/app/services/ee/groups/destroy_service.rb'
- 'ee/app/services/ee/groups/update_service.rb'
- - 'ee/app/services/ee/issuable_base_service.rb'
- 'ee/app/services/ee/keys/create_service.rb'
- 'ee/app/services/ee/labels/promote_service.rb'
- 'ee/app/services/ee/lfs/unlock_file_service.rb'
@@ -1465,12 +1453,10 @@ Style/InlineDisableAnnotation:
- 'ee/app/services/security/ingestion/tasks/ingest_vulnerability_flags.rb'
- 'ee/app/services/security/merge_request_security_report_generation_service.rb'
- 'ee/app/services/security/scan_result_policies/sync_any_merge_request_rules_service.rb'
- - 'ee/app/services/security/scan_result_policies/update_approvals_service.rb'
- 'ee/app/services/security/security_orchestration_policies/fetch_policy_approvers_service.rb'
- 'ee/app/services/security/security_orchestration_policies/policy_branches_service.rb'
- 'ee/app/services/security/security_orchestration_policies/process_scan_result_policy_service.rb'
- 'ee/app/services/security/security_orchestration_policies/rule_schedule_service.rb'
- - 'ee/app/services/security/security_orchestration_policies/update_violations_service.rb'
- 'ee/app/services/security/security_orchestration_policies/validate_policy_service.rb'
- 'ee/app/services/security/token_revocation_service.rb'
- 'ee/app/services/security/update_training_service.rb'
@@ -1511,7 +1497,6 @@ Style/InlineDisableAnnotation:
- 'ee/app/workers/ee/post_receive.rb'
- 'ee/app/workers/elastic/migration_worker.rb'
- 'ee/app/workers/elastic/namespace_update_worker.rb'
- - 'ee/app/workers/elastic_association_indexer_worker.rb'
- 'ee/app/workers/elastic_cluster_reindexing_cron_worker.rb'
- 'ee/app/workers/elastic_full_index_worker.rb'
- 'ee/app/workers/elastic_index_bulk_cron_worker.rb'
@@ -1542,7 +1527,6 @@ Style/InlineDisableAnnotation:
- 'ee/app/workers/groups/enterprise_users/associate_worker.rb'
- 'ee/app/workers/groups/enterprise_users/bulk_associate_by_domain_worker.rb'
- 'ee/app/workers/groups/enterprise_users/disassociate_worker.rb'
- - 'ee/app/workers/groups/export_memberships_worker.rb'
- 'ee/app/workers/groups/update_repository_storage_worker.rb'
- 'ee/app/workers/historical_data_worker.rb'
- 'ee/app/workers/import_software_licenses_worker.rb'
@@ -1734,7 +1718,6 @@ Style/InlineDisableAnnotation:
- 'ee/lib/gitlab/status_page/storage/s3_multipart_upload.rb'
- 'ee/lib/gitlab/usage/metrics/instrumentations/license_metric.rb'
- 'ee/lib/gitlab/vulnerability_scanning/advisory.rb'
- - 'ee/lib/gitlab/vulnerability_scanning/security_scanner.rb'
- 'ee/lib/product_analytics/settings.rb'
- 'ee/lib/quality/seeders/vulnerabilities.rb'
- 'ee/lib/system_check/geo/authorized_keys_check.rb'
@@ -1820,7 +1803,6 @@ Style/InlineDisableAnnotation:
- 'ee/spec/presenters/ee/project_presenter_spec.rb'
- 'ee/spec/presenters/ee/projects/import_export/project_export_presenter_spec.rb'
- 'ee/spec/presenters/member_presenter_spec.rb'
- - 'ee/spec/requests/api/conan_project_packages_spec.rb'
- 'ee/spec/requests/api/debian_group_packages_spec.rb'
- 'ee/spec/requests/api/debian_project_packages_spec.rb'
- 'ee/spec/requests/api/geo_sites_spec.rb'
@@ -1833,14 +1815,12 @@ Style/InlineDisableAnnotation:
- 'ee/spec/requests/api/group_service_accounts_spec.rb'
- 'ee/spec/requests/api/groups_spec.rb'
- 'ee/spec/requests/api/internal/base_spec.rb'
- - 'ee/spec/requests/api/pypi_packages_spec.rb'
- 'ee/spec/requests/api/vulnerability_findings_spec.rb'
- 'ee/spec/requests/git_http_geo_spec.rb'
- 'ee/spec/requests/groups/issues_controller_spec.rb'
- 'ee/spec/serializers/vulnerabilities/issue_link_entity_spec.rb'
- 'ee/spec/serializers/vulnerabilities/merge_request_link_entity_spec.rb'
- 'ee/spec/services/app_sec/fuzzing/api/ci_configuration_create_service_spec.rb'
- - 'ee/spec/services/ee/branches/delete_service_spec.rb'
- 'ee/spec/services/ee/resource_events/change_iteration_service_spec.rb'
- 'ee/spec/services/geo/file_registry_removal_service_spec.rb'
- 'ee/spec/services/geo/framework_repository_sync_service_spec.rb'
@@ -1918,7 +1898,6 @@ Style/InlineDisableAnnotation:
- 'lib/api/entities/project_integration.rb'
- 'lib/api/entities/project_with_access.rb'
- 'lib/api/entities/tag.rb'
- - 'lib/api/entities/todo.rb'
- 'lib/api/features.rb'
- 'lib/api/group_boards.rb'
- 'lib/api/groups.rb'
@@ -2290,7 +2269,6 @@ Style/InlineDisableAnnotation:
- 'lib/gitlab/pagination_delegate.rb'
- 'lib/gitlab/patch/action_cable_subscription_adapter_identifier.rb'
- 'lib/gitlab/patch/prependable.rb'
- - 'lib/gitlab/patch/redis_cache_store.rb'
- 'lib/gitlab/patch/sidekiq_cron_poller.rb'
- 'lib/gitlab/performance_bar.rb'
- 'lib/gitlab/performance_bar/redis_adapter_when_peek_enabled.rb'
@@ -2391,7 +2369,6 @@ Style/InlineDisableAnnotation:
- 'metrics_server/override_gitlab_current_settings.rb'
- 'metrics_server/override_rails_constants.rb'
- 'metrics_server/settings_overrides.rb'
- - 'qa/qa/ee/page/admin/subscription.rb'
- 'qa/qa/ee/page/main/banner.rb'
- 'qa/qa/ee/page/project/monitor/on_call_schedule/index.rb'
- 'qa/qa/ee/page/project/settings/merge_request.rb'
@@ -2448,7 +2425,6 @@ Style/InlineDisableAnnotation:
- 'qa/spec/support/formatters/allure_metadata_formatter_spec.rb'
- 'rubocop/cop/gettext/static_identifier.rb'
- 'rubocop/cop/gitlab/feature_available_usage.rb'
- - 'rubocop/cop/graphql/id_type.rb'
- 'rubocop/cop/migration/add_reference.rb'
- 'rubocop/cop/rspec/factory_bot/inline_association.rb'
- 'rubocop/cop/static_translation_definition.rb'
@@ -2505,10 +2481,6 @@ Style/InlineDisableAnnotation:
- 'spec/finders/packages/build_infos_finder_spec.rb'
- 'spec/fixtures/packages/rubygems/package.gemspec'
- 'spec/frontend/fixtures/merge_requests.rb'
- - 'spec/graphql/mutations/clusters/agent_tokens/create_spec.rb'
- - 'spec/graphql/mutations/clusters/agents/create_spec.rb'
- - 'spec/graphql/mutations/clusters/agents/delete_spec.rb'
- - 'spec/graphql/mutations/commits/create_spec.rb'
- 'spec/graphql/mutations/design_management/delete_spec.rb'
- 'spec/graphql/resolvers/board_resolver_spec.rb'
- 'spec/graphql/resolvers/boards_resolver_spec.rb'
@@ -2530,7 +2502,6 @@ Style/InlineDisableAnnotation:
- 'spec/initializers/validate_database_config_spec.rb'
- 'spec/lib/api/base_spec.rb'
- 'spec/lib/api/entities/wiki_page_spec.rb'
- - 'spec/lib/api/helpers/packages/npm_spec.rb'
- 'spec/lib/backup/manager_spec.rb'
- 'spec/lib/banzai/filter/footnote_filter_spec.rb'
- 'spec/lib/banzai/filter/image_link_filter_spec.rb'
@@ -2589,7 +2560,6 @@ Style/InlineDisableAnnotation:
- 'spec/lib/gitlab/git/object_pool_spec.rb'
- 'spec/lib/gitlab/git/remote_mirror_spec.rb'
- 'spec/lib/gitlab/git/tree_spec.rb'
- - 'spec/lib/gitlab/gitaly_client/object_pool_service_spec.rb'
- 'spec/lib/gitlab/grape_logging/loggers/urgency_logger_spec.rb'
- 'spec/lib/gitlab/health_checks/master_check_spec.rb'
- 'spec/lib/gitlab/i18n/po_linter_spec.rb'
@@ -2672,7 +2642,6 @@ Style/InlineDisableAnnotation:
- 'spec/models/ci/job_token/project_scope_link_spec.rb'
- 'spec/models/ci/persistent_ref_spec.rb'
- 'spec/models/ci/pipeline_spec.rb'
- - 'spec/models/ci/runner_manager_build_spec.rb'
- 'spec/models/concerns/bulk_insertable_associations_spec.rb'
- 'spec/models/concerns/encrypted_user_password_spec.rb'
- 'spec/models/concerns/legacy_bulk_insert_spec.rb'
@@ -2687,7 +2656,6 @@ Style/InlineDisableAnnotation:
- 'spec/models/label_spec.rb'
- 'spec/models/member_spec.rb'
- 'spec/models/merge_request_spec.rb'
- - 'spec/models/namespace/package_setting_spec.rb'
- 'spec/models/operations/feature_flags/user_list_spec.rb'
- 'spec/models/project_feature_spec.rb'
- 'spec/models/project_spec.rb'
@@ -2733,7 +2701,6 @@ Style/InlineDisableAnnotation:
- 'spec/services/auto_merge_service_spec.rb'
- 'spec/services/batched_git_ref_updates/cleanup_scheduler_service_spec.rb'
- 'spec/services/boards/lists/list_service_spec.rb'
- - 'spec/services/bulk_imports/create_service_spec.rb'
- 'spec/services/ci/create_pipeline_service/environment_spec.rb'
- 'spec/services/ci/create_pipeline_service/logger_spec.rb'
- 'spec/services/ci/create_pipeline_service_spec.rb'
diff --git a/.rubocop_todo/style/redundant_parentheses.yml b/.rubocop_todo/style/redundant_parentheses.yml
index 867c0c387b982b4d81a2dc517aa2a20f55877789..e17d6949d93a046e433c61bb025a1d9ce45d44f1 100644
--- a/.rubocop_todo/style/redundant_parentheses.yml
+++ b/.rubocop_todo/style/redundant_parentheses.yml
@@ -19,7 +19,6 @@ Style/RedundantParentheses:
- 'ee/app/services/merge_trains/refresh_service.rb'
- 'ee/lib/ee/gitlab/git_access.rb'
- 'ee/lib/ee/gitlab/scim/params_parser.rb'
- - 'ee/lib/elastic/latest/git_class_proxy.rb'
- 'ee/spec/requests/lfs_locks_api_spec.rb'
- 'lib/api/appearance.rb'
- 'lib/file_size_validator.rb'
diff --git a/.rubocop_todo/style/redundant_self.yml b/.rubocop_todo/style/redundant_self.yml
index c7c2f3f23268be039fdf3bde8f2a19fd59f63c05..068449fa7b755a6a9ea24574227b610ce38c0d91 100644
--- a/.rubocop_todo/style/redundant_self.yml
+++ b/.rubocop_todo/style/redundant_self.yml
@@ -50,7 +50,6 @@ Style/RedundantSelf:
- 'app/models/concerns/merge_request_reviewer_state.rb'
- 'app/models/concerns/participable.rb'
- 'app/models/concerns/pg_full_text_searchable.rb'
- - 'app/models/concerns/protected_ref.rb'
- 'app/models/concerns/reactive_caching.rb'
- 'app/models/concerns/redis_cacheable.rb'
- 'app/models/concerns/resolvable_discussion.rb'
@@ -160,7 +159,6 @@ Style/RedundantSelf:
- 'ee/app/models/concerns/custom_model_naming.rb'
- 'ee/app/models/concerns/ee/issuable_link.rb'
- 'ee/app/models/concerns/ee/participable.rb'
- - 'ee/app/models/concerns/ee/protected_ref.rb'
- 'ee/app/models/concerns/elastic/application_versioned_search.rb'
- 'ee/app/models/concerns/elasticsearch_indexed_container.rb'
- 'ee/app/models/concerns/geo/replicable_model.rb'
diff --git a/.rubocop_todo/style/string_concatenation.yml b/.rubocop_todo/style/string_concatenation.yml
index 8aa6ceaf3847fe49c6ee5554c0a209d173dab9eb..ca2cba74cf5db318e4655d2fd15c8f6ef65971a7 100644
--- a/.rubocop_todo/style/string_concatenation.yml
+++ b/.rubocop_todo/style/string_concatenation.yml
@@ -29,7 +29,6 @@ Style/StringConcatenation:
- 'app/uploaders/object_storage.rb'
- 'config/initializers/1_settings.rb'
- 'config/settings.rb'
- - 'ee/app/controllers/admin/elasticsearch_controller.rb'
- 'ee/app/finders/ee/issuables/label_filter.rb'
- 'ee/app/helpers/ee/geo_helper.rb'
- 'ee/app/helpers/ee/gitlab_routing_helper.rb'
@@ -241,7 +240,6 @@ Style/StringConcatenation:
- 'spec/services/snippets/bulk_destroy_service_spec.rb'
- 'spec/services/snippets/update_service_spec.rb'
- 'spec/services/todo_service_spec.rb'
- - 'spec/support/capybara.rb'
- 'spec/support/helpers/ci_artifact_metadata_generator.rb'
- 'spec/support/helpers/gitaly_setup.rb'
- 'spec/support/helpers/javascript_fixtures_helpers.rb'
diff --git a/.rubocop_todo/style/string_literals_in_interpolation.yml b/.rubocop_todo/style/string_literals_in_interpolation.yml
index 00a353b39d2d96aba1be7d818a146fc3dc3adbc8..148f537d557397d019edacc4b8722a9cb27505d3 100644
--- a/.rubocop_todo/style/string_literals_in_interpolation.yml
+++ b/.rubocop_todo/style/string_literals_in_interpolation.yml
@@ -40,7 +40,6 @@ Style/StringLiteralsInInterpolation:
- 'spec/lib/banzai/filter/references/commit_reference_filter_spec.rb'
- 'spec/lib/banzai/filter/references/issue_reference_filter_spec.rb'
- 'spec/lib/gitlab/background_migration/batched_migration_job_spec.rb'
- - 'spec/lib/gitlab/ci/parsers/security/validators/schema_validator_spec.rb'
- 'spec/lib/gitlab/database/partitioning_migration_helpers/table_management_helpers_spec.rb'
- 'spec/lib/gitlab/gitaly_client/ref_service_spec.rb'
- 'spec/lib/object_storage/direct_upload_spec.rb'
diff --git a/.rubocop_todo/style/symbol_proc.yml b/.rubocop_todo/style/symbol_proc.yml
index 1352f750a92f2ee159c009ec64c983bc087c549e..f33ac35188917902128f4ab66a93b0814a5cbc23 100644
--- a/.rubocop_todo/style/symbol_proc.yml
+++ b/.rubocop_todo/style/symbol_proc.yml
@@ -8,7 +8,6 @@ Style/SymbolProc:
- 'app/models/discussion.rb'
- 'app/models/environment.rb'
- 'app/models/integrations/prometheus.rb'
- - 'app/models/label_note.rb'
- 'app/models/members/project_member.rb'
- 'app/models/preloaders/merge_request_diff_preloader.rb'
- 'app/models/release.rb'
@@ -73,7 +72,6 @@ Style/SymbolProc:
- 'ee/app/workers/geo/sync_timeout_cron_worker.rb'
- 'ee/app/workers/geo/verification_cron_worker.rb'
- 'ee/lib/api/entities/pending_member.rb'
- - 'ee/lib/api/related_epic_links.rb'
- 'ee/lib/ee/api/entities/audit_event.rb'
- 'ee/lib/ee/api/entities/geo_node.rb'
- 'ee/lib/ee/api/entities/merge_request_approval_state.rb'