From 4b2d88b6c9fd87276d5939332c5542a11e3b8f5e Mon Sep 17 00:00:00 2001 From: gdk <gdk@example.com> Date: Tue, 7 May 2024 03:13:02 +0000 Subject: [PATCH] Quarantine a flaky test The `bin/diagnostic-reports-uploader starts successfully` test has the `flakiness::1` label set, which means it has more than 1000 flakiness reports. This MR quarantines the test. This is a discussion starting point to let the responsible group know about the flakiness so that they can take action: - accept the merge request and schedule to improve the test - close the merge request in favor of another merge request to delete the test Related to https://gitlab.com/gitlab-org/gitlab/-/issues/448411. This change was generated by [gitlab-housekeeper](https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-housekeeper) using the Keeps::QuarantineFlakyTests keep. To provide feedback on your experience with `gitlab-housekeeper` please comment in <https://gitlab.com/gitlab-org/gitlab/-/issues/442003>. Changelog: other --- spec/commands/diagnostic_reports/uploader_smoke_spec.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/commands/diagnostic_reports/uploader_smoke_spec.rb b/spec/commands/diagnostic_reports/uploader_smoke_spec.rb index 9fbceb688449f..1ec4eb407d8b6 100644 --- a/spec/commands/diagnostic_reports/uploader_smoke_spec.rb +++ b/spec/commands/diagnostic_reports/uploader_smoke_spec.rb @@ -57,7 +57,7 @@ FileUtils.rm_rf(reports_dir, secure: true) end - it 'starts successfully' do + it 'starts successfully', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/448411' do expect(File.exist?(report.path)).to be true bin_path = rails_root_join("bin/diagnostic-reports-uploader") -- GitLab