From 45fa2cc48dfa836f128da63a31f018946b85076c Mon Sep 17 00:00:00 2001
From: Dmitry Gruzd <dgruzd@gitlab.com>
Date: Mon, 17 Feb 2025 15:22:01 +0000
Subject: [PATCH] Fix the migrate.rb script
---
scripts/database/migrate.rb | 55 +++++++++++++++++++++++--------------
1 file changed, 34 insertions(+), 21 deletions(-)
diff --git a/scripts/database/migrate.rb b/scripts/database/migrate.rb
index b0a78ecbee96c..646d1a3bd5688 100755
--- a/scripts/database/migrate.rb
+++ b/scripts/database/migrate.rb
@@ -16,7 +16,11 @@
# $ ./scripts/database/migrate.rb -t down
# This will show a list of changed migration files and allow you to select which ones to revert.
#
-# 3. Debug mode:
+# 3. Dry run mode:
+# $ ./scripts/database/migrate.rb -n
+# This will show what commands would be executed without actually running them.
+#
+# 4. Debug mode:
# $ ruby scripts/database/migrate.rb --debug
# This will run the script with additional debug output for troubleshooting.
#
@@ -38,7 +42,8 @@ def require_commands!(*commands)
def parse_options
options = {
- task: :up
+ task: :up,
+ dry_run: false
}
OptionParser.new do |opts|
opts.banner = "Usage: #{SCRIPT_NAME} [options]"
@@ -46,7 +51,10 @@ def parse_options
opts.on('--debug', 'Enable debug mode') do |v|
options[:debug] = v
end
- opts.on('-t', '--task=[up|down]', 'Set task - "up" to migrate forward, "down" to rollback') do |v|
+ opts.on('-n', '--dry-run', 'Show commands without executing them') do |v|
+ options[:dry_run] = v
+ end
+ opts.on('-t', '--task [up|down]', [:up, :down], 'Set task - "up" to migrate forward, "down" to rollback') do |v|
options[:task] = v
end
end.parse!
@@ -109,25 +117,30 @@ def execute
sorted = selected_files.sort_by { |f| f.match(/^\d+/)[0].to_i }
puts "Sorted: #{sorted.inspect}" if options[:debug]
- case options[:task].to_sym
- when :up
- sorted.each do |file|
- version = file.match(/^\d+/)[0].to_i
-
- cmd = "bin/rails db:migrate:up:main db:migrate:up:ci VERSION=#{version}"
- puts "$ #{cmd}"
- raise "Migration #{version} failed" unless system(cmd)
+ migrations = case options[:task]
+ when :up
+ sorted.map do |file|
+ version = file.match(/^\d+/)[0].to_i
+ "bin/rails db:migrate:up:main db:migrate:up:ci VERSION=#{version}"
+ end
+ when :down
+ sorted.reverse.map do |file|
+ version = file.match(/^\d+/)[0].to_i
+ "bin/rails db:migrate:down:main db:migrate:down:ci VERSION=#{version}"
+ end
+ else
+ puts 'Invalid task. Use --task=[up|down]'
+ exit 1
+ end
+
+ migrations.each do |cmd|
+ puts "$ #{cmd}"
+
+ if options[:dry_run]
+ puts "[dry-run] Skipping execution"
+ else
+ raise "Migration failed: #{cmd}" unless system(cmd)
end
- when :down
- sorted.reverse_each do |file|
- version = file.match(/^\d+/)[0].to_i
- cmd = "bin/rails db:migrate:down:main db:migrate:down:ci VERSION=#{version}"
- puts "$ #{cmd}"
- raise "Migration #{version} failed" unless system(cmd)
- end
- else
- puts 'Invalid task. Use --task=[up|down]'
- exit 1
end
end
# rubocop:enable Metrics/CyclomaticComplexity,Metrics/PerceivedComplexity
--
GitLab