diff --git a/.rubocop_manual_todo.yml b/.rubocop_manual_todo.yml index 496831acb6591325708d4efd3bcad40a590b411f..185bbb36e601c9a57da952cad4e559aaca281ada 100644 --- a/.rubocop_manual_todo.yml +++ b/.rubocop_manual_todo.yml @@ -412,8 +412,6 @@ Rails/TimeZone: # WIP: https://gitlab.com/gitlab-org/gitlab/-/issues/325836 RSpec/EmptyLineAfterFinalLetItBe: Exclude: - - ee/spec/controllers/admin/geo/projects_controller_spec.rb - - ee/spec/controllers/admin/projects_controller_spec.rb - ee/spec/controllers/groups/analytics/cycle_analytics/stages_controller_spec.rb - ee/spec/controllers/groups/analytics/cycle_analytics/summary_controller_spec.rb - ee/spec/controllers/groups/analytics/cycle_analytics/value_streams_controller_spec.rb diff --git a/ee/changelogs/unreleased/rspec-empty-lines-after-letitbe-ee-spec-controllers-admin.yml b/ee/changelogs/unreleased/rspec-empty-lines-after-letitbe-ee-spec-controllers-admin.yml new file mode 100644 index 0000000000000000000000000000000000000000..f3b849ea8a30abae74b08085a4b4bdcac8d04cee --- /dev/null +++ b/ee/changelogs/unreleased/rspec-empty-lines-after-letitbe-ee-spec-controllers-admin.yml @@ -0,0 +1,5 @@ +--- +title: Fix RSpec/EmptyLineAfterFinalLetItBe rubocop offenses in ee/spec/controllers/admin +merge_request: 58417 +author: Abdul Wadood @abdulwd +type: fixed diff --git a/ee/spec/controllers/admin/geo/projects_controller_spec.rb b/ee/spec/controllers/admin/geo/projects_controller_spec.rb index 15d6c31f84bc975699702fb7ca1d0103ce4dc0bc..449c73f4c34a7043c5a47db22434f2405c5c4577 100644 --- a/ee/spec/controllers/admin/geo/projects_controller_spec.rb +++ b/ee/spec/controllers/admin/geo/projects_controller_spec.rb @@ -7,6 +7,7 @@ let_it_be(:admin) { create(:admin) } let_it_be(:geo_primary) { create(:geo_node, :primary) } + let(:synced_registry) { create(:geo_project_registry, :synced) } before do diff --git a/ee/spec/controllers/admin/projects_controller_spec.rb b/ee/spec/controllers/admin/projects_controller_spec.rb index c85a6cae0cc1b73c7622956e61365d5c75ce400c..01b51170dd871f606f6fba6d92010589d168dcc2 100644 --- a/ee/spec/controllers/admin/projects_controller_spec.rb +++ b/ee/spec/controllers/admin/projects_controller_spec.rb @@ -6,6 +6,7 @@ include EE::GeoHelpers let_it_be(:geo_primary) { create(:geo_node, :primary) } + let!(:project_registry) { create(:geo_project_registry) } let(:project) { project_registry.project }