From 42a58912f274e53425de84337eaa66f5135606ff Mon Sep 17 00:00:00 2001 From: Jonston Chan <jonstonchan1@gmail.com> Date: Sun, 23 Apr 2023 03:27:24 +0000 Subject: [PATCH] Improve Vale's CIConfigFile rule to catch previous false negatives Changelog: fixed --- doc/.vale/gitlab/CIConfigFile.yml | 6 +----- doc/user/application_security/dast/proxy-based.md | 2 +- doc/user/application_security/secret_detection/index.md | 2 +- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/doc/.vale/gitlab/CIConfigFile.yml b/doc/.vale/gitlab/CIConfigFile.yml index 4d2ba45441046..5cbd02e799b51 100644 --- a/doc/.vale/gitlab/CIConfigFile.yml +++ b/doc/.vale/gitlab/CIConfigFile.yml @@ -10,8 +10,4 @@ link: https://docs.gitlab.com/ee/development/documentation/versions.html level: error scope: raw raw: - - '(`gitlab-ci.yml`|' - - '`gitlabci.yml`|' - - '`gitlab.ci.yml`|' - - '`.gitlab.ci-yml`|' - - '`.gitlab-ci.yaml`)' + - '(?!`\.gitlab-ci\.yml`)`.?gitlab.?ci.?ya?ml`' diff --git a/doc/user/application_security/dast/proxy-based.md b/doc/user/application_security/dast/proxy-based.md index ae2d04ae4bb25..8b71e340a4352 100644 --- a/doc/user/application_security/dast/proxy-based.md +++ b/doc/user/application_security/dast/proxy-based.md @@ -80,7 +80,7 @@ To enable DAST to run automatically, either: - Enable [Auto DAST](../../../topics/autodevops/stages.md#auto-dast) (provided by [Auto DevOps](../../../topics/autodevops/index.md)). -- [Edit the `.gitlab.ci.yml` file manually](#edit-the-gitlab-ciyml-file-manually). +- [Edit the `.gitlab-ci.yml` file manually](#edit-the-gitlab-ciyml-file-manually). - [Configure DAST using the UI](#configure-dast-using-the-ui). #### Edit the `.gitlab-ci.yml` file manually diff --git a/doc/user/application_security/secret_detection/index.md b/doc/user/application_security/secret_detection/index.md index 49bab0b3b29f1..b5209b4209852 100644 --- a/doc/user/application_security/secret_detection/index.md +++ b/doc/user/application_security/secret_detection/index.md @@ -142,7 +142,7 @@ To enable Secret Detection, either: - Enable [Auto DevOps](../../../topics/autodevops/index.md), which includes [Auto Secret Detection](../../../topics/autodevops/stages.md#auto-secret-detection). -- [Edit the `.gitlab.ci.yml` file manually](#edit-the-gitlab-ciyml-file-manually). Use this method +- [Edit the `.gitlab-ci.yml` file manually](#edit-the-gitlab-ciyml-file-manually). Use this method if your `.gitlab-ci.yml` file is complex. - [Use an automatically configured merge request](#use-an-automatically-configured-merge-request). -- GitLab