From 4202a7265411380b403ae97da9b825e46d167ca3 Mon Sep 17 00:00:00 2001
From: James Fargher <proglottis@gmail.com>
Date: Fri, 13 Dec 2019 11:04:51 +1300
Subject: [PATCH] Automatically fixed EmptyLineAfterFinalLet in ee/
Ran: bundle exec rubocop --only RSpec/EmptyLineAfterFinalLet -a ee/
---
.../analytics/cycle_analytics/stages_controller_spec.rb | 1 +
.../controllers/analytics/tasks_by_type_controller_spec.rb | 1 +
ee/spec/controllers/concerns/boards_responses_spec.rb | 2 ++
ee/spec/controllers/concerns/internal_redirect_spec.rb | 1 +
ee/spec/controllers/projects/push_rules_controller_spec.rb | 1 +
ee/spec/features/security/group/internal_access_spec.rb | 1 +
ee/spec/features/security/group/public_access_spec.rb | 1 +
ee/spec/features/security/project/internal_access_spec.rb | 4 ++++
ee/spec/features/security/project/private_access_spec.rb | 2 ++
ee/spec/features/security/project/public_access_spec.rb | 3 +++
ee/spec/finders/issues_finder_spec.rb | 1 +
ee/spec/finders/licenses_finder_spec.rb | 1 +
ee/spec/finders/packages/group_packages_finder_spec.rb | 1 +
.../graphql/mutations/merge_requests/set_assignees_spec.rb | 2 ++
ee/spec/helpers/ee/labels_helper_spec.rb | 1 +
ee/spec/helpers/kerberos_spnego_helper_spec.rb | 1 +
ee/spec/helpers/license_helper_spec.rb | 1 +
ee/spec/helpers/search_helper_spec.rb | 1 +
ee/spec/helpers/users_helper_spec.rb | 1 +
ee/spec/lib/ee/gitlab/auth/ldap/access_levels_spec.rb | 2 ++
ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb | 5 +++++
.../lib/ee/gitlab/cleanup/orphan_job_artifact_files_spec.rb | 1 +
.../gitlab/analytics/cycle_analytics/request_params_spec.rb | 1 +
ee/spec/lib/gitlab/auth/auth_finders_spec.rb | 2 ++
ee/spec/lib/gitlab/auth/smartcard/ldap_certificate_spec.rb | 1 +
.../lib/gitlab/ci/reports/license_scanning/report_spec.rb | 4 ++++
ee/spec/lib/gitlab/elastic/project_search_results_spec.rb | 1 +
ee/spec/lib/gitlab/elastic/search_results_spec.rb | 1 +
ee/spec/lib/gitlab/geo/event_gap_tracking_spec.rb | 1 +
ee/spec/lib/gitlab/geo/git_push_http_spec.rb | 1 +
.../gitlab/geo/replication/job_artifact_retriever_spec.rb | 1 +
ee/spec/lib/gitlab/ip_address_state_spec.rb | 1 +
ee/spec/lib/gitlab/prometheus/queries/cluster_query_spec.rb | 1 +
ee/spec/lib/gitlab/prometheus/queries/validate_query_spec.rb | 2 ++
ee/spec/lib/pseudonymizer/dumper_spec.rb | 1 +
ee/spec/lib/pseudonymizer/pager_spec.rb | 1 +
ee/spec/lib/pseudonymizer/uploader_spec.rb | 1 +
ee/spec/mailers/notify_spec.rb | 3 +++
ee/spec/models/approvable_spec.rb | 1 +
ee/spec/models/design_management/version_spec.rb | 1 +
ee/spec/models/ee/list_spec.rb | 1 +
ee/spec/models/gitlab_subscription_spec.rb | 1 +
ee/spec/models/issue_spec.rb | 2 ++
ee/spec/models/license_spec.rb | 3 +++
ee/spec/models/merge_request_spec.rb | 2 ++
ee/spec/models/namespace_spec.rb | 2 ++
.../project_services/jenkins_deprecated_service_spec.rb | 2 ++
ee/spec/models/project_spec.rb | 1 +
ee/spec/models/user_spec.rb | 2 ++
ee/spec/policies/clusters/instance_policy_spec.rb | 1 +
ee/spec/policies/group_policy_spec.rb | 1 +
ee/spec/requests/api/graphql/mutations/epics/update_spec.rb | 1 +
ee/spec/requests/api/issues_spec.rb | 1 +
ee/spec/requests/api/project_import_spec.rb | 1 +
ee/spec/requests/api/todos_spec.rb | 1 +
ee/spec/requests/git_http_geo_spec.rb | 1 +
ee/spec/serializers/epic_note_entity_spec.rb | 1 +
ee/spec/services/ee/boards/lists/create_service_spec.rb | 2 ++
ee/spec/services/fetch_subscription_plans_service_spec.rb | 1 +
ee/spec/services/licenses/destroy_service_spec.rb | 1 +
ee/spec/services/merge_requests/approval_service_spec.rb | 2 ++
.../personal_access_tokens/revoke_invalid_tokens_spec.rb | 1 +
ee/spec/services/quick_actions/interpret_service_spec.rb | 1 +
ee/spec/services/search/group_service_spec.rb | 1 +
.../support/prometheus/additional_metrics_shared_examples.rb | 1 +
ee/spec/support/shared_examples/packages_shared_examples.rb | 2 ++
.../serializers/report_status_shared_examples.rb | 1 +
ee/spec/workers/ee/repository_check/batch_worker_spec.rb | 1 +
68 files changed, 98 insertions(+)
diff --git a/ee/spec/controllers/analytics/cycle_analytics/stages_controller_spec.rb b/ee/spec/controllers/analytics/cycle_analytics/stages_controller_spec.rb
index 6e4089f438c67..d473c180bf44c 100644
--- a/ee/spec/controllers/analytics/cycle_analytics/stages_controller_spec.rb
+++ b/ee/spec/controllers/analytics/cycle_analytics/stages_controller_spec.rb
@@ -90,6 +90,7 @@
describe 'PUT `update`' do
let(:stage) { create(:cycle_analytics_group_stage, parent: group, relative_position: 15) }
+
subject { put :update, params: params.merge(id: stage.id) }
include_examples 'group permission check on the controller level'
diff --git a/ee/spec/controllers/analytics/tasks_by_type_controller_spec.rb b/ee/spec/controllers/analytics/tasks_by_type_controller_spec.rb
index 1f4c41843668b..e85aa89085905 100644
--- a/ee/spec/controllers/analytics/tasks_by_type_controller_spec.rb
+++ b/ee/spec/controllers/analytics/tasks_by_type_controller_spec.rb
@@ -8,6 +8,7 @@
let(:label) { create(:group_label, group: group) }
let(:params) { { group_id: group.full_path, label_ids: [label.id], created_after: 10.days.ago, subject: 'Issue' } }
let!(:issue) { create(:labeled_issue, created_at: 5.days.ago, project: create(:project, group: group), labels: [label]) }
+
subject { get :show, params: params }
before do
diff --git a/ee/spec/controllers/concerns/boards_responses_spec.rb b/ee/spec/controllers/concerns/boards_responses_spec.rb
index 5ad5e6e6c6938..8a0329bc494af 100644
--- a/ee/spec/controllers/concerns/boards_responses_spec.rb
+++ b/ee/spec/controllers/concerns/boards_responses_spec.rb
@@ -17,6 +17,7 @@
describe '#serialize_as_json' do
let!(:board) { create(:board, milestone: milestone) }
+
context 'with milestone' do
let(:milestone) { create(:milestone) }
@@ -33,6 +34,7 @@
context 'without milestone' do
let(:milestone) { nil }
+
it 'serialises properly' do
expected = { id: board.id, name: board.name }.as_json
diff --git a/ee/spec/controllers/concerns/internal_redirect_spec.rb b/ee/spec/controllers/concerns/internal_redirect_spec.rb
index 42b486fd8a38e..86df0ffb270bd 100644
--- a/ee/spec/controllers/concerns/internal_redirect_spec.rb
+++ b/ee/spec/controllers/concerns/internal_redirect_spec.rb
@@ -12,6 +12,7 @@ def request
end
end
end
+
subject(:controller) { controller_class.new }
describe '#host_allowed?' do
diff --git a/ee/spec/controllers/projects/push_rules_controller_spec.rb b/ee/spec/controllers/projects/push_rules_controller_spec.rb
index 95b1248bdd9d6..b0a9bd47556e0 100644
--- a/ee/spec/controllers/projects/push_rules_controller_spec.rb
+++ b/ee/spec/controllers/projects/push_rules_controller_spec.rb
@@ -73,6 +73,7 @@ def do_update
context "Updating #{rule_attr} rule" do
context 'as an admin' do
let(:user) { create(:admin) }
+
it_behaves_like 'a setting with global default', rule_attr, updates: true
end
diff --git a/ee/spec/features/security/group/internal_access_spec.rb b/ee/spec/features/security/group/internal_access_spec.rb
index 8db426434c44f..98c80823c4d07 100644
--- a/ee/spec/features/security/group/internal_access_spec.rb
+++ b/ee/spec/features/security/group/internal_access_spec.rb
@@ -47,6 +47,7 @@
describe 'GET /groups/:path/merge_requests' do
let(:project) { create(:project, :internal, :repository, group: group) }
+
subject { merge_requests_group_path(group) }
it { is_expected.to be_allowed_for(:auditor) }
diff --git a/ee/spec/features/security/group/public_access_spec.rb b/ee/spec/features/security/group/public_access_spec.rb
index 3553234be83ff..c49d2a19f4000 100644
--- a/ee/spec/features/security/group/public_access_spec.rb
+++ b/ee/spec/features/security/group/public_access_spec.rb
@@ -47,6 +47,7 @@
describe 'GET /groups/:path/merge_requests' do
let(:project) { create(:project, :public, :repository, group: group) }
+
subject { merge_requests_group_path(group) }
it { is_expected.to be_allowed_for(:auditor) }
diff --git a/ee/spec/features/security/project/internal_access_spec.rb b/ee/spec/features/security/project/internal_access_spec.rb
index d7426837bafb7..f75b54d0a7654 100644
--- a/ee/spec/features/security/project/internal_access_spec.rb
+++ b/ee/spec/features/security/project/internal_access_spec.rb
@@ -70,6 +70,7 @@
describe "GET /:project_path/blob" do
let(:commit) { project.repository.commit }
+
subject { project_blob_path(project, File.join(commit.id, '.gitignore')) }
it { is_expected.to be_allowed_for(:auditor) }
@@ -153,6 +154,7 @@
describe "GET /:project_path/pipelines/:id" do
let(:pipeline) { create(:ci_pipeline, project: project) }
+
subject { project_pipeline_path(project, pipeline) }
it { is_expected.to be_allowed_for(:auditor) }
@@ -181,6 +183,7 @@
describe "GET /:project_path/builds/:id" do
let(:pipeline) { create(:ci_pipeline, project: project) }
let(:build) { create(:ci_build, pipeline: pipeline) }
+
subject { project_job_path(project, build.id) }
context "when allowed for public and internal" do
@@ -208,6 +211,7 @@
describe "GET /:project_path/-/environments/:id" do
let(:environment) { create(:environment, project: project) }
+
subject { project_environment_path(project, environment) }
it { is_expected.to be_allowed_for(:auditor) }
diff --git a/ee/spec/features/security/project/private_access_spec.rb b/ee/spec/features/security/project/private_access_spec.rb
index dd17ddd011117..78da1aeb72af6 100644
--- a/ee/spec/features/security/project/private_access_spec.rb
+++ b/ee/spec/features/security/project/private_access_spec.rb
@@ -64,6 +64,7 @@
describe "GET /:project_path/blob" do
let(:commit) { project.repository.commit }
+
subject { project_blob_path(project, File.join(commit.id, '.gitignore')) }
it { is_expected.to be_allowed_for(:auditor) }
@@ -135,6 +136,7 @@
describe "GET /:project_path/-/environments/:id" do
let(:environment) { create(:environment, project: project) }
+
subject { project_environment_path(project, environment) }
it { is_expected.to be_allowed_for(:auditor) }
diff --git a/ee/spec/features/security/project/public_access_spec.rb b/ee/spec/features/security/project/public_access_spec.rb
index 17451ed86aeff..85644c330dfdf 100644
--- a/ee/spec/features/security/project/public_access_spec.rb
+++ b/ee/spec/features/security/project/public_access_spec.rb
@@ -70,6 +70,7 @@
describe "GET /:project_path/pipelines/:id" do
let(:pipeline) { create(:ci_pipeline, project: project) }
+
subject { project_pipeline_path(project, pipeline) }
it { is_expected.to be_allowed_for(:auditor) }
@@ -98,6 +99,7 @@
describe "GET /:project_path/builds/:id" do
let(:pipeline) { create(:ci_pipeline, project: project) }
let(:build) { create(:ci_build, pipeline: pipeline) }
+
subject { project_job_path(project, build.id) }
context "when allowed for public" do
@@ -125,6 +127,7 @@
describe "GET /:project_path/-/environments/:id" do
let(:environment) { create(:environment, project: project) }
+
subject { project_environment_path(project, environment) }
it { is_expected.to be_allowed_for(:auditor) }
diff --git a/ee/spec/finders/issues_finder_spec.rb b/ee/spec/finders/issues_finder_spec.rb
index f19b957126123..b0036b62d9d1e 100644
--- a/ee/spec/finders/issues_finder_spec.rb
+++ b/ee/spec/finders/issues_finder_spec.rb
@@ -58,6 +58,7 @@
describe '#with_confidentiality_access_check' do
let(:guest) { create(:user) }
+
set(:authorized_user) { create(:user) }
set(:project) { create(:project, namespace: authorized_user.namespace) }
set(:public_issue) { create(:issue, project: project) }
diff --git a/ee/spec/finders/licenses_finder_spec.rb b/ee/spec/finders/licenses_finder_spec.rb
index b504f18e8f654..de7fb0e8d3f2e 100644
--- a/ee/spec/finders/licenses_finder_spec.rb
+++ b/ee/spec/finders/licenses_finder_spec.rb
@@ -4,6 +4,7 @@
describe LicensesFinder do
let(:license) { create(:license) }
+
set(:user) { create(:admin) }
it 'returns a license by id' do
diff --git a/ee/spec/finders/packages/group_packages_finder_spec.rb b/ee/spec/finders/packages/group_packages_finder_spec.rb
index c98422c57ce58..1172f5c9c97c1 100644
--- a/ee/spec/finders/packages/group_packages_finder_spec.rb
+++ b/ee/spec/finders/packages/group_packages_finder_spec.rb
@@ -13,6 +13,7 @@
describe '#execute' do
let(:params) { { exclude_subgroups: false } }
+
subject { described_class.new(user, group, params).execute }
shared_examples 'with package type' do |package_type|
diff --git a/ee/spec/graphql/mutations/merge_requests/set_assignees_spec.rb b/ee/spec/graphql/mutations/merge_requests/set_assignees_spec.rb
index 3a9e0477ed60e..fc54d596d1f8c 100644
--- a/ee/spec/graphql/mutations/merge_requests/set_assignees_spec.rb
+++ b/ee/spec/graphql/mutations/merge_requests/set_assignees_spec.rb
@@ -5,12 +5,14 @@
describe Mutations::MergeRequests::SetAssignees do
let(:merge_request) { create(:merge_request) }
let(:user) { create(:user) }
+
subject(:mutation) { described_class.new(object: nil, context: { current_user: user }) }
describe '#resolve' do
let(:assignees) { create_list(:user, 3) }
let(:assignee_usernames) { assignees.map(&:username) }
let(:mutated_merge_request) { subject[:merge_request] }
+
subject { mutation.resolve(project_path: merge_request.project.full_path, iid: merge_request.iid, assignee_usernames: assignee_usernames) }
before do
diff --git a/ee/spec/helpers/ee/labels_helper_spec.rb b/ee/spec/helpers/ee/labels_helper_spec.rb
index 73a333fb21701..fbfcdf11f550e 100644
--- a/ee/spec/helpers/ee/labels_helper_spec.rb
+++ b/ee/spec/helpers/ee/labels_helper_spec.rb
@@ -52,6 +52,7 @@
context 'when edit_context is a project' do
let(:edit_context) { create(:project) }
let(:label) { create(:label, project: edit_context, title: 'bug') }
+
before do
data.merge!({
project_id: edit_context.id,
diff --git a/ee/spec/helpers/kerberos_spnego_helper_spec.rb b/ee/spec/helpers/kerberos_spnego_helper_spec.rb
index 7db8e5698a291..2245d56bbba9e 100644
--- a/ee/spec/helpers/kerberos_spnego_helper_spec.rb
+++ b/ee/spec/helpers/kerberos_spnego_helper_spec.rb
@@ -7,6 +7,7 @@
describe '#spnego_credentials!' do
let(:gss) { double('GSSAPI::Simple') }
let(:gss_service_name) { 'gss_service_name' }
+
subject { Class.new { include KerberosSpnegoHelper }.new }
before do
diff --git a/ee/spec/helpers/license_helper_spec.rb b/ee/spec/helpers/license_helper_spec.rb
index 826da35e80cd9..668f97496a25b 100644
--- a/ee/spec/helpers/license_helper_spec.rb
+++ b/ee/spec/helpers/license_helper_spec.rb
@@ -24,6 +24,7 @@ def stub_default_url_options(host: "localhost", protocol: "http", port: nil, scr
context 'normal user' do
let(:is_admin) { false }
+
it 'displays correct error message for normal user' do
expect(license_message(signed_in: true, is_admin: is_admin)).to be_blank
end
diff --git a/ee/spec/helpers/search_helper_spec.rb b/ee/spec/helpers/search_helper_spec.rb
index 2d12820737ea1..f22926656b74a 100644
--- a/ee/spec/helpers/search_helper_spec.rb
+++ b/ee/spec/helpers/search_helper_spec.rb
@@ -180,6 +180,7 @@ def es_blob_search
let(:use_elasticsearch) { true }
let(:scope) { 'commits' }
let(:search_service) { instance_double(Search::GlobalService, use_elasticsearch?: use_elasticsearch, scope: scope) }
+
subject { show_switch_to_basic_search?(search_service) }
before do
diff --git a/ee/spec/helpers/users_helper_spec.rb b/ee/spec/helpers/users_helper_spec.rb
index b0cd8b8531756..73d08a9923ed2 100644
--- a/ee/spec/helpers/users_helper_spec.rb
+++ b/ee/spec/helpers/users_helper_spec.rb
@@ -5,6 +5,7 @@
describe UsersHelper do
describe '#current_user_menu_items' do
let(:user) { create(:user) }
+
using RSpec::Parameterized::TableSyntax
subject(:items) { helper.current_user_menu_items }
diff --git a/ee/spec/lib/ee/gitlab/auth/ldap/access_levels_spec.rb b/ee/spec/lib/ee/gitlab/auth/ldap/access_levels_spec.rb
index 866f272edfcac..4d37e6468aaac 100644
--- a/ee/spec/lib/ee/gitlab/auth/ldap/access_levels_spec.rb
+++ b/ee/spec/lib/ee/gitlab/auth/ldap/access_levels_spec.rb
@@ -11,6 +11,7 @@
uid=janedoe,ou=users,dc=example,dc=com
)
end
+
subject { access_levels }
context 'when access_levels is empty' do
@@ -40,6 +41,7 @@
uid=janedoe,ou=users,dc=example,dc=com
}
end
+
before do
access_levels.set(master_dns, to: Gitlab::Access::MAINTAINER)
access_levels.set(developer_dns, to: Gitlab::Access::DEVELOPER)
diff --git a/ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb b/ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb
index 59992a551029b..0a7001094b238 100644
--- a/ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb
+++ b/ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb
@@ -311,6 +311,7 @@ def execute
context 'when user inherits higher permissions from parent' do
let(:parent_group) { create(:group) }
let(:ldap_group1) { ldap_group_entry(user_dn(user.username)) }
+
before do
group.update(parent: parent_group)
parent_group.add_maintainer(user)
@@ -350,6 +351,7 @@ def execute
context 'when user inherits lower permissions from parent' do
let(:parent_group) { create(:group) }
let(:ldap_group1) { ldap_group_entry(user_dn(user.username)) }
+
before do
group.update(parent: parent_group)
parent_group.add_reporter(user)
@@ -390,6 +392,7 @@ def execute
let(:parent_group) { create(:group) }
let(:ldap_group1) { ldap_group_entry(user_dn(user.username)) }
let(:access_requester) { parent_group.request_access(user) }
+
before do
group.update(parent: parent_group)
parent_group.add_owner(create(:user))
@@ -415,6 +418,7 @@ def execute
context 'when user inherits permissions from parent and user is no longer in LDAP group' do
let(:parent_group) { create(:group) }
let(:ldap_group1) { ldap_group_entry(user_dn('other_user')) }
+
before do
group.update(parent: parent_group)
parent_group.add_maintainer(user)
@@ -434,6 +438,7 @@ def execute
let(:group1) { create(:group) }
let(:group2) { create(:group) }
let(:group3) { create(:group) }
+
before do
group1.add_reporter(user)
diff --git a/ee/spec/lib/ee/gitlab/cleanup/orphan_job_artifact_files_spec.rb b/ee/spec/lib/ee/gitlab/cleanup/orphan_job_artifact_files_spec.rb
index 3d43714820d38..be49cdb303a4f 100644
--- a/ee/spec/lib/ee/gitlab/cleanup/orphan_job_artifact_files_spec.rb
+++ b/ee/spec/lib/ee/gitlab/cleanup/orphan_job_artifact_files_spec.rb
@@ -6,6 +6,7 @@
include ::EE::GeoHelpers
let(:null_logger) { Logger.new('/dev/null') }
+
subject(:cleanup) { described_class.new(logger: null_logger) }
before do
diff --git a/ee/spec/lib/gitlab/analytics/cycle_analytics/request_params_spec.rb b/ee/spec/lib/gitlab/analytics/cycle_analytics/request_params_spec.rb
index 3fc9a8ba9bb5f..92c9cd3223121 100644
--- a/ee/spec/lib/gitlab/analytics/cycle_analytics/request_params_spec.rb
+++ b/ee/spec/lib/gitlab/analytics/cycle_analytics/request_params_spec.rb
@@ -4,6 +4,7 @@
describe Gitlab::Analytics::CycleAnalytics::RequestParams do
let(:params) { { created_after: '2018-01-01', created_before: '2019-01-01' } }
+
subject { described_class.new(params) }
describe 'validations' do
diff --git a/ee/spec/lib/gitlab/auth/auth_finders_spec.rb b/ee/spec/lib/gitlab/auth/auth_finders_spec.rb
index 8a10a6c8a4839..155015c97601e 100644
--- a/ee/spec/lib/gitlab/auth/auth_finders_spec.rb
+++ b/ee/spec/lib/gitlab/auth/auth_finders_spec.rb
@@ -70,6 +70,7 @@ def set_param(key, value)
describe '#find_user_from_bearer_token' do
let(:job) { create(:ci_build, user: user) }
+
subject { find_user_from_bearer_token }
context 'when the token is passed as an oauth token' do
@@ -107,6 +108,7 @@ def set_token(token)
describe '#find_user_from_job_token' do
let(:job) { create(:ci_build, user: user) }
+
subject { find_user_from_job_token }
shared_examples 'job token disabled' do
diff --git a/ee/spec/lib/gitlab/auth/smartcard/ldap_certificate_spec.rb b/ee/spec/lib/gitlab/auth/smartcard/ldap_certificate_spec.rb
index 7224fd01a85f7..8927ff347a6ba 100644
--- a/ee/spec/lib/gitlab/auth/smartcard/ldap_certificate_spec.rb
+++ b/ee/spec/lib/gitlab/auth/smartcard/ldap_certificate_spec.rb
@@ -60,6 +60,7 @@
context 'user exists but it is using a new ldap certificate' do
let(:ldap_person_email) { user.email }
+
let_it_be(:user) { create(:user) }
it 'finds existing user' do
diff --git a/ee/spec/lib/gitlab/ci/reports/license_scanning/report_spec.rb b/ee/spec/lib/gitlab/ci/reports/license_scanning/report_spec.rb
index 84cbeecd060cf..e1eabf45894b9 100644
--- a/ee/spec/lib/gitlab/ci/reports/license_scanning/report_spec.rb
+++ b/ee/spec/lib/gitlab/ci/reports/license_scanning/report_spec.rb
@@ -176,6 +176,7 @@ def names_from(licenses)
context 'when diffing two v1 reports' do
let(:base_report) { build(:license_scan_report, :version_1) }
let(:head_report) { build(:license_scan_report, :version_1) }
+
subject { base_report.diff_with(head_report) }
before do
@@ -196,6 +197,7 @@ def names_from(licenses)
context 'when diffing two v2 reports' do
let(:base_report) { build(:license_scan_report, :version_2) }
let(:head_report) { build(:license_scan_report, :version_2) }
+
subject { base_report.diff_with(head_report) }
before do
@@ -216,6 +218,7 @@ def names_from(licenses)
context 'when diffing a v1 report with a v2 report' do
let(:base_report) { build(:license_scan_report, :version_1) }
let(:head_report) { build(:license_scan_report, :version_2) }
+
subject { base_report.diff_with(head_report) }
before do
@@ -236,6 +239,7 @@ def names_from(licenses)
context 'when diffing a v2 report with a v1 report' do
let(:base_report) { build(:license_scan_report, :version_2) }
let(:head_report) { build(:license_scan_report, :version_1) }
+
subject { base_report.diff_with(head_report) }
before do
diff --git a/ee/spec/lib/gitlab/elastic/project_search_results_spec.rb b/ee/spec/lib/gitlab/elastic/project_search_results_spec.rb
index 5c937f3e38026..9aa9543a7d4a0 100644
--- a/ee/spec/lib/gitlab/elastic/project_search_results_spec.rb
+++ b/ee/spec/lib/gitlab/elastic/project_search_results_spec.rb
@@ -21,6 +21,7 @@
describe 'initialize with ref' do
let(:ref) { 'refs/heads/test' }
+
subject(:results) { described_class.new(user, query, project.id, ref) }
it { expect(results.project).to eq(project) }
diff --git a/ee/spec/lib/gitlab/elastic/search_results_spec.rb b/ee/spec/lib/gitlab/elastic/search_results_spec.rb
index ae04c4887d6af..38557679384a8 100644
--- a/ee/spec/lib/gitlab/elastic/search_results_spec.rb
+++ b/ee/spec/lib/gitlab/elastic/search_results_spec.rb
@@ -639,6 +639,7 @@ def search_for(term)
describe 'Wikis' do
let(:results) { described_class.new(user, 'term', limit_project_ids) }
+
subject(:wiki_blobs) { results.objects('wiki_blobs') }
before do
diff --git a/ee/spec/lib/gitlab/geo/event_gap_tracking_spec.rb b/ee/spec/lib/gitlab/geo/event_gap_tracking_spec.rb
index 7e84238bcc3bd..152de1de3c4b1 100644
--- a/ee/spec/lib/gitlab/geo/event_gap_tracking_spec.rb
+++ b/ee/spec/lib/gitlab/geo/event_gap_tracking_spec.rb
@@ -6,6 +6,7 @@
let(:previous_event_id) { 7 }
let(:gap_id) { previous_event_id + 1 }
let(:event_id_with_gap) { previous_event_id + 2 }
+
subject(:gap_tracking) { described_class.new }
before do
diff --git a/ee/spec/lib/gitlab/geo/git_push_http_spec.rb b/ee/spec/lib/gitlab/geo/git_push_http_spec.rb
index e7339eb9ba312..eb553d21a151d 100644
--- a/ee/spec/lib/gitlab/geo/git_push_http_spec.rb
+++ b/ee/spec/lib/gitlab/geo/git_push_http_spec.rb
@@ -8,6 +8,7 @@
let(:gl_id) { 'user-1234' }
let(:gl_repository) { 'project-77777' }
let(:cache_key) { "#{described_class::CACHE_KEY_PREFIX}:#{gl_id}:#{gl_repository}" }
+
set(:secondary) { create(:geo_node) }
subject { described_class.new(gl_id, gl_repository) }
diff --git a/ee/spec/lib/gitlab/geo/replication/job_artifact_retriever_spec.rb b/ee/spec/lib/gitlab/geo/replication/job_artifact_retriever_spec.rb
index 8db6b4e55fdef..8de3695332303 100644
--- a/ee/spec/lib/gitlab/geo/replication/job_artifact_retriever_spec.rb
+++ b/ee/spec/lib/gitlab/geo/replication/job_artifact_retriever_spec.rb
@@ -5,6 +5,7 @@
describe Gitlab::Geo::Replication::JobArtifactRetriever, :geo do
context '#execute' do
let(:retriever) { described_class.new(job_artifact.id, {}) }
+
subject { retriever.execute }
context 'when the job artifact exists' do
diff --git a/ee/spec/lib/gitlab/ip_address_state_spec.rb b/ee/spec/lib/gitlab/ip_address_state_spec.rb
index 0f63a4af2ada9..fe173625ff1e4 100644
--- a/ee/spec/lib/gitlab/ip_address_state_spec.rb
+++ b/ee/spec/lib/gitlab/ip_address_state_spec.rb
@@ -4,6 +4,7 @@
describe Gitlab::IpAddressState do
let(:address) { '1.1.1.1' }
+
describe '.with' do
it 'saves IP address' do
described_class.with(address) do
diff --git a/ee/spec/lib/gitlab/prometheus/queries/cluster_query_spec.rb b/ee/spec/lib/gitlab/prometheus/queries/cluster_query_spec.rb
index 041dfebb77e87..63f7e8bcfd74d 100644
--- a/ee/spec/lib/gitlab/prometheus/queries/cluster_query_spec.rb
+++ b/ee/spec/lib/gitlab/prometheus/queries/cluster_query_spec.rb
@@ -4,6 +4,7 @@
describe Gitlab::Prometheus::Queries::ClusterQuery do
let(:client) { double('prometheus_client', query_range: nil) }
+
subject { described_class.new(client) }
around do |example|
diff --git a/ee/spec/lib/gitlab/prometheus/queries/validate_query_spec.rb b/ee/spec/lib/gitlab/prometheus/queries/validate_query_spec.rb
index 6dbc699ef754c..0287c4f6e16b8 100644
--- a/ee/spec/lib/gitlab/prometheus/queries/validate_query_spec.rb
+++ b/ee/spec/lib/gitlab/prometheus/queries/validate_query_spec.rb
@@ -5,6 +5,7 @@
describe Gitlab::Prometheus::Queries::ValidateQuery do
let(:client) { double('prometheus_client') }
let(:query) { 'avg(metric)' }
+
subject { described_class.new(client) }
context 'valid query' do
@@ -21,6 +22,7 @@
context 'invalid query' do
let(:message) { 'message' }
+
before do
allow(client).to receive(:query).with(query).and_raise(Gitlab::PrometheusClient::QueryError.new(message))
end
diff --git a/ee/spec/lib/pseudonymizer/dumper_spec.rb b/ee/spec/lib/pseudonymizer/dumper_spec.rb
index 66412b8bfce3c..f75fe58af2154 100644
--- a/ee/spec/lib/pseudonymizer/dumper_spec.rb
+++ b/ee/spec/lib/pseudonymizer/dumper_spec.rb
@@ -10,6 +10,7 @@
config: YAML.load_file(Gitlab.config.pseudonymizer.manifest)
)
end
+
subject(:pseudo) { described_class.new(options) }
before do
diff --git a/ee/spec/lib/pseudonymizer/pager_spec.rb b/ee/spec/lib/pseudonymizer/pager_spec.rb
index 12fd94b5b9536..188130438574b 100644
--- a/ee/spec/lib/pseudonymizer/pager_spec.rb
+++ b/ee/spec/lib/pseudonymizer/pager_spec.rb
@@ -5,6 +5,7 @@
describe Pseudonymizer::Pager do
let(:page_size) { 1 }
let!(:projects) { create_list(:project, 10) }
+
subject { described_class.new("projects", whitelisted_columns) }
before do
diff --git a/ee/spec/lib/pseudonymizer/uploader_spec.rb b/ee/spec/lib/pseudonymizer/uploader_spec.rb
index 2f3921fbf072d..9d71e7d9e8f2c 100644
--- a/ee/spec/lib/pseudonymizer/uploader_spec.rb
+++ b/ee/spec/lib/pseudonymizer/uploader_spec.rb
@@ -10,6 +10,7 @@
)
end
let(:remote_directory) { subject.send(:remote_directory) }
+
subject { described_class.new(options) }
def mock_file(file_name)
diff --git a/ee/spec/mailers/notify_spec.rb b/ee/spec/mailers/notify_spec.rb
index afd7fda192d75..4ae3424502425 100644
--- a/ee/spec/mailers/notify_spec.rb
+++ b/ee/spec/mailers/notify_spec.rb
@@ -122,6 +122,7 @@
describe 'that are approved' do
let(:last_approver) { create(:user) }
+
subject { described_class.approved_merge_request_email(recipient.id, merge_request.id, last_approver.id) }
before do
@@ -185,6 +186,7 @@
describe 'that are unapproved' do
let(:last_unapprover) { create(:user) }
+
subject { described_class.unapproved_merge_request_email(recipient.id, merge_request.id, last_unapprover.id) }
before do
@@ -239,6 +241,7 @@
context 'for merge requests without assignee' do
describe 'that are unapproved' do
let(:last_unapprover) { create(:user) }
+
subject { described_class.unapproved_merge_request_email(recipient.id, merge_request_without_assignee.id, last_unapprover.id) }
before do
diff --git a/ee/spec/models/approvable_spec.rb b/ee/spec/models/approvable_spec.rb
index cf0377830148f..207b714c71a65 100644
--- a/ee/spec/models/approvable_spec.rb
+++ b/ee/spec/models/approvable_spec.rb
@@ -11,6 +11,7 @@
describe '#approval_feature_available?' do
let(:project) { create(:project) }
let(:merge_request) { create(:merge_request, source_project: project, target_project: project) }
+
subject { merge_request.approval_feature_available? }
it 'is false when feature is disabled' do
diff --git a/ee/spec/models/design_management/version_spec.rb b/ee/spec/models/design_management/version_spec.rb
index 38b50b842b87f..30ce6919eda0e 100644
--- a/ee/spec/models/design_management/version_spec.rb
+++ b/ee/spec/models/design_management/version_spec.rb
@@ -207,6 +207,7 @@ def call_with_mismatched_designs
describe '#author' do
let(:author) { create(:user) }
+
subject(:version) { create(:design_version, :committed, author: author) }
it { is_expected.to have_attributes(author: author) }
diff --git a/ee/spec/models/ee/list_spec.rb b/ee/spec/models/ee/list_spec.rb
index 0b83a05e1a841..7778f5cf74a2c 100644
--- a/ee/spec/models/ee/list_spec.rb
+++ b/ee/spec/models/ee/list_spec.rb
@@ -36,6 +36,7 @@
context 'when it is a milestone type' do
let(:milestone) { build(:milestone, title: 'awesome-release') }
+
subject { described_class.new(list_type: :milestone, milestone: milestone, board: board) }
it { is_expected.to be_destroyable }
diff --git a/ee/spec/models/gitlab_subscription_spec.rb b/ee/spec/models/gitlab_subscription_spec.rb
index 3c1c0364c8616..a74f815c3c40c 100644
--- a/ee/spec/models/gitlab_subscription_spec.rb
+++ b/ee/spec/models/gitlab_subscription_spec.rb
@@ -159,6 +159,7 @@
describe '#expired?' do
let(:gitlab_subscription) { create(:gitlab_subscription, end_date: end_date) }
+
subject { gitlab_subscription.expired? }
context 'when end_date is expired' do
diff --git a/ee/spec/models/issue_spec.rb b/ee/spec/models/issue_spec.rb
index 97ce7f540ec25..eab61db5bf681 100644
--- a/ee/spec/models/issue_spec.rb
+++ b/ee/spec/models/issue_spec.rb
@@ -266,6 +266,7 @@
describe '#promoted?' do
let(:issue) { create(:issue) }
+
subject { issue.promoted? }
context 'issue not promoted' do
@@ -487,6 +488,7 @@
describe 'current designs' do
let(:issue) { create(:issue) }
+
subject { issue.designs.current }
context 'an issue has no designs' do
diff --git a/ee/spec/models/license_spec.rb b/ee/spec/models/license_spec.rb
index 5f221a981af71..f80fb550dd766 100644
--- a/ee/spec/models/license_spec.rb
+++ b/ee/spec/models/license_spec.rb
@@ -304,6 +304,7 @@
describe '.plan_includes_feature?' do
let(:feature) { :deploy_board }
+
subject { described_class.plan_includes_feature?(plan, feature) }
context 'when addon included' do
@@ -669,6 +670,7 @@ def build_license_with_add_ons(add_ons, plan: nil)
context 'when the license is the very first trial' do
let(:tomorrow) { Date.tomorrow }
+
before do
gl_license.restrictions = { trial: true }
gl_license.expires_at = tomorrow
@@ -689,6 +691,7 @@ def build_license_with_add_ons(add_ons, plan: nil)
context 'when the license is a repeated trial' do
let(:yesterday) { Date.yesterday }
+
before do
gl_license.restrictions = { trial: true }
gl_license.expires_at = Date.tomorrow
diff --git a/ee/spec/models/merge_request_spec.rb b/ee/spec/models/merge_request_spec.rb
index acfd9df80e457..15cf92c083e48 100644
--- a/ee/spec/models/merge_request_spec.rb
+++ b/ee/spec/models/merge_request_spec.rb
@@ -335,6 +335,7 @@
let(:project) { create(:project, :repository) }
let(:current_user) { project.users.take }
let(:merge_request) { create(:merge_request, source_project: project) }
+
subject { merge_request.calculate_reactive_cache(service_class_name, current_user&.id) }
context 'when given a known service class name' do
@@ -713,6 +714,7 @@ def create_pipeline(status)
context 'when using approvals' do
let(:user) { create(:user) }
+
before do
allow(subject).to receive(:mergeable_state?).and_return(true)
diff --git a/ee/spec/models/namespace_spec.rb b/ee/spec/models/namespace_spec.rb
index 53f20531d5cc1..dc5692cafde58 100644
--- a/ee/spec/models/namespace_spec.rb
+++ b/ee/spec/models/namespace_spec.rb
@@ -620,6 +620,7 @@
describe '#shared_runners_remaining_minutes_percent' do
let(:namespace) { build(:namespace) }
+
subject { namespace.shared_runners_remaining_minutes_percent }
it 'returns the minutes left as a percent of the limit' do
@@ -666,6 +667,7 @@ def stub_minutes_used_and_limit(minutes_used, limit)
describe '#shared_runners_remaining_minutes_below_threshold?' do
let(:namespace) { build(:namespace, last_ci_minutes_usage_notification_level: 30) }
+
subject { namespace.shared_runners_remaining_minutes_below_threshold? }
it 'is true when minutes left is below the notification level' do
diff --git a/ee/spec/models/project_services/jenkins_deprecated_service_spec.rb b/ee/spec/models/project_services/jenkins_deprecated_service_spec.rb
index 820ff7ef88d1a..134969036540b 100644
--- a/ee/spec/models/project_services/jenkins_deprecated_service_spec.rb
+++ b/ee/spec/models/project_services/jenkins_deprecated_service_spec.rb
@@ -23,6 +23,7 @@ def status_body_for_icon(state)
describe '#calculate_reactive_cache' do
let(:pass_unstable) { '0' }
+
before do
@service = JenkinsDeprecatedService.new
allow(@service).to receive_messages(
@@ -73,6 +74,7 @@ def status_body_for_icon(state)
describe 'multiproject enabled' do
let!(:project) { create(:project) }
+
before do
@service = JenkinsDeprecatedService.new
allow(@service).to receive_messages(
diff --git a/ee/spec/models/project_spec.rb b/ee/spec/models/project_spec.rb
index c6416bc8cf16d..2fff009f2582e 100644
--- a/ee/spec/models/project_spec.rb
+++ b/ee/spec/models/project_spec.rb
@@ -1767,6 +1767,7 @@ def stub_find_remote_root_ref(project, ref:)
describe '#object_pool_missing?' do
let(:pool) { create(:pool_repository, :ready) }
+
subject { create(:project, :repository, pool_repository: pool) }
it 'returns true when object pool is missing' do
diff --git a/ee/spec/models/user_spec.rb b/ee/spec/models/user_spec.rb
index b14be6ebcc44f..e30ff352174be 100644
--- a/ee/spec/models/user_spec.rb
+++ b/ee/spec/models/user_spec.rb
@@ -657,6 +657,7 @@
context 'namespace with input name exists' do
let(:name) { 'Disney' }
+
before do
create(:user, name: 'disney')
end
@@ -670,6 +671,7 @@
context 'namespace with input name and suffix exists' do
let(:name) { 'Disney' }
+
before do
create(:user, name: 'disney')
create(:user, name: 'disney1')
diff --git a/ee/spec/policies/clusters/instance_policy_spec.rb b/ee/spec/policies/clusters/instance_policy_spec.rb
index e87f6958cf60b..58e488a849669 100644
--- a/ee/spec/policies/clusters/instance_policy_spec.rb
+++ b/ee/spec/policies/clusters/instance_policy_spec.rb
@@ -4,6 +4,7 @@
describe Clusters::InstancePolicy do
let(:user) { create(:admin) }
+
subject { described_class.new(user, Clusters::Instance.new) }
context 'when cluster deployments is available' do
diff --git a/ee/spec/policies/group_policy_spec.rb b/ee/spec/policies/group_policy_spec.rb
index cf13e1811a7b7..15a50ea58b25e 100644
--- a/ee/spec/policies/group_policy_spec.rb
+++ b/ee/spec/policies/group_policy_spec.rb
@@ -138,6 +138,7 @@
context 'with sso enforcement enabled' do
let(:current_user) { guest }
+
let_it_be(:saml_provider) { create(:saml_provider, group: group, enforced_sso: true) }
context 'when the session has been set globally' do
diff --git a/ee/spec/requests/api/graphql/mutations/epics/update_spec.rb b/ee/spec/requests/api/graphql/mutations/epics/update_spec.rb
index c18bf942271a1..bed0c5ec64803 100644
--- a/ee/spec/requests/api/graphql/mutations/epics/update_spec.rb
+++ b/ee/spec/requests/api/graphql/mutations/epics/update_spec.rb
@@ -105,6 +105,7 @@ def mutation_response
context 'when changing labels of the epic' do
let(:attributes) { { add_label_ids: [label_1.id, label_3.id], remove_label_ids: label_2.id } }
+
it 'adds and removes labels correctly' do
post_graphql_mutation(mutation, current_user: current_user)
diff --git a/ee/spec/requests/api/issues_spec.rb b/ee/spec/requests/api/issues_spec.rb
index 0245a1a9b2d25..51079fcec7e43 100644
--- a/ee/spec/requests/api/issues_spec.rb
+++ b/ee/spec/requests/api/issues_spec.rb
@@ -27,6 +27,7 @@
title: issue_title,
description: issue_description
end
+
set(:milestone) { create(:milestone, title: '1.0.0', project: project) }
before(:all) do
diff --git a/ee/spec/requests/api/project_import_spec.rb b/ee/spec/requests/api/project_import_spec.rb
index f6670960843cb..cb5145f1bd0cd 100644
--- a/ee/spec/requests/api/project_import_spec.rb
+++ b/ee/spec/requests/api/project_import_spec.rb
@@ -9,6 +9,7 @@
let(:user) { create(:user) }
let(:file) { File.join('spec', 'features', 'projects', 'import_export', 'test_project_export.tar.gz') }
let(:namespace) { create(:group) }
+
before do
allow_any_instance_of(Gitlab::ImportExport).to receive(:storage_path).and_return(export_path)
diff --git a/ee/spec/requests/api/todos_spec.rb b/ee/spec/requests/api/todos_spec.rb
index 6ee100cd54f0d..9b3d00c4cffd7 100644
--- a/ee/spec/requests/api/todos_spec.rb
+++ b/ee/spec/requests/api/todos_spec.rb
@@ -6,6 +6,7 @@
set(:group) { create(:group) }
let(:user) { create(:user) }
let(:epic) { create(:epic, group: group) }
+
set(:project) { create(:project, group: group) }
describe 'GET /todos' do
diff --git a/ee/spec/requests/git_http_geo_spec.rb b/ee/spec/requests/git_http_geo_spec.rb
index 7571b52357517..918a9e5bf4fa4 100644
--- a/ee/spec/requests/git_http_geo_spec.rb
+++ b/ee/spec/requests/git_http_geo_spec.rb
@@ -67,6 +67,7 @@
context 'no Geo JWT token' do
let(:env) { workhorse_internal_api_request_header }
+
it { is_expected.to have_gitlab_http_status(:unauthorized) }
end
diff --git a/ee/spec/serializers/epic_note_entity_spec.rb b/ee/spec/serializers/epic_note_entity_spec.rb
index f877138937b0b..4f68ebad2b809 100644
--- a/ee/spec/serializers/epic_note_entity_spec.rb
+++ b/ee/spec/serializers/epic_note_entity_spec.rb
@@ -11,6 +11,7 @@
let(:epic) { create(:epic, author: user) }
let(:note) { create(:note, noteable: epic, author: user) }
let(:user) { create(:user) }
+
subject { entity.as_json }
it_behaves_like 'note entity'
diff --git a/ee/spec/services/ee/boards/lists/create_service_spec.rb b/ee/spec/services/ee/boards/lists/create_service_spec.rb
index fb0d9130b2950..c4066e9d57882 100644
--- a/ee/spec/services/ee/boards/lists/create_service_spec.rb
+++ b/ee/spec/services/ee/boards/lists/create_service_spec.rb
@@ -10,6 +10,7 @@
context 'when assignee_id param is sent' do
let(:other_user) { create(:user) }
+
subject(:service) { described_class.new(project, user, 'assignee_id' => other_user.id) }
before do
@@ -30,6 +31,7 @@
context 'when milestone_id param is sent' do
let(:user) { create(:user) }
let(:milestone) { create(:milestone, project: project) }
+
subject(:service) { described_class.new(project, user, 'milestone_id' => milestone.id) }
before do
diff --git a/ee/spec/services/fetch_subscription_plans_service_spec.rb b/ee/spec/services/fetch_subscription_plans_service_spec.rb
index 0d2da790ee651..2dc3f5c322d39 100644
--- a/ee/spec/services/fetch_subscription_plans_service_spec.rb
+++ b/ee/spec/services/fetch_subscription_plans_service_spec.rb
@@ -5,6 +5,7 @@
describe FetchSubscriptionPlansService do
describe '#execute' do
let(:endpoint_url) { 'https://customers.gitlab.com/gitlab_plans' }
+
subject { described_class.new(plan: 'bronze').execute }
context 'when successully fetching plans data' do
diff --git a/ee/spec/services/licenses/destroy_service_spec.rb b/ee/spec/services/licenses/destroy_service_spec.rb
index 0470ab97d150a..fe09d6b62d9f6 100644
--- a/ee/spec/services/licenses/destroy_service_spec.rb
+++ b/ee/spec/services/licenses/destroy_service_spec.rb
@@ -3,6 +3,7 @@
describe Licenses::DestroyService do
let(:license) { create(:license) }
+
set(:user) { create(:admin) }
def destroy_with(user)
diff --git a/ee/spec/services/merge_requests/approval_service_spec.rb b/ee/spec/services/merge_requests/approval_service_spec.rb
index ceebc3a4f503b..7087f8318d83d 100644
--- a/ee/spec/services/merge_requests/approval_service_spec.rb
+++ b/ee/spec/services/merge_requests/approval_service_spec.rb
@@ -106,6 +106,7 @@
let(:params) do
{ approval_password: 'incorrect' }
end
+
it 'raises an error' do
service_with_params = described_class.new(project, user, params)
expect { service_with_params.execute(merge_request) }.to raise_error(::MergeRequests::ApprovalService::IncorrectApprovalPasswordError)
@@ -116,6 +117,7 @@
let(:params) do
{ approval_password: 'password' }
end
+
it 'does not raise an error' do
service_with_params = described_class.new(project, user, params)
expect { service_with_params.execute(merge_request) }.not_to raise_error(::MergeRequests::ApprovalService::IncorrectApprovalPasswordError)
diff --git a/ee/spec/services/personal_access_tokens/revoke_invalid_tokens_spec.rb b/ee/spec/services/personal_access_tokens/revoke_invalid_tokens_spec.rb
index 82550951b2ea1..f4e96b7b8e691 100644
--- a/ee/spec/services/personal_access_tokens/revoke_invalid_tokens_spec.rb
+++ b/ee/spec/services/personal_access_tokens/revoke_invalid_tokens_spec.rb
@@ -7,6 +7,7 @@
describe '#execute' do
let(:expiration_date) { 10.days.from_now }
+
let_it_be(:user) { create(:user) }
let_it_be(:pat) { create(:personal_access_token, expires_at: 5.days.from_now, user: user) }
let_it_be(:invalid_pat1) { create(:personal_access_token, expires_at: nil, user: user) }
diff --git a/ee/spec/services/quick_actions/interpret_service_spec.rb b/ee/spec/services/quick_actions/interpret_service_spec.rb
index ae262433c4a4b..40b7a38786c0d 100644
--- a/ee/spec/services/quick_actions/interpret_service_spec.rb
+++ b/ee/spec/services/quick_actions/interpret_service_spec.rb
@@ -565,6 +565,7 @@
context 'when child and parent epics are in different groups' do
let(:child_epic) { create(:epic, group: group, parent: epic) }
+
context 'when child epic is in a parent group of the parent epic' do
before do
epic.update!(group: subgroup)
diff --git a/ee/spec/services/search/group_service_spec.rb b/ee/spec/services/search/group_service_spec.rb
index 8a218ac6558ac..fd597f76d8479 100644
--- a/ee/spec/services/search/group_service_spec.rb
+++ b/ee/spec/services/search/group_service_spec.rb
@@ -86,6 +86,7 @@
{ project_level: :internal, feature_access_level: :enabled, membership: :guest, expected_count: 1 }
]
end
+
where(:project_level, :feature_access_level, :membership, :expected_count) do
permission_table_for_reporter_feature_access
end
diff --git a/ee/spec/support/prometheus/additional_metrics_shared_examples.rb b/ee/spec/support/prometheus/additional_metrics_shared_examples.rb
index 8be03f26f7119..c5ed25e3f1c70 100644
--- a/ee/spec/support/prometheus/additional_metrics_shared_examples.rb
+++ b/ee/spec/support/prometheus/additional_metrics_shared_examples.rb
@@ -24,6 +24,7 @@
context 'with custom metrics' do
let!(:metric) { create(:prometheus_metric, project: project) }
+
before do
allow(client).to receive(:query_range).with('avg(metric)', any_args).and_return(query_range_result)
end
diff --git a/ee/spec/support/shared_examples/packages_shared_examples.rb b/ee/spec/support/shared_examples/packages_shared_examples.rb
index 75f5784e45bb8..f77a07390b46d 100644
--- a/ee/spec/support/shared_examples/packages_shared_examples.rb
+++ b/ee/spec/support/shared_examples/packages_shared_examples.rb
@@ -73,6 +73,7 @@
context 'when viewing the first page' do
let(:page) { 1 }
+
it 'returns first 2 packages' do
get api(url, user), params: { page: page, per_page: per_page }
@@ -82,6 +83,7 @@
context 'when viewing the second page' do
let(:page) { 2 }
+
it 'returns first 2 packages' do
get api(url, user), params: { page: page, per_page: per_page }
diff --git a/ee/spec/support/shared_examples/serializers/report_status_shared_examples.rb b/ee/spec/support/shared_examples/serializers/report_status_shared_examples.rb
index 8fe27a1c01fda..7ecdac731300b 100644
--- a/ee/spec/support/shared_examples/serializers/report_status_shared_examples.rb
+++ b/ee/spec/support/shared_examples/serializers/report_status_shared_examples.rb
@@ -7,6 +7,7 @@
end
let(:request) { double('request') }
+
set(:project) { create(:project, :repository, :private) }
set(:developer) { create(:user) }
diff --git a/ee/spec/workers/ee/repository_check/batch_worker_spec.rb b/ee/spec/workers/ee/repository_check/batch_worker_spec.rb
index f801d039129e7..88523e189c714 100644
--- a/ee/spec/workers/ee/repository_check/batch_worker_spec.rb
+++ b/ee/spec/workers/ee/repository_check/batch_worker_spec.rb
@@ -6,6 +6,7 @@
include ::EE::GeoHelpers
let(:shard_name) { 'default' }
+
subject(:worker) { RepositoryCheck::BatchWorker.new }
before do
--
GitLab