diff --git a/doc/administration/gitaly/concurrency_limiting.md b/doc/administration/gitaly/concurrency_limiting.md index 7150883123c375579a06f0c89d10bafeb64507fa..321bb9efe20d3729bef72a182c5486ae610d3ac7 100644 --- a/doc/administration/gitaly/concurrency_limiting.md +++ b/doc/administration/gitaly/concurrency_limiting.md @@ -163,7 +163,7 @@ The adaptive limiter calibrates the limits every 30 seconds and: or CPU throttled for 50% or more of the observation time. Otherwise, the limits increase by one until reaching the upper bound. For more information about technical implementation -of this system, please refer to [this blueprint](../../architecture/blueprints/gitaly_adaptive_concurrency_limit/index.md). +of this system, refer to [this blueprint](../../architecture/blueprints/gitaly_adaptive_concurrency_limit/index.md). Adaptive limiting is enabled for each RPC or pack-objects cache individually. However, limits are calibrated at the same time. diff --git a/doc/administration/postgresql/replication_and_failover.md b/doc/administration/postgresql/replication_and_failover.md index 67037a1f02dd0b76cb7d6becb391e7fb84620acc..f4ed9d99b457fba5de6066e34c9daf43447dba08 100644 --- a/doc/administration/postgresql/replication_and_failover.md +++ b/doc/administration/postgresql/replication_and_failover.md @@ -275,7 +275,7 @@ gitlab_rails['auto_migrate'] = false consul['services'] = %w(postgresql) # START user configuration -# Please set the real values as explained in Required Information section +# Set the real values as explained in Required Information section # # Replace PGBOUNCER_PASSWORD_HASH with a generated md5 value postgresql['pgbouncer_user_password'] = 'PGBOUNCER_PASSWORD_HASH' @@ -427,7 +427,7 @@ authentication mode (`patroni['tls_client_mode']`), must each have the same valu consul['watchers'] = %w(postgresql) # START user configuration - # Please set the real values as explained in Required Information section + # Set the real values as explained in Required Information section # Replace CONSUL_PASSWORD_HASH with with a generated md5 value # Replace PGBOUNCER_PASSWORD_HASH with with a generated md5 value pgbouncer['users'] = { diff --git a/doc/administration/silent_mode/index.md b/doc/administration/silent_mode/index.md index da9c930c86cc80ae1a2ddbd753930f08e80792ad..f72b715ac5e5fd8a30efef134000c18dfa150900 100644 --- a/doc/administration/silent_mode/index.md +++ b/doc/administration/silent_mode/index.md @@ -91,7 +91,7 @@ Outbound communications from the following features are silenced by Silent Mode. | [Executable integrations](../../user/project/integrations/index.md) | The integrations are not executed. | | [Service Desk](../../user/project/service_desk/index.md) | Incoming emails still raise issues, but the users who sent the emails to Service Desk are not notified of issue creation or comments on their issues. | | Outbound emails | | -| Outbound HTTP requests | Many HTTP requests are blocked where features are not blocked or skipped explicitly. These may produce errors. If a particular error is problematic for testing during Silent Mode, please consult [GitLab Support](https://about.gitlab.com/support/). | +| Outbound HTTP requests | Many HTTP requests are blocked where features are not blocked or skipped explicitly. These may produce errors. If a particular error is problematic for testing during Silent Mode, consult [GitLab Support](https://about.gitlab.com/support/). | ### Outbound communications that are not silenced diff --git a/doc/api/oauth2.md b/doc/api/oauth2.md index 2eea6cec6e2c8d00fac20c925dd67a37e952cf1c..4ef09868565f45f5beddcfb534a9c5118bece361 100644 --- a/doc/api/oauth2.md +++ b/doc/api/oauth2.md @@ -72,7 +72,7 @@ parameter, which are securely bound to the user agent", with each request to the ### Use HTTPS in production -For production, please use HTTPS for your `redirect_uri`. +For production, use HTTPS for your `redirect_uri`. For development, GitLab allows insecure HTTP redirect URIs. As OAuth 2.0 bases its security entirely on the transport layer, you should not use unprotected diff --git a/doc/api/project_vulnerabilities.md b/doc/api/project_vulnerabilities.md index 82217fc37c0d455103b5410a2fd6d628ee82ae89..771ff4c2e8eaaee3de89b89ed2adc501d8cae447 100644 --- a/doc/api/project_vulnerabilities.md +++ b/doc/api/project_vulnerabilities.md @@ -16,7 +16,7 @@ info: "To determine the technical writer assigned to the Stage/Group associated WARNING: This API is in the process of being deprecated and considered unstable. The response payload may be subject to change or breakage -across GitLab releases. Please use the +across GitLab releases. Use the [GraphQL API](graphql/reference/index.md#queryvulnerabilities) instead. diff --git a/doc/architecture/blueprints/_template.md b/doc/architecture/blueprints/_template.md index 18f88322906249a420bae9c510887ce6cdfd814f..8577054db83ea652168ec864f217fadda3211364 100644 --- a/doc/architecture/blueprints/_template.md +++ b/doc/architecture/blueprints/_template.md @@ -13,7 +13,7 @@ Before you start: - Copy this file to a sub-directory and call it `index.md` for it to appear in the blueprint directory. -- Please remove comment blocks for sections you've filled in. +- Remove comment blocks for sections you've filled in. When your blueprint ready for review, all of these comment blocks should be removed. diff --git a/doc/architecture/blueprints/consolidating_groups_and_projects/index.md b/doc/architecture/blueprints/consolidating_groups_and_projects/index.md index c35488cfa4f0b0c04333abd0070952546d4d671d..89e7f0a8a8837a35301e8d2c1af15f07b3290ee0 100644 --- a/doc/architecture/blueprints/consolidating_groups_and_projects/index.md +++ b/doc/architecture/blueprints/consolidating_groups_and_projects/index.md @@ -230,7 +230,7 @@ We should strive to do the code clean up as we move through the phases. However, The initial iteration will provide a framework to house features under `Namespaces`. Stage groups will eventually need to migrate their own features and functionality over to `Namespaces`. This may impact these features in unexpected ways. Therefore, to minimize UX debt and maintain product consistency, stage groups will have to consider several factors when migrating their features over to `Namespaces`: 1. **Conceptual model**: What are the current and future state conceptual models of these features ([see object modeling for designers](https://hpadkisson.medium.com/object-modeling-for-designers-an-introduction-7871bdcf8baf))? These should be documented in Pajamas (example: [merge requests](https://design.gitlab.com/objects/merge-request/)). -1. **Merge conflicts**: What inconsistencies are there across project, group, and administrator levels? How might these be addressed? For an example of how we rationalized this for labels, please see [this issue](https://gitlab.com/gitlab-org/gitlab/-/issues/338820). +1. **Merge conflicts**: What inconsistencies are there across project, group, and administrator levels? How might these be addressed? For an example of how we rationalized this for labels, see [this issue](https://gitlab.com/gitlab-org/gitlab/-/issues/338820). 1. **Inheritance & information flow**: How is information inherited across our container hierarchy currently? How might this be impacted if complying with the new [inheritance behavior](https://gitlab.com/gitlab-org/gitlab/-/issues/343316) framework? 1. **Settings**: Where can settings for this feature be found currently? How will these be impacted by `Namespaces`? 1. **Access**: Who can access this feature and is that impacted by the new container structure? Are there any role or privacy considerations? diff --git a/doc/architecture/blueprints/container_registry_metadata_database/index.md b/doc/architecture/blueprints/container_registry_metadata_database/index.md index b62dd66064392012162cc845b0488ed43c6bfa69..66beac6cdb7618e7d2da6b63671508e3ee022ead 100644 --- a/doc/architecture/blueprints/container_registry_metadata_database/index.md +++ b/doc/architecture/blueprints/container_registry_metadata_database/index.md @@ -65,7 +65,7 @@ sequenceDiagram Note right of C: Bearer token included in the Authorization header ``` -Please refer to the [Docker documentation](https://docs.docker.com/registry/spec/auth/token/) for more details. +For more details, refer to the [Docker documentation](https://docs.docker.com/registry/spec/auth/token/). ##### Push and Pull @@ -164,7 +164,7 @@ Although blobs are shared across repositories, manifest and tag metadata are sco #### GitLab.com -Due to scale, performance and isolation concerns, for GitLab.com the registry database will be on a separate dedicated PostgreSQL cluster. Please see [#93](https://gitlab.com/gitlab-org/container-registry/-/issues/93) and [GitLab-com/gl-infra/reliability#10109](https://gitlab.com/gitlab-com/gl-infra/reliability/-/issues/10109) for additional context. +Due to scale, performance and isolation concerns, for GitLab.com the registry database will be on a separate dedicated PostgreSQL cluster. See [#93](https://gitlab.com/gitlab-org/container-registry/-/issues/93) and [GitLab-com/gl-infra/reliability#10109](https://gitlab.com/gitlab-com/gl-infra/reliability/-/issues/10109) for additional context. The diagram below illustrates the architecture of the database cluster: @@ -238,7 +238,7 @@ This is a list of all the registry HTTP API operations and how they depend on th | [Complete blob upload](https://gitlab.com/gitlab-org/container-registry/-/blob/master/docs/spec/api.md#put-blob-upload) | `PUT` | `/v2/<name>/blobs/uploads/<uuid>` | **{check-circle}** Yes | **{check-circle}** Yes | **{dotted-circle}** No | | [Cancel blob upload](https://gitlab.com/gitlab-org/container-registry/-/blob/master/docs/spec/api.md#canceling-an-upload) | `DELETE` | `/v2/<name>/blobs/uploads/<uuid>` | **{check-circle}** Yes | **{check-circle}** Yes | **{dotted-circle}** No | -`*` Please refer to the [list of interactions between registry and Rails](#from-gitlab-rails-to-registry) to know why and how. +`*` Refer to the [list of interactions between registry and Rails](#from-gitlab-rails-to-registry) to know why and how. #### Failure Scenarios diff --git a/doc/architecture/blueprints/container_registry_metadata_database_self_managed_rollout/index.md b/doc/architecture/blueprints/container_registry_metadata_database_self_managed_rollout/index.md index 4e81761839c88e6fb2c9da3524b09ab7ab4c4f4f..bfc5c4a7133afd96374d7bdcb7f0f0a707603e0c 100644 --- a/doc/architecture/blueprints/container_registry_metadata_database_self_managed_rollout/index.md +++ b/doc/architecture/blueprints/container_registry_metadata_database_self_managed_rollout/index.md @@ -88,7 +88,7 @@ The metadata database is in early beta for self-managed users. The core migratio process for existing registries has been implemented, and online garbage collection is fully implemented. Certain database enabled features are only enabled for GitLab.com and automatic database provisioning for the registry database is not available. -Please see the table below for the status of features related to the container +See the table below for the status of features related to the container registry database. | Feature | Description | Status | Link | diff --git a/doc/architecture/blueprints/gitaly_handle_upload_pack_in_http2_server/index.md b/doc/architecture/blueprints/gitaly_handle_upload_pack_in_http2_server/index.md index acee83b26495eecc7c7bd0a27342db05d78a844f..897f9f9736596a1fac3d14f5713708eaa7885bf1 100644 --- a/doc/architecture/blueprints/gitaly_handle_upload_pack_in_http2_server/index.md +++ b/doc/architecture/blueprints/gitaly_handle_upload_pack_in_http2_server/index.md @@ -28,7 +28,7 @@ provided. We are looking for a solution that won't require us to completely rewr ### How Git data transfer works -Please skip this part if you are familiar with how Git data transfer architecture at GitLab. +Skip this part if you are familiar with how Git data transfer architecture at GitLab. Git data transfer is undeniably one of the crucial services that a Git server can offer. It is a fundamental feature of Git that was originally developed for Linux kernel development. As Git gained popularity, it continued to be recognized as a distributed system. However, the emergence of centralized Git services like GitHub or diff --git a/doc/architecture/blueprints/google_artifact_registry_integration/index.md b/doc/architecture/blueprints/google_artifact_registry_integration/index.md index 78a158f7baa2f81ca3a6b21c13d34ab6cadcbd49..0419601e266312703125fb02b87e7625eaf65901 100644 --- a/doc/architecture/blueprints/google_artifact_registry_integration/index.md +++ b/doc/architecture/blueprints/google_artifact_registry_integration/index.md @@ -18,7 +18,7 @@ As highlighted in the announcement, one key goal is the ability to "_use Google' ## Motivation -Please refer to the [announcement](https://about.gitlab.com/blog/2023/08/29/gitlab-google-partnership-s3c/) blog post for more details about the motivation and long-term goals of the GitLab and Google Cloud partnership. +Refer to the [announcement](https://about.gitlab.com/blog/2023/08/29/gitlab-google-partnership-s3c/) blog post for more details about the motivation and long-term goals of the GitLab and Google Cloud partnership. Regarding the scope of this design document, our primary focus is to fulfill the Product requirement of providing users with visibility over their container images in GAR. The motivation for this specific goal is rooted in foundational research on the use of external registries as a complement to the GitLab container registry ([internal](https://gitlab.com/gitlab-org/ux-research/-/issues/2602)). @@ -82,13 +82,13 @@ Regarding the GAR integration, since there is no equivalent entities for GitLab GAR provides three APIs: Docker API, REST API, and RPC API. -The [Docker API](https://cloud.google.com/artifact-registry/docs/reference/docker-api) is based on the [Docker Registry HTTP API V2](https://docs.docker.com/registry/spec/api), now superseded by the [OCI Distribution Specification API](https://github.com/opencontainers/distribution-spec/blob/main/spec.md) (from now on referred to as OCI API). This API is used for pushing/pulling images to/from GAR and also provides some discoverability operations. Please refer to [Alternative Solutions](#alternative-solutions) for the reasons why we don't intend to use it. +The [Docker API](https://cloud.google.com/artifact-registry/docs/reference/docker-api) is based on the [Docker Registry HTTP API V2](https://docs.docker.com/registry/spec/api), now superseded by the [OCI Distribution Specification API](https://github.com/opencontainers/distribution-spec/blob/main/spec.md) (from now on referred to as OCI API). This API is used for pushing/pulling images to/from GAR and also provides some discoverability operations. Refer to [Alternative Solutions](#alternative-solutions) for the reasons why we don't intend to use it. Among the proprietary GAR APIs, the [REST API](https://cloud.google.com/artifact-registry/docs/reference/rest) provides basic functionality for managing repositories. This includes [`list`](https://cloud.google.com/artifact-registry/docs/reference/rest/v1/projects.locations.repositories.dockerImages/list) and [`get`](https://cloud.google.com/artifact-registry/docs/reference/rest/v1/projects.locations.repositories.dockerImages/get) operations for container image repositories, which could be used for this integration. Both operations return the same data structure, represented by the [`DockerImage`](https://cloud.google.com/artifact-registry/docs/reference/rest/v1/projects.locations.repositories.dockerImages#DockerImage) object, so both provide the same level of detail. Last but not least, there is also an [RPC API](https://cloud.google.com/artifact-registry/docs/reference/rpc/google.devtools.artifactregistry.v1), backed by gRPC and Protocol Buffers. This API provides the most functionality, covering all GAR features. From the available operations, we can make use of the [`ListDockerImagesRequest`](https://cloud.google.com/artifact-registry/docs/reference/rpc/google.devtools.artifactregistry.v1#listdockerimagesrequest) and [`GetDockerImageRequest`](https://cloud.google.com/artifact-registry/docs/reference/rpc/google.devtools.artifactregistry.v1#google.devtools.artifactregistry.v1.GetDockerImageRequest) operations. As with the REST API, both responses are composed of [`DockerImage`](https://cloud.google.com/artifact-registry/docs/reference/rpc/google.devtools.artifactregistry.v1#google.devtools.artifactregistry.v1.DockerImage) objects. -Between the two proprietary API options, we chose the RPC one because it provides support not only for the operations we need today but also offers better coverage of all GAR features, which will be beneficial in future iterations. Finally, we do not intend to make direct use of this API but rather use it through the official Ruby client SDK. Please see [Client SDK](backend.md#client-sdk) below for more details. +Between the two proprietary API options, we chose the RPC one because it provides support not only for the operations we need today but also offers better coverage of all GAR features, which will be beneficial in future iterations. Finally, we do not intend to make direct use of this API but rather use it through the official Ruby client SDK. See [Client SDK](backend.md#client-sdk) below for more details. #### Backend Integration diff --git a/doc/architecture/blueprints/observability_logging/index.md b/doc/architecture/blueprints/observability_logging/index.md index d8259e0a73632dd85796c5083667fd23d99c0c95..bbe15cde58e2572b1d3b5d46fb2e04fd9c717850 100644 --- a/doc/architecture/blueprints/observability_logging/index.md +++ b/doc/architecture/blueprints/observability_logging/index.md @@ -121,7 +121,7 @@ Hence the decision to only support Log objects seems like a boring and simple so Similar to traces, logging data ingestion will be done at the Ingress level. As part of [the forward-auth](https://doc.traefik.io/traefik/middlewares/http/forwardauth/) flow, Traefik will forward the request to Gatekeeper which in turn leverages Redis for counting. This is currently done only for [the ingestion path](https://gitlab.com/gitlab-org/opstrace/opstrace/-/merge_requests/2236). -Please check the MR description for more details on how it works. +Check the MR description for more details on how it works. The read path rate limiting implementation is tracked [here](https://gitlab.com/gitlab-org/opstrace/opstrace/-/issues/2356). ### Database schema @@ -629,4 +629,4 @@ Long-term, we will need a way to monitor the number of user queries that failed ## Iterations -Please refer to [Observability Group planning epic](https://gitlab.com/groups/gitlab-org/opstrace/-/epics/92) and its linked issues for up-to-date information. +Refer to [Observability Group planning epic](https://gitlab.com/groups/gitlab-org/opstrace/-/epics/92) and its linked issues for up-to-date information. diff --git a/doc/architecture/blueprints/runner_tokens/index.md b/doc/architecture/blueprints/runner_tokens/index.md index 5e1300f9a3bdc9869607a5d79592f393f29f216a..f2e9d624d204db0320074a6fc9af538e3e14523d 100644 --- a/doc/architecture/blueprints/runner_tokens/index.md +++ b/doc/architecture/blueprints/runner_tokens/index.md @@ -440,7 +440,7 @@ scope. ## FAQ -Please follow [the user documentation](../../../ci/runners/new_creation_workflow.md). +Follow [the user documentation](../../../ci/runners/new_creation_workflow.md). ## Status diff --git a/doc/cloud_seed/index.md b/doc/cloud_seed/index.md index 70166b2d09f6a9374af70d0db6fa378c2acd0e17..8180669b1afea334891af56cc1ca29debec4e89d 100644 --- a/doc/cloud_seed/index.md +++ b/doc/cloud_seed/index.md @@ -120,7 +120,7 @@ The following databases and versions are supported: - 2019: Standard, Enterprise, Express, and Web - 2017: Standard, Enterprise, Express, and Web -Google Cloud pricing applies. Please refer to the [Cloud SQL pricing page](https://cloud.google.com/sql/pricing). +Google Cloud pricing applies. Refer to the [Cloud SQL pricing page](https://cloud.google.com/sql/pricing). 1. [Create a database instance](#create-a-database-instance) 1. [Database setup through a background worker](#database-setup-through-a-background-worker) diff --git a/doc/development/advanced_search.md b/doc/development/advanced_search.md index 64127af58a1997ad0eb2c34343c9e757ba81a56e..a552b22226d10e9c50a2d0245b4aae83a827b7d3 100644 --- a/doc/development/advanced_search.md +++ b/doc/development/advanced_search.md @@ -32,7 +32,7 @@ See the [Elasticsearch GDK setup instructions](https://gitlab.com/gitlab-org/git - `gitlab:elastic:test:index_size`: Tells you how much space the current index is using, as well as how many documents are in the index. - `gitlab:elastic:test:index_size_change`: Outputs index size, reindexes, and outputs index size again. Useful when testing improvements to indexing size. -Additionally, if you need large repositories or multiple forks for testing, please consider [following these instructions](rake_tasks.md#extra-project-seed-options) +Additionally, if you need large repositories or multiple forks for testing, consider [following these instructions](rake_tasks.md#extra-project-seed-options) ## How does it work? @@ -40,7 +40,7 @@ The Elasticsearch integration depends on an external indexer. We ship an [indexe After initial indexing is complete, create, update, and delete operations for all models except projects (see [#207494](https://gitlab.com/gitlab-org/gitlab/-/issues/207494)) are tracked in a Redis [`ZSET`](https://redis.io/docs/manual/data-types/#sorted-sets). A regular `sidekiq-cron` `ElasticIndexBulkCronWorker` processes this queue, updating many Elasticsearch documents at a time with the [Bulk Request API](https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-bulk.html). -Search queries are generated by the concerns found in [`ee/app/models/concerns/elastic`](https://gitlab.com/gitlab-org/gitlab/-/tree/master/ee/app/models/concerns/elastic). These concerns are also in charge of access control, and have been a historic source of security bugs so please pay close attention to them! +Search queries are generated by the concerns found in [`ee/app/models/concerns/elastic`](https://gitlab.com/gitlab-org/gitlab/-/tree/master/ee/app/models/concerns/elastic). These concerns are also in charge of access control, and have been a historic source of security bugs so pay close attention to them! ### Custom routing @@ -62,13 +62,13 @@ The following analyzers and tokenizers are defined in [`ee/lib/elastic/latest/co Used when indexing blobs' paths. Uses the `path_tokenizer` and the `lowercase` and `asciifolding` filters. -Please see the `path_tokenizer` explanation below for an example. +See the `path_tokenizer` explanation below for an example. #### `sha_analyzer` Used in blobs and commits. Uses the `sha_tokenizer` and the `lowercase` and `asciifolding` filters. -Please see the `sha_tokenizer` explanation later below for an example. +See the `sha_tokenizer` explanation later below for an example. #### `code_analyzer` @@ -76,7 +76,7 @@ Used when indexing a blob's filename and content. Uses the `whitespace` tokenize The `whitespace` tokenizer was selected to have more control over how tokens are split. For example the string `Foo::bar(4)` needs to generate tokens like `Foo` and `bar(4)` to be properly searched. -Please see the `code` filter for an explanation on how tokens are split. +See the `code` filter for an explanation on how tokens are split. NOTE: The [Elasticsearch `code_analyzer` doesn't account for all code cases](../integration/advanced_search/elasticsearch_troubleshooting.md#elasticsearch-code_analyzer-doesnt-account-for-all-code-cases). diff --git a/doc/development/ai_architecture.md b/doc/development/ai_architecture.md index e1ad9745fee1175ee427659ade3431dc550b8be9..0717872a12b4d33fbf5e99abccaa161c4ba32b57 100644 --- a/doc/development/ai_architecture.md +++ b/doc/development/ai_architecture.md @@ -19,7 +19,7 @@ The following diagram from the [architecture blueprint](../architecture/blueprin ## SaaS-based AI abstraction layer -GitLab currently operates a cloud-hosted AI architecture. We will allow access to it for licensed self managed instances using the AI-gateway. Please see [the blueprint](../architecture/blueprints/ai_gateway) for details +GitLab currently operates a cloud-hosted AI architecture. We will allow access to it for licensed self managed instances using the AI-gateway. See [the blueprint](../architecture/blueprints/ai_gateway) for details. There are two primary reasons for this: the best AI models are cloud-based as they often depend on specialized hardware designed for this purpose, and operating self-managed infrastructure capable of AI at-scale and with appropriate performance is a significant undertaking. We are actively [tracking self-managed customers interested in AI](https://gitlab.com/gitlab-org/gitlab/-/issues/409183). diff --git a/doc/development/ai_features/glossary.md b/doc/development/ai_features/glossary.md index 2228d6e231a4c1f4e4249d86a258953b245ddd27..be856639b83ca843938d5eba7b7abbfa27af3a82 100644 --- a/doc/development/ai_features/glossary.md +++ b/doc/development/ai_features/glossary.md @@ -8,7 +8,7 @@ info: To determine the technical writer assigned to the Stage/Group associated w This is a list of terms that may have a general meaning but also may have a specific meaning at GitLab. If you encounter a piece of technical jargon related -to AI that you think could benefit from being in this list, please add it! +to AI that you think could benefit from being in this list, add it! - **AI Gateway**: standalone service used to give access to AI features to non-SaaS GitLab users. This logic will be moved to Cloud Connector when that diff --git a/doc/development/ai_features/index.md b/doc/development/ai_features/index.md index 35c329ff1e60db0735b0db5913c8fb699e2177ca..d1b530f00cffaa41a7ddfe51f4c629068a00f947 100644 --- a/doc/development/ai_features/index.md +++ b/doc/development/ai_features/index.md @@ -93,7 +93,7 @@ For features that use the embedding database, additional setup is needed. ### Configure GCP Vertex access -In order to obtain a GCP service key for local development, please follow the steps below: +In order to obtain a GCP service key for local development, follow the steps below: - Create a sandbox GCP project by visiting [this page](https://about.gitlab.com/handbook/infrastructure-standards/#individual-environment) and following the instructions, or by requesting access to our existing group GCP project by using [this template](https://gitlab.com/gitlab-com/it/infra/issue-tracker/-/issues/new?issuable_template=gcp_group_account_iam_update_request). - If you are using an individual GCP project, you may also need to enable the Vertex AI API: diff --git a/doc/development/api_graphql_styleguide.md b/doc/development/api_graphql_styleguide.md index f6d39ff954b8df612ae0d6099601623eb5d43ea7..ab291026fc64a6209cbd44c127670e1bbd89cf34 100644 --- a/doc/development/api_graphql_styleguide.md +++ b/doc/development/api_graphql_styleguide.md @@ -58,7 +58,7 @@ For example, the one for [GitLab.com](https://gitlab.com/-/graphql-explorer). The GraphQL framework has some specific gotchas to be aware of, and domain expertise is required to ensure they are satisfied. -If you are asked to review a merge request that modifies any GraphQL files or adds an endpoint, please have a look at +If you are asked to review a merge request that modifies any GraphQL files or adds an endpoint, have a look at [our GraphQL review guide](graphql_guide/reviewing.md). ## Reading GraphQL logs diff --git a/doc/development/api_styleguide.md b/doc/development/api_styleguide.md index 7a5898c652187d803b546359515a5fde15b9143c..714115d474af47a5418bb39ab809218a717105cb 100644 --- a/doc/development/api_styleguide.md +++ b/doc/development/api_styleguide.md @@ -10,7 +10,7 @@ This style guide recommends best practices for API development. ## Instance variables -Please do not use instance variables, there is no need for them (we don't need +Don't use instance variables, there is no need for them (we don't need to access them as we do in Rails views), local variables are fine. ## Entities @@ -321,7 +321,7 @@ it's own file in the [`validators`](https://gitlab.com/gitlab-org/gitlab/-/blob/ ## Internal API -The [internal API](internal_api/index.md) is documented for internal use. Please keep it up to date so we know what endpoints +The [internal API](internal_api/index.md) is documented for internal use. Keep it up to date so we know what endpoints different components are making use of. ## Avoiding N+1 problems diff --git a/doc/development/application_secrets.md b/doc/development/application_secrets.md index 3961cc08d97f612f91709958b114bd7949484e27..3217f0500f81db692e3a9dd1fd4d3ad065bfc6e8 100644 --- a/doc/development/application_secrets.md +++ b/doc/development/application_secrets.md @@ -46,4 +46,4 @@ GitLab.com environments prior to changing this file. ## Further iteration We may either deprecate or remove this automatic secret generation `01_secret_token.rb` in the future. -Please see [issue 222690](https://gitlab.com/gitlab-org/gitlab/-/issues/222690) for more information. +See [issue 222690](https://gitlab.com/gitlab-org/gitlab/-/issues/222690) for more information. diff --git a/doc/development/application_slis/index.md b/doc/development/application_slis/index.md index 3eacfab7d7cc64eacfaad422dd2436cd750510f8..c5cdc6edc5a3bbcdfe9d22f66a9287900b9aa978 100644 --- a/doc/development/application_slis/index.md +++ b/doc/development/application_slis/index.md @@ -179,7 +179,7 @@ In [this project](https://gitlab.com/groups/gitlab-com/gl-infra/-/epics/614) we are extending this so alerts for SLIs with a `feature_category` label in the source metrics can also be routed. -For any question, please don't hesitate to create an issue in +For any question, don't hesitate to create an issue in [the Scalability issue tracker](https://gitlab.com/gitlab-com/gl-infra/scalability/-/issues) or come find us in [#g_scalability](https://gitlab.slack.com/archives/CMMF8TKR9) on Slack. diff --git a/doc/development/application_slis/rails_request.md b/doc/development/application_slis/rails_request.md index 981fc28c9b0cf58d4b3b53bce4880ba03c1d8c98..2d18e2a8a1502a2c12756a6b34cf6edcdfd75a73 100644 --- a/doc/development/application_slis/rails_request.md +++ b/doc/development/application_slis/rails_request.md @@ -126,7 +126,7 @@ a case-by-case basis. Take the following into account: view. We cannot scale up the fleet fast enough to accommodate for the incoming slow requests alongside the regular traffic. -When lowering the urgency for an existing endpoint, please involve a +When lowering the urgency for an existing endpoint, involve a [Scalability team member](https://about.gitlab.com/handbook/engineering/infrastructure/team/scalability/#team-members) in the review. We can use request rates and durations available in the logs to come up with a recommendation. You can pick a threshold @@ -172,7 +172,7 @@ information in the logs to check: the target duration we want to set. As decreasing a threshold too much could result in alerts for the -Apdex degradation, please also involve a Scalability team member in +Apdex degradation, also involve a Scalability team member in the merge request. ## How to adjust the urgency diff --git a/doc/development/audit_event_guide/index.md b/doc/development/audit_event_guide/index.md index df1d2dd03b580e57a87033a2f932e38730220ba0..28af4c3e0bbc42835fc4014a57dfa45fe66d7a9c 100644 --- a/doc/development/audit_event_guide/index.md +++ b/doc/development/audit_event_guide/index.md @@ -23,7 +23,7 @@ While any events could trigger an Audit Event, not all events should. In general - Are tracking information for product feature adoption. - Are covered in the direction page's discussion on [what is not planned](https://about.gitlab.com/direction/govern/compliance/audit-events/#what-is-not-planned-right-now). -If you have any questions, please reach out to `@gitlab-org/govern/compliance` to see if an Audit Event, or some other approach, may be best for your event. +If you have any questions, reach out to `@gitlab-org/govern/compliance` to see if an Audit Event, or some other approach, may be best for your event. ## Audit Event Schemas diff --git a/doc/development/avoiding_required_stops.md b/doc/development/avoiding_required_stops.md index 551ffd3e12ddbb85e4fa2242a38068b7d1b7c2e4..74db216a1f0c20983bdb6f5e10b838eb975bf4d0 100644 --- a/doc/development/avoiding_required_stops.md +++ b/doc/development/avoiding_required_stops.md @@ -32,7 +32,7 @@ Wherever possible, a required stop should be avoided. If it can't be avoided, the required stop should be aligned to a _scheduled_ required stop. In cases where we are considering retroactively declaring an unplanned required stop, -please contact the [Distribution team product manager](https://about.gitlab.com/handbook/product/categories/#distributionbuild-group) to advise on next steps. If there +contact the [Distribution team product manager](https://about.gitlab.com/handbook/product/categories/#distributionbuild-group) to advise on next steps. If there is uncertainty about whether we should declare a required stop, the Distribution product manager may escalate to GitLab product leadership (VP or Chief Product Officer) to make a final determination. This may happen, for example, if a change might require a stop for diff --git a/doc/development/cicd/index.md b/doc/development/cicd/index.md index 6e6156c8f52681ff59ba453d9eac89d9c308252e..18781f9315a3b7f7efc65bfb8ce2e71e9f924999 100644 --- a/doc/development/cicd/index.md +++ b/doc/development/cicd/index.md @@ -8,7 +8,7 @@ info: Any user with at least the Maintainer role can merge updates to this conte Development guides that are specific to CI/CD are listed here: -- If you are creating new CI/CD templates, please read [the development guide for GitLab CI/CD templates](templates.md). +- If you are creating new CI/CD templates, read [the development guide for GitLab CI/CD templates](templates.md). - If you are adding a new keyword or changing the CI schema, check the [CI schema guide](schema.md) See the [CI/CD YAML reference documentation guide](cicd_reference_documentation_guide.md) diff --git a/doc/development/cicd/templates.md b/doc/development/cicd/templates.md index e9cfe0fc56f32e2ded5ed73d9b445dfdb5a2de94..dfa77362a9d6dc5beddc4d861421ae9318de4843 100644 --- a/doc/development/cicd/templates.md +++ b/doc/development/cicd/templates.md @@ -284,7 +284,7 @@ the user's `.gitlab-ci.yml` immediately causes a lint error because there are no such jobs named `performance` in the included template anymore. Therefore, users have to fix their `.gitlab-ci.yml` that could annoy their workflow. -Please read [versioning](#versioning) section for introducing breaking change safely. +Read [versioning](#versioning) section for introducing breaking change safely. ## Versioning @@ -377,7 +377,7 @@ Each CI/CD template must be tested to make sure that it's safe to be published. ### Manual QA It's always good practice to test the template in a minimal demo project. -To do so, please follow the following steps: +To do so, follow the following steps: 1. Create a public sample project on <https://gitlab.com>. 1. Add a `.gitlab-ci.yml` to the project with the proposed template. @@ -481,6 +481,6 @@ If you're unsure if it's secure or not, you must ask security experts for cross- After your CI/CD template MR is created and labeled with `ci::templates`, DangerBot suggests one reviewer and one maintainer that can review your code. When your merge -request is ready for review, please [mention](../../user/discussions/index.md#mentions) +request is ready for review, [mention](../../user/discussions/index.md#mentions) the reviewer and ask them to review your CI/CD template changes. See details in the merge request that added [a DangerBot task for CI/CD template MRs](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/44688). diff --git a/doc/development/code_comments.md b/doc/development/code_comments.md index b1a360a8a2f364b890e7666ee348f36e0a0f1d25..51643f3e7ed5833ce7187f10bb6ea8cf2c4bf042 100644 --- a/doc/development/code_comments.md +++ b/doc/development/code_comments.md @@ -7,7 +7,7 @@ info: Any user with at least the Maintainer role can merge updates to this conte # Code comments Whenever you add comment to the code that is expected to be addressed at any time -in future, please create a technical debt issue for it. Then put a link to it +in future, create a technical debt issue for it. Then put a link to it to the code comment you've created. This allows other developers to quickly check if a comment is still relevant and what needs to be done to address it. diff --git a/doc/development/code_review.md b/doc/development/code_review.md index 401cca494293ca65f9dad858fd565f6528b4a192..32a7e394034392355cda3e40f454916b824e4070 100644 --- a/doc/development/code_review.md +++ b/doc/development/code_review.md @@ -251,7 +251,7 @@ See the [test engineering process](https://about.gitlab.com/handbook/engineering 1. You have reviewed the documentation regarding [internal application security reviews](https://about.gitlab.com/handbook/security/#internal-application-security-reviews) for **when** and **how** to request a security review and requested a security review if this is warranted for this change. 1. If there are security scan results that are blocking the MR (due to the [scan result policies](https://gitlab.com/gitlab-com/gl-security/security-policies)): - For true positive findings, they should be corrected before the merge request is merged. This will remove the AppSec approval required by the scan result policy. - - For false positive findings, something that should be discussed for risk acceptance, or anything questionable, please ping `@gitlab-com/gl-security/appsec`. + - For false positive findings, something that should be discussed for risk acceptance, or anything questionable, ping `@gitlab-com/gl-security/appsec`. ##### Deployment @@ -466,7 +466,7 @@ Here is a summary of the changes, also reflected in this section above. ### Having your merge request reviewed -Please keep in mind that code review is a process that can take multiple +Keep in mind that code review is a process that can take multiple iterations, and reviewers may spot things later that they may not have seen the first time. diff --git a/doc/development/contributing/index.md b/doc/development/contributing/index.md index f95d6abca5483f5ef96d2ae1611041aefcfc70ec..39414f9c298f2419a1e74743bcc008f9dd509185 100644 --- a/doc/development/contributing/index.md +++ b/doc/development/contributing/index.md @@ -142,7 +142,7 @@ Lastly, keep the following in mind when submitting merge requests: ## Contributing to Premium/Ultimate features with an Enterprise Edition license If you would like to work on GitLab features that are within a paid tier, also known as the code that lives in the [EE folder](https://gitlab.com/gitlab-org/gitlab/-/tree/master/ee), it requires a GitLab Enterprise Edition license. -Please request an Enterprise Edition Developers License according to the [documented process](https://about.gitlab.com/handbook/marketing/developer-relations/contributor-success/community-contributors-workflows.html#contributing-to-the-gitlab-enterprise-edition-ee). +Request an Enterprise Edition Developers License according to the [documented process](https://about.gitlab.com/handbook/marketing/developer-relations/contributor-success/community-contributors-workflows.html#contributing-to-the-gitlab-enterprise-edition-ee). ## Get help diff --git a/doc/development/contributing/issue_workflow.md b/doc/development/contributing/issue_workflow.md index b5a49ffa9956ddd99f7dbf0dd57c196d9df35ebf..b59a77c1f524c4318f8ffa1a7a11d9b0221fb943 100644 --- a/doc/development/contributing/issue_workflow.md +++ b/doc/development/contributing/issue_workflow.md @@ -34,7 +34,7 @@ In order to help track feature proposals, we use the Users that are not members of the project cannot add labels via the UI. Instead, use [reactive label commands](https://about.gitlab.com/handbook/engineering/quality/triage-operations/#reactive-label-and-unlabel-commands). -Please keep feature proposals as small and simple as possible, complex ones +Keep feature proposals as small and simple as possible, complex ones might be edited to make them small and simple. For changes to the user interface (UI), follow our [design and UI guidelines](design.md), @@ -77,7 +77,7 @@ You are very welcome to help the GitLab team triage issues. The most important thing is making sure valid issues receive feedback from the development team. Therefore the priority is mentioning developers that can help -on those issues. Please select someone with relevant experience from the +on those issues. Select someone with relevant experience from the [GitLab team](https://about.gitlab.com/company/team/). If there is nobody mentioned with that expertise, look in the commit history for the affected files to find someone. @@ -120,7 +120,7 @@ with a reference to an issue describing the regression, and then to update that note with a reference to the merge request that fixes it as it becomes available. If you're a contributor who doesn't have the required permissions to update -other users' notes, please post a new note with a reference to both the issue +other users' notes, post a new note with a reference to both the issue and the merge request. The release manager will diff --git a/doc/development/contributing/merge_request_workflow.md b/doc/development/contributing/merge_request_workflow.md index c6376c083aa1072298ce0be42e7e0c0454211ff9..30fe82aae58e2e5f08c73463a849ae367ca7a415 100644 --- a/doc/development/contributing/merge_request_workflow.md +++ b/doc/development/contributing/merge_request_workflow.md @@ -14,7 +14,7 @@ label, but you are free to contribute to any issue you want. ## Working from issues -If you find an issue, please submit a merge request with a fix or improvement, +If you find an issue, submit a merge request with a fix or improvement, if you can, and include tests. If you want to add a new feature that is not labeled, it is best to first create @@ -70,13 +70,13 @@ For a walkthrough of the contribution process, see [Tutorial: Make a GitLab cont - If you would like quick feedback on your merge request feel free to mention someone from the [core team](https://about.gitlab.com/community/core-team/) or one of the [merge request coaches](https://about.gitlab.com/company/team/). When having your code reviewed - and when reviewing merge requests, please keep the [code review guidelines](../code_review.md) + and when reviewing merge requests, keep the [code review guidelines](../code_review.md) in mind. And if your code also makes changes to the database, or does expensive queries, check the [database review guidelines](../database_review.md). ### Keep it simple -*Live by smaller iterations.* Please keep the amount of changes in a single MR **as small as possible**. +*Live by smaller iterations.* Keep the amount of changes in a single MR **as small as possible**. If you want to contribute a large feature, think very carefully about what the [minimum viable change](https://about.gitlab.com/handbook/product/#the-minimally-viable-change) is. Can you split the functionality into two smaller MRs? Can you submit only the @@ -156,7 +156,7 @@ Example commit message template that can be used on your machine that embodies t ## Contribution acceptance criteria -To make sure that your merge request can be approved, please ensure that it meets +To make sure that your merge request can be approved, ensure that it meets the contribution acceptance criteria below: 1. The change is as small as possible. @@ -195,7 +195,7 @@ the contribution acceptance criteria below: ## Definition of done -If you contribute to GitLab, please know that changes involve more than just +If you contribute to GitLab, know that changes involve more than just code. We use the following [definition of done](https://www.agilealliance.org/glossary/definition-of-done/). To reach the definition of done, the merge request must create no regressions and meet all these criteria: @@ -263,7 +263,7 @@ requirements. 1. For tests that use Capybara, read [how to write reliable, asynchronous integration tests](https://thoughtbot.com/blog/write-reliable-asynchronous-integration-tests-with-capybara). 1. [Black-box tests/end-to-end tests](../testing_guide/testing_levels.md#black-box-tests-at-the-system-level-aka-end-to-end-tests) - added if required. Please contact [the quality team](https://about.gitlab.com/handbook/engineering/quality/#teams) + added if required. Contact [the quality team](https://about.gitlab.com/handbook/engineering/quality/#teams) with any questions. 1. The change is tested in a review app where possible and if appropriate. 1. Code affected by a feature flag is covered by [automated tests with the feature flag enabled and disabled](../feature_flags/index.md#feature-flags-in-tests), or both @@ -275,7 +275,7 @@ requirements. 1. Use available components from the GitLab Design System, [Pajamas](https://design.gitlab.com/). 1. The MR must include *Before* and *After* screenshots if UI changes are made. -1. If the MR changes CSS classes, please include the list of affected pages, which +1. If the MR changes CSS classes, include the list of affected pages, which can be found by running `grep css-class ./app -R`. ### Description of changes @@ -323,7 +323,7 @@ Contributions do not require approval from the [Product team](https://about.gitl ## Dependencies -If you add a dependency in GitLab (such as an operating system package) please +If you add a dependency in GitLab (such as an operating system package), consider updating the following, and note the applicability of each in your merge request: diff --git a/doc/development/contributing/verify/index.md b/doc/development/contributing/verify/index.md index 9cd44b6cb64390d0621dcd265ab2aa03b63a9c6b..dbc48121dffcdece9f33f4786edf6ccb3fa00563 100644 --- a/doc/development/contributing/verify/index.md +++ b/doc/development/contributing/verify/index.md @@ -242,7 +242,7 @@ scenario relating to a software being built by one of our [early customers](http > could generate a new particle that would then cause the universe to implode. That would be quite an undesirable outcome of a small bug in GitLab CI/CD status -processing. Please take extra care when you are working on CI/CD statuses, +processing. Take extra care when you are working on CI/CD statuses, we don't want to implode our Universe! This is an extreme and unlikely scenario, but presenting data that is not accurate diff --git a/doc/development/database/database_reviewer_guidelines.md b/doc/development/database/database_reviewer_guidelines.md index 69b4b3b7a028a138ed2841367c3e00787850dd4a..07785557813f019a57114712ae83e47440c02f55 100644 --- a/doc/development/database/database_reviewer_guidelines.md +++ b/doc/development/database/database_reviewer_guidelines.md @@ -84,7 +84,7 @@ topics and use cases. The most frequently required during database reviewing are Database maintainership uses the same process as other projects for identifying maintainers. [Follow the general process documented here](https://about.gitlab.com/handbook/engineering/workflow/code-review/#how-to-become-a-project-maintainer). -For database specific requirements, please see [`Project maintainer process for gitlab-database`](https://about.gitlab.com/handbook/engineering/workflow/code-review/#project-maintainer-process-for-gitlab-database) +For database specific requirements, see [`Project maintainer process for gitlab-database`](https://about.gitlab.com/handbook/engineering/workflow/code-review/#project-maintainer-process-for-gitlab-database) ## What to do if you feel overwhelmed diff --git a/doc/development/event_store.md b/doc/development/event_store.md index ea7ccb9f7268c156c22ff51104f88d6c12b49efd..0ffcf8704ff1b3aef3ff10c9090e4e01abe4b23f 100644 --- a/doc/development/event_store.md +++ b/doc/development/event_store.md @@ -184,7 +184,7 @@ Changes to the schema require multiple rollouts. While the new version is being - Existing subscribers can consume events using the old version. - Events get persisted in the Sidekiq queue as job arguments, so we could have 2 versions of the schema during deployments. -As changing the schema ultimately impacts the Sidekiq arguments, please refer to our +As changing the schema ultimately impacts the Sidekiq arguments, refer to our [Sidekiq style guide](sidekiq/compatibility_across_updates.md#changing-the-arguments-for-a-worker) with regards to multiple rollouts. #### Add properties diff --git a/doc/development/fe_guide/graphql.md b/doc/development/fe_guide/graphql.md index 9bfc68bd2acd18fadca3c9d07e9f5c288f1d97d5..22b977519be06cdc5e86b33a42185318f7a8e7ce 100644 --- a/doc/development/fe_guide/graphql.md +++ b/doc/development/fe_guide/graphql.md @@ -104,7 +104,7 @@ Default client accepts two parameters: `resolvers` and `config`. ### Multiple client queries for the same object -If you are making multiple queries to the same Apollo client object you might encounter the following error: `Cache data may be lost when replacing the someProperty field of a Query object. To address this problem, either ensure all objects of SomeEntityhave an id or a custom merge function`. We are already checking `id` presence for every GraphQL type that has an `id`, so this shouldn't be the case (unless you see this warning when running unit tests; in this case please ensure your mocked responses contain an `id` whenever it's requested). +If you are making multiple queries to the same Apollo client object you might encounter the following error: `Cache data may be lost when replacing the someProperty field of a Query object. To address this problem, either ensure all objects of SomeEntityhave an id or a custom merge function`. We are already checking `id` presence for every GraphQL type that has an `id`, so this shouldn't be the case (unless you see this warning when running unit tests; in this case ensure your mocked responses contain an `id` whenever it's requested). When `SomeEntity` type doesn't have an `id` property in the GraphQL schema, to fix this warning we need to define a custom merge function. diff --git a/doc/development/fe_guide/index.md b/doc/development/fe_guide/index.md index 3c7c000dbe6c12f6d89511dbefebaaed188e6f12..40ff704edfa2c86d76ecf74e32715484757528f8 100644 --- a/doc/development/fe_guide/index.md +++ b/doc/development/fe_guide/index.md @@ -11,7 +11,7 @@ across the GitLab frontend team. ## Overview -GitLab is built on top of [Ruby on Rails](https://rubyonrails.org). It uses [Haml](https://haml.info/) and a JavaScript-based frontend with [Vue.js](https://vuejs.org). If you are not sure when to use Vue on top of Haml-page, please read [this explanation](vue.md#when-to-add-vue-application). +GitLab is built on top of [Ruby on Rails](https://rubyonrails.org). It uses [Haml](https://haml.info/) and a JavaScript-based frontend with [Vue.js](https://vuejs.org). If you are not sure when to use Vue on top of Haml-page, read [this explanation](vue.md#when-to-add-vue-application). <!-- vale gitlab.Spelling = NO --> @@ -19,7 +19,7 @@ Be wary of [the limitations that come with using Hamlit](https://github.com/k0ku <!-- vale gitlab.Spelling = YES --> -When it comes to CSS, we use a utils-based CSS approach. GitLab has its own CSS utils which are packaged inside the `gitlab-ui` project and can be seen [in the repository](https://gitlab.com/gitlab-org/gitlab-ui/-/tree/main/src/scss/utility-mixins) or on [UNPKG](https://unpkg.com/browse/@gitlab/ui@latest/src/scss/utility-mixins/). Please favor using these before adding or using any SCSS classes. +When it comes to CSS, we use a utils-based CSS approach. GitLab has its own CSS utils which are packaged inside the `gitlab-ui` project and can be seen [in the repository](https://gitlab.com/gitlab-org/gitlab-ui/-/tree/main/src/scss/utility-mixins) or on [UNPKG](https://unpkg.com/browse/@gitlab/ui@latest/src/scss/utility-mixins/). Favor using these before adding or using any SCSS classes. We also use [SCSS](https://sass-lang.com) and plain JavaScript with modern ECMAScript standards supported through [Babel](https://babeljs.io/) and ES module support through [webpack](https://webpack.js.org/). @@ -31,7 +31,7 @@ We use [Apollo](https://www.apollographql.com/) as our global state manager and You should **not** [use VueX and Apollo together](graphql.md#using-with-vuex), and should [avoid adding new VueX stores](migrating_from_vuex.md) whenever possible. -For copy strings and translations, we have frontend utilities available. Please see the JavaScript section of [Preparing a page for translation](../i18n/externalization.md#javascript-files) for more information. +For copy strings and translations, we have frontend utilities available. See the JavaScript section of [Preparing a page for translation](../i18n/externalization.md#javascript-files) for more information. Working with our frontend assets requires Node (v12.22.1 or greater) and Yarn (v1.10.0 or greater). You can find information on how to install these on our diff --git a/doc/development/fe_guide/onboarding_course/index.md b/doc/development/fe_guide/onboarding_course/index.md index 082ab08fe58cc18c3ed65339a1df38a00fc1e074..d8d4cdad8a6ca4b442a801167ac8d66eee7445f2 100644 --- a/doc/development/fe_guide/onboarding_course/index.md +++ b/doc/development/fe_guide/onboarding_course/index.md @@ -46,7 +46,7 @@ A fortnightly 1-on-1 mentoring sessions are also available to each participant. There are 10 places available on the course. The date will be set after the course material has been prepared. -Please complete the [Frontend Onboarding Course Application Form](https://forms.gle/39Rs4w4ZxQuByhE4A) to apply. +Complete the [Frontend Onboarding Course Application Form](https://forms.gle/39Rs4w4ZxQuByhE4A) to apply. You may also participate in the course informally at your own pace, without the benefit of the synchronous office hours or mentoring session. GitLab team members are happy to support you regardless. diff --git a/doc/development/fe_guide/vue.md b/doc/development/fe_guide/vue.md index 1886e9c74834f3086cad0724b51c711b2a6863bb..a50e3fea60561a537370ef5c3f8e476cb034a6bc 100644 --- a/doc/development/fe_guide/vue.md +++ b/doc/development/fe_guide/vue.md @@ -39,9 +39,9 @@ In the past, we added interactivity to the page piece-by-piece, adding multiple - multiple applications lead to unpredictable user experience, increased page complexity, harder debugging process; - the way apps communicate with each other affects Web Vitals numbers. -Because of these reasons, we want to be cautious about adding new Vue applications to the pages where another Vue application is already present (this does not include old or new navigation). Before adding a new app, please make sure that it is absolutely impossible to extend an existing application to achieve a desired functionality. When in doubt, please feel free to ask for the architectural advise on `#frontend` or `#frontend-maintainers` Slack channel. +Because of these reasons, we want to be cautious about adding new Vue applications to the pages where another Vue application is already present (this does not include old or new navigation). Before adding a new app, make sure that it is absolutely impossible to extend an existing application to achieve a desired functionality. When in doubt, feel free to ask for the architectural advise on `#frontend` or `#frontend-maintainers` Slack channel. -If you still need to add a new application, please make sure it shares local state with existing applications (preferably via Apollo Client, or Vuex if we use REST API) +If you still need to add a new application, make sure it shares local state with existing applications (preferably via Apollo Client, or Vuex if we use REST API) ## Vue architecture diff --git a/doc/development/fe_guide/vuex.md b/doc/development/fe_guide/vuex.md index 1adbd892fc0cc4c947abf1531d78351cdb2d77c6..aff3588a503b508fad5b64b8ae31eb737c91f072 100644 --- a/doc/development/fe_guide/vuex.md +++ b/doc/development/fe_guide/vuex.md @@ -6,7 +6,7 @@ info: Any user with at least the Maintainer role can merge updates to this conte # Vuex -[Vuex](https://vuex.vuejs.org) should no longer be considered a preferred path to store management and is currently in its legacy phase. This means it is acceptable to add upon existing `Vuex` stores, but we strongly recommend reducing store sizes over time and eventually [migrating away from VueX entirely](migrating_from_vuex.md). Before adding any new `Vuex` store to an application, first ensure that the `Vue` application you plan to add it into **does not use** `Apollo`. `Vuex` and `Apollo` should not be combined unless absolutely necessary. Please consider reading through [our GraphQL documentation](../fe_guide/graphql.md) for more guidelines on how you can build `Apollo` based applications. +[Vuex](https://vuex.vuejs.org) should no longer be considered a preferred path to store management and is currently in its legacy phase. This means it is acceptable to add upon existing `Vuex` stores, but we strongly recommend reducing store sizes over time and eventually [migrating away from VueX entirely](migrating_from_vuex.md). Before adding any new `Vuex` store to an application, first ensure that the `Vue` application you plan to add it into **does not use** `Apollo`. `Vuex` and `Apollo` should not be combined unless absolutely necessary. Consider reading through [our GraphQL documentation](../fe_guide/graphql.md) for more guidelines on how you can build `Apollo` based applications. The information included in this page is explained in more detail in the official [Vuex documentation](https://vuex.vuejs.org). diff --git a/doc/development/feature_flags/controls.md b/doc/development/feature_flags/controls.md index 69822f0d03d7c45e2f42789039a649c9bd52ffb8..1fffd3c652bbd9dbc98f635d62569f3f18f78a6f 100644 --- a/doc/development/feature_flags/controls.md +++ b/doc/development/feature_flags/controls.md @@ -42,7 +42,7 @@ The GitLab feature library (using [Feature flags process](https://about.gitlab.com/handbook/product-development-flow/feature-flag-lifecycle/) guide) supports rolling out changes to a percentage of time to users. This in turn can be controlled using [GitLab ChatOps](../../ci/chatops/index.md). -For an up to date list of feature flag commands please see +For an up to date list of feature flag commands see [the source code](https://gitlab.com/gitlab-com/chatops/blob/master/lib/chatops/commands/feature.rb). Note that all the examples in that file must be preceded by `/chatops run`. @@ -104,7 +104,7 @@ Guidelines: - Consider notifying `#support_gitlab-com` beforehand. So in case if the feature has any side effects on user experience, they can mitigate and disable the feature flag to reduce some impact. - If the feature meets the requirements for creating a [Change Management](https://about.gitlab.com/handbook/engineering/infrastructure/change-management/#feature-flags-and-the-change-management-process) issue, create a Change Management issue per [criticality guidelines](https://about.gitlab.com/handbook/engineering/infrastructure/change-management/#change-request-workflows). - For simple, low-risk, easily reverted features, proceed and [enable the feature in `#production`](#process). -- For support requests to toggle feature flags for specific groups or projects, please follow the process outlined in the [support workflows](https://about.gitlab.com/handbook/support/workflows/saas_feature_flags.html). +- For support requests to toggle feature flags for specific groups or projects, follow the process outlined in the [support workflows](https://about.gitlab.com/handbook/support/workflows/saas_feature_flags.html). #### Guideline for which percentages to choose during the rollout @@ -203,7 +203,7 @@ Before enabling a feature flag, verify that you are not violating any [Productio The following `/chatops` commands should be performed in the Slack `#production` channel. -When you begin to enable the feature, please link to the relevant +When you begin to enable the feature, link to the relevant feature flag rollout issue within a Slack thread of the first `/chatops` command you make so people can understand the change if they need to. diff --git a/doc/development/feature_flags/index.md b/doc/development/feature_flags/index.md index 3e20eb0ab536e4639b4c0930be811af0b084c1c2..17dd8432f7b457fe809f8e01b0c997d377d5230a 100644 --- a/doc/development/feature_flags/index.md +++ b/doc/development/feature_flags/index.md @@ -19,7 +19,7 @@ All newly-introduced feature flags should be [used with an actor](controls.md#pe This document is the subject of continued work as part of an epic to [improve internal usage of feature flags](https://gitlab.com/groups/gitlab-org/-/epics/3551). Raise any suggestions as new issues and attach them to the epic. -For an [overview of the feature flag lifecycle](https://about.gitlab.com/handbook/product-development-flow/feature-flag-lifecycle/#feature-flag-lifecycle), or if you need help deciding [if you should use a feature flag](https://about.gitlab.com/handbook/product-development-flow/feature-flag-lifecycle/#when-to-use-feature-flags) or not, please see the [feature flag lifecycle](https://about.gitlab.com/handbook/product-development-flow/feature-flag-lifecycle/) handbook page. +For an [overview of the feature flag lifecycle](https://about.gitlab.com/handbook/product-development-flow/feature-flag-lifecycle/#feature-flag-lifecycle), or if you need help deciding [if you should use a feature flag](https://about.gitlab.com/handbook/product-development-flow/feature-flag-lifecycle/#when-to-use-feature-flags) or not, see the [feature flag lifecycle](https://about.gitlab.com/handbook/product-development-flow/feature-flag-lifecycle/) handbook page. ## When to use feature flags @@ -604,7 +604,7 @@ with the untested code path should be manually tested before deployment to produ When using the testing environment, all feature flags are enabled by default. Flags can be disabled by default in the [`spec/spec_helper.rb` file](https://gitlab.com/gitlab-org/gitlab/-/blob/b61fba42eea2cf5bb1ca64e80c067a07ed5d1921/spec/spec_helper.rb#L274). -Please add a comment inline to explain why the flag needs to be disabled. You can also attach the issue URL for reference if possible. +Add a comment inline to explain why the flag needs to be disabled. You can also attach the issue URL for reference if possible. WARNING: This does not apply to end-to-end (QA) tests, which [do not enable feature flags by default](#end-to-end-qa-tests). There is a different [process for using feature flags in end-to-end tests](../testing_guide/end_to_end/feature_flags.md). diff --git a/doc/development/features_inside_dot_gitlab.md b/doc/development/features_inside_dot_gitlab.md index 889e13494856ca2f1acf1a4a740de06deb89ad3a..1217c2bf59618a528025a6d77a6741e90803aa43 100644 --- a/doc/development/features_inside_dot_gitlab.md +++ b/doc/development/features_inside_dot_gitlab.md @@ -7,7 +7,7 @@ info: Any user with at least the Maintainer role can merge updates to this conte # Features inside the `.gitlab/` directory We have implemented standard features that depend on configuration files in the `.gitlab/` directory. You can find `.gitlab/` in various GitLab repositories. -When implementing new features, please refer to these existing features to avoid conflicts: +When implementing new features, refer to these existing features to avoid conflicts: - [Issue Templates](../user/project/description_templates.md#create-an-issue-template): `.gitlab/issue_templates/`. - [Merge request Templates](../user/project/description_templates.md#create-a-merge-request-template): `.gitlab/merge_request_templates/`. diff --git a/doc/development/file_storage.md b/doc/development/file_storage.md index 6d236b6f1b71f815eaa575994429a54155b96647..550b56af520229716864b6a4bcf79bf85e3c1615 100644 --- a/doc/development/file_storage.md +++ b/doc/development/file_storage.md @@ -8,7 +8,7 @@ info: Any user with at least the Maintainer role can merge updates to this conte We use the [CarrierWave](https://github.com/carrierwaveuploader/carrierwave) gem to handle file upload, store and retrieval. -File uploads should be accelerated by workhorse, for details please refer to [uploads development documentation](uploads/index.md). +File uploads should be accelerated by workhorse, for details refer to [uploads development documentation](uploads/index.md). There are many places where file uploading is used, according to contexts: diff --git a/doc/development/gitaly.md b/doc/development/gitaly.md index 5f82344156c2a2ecffc6770ad301b66115b24484..a391daf8962c5eb43fe6b0d39a8f3c63cdc4317f 100644 --- a/doc/development/gitaly.md +++ b/doc/development/gitaly.md @@ -73,12 +73,12 @@ when Gitaly is called more than 30 times in a single Rails request or Sidekiq ex As a temporary measure, export `GITALY_DISABLE_REQUEST_LIMITS=1` to suppress the error. This disables the n+1 detection in your development environment. -Please raise an issue in the GitLab CE or EE repositories to report the issue. Include the labels ~Gitaly -~performance ~"technical debt". Please ensure that the issue contains the full stack trace and error message of the +Raise an issue in the GitLab CE or EE repositories to report the issue. Include the labels ~Gitaly +~performance ~"technical debt". Ensure that the issue contains the full stack trace and error message of the `TooManyInvocationsError`. Also include any known failing tests if possible. Isolate the source of the n+1 problem. This is usually a loop that results in Gitaly being called for each -element in an array. If you are unable to isolate the problem, please contact a member +element in an array. If you are unable to isolate the problem, contact a member of the [Gitaly Team](https://gitlab.com/groups/gl-gitaly/group_members) for assistance. After the source has been found, wrap it in an `allow_n_plus_1_calls` block, as follows: diff --git a/doc/development/gitpod_internals.md b/doc/development/gitpod_internals.md index 90d808e87c5eeeca90414032ca4f8a94ca2e0379..33e18dc2133ec01e27e7a7d536c8b4216ad5c7e4 100644 --- a/doc/development/gitpod_internals.md +++ b/doc/development/gitpod_internals.md @@ -19,7 +19,7 @@ The current settings are: A webhook that starts with `https://gitpod.io/` is created to enable prebuilds (see [Enabling Prebuilds](https://www.gitpod.io/docs/configure/authentication/gitlab#enabling-prebuilds) for more details). The webhook is maintained by an [Engineering Productivity team](https://about.gitlab.com/handbook/engineering/quality/engineering-productivity/). -You can find this webhook in [Webhook Settings in `gitlab-org/gitlab`](https://gitlab.com/gitlab-org/gitlab/-/hooks). If you cannot access this setting, please chat to the [Engineering Productivity team](https://about.gitlab.com/handbook/engineering/quality/engineering-productivity/). +You can find this webhook in [Webhook Settings in `gitlab-org/gitlab`](https://gitlab.com/gitlab-org/gitlab/-/hooks). If you cannot access this setting, chat to the [Engineering Productivity team](https://about.gitlab.com/handbook/engineering/quality/engineering-productivity/). ### Troubleshooting a failed webhook diff --git a/doc/development/go_guide/index.md b/doc/development/go_guide/index.md index 97f863082a24fe21205dcc7a73eabbb2417d3256..a9f4b22c778b012d8441f5dcf13fff7a5e7c131d 100644 --- a/doc/development/go_guide/index.md +++ b/doc/development/go_guide/index.md @@ -26,7 +26,7 @@ can still have specifics. They are described in their respective The Go upgrade documentation [provides an overview](go_upgrade.md#overview) of how GitLab manages and ships Go binary support. -If a GitLab component requires a newer version of Go, please +If a GitLab component requires a newer version of Go, follow the [upgrade process](go_upgrade.md#updating-go-version) to ensure no customer, team, or component is adversely impacted. Sometimes, individual projects must also [manage builds with multiple versions of Go](go_upgrade.md#supporting-multiple-go-versions). diff --git a/doc/development/gotchas.md b/doc/development/gotchas.md index 6864676a71937b0eed3400c54d6a66f69afa1997..0f872bfff01fb0d83ed31c9a19aa49758ca26084 100644 --- a/doc/development/gotchas.md +++ b/doc/development/gotchas.md @@ -76,7 +76,7 @@ When run, this spec doesn't do what we might expect: This is because FactoryBot sequences are not reset for each example. -Please remember that sequence-generated values exist only to avoid having to +Remember that sequence-generated values exist only to avoid having to explicitly set attributes that have a uniqueness constraint when using a factory. ### Solution diff --git a/doc/development/i18n/translation.md b/doc/development/i18n/translation.md index 63c325cfaa0ddf038556cc6ca7fb6f8fb881879f..7149d431c308e5dfdbdb3731f7a8af4cd0a8de33 100644 --- a/doc/development/i18n/translation.md +++ b/doc/development/i18n/translation.md @@ -96,7 +96,7 @@ For example, in German, the word _user_ can be translated into _Benutzer_ (male) ### Updating the glossary -To propose additions to the glossary, please +To propose additions to the glossary, [open an issue](https://gitlab.com/gitlab-org/gitlab/-/issues?scope=all&utf8=✓&state=all&label_name[]=Category%3AInternationalization). ## French translation guidelines diff --git a/doc/development/import_export.md b/doc/development/import_export.md index 55db6a3ca3b7f5d729da4192c51243b6c8345896..909c31c1b629e9081f9bce1973920165eb38a5a0 100644 --- a/doc/development/import_export.md +++ b/doc/development/import_export.md @@ -288,13 +288,13 @@ Fixtures used in Import/Export specs live in `spec/fixtures/lib/gitlab/import_ex There are two versions of each of these fixtures: - A human readable single JSON file with all objects, called either `project.json` or `group.json`. -- A folder named `tree`, containing a tree of files in `ndjson` format. **Please do not edit files under this folder manually unless strictly necessary.** +- A folder named `tree`, containing a tree of files in `ndjson` format. **Do not edit files under this folder manually unless strictly necessary.** The tools to generate the NDJSON tree from the human-readable JSON files live in the [`gitlab-org/memory-team/team-tools`](https://gitlab.com/gitlab-org/memory-team/team-tools/-/blob/master/import-export/) project. ### Project -**Please use `legacy-project-json-to-ndjson.sh` to generate the NDJSON tree.** +**Use `legacy-project-json-to-ndjson.sh` to generate the NDJSON tree.** The NDJSON tree looks like: @@ -328,7 +328,7 @@ tree ### Group -**Please use `legacy-group-json-to-ndjson.rb` to generate the NDJSON tree.** +**Use `legacy-group-json-to-ndjson.rb` to generate the NDJSON tree.** The NDJSON tree looks like this: @@ -355,4 +355,4 @@ tree ``` WARNING: -When updating these fixtures, please ensure you update both `json` files and `tree` folder, as the tests apply to both. +When updating these fixtures, ensure you update both `json` files and `tree` folder, as the tests apply to both. diff --git a/doc/development/integrations/secure_partner_integration.md b/doc/development/integrations/secure_partner_integration.md index 082168fcfdce0475f28a4b0f6c4b2a089df0b782..53c333a6f136f6aaf218784ce7e7b5619d67deec 100644 --- a/doc/development/integrations/secure_partner_integration.md +++ b/doc/development/integrations/secure_partner_integration.md @@ -104,7 +104,7 @@ and complete an integration with the Secure stage. - If you specified `remediations` in your artifact, it is proposed through our [remediation](../../user/application_security/vulnerabilities/index.md#resolve-a-vulnerability) interface. 1. Demo the integration to GitLab: - - After you have tested and are ready to demo your integration please + - After you have tested and are ready to demo your integration, [reach out](https://about.gitlab.com/partners/technology-partners/integrate/) to us. If you skip this step you won't be able to do supported marketing. 1. Begin doing supported marketing of your GitLab integration. @@ -119,4 +119,4 @@ that may be helpful as part of this process. This covers various topics related tool. If you have any issues while working through your integration or the steps -above, please create an issue to discuss with us further. +above, create an issue to discuss with us further. diff --git a/doc/development/internal_analytics/internal_event_instrumentation/migration.md b/doc/development/internal_analytics/internal_event_instrumentation/migration.md index f0e39b148ec6b9a0fdb99fcc1d2aa2680323816b..32a68011e5a6c42ebfa828dbfd45299b37aaea8a 100644 --- a/doc/development/internal_analytics/internal_event_instrumentation/migration.md +++ b/doc/development/internal_analytics/internal_event_instrumentation/migration.md @@ -23,7 +23,7 @@ The event triggered by Internal Events has some special properties compared to p 1. The `label`, `property` and `value` attributes are not used within Internal Events and are always empty. 1. The `category` is automatically set to `InternalEventTracking` -Please make sure that you are okay with this change before you migrate and dashboards are changed accordingly. +Make sure that you are okay with this change before you migrate and dashboards are changed accordingly. ### Backend diff --git a/doc/development/internal_analytics/internal_event_instrumentation/quick_start.md b/doc/development/internal_analytics/internal_event_instrumentation/quick_start.md index c5388754babab3af9121fad25ce7f257345c54dd..34be2080e9537650d771df3260a80fb574c4ee91 100644 --- a/doc/development/internal_analytics/internal_event_instrumentation/quick_start.md +++ b/doc/development/internal_analytics/internal_event_instrumentation/quick_start.md @@ -44,7 +44,7 @@ Where: ## Trigger events -Triggering an event and thereby updating a metric is slightly different on backend and frontend. Please refer to the relevant section below. +Triggering an event and thereby updating a metric is slightly different on backend and frontend. Refer to the relevant section below. ### Backend tracking @@ -71,7 +71,7 @@ If a `project` but no `namespace` is provided, the `project.namespace` is used a Any frontend tracking call automatically passes the values `user.id`, `namespace.id`, and `project.id` from the current context of the page. -If you need to pass any further properties, such as `extra`, `context`, `label`, `property`, and `value`, you can use the [deprecated snowplow implementation](https://docs.gitlab.com/16.4/ee/development/internal_analytics/snowplow/implementation.html). In this case, please let us know about your specific use-case in our [feedback issue for Internal Events](https://gitlab.com/gitlab-org/analytics-section/analytics-instrumentation/internal/-/issues/690). +If you need to pass any further properties, such as `extra`, `context`, `label`, `property`, and `value`, you can use the [deprecated snowplow implementation](https://docs.gitlab.com/16.4/ee/development/internal_analytics/snowplow/implementation.html). In this case, let us know about your specific use-case in our [feedback issue for Internal Events](https://gitlab.com/gitlab-org/analytics-section/analytics-instrumentation/internal/-/issues/690). #### Vue components diff --git a/doc/development/internal_analytics/metrics/metrics_lifecycle.md b/doc/development/internal_analytics/metrics/metrics_lifecycle.md index cb734901c2eeb1e00a60c8046b2189de6979b4d6..681992b43797f361bda4ac88d5d7df6536ecd6bf 100644 --- a/doc/development/internal_analytics/metrics/metrics_lifecycle.md +++ b/doc/development/internal_analytics/metrics/metrics_lifecycle.md @@ -24,7 +24,7 @@ As a result, if you need to change one of the following parts of a metric, you n - **calculation logic**: This means any changes that can produce a different value than the previous implementation - **YAML attributes**: The following attributes are directly used for analysis or calculation: `key_path`, `time_frame`, `value_type`, `data_source`. -If you change the `performance_indicator_type` attribute of a metric or think your case needs an exception from the outlined rules then please notify the Customer Success Ops team (`@csops-team`), Analytics Engineers (`@gitlab-data/analytics-engineers`), and Product Analysts (`@gitlab-data/product-analysts`) teams by `@` mentioning those groups in a comment on the merge request or issue. +If you change the `performance_indicator_type` attribute of a metric or think your case needs an exception from the outlined rules then notify the Customer Success Ops team (`@csops-team`), Analytics Engineers (`@gitlab-data/analytics-engineers`), and Product Analysts (`@gitlab-data/product-analysts`) teams by `@` mentioning those groups in a comment on the merge request or issue. You can change any other attributes without impact to the calculation or analysis. See [this video tutorial](https://youtu.be/bYf3c01KCls) for help updating metric attributes. @@ -91,7 +91,7 @@ To remove a metric: therefore continue to report the removed metric. The Analytics Instrumentation team requires a record of all removed metrics to identify and filter them. - For example please take a look at this [merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/60149/diffs#b01f429a54843feb22265100c0e4fec1b7da1240_10_10). + For example, take a look at this [merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/60149/diffs#b01f429a54843feb22265100c0e4fec1b7da1240_10_10). 1. After you verify the metric can be safely removed, remove the metric's instrumentation from @@ -99,7 +99,7 @@ To remove a metric: or [`ee/lib/ee/gitlab/usage_data.rb`](https://gitlab.com/gitlab-org/gitlab/-/blob/master/ee/lib/ee/gitlab/usage_data.rb). - For example please take a look at this [merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/60149/diffs#6335dc533bd21df26db9de90a02dd66278c2390d_167_167). + For example, take a look at this [merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/60149/diffs#6335dc533bd21df26db9de90a02dd66278c2390d_167_167). 1. Remove any other records related to the metric: - The feature flag YAML file at [`config/feature_flags/*/*.yaml`](https://gitlab.com/gitlab-org/gitlab/-/tree/master/config/feature_flags). diff --git a/doc/development/labels/index.md b/doc/development/labels/index.md index 90253d101d4f7d56522c37a90b20deccc1aedb0c..4288408baf6b423218208c91a33697650f76aa94 100644 --- a/doc/development/labels/index.md +++ b/doc/development/labels/index.md @@ -24,9 +24,9 @@ Most issues will have labels for at least one of the following: - Priority: `~"priority::1"`, `~"priority::2"`, `~"priority::3"`, `~"priority::4"` - Severity: `~"severity::1"`, `~"severity::2"`, `~"severity::3"`, `~"severity::4"` -Please add `~"breaking change"` label if the issue can be considered as a [breaking change](../deprecation_guidelines/index.md). +Add `~"breaking change"` label if the issue can be considered as a [breaking change](../deprecation_guidelines/index.md). -Please add `~security` label if the issue is related to application security. +Add `~security` label if the issue is related to application security. All labels, their meaning and priority are defined on the [labels page](https://gitlab.com/gitlab-org/gitlab/-/labels). @@ -252,7 +252,7 @@ We have the following priority labels: - `~"priority::3"` - `~"priority::4"` -Please refer to the issue triage [priority label](https://about.gitlab.com/handbook/engineering/quality/issue-triage/#priority) section in our handbook to see how it's used. +Refer to the issue triage [priority label](https://about.gitlab.com/handbook/engineering/quality/issue-triage/#priority) section in our handbook to see how it's used. ## Severity labels @@ -263,7 +263,7 @@ We have the following severity labels: - `~"severity::3"` - `~"severity::4"` -Please refer to the issue triage [severity label](https://about.gitlab.com/handbook/engineering/quality/issue-triage/#severity) section in our handbook to see how it's used. +Refer to the issue triage [severity label](https://about.gitlab.com/handbook/engineering/quality/issue-triage/#severity) section in our handbook to see how it's used. ## Label for community contributors @@ -301,7 +301,7 @@ with the [label `~"Community Challenge"`](https://gitlab.com/gitlab-org/gitlab/- If your MR for the `~"Community Challenge"` issue gets merged, you will also have a chance to win a custom GitLab merchandise. -If you've decided that you would like to work on an issue, please @-mention +If you've decided that you would like to work on an issue, @-mention the [appropriate product manager](https://about.gitlab.com/handbook/product/#who-to-talk-to-for-what) as soon as possible. The product manager will then pull in appropriate GitLab team members to further discuss scope, design, and technical considerations. This will diff --git a/doc/development/licensing.md b/doc/development/licensing.md index 2c11756acbcda6b0ffb36b3c8301f8df9e699d2c..c84f42270c3b84b2204218affdb23bae73934e7e 100644 --- a/doc/development/licensing.md +++ b/doc/development/licensing.md @@ -44,7 +44,7 @@ To tell License Finder about a dependency's license if it isn't auto-detected: license_finder licenses add my_unknown_dependency MIT ``` -For all of the above, please include `--why "Reason"` and `--who "My Name"` so the `decisions.yml` file can keep track of when, why, and who approved of a dependency. +For all of the above, include `--why "Reason"` and `--who "My Name"` so the `decisions.yml` file can keep track of when, why, and who approved of a dependency. More detailed information on how the gem and its commands work is available in the [License Finder README](https://github.com/pivotal/LicenseFinder). @@ -77,4 +77,4 @@ Those projects are set to use a test license encryption key by default. ## Additional information -Please see the [Open Source](https://about.gitlab.com/handbook/engineering/open-source/#using-open-source-libraries) page for more information on licensing. +See the [Open Source](https://about.gitlab.com/handbook/engineering/open-source/#using-open-source-libraries) page for more information on licensing. diff --git a/doc/development/logging.md b/doc/development/logging.md index 123c5c46f9210b64ce5f25fc63ed83627decbcef..2af914d76eff959340d459ff359064b78cea31ac 100644 --- a/doc/development/logging.md +++ b/doc/development/logging.md @@ -361,7 +361,7 @@ class MyExampleWorker end ``` -Please see [this example](https://gitlab.com/gitlab-org/gitlab/-/blob/16ecc33341a3f6b6bebdf78d863c5bce76b040d3/app/workers/ci/pipeline_artifacts/expire_artifacts_worker.rb#L20-21) +See [this example](https://gitlab.com/gitlab-org/gitlab/-/blob/16ecc33341a3f6b6bebdf78d863c5bce76b040d3/app/workers/ci/pipeline_artifacts/expire_artifacts_worker.rb#L20-21) which logs a count of how many artifacts are destroyed per run of the `ExpireArtifactsWorker`. ## Exception Handling diff --git a/doc/development/merge_request_concepts/performance.md b/doc/development/merge_request_concepts/performance.md index 548bd6e1e5588177307c15f9a849b06d3071149f..7a1e33494d0543ed62d6d4e147ca8f4cfdbfe013 100644 --- a/doc/development/merge_request_concepts/performance.md +++ b/doc/development/merge_request_concepts/performance.md @@ -286,7 +286,7 @@ be clearly mentioned in the merge request description. **Summary:** Iterating a single process to external services (for example, PostgreSQL, Redis, Object Storage) should be executed in a **batch-style** to reduce connection overheads. -For fetching rows from various tables in a batch-style, please see [Eager Loading](#eager-loading) section. +For fetching rows from various tables in a batch-style, see [Eager Loading](#eager-loading) section. ### Example: Delete multiple files from Object Storage @@ -323,7 +323,7 @@ Using [`ReactiveCaching`](../utilities.md#reactivecaching) is one of the best so transactions, otherwise it leads to severe contention problems as an open transaction basically blocks the release of a PostgreSQL backend connection. -For keeping transaction as minimal as possible, please consider using `AfterCommitQueue` +For keeping transaction as minimal as possible, consider using `AfterCommitQueue` module or `after_commit` AR hook. Here is [an example](https://gitlab.com/gitlab-org/gitlab/-/issues/36154#note_247228859) diff --git a/doc/development/migration_style_guide.md b/doc/development/migration_style_guide.md index 25d48632bd6565b92dd6ddefb9609eaffc135e4b..30f598ef7363edc552b33904427a83cd90a1b2ae 100644 --- a/doc/development/migration_style_guide.md +++ b/doc/development/migration_style_guide.md @@ -27,7 +27,7 @@ When writing your migrations, also consider that databases might have stale data or inconsistencies and guard for that. Try to make as few assumptions as possible about the state of the database. -Please don't depend on GitLab-specific code since it can change in future +Don't depend on GitLab-specific code since it can change in future versions. If needed copy-paste GitLab code into the migration to make it forward compatible. @@ -140,7 +140,7 @@ Changes to the schema should be committed to `db/structure.sql`. This file is automatically generated by Rails when you run `bundle exec rails db:migrate`, so you typically should not edit this file by hand. If your migration is adding a column to a -table, that column is added at the bottom. Please do not reorder +table, that column is added at the bottom. Do not reorder columns manually for existing tables as this causes confusion to other people using `db/structure.sql` generated by Rails. @@ -1025,7 +1025,7 @@ steps in the [database dictionary guide](database/database_dictionary.md#droppin Dropping a database table is uncommon, and the `drop_table` method provided by Rails is generally considered safe. Before dropping the table, -please consider the following: +consider the following: If your table has foreign keys on a [high-traffic table](#high-traffic-tables) (like `projects`), then the `DROP TABLE` statement is likely to stall concurrent traffic until it fails with **statement timeout** error. @@ -1370,7 +1370,7 @@ See the [Testing Rails migrations](testing_guide/testing_migrations_guide.md) st ## Data migration -Please prefer Arel and plain SQL over usual ActiveRecord syntax. In case of +Prefer Arel and plain SQL over usual ActiveRecord syntax. In case of using plain SQL, you need to quote all input manually with `quote_string` helper. Example with Arel: diff --git a/doc/development/multi_version_compatibility.md b/doc/development/multi_version_compatibility.md index 4f1fc1b0f104f56cefc389da1cb63ce02d171dc3..40a30aa4926c16dfbcb133fbe3abeab0cd141185 100644 --- a/doc/development/multi_version_compatibility.md +++ b/doc/development/multi_version_compatibility.md @@ -243,7 +243,7 @@ With all those details in mind, let's imagine we need to replace a query, and th 1. **contract**: from `Schema B` to `Schema C` (post-deployment migration). Nothing uses the old index anymore, we can safely remove it. This is only an example. More complex migrations, especially when background migrations are needed may -require more than one milestone. For details please refer to our [migration style guide](migration_style_guide.md). +require more than one milestone. For details refer to our [migration style guide](migration_style_guide.md). ## Examples of previous incidents diff --git a/doc/development/pipelines/index.md b/doc/development/pipelines/index.md index c7b6470f9b0f65d7e4dbf03c294f5fdd9735c41b..c4dfda9466a3e322a31c43ade91e72a266d67315 100644 --- a/doc/development/pipelines/index.md +++ b/doc/development/pipelines/index.md @@ -105,7 +105,7 @@ In addition, there are a few circumstances where we would always run the full RS #### Have you encountered a problem with backend predictive tests? -If so, please have a look at [the Engineering Productivity RUNBOOK on predictive tests](https://gitlab.com/gitlab-org/quality/engineering-productivity/team/-/blob/main/runbooks/predictive-tests.md) for instructions on how to act upon predictive tests issues. Additionally, if you identified any test selection gaps, please let `@gl-quality/eng-prod` know so that we can take the necessary steps to optimize test selections. +If so, have a look at [the Engineering Productivity RUNBOOK on predictive tests](https://gitlab.com/gitlab-org/quality/engineering-productivity/team/-/blob/main/runbooks/predictive-tests.md) for instructions on how to act upon predictive tests issues. Additionally, if you identified any test selection gaps, let `@gl-quality/eng-prod` know so that we can take the necessary steps to optimize test selections. ### Jest predictive jobs @@ -130,7 +130,7 @@ The `rules` definitions for full Jest tests are defined at `.frontend:rules:jest #### Have you encountered a problem with frontend predictive tests? -If so, please have a look at [the Engineering Productivity RUNBOOK on predictive tests](https://gitlab.com/gitlab-org/quality/engineering-productivity/team/-/blob/main/runbooks/predictive-tests.md) for instructions on how to act upon predictive tests issues. +If so, have a look at [the Engineering Productivity RUNBOOK on predictive tests](https://gitlab.com/gitlab-org/quality/engineering-productivity/team/-/blob/main/runbooks/predictive-tests.md) for instructions on how to act upon predictive tests issues. ### Fork pipelines @@ -302,7 +302,7 @@ The intent is to ensure that a change doesn't introduce a failure after `gitlab- #### What it is This pipeline is also called [JiHu validation pipeline](https://about.gitlab.com/handbook/ceo/chief-of-staff-team/jihu-support/jihu-validation-pipelines.html), -and it's currently allowed to fail. When that happens, please follow +and it's currently allowed to fail. When that happens, follow [What to do when the validation pipeline fails](https://about.gitlab.com/handbook/ceo/chief-of-staff-team/jihu-support/jihu-validation-pipelines.html#what-to-do-when-the-validation-pipeline-failed). #### How we run it diff --git a/doc/development/project_templates.md b/doc/development/project_templates.md index d3114e7b2b6327032b0b63794d7ccbd1020aadc9..7200927858ccb4fc08e16f41a968f2c957cc52c6 100644 --- a/doc/development/project_templates.md +++ b/doc/development/project_templates.md @@ -8,11 +8,11 @@ info: "To determine the technical writer assigned to the Stage/Group associated ## Adding a new built-in project template -If you'd like to contribute a new built-in project template to be distributed with GitLab, please do the following: +If you'd like to contribute a new built-in project template to be distributed with GitLab, do the following: 1. Create a new public project with the project content you'd like to contribute in a namespace of your choosing. You can view a working example [here](https://gitlab.com/gitlab-org/project-templates/dotnetcore). - Projects should be as simple as possible and free of any unnecessary assets or dependencies. -1. When the project is ready for review, please create a new issue in [GitLab](https://gitlab.com/gitlab-org/gitlab/issues) with a link to your project. +1. When the project is ready for review, create a new issue in [GitLab](https://gitlab.com/gitlab-org/gitlab/issues) with a link to your project. - In your issue, `@` mention the relevant Backend Engineering Manager and Product Manager for the [Create:Source Code group](https://about.gitlab.com/handbook/product/categories/#source-code-group). To make the project template available when creating a new project, the vendoring process will have to be completed: @@ -59,7 +59,7 @@ To make the project template available when creating a new project, the vendorin Existing templates are available in the [project-templates](https://gitlab.com/gitlab-org/project-templates) group. -To contribute a change, please open a merge request in the relevant project +To contribute a change, open a merge request in the relevant project and mention `@gitlab-org/manage/import/backend` when you are ready for a review. Then, if your merge request gets accepted, either open an issue on @@ -79,7 +79,7 @@ Complete the following steps to test the project template in your own GitLab Dev ## For GitLab team members -Please ensure the merge request has been reviewed by the Security Counterpart before merging. +Ensure the merge request has been reviewed by the Security Counterpart before merging. To review a merge request which changes a vendored project template, run the `check-template-changes` script: diff --git a/doc/development/rails_endpoints/index.md b/doc/development/rails_endpoints/index.md index 5442e0313ac02d1f2b90b64e28d8ae8bc16ecff6..adc17fde1d0424fe75eb7b367f58d06eafd6e036 100644 --- a/doc/development/rails_endpoints/index.md +++ b/doc/development/rails_endpoints/index.md @@ -19,7 +19,7 @@ These Rails Endpoints: ## Proof of concept period: Feedback Request -We are currently evaluating a new approach for documenting Rails endpoints. Please [check out the Feedback Issue](https://gitlab.com/gitlab-org/gitlab/-/issues/411605) and feel free to share your thoughts, suggestions, or concerns. We appreciate your participation in helping us improve the documentation! +We are currently evaluating a new approach for documenting Rails endpoints. [Check out the Feedback Issue](https://gitlab.com/gitlab-org/gitlab/-/issues/411605) and feel free to share your thoughts, suggestions, or concerns. We appreciate your participation in helping us improve the documentation! ## SAST Scanners diff --git a/doc/development/ruby3_gotchas.md b/doc/development/ruby3_gotchas.md index 16ca804e6d6665be388167bb6cef4cafeb3c5973..d32f71948d78fa642a2667b89a84428249cfc0da 100644 --- a/doc/development/ruby3_gotchas.md +++ b/doc/development/ruby3_gotchas.md @@ -150,7 +150,7 @@ We run automated detection for this warning in tests via `deprecation_toolkit`, but it relies on the fact that `Kernel#warn` emits a warning, so stubbing out this call will effectively remove the call to warn, which means `deprecation_toolkit` will never see the deprecation warnings. Stubbing out the implementation removes that warning, and we never pick it up, so the build is green. -Please refer to [issue 364099](https://gitlab.com/gitlab-org/gitlab/-/issues/364099) for more context. +Refer to [issue 364099](https://gitlab.com/gitlab-org/gitlab/-/issues/364099) for more context. ## Testing in `irb` and `rails console` diff --git a/doc/development/search/advanced_search_migration_styleguide.md b/doc/development/search/advanced_search_migration_styleguide.md index e02ae7372fe1f0fcdeb0d00b242d09a0ace9720b..0ad3b5dc7c9d999005a8730eb99b56fba887bf4f 100644 --- a/doc/development/search/advanced_search_migration_styleguide.md +++ b/doc/development/search/advanced_search_migration_styleguide.md @@ -425,7 +425,7 @@ being upgraded to, we do the following: ### Process for removing migrations 1. Select migrations that were marked as obsolete before the current major release -1. If the step above includes all obsolete migrations, please keep one last migration as a safeguard for customers with unapplied migrations +1. If the step above includes all obsolete migrations, keep one last migration as a safeguard for customers with unapplied migrations 1. Delete migration files and spec files for those migrations 1. Verify that there are no references of the migrations in the `.rubocop_todo/` directory. 1. Create a merge request and assign it to a team member from the global search team. diff --git a/doc/development/sec/analyzer_development_guide.md b/doc/development/sec/analyzer_development_guide.md index 956c7b464aa3fe6ab98d89af1119e331194862d3..eb59d8fcaf5564a19603978d848c188f6b1edee2 100644 --- a/doc/development/sec/analyzer_development_guide.md +++ b/doc/development/sec/analyzer_development_guide.md @@ -226,7 +226,7 @@ After the above steps have been completed, the automatic release process execute ### Steps to perform after releasing an analyzer -1. After a new version of the analyzer Docker image has been tagged and deployed, please test it with the corresponding test project. +1. After a new version of the analyzer Docker image has been tagged and deployed, test it with the corresponding test project. 1. Announce the release on the relevant group Slack channel. Example message: > FYI I've just released `ANALYZER_NAME` `ANALYZER_VERSION`. `LINK_TO_RELEASE` diff --git a/doc/development/sec/index.md b/doc/development/sec/index.md index 5deb153fe9b64ecbbdabb4e68872be0801050509..9e8486b26fa6675beba8f1ce615b196a1053ad97 100644 --- a/doc/development/sec/index.md +++ b/doc/development/sec/index.md @@ -71,7 +71,7 @@ For details on how GitLab processes the reports generated by the scanners, see ## CI/CD template development While CI/CD templates are the responsibility of the Verify section, many are critical to the Sec Section's feature usage. -If you are working with CI/CD templates, please read the [development guide for GitLab CI/CD templates](../cicd/templates.md). +If you are working with CI/CD templates, read the [development guide for GitLab CI/CD templates](../cicd/templates.md). ## Importance of the primary identifier diff --git a/doc/development/secure_coding_guidelines.md b/doc/development/secure_coding_guidelines.md index c68a1a6bcab9dab55d879827568e23aba3da239b..a575d1ff890f0de5a08e3200fec1da7f7889f421 100644 --- a/doc/development/secure_coding_guidelines.md +++ b/doc/development/secure_coding_guidelines.md @@ -14,17 +14,16 @@ goal of reducing the number of vulnerabilities released over time. **Contributing** If you would like to contribute to one of the existing documents, or add -guidelines for a new vulnerability type, please open an MR! Please try to +guidelines for a new vulnerability type, open an MR! Try to include links to examples of the vulnerability found, and link to any resources -used in defined mitigations. If you have questions or when ready for a review, -please ping `gitlab-com/gl-security/appsec`. +used in defined mitigations. If you have questions or when ready for a review, ping `gitlab-com/gl-security/appsec`. ## Permissions ### Description Application permissions are used to determine who can access what and what actions they can perform. -For more information about the permission model at GitLab, please see [the GitLab permissions guide](permissions.md) or the [EE docs on permissions](../../ee/user/permissions.md). +For more information about the permission model at GitLab, see [the GitLab permissions guide](permissions.md) or the [EE docs on permissions](../../ee/user/permissions.md). ### Impact @@ -340,7 +339,7 @@ The injected client-side code is executed on the victim's browser in the context - potentially <i class="fa fa-youtube-play youtube" aria-hidden="true"></i> [obtain the victim's session tokens](https://youtu.be/2VFavqfDS6w?t=739) - perform actions that lead to data loss/theft or account takeover -Much of the impact is contingent upon the function of the application and the capabilities of the victim's session. For further impact possibilities, please check out [the beef project](https://beefproject.com/). +Much of the impact is contingent upon the function of the application and the capabilities of the victim's session. For further impact possibilities, check out [the beef project](https://beefproject.com/). For a demonstration of the impact on GitLab with a realistic attack scenario, see [this video on the GitLab Unfiltered channel](https://www.youtube.com/watch?v=t4PzHNycoKo) (internal, it requires being logged in with the GitLab Unfiltered account). diff --git a/doc/development/sidekiq/idempotent_jobs.md b/doc/development/sidekiq/idempotent_jobs.md index 30e41884870a9142438d9df2ceb0102ffaae4775..029b18adb46518f4939f6bdc278a24ef30159fab 100644 --- a/doc/development/sidekiq/idempotent_jobs.md +++ b/doc/development/sidekiq/idempotent_jobs.md @@ -80,7 +80,7 @@ GitLab supports two deduplication strategies: More [deduplication strategies have been suggested](https://gitlab.com/gitlab-com/gl-infra/scalability/-/issues/195). If you are implementing a worker that could benefit from a different -strategy, please comment in the issue. +strategy, comment in the issue. #### Until Executing diff --git a/doc/development/sql.md b/doc/development/sql.md index e62500e44b68cd46e1bf6b8a04e8edc2f29bb809..86892f86e0c80a2ca37b8309f15647a054a832bc 100644 --- a/doc/development/sql.md +++ b/doc/development/sql.md @@ -86,7 +86,7 @@ _can_ be used by `ILIKE` / `LIKE` and can lead to greatly improved performance. One downside of these indexes is that they can easily get quite large (depending on the amount of data indexed). -To keep naming of these indexes consistent please use the following naming +To keep naming of these indexes consistent, use the following naming pattern: ```plaintext diff --git a/doc/development/testing_guide/best_practices.md b/doc/development/testing_guide/best_practices.md index e6155fa36bff261555175f8afa266235aa829238..458a5efea4237b45f822fc8374daf1e8de765c91 100644 --- a/doc/development/testing_guide/best_practices.md +++ b/doc/development/testing_guide/best_practices.md @@ -385,7 +385,7 @@ NOTE: `stub_method` does not support method existence and method arity checks. WARNING: -`stub_method` is supposed to be used in factories only. It's strongly discouraged to be used elsewhere. Please consider using [RSpec mocks](https://rspec.info/features/3-12/rspec-mocks/) if available. +`stub_method` is supposed to be used in factories only. It's strongly discouraged to be used elsewhere. Consider using [RSpec mocks](https://rspec.info/features/3-12/rspec-mocks/) if available. #### Stubbing member access level @@ -582,7 +582,7 @@ Use the coverage reports to ensure your tests cover 100% of your code. NOTE: Before writing a new system test, -[please consider **not** writing one](testing_levels.md#consider-not-writing-a-system-test)! +[consider **not** writing one](testing_levels.md#consider-not-writing-a-system-test)! - Feature specs should be named `ROLE_ACTION_spec.rb`, such as `user_changes_password_spec.rb`. diff --git a/doc/development/testing_guide/end_to_end/best_practices.md b/doc/development/testing_guide/end_to_end/best_practices.md index 71d607f6f052460cf6b5efe8d30222869609ad94..cd92f8656e95ac52d1e229bee0bd9d4e2703589c 100644 --- a/doc/development/testing_guide/end_to_end/best_practices.md +++ b/doc/development/testing_guide/end_to_end/best_practices.md @@ -361,7 +361,7 @@ When you add a new test that requires administrator access, apply the RSpec meta When running tests locally or configuring a pipeline, the environment variable `QA_CAN_TEST_ADMIN_FEATURES` can be set to `false` to skip tests that have the `:requires_admin` tag. NOTE: -If the _only_ action in the test that requires administrator access is to toggle a feature flag, please use the `feature_flag` tag instead. More details can be found in [testing with feature flags](feature_flags.md). +If the _only_ action in the test that requires administrator access is to toggle a feature flag, use the `feature_flag` tag instead. More details can be found in [testing with feature flags](feature_flags.md). ## Prefer `Commit` resource over `ProjectPush` diff --git a/doc/development/testing_guide/end_to_end/feature_flags.md b/doc/development/testing_guide/end_to_end/feature_flags.md index 0b1525fb973fe2e91b6537f967a30fc52e60f311..e11119d2c0b050108d6e84fc447727a552fe592b 100644 --- a/doc/development/testing_guide/end_to_end/feature_flags.md +++ b/doc/development/testing_guide/end_to_end/feature_flags.md @@ -16,7 +16,7 @@ and `GITLAB_ADMIN_PASSWORD`. ## `feature_flag` RSpec tag -Please be sure to include the `feature_flag` tag so that the test can be skipped on the appropriate environments. +Be sure to include the `feature_flag` tag so that the test can be skipped on the appropriate environments. **Optional metadata:** @@ -181,7 +181,7 @@ active feature flag. To circumvent this behavior, add a wait for elements behind It's also possible to run an entire scenario with a feature flag enabled, without having to edit existing tests or write new ones. -Please see the [QA README](https://gitlab.com/gitlab-org/gitlab/-/tree/master/qa#running-tests-with-a-feature-flag-enabled) +See the [QA README](https://gitlab.com/gitlab-org/gitlab/-/tree/master/qa#running-tests-with-a-feature-flag-enabled) for details. ## Confirming that end-to-end tests pass with a feature flag enabled @@ -219,4 +219,4 @@ pass on the default branch. The end-to-end tests run on the default branch every If the relevant tests do not enable the feature flag themselves, you can check if the tests will need to be updated by opening a draft merge request that enables the flag by default via a [feature flag definition file](../../feature_flags/index.md#feature-flag-definition-and-validation). That will [automatically execute the end-to-end test suite](#automatic-test-execution-when-a-feature-flag-definition-changes). -The merge request can be closed once the tests pass. If you need assistance to update the tests, please contact the relevant [stable counterpart in the Quality department](https://about.gitlab.com/handbook/engineering/quality/#individual-contributors), or any Software Engineer in Test if there is no stable counterpart for your group. +The merge request can be closed once the tests pass. If you need assistance to update the tests, contact the relevant [stable counterpart in the Quality department](https://about.gitlab.com/handbook/engineering/quality/#individual-contributors), or any Software Engineer in Test if there is no stable counterpart for your group. diff --git a/doc/development/testing_guide/end_to_end/index.md b/doc/development/testing_guide/end_to_end/index.md index 7ab1e588a4066d80e46fda01a6a04177d96caa2d..33465816ec12e12c0a97a4d63468edd79ca28b7f 100644 --- a/doc/development/testing_guide/end_to_end/index.md +++ b/doc/development/testing_guide/end_to_end/index.md @@ -266,7 +266,7 @@ use the [GitLab QA orchestrator](https://gitlab.com/gitlab-org/gitlab-qa/tree/ma On the other hand, if you would like to run against a local development GitLab environment, you can use the [GitLab Development Kit (GDK)](https://gitlab.com/gitlab-org/gitlab-development-kit/). -Please refer to the instructions in the [QA README](https://gitlab.com/gitlab-org/gitlab/-/tree/master/qa/README.md#how-can-i-use-it) +Refer to the instructions in the [QA README](https://gitlab.com/gitlab-org/gitlab/-/tree/master/qa/README.md#how-can-i-use-it) and the section below. ### Running tests that require special setup diff --git a/doc/development/testing_guide/end_to_end/page_objects.md b/doc/development/testing_guide/end_to_end/page_objects.md index 6e05bb972f8d0044162cdb8abb1ce3cd41dea99c..812d2724b721bfc88e3ea16d4fb02b6d51a23725 100644 --- a/doc/development/testing_guide/end_to_end/page_objects.md +++ b/doc/development/testing_guide/end_to_end/page_objects.md @@ -306,5 +306,5 @@ from within the `qa` directory. If you need more information, ask for help on `#test-platform` channel on Slack (internal, GitLab Team only). -If you are not a Team Member, and you still need help to contribute, please +If you are not a Team Member, and you still need help to contribute, open an issue in GitLab CE issue tracker with the `~QA` label. diff --git a/doc/development/testing_guide/end_to_end/resources.md b/doc/development/testing_guide/end_to_end/resources.md index 2b5d6fcf855aa49434a4216399bb7f0f9b2645be..7ff44f8cddbdbe1c0eba8aacbf4e33aa6e7abc9b 100644 --- a/doc/development/testing_guide/end_to_end/resources.md +++ b/doc/development/testing_guide/end_to_end/resources.md @@ -494,7 +494,7 @@ We have a mechanism to [collect](https://gitlab.com/gitlab-org/gitlab/-/blob/443 all resources created during test executions, and another to [handle](https://gitlab.com/gitlab-org/gitlab/-/blob/44345381e89d6bbd440f7b4c680d03e8b75b86de/qa/qa/tools/test_resources_handler.rb#L44) these resources. On [dotcom environments](https://about.gitlab.com/handbook/engineering/infrastructure/environments/#environments), after a test suite finishes in the [QA pipelines](https://about.gitlab.com/handbook/engineering/quality/quality-engineering/debugging-qa-test-failures/#scheduled-qa-test-pipelines), resources from all passing test are automatically deleted in the same pipeline run. Resources from all failed tests are reserved for investigation, -and won't be deleted until the following Saturday by a scheduled pipeline. When introducing new resources, please +and won't be deleted until the following Saturday by a scheduled pipeline. When introducing new resources, also make sure to add any resource that cannot be deleted to the [IGNORED_RESOURCES](https://gitlab.com/gitlab-org/gitlab/-/blob/44345381e89d6bbd440f7b4c680d03e8b75b86de/qa/qa/tools/test_resources_handler.rb#L29) list. @@ -503,5 +503,5 @@ list. If you need more information, ask for help on `#test-platform` channel on Slack (internal, GitLab Team only). -If you are not a Team Member, and you still need help to contribute, please +If you are not a Team Member, and you still need help to contribute, open an issue in GitLab CE issue tracker with the `~QA` label. diff --git a/doc/development/testing_guide/end_to_end/running_tests_that_require_special_setup.md b/doc/development/testing_guide/end_to_end/running_tests_that_require_special_setup.md index 83c194afc606a3ccb9ea6e4d93eacbf87e8f16c6..c2661a15c3d174eeb17d65197e84a757bb4f1988 100644 --- a/doc/development/testing_guide/end_to_end/running_tests_that_require_special_setup.md +++ b/doc/development/testing_guide/end_to_end/running_tests_that_require_special_setup.md @@ -10,7 +10,7 @@ info: Any user with at least the Maintainer role can merge updates to this conte The [`jenkins_build_status_spec`](https://gitlab.com/gitlab-org/gitlab/-/blob/24a86debf49f3aed6f2ecfd6e8f9233b3a214181/qa/qa/specs/features/browser_ui/3_create/jenkins/jenkins_build_status_spec.rb) spins up a Jenkins instance in a Docker container with the Jenkins GitLab plugin pre-installed. Due to a license restriction we are unable to distribute this image. -To build a QA compatible image, please visit the [third party images project](https://gitlab.com/gitlab-org/quality/third-party-docker-public), where third party Dockerfiles can be found. +To build a QA compatible image, visit the [third party images project](https://gitlab.com/gitlab-org/quality/third-party-docker-public), where third party Dockerfiles can be found. The project also has instructions for forking and building the images automatically in CI. Some extra environment variables for the location of the forked repository are also needed. @@ -47,7 +47,7 @@ bin/qa Test::Instance::All http://localhost -- qa/specs/features/ee/browser_ui/3 The test automatically spins up a Docker container for Jenkins and tear down once the test completes. -If you need to run Jenkins manually outside of the tests, please refer to the README for the +If you need to run Jenkins manually outside of the tests, refer to the README for the [third party images project](https://gitlab.com/gitlab-org/quality/third-party-docker-public/-/blob/main/jenkins/README.md) ### Troubleshooting @@ -420,7 +420,7 @@ To run these tests locally against the GDK: QA_LOG_LEVEL=debug WEBDRIVER_HEADLESS=false bin/qa Test::Instance::All http://localhost:3000 qa/specs/features/browser_ui/2_plan/email/trigger_email_notification_spec.rb -- --tag orchestrated ``` -For instructions on how to run these tests using the `gitlab-qa` gem, please refer to [the GitLab QA documentation](https://gitlab.com/gitlab-org/gitlab-qa/-/blob/master/docs/what_tests_can_be_run.md#testintegrationsmtp-ceeefull-image-address). +For instructions on how to run these tests using the `gitlab-qa` gem, refer to [the GitLab QA documentation](https://gitlab.com/gitlab-org/gitlab-qa/-/blob/master/docs/what_tests_can_be_run.md#testintegrationsmtp-ceeefull-image-address). ## Guide to the mobile suite diff --git a/doc/development/testing_guide/end_to_end/style_guide.md b/doc/development/testing_guide/end_to_end/style_guide.md index 4ab0d06282e5cda1f6d95d64dbf460fb528a6788..966ed851115748cacdf1714f8a9ffcb96d84745e 100644 --- a/doc/development/testing_guide/end_to_end/style_guide.md +++ b/doc/development/testing_guide/end_to_end/style_guide.md @@ -71,7 +71,7 @@ We follow a simple formula roughly based on Hungarian notation. - `_menu_item` NOTE: -If none of the listed types are suitable, please open a merge request to add an appropriate type to the list. +If none of the listed types are suitable, open a merge request to add an appropriate type to the list. ### Examples diff --git a/doc/development/testing_guide/review_apps.md b/doc/development/testing_guide/review_apps.md index 51ca7e203003b221507bfafc25df47337ab7e770..d0a6fa8da5fadcba56fecb8723414a5fd019d573 100644 --- a/doc/development/testing_guide/review_apps.md +++ b/doc/development/testing_guide/review_apps.md @@ -203,15 +203,15 @@ subgraph "CNG-mirror pipeline" **Additional notes:** - If the `review-deploy` job keeps failing (and a manual retry didn't help), - please post a message in the `#g_qe_engineering_productivity` channel and/or create a `~"Engineering Productivity"` `~"ep::review apps"` `~"type::bug"` + post a message in the `#g_qe_engineering_productivity` channel and/or create a `~"Engineering Productivity"` `~"ep::review apps"` `~"type::bug"` issue with a link to your merge request. The deployment failure can reveal an actual problem introduced in your merge request (that is, this isn't necessarily a transient failure)! - If the `review-qa-smoke` or `review-qa-reliable` job keeps failing (we already retry them once), - please check the job's logs: you could discover an actual problem introduced in + check the job's logs: you could discover an actual problem introduced in your merge request. You can also download the artifacts to see screenshots of the page at the time the failures occurred. If you don't find the cause of the - failure or if it seems unrelated to your change, please post a message in the + failure or if it seems unrelated to your change, post a message in the `#test-platform` channel and/or create a ~Quality ~"type::bug" issue with a link to your merge request. - The manual `review-stop` can be used to diff --git a/doc/development/testing_guide/testing_migrations_guide.md b/doc/development/testing_guide/testing_migrations_guide.md index 56d4b8b8ccbc52f5266a2e086eae6b644e2f2afd..ce6ba082f3bcf1c5146784745e11078c5a2db77b 100644 --- a/doc/development/testing_guide/testing_migrations_guide.md +++ b/doc/development/testing_guide/testing_migrations_guide.md @@ -369,7 +369,7 @@ end ## Testing a non-`ActiveRecord::Migration` class To test a non-`ActiveRecord::Migration` test (a background migration), -you must manually provide a required schema version. Please add a +you must manually provide a required schema version. Add a `schema` tag to a context that you want to switch the database schema within. If not set, `schema` defaults to `:latest`. diff --git a/doc/development/work_items.md b/doc/development/work_items.md index 6ce35ea69f9fb56c65da86cd2a75cdc23ebb39f0..0c3bc4611f59f81c15767b14c518b1c4d178c053 100644 --- a/doc/development/work_items.md +++ b/doc/development/work_items.md @@ -190,7 +190,7 @@ and incidents) into work items. Eventually (when these resources become regular work items), `base_type` will be removed. Until the architecture of WIT widgets is finalized, we are holding off on the creation of new work item -types. If a new work item type is absolutely necessary, please reach out to a +types. If a new work item type is absolutely necessary, reach out to a member of the [Project Management Engineering Team](https://gitlab.com/gitlab-org/gitlab/-/issues/370599). ### Creating a new work item type in the database diff --git a/doc/integration/advanced_search/elasticsearch_troubleshooting.md b/doc/integration/advanced_search/elasticsearch_troubleshooting.md index 3e3de155b3f17f8ece7ef4760f6120aa56040b42..77ffc58460681e81848e9cb5e0db3f454b71cef7 100644 --- a/doc/integration/advanced_search/elasticsearch_troubleshooting.md +++ b/doc/integration/advanced_search/elasticsearch_troubleshooting.md @@ -367,7 +367,7 @@ Elasticsearch administrator has more experience with. ## Issues with migrations -Please ensure you've read about [Elasticsearch Migrations](../advanced_search/elasticsearch.md#advanced-search-migrations). +Ensure you've read about [Elasticsearch Migrations](../advanced_search/elasticsearch.md#advanced-search-migrations). If there is a halted migration and your [`elasticsearch.log`](../../administration/logs/index.md#elasticsearchlog) file contain errors, this could potentially be a bug/issue. Escalate to GitLab support if retrying migrations does not succeed. @@ -395,7 +395,7 @@ see details in the [update guide](../../update/upgrading_from_source.md). ## `Elasticsearch::Transport::Transport::Errors::BadRequest` -If you have this exception (just like in the case above but the actual message is different) please check if you have the correct Elasticsearch version and you met the other [requirements](elasticsearch.md#system-requirements). +If you have this exception (just like in the case above but the actual message is different), check that you have the correct Elasticsearch version and you met the other [requirements](elasticsearch.md#system-requirements). There is also an easy way to check it automatically with `sudo gitlab-rake gitlab:check` command. ## `Elasticsearch::Transport::Transport::Errors::RequestEntityTooLarge` @@ -419,7 +419,7 @@ Set a custom `gitlab_rails['env']` environment variable, called [`no_proxy`](htt WARNING: Setting the number of replicas to `0` is discouraged (this is not allowed in the GitLab Elasticsearch Integration menu). If you are planning to add more Elasticsearch nodes (for a total of more than 1 Elasticsearch) the number of replicas needs to be set to an integer value larger than `0`. Failure to do so results in lack of redundancy (losing one node corrupts the index). -If you have a **hard requirement to have a green status for your single node Elasticsearch cluster**, please make sure you understand the risks outlined in the previous paragraph and then run the following query to set the number of replicas to `0`(the cluster no longer tries to create any shard replicas): +If you have a **hard requirement to have a green status for your single node Elasticsearch cluster**, make sure you understand the risks outlined in the previous paragraph and then run the following query to set the number of replicas to `0`(the cluster no longer tries to create any shard replicas): ```shell curl --request PUT localhost:9200/gitlab-production/_settings --header 'Content-Type: application/json' \ @@ -438,7 +438,7 @@ If you're getting a `health check timeout: no Elasticsearch node available` erro Gitlab::Elastic::Indexer::Error: time="2020-01-23T09:13:00Z" level=fatal msg="health check timeout: no Elasticsearch node available" ``` -You probably have not used either `http://` or `https://` as part of your value in the **"URL"** field of the Elasticsearch Integration Menu. Please make sure you are using either `http://` or `https://` in this field as the [Elasticsearch client for Go](https://github.com/olivere/elastic) that we are using [needs the prefix for the URL to be accepted as valid](https://github.com/olivere/elastic/commit/a80af35aa41856dc2c986204e2b64eab81ccac3a). +You probably have not used either `http://` or `https://` as part of your value in the **"URL"** field of the Elasticsearch Integration Menu. Make sure you are using either `http://` or `https://` in this field as the [Elasticsearch client for Go](https://github.com/olivere/elastic) that we are using [needs the prefix for the URL to be accepted as valid](https://github.com/olivere/elastic/commit/a80af35aa41856dc2c986204e2b64eab81ccac3a). After you have corrected the formatting of the URL, delete the index (via the [dedicated Rake task](elasticsearch.md#gitlab-advanced-search-rake-tasks)) and [reindex the content of your instance](elasticsearch.md#enable-advanced-search). ## My Elasticsearch cluster has a plugin and the integration is not working diff --git a/doc/operations/error_tracking.md b/doc/operations/error_tracking.md index 8825f3d7451f7504d3285f37b73bc953993699dc..a46998c11d8ed05a6f02f26dcf2a34895b573c3f 100644 --- a/doc/operations/error_tracking.md +++ b/doc/operations/error_tracking.md @@ -8,7 +8,7 @@ info: To determine the technical writer assigned to the Stage/Group associated w Error Tracking allows developers to discover and view errors generated by their application. Because error information is surfaced where the code is developed, this increases efficiency and awareness. Users can choose between [GitLab Integrated error tracking](#integrated-error-tracking) and [Sentry based](#sentry-error-tracking) backends. -To leave feedback about Error Tracking bugs or functionality, please comment in the [feedback issue](https://gitlab.com/gitlab-org/opstrace/opstrace/-/issues/2362) or open a [new issue](https://gitlab.com/gitlab-org/opstrace/opstrace/-/issues/new). +To leave feedback about Error Tracking bugs or functionality, comment in the [feedback issue](https://gitlab.com/gitlab-org/opstrace/opstrace/-/issues/2362) or open a [new issue](https://gitlab.com/gitlab-org/opstrace/opstrace/-/issues/new). ## How error tracking works diff --git a/doc/operations/tracing.md b/doc/operations/tracing.md index 9ba32c6ab94ebfa33e67ef1fa82d2104cfd65070..cb31fdd8025f66ddff2b2a99f815a0157c2621a7 100644 --- a/doc/operations/tracing.md +++ b/doc/operations/tracing.md @@ -16,7 +16,7 @@ The feature is not ready for production use. With distributed tracing, you can troubleshoot application performance issues by inspecting how a request moves through different services and systems, the timing of each operation, and any errors or logs as they occur. Tracing is particularly useful in the context of microservice applications, which group multiple independent services collaborating to fulfill user requests. -This feature is an [Experiment](../policy/experiment-beta-support.md). For more information, see the [group direction page](https://about.gitlab.com/direction/analytics/observability/). To leave feedback about tracing bugs or functionality, please comment in the [feedback issue](https://gitlab.com/gitlab-org/opstrace/opstrace/-/issues/2363) or open a [new issue](https://gitlab.com/gitlab-org/opstrace/opstrace/-/issues/new). +This feature is an [Experiment](../policy/experiment-beta-support.md). For more information, see the [group direction page](https://about.gitlab.com/direction/analytics/observability/). To leave feedback about tracing bugs or functionality, comment in the [feedback issue](https://gitlab.com/gitlab-org/opstrace/opstrace/-/issues/2363) or open a [new issue](https://gitlab.com/gitlab-org/opstrace/opstrace/-/issues/new). ## Configure distributed tracing for a project diff --git a/doc/subscriptions/customers_portal.md b/doc/subscriptions/customers_portal.md index 6298389dfd29e93e15d5003969f310cbf3ad1135..10de69242d9e3824a5ba7523180c4114a82d54dd 100644 --- a/doc/subscriptions/customers_portal.md +++ b/doc/subscriptions/customers_portal.md @@ -77,7 +77,7 @@ Purchases in the Customers Portal require a credit card on record as a payment m multiple credit cards to your account, so that purchases for different products are charged to the correct card. -If you would like to use an alternative method to pay, please +If you would like to use an alternative method to pay, [contact our Sales team](https://about.gitlab.com/sales/). To change your payment method: diff --git a/doc/subscriptions/gitlab_com/index.md b/doc/subscriptions/gitlab_com/index.md index 6b4540c76a1e777fa9a732c3cf6caf71f8b816fd..9299028e56aa62231dc273ee44dda3fa95e31b0b 100644 --- a/doc/subscriptions/gitlab_com/index.md +++ b/doc/subscriptions/gitlab_com/index.md @@ -479,7 +479,7 @@ executive dashboards to drive organizational visibility. ### Purchase additional Enterprise Agile Planning seats -Please contact your [GitLab sales representative](https://about.gitlab.com/sales/) for more information. +Contact your [GitLab sales representative](https://about.gitlab.com/sales/) for more information. ## Contact Support diff --git a/doc/subscriptions/gitlab_dedicated/index.md b/doc/subscriptions/gitlab_dedicated/index.md index 0864275a85bb0aa4d8f7cd7073ac84784a17d515..0f2fdb4351291ce3d0d2d669be6db57f34dcdee6 100644 --- a/doc/subscriptions/gitlab_dedicated/index.md +++ b/doc/subscriptions/gitlab_dedicated/index.md @@ -150,7 +150,7 @@ The following operational features are not available: ### Available AWS regions -The following is a list of AWS regions verified for use in GitLab Dedicated. Regions must support io2 volumes and meet other requirements. If there is a region you are interested in that is not on this list, please reach out through your account representative or [GitLab Support](https://about.gitlab.com/support/) to inquire about its availability. This list will be updated from time to time as additional regions are verified. +The following is a list of AWS regions verified for use in GitLab Dedicated. Regions must support io2 volumes and meet other requirements. If there is a region you are interested in that is not on this list, reach out through your account representative or [GitLab Support](https://about.gitlab.com/support/) to inquire about its availability. This list will be updated from time to time as additional regions are verified. - Asia Pacific (Singapore) - Asia Pacific (Sydney) diff --git a/doc/subscriptions/quarterly_reconciliation.md b/doc/subscriptions/quarterly_reconciliation.md index 30d7a5bfb8d24240d632f595450eb6c3f23fcdee..87a4b65833c76875f974219f1d7c7513c0aa446f 100644 --- a/doc/subscriptions/quarterly_reconciliation.md +++ b/doc/subscriptions/quarterly_reconciliation.md @@ -81,7 +81,7 @@ sent and subject to your payment terms. ### Troubleshooting failed payment -If your credit card is declined during the reconciliation process, an email will be sent with the subject `Your GitLab subscription failed to reconcile`. Please follow these instructions to update your payment information, and the reconciliation will be automatically retried: +If your credit card is declined during the reconciliation process, an email will be sent with the subject `Your GitLab subscription failed to reconcile`. Follow these instructions to update your payment information, and the reconciliation will be automatically retried: 1. Log in to your account at `https://customers.gitlab.com`. 1. Go to **Payment Methods**. diff --git a/doc/update/index.md b/doc/update/index.md index b8da6a3b7e6467735d0171690840b8f01d4ae56e..c0a6b64a1ac3409e0162944d71a33bc1e4d96494 100644 --- a/doc/update/index.md +++ b/doc/update/index.md @@ -218,7 +218,7 @@ upgrade stops allow required background migrations to finish. During GitLab 16.x, we are scheduling required upgrade stops beforehand so users can better plan out appropriate upgrade stops and downtime when necessary. -The first scheduled required upgrade stop has been announced for 16.3.x. When planning upgrades, please take this into account. +The first scheduled required upgrade stop has been announced for 16.3.x. When planning upgrades, take this into account. ### Earlier GitLab versions diff --git a/doc/user/analytics/value_streams_dashboard.md b/doc/user/analytics/value_streams_dashboard.md index 7321ddfc15b6e7663b9be4e71621560da9d0f66d..a50eab42a2df08c678754822b744b94e3f40f1f6 100644 --- a/doc/user/analytics/value_streams_dashboard.md +++ b/doc/user/analytics/value_streams_dashboard.md @@ -10,7 +10,7 @@ info: To determine the technical writer assigned to the Stage/Group associated w > - Released in GitLab 15.11 as an Open [Beta](../../policy/experiment-beta-support.md#beta) feature [with a flag](../../administration/feature_flags.md) named `group_analytics_dashboards_page`. Enabled by default. > - [Generally available](https://gitlab.com/gitlab-org/gitlab/-/issues/392734) in GitLab 16.0. Feature flag `group_analytics_dashboards_page` removed. -To help us improve the Value Streams Dashboard, please share feedback about your experience in this [survey](https://gitlab.fra1.qualtrics.com/jfe/form/SV_50guMGNU2HhLeT4). +To help us improve the Value Streams Dashboard, share feedback about your experience in this [survey](https://gitlab.fra1.qualtrics.com/jfe/form/SV_50guMGNU2HhLeT4). For more information, see also the [Value Stream Management category direction page](https://about.gitlab.com/direction/plan/value_stream_management/). The Value Streams Dashboard is a customizable dashboard you can use to identify trends, patterns, and opportunities for digital transformation improvements. diff --git a/doc/user/application_security/continuous_vulnerability_scanning/index.md b/doc/user/application_security/continuous_vulnerability_scanning/index.md index 8d879ee6fe758bf509d4195dca7c4b23204453c5..4d6d48012aecf65851c8a4c93d66ea5256759667 100644 --- a/doc/user/application_security/continuous_vulnerability_scanning/index.md +++ b/doc/user/application_security/continuous_vulnerability_scanning/index.md @@ -25,7 +25,7 @@ Continuous Vulnerability Scanning detects vulnerabilities in the latest CycloneD To enable Continuous Vulnerability Scanning: - Enable [Dependency Scanning](../dependency_scanning/index.md#configuration) and ensure that its prerequisites are met. -- On GitLab self-managed only, you can [choose package registry metadata to synchronize](../../../administration/settings/security_and_compliance.md#choose-package-registry-metadata-to-sync) in the Admin Area for the GitLab instance. For this data synchronization to work, you must allow outbound network traffic from your GitLab instance to the domain `storage.googleapis.com`. If you have limited or no network connectivity then please refer to the documentation section [running in an offline environment](#running-in-an-offline-environment) for further guidance. +- On GitLab self-managed only, you can [choose package registry metadata to synchronize](../../../administration/settings/security_and_compliance.md#choose-package-registry-metadata-to-sync) in the Admin Area for the GitLab instance. For this data synchronization to work, you must allow outbound network traffic from your GitLab instance to the domain `storage.googleapis.com`. If you have limited or no network connectivity then refer to the documentation section [running in an offline environment](#running-in-an-offline-environment) for further guidance. ### Running in an offline environment diff --git a/doc/user/application_security/dast/browser_based.md b/doc/user/application_security/dast/browser_based.md index a683060fcfd0e7f4d8253c7c273e9d7b99a881cf..c0d71a95f91ee6241672a1b1adcf88bacb78c02a 100644 --- a/doc/user/application_security/dast/browser_based.md +++ b/doc/user/application_security/dast/browser_based.md @@ -89,7 +89,7 @@ A simplified timing attack works as follows: Active scans do not use a browser to send HTTP requests in an effort to minimize scan time. -Anti-CSRF tokens are not regenerated for attacks that submit forms. Please disable anti-CSRF tokens when running an active scan. +Anti-CSRF tokens are not regenerated for attacks that submit forms. Disable anti-CSRF tokens when running an active scan. ## Getting started diff --git a/doc/user/application_security/dast/checks/1336.1.md b/doc/user/application_security/dast/checks/1336.1.md index f5a5d1eac4b2f16d0aaafbf906e7bee099aa37fb..d20a67d34d409838a95626e70e6187c5ce624b97 100644 --- a/doc/user/application_security/dast/checks/1336.1.md +++ b/doc/user/application_security/dast/checks/1336.1.md @@ -17,7 +17,7 @@ system's integrity and confidentiality. ## Remediation User-controlled data should always have special elements neutralized when used as part of -constructing Expression Language statements. Please consult the documentation for the template +constructing Expression Language statements. Consult the documentation for the template system in use on how properly neutralize user-controlled data. ## Details diff --git a/doc/user/application_security/dast/checks/16.11.md b/doc/user/application_security/dast/checks/16.11.md index 6d72e5bf668feb23b30d7b6f5a0a4f6a7b378d7a..cdc0bd4e271c2893d2376365c0436fdd76b56e8e 100644 --- a/doc/user/application_security/dast/checks/16.11.md +++ b/doc/user/application_security/dast/checks/16.11.md @@ -25,7 +25,7 @@ registry key: - `HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\W3SVC\Parameters` -For all other server types, please consult your product's documentation on how to disable the TRACE method. +For all other server types, consult your product's documentation on how to disable the TRACE method. ## Details diff --git a/doc/user/application_security/dast/checks/16.2.md b/doc/user/application_security/dast/checks/16.2.md index 2051b118009b966f79b921b62863831a493cca28..fe6a882e3c4320785d3b30adaf346f93f2fe2660 100644 --- a/doc/user/application_security/dast/checks/16.2.md +++ b/doc/user/application_security/dast/checks/16.2.md @@ -27,7 +27,7 @@ IIS: For IIS based websites version 10 and above you can use the `removeServerHeader` element to the `requestFiltering` section of the `Web.config` file. -For all other server types, please consult your product's documentation on how to redact the version information from +For all other server types, consult your product's documentation on how to redact the version information from the `Server` header. ## Details diff --git a/doc/user/application_security/dast/checks/16.3.md b/doc/user/application_security/dast/checks/16.3.md index d1799baa517d77a1f5b9149779432b375576f55f..3179be7d691fc81d92b851a9a21503a18e3db8e2 100644 --- a/doc/user/application_security/dast/checks/16.3.md +++ b/doc/user/application_security/dast/checks/16.3.md @@ -20,7 +20,7 @@ We recommend that the version information be removed from the `X-Powered-By` hea PHP: For PHP based web sites, set the `expose_php` option to `off` in the `php.ini` configuration file. -For all other server types, please consult your product's documentation on how to redact the version +For all other server types, consult your product's documentation on how to redact the version information from the `X-Powered-By` header. ## Details diff --git a/doc/user/application_security/dast/checks/16.8.md b/doc/user/application_security/dast/checks/16.8.md index b8faef75de7157fc7b76874c4e8020169a5d892e..816bc8bd8732ba7ef5ee928b8525d037654aba8f 100644 --- a/doc/user/application_security/dast/checks/16.8.md +++ b/doc/user/application_security/dast/checks/16.8.md @@ -13,7 +13,7 @@ hardening a website against various client side attacks such as Cross-Site Scrip ## Remediation -If the target site is missing a CSP, please investigate the relevant URLs for enabling CSP. Otherwise, +If the target site is missing a CSP, investigate the relevant URLs for enabling CSP. Otherwise, follow the recommendations to determine if any actions are necessary. ## Details diff --git a/doc/user/application_security/dast/checks/548.1.md b/doc/user/application_security/dast/checks/548.1.md index 6cef8ccdb63b7ced340211db5d6e93aff35f92f7..3bef3bdc744c34b7b1fc0666ffb05b37662d8ce9 100644 --- a/doc/user/application_security/dast/checks/548.1.md +++ b/doc/user/application_security/dast/checks/548.1.md @@ -28,7 +28,7 @@ IIS: For IIS based websites version 7.0 and above you can use the `<directoryBrowse enabled="false" />` element in the `applicationHost.config` or `Web.config` files. -For all other server types, please consult your product's documentation on how to disable directory +For all other server types, Consult your product's documentation on how to disable directory indexing. ## Details diff --git a/doc/user/application_security/dast/checks/917.1.md b/doc/user/application_security/dast/checks/917.1.md index 68b9665e393ead01707703a2e68aa39e4aa09fac..853407afe30c5e5b53471119b6706eecf8588402 100644 --- a/doc/user/application_security/dast/checks/917.1.md +++ b/doc/user/application_security/dast/checks/917.1.md @@ -17,7 +17,7 @@ intended EL statement prior to it being executed by an interpreter. ## Remediation User-controlled data should always have special elements neutralized when used as part of -constructing Expression Language statements. Please consult the documentation for the EL +constructing Expression Language statements. Consult the documentation for the EL interpreter in use on how properly neutralize user controlled data. ## Details diff --git a/doc/user/application_security/dast/proxy-based.md b/doc/user/application_security/dast/proxy-based.md index 0cc016dfd1be11f139b500b36cc843c2d7d2e5b4..6127866b0a9423adfee272223a0e0277e10a2764 100644 --- a/doc/user/application_security/dast/proxy-based.md +++ b/doc/user/application_security/dast/proxy-based.md @@ -8,7 +8,7 @@ info: To determine the technical writer assigned to the Stage/Group associated w WARNING: Proxy-based DAST is [deprecated](https://gitlab.com/gitlab-org/gitlab/-/issues/430966). -We plan to [remove support for Proxy-based DAST](../../../update/deprecations.md#proxy-based-dast-deprecated). Please migrate to [Browser-based DAST](browser_based.md) +We plan to [remove support for Proxy-based DAST](../../../update/deprecations.md#proxy-based-dast-deprecated). Migrate to [Browser-based DAST](browser_based.md) to continue analyzing your projects for security findings via dynamic analysis. The DAST proxy-based analyzer can be added to your [GitLab CI/CD](../../../ci/index.md) pipeline. diff --git a/doc/user/application_security/index.md b/doc/user/application_security/index.md index fe7884baa23ecce3805da6db88b666d8f4bcb407..76a4f501d8619a981d3c86279e0716555fa4ac73 100644 --- a/doc/user/application_security/index.md +++ b/doc/user/application_security/index.md @@ -592,7 +592,7 @@ variables: This indicates to all GitLab analyzers that they are to output **all** messages. For more details, see [logging level](#logging-level). -<!-- NOTE: The below subsection(`### Secure job failing with exit code 1`) documentation URL is referred in the [/gitlab-org/security-products/analyzers/command](https://gitlab.com/gitlab-org/security-products/analyzers/command/-/blob/main/command.go#L19) repository. If this section/subsection changes, please ensure to update the corresponding URL in the mentioned repository. +<!-- NOTE: The below subsection(`### Secure job failing with exit code 1`) documentation URL is referred in the [/gitlab-org/security-products/analyzers/command](https://gitlab.com/gitlab-org/security-products/analyzers/command/-/blob/main/command.go#L19) repository. If this section/subsection changes, ensure to update the corresponding URL in the mentioned repository. --> ### Secure job failing with exit code 1 diff --git a/doc/user/compliance/license_scanning_of_cyclonedx_files/index.md b/doc/user/compliance/license_scanning_of_cyclonedx_files/index.md index 40b9f6f72908317e831aac193bb64fc4541ec1a1..123809787190fcff8cc346fc5c8afc838b826212 100644 --- a/doc/user/compliance/license_scanning_of_cyclonedx_files/index.md +++ b/doc/user/compliance/license_scanning_of_cyclonedx_files/index.md @@ -38,7 +38,7 @@ To enable License scanning of CycloneDX files: - Enable [Dependency Scanning](../../application_security/dependency_scanning/index.md#enabling-the-analyzer) and ensure that its prerequisites are met. -- On GitLab self-managed only, you can [choose package registry metadata to synchronize](../../../administration/settings/security_and_compliance.md#choose-package-registry-metadata-to-sync) in the Admin Area for the GitLab instance. For this data synchronization to work, you must allow outbound network traffic from your GitLab instance to the domain `storage.googleapis.com`. If you have limited or no network connectivity then please refer to the documentation section [running in an offline environment](#running-in-an-offline-environment) for further guidance. +- On GitLab self-managed only, you can [choose package registry metadata to synchronize](../../../administration/settings/security_and_compliance.md#choose-package-registry-metadata-to-sync) in the Admin Area for the GitLab instance. For this data synchronization to work, you must allow outbound network traffic from your GitLab instance to the domain `storage.googleapis.com`. If you have limited or no network connectivity then refer to the documentation section [running in an offline environment](#running-in-an-offline-environment) for further guidance. ## Supported languages and package managers diff --git a/doc/user/free_push_limit.md b/doc/user/free_push_limit.md index d2b47228f31cda623bdf18af299351e7c707968a..53088cd444578f0df51ca15b04c4ba1787858468 100644 --- a/doc/user/free_push_limit.md +++ b/doc/user/free_push_limit.md @@ -39,7 +39,7 @@ Git LFS is designed to work with Git to track large files. ## Feedback -If you have any feedback to share about this limit, please do so in +If you have any feedback to share about this limit, do so in [issue 428188](https://gitlab.com/gitlab-org/gitlab/-/issues/428188). ## Related topics diff --git a/doc/user/product_analytics/index.md b/doc/user/product_analytics/index.md index 106da1d1d75443cfd72a331c667453eb042147b2..75e44471f92d5cfc755cdab0f73ad99b5865b262 100644 --- a/doc/user/product_analytics/index.md +++ b/doc/user/product_analytics/index.md @@ -222,7 +222,7 @@ You can [query the funnel data with the REST API](../../api/product_analytics.md To do this, you can use the example query body below, where you need to replace `FUNNEL_NAME` with your funnel's name. NOTE: -The `afterDate` filter is not supported. Please use `beforeDate` or `inDateRange`. +The `afterDate` filter is not supported. Use `beforeDate` or `inDateRange`. ```json { diff --git a/doc/user/project/git_attributes.md b/doc/user/project/git_attributes.md index c34c489570a42ee4be7c33297c031b49e5a0eaec..61e73fcce8185b88c18ca0e76c894fc19bc10468 100644 --- a/doc/user/project/git_attributes.md +++ b/doc/user/project/git_attributes.md @@ -108,7 +108,7 @@ with no arguments, it always returns a non-zero return code. This means that for the files specified in `.gitattributes`, merges do nothing. To use your own merge driver, replace the value in `driver` to point to an -executable. For more details on how this command is invoked, please see the Git +executable. For more details on how this command is invoked, see the Git documentation on [custom merge drivers](https://git-scm.com/docs/gitattributes#_defining_a_custom_merge_driver). ### Use `.gitattributes` to set files custom merge driver applies to