From 3c70be62b33e1c1e9af1098feb00a60f3896ff58 Mon Sep 17 00:00:00 2001
From: Marcos Rocha <mrocha@gitlab.com>
Date: Tue, 9 Apr 2024 08:21:22 +0000
Subject: [PATCH] Fix rubocop complaints in ForeignKeysGenerator spec
---
.rubocop_todo/layout/argument_alignment.yml | 1 -
.../gitlab/partitioning/foreign_keys_generator_spec.rb | 6 +++---
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/.rubocop_todo/layout/argument_alignment.yml b/.rubocop_todo/layout/argument_alignment.yml
index a1894510b6abc..0c429ba608c9e 100644
--- a/.rubocop_todo/layout/argument_alignment.yml
+++ b/.rubocop_todo/layout/argument_alignment.yml
@@ -1204,7 +1204,6 @@ Layout/ArgumentAlignment:
- 'spec/lib/feature/definition_spec.rb'
- 'spec/lib/feature/gitaly_spec.rb'
- 'spec/lib/feature_spec.rb'
- - 'spec/lib/generators/gitlab/partitioning/foreign_keys_generator_spec.rb'
- 'spec/lib/gitlab/checks/changes_access_spec.rb'
- 'spec/lib/gitlab/checks/single_change_access_spec.rb'
- 'spec/lib/gitlab/conan_token_spec.rb'
diff --git a/spec/lib/generators/gitlab/partitioning/foreign_keys_generator_spec.rb b/spec/lib/generators/gitlab/partitioning/foreign_keys_generator_spec.rb
index 5f31603e331f1..77e14fa71ba6b 100644
--- a/spec/lib/generators/gitlab/partitioning/foreign_keys_generator_spec.rb
+++ b/spec/lib/generators/gitlab/partitioning/foreign_keys_generator_spec.rb
@@ -4,7 +4,7 @@
require 'active_support/testing/stream'
RSpec.describe Gitlab::Partitioning::ForeignKeysGenerator, :migration, :silence_stdout,
-feature_category: :continuous_integration, quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/454333' do
+ feature_category: :continuous_integration, quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/454333' do
include ActiveSupport::Testing::Stream
include MigrationsHelpers
@@ -34,10 +34,10 @@
end
let(:generator_config) { { destination_root: destination_root } }
- let(:generator_args) { ['--source', '_test_tmp_metadata', '--target', '_test_tmp_builds', '--database', 'main'] }
+ let(:generator_args) { %w[--source _test_tmp_metadata --target _test_tmp_builds --database main] }
context 'without foreign keys' do
- let(:generator_args) { ['--source', '_test_tmp_metadata', '--target', 'projects', '--database', 'main'] }
+ let(:generator_args) { %w[--source _test_tmp_metadata --target projects --database main] }
it 'does not generate migrations' do
output = capture(:stderr) { run_generator }
--
GitLab