diff --git a/ee/app/assets/javascripts/analytics/cycle_analytics/store/actions.js b/ee/app/assets/javascripts/analytics/cycle_analytics/store/actions.js index 18652d0bbfd0a2f0906c889fcf3a423433730a5c..85148429ab6a858a3249cbe7a4cd7806204d99bd 100644 --- a/ee/app/assets/javascripts/analytics/cycle_analytics/store/actions.js +++ b/ee/app/assets/javascripts/analytics/cycle_analytics/store/actions.js @@ -115,14 +115,14 @@ export const fetchStageMedianValues = ({ dispatch, commit, getters }) => { export const requestCycleAnalyticsData = ({ commit }) => commit(types.REQUEST_VALUE_STREAM_DATA); export const receiveCycleAnalyticsDataSuccess = ({ commit, dispatch }) => { - commit(types.RECEIVE_CYCLE_ANALYTICS_DATA_SUCCESS); + commit(types.RECEIVE_VALUE_STREAM_DATA_SUCCESS); dispatch('typeOfWork/fetchTopRankedGroupLabels'); }; export const receiveCycleAnalyticsDataError = ({ commit }, { response = {} }) => { const { status = httpStatus.INTERNAL_SERVER_ERROR } = response; - commit(types.RECEIVE_CYCLE_ANALYTICS_DATA_ERROR, status); + commit(types.RECEIVE_VALUE_STREAM_DATA_ERROR, status); if (status !== httpStatus.FORBIDDEN) { createFlash(__('There was an error while fetching value stream analytics data.')); } diff --git a/ee/app/assets/javascripts/analytics/cycle_analytics/store/mutation_types.js b/ee/app/assets/javascripts/analytics/cycle_analytics/store/mutation_types.js index 144e38ac88afbbf35b107e91c36d5126db363c1e..b16be07a84fe64458d615db9dd4745b37c276dbf 100644 --- a/ee/app/assets/javascripts/analytics/cycle_analytics/store/mutation_types.js +++ b/ee/app/assets/javascripts/analytics/cycle_analytics/store/mutation_types.js @@ -6,8 +6,8 @@ export const SET_DATE_RANGE = 'SET_DATE_RANGE'; export const SET_SELECTED_VALUE_STREAM = 'SET_SELECTED_VALUE_STREAM'; export const REQUEST_VALUE_STREAM_DATA = 'REQUEST_VALUE_STREAM_DATA'; -export const RECEIVE_CYCLE_ANALYTICS_DATA_SUCCESS = 'RECEIVE_CYCLE_ANALYTICS_DATA_SUCCESS'; -export const RECEIVE_CYCLE_ANALYTICS_DATA_ERROR = 'RECEIVE_CYCLE_ANALYTICS_DATA_ERROR'; +export const RECEIVE_VALUE_STREAM_DATA_SUCCESS = 'RECEIVE_VALUE_STREAM_DATA_SUCCESS'; +export const RECEIVE_VALUE_STREAM_DATA_ERROR = 'RECEIVE_VALUE_STREAM_DATA_ERROR'; export const REQUEST_STAGE_DATA = 'REQUEST_STAGE_DATA'; export const RECEIVE_STAGE_DATA_SUCCESS = 'RECEIVE_STAGE_DATA_SUCCESS'; diff --git a/ee/app/assets/javascripts/analytics/cycle_analytics/store/mutations.js b/ee/app/assets/javascripts/analytics/cycle_analytics/store/mutations.js index 68b6bd9e3f5060289926d2f1258172af93777ea1..ba86ed0bbff317064fac6fe7895bc13c3ed6d4fc 100644 --- a/ee/app/assets/javascripts/analytics/cycle_analytics/store/mutations.js +++ b/ee/app/assets/javascripts/analytics/cycle_analytics/store/mutations.js @@ -19,11 +19,11 @@ export default { [types.REQUEST_VALUE_STREAM_DATA](state) { state.isLoading = true; }, - [types.RECEIVE_CYCLE_ANALYTICS_DATA_SUCCESS](state) { + [types.RECEIVE_VALUE_STREAM_DATA_SUCCESS](state) { state.errorCode = null; state.isLoading = false; }, - [types.RECEIVE_CYCLE_ANALYTICS_DATA_ERROR](state, errCode) { + [types.RECEIVE_VALUE_STREAM_DATA_ERROR](state, errCode) { state.errorCode = errCode; state.isLoading = false; }, diff --git a/ee/spec/frontend/analytics/cycle_analytics/store/actions_spec.js b/ee/spec/frontend/analytics/cycle_analytics/store/actions_spec.js index 32ad87e0333f41836601728d0f207993deea8dc1..90b2fea80ec55763057229d0b9f4eeccc58cbfc1 100644 --- a/ee/spec/frontend/analytics/cycle_analytics/store/actions_spec.js +++ b/ee/spec/frontend/analytics/cycle_analytics/store/actions_spec.js @@ -327,7 +327,7 @@ describe('Value Stream Analytics actions', () => { describe('receiveCycleAnalyticsDataError', () => { beforeEach(() => {}); - it(`commits the ${types.RECEIVE_CYCLE_ANALYTICS_DATA_ERROR} mutation on a 403 response`, () => { + it(`commits the ${types.RECEIVE_VALUE_STREAM_DATA_ERROR} mutation on a 403 response`, () => { const response = { status: 403 }; return testAction( actions.receiveCycleAnalyticsDataError, @@ -335,7 +335,7 @@ describe('Value Stream Analytics actions', () => { state, [ { - type: types.RECEIVE_CYCLE_ANALYTICS_DATA_ERROR, + type: types.RECEIVE_VALUE_STREAM_DATA_ERROR, payload: response.status, }, ], @@ -343,7 +343,7 @@ describe('Value Stream Analytics actions', () => { ); }); - it(`commits the ${types.RECEIVE_CYCLE_ANALYTICS_DATA_ERROR} mutation on a non 403 error response`, () => { + it(`commits the ${types.RECEIVE_VALUE_STREAM_DATA_ERROR} mutation on a non 403 error response`, () => { const response = { status: 500 }; return testAction( actions.receiveCycleAnalyticsDataError, @@ -351,7 +351,7 @@ describe('Value Stream Analytics actions', () => { state, [ { - type: types.RECEIVE_CYCLE_ANALYTICS_DATA_ERROR, + type: types.RECEIVE_VALUE_STREAM_DATA_ERROR, payload: response.status, }, ], diff --git a/ee/spec/frontend/analytics/cycle_analytics/store/mutations_spec.js b/ee/spec/frontend/analytics/cycle_analytics/store/mutations_spec.js index 1084e19dcc452d9d054c2cdde2f7608425851916..cd43e7b6bdf3a851aa16fb8253f2176a0e027f5b 100644 --- a/ee/spec/frontend/analytics/cycle_analytics/store/mutations_spec.js +++ b/ee/spec/frontend/analytics/cycle_analytics/store/mutations_spec.js @@ -131,9 +131,9 @@ describe('Value Stream Analytics mutations', () => { ); }); - describe(`${types.RECEIVE_CYCLE_ANALYTICS_DATA_SUCCESS}`, () => { + describe(`${types.RECEIVE_VALUE_STREAM_DATA_SUCCESS}`, () => { it('will set isLoading=false and errorCode=null', () => { - mutations[types.RECEIVE_CYCLE_ANALYTICS_DATA_SUCCESS](state, { + mutations[types.RECEIVE_VALUE_STREAM_DATA_SUCCESS](state, { stats: [], stages: [], }); @@ -157,11 +157,11 @@ describe('Value Stream Analytics mutations', () => { }); }); - describe(`${types.RECEIVE_CYCLE_ANALYTICS_DATA_ERROR}`, () => { + describe(`${types.RECEIVE_VALUE_STREAM_DATA_ERROR}`, () => { it('sets errorCode correctly', () => { const errorCode = 403; - mutations[types.RECEIVE_CYCLE_ANALYTICS_DATA_ERROR](state, errorCode); + mutations[types.RECEIVE_VALUE_STREAM_DATA_ERROR](state, errorCode); expect(state.isLoading).toBe(false); expect(state.errorCode).toBe(errorCode);