From 3610310082f12230aebca28728c8b820972b087b Mon Sep 17 00:00:00 2001
From: mfluharty <mfluharty@gitlab.com>
Date: Tue, 24 May 2022 17:25:45 -0600
Subject: [PATCH] Fix last updated date in group coverage summary
Get date from last data point while parsing the result
instead of confusing computed prop that actually got first data point
---
.../components/test_coverage_summary.vue | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/ee/app/assets/javascripts/analytics/repository_analytics/components/test_coverage_summary.vue b/ee/app/assets/javascripts/analytics/repository_analytics/components/test_coverage_summary.vue
index 589c00d641c85..23e585f62cb5a 100644
--- a/ee/app/assets/javascripts/analytics/repository_analytics/components/test_coverage_summary.vue
+++ b/ee/app/assets/javascripts/analytics/repository_analytics/components/test_coverage_summary.vue
@@ -52,12 +52,13 @@ export default {
},
result({ data }) {
const groupCoverage = data.group.codeCoverageActivities.nodes;
- const { projectCount, averageCoverage, coverageCount } =
+ const { projectCount, averageCoverage, coverageCount, date } =
groupCoverage?.[groupCoverage.length - 1] || {};
this.projectCount = projectCount;
this.averageCoverage = averageCoverage;
this.coverageCount = coverageCount;
+ this.latestCoverageDate = date;
this.groupCoverageChartData = [
{
name: this.$options.i18n.graphName,
@@ -87,6 +88,7 @@ export default {
projectCount: null,
averageCoverage: null,
coverageCount: null,
+ latestCoverageDate: null,
groupCoverageChartData: [],
coveragePercentage: null,
tooltipTitle: null,
@@ -152,14 +154,13 @@ export default {
};
},
latestCoverageTimeAgo() {
- const latestCoverageDataPoint = this.groupCoverageChartData?.[
- this.groupCoverageChartData.length - 1
- ];
- const latestCoverageDate = latestCoverageDataPoint?.data[0][0];
- if (isToday(newDateAsLocaleTime(latestCoverageDate))) {
+ if (!this.latestCoverageDate) {
+ return null;
+ }
+ if (isToday(newDateAsLocaleTime(this.latestCoverageDate))) {
return __('today');
}
- return getTimeago().format(latestCoverageDate);
+ return getTimeago().format(this.latestCoverageDate);
},
},
methods: {
--
GitLab