diff --git a/.rubocop_manual_todo.yml b/.rubocop_manual_todo.yml index fcf4ae04562d5331f4112ee95edec243e4dff2f8..462896509eefdc6d44db3338ed192eee97de2bcf 100644 --- a/.rubocop_manual_todo.yml +++ b/.rubocop_manual_todo.yml @@ -431,8 +431,6 @@ RSpec/EmptyLineAfterFinalLetItBe: - ee/spec/controllers/projects/merge_requests_controller_spec.rb - ee/spec/controllers/projects/mirrors_controller_spec.rb - ee/spec/controllers/projects/threat_monitoring_controller_spec.rb - - ee/spec/controllers/registrations/groups_controller_spec.rb - - ee/spec/controllers/registrations/projects_controller_spec.rb - ee/spec/controllers/subscriptions_controller_spec.rb - ee/spec/features/boards/group_boards/multiple_boards_spec.rb - ee/spec/features/ci_shared_runner_warnings_spec.rb diff --git a/ee/changelogs/unreleased/rspec-empty-lines-after-letitbe-ee-spec-controllers-registractions.yml b/ee/changelogs/unreleased/rspec-empty-lines-after-letitbe-ee-spec-controllers-registractions.yml new file mode 100644 index 0000000000000000000000000000000000000000..a0a0485dc6cd523e65d0a432fa9c98a170fd8f2e --- /dev/null +++ b/ee/changelogs/unreleased/rspec-empty-lines-after-letitbe-ee-spec-controllers-registractions.yml @@ -0,0 +1,5 @@ +--- +title: Fix RSpec/EmptyLineAfterFinalLetItBe rubocop offenses in ee/spec/controllers/registrations +merge_request: 58408 +author: Abdul Wadood @abdulwd +type: fixed diff --git a/ee/spec/controllers/registrations/groups_controller_spec.rb b/ee/spec/controllers/registrations/groups_controller_spec.rb index 9be431afb180a81b93077a8b538d6a43ddf6abfd..512ef65cc89b316ad17859870a1c755c32d2c64c 100644 --- a/ee/spec/controllers/registrations/groups_controller_spec.rb +++ b/ee/spec/controllers/registrations/groups_controller_spec.rb @@ -78,6 +78,7 @@ let_it_be(:trial_form_params) { { trial: 'false' } } let_it_be(:trial_onboarding_issues_enabled) { false } let_it_be(:trial_onboarding_flow_params) { {} } + let(:signup_onboarding_enabled) { true } let(:group_params) { { name: 'Group name', path: 'group-path', visibility_level: Gitlab::VisibilityLevel::PRIVATE, emails: ['', ''] } } let(:params) do diff --git a/ee/spec/controllers/registrations/projects_controller_spec.rb b/ee/spec/controllers/registrations/projects_controller_spec.rb index 229815df354d5bf3ba53da01a74a5db6ea0258dd..e2e744f96707eeeb89b8aa30ee628db7c0045237 100644 --- a/ee/spec/controllers/registrations/projects_controller_spec.rb +++ b/ee/spec/controllers/registrations/projects_controller_spec.rb @@ -54,6 +54,7 @@ subject { post :create, params: { project: params }.merge(trial_onboarding_flow_params) } let_it_be(:trial_onboarding_flow_params) { {} } + let(:params) { { namespace_id: namespace.id, name: 'New project', path: 'project-path', visibility_level: Gitlab::VisibilityLevel::PRIVATE } } let(:signup_onboarding_enabled) { true }