diff --git a/.rubocop.yml b/.rubocop.yml index b159b1e5c51655bc2917b5fb91a42193c2abbd1e..1a47e5d81f41371da7456a407d88b86b2326eb66 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -46,10 +46,6 @@ AllCops: - 'spec/support/*.git/**/*' # e.g. spec/support/gitlab-git-test.git # projects_controller.rb is used for testing LLM response and is very sensitive to whitespaces. - 'ee/spec/fixtures/llm/projects_controller.rb' - # Adding this specifically for a large revert: !118368 - <% File.readlines('.rubocop_revert_ignores.txt').map(&:chomp).each do |f| %> - - '<%= f %>' - <% end %> # Use absolute path to avoid orphan directories with changed workspace root. CacheRootDirectory: <%= Dir.getwd %>/tmp MaxFilesInCache: 1_000_000 diff --git a/.rubocop_revert_ignores.txt b/.rubocop_revert_ignores.txt deleted file mode 100644 index 8192cd6b57b3b7501d30db7856e561a57c8a5cd0..0000000000000000000000000000000000000000 --- a/.rubocop_revert_ignores.txt +++ /dev/null @@ -1,389 +0,0 @@ -db/migrate/20211202041233_init_schema.rb -db/migrate/20211202094944_move_loose_fk_deleted_records_to_dynamic_schema.rb -db/migrate/20211202135508_add_index_on_packages_build_infos_package_id_pipeline_id.rb -db/migrate/20211203160952_add_updated_state_by_user_id_to_merge_request_reviewers.rb -db/migrate/20211203161149_add_index_to_merge_request_reviewers_updated_state_by_user_id.rb -db/migrate/20211203161840_add_updated_state_by_user_id_to_merge_request_assignees.rb -db/migrate/20211203161942_add_index_to_merge_request_assignees_updated_state_by_user_id.rb -db/migrate/20211204010826_add_index_snippets_on_project_id_and_title.rb -db/migrate/20211207154413_add_ci_runners_index_on_created_at_where_active_is_false.rb -db/migrate/20211207154414_add_ci_runners_index_on_contacted_at_where_active_is_false.rb -db/migrate/20211207165508_add_protected_environments_required_approval_count_check_constraint.rb -db/migrate/20211208111425_add_executor_type_column_to_ci_runners.rb -db/migrate/20211209230042_add_status_to_cluster_agent_tokens.rb -db/migrate/20211210025754_alter_constraint_of_phone.rb -db/migrate/20211210031721_change_user_details_phone_text_limit.rb -db/migrate/20211213130324_update_timelogs_spent_at_default.rb -db/migrate/20211213142344_add_settings_user_email_lookup_limit.rb -db/migrate/20211213154259_add_status_to_packages_package_files.rb -db/migrate/20211213154704_add_status_index_to_packages_package_files.rb -db/migrate/20211214110307_remove_temp_index_from_vulnerability_occurrences.rb -db/migrate/20211215182006_update_application_settings_protected_paths.rb -db/migrate/20211216133107_add_cluster_agent_id_to_vulnerability_reads.rb -db/migrate/20211216134134_add_text_limit_to_vulnerability_reads_cluster_agent_id.rb -db/migrate/20211216135651_add_index_to_cluster_agent_id.rb -db/migrate/20211216220939_add_group_crm_settings.rb -db/migrate/20211217050753_remove_artifacts_archive_id_foreign_key_from_project_pages_metadata.rb -db/migrate/20211220174504_add_secure_scanning_actions_to_onboarding_progresses.rb -db/migrate/20211223125921_add_temp_index_to_members_state.rb -db/migrate/20211224112937_add_packages_cleanup_package_file_worker_capacity_to_application_settings.rb -db/migrate/20211224114539_add_packages_cleanup_package_file_worker_capacity_check_constraint_to_app_settings.rb -db/migrate/20220104174445_add_ci_runners_index_on_active_state.rb -db/migrate/20220105082217_add_verification_token_to_external_ae_destinations.rb -db/migrate/20220105121325_add_route_namespace_reference.rb -db/migrate/20220105152547_add_foreign_key_to_updated_state_by_user_id_to_merge_request_assignees.rb -db/migrate/20220105153149_add_foreign_key_to_updated_state_by_user_id_to_merge_request_reviewers.rb -db/migrate/20220106111958_add_insert_or_update_vulnerability_reads_trigger.rb -db/migrate/20220106112043_add_update_vulnerability_reads_trigger.rb -db/migrate/20220106112085_add_update_vulnerability_reads_location_trigger.rb -db/migrate/20220106141756_remove_lock_version_indexes.rb -db/migrate/20220106163326_add_has_issues_on_vulnerability_reads_trigger.rb -db/migrate/20220106230629_add_registry_migration_application_settings.rb -db/migrate/20220106230712_add_migration_columns_to_container_repositories.rb -db/migrate/20220107091629_add_route_namespace_index.rb -db/migrate/20220107165036_remove_note_id_index.rb -db/migrate/20220109133006_remove_ci_pipelines_lock_version_index.rb -db/migrate/20220110170953_create_ci_secure_files.rb -db/migrate/20220111095006_add_maintainer_note_to_ci_runners.rb -db/migrate/20220111095007_add_text_limit_to_ci_runners_maintainer_note.rb -db/migrate/20220111154950_add_token_expires_at_to_ci_runners.rb -db/migrate/20220111154951_add_index_to_ci_runners_token_expires_at.rb -db/migrate/20220111200254_remove_index_from_merge_requests.rb -db/migrate/20220112115413_add_requires_verification_to_user_details.rb -db/migrate/20220112205111_create_security_training_providers.rb -db/migrate/20220112232037_add_member_namespace_reference.rb -db/migrate/20220112232605_add_member_namespace_index.rb -db/migrate/20220113125401_create_security_trainings.rb -db/migrate/20220113135449_add_package_files_limit_to_application_settings.rb -db/migrate/20220113135924_add_application_settings_package_files_limit_constraints.rb -db/migrate/20220113164801_add_diffs_colors_to_user_preferences.rb -db/migrate/20220113164901_add_text_limit_to_user_preferences_diffs_colors.rb -db/migrate/20220114131950_add_status_only_index_to_packages_package_files.rb -db/migrate/20220117082611_add_text_limit_to_exad_verification_tokens.rb -db/migrate/20220117225936_add_text_limits_to_container_repositories_migration_columns.rb -db/migrate/20220118015633_add_url_text_to_issuable_metric_images.rb -db/migrate/20220118020026_add_url_text_limit_to_issuable_metric_images.rb -db/migrate/20220118141950_add_text_limit_to_container_registry_import_target_plan.rb -db/migrate/20220118155846_add_runner_token_expiration_interval_settings_to_application_settings.rb -db/migrate/20220118155847_add_runner_token_expiration_interval_settings_to_namespace_settings.rb -db/migrate/20220118155848_add_runner_token_expiration_interval_settings_to_project_settings.rb -db/migrate/20220119094023_add_unique_index_to_aed_verification_token.rb -db/migrate/20220119141407_add_dependency_proxy_size_to_namespace_statistics.rb -db/migrate/20220119144253_add_dependency_proxy_size_to_namespace_root_storage_statistics.rb -db/migrate/20220119170426_remove_temporary_vulnerability_occurrences_deduplication_index.rb -db/migrate/20220119220620_add_scan_method_to_dast_site_profile.rb -db/migrate/20220120033115_create_alert_management_alert_metric_images.rb -db/migrate/20220120085655_add_ci_runner_project_index_to_runner_id_and_project_id.rb -db/migrate/20220120160625_remove_temp_index_on_id_from_vulnerability_occurrences.rb -db/migrate/20220120211831_temp_index_for_group_namespace_member_backfill.rb -db/migrate/20220124200927_add_index_to_issues.rb -db/migrate/20220125084127_add_cleanup_attempts_to_loose_foreign_keys_deleted_records.rb -db/migrate/20220125122228_add_topics_non_private_projects_count.rb -db/migrate/20220125122725_add_topics_non_private_projects_count_index.rb -db/migrate/20220125230538_add_compound_index_on_project_id_and_id_for_vulnerabilities.rb -db/migrate/20220126191624_add_scan_file_path_to_dast_site_profile.rb -db/migrate/20220128093756_add_ecdsa_sk_and_ed25519_sk_key_restrictions_to_application_settings.rb -db/migrate/20220128194722_add_index_on_migration_state_and_import_done_at_to_container_repositories.rb -db/migrate/20220131135725_add_severity_level_to_merge_requests_compliance_violations.rb -db/migrate/20220131192643_add_show_diff_preview_in_email_to_project_settings.rb -db/migrate/20220201205300_remove_index_for_vulnerability_occurrences.rb -db/migrate/20220202034409_add_tmp_index_on_id_and_migration_state_to_container_repositories.rb -db/migrate/20220202115350_add_migration_indexes_to_container_repositories.rb -db/migrate/20220203074916_add_topics_lower_name_index.rb -db/migrate/20220203091304_fix_unique_packages_index_excluding_pending_destruction_status.rb -db/migrate/20220203123333_add_batched_migration_max_batch.rb -db/migrate/20220203133652_add_legacy_open_source_license_available_to_project_settings.rb -db/migrate/20220203134942_add_hidden_to_projects.rb -db/migrate/20220204093120_create_analytics_cycle_analytics_aggregations.rb -db/migrate/20220204154220_add_index_on_greatest_done_at_to_container_repositories.rb -db/migrate/20220204193000_add_integrations_encrypted_properties.rb -db/migrate/20220207083129_add_users_get_by_id_limit_to_application_setting.rb -db/migrate/20220208170445_add_not_valid_foreign_key_to_ci_builds_runner_id.rb -db/migrate/20220208171826_update_default_scan_method_of_dast_site_profile.rb -db/migrate/20220211090920_cleanup_populate_topics_non_private_projects_count.rb -db/migrate/20220211125954_create_related_epic_links.rb -db/migrate/20220211214605_update_integrations_trigger_type_new_on_insert_null_safe.rb -db/migrate/20220213100000_remove_integration_type_triggers.rb -db/migrate/20220215164709_update_application_settings_container_registry_exp_pol_worker_capacity_default.rb -db/migrate/20220216110023_create_saved_replies.rb -db/migrate/20220217100008_add_container_registry_expiration_policies_caching_to_application_settings.rb -db/migrate/20220217113058_add_status_to_status_check_responses.rb -db/migrate/20220221102333_change_maintainer_note_limit_in_ci_runner.rb -db/migrate/20220222072536_add_target_access_levels_to_broadcast_messages.rb -db/migrate/20220301002101_add_security_orchestration_policy_configuration_namespace_reference.rb -db/migrate/20220301003502_add_security_orchestration_policy_configuration_namespace_index.rb -db/migrate/20220301091503_add_not_null_constraint_to_security_policy_configurations.rb -db/migrate/20220301175104_change_security_orchestration_policy_configuration_project_index.rb -db/migrate/20220301175426_create_project_build_artifacts_size_refresh.rb -db/migrate/20220302110724_add_group_features_table.rb -db/migrate/20220303190555_add_comment_to_deployment_approvals.rb -db/migrate/20220303191047_add_text_limit_to_deployment_approvals_comment.rb -db/migrate/20220304052335_remove_not_null_contraint_on_title_from_sprints.rb -db/migrate/20220304061631_remove_unique_index_for_sprints_on_iterations_cadence_id_and_title.rb -db/migrate/20220304062107_remove_unique_index_for_sprints_on_project_id_and_title.rb -db/migrate/20220304152729_add_default_to_required_python_on_packages_pypi_metadata.rb -db/migrate/20220307203458_rename_user_email_lookup_limit_setting_to_search_settings.rb -db/migrate/20220309100648_add_time_to_restore_service_dora_metric.rb -db/migrate/20220310011530_add_database_grafana_config_to_application_settings.rb -db/migrate/20220310011613_add_text_limit_to_database_grafana_application_settings.rb -db/migrate/20220310101118_update_holder_name_limit.rb -db/migrate/20220314094841_add_package_registry_access_level_into_project_features.rb -db/migrate/20220314184009_create_protected_environment_approval_rules.rb -db/post_migrate/20211202145237_add_todos_project_and_id_index.rb -db/post_migrate/20211203091642_add_index_to_projects_on_marked_for_deletion_at.rb -db/post_migrate/20211206073851_create_calendar_events_index_synchronously.rb -db/post_migrate/20211206074547_remove_old_calendar_events_index.rb -db/post_migrate/20211206161271_add_indexes_for_primary_email_cleanup_migration.rb -db/post_migrate/20211207081708_add_index_ci_job_artifacts_project_id_file_type.rb -db/post_migrate/20211207090503_cleanup_first_mentioned_in_commit_jobs.rb -db/post_migrate/20211207125331_remove_jobs_for_recalculate_vulnerabilities_occurrences_uuid.rb -db/post_migrate/20211207135331_schedule_recalculate_uuid_on_vulnerabilities_occurrences4.rb -db/post_migrate/20211207173510_remove_extra_finding_evidence_tables_foreign_keys.rb -db/post_migrate/20211207173511_remove_extra_finding_evidence_tables.rb -db/post_migrate/20211208122200_schedule_backfill_ci_namespace_mirrors.rb -db/post_migrate/20211208122201_schedule_backfill_ci_project_mirrors.rb -db/post_migrate/20211208171402_reschedule_recalculate_vulnerability_finding_signatures_for_findings.rb -db/post_migrate/20211209093636_track_ci_job_artifacts_deletes.rb -db/post_migrate/20211209093828_track_users_deletes.rb -db/post_migrate/20211209093923_track_external_pull_requests_deletes.rb -db/post_migrate/20211209094222_track_merge_requests_deletes.rb -db/post_migrate/20211209103048_backfill_project_namespaces_for_group.rb -db/post_migrate/20211209203820_add_tmp_index_on_report_type.rb -db/post_migrate/20211209203821_convert_stringified_raw_metadata_hash_to_json.rb -db/post_migrate/20211210140000_add_temporary_static_object_token_index.rb -db/post_migrate/20211210140629_encrypt_static_object_token.rb -db/post_migrate/20211210173137_remove_vulnerability_finding_links_again.rb -db/post_migrate/20211213064821_add_agent_id_location_index_to_vulnerability_occurrences.rb -db/post_migrate/20211213102111_drop_ci_pipelines_mr_metrics_fk.rb -db/post_migrate/20211214012507_backfill_incident_issue_escalation_statuses.rb -db/post_migrate/20211215090620_schedule_update_timelogs_null_spent_at.rb -db/post_migrate/20211217120000_modify_kubernetes_resource_location_index_to_vulnerability_occurrences.rb -db/post_migrate/20211217145923_add_index_to_events_on_author_id_and_action_and_id.rb -db/post_migrate/20211217174331_mark_recalculate_finding_signatures_as_completed.rb -db/post_migrate/20211220064757_drop_temporary_indexes_for_primary_email_migration.rb -db/post_migrate/20211220120402_add_index_on_ci_pipelines_user_id_id_failure_reason.rb -db/post_migrate/20211220123956_update_invalid_member_states.rb -db/post_migrate/20211229023654_add_async_index_ci_job_artifacts_project_id_file_type.rb -db/post_migrate/20211230112517_remove_index_events_on_author_id_and_action_and_id.rb -db/post_migrate/20211230113031_add_index_to_events_on_author_id_and_id.rb -db/post_migrate/20220104060049_remove_foreign_key_ci_group_variables_group_id.rb -db/post_migrate/20220105020514_remove_ci_minutes_additional_packs_namespace_id_foreign_key_constraint.rb -db/post_migrate/20220106185033_remove_finding_evidence_summary.rb -db/post_migrate/20220106231518_remove_foreign_key_ci_daily_build_group_report_results_group_id.rb -db/post_migrate/20220106233459_remove_foreign_key_ci_pending_builds_namespace_id.rb -db/post_migrate/20220106235626_remove_foreign_key_ci_runner_namespaces_namespace_id.rb -db/post_migrate/20220107064845_populate_vulnerability_reads.rb -db/post_migrate/20220109134455_add_idx_vulnerability_occurrences_dedup_again.rb -db/post_migrate/20220110171049_schedule_populate_test_reports_issue_id.rb -db/post_migrate/20220110224913_remove_dast_scanner_profiles_builds_ci_build_id_fk.rb -db/post_migrate/20220110231420_remove_requirements_management_test_reports_build_id_fk.rb -db/post_migrate/20220110233155_remove_dast_site_profiles_builds_ci_build_id_fk.rb -db/post_migrate/20220111002756_remove_security_scans_build_id_fk.rb -db/post_migrate/20220111023852_index_cluster_agent_tokens_on_status.rb -db/post_migrate/20220111093534_remove_index_on_auto_stop_in.rb -db/post_migrate/20220111101421_remove_index_on_merge_request_id.rb -db/post_migrate/20220111102314_truncate_ci_mirror_tables.rb -db/post_migrate/20220111221516_remove_projects_ci_pending_builds_fk.rb -db/post_migrate/20220112015940_remove_projects_ci_running_builds_fk.rb -db/post_migrate/20220112090556_remove_cascade_delete_from_project_namespace_foreign_key.rb -db/post_migrate/20220112230642_remove_projects_ci_unit_tests_project_id_fk.rb -db/post_migrate/20220112232723_remove_projects_ci_daily_build_group_report_results_project_id_fk.rb -db/post_migrate/20220113013319_remove_projects_ci_freeze_periods_project_id_fk.rb -db/post_migrate/20220113014438_remove_projects_ci_resource_groups_project_id_fk.rb -db/post_migrate/20220113015830_remove_projects_ci_build_report_results_project_id_fk.rb -db/post_migrate/20220113035519_remove_users_ci_job_token_project_scope_links_added_by_id_fk.rb -db/post_migrate/20220113040447_remove_users_ci_pipeline_schedules_owner_id_fk.rb -db/post_migrate/20220113111440_schedule_fix_incorrect_max_seats_used.rb -db/post_migrate/20220114105525_add_index_on_projects_path.rb -db/post_migrate/20220116175851_add_author_index_to_design_management_versions.rb -db/post_migrate/20220117034056_remove_index_cluster_agent_tokens_on_agent_id_and_last_used_at.rb -db/post_migrate/20220118204039_self_managed_reschedule_recalculate_vulnerability_finding_signatures_for_findings.rb -db/post_migrate/20220119094503_populate_audit_event_streaming_verification_token.rb -db/post_migrate/20220119141736_remove_projects_ci_pipeline_artifacts_project_id_fk.rb -db/post_migrate/20220119143130_remove_projects_ci_sources_pipelines_source_project_id_fk.rb -db/post_migrate/20220119144458_remove_users_ci_triggers_owner_id_fk.rb -db/post_migrate/20220119151221_remove_merge_requests_ci_pipelines_merge_request_id_fk.rb -db/post_migrate/20220119153706_remove_ci_pipelines_merge_trains_pipeline_id_fk.rb -db/post_migrate/20220119154442_remove_ci_pipelines_merge_requests_head_pipeline_id_fk.rb -db/post_migrate/20220119193130_remove_ci_pipelines_dast_profiles_pipelines_ci_pipeline_id_fk.rb -db/post_migrate/20220119201340_remove_ci_pipelines_vulnerability_statistics_latest_pipeline_id_fk.rb -db/post_migrate/20220119203119_remove_ci_pipelines_vulnerability_occurrence_pipelines_pipeline_id_fk.rb -db/post_migrate/20220120094340_drop_position_from_security_findings.rb -db/post_migrate/20220120123700_add_tmp_index_routes_id_for_namespaces.rb -db/post_migrate/20220120123800_backfill_namespace_id_for_namespace_routes.rb -db/post_migrate/20220120211832_backfill_member_namespace_id_for_group_members.rb -db/post_migrate/20220121214752_remove_projects_ci_stages_project_id_fk.rb -db/post_migrate/20220121214753_re_remove_projects_ci_stages_project_id_fk.rb -db/post_migrate/20220121221651_remove_projects_ci_variables_project_id_fk.rb -db/post_migrate/20220124130028_dedup_runner_projects.rb -db/post_migrate/20220124145019_remove_projects_external_pull_requests_project_id_fk.rb -db/post_migrate/20220124151456_remove_projects_ci_triggers_project_id_fk.rb -db/post_migrate/20220124151949_remove_projects_ci_runner_projects_project_id_fk.rb -db/post_migrate/20220124152824_remove_projects_ci_subscriptions_projects_downstream_project_id_fk.rb -db/post_migrate/20220124153233_remove_projects_ci_job_artifacts_project_id_fk.rb -db/post_migrate/20220124153234_re_remove_projects_ci_job_artifacts_project_id_fk.rb -db/post_migrate/20220124180704_remove_projects_ci_builds_metadata_project_id_fk.rb -db/post_migrate/20220124180705_re_remove_projects_ci_builds_metadata_project_id_fk.rb -db/post_migrate/20220124184338_remove_projects_ci_subscriptions_projects_upstream_project_id_fk.rb -db/post_migrate/20220124204046_remove_projects_ci_sources_pipelines_project_id_fk.rb -db/post_migrate/20220124214131_remove_projects_ci_refs_project_id_fk.rb -db/post_migrate/20220124215857_remove_projects_ci_job_token_project_scope_links_source_project_id_fk.rb -db/post_migrate/20220124221521_remove_projects_ci_project_monthly_usages_project_id_fk.rb -db/post_migrate/20220125083520_remove_ci_pipelines_dast_site_profiles_pipelines_ci_pipeline_id_fk.rb -db/post_migrate/20220125084348_remove_ci_pipelines_vulnerability_feedback_pipeline_id_fk.rb -db/post_migrate/20220125122640_schedule_populate_topics_non_private_projects_count.rb -db/post_migrate/20220126201752_remove_projects_ci_job_token_project_scope_links_target_project_id_fk.rb -db/post_migrate/20220126202654_remove_projects_ci_sources_projects_source_project_id_fk.rb -db/post_migrate/20220126203421_remove_projects_ci_pipeline_schedules_project_id_fk.rb -db/post_migrate/20220126210021_remove_projects_ci_builds_project_id_fk.rb -db/post_migrate/20220126210022_re_remove_projects_ci_builds_project_id_fk.rb -db/post_migrate/20220126210657_remove_projects_ci_pipelines_project_id_fk.rb -db/post_migrate/20220127112243_add_index_to_merge_request_assignees_state.rb -db/post_migrate/20220127112412_add_index_to_merge_request_reviewers_state.rb -db/post_migrate/20220127132200_cleanup_backfill_ci_namespace_mirrors.rb -db/post_migrate/20220127132201_cleanup_backfill_ci_project_mirrors.rb -db/post_migrate/20220128103042_schedule_delete_invalid_epic_issues_revised.rb -db/post_migrate/20220128155251_remove_dangling_running_builds.rb -db/post_migrate/20220128155814_fix_approval_rules_code_owners_rule_type_index.rb -db/post_migrate/20220131000000_index_job_artifacts_on_trace_type_and_expire_at.rb -db/post_migrate/20220131000001_schedule_trace_expiry_removal.rb -db/post_migrate/20220201034731_remove_index_clusters_kubernetes_namespaces_on_cluster_id.rb -db/post_migrate/20220201141705_cleanup_background_migration_populate_test_reports_issue_id.rb -db/post_migrate/20220201173212_add_user_details_provisioning_index.rb -db/post_migrate/20220201193033_add_unique_index_to_vulnerability_finding_links_with_truncate.rb -db/post_migrate/20220202105733_delete_service_template_records.rb -db/post_migrate/20220204053655_remove_index_epic_issues_on_epic_id.rb -db/post_migrate/20220204095121_backfill_namespace_statistics_with_dependency_proxy_size.rb -db/post_migrate/20220204110725_backfill_cycle_analytics_aggregations.rb -db/post_migrate/20220204194347_encrypt_integration_properties.rb -db/post_migrate/20220207080758_update_api_indexes_for_projects.rb -db/post_migrate/20220208080921_schedule_migrate_personal_namespace_project_maintainer_to_owner.rb -db/post_migrate/20220208115439_start_backfill_ci_queuing_tables.rb -db/post_migrate/20220209111007_add_partial_index_for_batching_active_cluster_image_scanning_vulnerabilities.rb -db/post_migrate/20220212120735_schedule_fix_incorrect_max_seats_used2.rb -db/post_migrate/20220213103859_remove_integrations_type.rb -db/post_migrate/20220213104531_create_indexes_on_integration_type_new.rb -db/post_migrate/20220215190020_rerun_convert_stringified_raw_metadata_hash_to_json.rb -db/post_migrate/20220216201949_remove_package_files_limit_from_application_settings.rb -db/post_migrate/20220217135229_validate_not_null_constraint_on_security_findings_uuid.rb -db/post_migrate/20220221214928_remove_show_diff_preview_in_email_column.rb -db/post_migrate/20220222191845_remove_not_null_constraint_for_security_scan_succeeded.rb -db/post_migrate/20220222192524_create_not_null_constraint_releases_tag.rb -db/post_migrate/20220222192525_remove_null_releases.rb -db/post_migrate/20220223112304_schedule_nullify_orphan_runner_id_on_ci_builds.rb -db/post_migrate/20220223124428_schedule_merge_topics_with_same_name.rb -db/post_migrate/20220224000000_async_build_trace_expire_at_index.rb -db/post_migrate/20220224204415_recreate_index_security_ci_builds_on_name_and_id_parser_with_new_features.rb -db/post_migrate/20220225133705_cleanup_backfill_ci_queuing_tables.rb -db/post_migrate/20220301093434_backfill_all_project_namespaces.rb -db/post_migrate/20220302114046_backfill_group_features.rb -db/post_migrate/20220302203410_create_index_security_ci_builds_on_name_and_id_parser_with_new_features.rb -db/post_migrate/20220304165107_drop_partitioned_foreign_keys.rb -db/post_migrate/20220304201847_add_unique_index_on_security_training_providers.rb -db/post_migrate/20220305223212_add_security_training_providers.rb -db/post_migrate/20220307192534_create_index_for_remove_duplicate_project_tag_releases.rb -db/post_migrate/20220307192610_remove_duplicate_project_tag_releases.rb -db/post_migrate/20220307192645_remove_index_for_remove_duplicate_project_tag_releases.rb -db/post_migrate/20220307192725_create_unique_index_release_tag_project.rb -db/post_migrate/20220307203459_rename_user_email_lookup_limit_setting_to_search_settings_cleanup.rb -db/post_migrate/20220308000205_drop_old_index_security_ci_builds_on_name_and_id_parser_features.rb -db/post_migrate/20220308115219_schedule_reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb -db/post_migrate/20220308115502_schedule_reset_duplicate_ci_runners_token_values_on_projects.rb -db/post_migrate/20220309084838_remove_external_pull_request_tracking.rb -db/post_migrate/20220309084954_remove_leftover_external_pull_request_deletions.rb -db/post_migrate/20220309154855_add_index_on_issues_closed_incidents.rb -db/post_migrate/20220310095341_add_async_index_ci_job_artifacts_project_id_created_at.rb -db/post_migrate/20220310134207_add_index_project_id_and_released_at_and_id_on_releases.rb -db/post_migrate/20220310141349_remove_dependency_list_usage_data_from_redis.rb -db/post_migrate/20220311010352_create_scan_id_and_id_index_on_security_findings.rb -db/post_migrate/20220314154235_migrate_vulnerability_approval_rules.rb -db/post_migrate/20220314162342_add_index_ci_job_artifacts_project_id_created_at.rb -ee/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used.rb -ee/lib/ee/gitlab/background_migration/populate_namespace_statistics.rb -ee/lib/ee/gitlab/background_migration/populate_test_reports_issue_id.rb -ee/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings.rb -ee/spec/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used_spec.rb -ee/spec/lib/ee/gitlab/background_migration/populate_namespace_statistics_spec.rb -ee/spec/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings_spec.rb -ee/spec/lib/gitlab/background_migration/populate_test_reports_issue_id_spec.rb -ee/spec/lib/gitlab/background_migration/remove_all_trace_expiration_dates_spec.rb -ee/spec/migrations/async_build_trace_expire_at_index_spec.rb -ee/spec/migrations/schedule_delete_invalid_epic_issues_revised_spec.rb -ee/spec/migrations/schedule_populate_test_reports_issue_id_spec.rb -ee/spec/migrations/schedule_trace_expiry_removal_spec.rb -lib/gitlab/background_migration/backfill_ci_queuing_tables.rb -lib/gitlab/background_migration/backfill_integrations_type_new.rb -lib/gitlab/background_migration/encrypt_static_object_token.rb -lib/gitlab/background_migration/fix_incorrect_max_seats_used.rb -lib/gitlab/background_migration/merge_topics_with_same_name.rb -lib/gitlab/background_migration/populate_namespace_statistics.rb -lib/gitlab/background_migration/populate_test_reports_issue_id.rb -lib/gitlab/background_migration/populate_topics_non_private_projects_count.rb -lib/gitlab/background_migration/populate_vulnerability_reads.rb -lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb -lib/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings.rb -lib/gitlab/background_migration/remove_all_trace_expiration_dates.rb -lib/gitlab/background_migration/update_timelogs_null_spent_at.rb -spec/lib/gitlab/background_migration/backfill_ci_queuing_tables_spec.rb -spec/lib/gitlab/background_migration/backfill_group_features_spec.rb -spec/lib/gitlab/background_migration/backfill_integrations_type_new_spec.rb -spec/lib/gitlab/background_migration/backfill_member_namespace_for_group_members_spec.rb -spec/lib/gitlab/background_migration/backfill_namespace_id_for_namespace_route_spec.rb -spec/lib/gitlab/background_migration/encrypt_integration_properties_spec.rb -spec/lib/gitlab/background_migration/encrypt_static_object_token_spec.rb -spec/lib/gitlab/background_migration/fix_vulnerability_occurrences_with_hashes_as_raw_metadata_spec.rb -spec/lib/gitlab/background_migration/merge_topics_with_same_name_spec.rb -spec/lib/gitlab/background_migration/migrate_personal_namespace_project_maintainer_to_owner_spec.rb -spec/lib/gitlab/background_migration/nullify_orphan_runner_id_on_ci_builds_spec.rb -spec/lib/gitlab/background_migration/populate_namespace_statistics_spec.rb -spec/lib/gitlab/background_migration/populate_topics_non_private_projects_count_spec.rb -spec/lib/gitlab/background_migration/populate_vulnerability_reads_spec.rb -spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb -spec/lib/gitlab/background_migration/remove_all_trace_expiration_dates_spec.rb -spec/lib/gitlab/background_migration/remove_vulnerability_finding_links_spec.rb -spec/lib/gitlab/background_migration/update_timelogs_null_spent_at_spec.rb -spec/migrations/20211203091642_add_index_to_projects_on_marked_for_deletion_at_spec.rb -spec/migrations/20211207125331_remove_jobs_for_recalculate_vulnerabilities_occurrences_uuid_spec.rb -spec/migrations/20211207135331_schedule_recalculate_uuid_on_vulnerabilities_occurrences4_spec.rb -spec/migrations/20211210140629_encrypt_static_object_token_spec.rb -spec/migrations/20211214012507_backfill_incident_issue_escalation_statuses_spec.rb -spec/migrations/20211217174331_mark_recalculate_finding_signatures_as_completed_spec.rb -spec/migrations/20220106111958_add_insert_or_update_vulnerability_reads_trigger_spec.rb -spec/migrations/20220106112043_add_update_vulnerability_reads_trigger_spec.rb -spec/migrations/20220106112085_add_update_vulnerability_reads_location_trigger_spec.rb -spec/migrations/20220106163326_add_has_issues_on_vulnerability_reads_trigger_spec.rb -spec/migrations/20220107064845_populate_vulnerability_reads_spec.rb -spec/migrations/20220120094340_drop_position_from_security_findings_spec.rb -spec/migrations/20220124130028_dedup_runner_projects_spec.rb -spec/migrations/20220128155251_remove_dangling_running_builds_spec.rb -spec/migrations/20220128155814_fix_approval_rules_code_owners_rule_type_index_spec.rb -spec/migrations/20220202105733_delete_service_template_records_spec.rb -spec/migrations/20220204095121_backfill_namespace_statistics_with_dependency_proxy_size_spec.rb -spec/migrations/20220204194347_encrypt_integration_properties_spec.rb -spec/migrations/20220208080921_schedule_migrate_personal_namespace_project_maintainer_to_owner_spec.rb -spec/migrations/20220211214605_update_integrations_trigger_type_new_on_insert_null_safe_spec.rb -spec/migrations/20220213103859_remove_integrations_type_spec.rb -spec/migrations/20220222192524_create_not_null_constraint_releases_tag_spec.rb -spec/migrations/20220222192525_remove_null_releases_spec.rb -spec/migrations/20220223124428_schedule_merge_topics_with_same_name_spec.rb -spec/migrations/20220305223212_add_security_training_providers_spec.rb -spec/migrations/20220307192610_remove_duplicate_project_tag_releases_spec.rb -spec/migrations/20220309084954_remove_leftover_external_pull_request_deletions_spec.rb -spec/migrations/20220310141349_remove_dependency_list_usage_data_from_redis_spec.rb -spec/migrations/backfill_all_project_namespaces_spec.rb -spec/migrations/backfill_cycle_analytics_aggregations_spec.rb -spec/migrations/backfill_group_features_spec.rb -spec/migrations/backfill_member_namespace_id_for_group_members_spec.rb -spec/migrations/backfill_namespace_id_for_namespace_routes_spec.rb -spec/migrations/backfill_project_namespaces_for_group_spec.rb -spec/migrations/populate_audit_event_streaming_verification_token_spec.rb -spec/migrations/recreate_index_security_ci_builds_on_name_and_id_parser_with_new_features_spec.rb -spec/migrations/remove_not_null_contraint_on_title_from_sprints_spec.rb -spec/migrations/schedule_fix_incorrect_max_seats_used2_spec.rb -spec/migrations/schedule_fix_incorrect_max_seats_used_spec.rb -spec/migrations/schedule_update_timelogs_null_spent_at_spec.rb -spec/migrations/start_backfill_ci_queuing_tables_spec.rb -spec/migrations/update_application_settings_container_registry_exp_pol_worker_capacity_default_spec.rb -spec/migrations/update_application_settings_protected_paths_spec.rb -spec/migrations/update_default_scan_method_of_dast_site_profile_spec.rb -spec/migrations/update_invalid_member_states_spec.rb diff --git a/lib/gitlab/background_migration/backfill_integrations_type_new.rb b/lib/gitlab/background_migration/backfill_integrations_type_new.rb deleted file mode 100644 index b07d9371c197d13689c5cb0da10794a2d3d54a74..0000000000000000000000000000000000000000 --- a/lib/gitlab/background_migration/backfill_integrations_type_new.rb +++ /dev/null @@ -1,86 +0,0 @@ -# frozen_string_literal: true - -module Gitlab - module BackgroundMigration - # Backfills the new `integrations.type_new` column, which contains - # the real class name, rather than the legacy class name in `type` - # which is mapped via `Gitlab::Integrations::StiType`. - class BackfillIntegrationsTypeNew - include Gitlab::Database::DynamicModelHelpers - - def perform(start_id, stop_id, batch_table, batch_column, sub_batch_size, pause_ms) - parent_batch_relation = define_batchable_model(batch_table, connection: connection) - .where(batch_column => start_id..stop_id) - - parent_batch_relation.each_batch(column: batch_column, of: sub_batch_size) do |sub_batch| - process_sub_batch(sub_batch) - - sleep(pause_ms * 0.001) if pause_ms > 0 - end - end - - private - - def connection - ApplicationRecord.connection - end - - def process_sub_batch(sub_batch) - # Extract the start/stop IDs from the current sub-batch - sub_start_id, sub_stop_id = sub_batch.pick(Arel.sql('MIN(id), MAX(id)')) - - # This matches the mapping from the INSERT trigger added in - # db/migrate/20210721135638_add_triggers_to_integrations_type_new.rb - connection.execute(<<~SQL) - WITH mapping(old_type, new_type) AS (VALUES - ('AsanaService', 'Integrations::Asana'), - ('AssemblaService', 'Integrations::Assembla'), - ('BambooService', 'Integrations::Bamboo'), - ('BugzillaService', 'Integrations::Bugzilla'), - ('BuildkiteService', 'Integrations::Buildkite'), - ('CampfireService', 'Integrations::Campfire'), - ('ConfluenceService', 'Integrations::Confluence'), - ('CustomIssueTrackerService', 'Integrations::CustomIssueTracker'), - ('DatadogService', 'Integrations::Datadog'), - ('DiscordService', 'Integrations::Discord'), - ('DroneCiService', 'Integrations::DroneCi'), - ('EmailsOnPushService', 'Integrations::EmailsOnPush'), - ('EwmService', 'Integrations::Ewm'), - ('ExternalWikiService', 'Integrations::ExternalWiki'), - ('FlowdockService', 'Integrations::Flowdock'), - ('HangoutsChatService', 'Integrations::HangoutsChat'), - ('IrkerService', 'Integrations::Irker'), - ('JenkinsService', 'Integrations::Jenkins'), - ('JiraService', 'Integrations::Jira'), - ('MattermostService', 'Integrations::Mattermost'), - ('MattermostSlashCommandsService', 'Integrations::MattermostSlashCommands'), - ('MicrosoftTeamsService', 'Integrations::MicrosoftTeams'), - ('MockCiService', 'Integrations::MockCi'), - ('MockMonitoringService', 'Integrations::MockMonitoring'), - ('PackagistService', 'Integrations::Packagist'), - ('PipelinesEmailService', 'Integrations::PipelinesEmail'), - ('PivotaltrackerService', 'Integrations::Pivotaltracker'), - ('PrometheusService', 'Integrations::Prometheus'), - ('PushoverService', 'Integrations::Pushover'), - ('RedmineService', 'Integrations::Redmine'), - ('SlackService', 'Integrations::Slack'), - ('SlackSlashCommandsService', 'Integrations::SlackSlashCommands'), - ('TeamcityService', 'Integrations::Teamcity'), - ('UnifyCircuitService', 'Integrations::UnifyCircuit'), - ('WebexTeamsService', 'Integrations::WebexTeams'), - ('YoutrackService', 'Integrations::Youtrack'), - - -- EE-only integrations - ('GithubService', 'Integrations::Github'), - ('GitlabSlackApplicationService', 'Integrations::GitlabSlackApplication') - ) - - UPDATE integrations SET type_new = mapping.new_type - FROM mapping - WHERE integrations.id BETWEEN #{sub_start_id} AND #{sub_stop_id} - AND integrations.type = mapping.old_type - SQL - end - end - end -end diff --git a/spec/dot_gitlab_ci/rules_spec.rb b/spec/dot_gitlab_ci/rules_spec.rb index 8cc0940ba1c72d1a2976c84e50ec3f91c84913f4..b96147024d05c7e9c53aa015cd0dd0157bc1d317 100644 --- a/spec/dot_gitlab_ci/rules_spec.rb +++ b/spec/dot_gitlab_ci/rules_spec.rb @@ -192,7 +192,6 @@ '.mailmap', '.prettierignore', '.projections.json.example', - '.rubocop_revert_ignores.txt', '.solargraph.yml.example', '.solargraph.yml', '.test_license_encryption_key.pub',