diff --git a/.rubocop_todo/rails/save_bang.yml b/.rubocop_todo/rails/save_bang.yml deleted file mode 100644 index e1698a8368232ada99bd835b3fa9d33b83062a7f..0000000000000000000000000000000000000000 --- a/.rubocop_todo/rails/save_bang.yml +++ /dev/null @@ -1,4 +0,0 @@ ---- -Rails/SaveBang: - Exclude: - - ee/spec/lib/analytics/merge_request_metrics_calculator_spec.rb diff --git a/ee/spec/lib/analytics/merge_request_metrics_calculator_spec.rb b/ee/spec/lib/analytics/merge_request_metrics_calculator_spec.rb index 50d5229d9edc612db567bcdb48a1b1a5e7785e77..53615743a5f12a03d8a65db00e37383df6f47292 100644 --- a/ee/spec/lib/analytics/merge_request_metrics_calculator_spec.rb +++ b/ee/spec/lib/analytics/merge_request_metrics_calculator_spec.rb @@ -60,9 +60,9 @@ describe '#first_reassigned_at' do it 'returns earliest non-author assignee creation timestamp' do - merge_request.merge_request_assignees.create(assignee: merge_request.author, created_at: 5.days.ago) - merge_request.merge_request_assignees.create(assignee: create(:user), created_at: 3.days.ago) - merge_request.merge_request_assignees.create(assignee: create(:user), created_at: 1.day.ago) + merge_request.merge_request_assignees.create!(assignee: merge_request.author, created_at: 5.days.ago) + merge_request.merge_request_assignees.create!(assignee: create(:user), created_at: 3.days.ago) + merge_request.merge_request_assignees.create!(assignee: create(:user), created_at: 1.day.ago) expect(subject.first_reassigned_at).to be_like_time(3.days.ago) end