From 2d5e8328b7b7071b1781091af90d5e4bf6db9bda Mon Sep 17 00:00:00 2001 From: gdk <gdk@example.com> Date: Mon, 3 Mar 2025 23:16:25 +0000 Subject: [PATCH] Finalize protected_environment_deploy_access_levels backfill This migration was finished at `2024-08-20 00:52:02 UTC`, you can confirm the status using our [batched background migration chatops commands](https://docs.gitlab.com/ee/development/database/batched_background_migrations.html#monitor-the-progress-and-status-of-a-batched-background-migration). To confirm it is finished you can run: ``` /chatops run batched_background_migrations status 1000651 ``` The last time this background migration was triggered was in [db/post_migrate/20240815083838_queue_backfill_protected_env_deploy_access_levels_protected_env_project_id.rb](https://gitlab.com/gitlab-org/gitlab/-/blob/master/db/post_migrate/20240815083838_queue_backfill_protected_env_deploy_access_levels_protected_env_project_id.rb) You can read more about the process for finalizing batched background migrations in https://docs.gitlab.com/ee/development/database/batched_background_migrations.html . As part of our process we want to ensure all batched background migrations have had at least one [required stop](https://docs.gitlab.com/ee/development/database/required_stops.html) to process the migration. Therefore we can finalize any batched background migration that was added before the last required stop. This change was generated by [gitlab-housekeeper](https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-housekeeper) using the Keeps::OverdueFinalizeBackgroundMigration keep. To provide feedback on your experience with `gitlab-housekeeper` please create an issue with the label ~"GitLab Housekeeper" and consider pinging the author of this keep. Changelog: other --- ...evels_protected_environment_project_id.yml | 5 +++-- ...ent_deploy_access_levels_protected66570.rb | 22 +++++++++++++++++++ db/schema_migrations/20250303231605 | 1 + 3 files changed, 26 insertions(+), 2 deletions(-) create mode 100644 db/post_migrate/20250303231605_finalize_hk_backfill_protected_environment_deploy_access_levels_protected66570.rb create mode 100644 db/schema_migrations/20250303231605 diff --git a/db/docs/batched_background_migrations/backfill_protected_environment_deploy_access_levels_protected_environment_project_id.yml b/db/docs/batched_background_migrations/backfill_protected_environment_deploy_access_levels_protected_environment_project_id.yml index 420ca95b0eb0d..15378aacb0004 100644 --- a/db/docs/batched_background_migrations/backfill_protected_environment_deploy_access_levels_protected_environment_project_id.yml +++ b/db/docs/batched_background_migrations/backfill_protected_environment_deploy_access_levels_protected_environment_project_id.yml @@ -1,8 +1,9 @@ --- migration_job_name: BackfillProtectedEnvironmentDeployAccessLevelsProtectedEnvironmentProjectId -description: Backfills sharding key `protected_environment_deploy_access_levels.protected_environment_project_id` from `protected_environments`. +description: Backfills sharding key `protected_environment_deploy_access_levels.protected_environment_project_id` + from `protected_environments`. feature_category: continuous_delivery introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/162834 milestone: '17.4' queued_migration_version: 20240815083838 -finalized_by: # version of the migration that finalized this BBM +finalized_by: '20250303231605' diff --git a/db/post_migrate/20250303231605_finalize_hk_backfill_protected_environment_deploy_access_levels_protected66570.rb b/db/post_migrate/20250303231605_finalize_hk_backfill_protected_environment_deploy_access_levels_protected66570.rb new file mode 100644 index 0000000000000..758d7deb3c640 --- /dev/null +++ b/db/post_migrate/20250303231605_finalize_hk_backfill_protected_environment_deploy_access_levels_protected66570.rb @@ -0,0 +1,22 @@ +# frozen_string_literal: true + +class FinalizeHkBackfillProtectedEnvironmentDeployAccessLevelsProtected66570 < Gitlab::Database::Migration[2.2] + milestone '17.10' + + disable_ddl_transaction! + + restrict_gitlab_migration gitlab_schema: :gitlab_main_cell + + def up + ensure_batched_background_migration_is_finished( + job_class_name: 'BackfillProtectedEnvironmentDeployAccessLevelsProtectedEnvironmentProjectId', + table_name: :protected_environment_deploy_access_levels, + column_name: :id, + job_arguments: [:protected_environment_project_id, :protected_environments, :project_id, + :protected_environment_id], + finalize: true + ) + end + + def down; end +end diff --git a/db/schema_migrations/20250303231605 b/db/schema_migrations/20250303231605 new file mode 100644 index 0000000000000..89ab9ebad38e3 --- /dev/null +++ b/db/schema_migrations/20250303231605 @@ -0,0 +1 @@ +9405413ee762e9b5ad018de4c92b5613f19d5e85f81b35a7e69c537d3e8f43ba \ No newline at end of file -- GitLab