diff --git a/ee/app/services/vulnerabilities/create_service.rb b/ee/app/services/vulnerabilities/create_service.rb index fb163b9953354370aded53571df8d8d83bf9e3da..a39b051a6bb0a6a88a0e807a38eebdf25fe19b36 100644 --- a/ee/app/services/vulnerabilities/create_service.rb +++ b/ee/app/services/vulnerabilities/create_service.rb @@ -28,7 +28,7 @@ def execute vulnerability = Vulnerability.new - Vulnerabilities::Finding.transaction(requires_new: true) do # rubocop:disable Performance/ActiveRecordSubtransactions + Vulnerabilities::Finding.transaction do save_vulnerability(vulnerability, finding) rescue ActiveRecord::RecordNotFound vulnerability.errors.add(:base, _('finding is not found or is already attached to a vulnerability')) diff --git a/ee/spec/services/vulnerabilities/create_service_spec.rb b/ee/spec/services/vulnerabilities/create_service_spec.rb index 55dd361b3da21cc07022c7098276c3d958046d88..5c8d31fab0c827beef5f229f41b9778ee5f99faf 100644 --- a/ee/spec/services/vulnerabilities/create_service_spec.rb +++ b/ee/spec/services/vulnerabilities/create_service_spec.rb @@ -137,13 +137,6 @@ end end - it 'starts a new transaction for the create sequence' do - allow(Vulnerabilities::Finding).to receive(:transaction).and_call_original - - subject - expect(Vulnerabilities::Finding).to have_received(:transaction).with(requires_new: true).once - end - context 'when finding id is unknown' do let(:finding_id) { 0 }