From 1fd3c0986fe4c3635b04f0dfe1fc08081d91b3bf Mon Sep 17 00:00:00 2001 From: gdk <gdk@example.com> Date: Thu, 24 Oct 2024 23:22:02 +0000 Subject: [PATCH] Finalize migration BackfillAuditEventsStreamingEventTypeFiltersGroupId This migration was finished at `2024-05-27 09:17:01 UTC`, you can confirm the status using our [batched background migration chatops commands](https://docs.gitlab.com/ee/development/database/batched_background_migrations.html#monitor-the-progress-and-status-of-a-batched-background-migration). To confirm it is finished you can run: ``` /chatops run batched_background_migrations status 1000545 ``` The last time this background migration was triggered was in [db/post_migrate/20240514140027_queue_backfill_audit_events_streaming_event_type_filters_group_id.rb](https://gitlab.com/gitlab-org/gitlab/-/blob/master/db/post_migrate/20240514140027_queue_backfill_audit_events_streaming_event_type_filters_group_id.rb) You can read more about the process for finalizing batched background migrations in https://docs.gitlab.com/ee/development/database/batched_background_migrations.html . As part of our process we want to ensure all batched background migrations have had at least one [required stop](https://docs.gitlab.com/ee/development/database/required_stops.html) to process the migration. Therefore we can finalize any batched background migration that was added before the last required stop. This change was generated by [gitlab-housekeeper](https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-housekeeper) using the Keeps::OverdueFinalizeBackgroundMigration keep. To provide feedback on your experience with `gitlab-housekeeper` please create an issue with the label ~"GitLab Housekeeper" and consider pinging the author of this keep. Changelog: other --- ..._streaming_event_type_filters_group_id.yml | 5 +++-- ...s_streaming_event_type_filters_group_id.rb | 22 +++++++++++++++++++ db/schema_migrations/20241024232152 | 1 + 3 files changed, 26 insertions(+), 2 deletions(-) create mode 100644 db/post_migrate/20241024232152_finalize_backfill_audit_events_streaming_event_type_filters_group_id.rb create mode 100644 db/schema_migrations/20241024232152 diff --git a/db/docs/batched_background_migrations/backfill_audit_events_streaming_event_type_filters_group_id.yml b/db/docs/batched_background_migrations/backfill_audit_events_streaming_event_type_filters_group_id.yml index 021c4886479c0..085c17493b5ad 100644 --- a/db/docs/batched_background_migrations/backfill_audit_events_streaming_event_type_filters_group_id.yml +++ b/db/docs/batched_background_migrations/backfill_audit_events_streaming_event_type_filters_group_id.yml @@ -1,8 +1,9 @@ --- migration_job_name: BackfillAuditEventsStreamingEventTypeFiltersGroupId -description: Backfills sharding key `audit_events_streaming_event_type_filters.group_id` from `audit_events_external_audit_event_destinations`. +description: Backfills sharding key `audit_events_streaming_event_type_filters.group_id` + from `audit_events_external_audit_event_destinations`. feature_category: audit_events introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/152957 milestone: '17.1' queued_migration_version: 20240514140027 -finalized_by: # version of the migration that finalized this BBM +finalized_by: '20241024232152' diff --git a/db/post_migrate/20241024232152_finalize_backfill_audit_events_streaming_event_type_filters_group_id.rb b/db/post_migrate/20241024232152_finalize_backfill_audit_events_streaming_event_type_filters_group_id.rb new file mode 100644 index 0000000000000..0a7ef1e4d9926 --- /dev/null +++ b/db/post_migrate/20241024232152_finalize_backfill_audit_events_streaming_event_type_filters_group_id.rb @@ -0,0 +1,22 @@ +# frozen_string_literal: true + +class FinalizeBackfillAuditEventsStreamingEventTypeFiltersGroupId < Gitlab::Database::Migration[2.2] + milestone '17.6' + + disable_ddl_transaction! + + restrict_gitlab_migration gitlab_schema: :gitlab_main_cell + + def up + ensure_batched_background_migration_is_finished( + job_class_name: 'BackfillAuditEventsStreamingEventTypeFiltersGroupId', + table_name: :audit_events_streaming_event_type_filters, + column_name: :id, + job_arguments: [:group_id, :audit_events_external_audit_event_destinations, :namespace_id, + :external_audit_event_destination_id], + finalize: true + ) + end + + def down; end +end diff --git a/db/schema_migrations/20241024232152 b/db/schema_migrations/20241024232152 new file mode 100644 index 0000000000000..b729de15cf3bb --- /dev/null +++ b/db/schema_migrations/20241024232152 @@ -0,0 +1 @@ +66d71716ae0d9d2c05deb4c9dd8636d9edd6dcd4173ebb06c5f8b7af8c0ca3cd \ No newline at end of file -- GitLab