From 1f865e565a687fe23b31cae17cf7bfb3fb2aa73f Mon Sep 17 00:00:00 2001
From: Rodrigo Tomonari <rtomonari@gitlab.com>
Date: Fri, 7 Feb 2025 13:38:17 -0300
Subject: [PATCH] Add stacktrace to response size logs
---
config/initializers/7_gitlab_http.rb | 5 ++++-
spec/initializers/gitlab_http_spec.rb | 2 +-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/config/initializers/7_gitlab_http.rb b/config/initializers/7_gitlab_http.rb
index 2b2c1b8030493..57d9fd93cbff2 100644
--- a/config/initializers/7_gitlab_http.rb
+++ b/config/initializers/7_gitlab_http.rb
@@ -23,7 +23,10 @@
Gitlab::SilentMode.log_info(message: message, outbound_http_request_method: http_method)
end
config.log_with_level_proc = ->(log_level, message_params) do
- Gitlab::AppJsonLogger.public_send(log_level, Gitlab::ApplicationContext.current.merge(message_params))
+ Gitlab::AppJsonLogger.public_send(
+ log_level,
+ message_params.merge(caller: Gitlab::BacktraceCleaner.clean_backtrace(caller))
+ )
end
end
diff --git a/spec/initializers/gitlab_http_spec.rb b/spec/initializers/gitlab_http_spec.rb
index 5627e064e290b..284077267554b 100644
--- a/spec/initializers/gitlab_http_spec.rb
+++ b/spec/initializers/gitlab_http_spec.rb
@@ -19,7 +19,7 @@ def load_initializer
describe 'log_with_level_proc' do
it 'calls AppJsonLogger with the correct log level and parameters' do
- expect(::Gitlab::AppJsonLogger).to receive(:debug).with({ message: 'Test', "correlation_id" => anything })
+ expect(::Gitlab::AppJsonLogger).to receive(:debug).with({ message: 'Test', caller: anything })
described_class.configuration.log_with_level(:debug, message: 'Test')
end
--
GitLab