From 1cf9325918b101e3cfff6e53e6bb0e4e403c2d4f Mon Sep 17 00:00:00 2001 From: Marcel Amirault <mamirault@gitlab.com> Date: Thu, 4 Jan 2024 12:37:55 +0000 Subject: [PATCH] Update whitespace usage across CI docs Fix indentation of lists and table alignment --- doc/ci/caching/index.md | 2 +- .../cloud_deployment/ecs/deploy_to_aws_ecs.md | 2 +- doc/ci/docker/using_docker_build.md | 2 +- doc/ci/environments/index.md | 2 +- doc/ci/index.md | 2 +- doc/ci/review_apps/index.md | 2 +- doc/ci/runners/index.md | 2 +- doc/ci/runners/new_creation_workflow.md | 4 ++-- doc/ci/runners/runners_scope.md | 7 +++++-- doc/ci/variables/index.md | 2 +- doc/ci/yaml/index.md | 2 +- doc/development/cicd/configuration.md | 8 ++++---- doc/development/cicd/pipeline_wizard.md | 2 +- doc/development/contributing/verify/index.md | 2 +- doc/development/pages/index.md | 20 +++++++++---------- doc/development/pipelines/index.md | 4 ++-- doc/development/pipelines/internals.md | 2 +- 17 files changed, 35 insertions(+), 32 deletions(-) diff --git a/doc/ci/caching/index.md b/doc/ci/caching/index.md index 55f1898749097..737b18fb6c250 100644 --- a/doc/ci/caching/index.md +++ b/doc/ci/caching/index.md @@ -738,5 +738,5 @@ instance. To share the cache between concurrent runners, you can either: - Use the `[runners.docker]` section of the runners' `config.toml` to configure a single mount point on the host that -is mapped to `/cache` in each container, preventing the runner from creating unique volume names. + is mapped to `/cache` in each container, preventing the runner from creating unique volume names. - Use a distributed cache. diff --git a/doc/ci/cloud_deployment/ecs/deploy_to_aws_ecs.md b/doc/ci/cloud_deployment/ecs/deploy_to_aws_ecs.md index b80bbbc5c98b7..82f92cdc938ca 100644 --- a/doc/ci/cloud_deployment/ecs/deploy_to_aws_ecs.md +++ b/doc/ci/cloud_deployment/ecs/deploy_to_aws_ecs.md @@ -276,7 +276,7 @@ include: To use DAST on the default branch: 1. Set up a new [service](#create-an-ecs-service). This service will be used to deploy a temporary -DAST environment. + DAST environment. 1. Use the `CI_AWS_ECS_SERVICE` variable to set the name. 1. Set the scope to the `dast-default` environment. 1. Add the following to your `.gitlab-ci.yml` file: diff --git a/doc/ci/docker/using_docker_build.md b/doc/ci/docker/using_docker_build.md index beaa2291eeac4..bc157c7ae08ba 100644 --- a/doc/ci/docker/using_docker_build.md +++ b/doc/ci/docker/using_docker_build.md @@ -853,7 +853,7 @@ This indicates the GitLab Runner does not have permission to start the 1. Check that `privileged = true` is set in the `config.toml`. 1. Make sure the CI job has the right Runner tags to use these -privileged runners. + privileged runners. ### Error: `cgroups: cgroup mountpoint does not exist: unknown` diff --git a/doc/ci/environments/index.md b/doc/ci/environments/index.md index 03c9a152d98b9..4a6e0118f3b9a 100644 --- a/doc/ci/environments/index.md +++ b/doc/ci/environments/index.md @@ -108,7 +108,7 @@ To create a static environment, in your `.gitlab-ci.yml` file: 1. Define a job in the `deploy` stage. 1. In the job, define the environment `name` and `url`. If an -environment of that name doesn't exist when the pipeline runs, it is created. + environment of that name doesn't exist when the pipeline runs, it is created. NOTE: Some characters cannot be used in environment names. For more information about the diff --git a/doc/ci/index.md b/doc/ci/index.md index beb7fffeb8a05..b74b2e1735ba5 100644 --- a/doc/ci/index.md +++ b/doc/ci/index.md @@ -39,7 +39,7 @@ In the `.gitlab-ci.yml` file, you can define: - [Create your first `.gitlab-ci.yml` file](quick_start/index.md). - [View all the possible keywords that you can use in the `.gitlab-ci.yml` file](yaml/index.md). -the configuration. + the configuration. - Use the [pipeline editor](pipeline_editor/index.md) to edit or [visualize](pipeline_editor/index.md#visualize-ci-configuration) your CI/CD configuration. diff --git a/doc/ci/review_apps/index.md b/doc/ci/review_apps/index.md index 3ff25cc8bab43..5854704521b16 100644 --- a/doc/ci/review_apps/index.md +++ b/doc/ci/review_apps/index.md @@ -108,7 +108,7 @@ The following are example projects that demonstrate review app configuration: Other examples of review apps: - <i class="fa fa-youtube-play youtube" aria-hidden="true"></i> -[Cloud Native Development with GitLab](https://www.youtube.com/watch?v=jfIyQEwrocw). + [Cloud Native Development with GitLab](https://www.youtube.com/watch?v=jfIyQEwrocw). - [Review apps for Android](https://about.gitlab.com/blog/2020/05/06/how-to-create-review-apps-for-android-with-gitlab-fastlane-and-appetize-dot-io/). ## Route Maps diff --git a/doc/ci/runners/index.md b/doc/ci/runners/index.md index 1df93ed8896e6..bfb30a36be2c9 100644 --- a/doc/ci/runners/index.md +++ b/doc/ci/runners/index.md @@ -33,7 +33,7 @@ When you use SaaS runners: - The VM is active only for the duration of the job and immediately deleted. This means that any changes that your job makes to the virtual machine will not be available to a subsequent job. - The virtual machine where your job runs has `sudo` access with no password. - The storage is shared by the operating system, the image with pre-installed software, and a copy of your cloned repository. -This means that the available free disk space for your jobs to use is reduced. + This means that the available free disk space for your jobs to use is reduced. NOTE: Jobs handled by SaaS runners on GitLab.com **time out after 3 hours**, regardless of the timeout configured in a project. diff --git a/doc/ci/runners/new_creation_workflow.md b/doc/ci/runners/new_creation_workflow.md index c870a89a77a22..ef10014504ba5 100644 --- a/doc/ci/runners/new_creation_workflow.md +++ b/doc/ci/runners/new_creation_workflow.md @@ -39,7 +39,7 @@ The new runner registration workflow has the following benefits: - Preserved ownership records for runners, and minimized impact on users. - The addition of a unique system ID ensures that you can reuse the same authentication token across -multiple runners. For more information, see [Reusing a GitLab Runner configuration](https://docs.gitlab.com/runner/fleet_scaling/#reusing-a-gitlab-runner-configuration). + multiple runners. For more information, see [Reusing a GitLab Runner configuration](https://docs.gitlab.com/runner/fleet_scaling/#reusing-a-gitlab-runner-configuration). ## Estimated time frame for planned changes @@ -61,7 +61,7 @@ To avoid a broken workflow, you must: 1. [Create a shared runner](runners_scope.md#create-a-shared-runner-with-a-runner-authentication-token) and obtain the authentication token. 1. Replace the registration token in your runner registration workflow with the -authentication token. + authentication token. ## Using registration tokens after GitLab 17.0 diff --git a/doc/ci/runners/runners_scope.md b/doc/ci/runners/runners_scope.md index 48f6a22e9b36a..d6a556ffd9bde 100644 --- a/doc/ci/runners/runners_scope.md +++ b/doc/ci/runners/runners_scope.md @@ -576,13 +576,16 @@ A runner can have one of the following statuses. As an administrator, you can view runner statistics to learn about the performance of your runner fleet. -- The **Median job queued time** value is calculated by sampling the queue duration of the +The **Median job queued time** value is calculated by sampling the queue duration of the most recent 100 jobs that were run by Instance runners. Jobs from only the latest 5000 runners are considered. -- The median is a value that falls into the 50th percentile: half of the jobs + +The median is a value that falls into the 50th percentile: half of the jobs queued for longer than the median value, and half of the jobs queued for less than the median value. +To view runner statistics: + 1. On the left sidebar, at the bottom, select **Admin Area**. 1. Select **CI/CD > Runners**. 1. Select **View metrics**. diff --git a/doc/ci/variables/index.md b/doc/ci/variables/index.md index f247d9609fed0..86fc813b0ccf8 100644 --- a/doc/ci/variables/index.md +++ b/doc/ci/variables/index.md @@ -967,4 +967,4 @@ As a workaround you can either: - Use [File-type](#use-file-type-cicd-variables) CI/CD variables for large environment variables where possible. - If a single large variable is larger than `ARG_MAX`, try using [Secure Files](../secure_files/index.md), or -bring the file to the job through some other mechanism. + bring the file to the job through some other mechanism. diff --git a/doc/ci/yaml/index.md b/doc/ci/yaml/index.md index 93c38237993b6..2575c78461e6f 100644 --- a/doc/ci/yaml/index.md +++ b/doc/ci/yaml/index.md @@ -1634,7 +1634,7 @@ use the new cache, instead of rebuilding the dependencies. **Additional details**: - The cache `key` is a SHA computed from the most recent commits -that changed each listed file. + that changed each listed file. If neither file is changed in any commits, the fallback key is `default`. ##### `cache:key:prefix` diff --git a/doc/development/cicd/configuration.md b/doc/development/cicd/configuration.md index 903a3d63e8cfd..60f551746518e 100644 --- a/doc/development/cicd/configuration.md +++ b/doc/development/cicd/configuration.md @@ -32,13 +32,13 @@ or [`ee/lib/ee/gitlab/ci/config/entry`](https://gitlab.com/gitlab-org/gitlab/-/t An entry is represented by a class that inherits from; - `Entry::Node`: for simple keywords. -(e.g. [`Entry::Stage`](https://gitlab.com/gitlab-org/gitlab/-/blob/master/lib/gitlab/ci/config/entry/stage.rb)) + (e.g. [`Entry::Stage`](https://gitlab.com/gitlab-org/gitlab/-/blob/master/lib/gitlab/ci/config/entry/stage.rb)) - `Entry::Simplifiable`: for keywords that have multiple structures. -For example, [`Entry::Retry`](https://gitlab.com/gitlab-org/gitlab/-/blob/master/lib/gitlab/ci/config/entry/retry.rb) can be a simple number or a hash configuration. + For example, [`Entry::Retry`](https://gitlab.com/gitlab-org/gitlab/-/blob/master/lib/gitlab/ci/config/entry/retry.rb) can be a simple number or a hash configuration. - `Entry::ComposableArray`: for keywords that have a list of single-type sub-elements. -For example, [`Entry::Includes`](https://gitlab.com/gitlab-org/gitlab/-/blob/master/lib/gitlab/ci/config/entry/includes.rb) has a list of `Entry::Include` elements. + For example, [`Entry::Includes`](https://gitlab.com/gitlab-org/gitlab/-/blob/master/lib/gitlab/ci/config/entry/includes.rb) has a list of `Entry::Include` elements. - `Entry::ComposableHash`: for keywords that have single-type sub-elements with user-defined keys. -For example, [`Entry::Variables`](https://gitlab.com/gitlab-org/gitlab/-/blob/master/lib/gitlab/ci/config/entry/variables.rb) has a list of `Entry::Variable` elements with user-defined keys. + For example, [`Entry::Variables`](https://gitlab.com/gitlab-org/gitlab/-/blob/master/lib/gitlab/ci/config/entry/variables.rb) has a list of `Entry::Variable` elements with user-defined keys. ### Helper Classes diff --git a/doc/development/cicd/pipeline_wizard.md b/doc/development/cicd/pipeline_wizard.md index 0c0c0f3cc45d3..b534fede6e9db 100644 --- a/doc/development/cicd/pipeline_wizard.md +++ b/doc/development/cicd/pipeline_wizard.md @@ -138,7 +138,7 @@ is planned to add the ability to create a MR from here. ### Events - `done` - Emitted after the file has been committed. Use this to redirect the -user to the pipeline, for example. + user to the pipeline, for example. ### Template file location diff --git a/doc/development/contributing/verify/index.md b/doc/development/contributing/verify/index.md index dbc48121dffcd..5f9e2e3acb3d4 100644 --- a/doc/development/contributing/verify/index.md +++ b/doc/development/contributing/verify/index.md @@ -53,7 +53,7 @@ and they serve us and our users well. Some examples of these principles are that If a job fails and we notify a user that it was successful, it can have severe negative consequences. - Feedback needs to be available when a user needs it and data cannot disappear unexpectedly when engineers need it. - It all doesn't matter if the platform is not secure and we -are leaking credentials or secrets. + are leaking credentials or secrets. - When a user provides a set of preconditions in a form of CI/CD configuration, the result should be deterministic each time a pipeline runs, because otherwise the platform might not be trustworthy. - If it is fast, simple to use and has a great UX it will serve our users well. diff --git a/doc/development/pages/index.md b/doc/development/pages/index.md index f4710c951eda8..7bf89789ee040 100644 --- a/doc/development/pages/index.md +++ b/doc/development/pages/index.md @@ -22,14 +22,14 @@ subdomain. You can set the GitLab Pages hostname: As `/etc/hosts` don't support wildcard hostnames, you must configure one entry for GitLab Pages, and then one entry for each page site: - ```plaintext - 127.0.0.1 gdk.test # If you're using GDK - 127.0.0.1 pages.gdk.test # Pages host - # Any namespace/group/user needs to be added - # as a subdomain to the pages host. This is because - # /etc/hosts doesn't accept wildcards - 127.0.0.1 root.pages.gdk.test # for the root pages - ``` +```plaintext +127.0.0.1 gdk.test # If you're using GDK +127.0.0.1 pages.gdk.test # Pages host +# Any namespace/group/user needs to be added +# as a subdomain to the pages host. This is because +# /etc/hosts doesn't accept wildcards +127.0.0.1 root.pages.gdk.test # for the root pages +``` ### With DNS wildcard alternatives @@ -151,8 +151,8 @@ GitLab Pages access control is disabled by default. To enable it: 1. Create an [Instance-wide OAuth application](../../integration/oauth_provider.md#create-an-instance-wide-application) with the `api` scope. 1. Set the value of your `redirect-uri` to the `pages-domain` authorization endpoint -(for example, `http://pages.gdk.test:3010/auth`). -The `redirect-uri` must not contain any GitLab Pages site domain. + (for example, `http://pages.gdk.test:3010/auth`). + The `redirect-uri` must not contain any GitLab Pages site domain. 1. Add the auth client configuration: diff --git a/doc/development/pipelines/index.md b/doc/development/pipelines/index.md index aebb0f9076d28..5ed15213e3e26 100644 --- a/doc/development/pipelines/index.md +++ b/doc/development/pipelines/index.md @@ -716,9 +716,9 @@ We also run tests with a single database in nightly scheduled pipelines, and in Single database tests run in two modes: 1. **Single database with one connection**. Where GitLab connects to all the tables using one connection pool. -This runs through all the jobs that end with `-single-db` + This runs through all the jobs that end with `-single-db` 1. **Single database with two connections**. Where GitLab connects to `gitlab_main`, `gitlab_ci` database tables -using different database connections. This runs through all the jobs that end with `-single-db-ci-connection`. + using different database connections. This runs through all the jobs that end with `-single-db-ci-connection`. If you want to force tests to run with a single database, you can add the `pipeline:run-single-db` label to the merge request. diff --git a/doc/development/pipelines/internals.md b/doc/development/pipelines/internals.md index a81eb6f656b9c..04c1d1f32e89b 100644 --- a/doc/development/pipelines/internals.md +++ b/doc/development/pipelines/internals.md @@ -445,7 +445,7 @@ projects, only one of the following tags should be added to a job: - `gitlab-org`: Jobs randomly use privileged and unprivileged runners. - `gitlab-org-docker`: Jobs must use a privileged runner. If you need [Docker-in-Docker support](../../ci/docker/using_docker_build.md#use-docker-in-docker), -use `gitlab-org-docker` instead of `gitlab-org`. + use `gitlab-org-docker` instead of `gitlab-org`. The `gitlab-org-docker` tag is added by the `.use-docker-in-docker` job definition above. -- GitLab