From 1c3d4885458ce163a7154e45f0d565a6ed0f6aad Mon Sep 17 00:00:00 2001
From: Jonathan Schafer <jschafer@gitlab.com>
Date: Mon, 1 Aug 2022 16:18:39 -0500
Subject: [PATCH] Fix Layout/SpaceInsideBlockBraces in other specs
This fixes all remaining files and removes the todo file
---
.../layout/space_inside_block_braces.yml | 74 -------------------
spec/config/settings_spec.rb | 2 +-
.../application_settings_controller_spec.rb | 2 +-
.../application_controller_spec.rb | 2 +-
.../groups/labels_controller_spec.rb | 4 +-
.../groups/releases_controller_spec.rb | 4 +-
.../import/manifest_controller_spec.rb | 2 +-
.../projects/blame_controller_spec.rb | 2 +-
.../projects/deploy_keys_controller_spec.rb | 4 +-
.../projects/feature_flags_controller_spec.rb | 2 +-
.../projects/jobs_controller_spec.rb | 2 +-
.../projects/labels_controller_spec.rb | 8 +-
.../projects/notes_controller_spec.rb | 2 +-
.../projects/releases_controller_spec.rb | 2 +-
.../projects/tree_controller_spec.rb | 6 +-
.../registrations/welcome_controller_spec.rb | 4 +-
.../snippets/notes_controller_spec.rb | 2 +-
spec/dependencies/omniauth_saml_spec.rb | 2 +-
.../application_experiment_spec.rb | 14 ++--
spec/finders/ci/jobs_finder_spec.rb | 2 +-
spec/finders/ci/runners_finder_spec.rb | 14 ++--
.../concerns/packages/finder_helper_spec.rb | 6 +-
.../container_repositories_finder_spec.rb | 8 +-
.../design_management/versions_finder_spec.rb | 4 +-
spec/finders/milestones_finder_spec.rb | 2 +-
.../packages/group_packages_finder_spec.rb | 4 +-
.../packages/npm/package_finder_spec.rb | 2 +-
spec/finders/projects_finder_spec.rb | 10 +--
.../application_settings_helper_spec.rb | 2 +-
spec/helpers/blob_helper_spec.rb | 2 +-
spec/helpers/gitlab_script_tag_helper_spec.rb | 4 +-
spec/helpers/issuables_helper_spec.rb | 4 +-
spec/helpers/projects/pipeline_helper_spec.rb | 2 +-
.../routing/pseudonymization_helper_spec.rb | 4 +-
spec/helpers/search_helper_spec.rb | 2 +-
spec/helpers/wiki_page_version_helper_spec.rb | 4 +-
spec/initializers/carrierwave_patch_spec.rb | 6 +-
spec/initializers/trusted_proxies_spec.rb | 2 +-
spec/mailers/emails/service_desk_spec.rb | 2 +-
...e_duplicate_project_authorizations_spec.rb | 2 +-
...or_existing_approval_project_rules_spec.rb | 2 +-
.../confirm_support_bot_user_spec.rb | 2 +-
...eset_job_token_scope_enabled_again_spec.rb | 4 +-
.../reset_job_token_scope_enabled_spec.rb | 4 +-
...set_severity_levels_to_new_default_spec.rb | 10 +--
spec/policies/clusters/agent_policy_spec.rb | 2 +-
spec/policies/group_member_policy_spec.rb | 6 +-
spec/policies/issue_policy_spec.rb | 2 +-
spec/policies/project_policy_spec.rb | 10 +--
spec/policies/terraform/state_policy_spec.rb | 2 +-
.../terraform/state_version_policy_spec.rb | 2 +-
.../composer/packages_presenter_spec.rb | 2 +-
.../packages/conan/package_presenter_spec.rb | 2 +-
.../nuget/packages_metadata_presenter_spec.rb | 2 +-
spec/presenters/project_presenter_spec.rb | 2 +-
.../create_table_with_foreign_keys_spec.rb | 2 +-
spec/serializers/cluster_entity_spec.rb | 2 +-
.../import/provider_repo_serializer_spec.rb | 2 +-
spec/tasks/gitlab/snippets_rake_spec.rb | 2 +-
...distribution_release_file_uploader_spec.rb | 4 +-
.../addressable_url_validator_spec.rb | 4 +-
.../instance_configuration.html.haml_spec.rb | 2 +-
.../layouts/_header_search.html.haml_spec.rb | 2 +-
.../_published_experiments.html.haml_spec.rb | 6 +-
.../runners/_runner_details.html.haml_spec.rb | 4 +-
.../export_request_worker_spec.rb | 2 +-
.../cleanup/project_namespace_worker_spec.rb | 2 +-
.../packages/helm/extraction_worker_spec.rb | 2 +-
spec/workers/pages_worker_spec.rb | 2 +-
...urge_dependency_proxy_cache_worker_spec.rb | 4 +-
.../releases/manage_evidence_worker_spec.rb | 2 +-
71 files changed, 126 insertions(+), 200 deletions(-)
delete mode 100644 .rubocop_todo/layout/space_inside_block_braces.yml
diff --git a/.rubocop_todo/layout/space_inside_block_braces.yml b/.rubocop_todo/layout/space_inside_block_braces.yml
deleted file mode 100644
index 25fc6dba4d9d2..0000000000000
--- a/.rubocop_todo/layout/space_inside_block_braces.yml
+++ /dev/null
@@ -1,74 +0,0 @@
----
-# Cop supports --auto-correct.
-Layout/SpaceInsideBlockBraces:
- Exclude:
- - 'spec/config/settings_spec.rb'
- - 'spec/controllers/admin/application_settings_controller_spec.rb'
- - 'spec/controllers/application_controller_spec.rb'
- - 'spec/controllers/groups/labels_controller_spec.rb'
- - 'spec/controllers/groups/releases_controller_spec.rb'
- - 'spec/controllers/import/manifest_controller_spec.rb'
- - 'spec/controllers/projects/blame_controller_spec.rb'
- - 'spec/controllers/projects/deploy_keys_controller_spec.rb'
- - 'spec/controllers/projects/feature_flags_controller_spec.rb'
- - 'spec/controllers/projects/jobs_controller_spec.rb'
- - 'spec/controllers/projects/labels_controller_spec.rb'
- - 'spec/controllers/projects/notes_controller_spec.rb'
- - 'spec/controllers/projects/releases_controller_spec.rb'
- - 'spec/controllers/projects/tree_controller_spec.rb'
- - 'spec/controllers/registrations/welcome_controller_spec.rb'
- - 'spec/controllers/snippets/notes_controller_spec.rb'
- - 'spec/dependencies/omniauth_saml_spec.rb'
- - 'spec/experiments/application_experiment_spec.rb'
- - 'spec/finders/ci/jobs_finder_spec.rb'
- - 'spec/finders/ci/runners_finder_spec.rb'
- - 'spec/finders/concerns/packages/finder_helper_spec.rb'
- - 'spec/finders/container_repositories_finder_spec.rb'
- - 'spec/finders/design_management/versions_finder_spec.rb'
- - 'spec/finders/milestones_finder_spec.rb'
- - 'spec/finders/packages/group_packages_finder_spec.rb'
- - 'spec/finders/packages/npm/package_finder_spec.rb'
- - 'spec/finders/projects_finder_spec.rb'
- - 'spec/helpers/application_settings_helper_spec.rb'
- - 'spec/helpers/blob_helper_spec.rb'
- - 'spec/helpers/gitlab_script_tag_helper_spec.rb'
- - 'spec/helpers/issuables_helper_spec.rb'
- - 'spec/helpers/projects/pipeline_helper_spec.rb'
- - 'spec/helpers/routing/pseudonymization_helper_spec.rb'
- - 'spec/helpers/search_helper_spec.rb'
- - 'spec/helpers/wiki_page_version_helper_spec.rb'
- - 'spec/initializers/carrierwave_patch_spec.rb'
- - 'spec/initializers/trusted_proxies_spec.rb'
- - 'spec/mailers/emails/service_desk_spec.rb'
- - 'spec/migrations/20210812013042_remove_duplicate_project_authorizations_spec.rb'
- - 'spec/migrations/20210910194952_update_report_type_for_existing_approval_project_rules_spec.rb'
- - 'spec/migrations/confirm_support_bot_user_spec.rb'
- - 'spec/migrations/reset_job_token_scope_enabled_again_spec.rb'
- - 'spec/migrations/reset_job_token_scope_enabled_spec.rb'
- - 'spec/migrations/reset_severity_levels_to_new_default_spec.rb'
- - 'spec/policies/clusters/agent_policy_spec.rb'
- - 'spec/policies/group_member_policy_spec.rb'
- - 'spec/policies/issue_policy_spec.rb'
- - 'spec/policies/project_policy_spec.rb'
- - 'spec/policies/terraform/state_policy_spec.rb'
- - 'spec/policies/terraform/state_version_policy_spec.rb'
- - 'spec/presenters/packages/composer/packages_presenter_spec.rb'
- - 'spec/presenters/packages/conan/package_presenter_spec.rb'
- - 'spec/presenters/packages/nuget/packages_metadata_presenter_spec.rb'
- - 'spec/presenters/project_presenter_spec.rb'
- - 'spec/rubocop/cop/migration/create_table_with_foreign_keys_spec.rb'
- - 'spec/serializers/cluster_entity_spec.rb'
- - 'spec/serializers/import/provider_repo_serializer_spec.rb'
- - 'spec/tasks/gitlab/snippets_rake_spec.rb'
- - 'spec/uploaders/packages/debian/distribution_release_file_uploader_spec.rb'
- - 'spec/validators/addressable_url_validator_spec.rb'
- - 'spec/views/help/instance_configuration.html.haml_spec.rb'
- - 'spec/views/layouts/_header_search.html.haml_spec.rb'
- - 'spec/views/layouts/_published_experiments.html.haml_spec.rb'
- - 'spec/views/shared/runners/_runner_details.html.haml_spec.rb'
- - 'spec/workers/bulk_imports/export_request_worker_spec.rb'
- - 'spec/workers/clusters/cleanup/project_namespace_worker_spec.rb'
- - 'spec/workers/packages/helm/extraction_worker_spec.rb'
- - 'spec/workers/pages_worker_spec.rb'
- - 'spec/workers/purge_dependency_proxy_cache_worker_spec.rb'
- - 'spec/workers/releases/manage_evidence_worker_spec.rb'
diff --git a/spec/config/settings_spec.rb b/spec/config/settings_spec.rb
index 1de0e7e6c2612..10eeb3f537188 100644
--- a/spec/config/settings_spec.rb
+++ b/spec/config/settings_spec.rb
@@ -116,7 +116,7 @@
describe '.cron_for_service_ping' do
it 'returns correct crontab for some manually calculated example' do
allow(Gitlab::CurrentSettings)
- .to receive(:uuid) { 'd9e2f4e8-db1f-4e51-b03d-f427e1965c4a'}
+ .to receive(:uuid) { 'd9e2f4e8-db1f-4e51-b03d-f427e1965c4a' }
expect(described_class.send(:cron_for_service_ping)).to eq('44 10 * * 4')
end
diff --git a/spec/controllers/admin/application_settings_controller_spec.rb b/spec/controllers/admin/application_settings_controller_spec.rb
index cb25011fd965f..ab0cad989cb8f 100644
--- a/spec/controllers/admin/application_settings_controller_spec.rb
+++ b/spec/controllers/admin/application_settings_controller_spec.rb
@@ -9,7 +9,7 @@
let(:group) { create(:group) }
let(:project) { create(:project, namespace: group) }
let(:admin) { create(:admin) }
- let(:user) { create(:user)}
+ let(:user) { create(:user) }
before do
stub_env('IN_MEMORY_APPLICATION_SETTINGS', 'false')
diff --git a/spec/controllers/application_controller_spec.rb b/spec/controllers/application_controller_spec.rb
index 1e28ef4ba93b9..f1adb9020fa94 100644
--- a/spec/controllers/application_controller_spec.rb
+++ b/spec/controllers/application_controller_spec.rb
@@ -1006,7 +1006,7 @@ def index
end
describe '.endpoint_id_for_action' do
- controller(described_class) { }
+ controller(described_class) {}
it 'returns an expected endpoint id' do
expect(controller.class.endpoint_id_for_action('hello')).to eq('AnonymousController#hello')
diff --git a/spec/controllers/groups/labels_controller_spec.rb b/spec/controllers/groups/labels_controller_spec.rb
index 90da40cd5f0cd..37db26096d32e 100644
--- a/spec/controllers/groups/labels_controller_spec.rb
+++ b/spec/controllers/groups/labels_controller_spec.rb
@@ -20,7 +20,7 @@
it 'returns group and project labels by default' do
get :index, params: { group_id: group }, format: :json
- label_ids = json_response.map {|label| label['title']}
+ label_ids = json_response.map { |label| label['title'] }
expect(label_ids).to match_array([label_1.title, group_label_1.title])
end
@@ -36,7 +36,7 @@
params = { group_id: subgroup, only_group_labels: true }
get :index, params: params, format: :json
- label_ids = json_response.map {|label| label['title']}
+ label_ids = json_response.map { |label| label['title'] }
expect(label_ids).to match_array([group_label_1.title, subgroup_label_1.title])
end
end
diff --git a/spec/controllers/groups/releases_controller_spec.rb b/spec/controllers/groups/releases_controller_spec.rb
index 9d372114d627c..7dd0bc6206ad4 100644
--- a/spec/controllers/groups/releases_controller_spec.rb
+++ b/spec/controllers/groups/releases_controller_spec.rb
@@ -42,7 +42,7 @@
end
it 'does not return any releases' do
- expect(json_response.map {|r| r['tag'] } ).to be_empty
+ expect(json_response.map { |r| r['tag'] } ).to be_empty
end
it 'returns OK' do
@@ -56,7 +56,7 @@
index
- expect(json_response.map {|r| r['tag'] } ).to match_array(%w(p2 p1 v2 v1))
+ expect(json_response.map { |r| r['tag'] } ).to match_array(%w(p2 p1 v2 v1))
end
end
diff --git a/spec/controllers/import/manifest_controller_spec.rb b/spec/controllers/import/manifest_controller_spec.rb
index 0111ad9501f0a..6f805b44e8947 100644
--- a/spec/controllers/import/manifest_controller_spec.rb
+++ b/spec/controllers/import/manifest_controller_spec.rb
@@ -6,7 +6,7 @@
include ImportSpecHelper
let_it_be(:user) { create(:user) }
- let_it_be(:group) { create(:group)}
+ let_it_be(:group) { create(:group) }
before(:all) do
group.add_maintainer(user)
diff --git a/spec/controllers/projects/blame_controller_spec.rb b/spec/controllers/projects/blame_controller_spec.rb
index bf475f6135a40..62a544bb3fc22 100644
--- a/spec/controllers/projects/blame_controller_spec.rb
+++ b/spec/controllers/projects/blame_controller_spec.rb
@@ -41,7 +41,7 @@
end
context "invalid branch, valid file" do
- let(:id) { 'invalid-branch/files/ruby/missing_file.rb'}
+ let(:id) { 'invalid-branch/files/ruby/missing_file.rb' }
it { is_expected.to respond_with(:not_found) }
end
diff --git a/spec/controllers/projects/deploy_keys_controller_spec.rb b/spec/controllers/projects/deploy_keys_controller_spec.rb
index 821f7fca73d44..308146ce7926d 100644
--- a/spec/controllers/projects/deploy_keys_controller_spec.rb
+++ b/spec/controllers/projects/deploy_keys_controller_spec.rb
@@ -27,8 +27,8 @@
end
context 'when json requested' do
- let(:project2) { create(:project, :internal)}
- let(:project_private) { create(:project, :private)}
+ let(:project2) { create(:project, :internal) }
+ let(:project_private) { create(:project, :private) }
let(:deploy_key_internal) { create(:deploy_key) }
let(:deploy_key_actual) { create(:deploy_key) }
diff --git a/spec/controllers/projects/feature_flags_controller_spec.rb b/spec/controllers/projects/feature_flags_controller_spec.rb
index fd95aa4456859..d7850cc5f33f6 100644
--- a/spec/controllers/projects/feature_flags_controller_spec.rb
+++ b/spec/controllers/projects/feature_flags_controller_spec.rb
@@ -208,7 +208,7 @@
end
context 'when feature flag is not found' do
- let!(:feature_flag) { }
+ let!(:feature_flag) {}
let(:params) do
{
diff --git a/spec/controllers/projects/jobs_controller_spec.rb b/spec/controllers/projects/jobs_controller_spec.rb
index e4e3151dd1226..0793e790301a8 100644
--- a/spec/controllers/projects/jobs_controller_spec.rb
+++ b/spec/controllers/projects/jobs_controller_spec.rb
@@ -700,7 +700,7 @@ def get_show(**extra_params)
expect(response).to match_response_schema('job/build_trace')
expect(json_response['id']).to eq job.id
expect(json_response['status']).to eq job.status
- expect(json_response['lines'].flat_map {|l| l['content'].map { |c| c['text'] } }).to include("ヾ(´༎ຶД༎ຶ`)ﾉ")
+ expect(json_response['lines'].flat_map { |l| l['content'].map { |c| c['text'] } }).to include("ヾ(´༎ຶД༎ຶ`)ﾉ")
end
end
diff --git a/spec/controllers/projects/labels_controller_spec.rb b/spec/controllers/projects/labels_controller_spec.rb
index 776ed9774b195..a5259522fe24f 100644
--- a/spec/controllers/projects/labels_controller_spec.rb
+++ b/spec/controllers/projects/labels_controller_spec.rb
@@ -25,10 +25,10 @@
let_it_be(:group_label_3) { create(:group_label, group: group, title: 'Group Label 3') }
let_it_be(:group_label_4) { create(:group_label, group: group, title: 'Group Label 4') }
- let_it_be(:group_labels) { [group_label_3, group_label_4]}
- let_it_be(:project_labels) { [label_4, label_5]}
- let_it_be(:group_priority_labels) { [group_label_1, group_label_2]}
- let_it_be(:project_priority_labels) { [label_1, label_2, label_3]}
+ let_it_be(:group_labels) { [group_label_3, group_label_4] }
+ let_it_be(:project_labels) { [label_4, label_5] }
+ let_it_be(:group_priority_labels) { [group_label_1, group_label_2] }
+ let_it_be(:project_priority_labels) { [label_1, label_2, label_3] }
before do
create(:label_priority, project: project, label: group_label_1, priority: 3)
diff --git a/spec/controllers/projects/notes_controller_spec.rb b/spec/controllers/projects/notes_controller_spec.rb
index 9050765afd6e7..1f8e96258ca5f 100644
--- a/spec/controllers/projects/notes_controller_spec.rb
+++ b/spec/controllers/projects/notes_controller_spec.rb
@@ -659,7 +659,7 @@ def create!
context 'when target_id and noteable_id do not match' do
let(:locked_issue) { create(:issue, :locked, project: project) }
- let(:issue) {create(:issue, project: project)}
+ let(:issue) { create(:issue, project: project) }
it 'uses target_id and ignores noteable_id' do
request_params = {
diff --git a/spec/controllers/projects/releases_controller_spec.rb b/spec/controllers/projects/releases_controller_spec.rb
index ad6682601f378..b307bb357fa99 100644
--- a/spec/controllers/projects/releases_controller_spec.rb
+++ b/spec/controllers/projects/releases_controller_spec.rb
@@ -312,7 +312,7 @@
end
context 'suffix path abuse' do
- let(:suffix_path) { 'downloads/zips/../../../../../../../robots.txt'}
+ let(:suffix_path) { 'downloads/zips/../../../../../../../robots.txt' }
it 'raises attack error' do
expect do
diff --git a/spec/controllers/projects/tree_controller_spec.rb b/spec/controllers/projects/tree_controller_spec.rb
index 143516e471280..9bc3065b6da4b 100644
--- a/spec/controllers/projects/tree_controller_spec.rb
+++ b/spec/controllers/projects/tree_controller_spec.rb
@@ -163,8 +163,8 @@
end
context 'successful creation' do
- let(:path) { 'files/new_dir'}
- let(:branch_name) { 'master-test'}
+ let(:path) { 'files/new_dir' }
+ let(:branch_name) { 'master-test' }
it 'redirects to the new directory' do
expect(subject)
@@ -175,7 +175,7 @@
context 'unsuccessful creation' do
let(:path) { 'README.md' }
- let(:branch_name) { 'master'}
+ let(:branch_name) { 'master' }
it 'does not allow overwriting of existing files' do
expect(subject)
diff --git a/spec/controllers/registrations/welcome_controller_spec.rb b/spec/controllers/registrations/welcome_controller_spec.rb
index 8a5a8490a23c1..14e88d469baf6 100644
--- a/spec/controllers/registrations/welcome_controller_spec.rb
+++ b/spec/controllers/registrations/welcome_controller_spec.rb
@@ -36,7 +36,7 @@
sign_in(user)
end
- it { is_expected.to redirect_to(dashboard_projects_path)}
+ it { is_expected.to redirect_to(dashboard_projects_path) }
end
context 'when role is set and setup_for_company is not set' do
@@ -78,7 +78,7 @@
sign_in(user)
end
- it { is_expected.to redirect_to(dashboard_projects_path)}
+ it { is_expected.to redirect_to(dashboard_projects_path) }
context 'when the new user already has any accepted group membership' do
let!(:member1) { create(:group_member, user: user) }
diff --git a/spec/controllers/snippets/notes_controller_spec.rb b/spec/controllers/snippets/notes_controller_spec.rb
index 8e85e283b31ec..00d99b46d0bd6 100644
--- a/spec/controllers/snippets/notes_controller_spec.rb
+++ b/spec/controllers/snippets/notes_controller_spec.rb
@@ -312,7 +312,7 @@ def request
describe 'POST toggle_award_emoji' do
let(:note) { create(:note_on_personal_snippet, noteable: public_snippet) }
- let(:emoji_name) { 'thumbsup'}
+ let(:emoji_name) { 'thumbsup' }
before do
sign_in(user)
diff --git a/spec/dependencies/omniauth_saml_spec.rb b/spec/dependencies/omniauth_saml_spec.rb
index 8956fa44b7ab5..470b1512a83a2 100644
--- a/spec/dependencies/omniauth_saml_spec.rb
+++ b/spec/dependencies/omniauth_saml_spec.rb
@@ -17,7 +17,7 @@
allow_next_instance_of(OneLogin::RubySaml::Response) do |instance|
allow(instance).to receive(:is_valid?).and_return(true)
end
- saml_strategy.send(:handle_response, mock_saml_response, {}, settings ) { }
+ saml_strategy.send(:handle_response, mock_saml_response, {}, settings ) {}
end
it 'can extract AuthnContextClassRef from SAMLResponse param' do
diff --git a/spec/experiments/application_experiment_spec.rb b/spec/experiments/application_experiment_spec.rb
index a39890dd53041..20050fae1cb2a 100644
--- a/spec/experiments/application_experiment_spec.rb
+++ b/spec/experiments/application_experiment_spec.rb
@@ -21,7 +21,7 @@
# them optional there.
expect(experiment(:example)).to register_behavior(:control).with(nil)
- expect { experiment(:example) { } }.not_to raise_error
+ expect { experiment(:example) {} }.not_to raise_error
end
describe "#publish" do
@@ -289,11 +289,11 @@
end
it "doesn't raise an exception" do
- expect { experiment(:top) { |e| e.control { experiment(:nested) { } } } }.not_to raise_error
+ expect { experiment(:top) { |e| e.control { experiment(:nested) {} } } }.not_to raise_error
end
it "tracks an event", :snowplow do
- experiment(:top) { |e| e.control { experiment(:nested) { } } }
+ experiment(:top) { |e| e.control { experiment(:nested) {} } }
expect(Gitlab::Tracking).to have_received(:event).with( # rubocop:disable RSpec/ExpectGitlabTracking
'top',
@@ -311,8 +311,8 @@
cache.clear(key: application_experiment.name)
- application_experiment.control { }
- application_experiment.candidate { }
+ application_experiment.control {}
+ application_experiment.candidate {}
end
it "caches the variant determined by the variant resolver" do
@@ -378,7 +378,7 @@
it "doesn't warn on non dev/test environments" do
allow(Gitlab).to receive(:dev_or_test_env?).and_return(false)
- expect { experiment(:example) { |e| e.use { } } }.not_to raise_error
+ expect { experiment(:example) { |e| e.use {} } }.not_to raise_error
expect(ActiveSupport::Deprecation).not_to have_received(:new).with(anything, 'Gitlab::Experiment')
end
@@ -387,7 +387,7 @@
# This will eventually raise an ActiveSupport::Deprecation exception,
# it's ok to change it when that happens.
- expect { experiment(:example) { |e| e.use { } } }.not_to raise_error
+ expect { experiment(:example) { |e| e.use {} } }.not_to raise_error
expect(ActiveSupport::Deprecation).to have_received(:new).with(anything, 'Gitlab::Experiment')
end
diff --git a/spec/finders/ci/jobs_finder_spec.rb b/spec/finders/ci/jobs_finder_spec.rb
index 45e8cf5a58294..dd3ba9721e4e3 100644
--- a/spec/finders/ci/jobs_finder_spec.rb
+++ b/spec/finders/ci/jobs_finder_spec.rb
@@ -56,7 +56,7 @@
context 'scope is an array' do
let(:jobs) { [pending_job, running_job, successful_job, canceled_job] }
- let(:params) {{ scope: %w'running success' }}
+ let(:params) { { scope: %w'running success' } }
it 'filters by the job statuses in the scope' do
expect(subject).to contain_exactly(running_job, successful_job)
diff --git a/spec/finders/ci/runners_finder_spec.rb b/spec/finders/ci/runners_finder_spec.rb
index 96412c1e3714f..8d3c375385ae0 100644
--- a/spec/finders/ci/runners_finder_spec.rb
+++ b/spec/finders/ci/runners_finder_spec.rb
@@ -260,13 +260,13 @@ def execute
let_it_be(:runner_sub_group_2) { create(:ci_runner, :group, contacted_at: 10.minutes.ago) }
let_it_be(:runner_sub_group_3) { create(:ci_runner, :group, contacted_at: 9.minutes.ago) }
let_it_be(:runner_sub_group_4) { create(:ci_runner, :group, contacted_at: 8.minutes.ago) }
- let_it_be(:runner_project_1) { create(:ci_runner, :project, contacted_at: 7.minutes.ago, projects: [project])}
- let_it_be(:runner_project_2) { create(:ci_runner, :project, contacted_at: 6.minutes.ago, projects: [project_2])}
- let_it_be(:runner_project_3) { create(:ci_runner, :project, contacted_at: 5.minutes.ago, description: 'runner_project_search', projects: [project, project_2])}
- let_it_be(:runner_project_4) { create(:ci_runner, :project, contacted_at: 4.minutes.ago, projects: [project_3])}
- let_it_be(:runner_project_5) { create(:ci_runner, :project, contacted_at: 3.minutes.ago, tag_list: %w[runner_tag], projects: [project_4])}
- let_it_be(:runner_project_6) { create(:ci_runner, :project, contacted_at: 2.minutes.ago, projects: [project_5])}
- let_it_be(:runner_project_7) { create(:ci_runner, :project, contacted_at: 1.minute.ago, projects: [project_6])}
+ let_it_be(:runner_project_1) { create(:ci_runner, :project, contacted_at: 7.minutes.ago, projects: [project]) }
+ let_it_be(:runner_project_2) { create(:ci_runner, :project, contacted_at: 6.minutes.ago, projects: [project_2]) }
+ let_it_be(:runner_project_3) { create(:ci_runner, :project, contacted_at: 5.minutes.ago, description: 'runner_project_search', projects: [project, project_2]) }
+ let_it_be(:runner_project_4) { create(:ci_runner, :project, contacted_at: 4.minutes.ago, projects: [project_3]) }
+ let_it_be(:runner_project_5) { create(:ci_runner, :project, contacted_at: 3.minutes.ago, tag_list: %w[runner_tag], projects: [project_4]) }
+ let_it_be(:runner_project_6) { create(:ci_runner, :project, contacted_at: 2.minutes.ago, projects: [project_5]) }
+ let_it_be(:runner_project_7) { create(:ci_runner, :project, contacted_at: 1.minute.ago, projects: [project_6]) }
let(:target_group) { nil }
let(:membership) { nil }
diff --git a/spec/finders/concerns/packages/finder_helper_spec.rb b/spec/finders/concerns/packages/finder_helper_spec.rb
index e8648d131ff4c..94bcec6163e3a 100644
--- a/spec/finders/concerns/packages/finder_helper_spec.rb
+++ b/spec/finders/concerns/packages/finder_helper_spec.rb
@@ -24,7 +24,7 @@ def execute(project1)
subject { finder.execute(project1) }
- it { is_expected.to eq [package1]}
+ it { is_expected.to eq [package1] }
end
describe '#packages_visible_to_user' do
@@ -61,7 +61,7 @@ def execute(group)
end
shared_examples 'returning package1' do
- it { is_expected.to eq [package1]}
+ it { is_expected.to eq [package1] }
end
shared_examples 'returning no packages' do
@@ -165,7 +165,7 @@ def execute(group)
end
shared_examples 'returning project1' do
- it { is_expected.to eq [project1]}
+ it { is_expected.to eq [project1] }
end
shared_examples 'returning no project' do
diff --git a/spec/finders/container_repositories_finder_spec.rb b/spec/finders/container_repositories_finder_spec.rb
index 5d449d1b811db..472c39d1f23f5 100644
--- a/spec/finders/container_repositories_finder_spec.rb
+++ b/spec/finders/container_repositories_finder_spec.rb
@@ -28,9 +28,9 @@
context "with name set to #{name}" do
let(:params) { { name: name } }
- it { is_expected.to contain_exactly(project_repository)}
+ it { is_expected.to contain_exactly(project_repository) }
- it { is_expected.not_to include(not_searched_repository)}
+ it { is_expected.not_to include(not_searched_repository) }
end
end
end
@@ -50,7 +50,7 @@
context "with sort set to #{order}" do
let(:params) { { sort: order } }
- it { is_expected.to eq([sort_repository2, sort_repository])}
+ it { is_expected.to eq([sort_repository2, sort_repository]) }
end
end
@@ -58,7 +58,7 @@
context "with sort set to #{order}" do
let(:params) { { sort: order } }
- it { is_expected.to eq([sort_repository, sort_repository2])}
+ it { is_expected.to eq([sort_repository, sort_repository2]) }
end
end
end
diff --git a/spec/finders/design_management/versions_finder_spec.rb b/spec/finders/design_management/versions_finder_spec.rb
index 0d606ef46f142..7dafdcfda97a2 100644
--- a/spec/finders/design_management/versions_finder_spec.rb
+++ b/spec/finders/design_management/versions_finder_spec.rb
@@ -71,13 +71,13 @@
describe 'returning versions earlier or equal to a version' do
context 'when argument is the first version' do
- let(:params) { { earlier_or_equal_to: version_1 }}
+ let(:params) { { earlier_or_equal_to: version_1 } }
it { is_expected.to eq([version_1]) }
end
context 'when argument is the second version' do
- let(:params) { { earlier_or_equal_to: version_2 }}
+ let(:params) { { earlier_or_equal_to: version_2 } }
it { is_expected.to contain_exactly(version_1, version_2) }
end
diff --git a/spec/finders/milestones_finder_spec.rb b/spec/finders/milestones_finder_spec.rb
index 8b26599cbfa89..8dd83df3a2809 100644
--- a/spec/finders/milestones_finder_spec.rb
+++ b/spec/finders/milestones_finder_spec.rb
@@ -28,7 +28,7 @@
end
context 'milestones for groups and project' do
- let(:extra_params) {{}}
+ let(:extra_params) { {} }
let(:result) do
described_class.new({ project_ids: [project_1.id, project_2.id], group_ids: group.id, state: 'all' }.merge(extra_params)).execute
end
diff --git a/spec/finders/packages/group_packages_finder_spec.rb b/spec/finders/packages/group_packages_finder_spec.rb
index 90a8cd3c57ff9..f78a356b13db7 100644
--- a/spec/finders/packages/group_packages_finder_spec.rb
+++ b/spec/finders/packages/group_packages_finder_spec.rb
@@ -217,7 +217,7 @@ def self.package_types
context 'group is nil' do
subject { described_class.new(user, nil).execute }
- it { is_expected.to be_empty}
+ it { is_expected.to be_empty }
end
context 'package type is nil' do
@@ -225,7 +225,7 @@ def self.package_types
subject { described_class.new(user, group, package_type: nil).execute }
- it { is_expected.to match_array([package1])}
+ it { is_expected.to match_array([package1]) }
end
context 'with invalid package_type' do
diff --git a/spec/finders/packages/npm/package_finder_spec.rb b/spec/finders/packages/npm/package_finder_spec.rb
index 7fabb3eed86bb..8c9149a5a2dcf 100644
--- a/spec/finders/packages/npm/package_finder_spec.rb
+++ b/spec/finders/packages/npm/package_finder_spec.rb
@@ -2,7 +2,7 @@
require 'spec_helper'
RSpec.describe ::Packages::Npm::PackageFinder do
- let_it_be_with_reload(:project) { create(:project)}
+ let_it_be_with_reload(:project) { create(:project) }
let_it_be_with_refind(:package) { create(:npm_package, project: project) }
let(:project) { package.project }
diff --git a/spec/finders/projects_finder_spec.rb b/spec/finders/projects_finder_spec.rb
index 3bef4d85b3302..1fa2a975ec356 100644
--- a/spec/finders/projects_finder_spec.rb
+++ b/spec/finders/projects_finder_spec.rb
@@ -62,7 +62,7 @@
describe 'with id_after' do
context 'only returns projects with a project id greater than given' do
- let(:params) { { id_after: internal_project.id }}
+ let(:params) { { id_after: internal_project.id } }
it { is_expected.to eq([public_project]) }
end
@@ -70,7 +70,7 @@
describe 'with id_before' do
context 'only returns projects with a project id less than given' do
- let(:params) { { id_before: public_project.id }}
+ let(:params) { { id_before: public_project.id } }
it { is_expected.to eq([internal_project]) }
end
@@ -79,7 +79,7 @@
describe 'with both id_before and id_after' do
context 'only returns projects with a project id less than given' do
let!(:projects) { create_list(:project, 5, :public) }
- let(:params) { { id_after: projects.first.id, id_before: projects.last.id }}
+ let(:params) { { id_after: projects.first.id, id_before: projects.last.id } }
it { is_expected.to contain_exactly(*projects[1..-2]) }
end
@@ -89,7 +89,7 @@
context 'only returns projects with a project id less than given and matching search' do
subject { finder.execute.joins(:route) }
- let(:params) { { id_before: public_project.id }}
+ let(:params) { { id_before: public_project.id } }
it { is_expected.to eq([internal_project]) }
end
@@ -97,7 +97,7 @@
context 'only returns projects with a project id greater than given and matching search' do
subject { finder.execute.joins(:route) }
- let(:params) { { id_after: internal_project.id }}
+ let(:params) { { id_after: internal_project.id } }
it { is_expected.to eq([public_project]) }
end
diff --git a/spec/helpers/application_settings_helper_spec.rb b/spec/helpers/application_settings_helper_spec.rb
index ba6caf7cf173d..fab1fed797c15 100644
--- a/spec/helpers/application_settings_helper_spec.rb
+++ b/spec/helpers/application_settings_helper_spec.rb
@@ -313,7 +313,7 @@
allow(helper).to receive(:can?).with(user, :read_cluster, instance_of(Clusters::Instance)).and_return(true)
end
- it { is_expected.to be_truthy}
+ it { is_expected.to be_truthy }
context ':certificate_based_clusters feature flag is disabled' do
before do
diff --git a/spec/helpers/blob_helper_spec.rb b/spec/helpers/blob_helper_spec.rb
index 65e46b618828e..fe652e905ccfa 100644
--- a/spec/helpers/blob_helper_spec.rb
+++ b/spec/helpers/blob_helper_spec.rb
@@ -357,7 +357,7 @@
describe '#ide_merge_request_path' do
let_it_be(:project) { create(:project, :repository) }
- let_it_be(:merge_request) { create(:merge_request, source_project: project)}
+ let_it_be(:merge_request) { create(:merge_request, source_project: project) }
it 'returns IDE path for the given MR if MR is not merged' do
expect(helper.ide_merge_request_path(merge_request)).to eq("/-/ide/project/#{project.full_path}/merge_requests/#{merge_request.iid}")
diff --git a/spec/helpers/gitlab_script_tag_helper_spec.rb b/spec/helpers/gitlab_script_tag_helper_spec.rb
index 9d71e25286e16..cfe7b349cec6d 100644
--- a/spec/helpers/gitlab_script_tag_helper_spec.rb
+++ b/spec/helpers/gitlab_script_tag_helper_spec.rb
@@ -27,8 +27,8 @@
end
describe 'inline script tag' do
- let(:tag_with_nonce) {"<script nonce=\"noncevalue\">\n//<![CDATA[\nalert(1)\n//]]>\n</script>"}
- let(:tag_with_nonce_and_type) {"<script type=\"application/javascript\" nonce=\"noncevalue\">\n//<![CDATA[\nalert(1)\n//]]>\n</script>"}
+ let(:tag_with_nonce) { "<script nonce=\"noncevalue\">\n//<![CDATA[\nalert(1)\n//]]>\n</script>" }
+ let(:tag_with_nonce_and_type) { "<script type=\"application/javascript\" nonce=\"noncevalue\">\n//<![CDATA[\nalert(1)\n//]]>\n</script>" }
it 'returns a script tag with a nonce using block syntax' do
expect(helper.javascript_tag { 'alert(1)' }.to_s).to eq tag_with_nonce
diff --git a/spec/helpers/issuables_helper_spec.rb b/spec/helpers/issuables_helper_spec.rb
index 069465c2fecca..18a21b59409bc 100644
--- a/spec/helpers/issuables_helper_spec.rb
+++ b/spec/helpers/issuables_helper_spec.rb
@@ -448,7 +448,7 @@
allow(merge_request).to receive(:can_be_merged_by?).and_return(can_merge)
end
- it { is_expected.to include({ can_merge: can_merge })}
+ it { is_expected.to include({ can_merge: can_merge }) }
end
end
end
@@ -480,7 +480,7 @@
allow(merge_request).to receive(:can_be_merged_by?).and_return(can_merge)
end
- it { is_expected.to include({ can_merge: can_merge })}
+ it { is_expected.to include({ can_merge: can_merge }) }
end
end
end
diff --git a/spec/helpers/projects/pipeline_helper_spec.rb b/spec/helpers/projects/pipeline_helper_spec.rb
index 1231dcef693e0..59fc278543ff4 100644
--- a/spec/helpers/projects/pipeline_helper_spec.rb
+++ b/spec/helpers/projects/pipeline_helper_spec.rb
@@ -8,7 +8,7 @@
let_it_be(:user) { create(:user) }
let_it_be(:project) { create(:project, :repository) }
let_it_be(:raw_pipeline) { create(:ci_pipeline, project: project, ref: 'master', sha: project.commit.id) }
- let_it_be(:pipeline) { Ci::PipelinePresenter.new(raw_pipeline, current_user: user)}
+ let_it_be(:pipeline) { Ci::PipelinePresenter.new(raw_pipeline, current_user: user) }
describe '#js_pipeline_tabs_data' do
before do
diff --git a/spec/helpers/routing/pseudonymization_helper_spec.rb b/spec/helpers/routing/pseudonymization_helper_spec.rb
index dd4cc55ed2bef..eb2cb548f3502 100644
--- a/spec/helpers/routing/pseudonymization_helper_spec.rb
+++ b/spec/helpers/routing/pseudonymization_helper_spec.rb
@@ -70,7 +70,7 @@
end
context 'with controller for groups with subgroups and project' do
- let(:masked_url) { "http://localhost/namespace#{subgroup.id}/project#{subproject.id}"}
+ let(:masked_url) { "http://localhost/namespace#{subgroup.id}/project#{subproject.id}" }
let(:group) { subgroup }
let(:project) { subproject }
let(:request) do
@@ -94,7 +94,7 @@
end
context 'with controller for groups and subgroups' do
- let(:masked_url) { "http://localhost/groups/namespace#{subgroup.id}/-/shared"}
+ let(:masked_url) { "http://localhost/groups/namespace#{subgroup.id}/-/shared" }
let(:group) { subgroup }
let(:request) do
double(:Request,
diff --git a/spec/helpers/search_helper_spec.rb b/spec/helpers/search_helper_spec.rb
index 513e2865ee3ab..ad0705e4fbf1b 100644
--- a/spec/helpers/search_helper_spec.rb
+++ b/spec/helpers/search_helper_spec.rb
@@ -625,7 +625,7 @@ def simple_sanitize(str)
false | false
end
- let(:params) {{ confidential: confidential }}
+ let(:params) { { confidential: confidential } }
with_them do
it 'transforms confidentiality param' do
diff --git a/spec/helpers/wiki_page_version_helper_spec.rb b/spec/helpers/wiki_page_version_helper_spec.rb
index bc500c28c5ac7..a792e5df035c9 100644
--- a/spec/helpers/wiki_page_version_helper_spec.rb
+++ b/spec/helpers/wiki_page_version_helper_spec.rb
@@ -6,8 +6,8 @@
let_it_be(:project) { create(:project, :public, :repository) }
let_it_be(:user) { create(:user, username: 'foo') }
- let(:commit_with_user) { create(:commit, project: project, author: user)}
- let(:commit_without_user) { create(:commit, project: project, author_name: 'Foo', author_email: 'foo@example.com')}
+ let(:commit_with_user) { create(:commit, project: project, author: user) }
+ let(:commit_without_user) { create(:commit, project: project, author_name: 'Foo', author_email: 'foo@example.com') }
let(:wiki_page_version) { Gitlab::Git::WikiPageVersion.new(commit, nil) }
describe '#wiki_page_version_author_url' do
diff --git a/spec/initializers/carrierwave_patch_spec.rb b/spec/initializers/carrierwave_patch_spec.rb
index b0f337935ef51..0910342f10f16 100644
--- a/spec/initializers/carrierwave_patch_spec.rb
+++ b/spec/initializers/carrierwave_patch_spec.rb
@@ -8,7 +8,7 @@
let(:storage) { CarrierWave::Storage::Fog.new(uploader) }
let(:bucket_name) { 'some-bucket' }
let(:connection) { ::Fog::Storage.new(connection_options) }
- let(:bucket) { connection.directories.new(key: bucket_name )}
+ let(:bucket) { connection.directories.new(key: bucket_name ) }
let(:test_filename) { 'test' }
let(:test_data) { File.read(Rails.root.join('spec/support/gitlab_stubs/gitlab_ci.yml')) }
@@ -33,7 +33,7 @@
end
describe '#copy_to' do
- let(:dest_filename) { 'copied.txt'}
+ let(:dest_filename) { 'copied.txt' }
it 'copies the file' do
fog_file = subject.send(:file)
@@ -67,7 +67,7 @@
end
describe '#copy_to' do
- let(:dest_filename) { 'copied.txt'}
+ let(:dest_filename) { 'copied.txt' }
it 'copies the file' do
result = subject.copy_to(dest_filename)
diff --git a/spec/initializers/trusted_proxies_spec.rb b/spec/initializers/trusted_proxies_spec.rb
index 2786f034969a8..63c96ce17d18a 100644
--- a/spec/initializers/trusted_proxies_spec.rb
+++ b/spec/initializers/trusted_proxies_spec.rb
@@ -58,7 +58,7 @@
end
def stub_request(headers = {})
- ActionDispatch::RemoteIp.new(proc { }, false, Rails.application.config.action_dispatch.trusted_proxies).call(headers)
+ ActionDispatch::RemoteIp.new(proc {}, false, Rails.application.config.action_dispatch.trusted_proxies).call(headers)
ActionDispatch::Request.new(headers)
end
diff --git a/spec/mailers/emails/service_desk_spec.rb b/spec/mailers/emails/service_desk_spec.rb
index 28011456a6668..1523d9b986b52 100644
--- a/spec/mailers/emails/service_desk_spec.rb
+++ b/spec/mailers/emails/service_desk_spec.rb
@@ -76,7 +76,7 @@ def mail_new_thread(issue, options)
shared_examples 'read template from repository' do |template_key|
let(:template_content) { 'custom text' }
- let(:issue) { create(:issue, project: project)}
+ let(:issue) { create(:issue, project: project) }
before do
issue.issue_email_participants.create!(email: email)
diff --git a/spec/migrations/20210812013042_remove_duplicate_project_authorizations_spec.rb b/spec/migrations/20210812013042_remove_duplicate_project_authorizations_spec.rb
index f734456b0b676..c88f94c6426d4 100644
--- a/spec/migrations/20210812013042_remove_duplicate_project_authorizations_spec.rb
+++ b/spec/migrations/20210812013042_remove_duplicate_project_authorizations_spec.rb
@@ -48,7 +48,7 @@
project_authorizations.create! project_id: project_1.id, user_id: user_1.id, access_level: Gitlab::Access::REPORTER
end
- it { expect { subject }.to change { ProjectAuthorization.count}.from(3).to(1) }
+ it { expect { subject }.to change { ProjectAuthorization.count }.from(3).to(1) }
it 'retains the highest access level' do
subject
diff --git a/spec/migrations/20210910194952_update_report_type_for_existing_approval_project_rules_spec.rb b/spec/migrations/20210910194952_update_report_type_for_existing_approval_project_rules_spec.rb
index c90eabbe4ebd7..69ee10eb0d1e3 100644
--- a/spec/migrations/20210910194952_update_report_type_for_existing_approval_project_rules_spec.rb
+++ b/spec/migrations/20210910194952_update_report_type_for_existing_approval_project_rules_spec.rb
@@ -39,7 +39,7 @@
end
context 'with the rule name set to another value (e.g., Test Rule)' do
- let(:rule_name) { 'Test Rule'}
+ let(:rule_name) { 'Test Rule' }
it 'does not update report_type' do
expect { migrate! }.not_to change { approval_project_rule.reload.report_type }
diff --git a/spec/migrations/confirm_support_bot_user_spec.rb b/spec/migrations/confirm_support_bot_user_spec.rb
index f6bcab4aa7d92..c60c7fe45f725 100644
--- a/spec/migrations/confirm_support_bot_user_spec.rb
+++ b/spec/migrations/confirm_support_bot_user_spec.rb
@@ -52,7 +52,7 @@
end
it 'does not change the `created_at` attribute' do
- expect { migrate!}.not_to change { support_bot.reload.created_at }.from(nil)
+ expect { migrate! }.not_to change { support_bot.reload.created_at }.from(nil)
end
end
diff --git a/spec/migrations/reset_job_token_scope_enabled_again_spec.rb b/spec/migrations/reset_job_token_scope_enabled_again_spec.rb
index da6817f6f2189..8f9e12852e14b 100644
--- a/spec/migrations/reset_job_token_scope_enabled_again_spec.rb
+++ b/spec/migrations/reset_job_token_scope_enabled_again_spec.rb
@@ -9,8 +9,8 @@
let(:projects) { table(:projects) }
let(:namespaces) { table(:namespaces) }
let(:namespace) { namespaces.create!(name: 'gitlab', path: 'gitlab-org') }
- let(:project_1) { projects.create!(name: 'proj-1', path: 'gitlab-org', namespace_id: namespace.id)}
- let(:project_2) { projects.create!(name: 'proj-2', path: 'gitlab-org', namespace_id: namespace.id)}
+ let(:project_1) { projects.create!(name: 'proj-1', path: 'gitlab-org', namespace_id: namespace.id) }
+ let(:project_2) { projects.create!(name: 'proj-2', path: 'gitlab-org', namespace_id: namespace.id) }
before do
settings.create!(id: 1, project_id: project_1.id, job_token_scope_enabled: true)
diff --git a/spec/migrations/reset_job_token_scope_enabled_spec.rb b/spec/migrations/reset_job_token_scope_enabled_spec.rb
index 40dfe4de34b89..fb7bd78c11ff1 100644
--- a/spec/migrations/reset_job_token_scope_enabled_spec.rb
+++ b/spec/migrations/reset_job_token_scope_enabled_spec.rb
@@ -9,8 +9,8 @@
let(:projects) { table(:projects) }
let(:namespaces) { table(:namespaces) }
let(:namespace) { namespaces.create!(name: 'gitlab', path: 'gitlab-org') }
- let(:project_1) { projects.create!(name: 'proj-1', path: 'gitlab-org', namespace_id: namespace.id)}
- let(:project_2) { projects.create!(name: 'proj-2', path: 'gitlab-org', namespace_id: namespace.id)}
+ let(:project_1) { projects.create!(name: 'proj-1', path: 'gitlab-org', namespace_id: namespace.id) }
+ let(:project_2) { projects.create!(name: 'proj-2', path: 'gitlab-org', namespace_id: namespace.id) }
before do
settings.create!(id: 1, project_id: project_1.id, job_token_scope_enabled: true)
diff --git a/spec/migrations/reset_severity_levels_to_new_default_spec.rb b/spec/migrations/reset_severity_levels_to_new_default_spec.rb
index 18dc001db16f7..c352f1f3cee35 100644
--- a/spec/migrations/reset_severity_levels_to_new_default_spec.rb
+++ b/spec/migrations/reset_severity_levels_to_new_default_spec.rb
@@ -6,10 +6,10 @@
RSpec.describe ResetSeverityLevelsToNewDefault do
let(:approval_project_rules) { table(:approval_project_rules) }
- let(:projects) { table(:projects)}
- let(:namespaces) { table(:namespaces)}
- let(:namespace) { namespaces.create!(name: 'namespace', path: 'namespace')}
- let(:project) { projects.create!(name: 'project', path: 'project', namespace_id: namespace.id)}
+ let(:projects) { table(:projects) }
+ let(:namespaces) { table(:namespaces) }
+ let(:namespace) { namespaces.create!(name: 'namespace', path: 'namespace') }
+ let(:project) { projects.create!(name: 'project', path: 'project', namespace_id: namespace.id) }
let(:approval_project_rule) { approval_project_rules.create!(name: 'rule', project_id: project.id, severity_levels: severity_levels) }
context 'without having all severity levels selected' do
@@ -27,7 +27,7 @@
it 'changes severity_levels to the default value' do
expect(approval_project_rule.severity_levels).to eq(severity_levels)
- expect { migrate! }.to change {approval_project_rule.reload.severity_levels}.from(severity_levels).to(default_levels)
+ expect { migrate! }.to change { approval_project_rule.reload.severity_levels }.from(severity_levels).to(default_levels)
end
end
end
diff --git a/spec/policies/clusters/agent_policy_spec.rb b/spec/policies/clusters/agent_policy_spec.rb
index 307d751b78b14..8f778d318edeb 100644
--- a/spec/policies/clusters/agent_policy_spec.rb
+++ b/spec/policies/clusters/agent_policy_spec.rb
@@ -3,7 +3,7 @@
require 'spec_helper'
RSpec.describe Clusters::AgentPolicy do
- let(:cluster_agent) { create(:cluster_agent, name: 'agent' )}
+ let(:cluster_agent) { create(:cluster_agent, name: 'agent' ) }
let(:user) { create(:admin) }
let(:policy) { described_class.new(user, cluster_agent) }
let(:project) { cluster_agent.project }
diff --git a/spec/policies/group_member_policy_spec.rb b/spec/policies/group_member_policy_spec.rb
index 50774313aaeea..27ce683861c0a 100644
--- a/spec/policies/group_member_policy_spec.rb
+++ b/spec/policies/group_member_policy_spec.rb
@@ -128,7 +128,7 @@ def expect_disallowed(*permissions)
context 'with the group parent' do
let(:current_user) { create :user }
- let(:subgroup) { create(:group, :private, parent: group)}
+ let(:subgroup) { create(:group, :private, parent: group) }
before do
group.add_owner(owner)
@@ -143,7 +143,7 @@ def expect_disallowed(*permissions)
context 'without group parent' do
let(:current_user) { create :user }
- let(:subgroup) { create(:group, :private)}
+ let(:subgroup) { create(:group, :private) }
before do
subgroup.add_owner(current_user)
@@ -158,7 +158,7 @@ def expect_disallowed(*permissions)
context 'without group parent with two owners' do
let(:current_user) { create :user }
let(:other_user) { create :user }
- let(:subgroup) { create(:group, :private)}
+ let(:subgroup) { create(:group, :private) }
before do
subgroup.add_owner(current_user)
diff --git a/spec/policies/issue_policy_spec.rb b/spec/policies/issue_policy_spec.rb
index 7ca4baddb793f..4d492deb54c6b 100644
--- a/spec/policies/issue_policy_spec.rb
+++ b/spec/policies/issue_policy_spec.rb
@@ -398,7 +398,7 @@ def permissions(user, issue)
context 'with a hidden issue' do
let(:user) { create(:user) }
let(:banned_user) { create(:user, :banned) }
- let(:admin) { create(:user, :admin)}
+ let(:admin) { create(:user, :admin) }
let(:hidden_issue) { create(:issue, project: project, author: banned_user) }
it 'does not allow non-admin user to read the issue' do
diff --git a/spec/policies/project_policy_spec.rb b/spec/policies/project_policy_spec.rb
index e8fdf9a8e256c..9bf96475fc1fa 100644
--- a/spec/policies/project_policy_spec.rb
+++ b/spec/policies/project_policy_spec.rb
@@ -777,13 +777,13 @@ def set_access_level(access_level)
project.add_developer(user)
end
- it { is_expected.not_to be_allowed(:project_bot_access)}
+ it { is_expected.not_to be_allowed(:project_bot_access) }
end
context "when project bot and not part of the project" do
let(:current_user) { project_bot }
- it { is_expected.not_to be_allowed(:project_bot_access)}
+ it { is_expected.not_to be_allowed(:project_bot_access) }
end
context "when project bot and part of the project" do
@@ -793,7 +793,7 @@ def set_access_level(access_level)
project.add_developer(project_bot)
end
- it { is_expected.to be_allowed(:project_bot_access)}
+ it { is_expected.to be_allowed(:project_bot_access) }
end
end
@@ -804,7 +804,7 @@ def set_access_level(access_level)
project.add_maintainer(project_bot)
end
- it { is_expected.not_to be_allowed(:create_resource_access_tokens)}
+ it { is_expected.not_to be_allowed(:create_resource_access_tokens) }
end
end
@@ -946,7 +946,7 @@ def set_access_level(access_level)
context 'with anonymous' do
let(:current_user) { anonymous }
- it { is_expected.to be_disallowed(:metrics_dashboard)}
+ it { is_expected.to be_disallowed(:metrics_dashboard) }
end
end
diff --git a/spec/policies/terraform/state_policy_spec.rb b/spec/policies/terraform/state_policy_spec.rb
index 8215292099701..d75e20a2c6678 100644
--- a/spec/policies/terraform/state_policy_spec.rb
+++ b/spec/policies/terraform/state_policy_spec.rb
@@ -4,7 +4,7 @@
RSpec.describe Terraform::StatePolicy do
let_it_be(:project) { create(:project) }
- let_it_be(:terraform_state) { create(:terraform_state, project: project)}
+ let_it_be(:terraform_state) { create(:terraform_state, project: project) }
subject { described_class.new(user, terraform_state) }
diff --git a/spec/policies/terraform/state_version_policy_spec.rb b/spec/policies/terraform/state_version_policy_spec.rb
index 6614e07333272..4d41dd4445508 100644
--- a/spec/policies/terraform/state_version_policy_spec.rb
+++ b/spec/policies/terraform/state_version_policy_spec.rb
@@ -4,7 +4,7 @@
RSpec.describe Terraform::StateVersionPolicy do
let_it_be(:project) { create(:project) }
- let_it_be(:terraform_state) { create(:terraform_state, :with_version, project: project)}
+ let_it_be(:terraform_state) { create(:terraform_state, :with_version, project: project) }
subject { described_class.new(user, terraform_state.latest_version) }
diff --git a/spec/presenters/packages/composer/packages_presenter_spec.rb b/spec/presenters/packages/composer/packages_presenter_spec.rb
index 1f638e5b935d1..ae88acea61dbe 100644
--- a/spec/presenters/packages/composer/packages_presenter_spec.rb
+++ b/spec/presenters/packages/composer/packages_presenter_spec.rb
@@ -50,7 +50,7 @@ def expected_json(package)
end
describe '#provider' do
- subject { presenter.provider}
+ subject { presenter.provider }
let(:expected_json) do
{
diff --git a/spec/presenters/packages/conan/package_presenter_spec.rb b/spec/presenters/packages/conan/package_presenter_spec.rb
index d35137cd820bc..9b74d2e637eac 100644
--- a/spec/presenters/packages/conan/package_presenter_spec.rb
+++ b/spec/presenters/packages/conan/package_presenter_spec.rb
@@ -7,7 +7,7 @@
let_it_be(:package) { create(:conan_package) }
let_it_be(:project) { package.project }
let_it_be(:package_file_pending_destruction) { create(:package_file, :pending_destruction, package: package) }
- let_it_be(:conan_package_reference) { '123456789'}
+ let_it_be(:conan_package_reference) { '123456789' }
let(:params) { { package_scope: :instance } }
let(:presenter) { described_class.new(package, user, project, params) }
diff --git a/spec/presenters/packages/nuget/packages_metadata_presenter_spec.rb b/spec/presenters/packages/nuget/packages_metadata_presenter_spec.rb
index b2bcdf8f03d9e..39682a3311c56 100644
--- a/spec/presenters/packages/nuget/packages_metadata_presenter_spec.rb
+++ b/spec/presenters/packages/nuget/packages_metadata_presenter_spec.rb
@@ -12,7 +12,7 @@
describe '#count' do
subject { presenter.count }
- it {is_expected.to eq 1}
+ it { is_expected.to eq 1 }
end
describe '#items' do
diff --git a/spec/presenters/project_presenter_spec.rb b/spec/presenters/project_presenter_spec.rb
index df3e4b985ab8a..5eeaea8de06ad 100644
--- a/spec/presenters/project_presenter_spec.rb
+++ b/spec/presenters/project_presenter_spec.rb
@@ -613,7 +613,7 @@
end
context 'empty repo' do
- let(:project) { create(:project, :stubbed_repository)}
+ let(:project) { create(:project, :stubbed_repository) }
context 'for a guest user' do
it 'orders the items correctly' do
diff --git a/spec/rubocop/cop/migration/create_table_with_foreign_keys_spec.rb b/spec/rubocop/cop/migration/create_table_with_foreign_keys_spec.rb
index 39bb4fc208f6b..072edb5827b05 100644
--- a/spec/rubocop/cop/migration/create_table_with_foreign_keys_spec.rb
+++ b/spec/rubocop/cop/migration/create_table_with_foreign_keys_spec.rb
@@ -192,7 +192,7 @@ def up
include_context 'when there is a target to a high traffic table', :foreign_key do
let(:explicit_target_opts) { ", to_table: :#{table_name}" }
- let(:implicit_target_opts) { }
+ let(:implicit_target_opts) {}
end
end
end
diff --git a/spec/serializers/cluster_entity_spec.rb b/spec/serializers/cluster_entity_spec.rb
index 7c4c146575d3e..2de27deeffef1 100644
--- a/spec/serializers/cluster_entity_spec.rb
+++ b/spec/serializers/cluster_entity_spec.rb
@@ -45,7 +45,7 @@
context 'when no application has been installed' do
let(:cluster) { create(:cluster, :instance) }
- subject { described_class.new(cluster, request: request).as_json[:applications]}
+ subject { described_class.new(cluster, request: request).as_json[:applications] }
it 'contains helm as not_installable' do
expect(subject).not_to be_empty
diff --git a/spec/serializers/import/provider_repo_serializer_spec.rb b/spec/serializers/import/provider_repo_serializer_spec.rb
index 430bad151d35d..905685c75e30b 100644
--- a/spec/serializers/import/provider_repo_serializer_spec.rb
+++ b/spec/serializers/import/provider_repo_serializer_spec.rb
@@ -23,7 +23,7 @@
end
it 'raises an error if invalid provider supplied' do
- expect { described_class.new.represent({}, { provider: :invalid })}.to raise_error { NotImplementedError }
+ expect { described_class.new.represent({}, { provider: :invalid }) }.to raise_error { NotImplementedError }
end
end
end
diff --git a/spec/tasks/gitlab/snippets_rake_spec.rb b/spec/tasks/gitlab/snippets_rake_spec.rb
index c55bded1d5a87..c50b04b460056 100644
--- a/spec/tasks/gitlab/snippets_rake_spec.rb
+++ b/spec/tasks/gitlab/snippets_rake_spec.rb
@@ -3,7 +3,7 @@
require 'rake_helper'
RSpec.describe 'gitlab:snippets namespace rake task', :silence_stdout do
- let_it_be(:user) { create(:user)}
+ let_it_be(:user) { create(:user) }
let_it_be(:migrated) { create(:personal_snippet, :repository, author: user) }
let(:non_migrated) { create_list(:personal_snippet, 3, author: user) }
diff --git a/spec/uploaders/packages/debian/distribution_release_file_uploader_spec.rb b/spec/uploaders/packages/debian/distribution_release_file_uploader_spec.rb
index 203a453bcdd5d..dbbf69e3c8d93 100644
--- a/spec/uploaders/packages/debian/distribution_release_file_uploader_spec.rb
+++ b/spec/uploaders/packages/debian/distribution_release_file_uploader_spec.rb
@@ -49,12 +49,12 @@
end
describe '#filename' do
- it { expect(subject.filename).to eq('Release')}
+ it { expect(subject.filename).to eq('Release') }
context 'with signed_file' do
let(:uploader) { described_class.new(distribution, :signed_file) }
- it { expect(subject.filename).to eq('InRelease')}
+ it { expect(subject.filename).to eq('InRelease') }
end
end
end
diff --git a/spec/validators/addressable_url_validator_spec.rb b/spec/validators/addressable_url_validator_spec.rb
index b3a4459db30fb..9109a89988157 100644
--- a/spec/validators/addressable_url_validator_spec.rb
+++ b/spec/validators/addressable_url_validator_spec.rb
@@ -245,7 +245,7 @@
end
context 'when enforce_user is' do
- let(:url) { 'http://$user@example.com'}
+ let(:url) { 'http://$user@example.com' }
let(:validator) { described_class.new(attributes: [:link_url], enforce_user: enforce_user) }
context 'true' do
@@ -274,7 +274,7 @@
end
context 'when ascii_only is' do
- let(:url) { 'https://ð•˜itⅼαƄ.com/foo/foo.bar'}
+ let(:url) { 'https://ð•˜itⅼαƄ.com/foo/foo.bar' }
let(:validator) { described_class.new(attributes: [:link_url], ascii_only: ascii_only) }
context 'true' do
diff --git a/spec/views/help/instance_configuration.html.haml_spec.rb b/spec/views/help/instance_configuration.html.haml_spec.rb
index fbf84a5d272d8..4461eadf1a326 100644
--- a/spec/views/help/instance_configuration.html.haml_spec.rb
+++ b/spec/views/help/instance_configuration.html.haml_spec.rb
@@ -4,7 +4,7 @@
RSpec.describe 'help/instance_configuration' do
describe 'General Sections:' do
- let(:instance_configuration) { build(:instance_configuration)}
+ let(:instance_configuration) { build(:instance_configuration) }
let(:settings) { instance_configuration.settings }
let(:ssh_settings) { settings[:ssh_algorithms_hashes] }
diff --git a/spec/views/layouts/_header_search.html.haml_spec.rb b/spec/views/layouts/_header_search.html.haml_spec.rb
index 3ab4ae6a48349..3a21bb3a92cfd 100644
--- a/spec/views/layouts/_header_search.html.haml_spec.rb
+++ b/spec/views/layouts/_header_search.html.haml_spec.rb
@@ -8,7 +8,7 @@
let(:scope) { nil }
let(:ref) { nil }
let(:code_search) { false }
- let(:for_snippets) { false}
+ let(:for_snippets) { false }
let(:header_search_context) do
{
diff --git a/spec/views/layouts/_published_experiments.html.haml_spec.rb b/spec/views/layouts/_published_experiments.html.haml_spec.rb
index 84894554bd964..072e4f2074ed6 100644
--- a/spec/views/layouts/_published_experiments.html.haml_spec.rb
+++ b/spec/views/layouts/_published_experiments.html.haml_spec.rb
@@ -13,10 +13,10 @@
test_variant: :variant_name
)
- experiment(:test_control) { }
+ experiment(:test_control) {}
experiment(:test_excluded) { |e| e.exclude! }
- experiment(:test_candidate) { |e| e.candidate { } }
- experiment(:test_variant) { |e| e.variant(:variant_name) { } }
+ experiment(:test_candidate) { |e| e.candidate {} }
+ experiment(:test_variant) { |e| e.variant(:variant_name) {} }
experiment(:test_published_only).publish
render
diff --git a/spec/views/shared/runners/_runner_details.html.haml_spec.rb b/spec/views/shared/runners/_runner_details.html.haml_spec.rb
index cdf5ec563d0b4..978750c8435b0 100644
--- a/spec/views/shared/runners/_runner_details.html.haml_spec.rb
+++ b/spec/views/shared/runners/_runner_details.html.haml_spec.rb
@@ -113,14 +113,14 @@
describe 'Tags value' do
context 'when runner does not have tags' do
it { is_expected.to have_content('Tags') }
- it { is_expected.not_to have_selector('span.gl-badge.badge.badge-info')}
+ it { is_expected.not_to have_selector('span.gl-badge.badge.badge-info') }
end
context 'when runner have tags' do
let(:runner) { create(:ci_runner, tag_list: %w(tag2 tag3 tag1)) }
it { is_expected.to have_content('Tags tag1 tag2 tag3') }
- it { is_expected.to have_selector('span.gl-badge.badge.badge-info')}
+ it { is_expected.to have_selector('span.gl-badge.badge.badge-info') }
end
end
diff --git a/spec/workers/bulk_imports/export_request_worker_spec.rb b/spec/workers/bulk_imports/export_request_worker_spec.rb
index 846df63a4d7a4..a7f7aaa7dbaa6 100644
--- a/spec/workers/bulk_imports/export_request_worker_spec.rb
+++ b/spec/workers/bulk_imports/export_request_worker_spec.rb
@@ -60,7 +60,7 @@
context 'when entity is group' do
let(:entity) { create(:bulk_import_entity, :group_entity, source_full_path: 'foo/bar', bulk_import: bulk_import) }
- let(:expected) { '/groups/foo%2Fbar/export_relations'}
+ let(:expected) { '/groups/foo%2Fbar/export_relations' }
include_examples 'requests relations export for api resource'
end
diff --git a/spec/workers/clusters/cleanup/project_namespace_worker_spec.rb b/spec/workers/clusters/cleanup/project_namespace_worker_spec.rb
index b9219586a0b74..c24ca71eb3533 100644
--- a/spec/workers/clusters/cleanup/project_namespace_worker_spec.rb
+++ b/spec/workers/clusters/cleanup/project_namespace_worker_spec.rb
@@ -18,7 +18,7 @@
end
context 'when exceeded the execution limit' do
- subject { worker_instance.perform(cluster.id, worker_instance.send(:execution_limit))}
+ subject { worker_instance.perform(cluster.id, worker_instance.send(:execution_limit)) }
it 'logs the error' do
expect(logger).to receive(:error)
diff --git a/spec/workers/packages/helm/extraction_worker_spec.rb b/spec/workers/packages/helm/extraction_worker_spec.rb
index daebbda307759..70a090d69892b 100644
--- a/spec/workers/packages/helm/extraction_worker_spec.rb
+++ b/spec/workers/packages/helm/extraction_worker_spec.rb
@@ -4,7 +4,7 @@
RSpec.describe Packages::Helm::ExtractionWorker, type: :worker do
describe '#perform' do
- let_it_be(:package) { create(:helm_package, without_package_files: true, status: 'processing')}
+ let_it_be(:package) { create(:helm_package, without_package_files: true, status: 'processing') }
let!(:package_file) { create(:helm_package_file, without_loaded_metadatum: true, package: package) }
let(:package_file_id) { package_file.id }
diff --git a/spec/workers/pages_worker_spec.rb b/spec/workers/pages_worker_spec.rb
index 5ddfd5b43b901..ad714d8d11e5c 100644
--- a/spec/workers/pages_worker_spec.rb
+++ b/spec/workers/pages_worker_spec.rb
@@ -4,7 +4,7 @@
RSpec.describe PagesWorker, :sidekiq_inline do
let(:project) { create(:project) }
- let(:ci_build) { create(:ci_build, project: project)}
+ let(:ci_build) { create(:ci_build, project: project) }
it 'calls UpdatePagesService' do
expect_next_instance_of(Projects::UpdatePagesService, project, ci_build) do |service|
diff --git a/spec/workers/purge_dependency_proxy_cache_worker_spec.rb b/spec/workers/purge_dependency_proxy_cache_worker_spec.rb
index 3de59670f8d5d..84315fd6ee95a 100644
--- a/spec/workers/purge_dependency_proxy_cache_worker_spec.rb
+++ b/spec/workers/purge_dependency_proxy_cache_worker_spec.rb
@@ -4,9 +4,9 @@
RSpec.describe PurgeDependencyProxyCacheWorker do
let_it_be(:user) { create(:admin) }
- let_it_be_with_refind(:blob) { create(:dependency_proxy_blob )}
+ let_it_be_with_refind(:blob) { create(:dependency_proxy_blob ) }
let_it_be_with_reload(:group) { blob.group }
- let_it_be_with_refind(:manifest) { create(:dependency_proxy_manifest, group: group )}
+ let_it_be_with_refind(:manifest) { create(:dependency_proxy_manifest, group: group ) }
let_it_be(:group_id) { group.id }
subject { described_class.new.perform(user.id, group_id) }
diff --git a/spec/workers/releases/manage_evidence_worker_spec.rb b/spec/workers/releases/manage_evidence_worker_spec.rb
index 2fbfb6c9dc188..886fcd346eb43 100644
--- a/spec/workers/releases/manage_evidence_worker_spec.rb
+++ b/spec/workers/releases/manage_evidence_worker_spec.rb
@@ -29,7 +29,7 @@
context 'when evidence has already been created' do
let(:release) { create(:release, project: project, released_at: 1.hour.since) }
- let!(:evidence) { create(:evidence, release: release )}
+ let!(:evidence) { create(:evidence, release: release ) }
it_behaves_like 'does not create a new Evidence record'
end
--
GitLab