From 182d3e84aa66380d8b6efcf0f7964e6ebf672c24 Mon Sep 17 00:00:00 2001
From: Max Orefice <morefice@gitlab.com>
Date: Fri, 23 Sep 2022 12:13:07 +0000
Subject: [PATCH] Prepares ci_builds_metadata to partitioning
This commit prepares ci_builds_metadata table for partitioning.
It makes sure the primary key include the partitioning_id.
Changelog: added
---
app/models/ci/build_metadata.rb | 1 +
...s_metadata_for_partitioning_primary_key.rb | 36 +++++++++++++++++++
db/schema_migrations/20220920081631 | 1 +
db/structure.sql | 2 +-
4 files changed, 39 insertions(+), 1 deletion(-)
create mode 100644 db/post_migrate/20220920081631_prepare_ci_builds_metadata_for_partitioning_primary_key.rb
create mode 100644 db/schema_migrations/20220920081631
diff --git a/app/models/ci/build_metadata.rb b/app/models/ci/build_metadata.rb
index 3bdf2f90acbea..98d829e92539c 100644
--- a/app/models/ci/build_metadata.rb
+++ b/app/models/ci/build_metadata.rb
@@ -11,6 +11,7 @@ class BuildMetadata < Ci::ApplicationRecord
include Gitlab::Utils::StrongMemoize
self.table_name = 'ci_builds_metadata'
+ self.primary_key = 'id'
belongs_to :build, class_name: 'CommitStatus'
belongs_to :project
diff --git a/db/post_migrate/20220920081631_prepare_ci_builds_metadata_for_partitioning_primary_key.rb b/db/post_migrate/20220920081631_prepare_ci_builds_metadata_for_partitioning_primary_key.rb
new file mode 100644
index 0000000000000..907271786242d
--- /dev/null
+++ b/db/post_migrate/20220920081631_prepare_ci_builds_metadata_for_partitioning_primary_key.rb
@@ -0,0 +1,36 @@
+# frozen_string_literal: true
+
+class PrepareCiBuildsMetadataForPartitioningPrimaryKey < Gitlab::Database::Migration[2.0]
+ disable_ddl_transaction!
+
+ TABLE_NAME = 'ci_builds_metadata'
+ PRIMARY_KEY = 'ci_builds_metadata_pkey'
+ NEW_INDEX_NAME = 'index_ci_builds_metadata_on_id_partition_id_unique'
+ OLD_INDEX_NAME = 'index_ci_builds_metadata_on_id_unique'
+
+ def up
+ with_lock_retries(raise_on_exhaustion: true) do
+ execute("ALTER TABLE #{TABLE_NAME} DROP CONSTRAINT #{PRIMARY_KEY} CASCADE")
+
+ rename_index(TABLE_NAME, NEW_INDEX_NAME, PRIMARY_KEY)
+
+ execute("ALTER TABLE #{TABLE_NAME} ADD CONSTRAINT #{PRIMARY_KEY} " \
+ "PRIMARY KEY USING INDEX #{PRIMARY_KEY}")
+ end
+ end
+
+ # rolling back this migration is time consuming with the creation of these two indexes
+ def down
+ add_concurrent_index(TABLE_NAME, :id, unique: true, name: OLD_INDEX_NAME)
+ add_concurrent_index(TABLE_NAME, [:id, :partition_id], unique: true, name: NEW_INDEX_NAME)
+
+ with_lock_retries(raise_on_exhaustion: true) do
+ execute("ALTER TABLE #{TABLE_NAME} DROP CONSTRAINT #{PRIMARY_KEY} CASCADE")
+
+ rename_index(TABLE_NAME, OLD_INDEX_NAME, PRIMARY_KEY)
+
+ execute("ALTER TABLE #{TABLE_NAME} ADD CONSTRAINT #{PRIMARY_KEY} " \
+ "PRIMARY KEY USING INDEX #{PRIMARY_KEY}")
+ end
+ end
+end
diff --git a/db/schema_migrations/20220920081631 b/db/schema_migrations/20220920081631
new file mode 100644
index 0000000000000..071ef93fc7a2a
--- /dev/null
+++ b/db/schema_migrations/20220920081631
@@ -0,0 +1 @@
+081480492cbe6e631f0357b181a883a2bc7f34566f23f119c0ba4df59ee363d6
\ No newline at end of file
diff --git a/db/structure.sql b/db/structure.sql
index 0f6ff043d6e6d..228d364bd6962 100644
--- a/db/structure.sql
+++ b/db/structure.sql
@@ -25045,7 +25045,7 @@ ALTER TABLE ONLY ci_build_trace_metadata
ADD CONSTRAINT ci_build_trace_metadata_pkey PRIMARY KEY (build_id);
ALTER TABLE ONLY ci_builds_metadata
- ADD CONSTRAINT ci_builds_metadata_pkey PRIMARY KEY (id);
+ ADD CONSTRAINT ci_builds_metadata_pkey PRIMARY KEY (id, partition_id);
ALTER TABLE ONLY ci_builds
ADD CONSTRAINT ci_builds_pkey PRIMARY KEY (id);
--
GitLab